Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-26 Thread Nayan Deshmukh
Hi Andy, On Sun, Jun 26, 2016 at 12:25 AM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Andy, >> >> Thanks for testing the patches. >> >> Please send me the videos and ratios with which there is corruption. >> > > > https://drive.goog

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-27 Thread Nayan Deshmukh
you taken into account that the pixel center is at 0.5 and not > 0.0? > > Regards, > Christian. > > > Am 26.06.2016 um 22:30 schrieb Andy Furniss: > >> Nayan Deshmukh wrote: >> >>> Hi Andy, >>> >>> On Sun, Jun 26, 2016 at 12:25

[Mesa-dev] [PATCH 1/2] vl: add a bicubic interpolation filter(v4)

2016-06-28 Thread Nayan Deshmukh
small changes to reduce calculation in shader Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_bicubic_filter.c | 465 +++ src/gallium/auxiliary/vl/vl_bicubic_filter.h | 63 3 files changed, 530

[Mesa-dev] [PATCH 2/2] st/vdpau: use bicubic filter for scaling(v6)

2016-06-28 Thread Nayan Deshmukh
interpolation v4: support high quality scaling v5: set dst_area and dst_clip in bicubic filter v6: set buffer layer before setting dst_area Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/mixer.c | 112 --- src/gallium/state_trackers/vdpau/query.c | 1

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-28 Thread Nayan Deshmukh
; 0.5 instead of 0.0. > > For the matrix and most other filters the difference doesn't matter > because you get the same offset on x/y as input you need to apply in the > texture instructions as well. > > Regards, > Christian. > > > Am 27.06.2016 um 15:51 schrieb

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-28 Thread Nayan Deshmukh
Hi Andy, Thanks for testing the patches. On Tue, Jun 28, 2016 at 11:26 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Christian and Andy, >> >> I have sent new series of patches which takes care of the points Christian >> pointed out. >> >>

Re: [Mesa-dev] Fwd: [PATCH] st/vdpau: use bicubic filter for scaling

2016-06-28 Thread Nayan Deshmukh
. On Tue, Jun 28, 2016 at 11:51 PM, Christian König wrote: > Am 28.06.2016 um 20:11 schrieb Nayan Deshmukh: > > Hi Andy, > > Thanks for testing the patches. > > On Tue, Jun 28, 2016 at 11:26 PM, Andy Furniss > wrote: > >> Nayan Deshmukh wrote: >> >&g

[Mesa-dev] [PATCH 0/3] error handling

2017-01-03 Thread Nayan Deshmukh
Hi Christian, Can you please push the patches for me. Regards, Nayan Nayan Deshmukh (3): vl/compositor: implement error handling st/vdpau: error handling st/va: error handling src/gallium/auxiliary/vl/vl_compositor.c | 13 -- src/gallium/auxiliary/vl/vl_compositor.h | 2

[Mesa-dev] [PATCH 3/3] st/va: error handling

2017-01-03 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- src/gallium/state_trackers/va/context.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH 1/3] vl/compositor: implement error handling

2017-01-03 Thread Nayan Deshmukh
pipe_buffer_map and pipe_buffer_create may return NULL Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_compositor.c | 13 +++-- src/gallium/auxiliary/vl/vl_compositor.h | 2 +- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a

[Mesa-dev] [PATCH 2/3] st/vdpau: error handling

2017-01-03 Thread Nayan Deshmukh
handle the cases when vl_compositor_set_csc_matrix(), vl_compositor_init_state() and vl_compositor_init() fail Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- src/gallium/state_trackers/vdpau/device.c | 8 +- src/gallium/state_trackers/vdpau/mixer.c | 43

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack(v1.1)

2017-01-04 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c| 50 - src/gallium/state_tra

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to direclty send the buffer to X(v1.1)

2017-01-04 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize Suggested-by: Christian König Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/presentation.c | 58 ++--- 1 file changed, 32 insertions(+), 26

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-04 Thread Nayan Deshmukh
esent extension for every frame Suggested-by: Leo Liu Signed-off-by: Nayan Deshmukh --- configure.ac | 2 +- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_dri3.c | 126 ++ 3 files changed

[Mesa-dev] [PATCH] st/va: fix incorrect argument in vl_compositor_cleanup

2017-01-05 Thread Nayan Deshmukh
This fixes the mistake introduced in commit b6737a8bcd03ea68952799144c0c6e6e6679bee9 Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/context.c b/src/gallium

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Nayan Deshmukh
On Fri, Jan 6, 2017 at 2:20 AM, Andy Furniss wrote: > Christian König wrote: >> >> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >>> >>> dri3 allows us to send handle of a texture directly to X >>> so this patch allows a state tracker to directly se

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-10 Thread Nayan Deshmukh
On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: > On 06/01/17 05:50 AM, Andy Furniss wrote: >> Christian König wrote: >>> Am 04.01.2017 um 18:13 schrieb Nayan Deshmukh: >>>> dri3 allows us to send handle of a texture directly to X >>>> so this pat

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer wrote: > On 10/01/17 06:53 PM, Nayan Deshmukh wrote: >> On Sat, Jan 7, 2017 at 12:42 PM, Michel Dänzer wrote: >>> On 06/01/17 05:50 AM, Andy Furniss wrote: >>>> Christian König wrote: >>>>> Am 04.01.2017

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
= PIPE_USAGE_DEFAULT; pipe_mutex_lock(dev->mutex); Regards, Nayan On Wed, Jan 11, 2017 at 5:11 PM, Andy Furniss wrote: > Michel Dänzer wrote: >> >> On 11/01/17 05:13 PM, Nayan Deshmukh wrote: >>> >>> On Wed, Jan 11, 2017 at 12:44 PM, Michel Dänzer >&

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
On Wed, Jan 11, 2017 at 9:25 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: >> >> Hi Andy, >> >> Can you try this patch? This should help with the tearing. > > > Patch seems to be good - I get page flipping again so DC, modesetting > and "normal"

[Mesa-dev] [PATCH 1/3] vl/dri3: use external texture as back buffers(v4)

2017-01-11 Thread Nayan Deshmukh
esent extension for every frame Reviewed and Suggested-by: Leo Liu Acked-by: Christian König Tested-by: Andy Furniss Signed-off-by: Nayan Deshmukh --- configure.ac | 2 +- src/gallium/auxiliary/vl/vl_winsys.h | 5 ++ src/gallium/auxiliary/vl/vl_winsys_d

[Mesa-dev] [PATCH 3/3] st/vdpau: remove the delayed rendering hack(v1.1)

2017-01-11 Thread Nayan Deshmukh
the hack was introduced to avoid an extra copying but now with dri3 we don't need it anymore v1.1: rebasing Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/bitmap.c| 2 - src/gallium/state_trackers/vdpau/device.c| 50 - src/gallium/state_tra

[Mesa-dev] [PATCH 2/3] st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-11 Thread Nayan Deshmukh
this avoids an extra copy which occurs in case of dri2 v1.1: fallback to dri2 if dri3 fails to initialize v2: add PIPE_BIND_SCANOUT to output buffers as they will be send to X server directly (Michel) Suggested-by: Christian König Tested-by: Andy Furniss Signed-off-by: Nayan Deshmukh

[Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
If begin_frame is called before setting intra_matrix and non_intra_matrix it leads to segmentation faults when vl_mpeg12_decoder.c is used. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/picture.c | 6 +++--- 1 file

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
Hi Andy, Please test this patch for regressions. Cheers, Nayan On Fri, Jan 13, 2017 at 6:45 PM, Nayan Deshmukh wrote: > If begin_frame is called before setting intra_matrix and > non_intra_matrix it leads to segmentation faults when > vl_mpeg12_decoder.c is used. > >

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Andy, >> >> Please test this patch for regressions. >> > > Do you have a testcase to show the fix? > > TBH I've not tested gstreamer with mpeg2 before as vaa

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-13 Thread Nayan Deshmukh
On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss wrote: > > Nayan Deshmukh wrote: >> >> On Fri, Jan 13, 2017 at 8:32 PM, Andy Furniss wrote: >> >>> Nayan Deshmukh wrote: >>> >>>> Hi Andy, >>>> >>>> Please test t

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-16 Thread Nayan Deshmukh
, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> On Fri, Jan 13, 2017 at 9:54 PM, Andy Furniss >> wrote: >> > > Would be interesting to see if you see the same with this vid >>> which easily shows the corruption. >>> >>> https://drive.g

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-17 Thread Nayan Deshmukh
On Tue, Jan 17, 2017 at 6:25 PM, Christian König wrote: > Hi Nayan, > > I've pushed this patch yesterday and this one just a minute ago. > Thanks for the push. I am planning on sending a similar patch for vaapi. Regards, Nayan ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-17 Thread Nayan Deshmukh
On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov wrote: > On 17 January 2017 at 14:55, Nayan Deshmukh wrote: >> On Tue, Jan 17, 2017 at 6:25 PM, Christian König >> wrote: >>> Hi Nayan, >>> >>> I've pushed this patch yesterday and this one just

Re: [Mesa-dev] Mesa (master): st/vdpau: use dri3 to directly send the buffer to X(v2)

2017-01-18 Thread Nayan Deshmukh
gt;>>> Branch: master >>>> Commit: 15bfdea99c7b487d2c38d6dd7b88fb44810ef75a >>>> URL: >>>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=15bfdea99c7b487d2c38d6dd7b88fb44810ef75a >>>> >>>> >>>> Author: Nayan Deshmukh >>>> Da

[Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth matches the window depth, otherwise it returns a BadMatch protocol error. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/output.c| 6 ++ src/gallium/state_trackers/vdpau/presentation.c | 6 +++--- src/gallium

Re: [Mesa-dev] [PATCH] st/vdpau: avoid sending buffers with 10bit channels to X

2017-01-18 Thread Nayan Deshmukh
On Wed, Jan 18, 2017 at 9:21 PM, Michel Dänzer wrote: > On 19/01/17 12:27 AM, Nayan Deshmukh wrote: >> PresentPixmap only works if the pixmap depth matches the window >> depth, otherwise it returns a BadMatch protocol error. >> >> Signed-off-by: Nayan Deshm

[Mesa-dev] [PATCH v2] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-18 Thread Nayan Deshmukh
PresentPixmap only works if the pixmap depth and format matches with the window, otherwise it returns a BadMatch protocol error. For other buffers we copy them to a buffer which is send to X. v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8 Signed-off-by: Nayan Deshmukh --- src

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-19 Thread Nayan Deshmukh
On Thu, Jan 19, 2017 at 2:07 PM, Christian König wrote: > Am 19.01.2017 um 00:20 schrieb Andy Furniss: >> >> Nayan Deshmukh wrote: >>> >>> On Tue, Jan 17, 2017 at 9:12 PM, Emil Velikov >>> wrote: >>>> >>>> On 17 January 2017 at 1

[Mesa-dev] [PATCH v3] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Nayan Deshmukh
buffers we copy them to a buffer which is send to X. v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8 v3: reword commit message Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/output.c| 2 ++ src/gallium/state_trackers/vdpau/presentation.c | 6 +++--- s

[Mesa-dev] [PATCH v4] st/vdpau: only send buffers with B8G8R8A8 format to X

2017-01-19 Thread Nayan Deshmukh
buffers we copy them to a buffer which is send to X. v2: only send buffers with format VDP_RGBA_FORMAT_B8G8R8A8 v3: reword commit message v4: add comment explaining the code Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/output.c| 7 +++ src/gallium/state_trac

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-21 Thread Nayan Deshmukh
Hi Christian, The new patch leads to seg fault on my system. You forgot to set the needs_begin_frame to true when the decoder is created. Here's diff for reference: diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index

Re: [Mesa-dev] [PATCH] st/va: delay calling begin_frame until we have all parameters

2017-01-23 Thread Nayan Deshmukh
The patch is Reviewed-by: Nayan Deshmukh On Mon, Jan 23, 2017 at 7:01 PM, Christian König wrote: > Ah, yes of course. If we delay creating the decoder we need to call > begin_frame() again as well. > > Please review and/or test the attached patch. Andy I did understand you >

[Mesa-dev] [PATCH v2] st/va: remove assert for single slice

2017-03-21 Thread Nayan Deshmukh
we anyway allow for multiple slices v2: do not remove assert to check for buf->size Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- src/gallium/state_trackers/va/picture_mpeg12.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers

Re: [Mesa-dev] [PATCH] r600_shader.c: fix indentation

2017-03-22 Thread Nayan Deshmukh
Reviewed-by: Nayan Deshmukh On Wed, Mar 22, 2017 at 9:28 PM, Julien Isorce wrote: > Introduced by ad13bd2e51a5dc01b0f8a0eb927022f0deac0a0c > > Signed-off-by: Julien Isorce > --- > src/gallium/drivers/r600/r600_shader.c | 8 > 1 file changed, 4 insertions(+), 4 del

<    1   2   3