On Mon, Jul 10, 2017 at 04:00:23PM -0700, Jason Ekstrand wrote:
> On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote:
>
> > Image layouts only let us know that an image *may* be fast-cleared. For
> > this reason we can end up with redundant resolves. Testing has shown
> >
On Mon, Jul 10, 2017 at 02:36:16PM -0700, Jason Ekstrand wrote:
> On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote:
>
> > For readability, bring the assignment of CCS closer to the assignment of
> > NONE and MCS.
> >
> > Signed-off-by: Nanley Chery
On Tue, Dec 05, 2017 at 03:48:45PM -0800, Nanley Chery wrote:
> On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote:
> > This replaces image_fast_clear and ccs_resolve with two new helpers that
> > simply perform an isl_aux_op whatever that may be on CCS or MCS. Th
On Wed, Dec 06, 2017 at 09:40:25AM -0800, Nanley Chery wrote:
> On Tue, Dec 05, 2017 at 03:48:45PM -0800, Nanley Chery wrote:
> > On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote:
> > > This replaces image_fast_clear and ccs_resolve with two new helpers that
>
On Mon, Nov 27, 2017 at 07:05:57PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_image.c | 48
> ++--
> 1 file changed, 29 insertions(+), 19 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/
On Mon, Nov 27, 2017 at 07:05:58PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 17 -
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index 0c1ae83..be717eb
On Mon, Dec 11, 2017 at 03:57:58PM -0800, Nanley Chery wrote:
> On Mon, Nov 27, 2017 at 07:05:58PM -0800, Jason Ekstrand wrote:
> > ---
> > src/intel/vulkan/genX_cmd_buffer.c | 17 -
> > 1 file changed, 8 insertions(+), 9 deletions(-)
> >
> &
On Mon, Nov 27, 2017 at 07:05:59PM -0800, Jason Ekstrand wrote:
> This moves it to being based on layout_to_aux_usage instead of being
> hard-coded based on bits of a priori knowledge of how transitions
> interact with layouts. This conceptually simplifies things because
> we're now using layout_t
On Mon, Nov 27, 2017 at 07:05:56PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_image.c | 58
> ++
> src/intel/vulkan/anv_private.h | 5
> 2 files changed, 63 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulk
t;
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_cmd_buffer.c
> b/src/intel/vulkan/anv_cmd_buffer.c
> index 69acafa..7e7580c 100644
> --- a/src/intel/vulkan/anv_cmd_buffer.c
> +++ b/src/intel/vulkan/anv_cmd_buffer.c
> @@ -323,24 +323,34 @@ VkResult
On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote:
> Currently, this helper does nothing but we call it every place where an
> image is written through the render pipeline. This will allow us to
> properly mark the aux state so that we can handle resolves correctly.
> ---
> src/intel
On Thu, Dec 14, 2017 at 07:39:46PM +0200, kevin.rogo...@intel.com wrote:
> From: Kevin Rogovin
>
> This patch series implements a needed workaround for Gen9 for ASTC5x5
> sampler reads. The crux of the work around is to make sure that the
> sampler does not read an ASTC5x5 texture and a surface w
On Wed, Dec 13, 2017 at 05:52:03PM -0800, Jason Ekstrand wrote:
> This reverts commit ee57b15ec764736e2d5360beaef9fb2045ed0f68.
>
> Cc: "17.3"
> ---
> src/mesa/drivers/dri/i965/brw_meta_util.c | 10 -
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 57
> ---
>
;
> -Kevin
>
Hi,
Thanks for giving it a try.
Regards,
Nanley
> -Original Message-
> From: Nanley Chery [mailto:nanleych...@gmail.com]
> Sent: Friday, December 15, 2017 8:34 PM
> To: Rogovin, Kevin
> Cc: mesa-dev@lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATC
> makes it explicitly only on gen9.
>
> Cc: "17.3"
> Cc: Nanley Chery
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
Thanks for making the workaround gen9 specifi
On Sun, Dec 17, 2017 at 07:34:47PM -0800, Jason Ekstrand wrote:
> On Sat, Dec 16, 2017 at 3:07 PM, Jason Ekstrand
> wrote:
>
> > On December 16, 2017 14:35:29 Nanley Chery wrote:
> >
> > On Wed, Dec 13, 2017 at 05:52:03PM -0800, Jason Ekstrand wrote:
>
On Mon, Nov 27, 2017 at 07:06:03PM -0800, Jason Ekstrand wrote:
> This makes us start tracking two bits per level for aux to describe both
> whether or not something is fast-cleared and whether or not it is
> compressed as opposed to a single "needs resolve" bit. The previous
> scheme only worked
On Fri, Dec 15, 2017 at 02:53:29PM -0800, Rafael Antognolli wrote:
> gen10 can emit the clear color by setting it on a buffer somewhere, and
> then adding only the address to the surface state.
>
> This commit add support for that on isl_surf_fill_state, and if that is
> requested, skip setting th
On Fri, Dec 15, 2017 at 02:53:30PM -0800, Rafael Antognolli wrote:
> On Gen10+, if we use the clear state address field in the surface state
> instead of the clear color directly, there's a restriction that the
> address must point to the lower part of a 64 byte cache-line.
>
> Signed-off-by: Rafa
On Fri, Dec 15, 2017 at 02:53:32PM -0800, Rafael Antognolli wrote:
> Similarly to vulkan where we store the clear value in the aux surface,
> we can do the same in GL.
>
> Signed-off-by: Rafael Antognolli
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 25 +
> 1 f
the compiler happy anyway.
>
> Signed-off-by: Rafael Antognolli
> ---
> src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface
the same position in the
> xml.
>
> Signed-off-by: Rafael Antognolli
> ---
> src/intel/genxml/gen10.xml | 10 ++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/genxml/gen10.xml b/src/intel/genxml/ge
On Mon, Jan 08, 2018 at 04:03:47PM -0800, Jason Ekstrand wrote:
> On Mon, Jan 8, 2018 at 3:00 PM, Nanley Chery wrote:
>
> > On Fri, Dec 15, 2017 at 02:53:30PM -0800, Rafael Antognolli wrote:
> > > On Gen10+, if we use the clear state address field in the surface state
>
On Mon, Jan 08, 2018 at 04:33:25PM -0800, Rafael Antognolli wrote:
> On Mon, Jan 08, 2018 at 04:03:47PM -0800, Jason Ekstrand wrote:
> > On Mon, Jan 8, 2018 at 3:00 PM, Nanley Chery wrote:
> >
> > On Fri, Dec 15, 2017 at 02:53:30PM -0800, Rafael Antognolli wrote:
>
On Tue, Jan 09, 2018 at 11:26:26AM -0800, Jason Ekstrand wrote:
> On Tue, Jan 9, 2018 at 10:33 AM, Nanley Chery wrote:
>
> > On Mon, Jan 08, 2018 at 04:03:47PM -0800, Jason Ekstrand wrote:
> > > On Mon, Jan 8, 2018 at 3:00 PM, Nanley Chery
> > wrote:
> > >
&
On Mon, Jan 08, 2018 at 04:00:37PM -0800, Jason Ekstrand wrote:
> On Mon, Jan 8, 2018 at 2:29 PM, Nanley Chery wrote:
>
> > On Fri, Dec 15, 2017 at 02:53:29PM -0800, Rafael Antognolli wrote:
> > > gen10 can emit the clear color by setting it on a buffer somewhere, and
>
d, 4 insertions(+), 4 deletions(-)
>
Makes sense. This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index 2d47179..bbe97f5 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulka
insertions(+), 24 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index bbe97f5..6f2fa0a 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulkan/genX
void genX(CmdNextSubpass)(
> @@ -3236,9 +3234,9 @@ void genX(CmdNextSubpass)(
>
> assert(cmd_buffer->level == VK_COMMAND_BUFFER_LEVEL_PRIMARY);
>
> + uint32_t prev_subpass = anv_get_subpass_id(&cmd_buffer->state);
The prev_ prefix confused me a little. Maybe ending_subpass
On Fri, Dec 08, 2017 at 04:16:04PM +0200, Pohjolainen, Topi wrote:
> On Mon, Nov 27, 2017 at 07:06:07PM -0800, Jason Ekstrand wrote:
> > This doesn't really change much now but it will give us more/better
> > control over clears in the future. The one interesting functional
> > change here is that
On Thu, Nov 30, 2017 at 06:20:51PM +0200, Pohjolainen, Topi wrote:
> On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote:
> > Currently, this helper does nothing but we call it every place where an
> > image is written through the render pipeline. This will allow us to
> > properly mark
src/intel/vulkan/genX_cmd_buffer.c | 46 ++-
> 3 files changed, 86 insertions(+), 83 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index 46e2eb0..7401234 100644
> --- a/src/intel/vulkan/anv_blo
On Mon, Nov 27, 2017 at 07:06:08PM -0800, Jason Ekstrand wrote:
> This is similar to blorp_gen8_hiz_clear_attachments except that it takes
> actual images instead of trusting in the already set depth state.
> ---
> src/intel/blorp/blorp.h | 11 ++
> src/intel/blorp/blorp_clear.c | 50
On Mon, Nov 27, 2017 at 07:06:09PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_blorp.c | 243
> -
> src/intel/vulkan/anv_private.h | 17 ++-
> src/intel/vulkan/genX_cmd_buffer.c | 68 ++-
> 3 files changed, 188 insertions(+), 1
--+-++
> >
> > We will need to think about what to do with this. Having non-zero clears
> > be different from zero clears is tricky. We may need to have even more
> > bits in our aux tracking. :-/
>
On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote:
> On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote:
> > Sorry for all the list spam, but I'm sort of thinking out-loud and writing
> > it on the list for all to read.
> >
> > I'm th
On Tue, Jan 16, 2018 at 10:21:44PM -0800, Jason Ekstrand wrote:
> On Tue, Jan 16, 2018 at 4:30 PM, Nanley Chery wrote:
>
> > On Tue, Jan 16, 2018 at 12:02:43PM -0800, Nanley Chery wrote:
> > > On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote:
> > >
On Sat, Jan 13, 2018 at 10:12:53AM -0800, Jason Ekstrand wrote:
> On Sat, Jan 13, 2018 at 9:55 AM, Jason Ekstrand
> wrote:
>
> > On Wed, Dec 13, 2017 at 4:46 PM, Nanley Chery
> > wrote:
> >
> >> On Mon, Nov 27, 2017 at 07:06:01PM -0800, Jason Ekstrand wrote
On Fri, Jan 12, 2018 at 04:26:44PM -0800, Jason Ekstrand wrote:
> On Wed, Dec 13, 2017 at 11:00 AM, Nanley Chery
> wrote:
>
> > On Mon, Nov 27, 2017 at 07:05:59PM -0800, Jason Ekstrand wrote:
> > > This moves it to being based on layout_to_aux_usage instead of being
&
On Fri, Jan 12, 2018 at 04:10:14PM -0800, Jason Ekstrand wrote:
> On Mon, Dec 11, 2017 at 3:57 PM, Nanley Chery wrote:
>
> > On Mon, Nov 27, 2017 at 07:05:58PM -0800, Jason Ekstrand wrote:
> > > ---
> > > src/intel/vulkan/genX_cmd_buffer.c | 17
On Mon, Jan 15, 2018 at 03:29:07PM +0200, Pohjolainen, Topi wrote:
> On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote:
> > Sorry for all the list spam, but I'm sort of thinking out-loud and writing
> > it on the list for all to read.
> >
> > I'm thinking that what we want this list t
On Thu, Oct 05, 2017 at 10:02:39PM -0700, Kenneth Graunke wrote:
> The bulk of the work in intel_disable_rb_aux_buffer() is finding the
> drawbuffer index for the given BO. After that, disabling the auxiliary
> buffers is an easy one liner.
>
> This lets us ask whether a texture is also bound as
On Thu, Oct 05, 2017 at 10:02:40PM -0700, Kenneth Graunke wrote:
> Jason and I investigated several OpenGL CTS failures where the tests
> bind the same texture for rendering and texturing, at the same time.
> This has defined results as long as the reads happen before writes,
> or the regions are n
On Mon, Oct 09, 2017 at 10:42:06PM +0200, Józef Kucia wrote:
> ---
> src/intel/vulkan/genX_cmd_buffer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan
Enable multiple layers of the depth/stencil buffers to be accessible.
Fixes the crucible test, func.depthstencil.arrayed_clear.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions
We currently don't perform clears or resolves on multiple array layers
with HiZ.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_im
Match the comment above the field by using units of pixels and not HiZ
blocks.
Cc: mesa-sta...@lists.freedesktop.org
Suggested-by: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel
On Fri, Jan 06, 2017 at 03:08:12PM -0800, Jason Ekstrand wrote:
> 2017-01-06 14:46 GMT-08:00 Nanley Chery :
>
> > We currently don't perform clears or resolves on multiple array layers
> > with HiZ.
> >
>
> Glancing through the code, it looks like you're
performed between driver builds. The
Talos Principle runs are omitted as no significant changes were
measured. No warm-up was performed for the Vulkan examples and the demo
resolution was the default window size on startup.
Nanley Chery (22):
intel/blorp: Add the BDW+ optimized HZ_OP sequence to BLORP
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 54 +++---
src/intel/vulkan/genX_cmd_buffer.c | 1 -
2 files changed, 50 insertions(+), 5 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 13d5b5f9d7
Prevent assert failures that would occur in the next patch. BLORP
ignores this flag internally, so no protections are lost here.
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp_blit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp
The helper doesn't provide additional functionality over the current
infrastructure.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 2 +-
src/intel/vulkan/anv_image.c | 10 --
src/intel/vulkan/anv_private.h | 10 --
src/intel/v
ge of VkCmdClearAttachments().
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp_genX_exec.h | 87 +++
1 file changed, 87 insertions(+)
diff --git a/src/intel/blorp/blorp_genX_exec.h
b/src/intel/blorp/blorp_genX_exec.h
index 66906fabbc..a673ab8141 100644
---
We'll be using layout transitions later on in the series which can occur
within and between subpasses. Turn this on now to simplify the change
later.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/TODO | 2 +-
src/intel/vulkan/gen8_cmd_buffer.c | 11 +--
src/intel/v
We're about to enable HiZ support for multiple subpasses. Use this field
to keep track of whether or not subpass operations should treat the
depth buffer as having an auxiliary HiZ buffer.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 6 --
1 file chang
Store the current and requested depth stencil layouts so that we can
perform the appropriate HiZ resolves for a given transition while
recording a render pass.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c| 5 +
src/intel/vulkan/anv_private.h | 11 +++
src
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 50 ++
1 file changed, 50 insertions(+)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 74369f6ba1..fff9bd37c0 100644
--- a/src/intel/vulkan
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 17 +
src/intel/vulkan/genX_cmd_buffer.c | 10 --
2 files changed, 17 insertions(+), 10 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index d821629191..f8a21c2982
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 9 +++--
src/intel/vulkan/anv_private.h | 15 +++
src/intel/vulkan/genX_cmd_buffer.c | 5 +
3 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 63f6be12a8..74369f6ba1 100644
--- a/src/intel/vulkan
This is no longer used.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_genX.h| 3 -
src/intel/vulkan/gen7_cmd_buffer.c | 7 --
src/intel/vulkan/gen8_cmd_buffer.c | 223 -
3 files changed, 233 deletions(-)
diff --git a/src/intel/vulkan
Add an entry point for resolving using BLORP's gen8 HiZ op function.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 74 ++
src/intel/vulkan/anv_private.h | 5 +++
2 files changed, 79 insertions(+)
diff --git a/src/intel/v
Avoid the resolves that would be required if fast depth clears were
allowed for such buffers.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 5d410f7d86
This is a better mapping to the Vulkan API and improves performance in
all tested workloads.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 48 ++---
src/intel/vulkan/genX_cmd_buffer.c | 54 +++---
2 files changed
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index f8a21c2982..7d5beeabbe 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -190,6
Signed-off-by: Nanley Chery
---
src/intel/isl/isl_surface_state.c | 38 +++---
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/src/intel/isl/isl_surface_state.c
b/src/intel/isl/isl_surface_state.c
index b9093cc951..54e48eb5da 100644
--- a/src/intel
additional alignment restrictions.
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp.h | 12 +++
src/intel/blorp/blorp_clear.c | 80 +++
2 files changed, 92 insertions(+)
diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h
index
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c| 3 +++
src/intel/vulkan/anv_private.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c
index ea86fa9ff2..5df6330c6a 100644
--- a/src/intel/vulkan/anv_pass.c
+++ b/src
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_private.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 98692b5913..fc7b6d1ec8 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 54 +-
1 file changed, 41 insertions(+), 13 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 447baa08b2..11745f8b9e 100644
--- a/src
Signed-off-by: Nanley Chery
---
src/intel/vulkan/TODO| 1 -
src/intel/vulkan/anv_image.c | 19 ---
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
index 37fd16b437..38acc0dd5b 100644
--- a/src/intel/vulkan
On Wed, Jan 11, 2017 at 05:54:46PM -0800, Nanley Chery wrote:
> In my testing, this series completely removes HiZ resolves for the
> following Vulkan applications: Dota 2, Talos Principle, and the Sascha
> Willems Vulkan examples and demos. This is accomplished with two major
> change
r things in the
> office if you'd like.
>
> --Jason
>
Good to hear! I'll see if I can safely get there, otherwise a remote
meeting would also work for me.
-Nanley
> On Wed, Jan 11, 2017 at 6:01 PM, Nanley Chery wrote:
>
> > On Wed, Jan 11, 2017 at 05:54:46PM -
additional alignment restrictions.
v2: Adjust code comment about padding
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp.h | 12 +++
src/intel/blorp/blorp_clear.c | 81 +++
2 files changed, 93 insertions(+)
diff --git a/src/intel/blorp/blorp.h
The helper doesn't provide additional functionality over the current
infrastructure.
v2: Add comment to anv_image::aux_usage (Jason Ekstrand)
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 2 +-
src/intel/vulkan/anv_image.c | 10 --
src/intel/v
We're about to enable HiZ support for multiple subpasses. Use this field
to keep track of whether or not subpass operations should treat the
depth buffer as having an auxiliary HiZ buffer.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 6 --
1 file chang
ge in VkCmdClearAttachments().
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp_genX_exec.h | 87 +++
1 file changed, 87 insertions(+)
diff --git a/src/intel/blorp/blorp_genX_exec.h
b/src/intel/blorp/blorp_genX_exec.h
index 66906fabbc..a673ab8141 100644
---
Prevent assert failures that would occur in the next patch.
v2: Don't remove asserts from blorp/blit (Jason Ekstrand)
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 54 +++---
src/intel/vulkan/genX_cmd_buffer.c | 1 -
2 files changed, 50 insertions(+), 5 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 97ce236fc5
This is no longer used.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_genX.h| 3 -
src/intel/vulkan/gen7_cmd_buffer.c | 7 --
src/intel/vulkan/gen8_cmd_buffer.c | 223 -
3 files changed, 233 deletions(-)
diff --git a/src/intel/vulkan
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c| 3 +++
src/intel/vulkan/anv_private.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c
index ea86fa9ff2..5df6330c6a 100644
--- a/src/intel/vulkan/anv_pass.c
+++ b/src
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 9 +++--
src/intel/vulkan/anv_private.h | 15 +++
src/intel/vulkan/genX_cmd_buffer.c | 5 +
3 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel
This is a better mapping to the Vulkan API and improves performance in
all tested workloads.
v2: Remove unnecessary image view aspect checks (Jason Ekstrand)
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 48 ++--
src/intel/vulkan
Store the current and requested depth stencil layouts so that we can
perform the appropriate HiZ resolves for a given transition while
recording a render pass.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c| 5 +
src/intel/vulkan/anv_private.h | 11 +++
src
Add an entry point for resolving using BLORP's gen8 HiZ op function.
v2: Manually add the aux info
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 83 ++
src/intel/vulkan/anv_private.h | 5 +++
2 files changed, 88 insertions(+)
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 50 ++
1 file changed, 50 insertions(+)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 74369f6ba1..fff9bd37c0 100644
--- a/src/intel/vulkan
v2 (Jason Ekstrand):
- Add spec citation
- Drop conditional
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 23 +++
src/intel/vulkan/genX_cmd_buffer.c | 17 +
2 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/src/intel
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 63f6be12a8..74369f6ba1 100644
--- a/src/intel/vulkan
We'll be using layout transitions later on in the series which can occur
within and between subpasses. Turn this on now to simplify the change
later.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/TODO | 2 +-
src/intel/vulkan/gen8_cmd_buffer.c | 11 +--
src/intel/v
v2: Simplify nested ifs (Jason Ekstrand)
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 67 --
1 file changed, 49 insertions(+), 18 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_private.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index b669d186ef..56aa6ef6e3 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
Avoid the resolves that would be required if fast depth clears were
allowed for such buffers.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index b161400db5
v2: Remove redundant x/y offset asserts (Jason Ekstrand)
Signed-off-by: Nanley Chery
---
src/intel/isl/isl_surface_state.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/intel/isl/isl_surface_state.c
b/src/intel/isl/isl_surface_state.c
index b9093cc951
v2: Restrict ISL_AUX_USAGE_HIZ to depth aspects
Signed-off-by: Nanley Chery
---
src/intel/vulkan/TODO| 1 -
src/intel/vulkan/anv_image.c | 20 +---
2 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
index
On Thu, Jan 12, 2017 at 06:17:58PM -0800, Jason Ekstrand wrote:
> On Thu, Jan 12, 2017 at 5:33 PM, Nanley Chery wrote:
>
> > The helper doesn't provide additional functionality over the current
> > infrastructure.
> >
> > v2: Add comment to anv_image::aux_us
On Thu, Jan 12, 2017 at 06:26:44PM -0800, Jason Ekstrand wrote:
> Good work! Series is
>
> Reviewed-by: Jason Ekstrand
>
Thanks!
-Nanley
> On Thu, Jan 12, 2017 at 5:34 PM, Nanley Chery wrote:
>
> > v2: Simplify nested ifs (Jason Ekstrand)
> >
&
Compressing a render target and decompressing it in the same
single-subpass render pass may waste bandwidth. While this may be
beneficial in some circumstances, it does not help in all.
Cc: "13.0 17.0"
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 6
olves. I'm currently looking into this.
-Nanley
Nanley Chery (2):
anv/cmd_buffer: Don't temporarily enable CCS_E within a render pass
anv/blorp: Disable partial resolves for transparent black clears
src/intel/vulkan/anv_blorp.c | 10 --
src/intel/vulkan/genX_cmd_buffer.c
Cc: "13.0 17.0"
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 2edd0712c9..4a4b479116 100644
--- a/src/intel/vulkan/anv_blo
On Mon, Jan 23, 2017 at 05:30:22PM -0800, Jason Ekstrand wrote:
> On Mon, Jan 23, 2017 at 4:55 PM, Nanley Chery wrote:
>
> > Compressing a render target and decompressing it in the same
> > single-subpass render pass may waste bandwidth. While this may be
> > beneficial i
901 - 1000 of 1409 matches
Mail list logo
