On Mon, Nov 27, 2017 at 07:06:04PM -0800, Jason Ekstrand wrote: > This seems slightly more correct because it means that the flushes > happen before any clears or resolves implied by the subpass transition. > --- > src/intel/vulkan/genX_cmd_buffer.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >
Makes sense. This patch is Reviewed-by: Nanley Chery <nanley.g.ch...@intel.com> > diff --git a/src/intel/vulkan/genX_cmd_buffer.c > b/src/intel/vulkan/genX_cmd_buffer.c > index 2d47179..bbe97f5 100644 > --- a/src/intel/vulkan/genX_cmd_buffer.c > +++ b/src/intel/vulkan/genX_cmd_buffer.c > @@ -3197,10 +3197,10 @@ void genX(CmdBeginRenderPass)( > > genX(flush_pipeline_select_3d)(cmd_buffer); > > - genX(cmd_buffer_set_subpass)(cmd_buffer, pass->subpasses); > - > cmd_buffer->state.pending_pipe_bits |= > cmd_buffer->state.pass->subpass_flushes[0]; > + > + genX(cmd_buffer_set_subpass)(cmd_buffer, pass->subpasses); > } > > void genX(CmdNextSubpass)( > @@ -3220,11 +3220,11 @@ void genX(CmdNextSubpass)( > */ > cmd_buffer_subpass_transition_layouts(cmd_buffer, true); > > - genX(cmd_buffer_set_subpass)(cmd_buffer, cmd_buffer->state.subpass + 1); > - > uint32_t subpass_id = anv_get_subpass_id(&cmd_buffer->state); > cmd_buffer->state.pending_pipe_bits |= > cmd_buffer->state.pass->subpass_flushes[subpass_id]; > + > + genX(cmd_buffer_set_subpass)(cmd_buffer, cmd_buffer->state.subpass + 1); > } > > void genX(CmdEndRenderPass)( > -- > 2.5.0.400.gff86faf > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
