On Tue, Nov 14, 2017 at 02:30:31PM +, Lionel Landwerlin wrote:
> On 13/11/17 22:07, Jason Ekstrand wrote:
> > On Mon, Nov 13, 2017 at 1:30 PM, Nanley Chery > <mailto:nanleych...@gmail.com>> wrote:
> >
> > On Mon, Nov 13, 2017 at 08:12:41AM -0800, Jason E
On Tue, Nov 14, 2017 at 02:52:35PM -0800, Anuj Phogat wrote:
> This fixes the changes introduced in commit 6165fda59b.
>
> Signed-off-by: Anuj Phogat
> Cc:
> Cc: Nanley Chery
> Cc: Kenneth Graunke
> ---
> src/mesa/drivers/dri/i965/brw_defines.h | 2 +-
> 1 file
On Wed, Nov 08, 2017 at 04:52:02PM +0100, Juan A. Suarez Romero wrote:
> From section 8.7, page 179 of OpenGL ES 3.2 spec:
>
> An INVALID_OPERATION error is generated by CompressedTexImage3D
> if internalformat is one of the the formats in table 8.17 and target
> is not TEXTURE_2D_ARRAY, TEX
On Wed, Nov 15, 2017 at 12:08:58PM -0500, Ilia Mirkin wrote:
> On Wed, Nov 15, 2017 at 11:54 AM, Juan A. Suarez Romero
> wrote:
> > From section 8.7, page 179 of OpenGL ES 3.2 spec:
> >
> > An INVALID_OPERATION error is generated by CompressedTexImage3D
> > if internalformat is one of the the
On Wed, Nov 15, 2017 at 05:56:00PM -0500, Ilia Mirkin wrote:
> On Wed, Nov 15, 2017 at 5:49 PM, Nanley Chery wrote:
> > On Wed, Nov 15, 2017 at 12:08:58PM -0500, Ilia Mirkin wrote:
> >> On Wed, Nov 15, 2017 at 11:54 AM, Juan A. Suarez Romero
> >> wrote:
> >
On Fri, Nov 17, 2017 at 09:42:40AM +0100, Juan A. Suarez Romero wrote:
> On Wed, 2017-11-15 at 17:56 -0500, Ilia Mirkin wrote:
> > On Wed, Nov 15, 2017 at 5:49 PM, Nanley Chery wrote:
> > > On Wed, Nov 15, 2017 at 12:08:58PM -0500, Ilia Mirkin wrote:
> > > > On Wed,
texture_cube_map_array.etc2_texture
> ---
> src/mesa/main/teximage.c | 20 +++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 4ec6148bf4
One helper is not used in this series, but is included because it may be
useful when working with CNL's 10-10-10-2 formats.
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.h| 4
src/intel/isl/isl_format.c | 20
2 files changed, 24 insertions(+)
diff --
When sampling from fast-cleared sRGB textures on gen10, the hardware
will not decode the clear color to linear. We must therefore do it in
software.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/brw_blorp.c| 7 +
src/mesa/drivers/dri/i965/brw_meta_util.c| 38
On Mon, Nov 20, 2017 at 01:54:39PM -0800, Nanley Chery wrote:
> When sampling from fast-cleared sRGB textures on gen10, the hardware
> will not decode the clear color to linear. We must therefore do it in
> software.
>
I should've included the tests that are now passing
On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote:
> On Mon, Nov 20, 2017 at 2:10 PM, Nanley Chery wrote:
>
> > On Mon, Nov 20, 2017 at 01:54:39PM -0800, Nanley Chery wrote:
> > > When sampling from fast-cleared sRGB textures on gen10, the hardware
> >
On Mon, Nov 20, 2017 at 03:48:54PM -0800, Nanley Chery wrote:
> On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote:
> > On Mon, Nov 20, 2017 at 2:10 PM, Nanley Chery wrote:
> >
> > > On Mon, Nov 20, 2017 at 01:54:39PM -0800, Nanley Chery wrote:
> > >
On Mon, Nov 20, 2017 at 04:03:20PM -0800, Jason Ekstrand wrote:
> On Mon, Nov 20, 2017 at 3:48 PM, Nanley Chery wrote:
>
> > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote:
> > > On Mon, Nov 20, 2017 at 2:10 PM, Nanley Chery
> > wrote:
> > >
&
On Fri, Nov 17, 2017 at 10:22:37AM -0800, Nanley Chery wrote:
> On Fri, Nov 17, 2017 at 05:07:09PM +0100, Juan A. Suarez Romero wrote:
> > From section 8.7, page 179 of OpenGL ES 3.2 spec:
> >
> > An INVALID_OPERATION error is generated by CompressedTexImage3D
> >
On Mon, Nov 13, 2017 at 08:12:46AM -0800, Jason Ekstrand wrote:
> ---
> src/intel/blorp/blorp.c | 1 +
> src/intel/blorp/blorp.h | 7 +++
> src/intel/blorp/blorp_genX_exec.h | 77
> +
> src/intel/blorp/blorp_priv.h
eletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c
> b/src/mesa/drivers/dri/i965/brw_blorp.c
> index 58e1f8a..eae8aaa 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c
> +++ b/src/mesa/drivers/dri
is
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h
> index c3077aa..690e65f 100644
> --- a/src/intel/blorp/blorp.h
> +++ b/src/intel/blorp/blorp.h
> @@ -202,7 +202,8 @@ enum blorp_fast_clear_op {
>
> void
> b
-
> 2 files changed, 33 insertions(+), 50 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index e17a52a..6eed057 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulk
files changed, 20 insertions(+), 67 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index 6deb350..27320c2 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulka
> need for the extra entrypoint.
> ---
> src/intel/blorp/blorp.h | 11 ---
> src/intel/blorp/blorp_clear.c | 70
> +--
> 2 files changed, 20 insertions(+), 61 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff
t)
> +{
> + assert(cmd_buffer && image);
> +
> + uint32_t plane = anv_image_aspect_to_plane(image->aspects, aspect);
> +
> + /* The resolved subresource range must have a CCS buffer. */
^
On Mon, Nov 13, 2017 at 08:12:54AM -0800, Jason Ekstrand wrote:
> This speeds up the Sascha Willems multisampling demo by around 25% when
> using 8x MSAA.
> ---
> src/intel/vulkan/anv_blorp.c | 6 ++
> src/intel/vulkan/genX_cmd_buffer.c | 22 --
> 2 files changed, 18
think it would also be good to update the documentation to
include this one.
Whether or not you update it, patches 3 and 4 are:
Reviewed-by: Nanley Chery
> nir_if *if_stmt = nir_if_create(b->shader);
> - if_stmt->condition = nir_src_for_ssa(mcs_zero);
> +
Ping.
-Nanley
On Mon, Nov 20, 2017 at 05:18:12PM -0800, Nanley Chery wrote:
> On Mon, Nov 20, 2017 at 04:03:20PM -0800, Jason Ekstrand wrote:
> > On Mon, Nov 20, 2017 at 3:48 PM, Nanley Chery wrote:
> >
> > > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wr
On Mon, Nov 20, 2017 at 05:18:12PM -0800, Nanley Chery wrote:
> On Mon, Nov 20, 2017 at 04:03:20PM -0800, Jason Ekstrand wrote:
> > On Mon, Nov 20, 2017 at 3:48 PM, Nanley Chery wrote:
> >
> > > On Mon, Nov 20, 2017 at 02:55:28PM -0800, Jason Ekstrand wrote:
> > &g
From: Jason Ekstrand
Reviewed-by: Nanley Chery
---
src/util/format_srgb.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/util/format_srgb.h b/src/util/format_srgb.h
index 34b50afe3d..596af56f4c 100644
--- a/src/util/format_srgb.h
+++ b/src/util/format_srgb.h
@@ -54,6
-clear
* spec@arb_framebuffer_srgb@msaa-fast-clear
* spec@ext_texture_srgb@fbo-fast-clear
* spec@ext_texture_srgb@multisample-fast-clear gl_ext_texture_srgb
v2 (Jason Ekstrand):
- Update some comments.
- Simplify assertions.
- Use an sRGB-to-linear helper.
Signed-off-by: Nanley Chery
---
src/mesa
On Mon, Nov 27, 2017 at 11:02:15AM -0800, Nanley Chery wrote:
> When sampling from fast-cleared sRGB textures on gen10, the hardware
> will not decode the clear color to linear. We must therefore do it in
> software.
>
> This makes the following piglit tests pass:
> * spec@ar
On Mon, Nov 27, 2017 at 07:05:55PM -0800, Jason Ekstrand wrote:
> This got lost in all of the aspect vs. plane rebasing of YCBCR.
> ---
> src/intel/vulkan/anv_image.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff
anged, 17 insertions(+), 17 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> index 7d040bd..6aeffa3 100644
> --- a/src/intel/vulkan/genX_cmd_buffer.c
> +++ b/src/intel/vulka
On Mon, Nov 27, 2017 at 11:44:21AM -0800, Jason Ekstrand wrote:
> On Mon, Nov 27, 2017 at 11:41 AM, Nanley Chery
> wrote:
>
> > On Mon, Nov 27, 2017 at 11:02:15AM -0800, Nanley Chery wrote:
> > > When sampling from fast-cleared sRGB textures on gen10, the hardware
> &g
_srgb
Suggested-by: Kenneth Graunke
Suggested-by: Jason Ekstrand
Signed-off-by: Nanley Chery
---
This patch is currently going through the jenkins pipeline.
src/mesa/drivers/dri/i965/brw_meta_util.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/mesa/dr
On Fri, Dec 01, 2017 at 02:44:42PM -0800, Nanley Chery wrote:
> Gen10 doesn't automatically decode the clear color of sRGB buffers. To
> get correct rendering, avoid fast-clearing such buffers for now.
>
> The driver now passes the following piglit tests:
> * spec@arb_frameb
On Fri, Dec 01, 2017 at 04:42:22PM -0800, Jason Ekstrand wrote:
> On Fri, Dec 1, 2017 at 2:44 PM, Nanley Chery wrote:
>
> > Gen10 doesn't automatically decode the clear color of sRGB buffers. To
> > get correct rendering, avoid fast-clearing such buffers for now.
> &
/isl/isl.h | 74
> +++--
> 1 file changed, 49 insertions(+), 25 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
> index e3acb0e..fda2411 100644
> --- a/src/intel/isl/isl.h
> +++ b/src/intel/i
On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote:
> This replaces image_fast_clear and ccs_resolve with two new helpers that
> simply perform an isl_aux_op whatever that may be on CCS or MCS. This
> is a bit cleaner as it separates performing the aux operation from which
> blorp help
ate no longer needs a check on the aspect. If the
aspect is stencil the aux_usage will either be NONE or HIZ. If the
aux_usage HIZ it'll be caught by the aux_usage check. If it's NONE
there's no work to be done. Either way, this patch is
Reviewed-by: Nanley Chery
> + a
On Mon, Nov 27, 2017 at 07:05:52PM -0800, Jason Ekstrand wrote:
> This replaces image_fast_clear and ccs_resolve with two new helpers that
> simply perform an isl_aux_op whatever that may be on CCS or MCS. This
> is a bit cleaner as it separates performing the aux operation from which
> blorp help
On Mon, Nov 27, 2017 at 07:05:54PM -0800, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_blorp.c | 38
> ++
> src/intel/vulkan/anv_private.h | 9 +
> src/intel/vulkan/genX_cmd_buffer.c | 11 ++-
> 3 files changed, 33 insertions(+)
On Wed, Jun 14, 2017 at 10:13:41AM +0200, Iago Toral wrote:
> On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote:
> > Splitting out these fields will make the color buffer transitioning
> > function simpler when it gains more features.
> >
> > Signed-off-by: Nan
tes. This
> + * maximum is 2 GB for all products and all surface types.
This block and the following are missing closing quotations. I think we
can omit the opening quotes since you're doing a block quote. It's up to
you though.
With those two issues fixed, this series is
Re
On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_blit.h | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_blit.h
> b/src/mesa/drivers/dri/i965/intel_b
On Tue, Jun 13, 2017 at 05:50:03PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> b/src/mesa/drivers/
On Thu, Jun 15, 2017 at 06:23:24PM -0700, Jason Ekstrand wrote:
> On Thu, Jun 15, 2017 at 5:18 PM, Nanley Chery wrote:
>
> > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen
> > > ---
> > > src/
On Fri, Jun 16, 2017 at 07:58:02AM +0300, Pohjolainen, Topi wrote:
> On Thu, Jun 15, 2017 at 05:18:22PM -0700, Nanley Chery wrote:
> > On Tue, Jun 13, 2017 at 05:50:00PM +0300, Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen
> > > ---
> > > sr
; > > + const unsigned level_depth = src_mt->surf.dim == ISL_SURF_DIM_3D ?
> > >
> >
> > This needs a MAYBE_UNUSED or else we'll get warnings in release builds.
> > Another option would be to do
> >
> > if (src_mt->surf.dim == ISL_SURF_DIM_3D
mt->surf.dim == ISL_SURF_DIM_3D ? 0 : slice;
> + isl_surf_get_image_offset_sa(&mt->surf, level, slice, z,
> + &x_offset_sa, &y_offset_sa);
> +
> + *x = x_offset_sa;
> + *y = y_offset_sa;
I'm assuming that usin
+ if (!isl_surf_init_s(&brw->isl_dev, &mt->surf, &init_info))
> + goto fail;
> +
> + assert(mt->surf.size % mt->surf.row_pitch == 0);
> +
> + if (!bo) {
> + unsigned pitch = mt->surf.row_pitch;
^
MAYBE_UNUSED for release
is
> resolved before merging some of these too.
>
> Iago
>
Thank you for the review! I plan to merge parts of this series soon.
-Nanley
> > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote:
> > > This series implements refactors and behavioral changes to make the
&
On Mon, Jun 19, 2017 at 04:16:32PM -0700, Jason Ekstrand wrote:
> On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery
> wrote:
>
> > v2:
> > - Check for aux levels in layer helper (Jason Ekstrand)
> > - Don't assert aux is present, return 0 if it isn't.
> &g
On Mon, Jun 19, 2017 at 04:33:29PM -0700, Jason Ekstrand wrote:
> On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery
> wrote:
>
> > Splitting out these fields will make the color buffer transitioning
> > function simpler when it gains more features.
> >
>
On Mon, Jun 19, 2017 at 04:19:36PM -0700, Jason Ekstrand wrote:
> On Wed, Jun 14, 2017 at 3:06 PM, Nanley Chery wrote:
>
> > On Wed, Jun 14, 2017 at 09:32:22AM +0200, Iago Toral wrote:
> > > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote:
> > > > For 3
On Mon, Jun 19, 2017 at 05:03:51PM -0700, Jason Ekstrand wrote:
> On Mon, Jun 19, 2017 at 4:46 PM, Nanley Chery wrote:
>
> > On Mon, Jun 19, 2017 at 04:16:32PM -0700, Jason Ekstrand wrote:
> > > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery
> > > wrote:
> &g
e I'll have to send out a V2, so I'll update the 3 uses of that
term.
> On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery
> wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/blorp/blorp.c | 4
> > 1 file changed, 4 insertions(+)
On Mon, Jun 19, 2017 at 04:06:34PM -0700, Jason Ekstrand wrote:
> On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery
> wrote:
>
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/blorp/blorp_clear.c | 4
> > 1 file changed, 4 insertions(+)
> >
> &g
On Tue, Jun 20, 2017 at 02:50:33PM -0700, Jason Ekstrand wrote:
> On Tue, Jun 20, 2017 at 2:43 PM, Nanley Chery wrote:
>
> > On Mon, Jun 19, 2017 at 04:06:34PM -0700, Jason Ekstrand wrote:
> > > On Tue, Jun 13, 2017 at 11:41 AM, Nanley Chery
> > > wrote:
>
On Wed, Jun 21, 2017 at 09:04:01AM +0200, Iago Toral wrote:
> On Tue, 2017-06-20 at 12:21 -0700, Nanley Chery wrote:
> > On Mon, Jun 19, 2017 at 04:19:36PM -0700, Jason Ekstrand wrote:
> > > On Wed, Jun 14, 2017 at 3:06 PM, Nanley Chery > > m> wrote:
> > >
&
v2 (Jason Ekstrand):
- Remove Vulkan-specific terminology from the commit title.
- Replace '== 7' with '<= 7' to hint that this is a new feature on BDW+.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v1)
---
src/intel/isl/isl.c | 9 +++--
1 file chan
v2 (Jason Ekstrand):
- Update commit title
- Check aux level and layer as well
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v1)
---
src/intel/blorp/blorp.c | 7 +++
src/intel/blorp/blorp_clear.c | 4
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a
v2: Update commit title (Jason Ekstrand)
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v1)
---
src/intel/blorp/blorp_clear.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
index 369e18726f..0e523dfe5b 100644
Reflect the fact that an image view or subresource range with the color
aspect cannot have any other aspect.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/vulkan/genX_cmd_buffer.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/src/intel
v2: Omit the commit message.
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand (v1)
Reviewed-by: Iago Toral Quiroga
---
src/intel/isl/isl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index ba56d86c17..bbbdb19df2 100644
v2:
- Check for aux levels in layer helper (Jason Ekstrand)
- Don't assert aux is present, return 0 if it isn't.
- Use the helpers.
v3:
- Make the helpers aspect-agnostic (Jason Ekstrand)
- Drop anv_image_has_color_aux()
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v2
amout' to 'so'
Suggested-by: Jason Ekstrand
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v2)
---
src/intel/vulkan/anv_genX.h| 8
src/intel/vulkan/genX_cmd_buffer.c | 6 +++---
src/intel/vulkan/genX_gpu_memcpy.c | 8
3 files changed, 11 inse
In the future, we plan on using this method to resolve images whose
surface state fast-clear value is dynamically updated during command
buffer execution. Start using it now for testing and to reduce churn
later on.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel
v2:
- Do layered resolves.
(Jason Ekstrand):
- Replace "bt" suffix with "attachment".
- Rename helper function to prepare_ccs_resolve.
- Move blorp_params_init() into helper function.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/blor
Make the function take in an image instead of an image view. This
enables us to record relocations for surfaces states created outside of
the anv_CreateImageView path.
v2 (Jason Ekstrand):
- Use image->offset instead of surf_offset in aux_offset calculation.
Signed-off-by: Nanley Chery
Revie
This will be used in the next patch.
v2:
- Omit BLORP_BATCH_NO_EMIT_DEPTH_STENCIL (Jason Ekstrand)
- Update commit message.
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/vulkan/anv_blorp.c | 38 ++
src/intel/vulkan
Splitting out these fields will make the color buffer transitioning
function simpler when it gains more features.
v2: Remove unintended blank line (Iago Toral)
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga
---
src/intel/vulkan/anv_blorp.c | 33
Toral).
Signed-off-by: Nanley Chery
Reviewed-by: Iago Toral Quiroga (v1)
Reviewed-by: Jason Ekstrand (v1)
---
src/intel/vulkan/anv_blorp.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
index 34a59
On Wed, Jun 21, 2017 at 06:19:57PM -0700, Jason Ekstrand wrote:
> On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote:
>
> > In the future, we plan on using this method to resolve images whose
> > surface state fast-clear value is dynamically updated during command
> >
On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote:
> On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote:
>
> > v2 (Jason Ekstrand):
> > - Update commit title
> > - Check aux level and layer as well
> >
> > Signed-off-by: Nanley Chery
>
On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote:
> On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote:
> > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote:
> >
> > > v2 (Jason Ekstrand):
> > > - Update commit title
> >
On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote:
> On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote:
> > On Wed, Jun 21, 2017 at 06:07:29PM -0700, Jason Ekstrand wrote:
> > > On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery
> > > wrote:
> &
gt; Given that you're changing core blorp, please make sure you run this
> through Jenkins on GL. :-)
>
> --Jason
>
Thanks! I made the modification to patch 1 and I'll re-run jenkins for GL.
-Nanley
> On Wed, Jun 21, 2017 at 5:15 PM, Nanley Chery wrote:
>
> > A
On Mon, Jun 26, 2017 at 09:07:12PM +0300, Topi Pohjolainen wrote:
> CID: 1413018
> Signed-off-by: Topi Pohjolainen
> ---
> src/intel/vulkan/anv_device.c | 1 +
> 1 file changed, 1 insertion(+)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv
On Thu, Jun 22, 2017 at 10:32:42AM -0700, Jason Ekstrand wrote:
> On Thu, Jun 22, 2017 at 10:02 AM, Nanley Chery
> wrote:
>
> > On Thu, Jun 22, 2017 at 09:59:44AM -0700, Nanley Chery wrote:
> > > On Thu, Jun 22, 2017 at 09:55:50AM -0700, Nanley Chery wrote:
> > >
This will be used to load and store clear values from surface state
objects.
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.c | 9 +
src/intel/isl/isl.h | 4
2 files changed, 13 insertions(+)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index bbbdb19df2..26e1676d61
v2: Rewrite functions.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 93 ++
1 file changed, 84 insertions(+), 9 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index 53c58ca5b3
A quick test shows that this change still improves frame rates on a
Dota 2 benchmark by about 3% at 1080p.
Cc: Jason Ekstrand
Nanley Chery (16):
intel/isl: Add surface state clear value information
anv/image: Append CCS/MCS with a fast-clear state buffer
anv/cmd_buffer: Initialize the
v2: Don't pass in the command buffer (Jason Ekstrand).
v3: Remove an incorrect assertion and an if condition for gen7.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 31 +++
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git
We'll be performing a GPU memcpy in more places to copy small amounts of
data. Add an alternate function that thrashes less state.
v2:
- Make a new function (Jason Ekstrand).
- Move the #define into the function.
v3:
- Update the function name (Jason).
- Update comments.
Signed-off-by: N
v2: Remove ::first_subpass_layout assertion (Jason Ekstrand).
v3: Allow some fast clears in the GENERAL layout.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c| 22 ++
src/intel/vulkan/anv_private.h | 2 ++
src/intel/vulkan/genX_cmd_buffer.c | 17
v2: Expound on comment for the pipe controls (Jason Ekstrand).
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 4 +-
src/intel/vulkan/genX_cmd_buffer.c | 183 +
2 files changed, 167 insertions(+), 20 deletions(-)
diff --git a/src/intel
v2: Update comments, function signatures, and add assertions.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 78 ++
src/intel/vulkan/anv_private.h | 12 +++
2 files changed, 90 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c
The next patch enables the use of CCS_D even when the color attachment
will not be fast-cleared. Catch the gen7 case early to simplify the
changes required.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index d71c3c92c9..62a2f22782 100644
--- a/src/intel
With an earlier patch from this series, resolves are additionally
performed on layout transitions. Remove the now unnecessary implicit
resolves within render passes.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 150 ++---
src/intel/vulkan
For readability, bring the assignment of CCS closer to the assignment of
NONE and MCS.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 62 ++
1 file changed, 30 insertions(+), 32 deletions(-)
diff --git a/src/intel/vulkan
v2: Rewrite functions, change location of synchronization.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 114 +
1 file changed, 114 insertions(+)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
Use the performance warning infrastructure to provide helpful
information when testing applications.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/genX_cmd_buffer.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src
Signed-off-by: Nanley Chery
---
src/intel/blorp/blorp.h | 3 +++
src/intel/blorp/blorp_genX_exec.h | 3 +++
2 files changed, 6 insertions(+)
diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blorp.h
index d5226c2248..1e96fb42b0 100644
--- a/src/intel/blorp/blorp.h
+++ b/src/intel
Image layouts only let us know that an image *may* be fast-cleared. For
this reason we can end up with redundant resolves. Testing has shown
that such resolves can measurably hurt performance and that predicating
them can avoid the penalty.
Signed-off-by: Nanley Chery
---
src/intel/vulkan
The lifespan of the fast-clear data will surpass the render pass scope.
We need CCS_D to be enabled in order to invalidate blocks previously
marked as cleared and to sample cleared data correctly.
v2: Avoid refactoring.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_blorp.c | 5
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index c84fc8ddea..df505ce8f0 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
://bugzilla.freedesktop.org/show_bug.cgi?id=101677
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index bbbdb19df2..ba56d86c17 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -1699,7 +1699,7
On Thu, Jul 06, 2017 at 01:11:27PM -0700, Nanley Chery wrote:
> This reverts commit 8aaa13467dc289d35dc7900ab9fab9a7689c4178, which was
> based on an incorrect assumption. Unlike the restriction placed on image
> views in the Vulkan API, OpenGL allows you to render to texture views
> w
On Mon, Jul 10, 2017 at 09:18:56AM -0700, Jason Ekstrand wrote:
> On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote:
>
> > v2: Rewrite functions.
> >
> > Signed-off-by: Nanley Chery
> > ---
> > src/intel/vulkan/genX_cmd_buffer.c | 93 +++
On Mon, Jul 10, 2017 at 09:28:05AM -0700, Jason Ekstrand wrote:
> On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote:
>
> > v2: Remove ::first_subpass_layout assertion (Jason Ekstrand).
> > v3: Allow some fast clears in the GENERAL layout.
> >
> > Signed-off-by:
On Mon, Jul 10, 2017 at 09:35:25AM -0700, Jason Ekstrand wrote:
> On Wed, Jun 28, 2017 at 2:14 PM, Nanley Chery wrote:
>
> > We'll be performing a GPU memcpy in more places to copy small amounts of
> > data. Add an alternate function that thrashes less state.
>
801 - 900 of 1409 matches
Mail list logo
