On Tue, Sep 27, 2016 at 11:00:14AM -0700, Chad Versace wrote:
> On Mon 26 Sep 2016, Nanley Chery wrote:
> > Create a function that performs one of three HiZ operations -
> > depth/stencil clears, HiZ resolve, and depth resolves.
> >
> > Signed-off-by: Nanley Chery
&g
On Mon, Oct 03, 2016 at 05:23:27PM -0700, Jason Ekstrand wrote:
> On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote:
>
> > Create a function that performs one of three HiZ operations -
> > depth/stencil clears, HiZ resolve, and depth resolves.
> >
> &g
On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote:
> On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand wrote:
>
> > On Tue, Sep 27, 2016 at 3:23 PM, Nanley Chery
> > wrote:
> >
> >> On Tue, Sep 27, 2016 at 03:12:17PM -0700, Chad Versace wrote:
> &
On Mon, Oct 03, 2016 at 04:27:53PM -0700, Jason Ekstrand wrote:
> On Mon, Sep 26, 2016 at 5:10 PM, Nanley Chery wrote:
>
> > From: Chad Versace
> >
> > Nanley Chery:
> > (rebase)
> > - Use isl_surf_get_hiz_surf()
> > (amend)
> > - Only a
ged, 96 insertions(+), 130 deletions(-)
>
This patch is
Reviewed-by: Nanley Chery
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index cb61070..f149f84 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulkan/anv_blorp.c
> @@ -48
On Tue, Oct 04, 2016 at 03:55:13PM -0700, Chad Versace wrote:
> On Tue 04 Oct 2016, Nanley Chery wrote:
> > On Mon, Oct 03, 2016 at 06:21:30PM -0700, Jason Ekstrand wrote:
> > > On Mon, Oct 3, 2016 at 6:11 PM, Jason Ekstrand
> > > wrote:
> > >
> > &
On Tue, Sep 27, 2016 at 02:47:22PM -0700, Nanley Chery wrote:
> On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote:
> > On Mon 26 Sep 2016, Nanley Chery wrote:
> > > From: Nanley Chery
> > >
> > > Provides an FPS increase of ~30% on the Sascha tr
On Wed, Oct 05, 2016 at 04:30:51PM -0700, Nanley Chery wrote:
> On Tue, Sep 27, 2016 at 02:47:22PM -0700, Nanley Chery wrote:
> > On Tue, Sep 27, 2016 at 11:00:21AM -0700, Chad Versace wrote:
> > > On Mon 26 Sep 2016, Nanley Chery wrote:
> > > > From: Nanley Chery
&g
On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote:
> Initially, we had intended set_subpass to be an interesting function that
> did whatever (presumably a lot) setup we needed for a subpass. In reality,
> it just sets a pointer and a dirty bit and then emits depth and stencil
> state
On Thu, Oct 06, 2016 at 12:35:53PM -0700, Jason Ekstrand wrote:
> On Thu, Oct 6, 2016 at 12:30 PM, Nanley Chery wrote:
>
> > On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote:
> > > Initially, we had intended set_subpass to be an interesting function th
: Add func anv_image_has_hiz()
anv: Allocate hiz surface
anv/cmd_buffer: Enable rendering to HiZ
Jason Ekstrand (2):
anv: Move BindImageMemory to anv_image.c
anv/image: Memset hiz surfaces to 0 when binding memory
Nanley Chery (4):
isl: Correct a comment in the isl_format enum
anv
From: Jason Ekstrand
Signed-off-by: Nanley Chery
Reviewed-by: Chad Versace
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_device.c | 20
src/intel/vulkan/anv_image.c | 20
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src
From: Chad Versace
Nanley Chery:
(rebase)
- Use isl_surf_get_hiz_surf()
(amend)
- Only add a HiZ surface onto a depth/stencil attachment
- Add comment above HiZ surface addition
- Hide HiZ behind INTEL_VK_HIZ prior to BDW
- Disable HiZ for untested cases
- Remove DISABLE_AUX_BIT instead of
Create a function that performs one of three HiZ operations -
depth/stencil clears, HiZ resolve, and depth resolves.
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand (v2)
---
v3. Change do_hz to emit_hz (Chad)
Always set XMin YMin explicitly (Chad)
Add anv_finishme for gen7
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
index 8fac370..9ac63eb 100644
--- a/src/intel/vulkan/TODO
+++ b/src/intel/vulkan/TODO
@@ -19,7
From: Chad Versace
Unused.
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_private.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 4fa403f..dfcedd1 100644
--- a/src/intel/vulkan
From: Jason Ekstrand
Nanley Chery (amend):
- Change memset value from 0xff to 0 (a defined value for HiZ).
Signed-off-by: Nanley Chery
Reviewed-by: Chad Versace
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_image.c | 31 ++-
1 file changed, 30 insertions
Provides an FPS increase of ~30% on the Sascha triangle and multisampling
demos.
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand (v2)
---
v3. Emit required clear_params packet (Chad)
Share clear_params code path IVB+ (Jason)
src/intel/vulkan/anv_pass.c| 13
HiZ is not a color surface, but an auxiliary depth surface.
Signed-off-by: Nanley Chery
Reviewed-by: Chad Versace
Reviewed-by: Jason Ekstrand
---
src/intel/isl/isl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index 29fb3d0
From: Chad Versace
Nanley Chery:
(rebase)
- Resolve conflicts with new anv_batch_emit macro
(amend)
- Handle a QPitch TODO
- Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems
- Only use HiZ for single-subpass renderpasses
- Emit the HiZ instruction before the stencil instruction to follow
From: Chad Versace
Signed-off-by: Nanley Chery
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_private.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index dfcedd1..fd886bf 100644
--- a/src/intel/vulkan
On Sun, Sep 25, 2016 at 09:59:02AM -0700, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
> ---
> src/intel/vulkan/anv_image.c | 16
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index f6e8
On Fri, Oct 07, 2016 at 09:41:14PM -0700, Jason Ekstrand wrote:
> If we don't, we can end up with corruption in the portion of the depth
> buffer that lies outside the render area when we do a HiZ resolve at the
> end. The only reason we weren't seeing this before was that all of the
> meta-based
This behavior differs from what's described in the PRMs and was
observed by analyzing CTS test results.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/gen8_cmd_buffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/gen8_cmd_buffer.c
b/src/intel/v
This matches the HW docs and specifies what the variable is actually
concerned with.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/gen8_cmd_buffer.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/gen8_cmd_buffer.c
b/src/intel/vulkan
Move the assignment to a less surprising location.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/gen8_cmd_buffer.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/gen8_cmd_buffer.c
b/src/intel/vulkan/gen8_cmd_buffer.c
index 97a035b
Delay the assignment of some variables until we know they will be used.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/gen8_cmd_buffer.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/src/intel/vulkan/gen8_cmd_buffer.c
b/src/intel
The HZ sequence modifies less state than the meta path and requires
less CPU time to be generated.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/gen8_cmd_buffer.c | 63 ++
1 file changed, 43 insertions(+), 20 deletions(-)
diff --git a/src/intel/vulkan
patch, I stated that I don't think the right fix is within this emit
function.
-Nanley
> On Oct 10, 2016 3:33 PM, "Nanley Chery" wrote:
>
> > Delay the assignment of some variables until we know they will be used.
> >
> > Signed-off-by: Nanley Chery
>
On Mon, Oct 10, 2016 at 06:00:49PM -0700, Jason Ekstrand wrote:
> On Mon, Oct 10, 2016 at 2:23 PM, Nanley Chery wrote:
>
> > On Fri, Oct 07, 2016 at 09:41:14PM -0700, Jason Ekstrand wrote:
> > > If we don't, we can end up with corruption in the portion of the depth
>
On Tue, Oct 11, 2016 at 06:55:53PM -0700, Jason Ekstrand wrote:
> On Tue, Oct 11, 2016 at 6:16 PM, Nanley Chery wrote:
>
> > On Mon, Oct 10, 2016 at 06:00:49PM -0700, Jason Ekstrand wrote:
> > > On Mon, Oct 10, 2016 at 2:23 PM, Nanley Chery
> > wrote:
> > >
&
On Mon, Oct 10, 2016 at 04:38:12PM -0700, Nanley Chery wrote:
> On Mon, Oct 10, 2016 at 04:01:29PM -0700, Jason Ekstrand wrote:
> > My patch to fix partial draws makes us use full_surface_op for HiZ resolves
> > as well so this patch (and maybe the next one?) are probably moot.
>
On Wed, Aug 03, 2016 at 01:06:10PM -0700, Jason Ekstrand wrote:
> We can't actually clear these images normally because we can't render to
> them. Instead, we have to manually unpack the rgb9e5 color value on the
> CPU and clear it as R32_UINT. We still have a bit of work to do to clear
> non-pow
r/nir_builder.h"
>
> +#include "gallium/auxiliary/util/u_format_rgb9e5.h"
I encountered a build failure on this patch. Please change the include to:
#include "util/format_rgb9e5.h"
to fix it.
With the above fixed, the spelling correction, and a mention of the
pass
On Tue, Aug 09, 2016 at 04:52:12PM -0700, Sirisha Gandikota wrote:
> From: Sirisha Gandikota
>
> This is a patch series for adding the aubinator tool to the codebase.
>
> The aubinator tool is designed to help the driver developers to debug
> the driver functionality by decoding the data in the
59,8 @@ anv_meta_blit2d_w_tiled_dst(struct anv_cmd_buffer
> *cmd_buffer,
>};
>
>struct blit2d_dst_temps dst_temps;
> - blit2d_bind_dst(cmd_buffer, &dst_Y, offset, xmax_Y, ymax_Y,
> &dst_temps);
> + blit2d_bind_dst(cmd_buffer, &dst_Y, o
On Wed, Aug 10, 2016 at 10:12:17AM -0700, Nanley Chery wrote:
> On Tue, Aug 02, 2016 at 10:00:29AM -0700, Jason Ekstrand wrote:
> > Signed-off-by: Jasosn Ekstrand
> > Cc: "12.0"
I just noticed a bug in this patch. With that fixed the Reviewed-by
will hold. P
On Wed, Aug 10, 2016 at 09:43:24AM -0700, Nanley Chery wrote:
> On Tue, Aug 09, 2016 at 04:52:12PM -0700, Sirisha Gandikota wrote:
> > From: Sirisha Gandikota
> >
> > This is a patch series for adding the aubinator tool to the codebase.
> >
> > The aubinator to
On Tue, Jul 26, 2016 at 10:04:22PM -0700, Jason Ekstrand wrote:
> We have implicitly been not advertising these formats since we had them
> turned off in the format capabilities table. We are about to update that
> table and this prevents a change in behavior. The only change in behavior
> create
On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote:
> There were a lot of formats where support was added on Haswell or later but
> we never updated the format table.
> ---
> src/intel/isl/isl_format.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletion
On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote:
> There were a lot of formats where support was added on Haswell or later but
> we never updated the format table.
> ---
> src/intel/isl/isl_format.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletion
On Tue, Jul 26, 2016 at 10:04:21PM -0700, Jason Ekstrand wrote:
> The real objective of this series is patch 5 which prevents us from
> accidentally creating a surface state with a format unsupported by the
> hardware. This turns some of the new Vulkan CTS tests from a hang into an
> informative c
On Thu, Aug 11, 2016 at 04:23:51PM -0700, Jason Ekstrand wrote:
> On Thu, Aug 11, 2016 at 11:26 AM, Nanley Chery
> wrote:
>
> > On Tue, Jul 26, 2016 at 10:04:22PM -0700, Jason Ekstrand wrote:
> > > We have implicitly been not advertising these formats since we had them
On Thu, Aug 11, 2016 at 04:22:04PM -0700, Jason Ekstrand wrote:
> On Thu, Aug 11, 2016 at 12:55 PM, Nanley Chery
> wrote:
>
> > On Tue, Jul 26, 2016 at 10:04:21PM -0700, Jason Ekstrand wrote:
> > > The real objective of this series is patch 5 which prevents us from
>
On Thu, Aug 11, 2016 at 11:34:38AM -0700, Nanley Chery wrote:
> On Tue, Jul 26, 2016 at 10:04:24PM -0700, Jason Ekstrand wrote:
> > There were a lot of formats where support was added on Haswell or later but
> > we never updated the format table.
> > ---
> > src/
es, the hangs in the latest CTS are gone (they came
> from trying to clear an unsupported image format).
With the spelling correction and the removal of the filtering feature for
integer formats, patches 1-3 are:
Reviewed-by: Nanley Chery
>
> Jason Ekstrand (5):
> i965/surface_f
f-by: Jason Ekstrand
This patch is
Reviewed-by: Nanley Chery
> ---
> src/intel/isl/isl_format.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c
> index bced4ff..8507cc5 100
rsion >= 40 is if
> ctx->Extensions.ARB_shader_subroutine is set.
>
> Signed-off-by: Ian Romanick
This patch is
Reviewed-by: Nanley Chery
> ---
> src/mesa/main/context.h | 10 --
> src/mesa/main/program_resource.c | 16
> src/mesa/
3DSTATE_CLEAR_PARAMS.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_pass.c| 11 +++
src/intel/vulkan/gen8_cmd_buffer.c | 6 ++
src/intel/vulkan/genX_cmd_buffer.c | 4 +---
3 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/anv_pass.c b/src/intel
From: Chad Versace
Nanley Chery:
(rebase)
- Resolve conflicts with new anv_batch_emit macro
(amend)
- Remove wip! tag and handle a QPitch TODO
- Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems
- Only use HiZ for single-subpass renderpasses
- Emit the HiZ instruction before the stencil
Ekstrand (3):
anv: Move BindImageMemory to anv_image.c
anv/image: Memset hiz surfaces to 0 when binding memory
anv/cmd_buffer: Add code for performing HZ operations
Nanley Chery (5):
isl: Correct a comment in the isl_format enum
isl: Update isl_surf_get_hiz_surf()
isl: Make MSAA pixel scali
From: Chad Versace
Unused.
Nanley Chery (amend):
- Remove wip! tag
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_private.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index f24020c..8964e3f 100644
--- a/src
From: Chad Versace
Nanley Chery (amend):
- Remove wip! tag
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_private.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 8964e3f..5718a19 100644
--- a/src
Modify extents and dimensions to match the PRMs more closely. Along with
being able to create the correct 3D surface this enables us to avoid working
with multisampled compressed textures.
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.c | 39 +--
1 file
From: Jason Ekstrand
Nanley Chery (amend):
- Change memset value from 0xff to 0 (a defined value for HiZ).
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_image.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_image.c b/src
From: Jason Ekstrand
Nanley Chery:
(rebase)
- Resolve conflicts with the new anv_batch_emit macro
(amend)
- Update commit title
- Combine all HZ operations into one function
- Add code for performing HiZ resolve operations
- Add proper stencil and multisampling support
- Set the proper
From: Chad Versace
Nanley Chery:
(rebase)
- Use isl_surf_get_hiz_surf()
(amend)
- Only add a HiZ surface onto a depth/stencil attachment
- Add comment above HiZ surface addition
- Hide HiZ behind INTEL_VK_HIZ prior to BDW
- Remove DISABLE_AUX_BIT instead of preventing it from being added
Signed-off-by: Nanley Chery
---
src/intel/vulkan/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO
index 8fac370..ef2408d 100644
--- a/src/intel/vulkan/TODO
+++ b/src/intel/vulkan/TODO
@@ -19,7 +19,7 @@ Code sharing with GL
From: Jason Ekstrand
Signed-off-by: Nanley Chery
---
src/intel/vulkan/anv_device.c | 20
src/intel/vulkan/anv_image.c | 20
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
This will be used in the next commit.
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.c | 2 +-
src/intel/isl/isl.h | 4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 1664dbf..811760a 100644
--- a/src/intel/isl/isl.c
+++ b
HiZ is not a color surface, but an auxiliary depth surface.
Signed-off-by: Nanley Chery
---
src/intel/isl/isl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index 5e56f28..507b342 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel
On Wed, Aug 31, 2016 at 08:29:55PM -0700, Nanley Chery wrote:
> From: Jason Ekstrand
>
> Nanley Chery:
> (rebase)
> - Resolve conflicts with the new anv_batch_emit macro
> (amend)
> - Update commit title
> - Combine all HZ operations into one function
> - Add code
o blorp (and we could use it from GL) but that's a bit more work and
> > I wanted to get this sent out earlier rather than later.
> >
> > For review, I would recommend that Topi review the first 19 or so and
> > Nanley review patch 26+. For 20-25, I'm not sure.
On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/blorp/blorp.h | 10
> src/intel/blorp/blorp_blit.c | 133
> +++
> 2 files changed, 143 insertions(+)
>
> diff --git a/src/intel/blorp/blorp.h b/src/intel/blorp/blo
On Tue, Sep 06, 2016 at 05:02:55PM -0700, Jason Ekstrand wrote:
> On Tue, Sep 6, 2016 at 4:12 PM, Nanley Chery wrote:
>
> > On Wed, Aug 31, 2016 at 02:22:33PM -0700, Jason Ekstrand wrote:
> > > ---
> > > src/intel/blorp/blorp.h | 10
> > &
On Wed, Sep 07, 2016 at 10:26:25AM -0700, Jason Ekstrand wrote:
> On Wed, Sep 7, 2016 at 9:50 AM, Jason Ekstrand wrote:
>
> > On Wed, Sep 7, 2016 at 9:36 AM, Nanley Chery
> > wrote:
> >
> >> On Tue, Sep 06, 2016 at 05:02:55PM -0700, Jason Ekstrand wrote:
>
On Fri, Sep 02, 2016 at 11:42:24AM -0700, Chad Versace wrote:
> On Thu 01 Sep 2016, Jason Ekstrand wrote:
> > On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
> >
> > From: Chad Versace
> >
> > Nanley Chery (amend):
> > - Remove wip!
On Fri, Sep 02, 2016 at 03:50:41PM -0700, Jason Ekstrand wrote:
> This series does a few cleanups to ISL so that it can actually handle
> multisampled HiZ correctly. When Chad and I first discussed HiZ, we
> thought it would all work out easy as ISL already had all the required
> code. We were co
On Thu, Sep 01, 2016 at 04:12:23PM -0700, Jason Ekstrand wrote:
> On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
>
> > From: Jason Ekstrand
> >
> > Nanley Chery (amend):
> > - Change memset value from 0xff to 0 (a defined value for HiZ).
>
Should the title the say needed instead of unneeded?
- Nanley
On Wed, Sep 07, 2016 at 08:29:30PM -0700, Chad Versace wrote:
> The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so.
> But it's needed only if HAVE_PLATFORM_X11.
>
> Fixes build of libvulkan_intel.so on Chromium OS,
ct coordinates in CmdCopyImage,"
you replace extent.depth with pRegions[r].extent.depth. I think it also makes
sense to change the assignment of src_base_layer and dest_base_layer with the
offsets straight from user when we know the image type is VK_IMAGE_TYPE_3D.
When the type is 3
On Wed, Aug 31, 2016 at 02:22:49PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/Makefile.sources | 1 -
> src/intel/vulkan/anv_blorp.c | 184
> ++
> src/intel/vulkan/anv_meta_copy.c | 180 -
> 3 files changed
On Fri, Sep 09, 2016 at 07:25:46PM -0700, Jason Ekstrand wrote:
> On Fri, Sep 9, 2016 at 5:47 PM, Nanley Chery wrote:
>
> > On Wed, Aug 31, 2016 at 02:22:49PM -0700, Jason Ekstrand wrote:
> > > ---
> > > src/intel/vulkan/Makefile.sources | 1 -
> > >
> 1 file changed, 24 insertions(+), 24 deletions(-)
Perhaps we should also mention that a bug is fixed here? Regardless,
with patch 30 fixed as discussed, patches 30 and 30.1 are,
Reviewed-by: Nanley Chery
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
&
On Wed, Aug 31, 2016 at 02:22:46PM -0700, Jason Ekstrand wrote:
> ---
> src/intel/vulkan/anv_blorp.c | 134
> +++
> src/intel/vulkan/anv_meta_copy.c | 16 -
> 2 files changed, 134 insertions(+), 16 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_bl
On Mon, Sep 12, 2016 at 12:45:51PM -0700, Jason Ekstrand wrote:
> On Mon, Sep 12, 2016 at 12:30 PM, Nanley Chery
> wrote:
>
> > On Wed, Aug 31, 2016 at 02:22:46PM -0700, Jason Ekstrand wrote:
> > > ---
> > > src/i
On Tue, Sep 06, 2016 at 10:20:02AM -0700, Nanley Chery wrote:
> On Mon, Sep 05, 2016 at 09:38:59AM -0700, Jason Ekstrand wrote:
> > Everything is now reviewed. I've also sent two additional patches blorp
> > which, when placed prior to the anv patches, make the series
>
This behavior differs from what's described in the PRMs and was
observed by analyzing CTS test results.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/gen8_cmd_buffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/gen8_cmd_buffer.c
b/src/intel/v
The HZ sequence modifies less state than the blorp path and requires
less CPU time to generate the necessary packets.
Signed-off-by: Nanley Chery
---
v2: Don't combine the depth alignment if statements
src/intel/vulkan/gen8_cmd_buffer.c | 46 +++---
1
Move the assignment to a less surprising location.
Signed-off-by: Nanley Chery
---
src/intel/vulkan/gen8_cmd_buffer.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/gen8_cmd_buffer.c
b/src/intel/vulkan/gen8_cmd_buffer.c
index 930b99e
tarted and set
> up most of the infastructure we will need for both full compression and
> fast-clears.
>
> I have no perf numbers yet.
>
> Cc: Chad Versace
> Cc: Topi Pohjolainen
> Cc: Nanley Chery
Some of these patches no longer rebase without conflict. Are you planning
With the isl_format_supports* helpers, we can now conveniently
report support for this format on Cherry View.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92925
Signed-off-by: Nanley Chery
---
src/intel/isl/isl_format.c | 70 +++---
1 file
orrect.
> Reviewed-by: Jason Ekstrand
>
Thanks!
> Helper functions are so much better...
>
Indeed.
> On Fri, Oct 21, 2016 at 3:50 PM, Nanley Chery wrote:
>
> > With the isl_format_supports* helpers, we can now conveniently
> > report support for
While analyzing the atom emission system, I noticed some unnecessary
atoms. This series removes these atoms to avoid paying the cost of
visiting them, and simplifies the codebase a bit.
Nanley Chery (2):
i965: Program 3DSTATE_AA_LINE_PARAMETERS in upload_invariant_state
i965: Move
This packet is non-pipelined and doesn't ever change across emissions.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/brw_misc_state.c | 41 +++-
src/mesa/drivers/dri/i965/brw_state.h| 1 -
src/mesa/drivers/dri/i965/brw_state_upload.c | 4 -
3DSTATE_WM_CHROMAKEY isn't programmed anywhere else.
3DSTATE_WM_HZ_OP is programmed, then cleared by blorp during a
HZ op, so repeatedly clearing it after every blorp execution is
redundant.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/Makefile.sources | 1 -
src/mesa/dr
On Thu, Oct 06, 2016 at 03:21:54PM -0700, Nanley Chery wrote:
> Provides an FPS increase of ~30% on the Sascha triangle and multisampling
> demos.
After attempting to enable fast depth clears in more areas, I noticed
something possibly worth sharing. Most of the performance gain from this
On Fri, Oct 28, 2016 at 02:17:04AM -0700, Jason Ekstrand wrote:
> Otherwise, we'll try to clear it the first time it's used as a draw so if
> you do some multisampled rendering, resolve to an attachment, and then draw
> on top of the single-sampled attachment, we might accidentally clear it.
>
> S
On Fri, Oct 28, 2016 at 02:17:05AM -0700, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
> ---
> src/intel/vulkan/anv_image.c | 16
> src/intel/vulkan/anv_private.h | 5 +++--
> src/intel/vulkan/genX_cmd_buffer.c | 10 +-
> 3 files changed, 16 insertions
On Fri, Oct 28, 2016 at 03:28:27PM -0700, Jason Ekstrand wrote:
> On Fri, Oct 28, 2016 at 3:06 PM, Nanley Chery wrote:
>
> > On Fri, Oct 28, 2016 at 02:17:05AM -0700, Jason Ekstrand wrote:
> > > Signed-off-by: Jason Ekstrand
> > > ---
> > >
On Mon, Oct 31, 2016 at 01:16:51PM -0700, Anuj Phogat wrote:
> On Wed, Oct 26, 2016 at 11:23 AM, Nanley Chery wrote:
> > 3DSTATE_WM_CHROMAKEY isn't programmed anywhere else.
> > 3DSTATE_WM_HZ_OP is programmed, then cleared by blorp during a
> > HZ op, so repeatedly cle
On Wed, Nov 02, 2016 at 01:37:07PM -0700, Jason Ekstrand wrote:
> Series is
>
> Reviewed-by: Jason Ekstrand
>
Thanks!
> On Thu, Sep 22, 2016 at 5:19 PM, Nanley Chery wrote:
>
> > This series prevents invalid compressed textures from being created in
> > the V
Such a surface is not possible on our hardware. Without this change, ISL
surface creation would fail with the next patch.
Signed-off-by: Nanley Chery
---
This series requires the following extra patch, seemingly due to the
recent changes with blorp.
src/intel/vulkan/anv_blorp.c | 16
orp_copy anyway.
>
Yeah, since blorp already handles compressed formats in general, I just
went for the simplest approach.
> On Nov 2, 2016 4:56 PM, "Nanley Chery" wrote:
>
> > Such a surface is not possible on our hardware. Without this change, ISL
> > surface creati
to copy the block
> of surface states from the primary into the secondary right before
> executing the secondary.
>
> It's kind of a crazy scheme but I like the end result quite a bit.
>
> Cc: Kristian Høgsberg Kristensen
> Cc: Chad Versace
> Cc: Nanley Cher
On Mon, Nov 07, 2016 at 05:28:12PM -0800, Jason Ekstrand wrote:
> Signed-off-by: Jason Ekstrand
> Cc: "12.0 13.0"
> ---
> src/intel/vulkan/anv_device.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 5393144..80
On Tue, Nov 08, 2016 at 01:50:01PM -0800, Jason Ekstrand wrote:
> On Tue, Nov 8, 2016 at 1:46 PM, Nanley Chery wrote:
>
> > On Mon, Nov 07, 2016 at 05:28:12PM -0800, Jason Ekstrand wrote:
> > > Signed-off-by: Jason Ekstrand
> > > Cc: "12.0 13.0"
> &
On Tue, Nov 08, 2016 at 02:01:17PM -0800, Nanley Chery wrote:
> On Tue, Nov 08, 2016 at 01:50:01PM -0800, Jason Ekstrand wrote:
> > On Tue, Nov 8, 2016 at 1:46 PM, Nanley Chery wrote:
> >
> > > On Mon, Nov 07, 2016 at 05:28:12PM -0800, Jason Ekstrand wrote:
> > >
On Tue, Nov 08, 2016 at 01:52:15PM -0800, Jason Ekstrand wrote:
> On Tue, Nov 8, 2016 at 1:36 PM, Nanley Chery wrote:
>
> > On Sat, Oct 22, 2016 at 10:50:31AM -0700, Jason Ekstrand wrote:
> > > This series does some fairly major surgery on color attachment surface
> >
On Sat, Oct 22, 2016 at 10:50:37AM -0700, Jason Ekstrand wrote:
> This commit moves the allocation and filling out of surface state from
> CreateImageView time to BeginRenderPass time. Instead of allocating the
> render target surface state as part of the image view, we allocate it in
> the comman
301 - 400 of 1409 matches
Mail list logo
