From: Nanley Chery
On Gen9+, vertical and horizontal alignment values for compressed textures are
equal to the pre-Gen9 value squared. Each miplevel must be aligned to this
value.
Signed-off-by: Nanley Chery
---
This fixes an FXT1 Piglit test regression and shows no failures on Jenkins
Hey Neil,
While this patch does fix FXT1, it also regresses 21 other Piglit tests on SKL.
- Nanley
On Thu, Jun 11, 2015 at 8:59 AM, Neil Roberts wrote:
> This function was trying to align the width and height to a multiple
> of the block size for compressed textures. It was using align_w/h as a
results from the first file with any that appear in the
> second file. Once I do that then there are no regressions and only the
> two FXT1 tests appear in the fixes.
>
> It might be interesting to see if you can run some of the regressing
> tests by hand after a reboot to s
On Thu, Jun 11, 2015 at 8:56 AM, Neil Roberts wrote:
> Hi Nanley,
>
> Could you explain the reasoning behind this patch? I can't find any
> mention of needing to align to the square of the block size in the docs.
>
Sure. I came to the conclusion that alignment must be squared due to 3
parts of the
On Thu, Jun 11, 2015 at 9:04 AM, Ben Widawsky wrote:
> On Wed, Jun 10, 2015 at 05:01:44PM -0700, Nanley Chery wrote:
>> From: Nanley Chery
>>
>> On Gen9+, vertical and horizontal alignment values for compressed textures
>> are
>> equal to the pre-Gen9 val
My test results haven't been consistent and some of the failures don't seem
to match what's going on in this patch. I'll have to look into improving my
testing methods on SKL, but that's a separate issue. This patch makes sense.
>>>
>>> src/mesa/drivers/dri/i965/brw_tex_layout.c | 20
>>> 1 file changed, 8 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
>>> b/src/mesa/drivers/dri/i965/brw_tex_layout.c
>>> index 312a887..dffc699 100644
>>> --- a/src/mesa/
Although most of the patch is incorrect, the following change is still
necessary isn't it?
if (mt->compressed) {
mip1_width = ALIGN(minify(mt->physical_width0, 1), mt->align_w) +
- ALIGN(minify(mt->physical_width0, 2), bw);
+ ALIGN(minify(mt->physical_widt
#x27;t exempt LOD-0
from being aligned by the alignment term, right?
Thanks,
Nanley
On Mon, Jun 15, 2015 at 10:45 AM, Neil Roberts wrote:
> Nanley Chery writes:
>
>> Although most of the patch is incorrect, the following change is still
>> necessary isn't it?
>
I agree. This will be fixed in the next revision.
On Tue, Jun 9, 2015 at 12:03 PM, Ian Romanick wrote:
> Should this patch be last? It looks like later patches fix bugs.
>
> On 06/01/2015 10:13 AM, Nanley Chery wrote:
>> From: Nanley Chery
>>
>> v2: remove O
intel_horizontal_texture_alignment_unit are called from within the
top-level (and only within it), it would be assumed that the
references also apply to these functions.
On Tue, Jun 9, 2015 at 12:13 PM, Ian Romanick wrote:
> On 06/01/2015 10:13 AM, Nanley Chery wrote:
>> From: Nan
From: Nanley Chery
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
index ac69fab..e7363b5 100644
--- a/src/mesa/main
From: Nanley Chery
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
src/mesa/main/texcompress.c | 22 ++
src/mesa/main/teximage.c| 28
2 files changed, 50 insertions(+)
diff --git a/src/mesa/main/texcompress.c b/src/mesa/main
From: Nanley Chery
v2: correct the spelling of the sRGB variants.
remove spaces around "=" when setting the enum value.
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
.../glapi/gen/KHR_texture_compression_astc.xml | 40 ++
src/mapi/glapi/gen/M
From: Nanley Chery
In agreement with the coding style, functions that aren't directly visible
to the GL API should prefer the use of bool over GLboolean.
Suggested-by: Ian Romanick
Signed-off-by: Nanley Chery
---
src/mesa/main/teximage.c | 6 +++---
1 file changed, 3 insertions(
From: Nanley Chery
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
src/mesa/main/texcompress.c | 114
1 file changed, 114 insertions(+)
diff --git a/src/mesa/main/texcompress.c b/src/mesa/main/texcompress.c
index 1654fc6..203a065 100644
From: Nanley Chery
v2: alphabetize the extensions.
remove OES ASTC extension.
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 2 ++
src/mesa/main/mtypes.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/src/mesa/main/extensions.c b/src
From: Nanley Chery
v2: remove extra newline.
v3: use bool instead of GLboolean.
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
src/mesa/main/format_info.py | 2 ++
src/mesa/main/formats.c | 28
2 files changed, 6 insertions(+), 24 deletions
From: Nanley Chery
This patch series enables support for the KHR_texture_compression_astc_{ldr,hdr}
extensions on Skylake machines. This revision includes developer suggestions and
fixes rendering issues on previously untested systems. The sRGB issues were
fixed and determined to be unrelated to
From: Nanley Chery
Includes definition of the formats, updates to functions likely to be used, as
well as changes necessary for compilation.
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
src/mesa/main/format_info.py | 3 +
src/mesa/main/formats.c | 130
From: Nanley Chery
In agreement with commit 4ab8d59a23, vertical alignment values are equal to
four times the block height on Gen9+.
v2: add newlines to separate declarations, statments, and comments.
Reviewed-by: Anuj Phogat
Reviewed-by: Neil Roberts
Signed-off-by: Nanley Chery
---
src
From: Nanley Chery
Remove redundant checks and comments by grouping our calculations for
align_w and align_h wherever possible.
v2: reintroduce brw.
don't include functional changes.
don't adjust function parameters or create a new function.
Signed-off-by: Nanley Chery
---
From: Nanley Chery
ALIGN and ROUND_DOWN_TO both require that the alignment value passed
into the macro be a power of two in the comments. Using software assertions
verifies this to be the case.
v2: use static inline functions instead of gcc-specific statement expressions.
Signed-off-by: Nanley
From: Nanley Chery
This is necesary to initialize the gl_texture_image struct.
From the KHR_texture_compression_astc_ldr spec:
"Added to Section 3.8.6, Compressed Texture Images
Add the tokens specified above to Table 3.16, Compressed Internal Formats.
In all cases, the base int
From: Nanley Chery
v2: remove OES ASTC extension reference.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/intel_extensions.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c
b/src/mesa/drivers/dri/i965/intel_extensions.c
index
From: Nanley Chery
Aligning with a non-power-of-two number is a general task that can be used in
various places. This commit is required for the next one.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/intel_upload.c | 6 --
src/mesa/main/macros.h | 6
From: Nanley Chery
This patch creates a new macro, FETCH_COMPRESSED - similar in nature
to the other FETCH_* macros. This reduces repetition in the code that
deals with compressed textures.
Reviewed-by: Anuj Phogat
Signed-off-by: Nanley Chery
---
src/mesa/swrast/s_texfetch.c | 239
From: Nanley Chery
ALIGN is changed to ALIGN_NPOT because alignment values are sometimes not
powers of two when working with ASTC.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/brw_tex_layout.c| 12 ++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
2 files
From: Nanley Chery
Intel surface formats default to LDR unless there is hardware
support for HDR and the texture is able to be processed in HDR mode.
v2: remove extra newlines.
v3: follow existing coding style in translate_tex_format().
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri
From: Nanley Chery
An ASTC block takes up 16 bytes for all block width and height configurations.
This size is not integrally divisible by all ASTC block widths. Therefore cpp
is changed to mean bytes per block if the texture is compressed.
Because the original definition was bytes per block
From: Nanley Chery
Although the horizontal and vertical alignment fields are ignored here,
0 is a reserved value for them and may cause undefined behavior. Change
the default value to an abitrary valid one.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/dri/i965/gen8_surface_state.c | 4
On Thu, Jun 25, 2015 at 12:37 AM, Pohjolainen, Topi
wrote:
> On Wed, Jun 24, 2015 at 05:57:13PM -0700, Anuj Phogat wrote:
>> On Wed, Jun 24, 2015 at 3:51 PM, Nanley Chery wrote:
>> > From: Nanley Chery
>> >
>> > Although the horizontal and vertical alignment
How about if I create a patch which puts the greater than 0 check into
is_power_of_two()?
(value > 0) && (value & (value - 1)) == 0);
Thanks,
Nanley
On Wed, Jun 24, 2015 at 3:22 PM, Anuj Phogat wrote:
> On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery wrote:
>> From: N
On Wed, Jun 24, 2015 at 3:43 PM, Anuj Phogat wrote:
> On Mon, Jun 22, 2015 at 4:02 PM, Nanley Chery wrote:
>> From: Nanley Chery
>>
>> Aligning with a non-power-of-two number is a general task that can be used in
>> various places. This commit is required for the ne
On Thu, Jun 25, 2015 at 4:16 PM, Anuj Phogat wrote:
> On Thu, Jun 25, 2015 at 3:22 PM, Nanley Chery wrote:
>> How about if I create a patch which puts the greater than 0 check into
>> is_power_of_two()?
>>
>> (value > 0) && (value & (value - 1)) == 0);
&
From: Nanley Chery
Aligning with a non-power-of-two number is a general task that can be used in
various places. This commit is required for the next one.
v2: add greater than 0 assertion (Anuj).
convert the macro to a static inline function.
Signed-off-by: Nanley Chery
---
src/mesa
From: Nanley Chery
Define two-thirds of the 2D Intel ASTC surface formats (LDR-only). This allows
a 1-to-1 mapping from the mesa format to the Intel format.
ASTC textures will default to being processed in LDR mode. If there is
hardware support for HDR/Full mode and the texture is not sRGB, add
Nice find. What do you think about putting this in a function to
reduce the code duplication?
- Nanley
On Wed, Jul 1, 2015 at 6:14 PM, Ben Widawsky wrote:
> On Wed, Jul 01, 2015 at 04:03:53PM -0700, Ben Widawsky wrote:
>> Certain compressed formats require this setting. The docs don't go into mu
From: Nanley Chery
Simplify future updates to the extension struct array by removing
the sentinel.
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 43 +--
1 file changed, 25 insertions(+), 18 deletions(-)
diff --git a/src/mesa/main
From: Nanley Chery
With this infrastructure set in place, we can now reuse the entries to
generate useful code.
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 321 +--
src/mesa/main/extensions_table.h | 320
From: Nanley Chery
Now that we're using macros, remove the redundant text from each entry.
Remove comments between the entries to make editing easier and separate
the sections with blank lines. Structure the EXT macros in a way that
helps reviewers verify that no meaning has been al
From: Nanley Chery
In agreement with the extension spec and commit
dd0eb004874645135b9aaac3ebbd0aaf274079ea, filter FXT1 formats to the
desktop GL profiles. Now we no longer advertise such formats as supported
in an ES context and then throw an INVALID_ENUM error when the client
tries to use
From: Nanley Chery
Replace open-coded checks for extension support with
_mesa_extension_supported().
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 54
src/mesa/main/extensions_table.h | 6 ++---
2 files changed, 14 insertions
From: Nanley Chery
Summary:
This series fixes 26 dEQP tests with prefix:
dEQP-GLES2.functional.negative_api.texture.compressedteximage2d*
and prevents similar bugs from occuring in the future.
The bug fix that originated from using the helper functions (mentioned below)
is split out for easy
From: Nanley Chery
Enable limiting advertised extension support by context version with
finer granularity. GLuint is chosen over smaller datatypes because,
when this field is eventually used, usage of this datatype provides
the smallest .text size of the compiled library.
Signed-off-by: Nanley
From: Nanley Chery
Create a function which determines if an extension is supported in the
current context.
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
From: Nanley Chery
Stop leaks into GLES1/2 and pre-3.3 GL contexts in all uses.
The extension spec lists OpenGL 3.3 as one of the requirements, so
update the extension table accordingly.
v2. Require 3.3 for GL legacy contexts as well (Chad).
Signed-off-by: Nanley Chery
---
src/mesa/main
From: Nanley Chery
Stop leaks into the following contexts:
* GLES in _mesa_get_compressed_formats().
* GL legacy 1.0 in all uses.
The extension spec lists OpenGL 1.1 as required, so update the
extension table accordingly.
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions_table.h
From: Nanley Chery
Stop leaks into the following contexts:
* GLES 1 in _mesa_get_compressed_formats() and lookup_view_class().
* GL legacy 1.0 in all uses.
The extension spec lists 1.1 as required for OpenGL and Rev 1.6 of the
extension adds GLES 2.0.25 and 3.0.2 dependencies, so update
From: Nanley Chery
Stop a leak of ASTC functionality into GLES 1 contexts.
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 4 ++--
src/mesa/main/teximage.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/mesa/main/glformats.c b/src/mesa/main
From: Nanley Chery
Since the version numbers being compared are integral and we don't ever
expect gl_context::Version to be equal to 0, subtract 1 from the rhs of
the equation and perform the optimization of removing the equality check.
Signed-off-by: Nanley Chery
---
src/mesa
From: Nanley Chery
The api_set field has no users outside of _mesa_extension_supported().
Remove it and allow the version field to take its place.
The brunt of the transformation was performed with the following vim commands:
s/\(GL [^,]\+\),\s*\d*,\s*\d*\(,\s*\d*\)\(,\s*\d*\)/\1, GLL, GLC\2\3
From: Nanley Chery
Make constext API and version checks done by the helper functions pass
unconditionally while meta is in progress. This transparently makes
extension checks solely dependent on struct gl_extensions while in meta.
Signed-off-by: Nanley Chery
---
src/mesa/drivers/common/meta.c
From: Nanley Chery
Aside from those modified in this commit, all gl_extensions structs are
zero-initialized by default. There is therefore no need to memset the
structs to 0. Also, remove the open-coded memset in
_mesa_init_extensions().
Signed-off-by: Nanley Chery
---
src/mesa/main
From: Nanley Chery
Stop leaks into the following contexts:
* GLES in _mesa_base_tex_format() and lookup_view_class().
* Pre-1.1 GL legacy contexts in all uses.
Stop allowing compressed sRGB formats as valid formats in GLES3
contexts. I realized this was happening when CTS failures occured
From: Nanley Chery
Mesa unconditionally sets this driver flag to true in
_mesa_init_extensions(). There is therefore no need for
the driver to communicate support for this extension.
Replace the driver capability flag with ::dummy_true.
Signed-off-by: Nanley Chery
---
src/glsl
From: Nanley Chery
Generate functions which determine if an extension is supported in the
current context. Initially, enums were going to be explicitly used with
_mesa_extension_supported(). The idea to embed the function and enums
into generated helper functions was suggested by Kristian
From: Nanley Chery
This variable existed to provide an unsigned error value for
name_to_offset(). Since o(extension_sentinel) is also a valid unsigned
error value, save space and replace this mysterious variable with
a less mysterious one (extension_sentinel).
Signed-off-by: Nanley Chery
From: Nanley Chery
Stop leaks into the following contexts:
* GLES in _mesa_target_can_be_compressed().
* Pre-3.1 GL legacy versions in all uses.
The extension spec lists OpenGL 3.1 as required, so update the extension
table accordingly.
Signed-off-by: Nanley Chery
---
src/mesa/main
From: Nanley Chery
Avoid the function call overhead for this one-liner.
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 14 --
src/mesa/main/extensions.h | 16 ++--
2 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/mesa/main/extensions.c
On Mon, Oct 19, 2015 at 3:47 PM, Ilia Mirkin wrote:
> On Mon, Oct 19, 2015 at 6:36 PM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > In agreement with the extension spec and commit
> > dd0eb004874645135b9aaac3ebbd0aaf274079ea, filter FXT1 formats to the
&
On Mon, Oct 19, 2015 at 4:02 PM, Ilia Mirkin wrote:
> On Mon, Oct 19, 2015 at 6:58 PM, Nanley Chery
> wrote:
> >
> >
> > On Mon, Oct 19, 2015 at 3:47 PM, Ilia Mirkin
> wrote:
> >>
> >> On Mon, Oct 19, 2015 at 6:36 PM, Nanley Chery
> >&
On Tue, Oct 20, 2015 at 6:26 AM, Ian Romanick wrote:
> On 10/19/2015 05:58 PM, Nanley Chery wrote:
> >
> >
> > On Mon, Oct 19, 2015 at 3:47 PM, Ilia Mirkin > <mailto:imir...@alum.mit.edu>> wrote:
> >
> > On Mon, Oct 19, 2015 at 6:36 PM, Nanl
On Tue, Oct 20, 2015 at 8:14 AM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund
> wrote:
> > On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery
> wrote:
> >> From: Nanley Chery
> >>
> >> - { "GL_SUN_mul
ck to
its original position.
Thanks,
Nanley
Marek
>
> On Tue, Oct 20, 2015 at 5:14 PM, Marek Olšák wrote:
> > On Tue, Oct 20, 2015 at 4:31 PM, Erik Faye-Lund
> wrote:
> >> On Tue, Oct 20, 2015 at 12:36 AM, Nanley Chery
> wrote:
> >>> From: Nanley Ch
On Tue, Oct 20, 2015 at 8:26 AM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > Generate functions which determine if an extension is supported in the
> > current context. Initially, enums were go
On Tue, Oct 20, 2015 at 8:32 AM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > Stop leaks into the following contexts:
> >* GLES in _mesa_base_tex_format() and lookup_view_class().
> >* Pr
On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > Avoid the function call overhead for this one-liner.
>
> Can you measure the overhead? If not, there is no reason for t
On Tue, Oct 20, 2015 at 9:31 AM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 6:25 PM, Nanley Chery
> wrote:
> >
> >
> > On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák wrote:
> >>
> >> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery
> >> wrote:
On Tue, Oct 20, 2015 at 8:49 AM, Marek Olšák wrote:
> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > Aside from those modified in this commit, all gl_extensions structs are
> > zero-initialized by default. There is t
ersion,
when in fact a longer list of dependencies would suffice instead. I'll look
into this issue. If it's
the right way to go, I can allow all versions of GL compatibility by simply
replacing the '31'
with 'GLL' in a v2.
> Marek
>
> On Tue, Oct 20, 20
ontained within any other extension and our context
version
is less than 3.3, we may not be able to actually implement the extension
spec as
described. I will try to see if this is the case. I agree that technical
roadblocks should be the
only things which prevent us from advertising certain extensions
On Wed, Oct 21, 2015 at 7:23 AM, Emil Velikov
wrote:
> On 9 October 2015 at 23:35, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > The refactoring commit, c6bf1cd, accidentally reverted cd49b97
> > and 99b1f47. These changes caused more code to be added to the
&
From: Nanley Chery
In OpenGL ES, the COMPRESSED_TEXTURE_FORMATS query returns the set of
supported specific compressed formats. Since ASTC formats fit within
that category, include them in the set and update the
NUM_COMPRESSED_TEXTURE_FORMATS query as well.
This enables GLES2-based ASTC dEQP
On Thu, Oct 22, 2015 at 3:06 AM, Emil Velikov
wrote:
> On 20 October 2015 at 16:43, Nanley Chery wrote:
> > On Tue, Oct 20, 2015 at 8:16 AM, Marek Olšák wrote:
> >>
> >> Also, the FIXME comment should be on its own line.
> >>
> >
> > I moved it
On Thu, Oct 22, 2015 at 3:19 AM, Emil Velikov
wrote:
> On 19 October 2015 at 23:36, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Create a function which determines if an extension is supported in the
> > current context.
> >
> > Signed-off-by: N
On Thu, Oct 22, 2015 at 11:08 AM, Chad Versace
wrote:
> On Thu 22 Oct 2015, Emil Velikov wrote:
> > On 19 October 2015 at 23:36, Nanley Chery wrote:
> > > From: Nanley Chery
> > >
> > > Create a function which determines if an extension is su
On Thu, Oct 22, 2015 at 3:13 AM, Emil Velikov
wrote:
> On 19 October 2015 at 23:36, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > With this infrastructure set in place, we can now reuse the entries to
> > generate useful code.
> >
> > Signed-off-
On Thu, Oct 22, 2015 at 3:40 AM, Emil Velikov
wrote:
> On 19 October 2015 at 23:44, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > This variable existed to provide an unsigned error value for
> > name_to_offset(). Since o(extension_sentinel) is also a valid uns
On Wed, Oct 21, 2015 at 11:43 PM, Erik Faye-Lund
wrote:
> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery
> wrote:
> > From: Nanley Chery
> >
> > Since the version numbers being compared are integral and we don't ever
> > expect gl_context::Version to be equ
On Thu, Oct 22, 2015 at 3:17 AM, Emil Velikov
wrote:
> On 19 October 2015 at 23:36, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Enable limiting advertised extension support by context version with
> > finer granularity. GLuint is chosen over smaller datat
On Thu, Oct 22, 2015 at 11:02 AM, Chad Versace
wrote:
> On Mon 19 Oct 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Enable limiting advertised extension support by context version with
> > finer granularity. GLuint is chosen over smaller datatypes beca
On Thu, Oct 22, 2015 at 3:32 AM, Emil Velikov
wrote:
> On 19 October 2015 at 23:44, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Aside from those modified in this commit, all gl_extensions structs are
> > zero-initialized by default. There is therefore no nee
On Tue, Oct 20, 2015 at 4:32 PM, Nanley Chery wrote:
>
>
> On Tue, Oct 20, 2015 at 8:45 AM, Marek Olšák wrote:
>
>> NAK. I'd like this extension in compatibility contexts. The fact the
>> spec requires OpenGL 3.3 was just authors' laziness.
>>
>>
&g
On Thu, Oct 22, 2015 at 12:15 PM, Chad Versace
wrote:
> On Mon 19 Oct 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Stop leaks into the following contexts:
> >* GLES in _mesa_base_tex_format() and lookup_view_class().
> >* Pre-1.1 GL legacy c
On Thu, Oct 22, 2015 at 11:30 AM, Chad Versace
wrote:
> On Mon 19 Oct 2015, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > Generate functions which determine if an extension is supported in the
> > current context. Initially, enums were going
On Mon, Oct 26, 2015 at 11:15 AM, Neil Roberts wrote:
> Nanley Chery writes:
>
> > + /* Throw an INVALID_OPERATION error if the target is
> > + * TEXTURE_CUBE_MAP_ARRAY and the format is not ASTC.
> > + */
> > + if (target_can_be_c
On Mon, Oct 26, 2015 at 11:53 AM, Roland Scheidegger
wrote:
> Am 26.10.2015 um 19:31 schrieb Ilia Mirkin:
> > On Mon, Oct 26, 2015 at 2:15 PM, Neil Roberts
> wrote:
> >> Nanley Chery writes:
> >>
> >>> + /* Throw a
On Fri, Oct 23, 2015 at 3:01 PM, Nanley Chery wrote:
>
>
> On Thu, Oct 22, 2015 at 12:15 PM, Chad Versace
> wrote:
>
>> On Mon 19 Oct 2015, Nanley Chery wrote:
>> > From: Nanley Chery
>> >
>> > Stop leaks into the following context
On Mon, Oct 26, 2015 at 4:30 PM, Ian Romanick wrote:
> Reviewed-by: Ian Romanick
>
> On 10/21/2015 03:06 PM, Nanley Chery wrote:
> > From: Nanley Chery
> >
> > In OpenGL ES, the COMPRESSED_TEXTURE_FORMATS query returns the set of
> > supported specific compr
From: Nanley Chery
The ASTC spec forbids other compressed formats from being used against
the targets: TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Because other
compressed formats were previously supported for these targets in
desktop GL, it's considered to be a spec bug and Mesa will diverge
From: Nanley Chery
A prior, literal reading of the ASTC spec led to the prohibition
of some compressed formats being used against the targets:
TEXTURE_CUBE_MAP_ARRAY and TEXTURE_3D. Since the spec does not specify
interactions with other extensions for specific compressed textures,
remove such
From: Nanley Chery
Simplify future updates to the extension struct array by removing
the sentinel.
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 43 +--
1 file changed, 25 insertions(+), 18 deletions(-)
diff --git a/src/mesa/main
From: Nanley Chery
Now that we're using macros, remove the redundant text from each entry.
Remove comments between the entries to make editing easier and separate
the sections with blank lines. Structure the EXT macros in a way that
helps reviewers verify that no meaning has been al
From: Nanley Chery
With this infrastructure set in place, we can now reuse the entries to
generate useful code.
v2. Add the new file into Makefile.sources (Emil)
Signed-off-by: Nanley Chery
---
src/mesa/Makefile.sources| 1 +
src/mesa/main/extensions.c | 321
From: Nanley Chery
Create a function which determines if an extension is supported in the
current context.
v2. Use common variable names (Emil)
Insert new line between variables and return statement (Chad)
Rename api_set variable to api_bit (Chad)
Signed-off-by: Nanley Chery
---
src
From: Nanley Chery
Replace open-coded checks for extension support with
_mesa_extension_supported().
Signed-off-by: Nanley Chery
---
src/mesa/main/extensions.c | 54
src/mesa/main/extensions_table.h | 6 ++---
2 files changed, 14 insertions
From: Nanley Chery
Enable limiting advertised extension support by context version with
finer granularity.
v2. Use uint*t type for version and note the expected values (Emil)
Use an 8-bit wide datatype.
Reformat macro for better readability (Chad)
Signed-off-by: Nanley Chery
---
src
From: Nanley Chery
Stop a leak of ASTC functionality into GLES 1 contexts.
v2. Handle ASTC driver capability check in texcompress.c
Signed-off-by: Nanley Chery
---
src/mesa/main/glformats.c | 4 ++--
src/mesa/main/texcompress.c | 2 +-
src/mesa/main/teximage.c| 6 +++---
3 files
From: Nanley Chery
The api_set field has no users outside of _mesa_extension_supported().
Remove it and allow the version field to take its place.
The brunt of the transformation was performed with the following vim commands:
s/\(GL [^,]\+\),\s*\d*,\s*\d*\(,\s*\d*\)\(,\s*\d*\)/\1, GLL, GLC\2\3
1 - 100 of 1409 matches
Mail list logo
