On Thu, Oct 22, 2015 at 3:40 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote:
> On 19 October 2015 at 23:44, Nanley Chery <nanleych...@gmail.com> wrote: > > From: Nanley Chery <nanley.g.ch...@intel.com> > > > > This variable existed to provide an unsigned error value for > > name_to_offset(). Since o(extension_sentinel) is also a valid unsigned > > error value, save space and replace this mysterious variable with > > a less mysterious one (extension_sentinel). > > > That's the first time I see someone calling 0, a "unsigned error > value". Perhaps reword the commit message a bit ? The comment/function > description should be updated as well. > > How's the following? This variable existed to enable 0 as a valid error value for name_to_offset(). Since o(extension_sentinel) is also a valid error value, save space and replace this mysterious variable with a less mysterious one (extension_sentinel). > -Emil >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
