Re: [Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
On 06/05/2015 03:57 PM, Mario Kleiner wrote: On 06/05/2015 03:50 PM, Ilia Mirkin wrote: This scheme is copied from radeon, does it need a similar fix? I'm away from computers for another week or so, will be able to look then. For some reason, no. Testing on Radeon multi-x-screen Zaphod

[Mesa-dev] [PATCH] radeon: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
Same problem and fix as for nouveau's ZaphodHeads trouble. See patch ... "nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads." ... for reference. Cc: "10.3 10.4 10.5 10.6" Signed-off-by: Mario Kleiner Cc: Ilia Mirkin --- src/

Re: [Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
On 06/28/2015 03:48 AM, Ilia Mirkin wrote: On Fri, Jun 5, 2015 at 9:36 AM, Mario Kleiner wrote: The dup'ed fd owned by the nouveau_screen for a device node must also be used as key for the winsys hash table, instead of using the original fd passed in for a screen, to make multi-x-s

Re: [Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
is to stick as the real key in the hash, although that'd involve making pointers. Probably not worth it. Cheers, -ilia On Sat, Jun 27, 2015 at 11:13 PM, Mario Kleiner wrote: On 06/28/2015 03:48 AM, Ilia Mirkin wrote: On Fri, Jun 5, 2015 at 9:36 AM, Mario Kleiner wrote: The dup&#

Re: [Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
ng, especially under dri3, although each such "mesa screen" corresponds to a x-screen. -mario On 06/28/2015 06:03 AM, Mario Kleiner wrote: On 06/28/2015 05:41 AM, Ilia Mirkin wrote: Oh duh. Thanks for the super-detailed explanation. To rephrase what you said in a slightly short

Re: [Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
w commit message is fine. Also i am possibly just confused about this, and your commit message is an improvement in clarity anyway :) So i think it is fine to leave it as is. thanks, -mario On Sun, Jun 28, 2015 at 12:23 AM, Mario Kleiner wrote: Ok, maybe one thing for the commit message,

Re: [Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
Yes, that's good. On 06/28/2015 07:00 AM, Ilia Mirkin wrote: How about: /* Use dupfd in hash table, to avoid errors if the original fd gets * closed by its owner. The hash key needs to live at least as long as * the screen. */ On Sun, Jun 28, 2015 at 12:57 AM, Mario Kleiner wrote: On

Re: [Mesa-dev] [PATCH] radeon: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-27 Thread Mario Kleiner
the situation for nouveau). Reviewed-by: Ilia Mirkin . But one of the radeon people definitely needs to look at this before pushing. On Sat, Jun 27, 2015 at 9:02 PM, Mario Kleiner wrote: Same problem and fix as for nouveau's ZaphodHeads trouble. See patch ... "nouveau: Use dup fd as

[Mesa-dev] [PATCH] libdrm/amdgpu: Use private fd for amdgpu_device and winsys hash table to fix ZaphodHeads.

2015-07-14 Thread Mario Kleiner
e0965c8c068c6d8 "winsys/radeon: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads." Signed-off-by: Mario Kleiner Cc: Marek Olšák --- amdgpu/amdgpu_device.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdg

[Mesa-dev] [PATCH] libdrm/amdgpu: Use private fd for amdgpu_device and winsys hash table to fix ZaphodHeads. (v2)

2015-07-17 Thread Mario Kleiner
e0965c8c068c6d8 "winsys/radeon: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads." Signed-off-by: Mario Kleiner Acked-by: Marek Olšák Reviewed-by: Christian König v2: Check for valid fd's being >= 0, because fd == 0 is in theory a valid, although unlikely

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Mario Kleiner
/radeon: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.) Cc: Mario Kleiner Signed-off-by: Emil Velikov Reviewed-by: Alex Deucher Looks good, thanks for catching this. Reviewed-by: Mario Kleiner cc stable seems safe, so can't hurt, no? I have a similar patch for the a

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Mario Kleiner
On 07/29/2015 08:50 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner wrote: On 07/29/2015 05:46 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 10:44 AM, Emil Velikov wrote: Earlier commit added an extra dup(fd) to fix a ZaphodHeads issue. Although it did not

Re: [Mesa-dev] [PATCH] winsys/radeon: don't leak the fd when it is 0

2015-07-29 Thread Mario Kleiner
On 07/29/2015 09:05 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 2:55 PM, Mario Kleiner wrote: On 07/29/2015 08:50 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 2:48 PM, Mario Kleiner wrote: On 07/29/2015 05:46 PM, Alex Deucher wrote: On Wed, Jul 29, 2015 at 10:44 AM, Emil

[Mesa-dev] [PATCH] glx: Perform check for valid fbconfig against proper X-Screen.

2016-10-11 Thread Mario Kleiner
. Tested to fix context creation failure on a dual-x-screen setup. Signed-off-by: Mario Kleiner Cc: "11.2 12.0" --- src/glx/glxcmds.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index b0a1cb0..6abe0b9 100644 --- a/src/g

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: Perform check for valid fbconfig against proper X-Screen.

2016-10-14 Thread Mario Kleiner
On 10/14/2016 11:14 AM, Emil Velikov wrote: On 12 October 2016 at 18:40, Emil Velikov wrote: On 11 October 2016 at 19:42, Mario Kleiner wrote: Tested to fix context creation failure on a dual-x-screen setup. Signed-off-by: Mario Kleiner Cc: "11.2 12.0" Reviewed-by: Em

[Mesa-dev] [PATCH] r600: increase performance for DRI PRIME offloading if 2nd GPU is Evergreen+

2016-08-26 Thread Mario Kleiner
R700 due to some bugs apparently present in their SDMA implementation. Signed-off-by: Mario Kleiner Cc: Marek Olšák --- src/gallium/drivers/r600/r600_blit.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600

Re: [Mesa-dev] DRI3/Present fixes for Mesa 10.3+ (v2)

2014-12-02 Thread Mario Kleiner
A slightly updated and extended series of the dri3/present fixes for Mesa i sent last week. Patch 1 and 2 are same as before. Patch 3 now has signed off by Frank Binns and reviewed by Chris Wilson. Patch 4 and 5 are additional fixes. The last one makes INTEL_swap_events behave properly again when

[Mesa-dev] [PATCH 2/5] glx/dri3: Track separate (ust, msc) for PresentPixmap vs. PresentNotifyMsc

2014-12-02 Thread Mario Kleiner
so rely on this not regressing under DRI3/Present, e.g., Neuro-Science software like Psychtoolbox-3. This patch fixes the problem. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner --- src/glx/dri3_glx.c | 11 +++ src/glx/dri3_priv.h | 5 - 2 files changed, 11 insertions(+), 5 d

[Mesa-dev] [PATCH 3/5] glx/dri3: Request non-vsynced Present for swapinterval zero. (v2)

2014-12-02 Thread Mario Kleiner
o also for this one. Signed-off-by: Frank Binns Signed-off-by: Mario Kleiner Reviewed-by: Chris Wilson --- src/glx/dri3_glx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index 5796491..c53be1b 100644 --- a/src/glx/dri3_glx.c

[Mesa-dev] [PATCH 5/5] glx: Handle out-of-sequence swap completion events correctly.

2014-12-02 Thread Mario Kleiner
the wraparound handling. This patch fixes the problem by handling 32-Bit wraparound in both directions. As long as successive swap completion events real 64-Bit sbc's don't differ by more than 2^30, this should be able to do the right thing. Cc: "10.3 10.4" Signed-off-by: Mar

[Mesa-dev] [PATCH 1/5] glx/dri3: Fix glXWaitForSbcOML() to handle targetSBC==0 correctly.

2014-12-02 Thread Mario Kleiner
rely on this not regressing under DRI3/Present, e.g., Neuro-Science software like Psychtoolbox-3. This patch fixes the problem. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner --- src/glx/dri3_glx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c

[Mesa-dev] [PATCH 4/5] glx/dri3: Don't fail on glXSwapBuffersMscOML(dpy, window, 0, 0, 0)

2014-12-02 Thread Mario Kleiner
present extension responded kindly to this with a BadValue error and dropped the request, but mesa's DRI3/Present backend doesn't check for error codes. From there on stuff went downhill quickly for the calling OpenGL client... This patch fixes the problem. Cc: "10.3 10.4"

Re: [Mesa-dev] [PATCH 1/5] glx/dri3: Fix glXWaitForSbcOML() to handle targetSBC==0 correctly.

2014-12-04 Thread Mario Kleiner
On 12/04/2014 11:48 AM, Axel Davy wrote: Le 04/12/2014 11:44, Axel Davy a écrit : On 02/12/2014 20:53, Mario Kleiner wrote : targetSBC == 0 is a special case, which asks the function to block until all pending OpenGL bufferswap requests have completed. Currently the function just falls

Re: [Mesa-dev] [PATCH 3/5] glx/dri3: Request non-vsynced Present for swapinterval zero. (v2)

2014-12-04 Thread Mario Kleiner
On 12/04/2014 11:20 AM, Axel Davy wrote: On 02/12/2014 20:53, Mario Kleiner wrote : Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. + if (priv->swap_interval == 0) + options |= XCB_PRESENT_OPTION_ASYNC; + back->bu

[Mesa-dev] [PATCH 2/5] glx/dri3: Track separate (ust, msc) for PresentPixmap vs. PresentNotifyMsc (v2)

2014-12-04 Thread Mario Kleiner
so rely on this not regressing under DRI3/Present, e.g., Neuro-Science software like Psychtoolbox-3. This patch fixes the problem. v2: Rename vblank_msc/ust to notify_msc/ust as suggested by Axel Davy for better clarity. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner Reviewed-by: Axel Davy

[Mesa-dev] DRI3/Present fixes for Mesa 10.3+ (v3)

2014-12-04 Thread Mario Kleiner
Ok, third iteration of the series. Incorporated all the review comments of Axel Davy and Eric Anholt and retested for extra paranoia. Thanks! -mario ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/m

[Mesa-dev] [PATCH 4/5] glx/dri3: Don't fail on glXSwapBuffersMscOML(dpy, window, 0, 0, 0) (v2)

2014-12-04 Thread Mario Kleiner
lear, with reference to relevant spec, as suggested by Eric Anholt. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner Reviewed-by: Axel Davy Reviewed-by: Eric Anholt --- src/glx/dri3_glx.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/glx/

[Mesa-dev] [PATCH 5/5] glx: Handle out-of-sequence swap completion events correctly.

2014-12-04 Thread Mario Kleiner
the wraparound handling. This patch fixes the problem by handling 32-Bit wraparound in both directions. As long as successive swap completion events real 64-Bit sbc's don't differ by more than 2^30, this should be able to do the right thing. Cc: "10.3 10.4" Signed-off-by: Mar

[Mesa-dev] [PATCH 1/5] glx/dri3: Fix glXWaitForSbcOML() to handle targetSBC==0 correctly. (v2)

2014-12-04 Thread Mario Kleiner
rely on this not regressing under DRI3/Present, e.g., Neuro-Science software like Psychtoolbox-3. This patch fixes the problem. v2: Simplify as suggested by Axel Davy. Add comments proposed by Eric Anholt. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner Reviewed-by: Axel Davy Reviewe

[Mesa-dev] [PATCH 3/5] glx/dri3: Request non-vsynced Present for swapinterval zero. (v3)

2014-12-04 Thread Mario Kleiner
o also for this one. v3: Incorporate comment about triple buffering as suggested by Axel Davy, and reference to relevant spec provided by Eric Anholt. Signed-off-by: Frank Binns Signed-off-by: Mario Kleiner Reviewed-by: Chris Wilson Reviewed-by: Axel Davy Reviewed-by: Eric Anholt --

Re: [Mesa-dev] DRI3/Present fixes for Mesa 10.3+ (v2)

2014-12-05 Thread Mario Kleiner
On 12/05/2014 03:41 AM, Eric Anholt wrote: Mario Kleiner writes: A slightly updated and extended series of the dri3/present fixes for Mesa i sent last week. Patch 1 and 2 are same as before. Patch 3 now has signed off by Frank Binns and reviewed by Chris Wilson. Patch 4 and 5 are additional

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-15 Thread Mario Kleiner
On 12/15/2014 06:46 AM, Keith Packard wrote: Mario Kleiner writes: Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Hrm. I'd love for this to be controlled by the GLX_EXT_swap_control_tear extension, but that one uses negative interval valu

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Mario Kleiner
On 12/16/2014 09:23 AM, Keith Packard wrote: Mario Kleiner writes: The 0 case is good for benchmarking. Sure, but the current code does benchmarking just fine. In fact, because it doesn't copy queued frames that aren't the most recent before the vblank, benchmarks tend to run *fa

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Mario Kleiner
On 12/17/2014 04:17 AM, Keith Packard wrote: Mario Kleiner writes: Hmm. For benchmarking i think i'd consider that a mild form of cheating. You get higher fps because you skip processing like the whole gpu blit overhead and host processing overhead for queuing / validating / processin

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Mario Kleiner
On 12/17/2014 05:49 AM, Keith Packard wrote: Mario Kleiner writes: It's just that i need access to both, the old behaviour i described, and the new "drop frame" behaviour, and i need a way to select what i want at runtime via api without the need for easily overwhelmed and co

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-17 Thread Mario Kleiner
On 12/17/2014 12:45 PM, Eero Tamminen wrote: Hi, On 12/16/2014 08:30 PM, Mario Kleiner wrote: On 12/16/2014 09:23 AM, Keith Packard wrote: Mario Kleiner writes: The 0 case is good for benchmarking. Sure, but the current code does benchmarking just fine. In fact, because it doesn't

[Mesa-dev] Fwd: Review for last remaining Mesa wayland-drm depth 30 bits?

2019-01-29 Thread Mario Kleiner
Hi, could i get some review of the last two missing patches of mine for depth 30 support in Mesa's egl/wayland wl-drm backend? They are over six months old now, well-tested at time of original submission: https://patchwork.freedesktop.org/project/mesa/list/?submitter=14956 Would be good to get t

Re: [Mesa-dev] Fwd: Review for last remaining Mesa wayland-drm depth 30 bits?

2019-01-29 Thread Mario Kleiner
, > > On Tue, 29 Jan 2019 at 16:05, Adam Jackson wrote: > > On Tue, 2019-01-29 at 14:45 +0100, Mario Kleiner wrote: > > > could i get some review of the last two missing patches of mine for > > > depth 30 support in Mesa's egl/wayland wl-drm backend? They are ov

[Mesa-dev] [PATCH] drirc: Add sddm-greeter to adaptive_sync blacklist.

2019-02-18 Thread Mario Kleiner
This is the sddm login screen. Fixes: a9c36dbf9c56 ("drirc: Initial blacklist for adaptive sync") Signed-off-by: Mario Kleiner Cc: 19.0 --- src/util/00-mesa-defaults.conf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/util/00-mesa-defaults.conf b/src/util/00-mesa-def

Re: [Mesa-dev] [xf86-video-nouveau] dri2: Enable BufferAge support

2015-05-08 Thread Mario Kleiner
tly support TripleBuffer, we don't have to worry about setting the copying the flags field when injecting the third buffer. Signed-off-by: Chris Wilson Cc: Maarten Lankhorst Cc: Mario Kleiner --- src/nouveau_dri2.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/nouveau_

[Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-05 Thread Mario Kleiner
een is recycled, which points to nirvana -> Crash. This problem is avoided by use of the dup()ed fd which is owned by the nouveau_screen and has the same lifetime as the nouveau_screen itself. Cc: "10.3 10.4 10.5 10.6" Signed-off-by: Mario Kleiner Cc: Ilia Mirkin --- sr

Re: [Mesa-dev] [PATCH] nouveau: Use dup fd as key in drm-winsys hash table to fix ZaphodHeads.

2015-06-05 Thread Mario Kleiner
calls? thanks, -mario On Jun 5, 2015 4:37 PM, "Mario Kleiner" mailto:mario.kleiner...@gmail.com>> wrote: The dup'ed fd owned by the nouveau_screen for a device node must also be used as key for the winsys hash table, instead of using the original fd passed in for

[Mesa-dev] [PATCH 1/3] glx/dri3: Fix glXWaitForSbcOML() to handle targetSBC==0 correctly.

2014-11-24 Thread Mario Kleiner
rely on this not regressing under DRI3/Present, e.g., Neuro-Science software like Psychtoolbox-3. This patch fixes the problem. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner --- src/glx/dri3_glx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c

[Mesa-dev] [PATCH 2/3] glx/dri3: Track separate (ust, msc) for PresentPixmap vs. PresentNotifyMsc

2014-11-24 Thread Mario Kleiner
so rely on this not regressing under DRI3/Present, e.g., Neuro-Science software like Psychtoolbox-3. This patch fixes the problem. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner --- src/glx/dri3_glx.c | 11 +++ src/glx/dri3_priv.h | 5 - 2 files changed, 11 insertions(+), 5 d

[Mesa-dev] DRI3/Present fixes for Mesa 10.3+

2014-11-24 Thread Mario Kleiner
Hi Here three patches against mesa to fix use of the OML_sync_control extension under DRI3/Present and restore behaviour compatible to the DRI2 implementation, so applications like mine, which were written and tested against DRI2, don't fail miserably under the new backend. Tested on Intel HD Iro

[Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-11-24 Thread Mario Kleiner
Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner --- src/glx/dri3_glx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c index 579649

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-11-30 Thread Mario Kleiner
ich is only a simple one-liner but solves more problems than the old one. I'll send it out after giving it some testing. thanks, -mario On 25/11/2014 04:00, Mario Kleiner wrote : Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Cc: "10.

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-11-30 Thread Mario Kleiner
... thanks, -mario On 25/11/14 03:00, Mario Kleiner wrote: Restores proper immediate tearing swap behaviour for OpenGL bufferswap under DRI3/Present. Cc: "10.3 10.4" Signed-off-by: Mario Kleiner --- src/glx/dri3_glx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] glx: Handle out-of-sequence swap completion events correctly. (v2)

2015-03-12 Thread Mario Kleiner
er, which is rather unlikely. v2: Explain the reason for this patch and the new wraparound handling much more extensive in commit message, no code change wrt. initial version. Cc: "10.3 10.4 10.5" Signed-off-by: Mario Kleiner --- src/glx/glxext.c | 9 +++-- 1 file changed, 7

[Mesa-dev] Resend [PATCH] glx: Handle out-of-sequence swap completion events correctly.

2015-03-12 Thread Mario Kleiner
Hi all, a respin of the bugfix for INTEL_swap_events + DRI3/Present. The code in the patch itself is identical to the one queued for Mesa 10.5.1, the one apparently nobody wants to review - I hate wraparound handling too... The only difference is a much longer commit message which explains why w

[Mesa-dev] [PATCH] mapi: Make private copies of name strings provided by client.

2015-03-12 Thread Mario Kleiner
- with a dangling pointer. strdup() the name string provided by the client to avoid this problem. Cc: "10.3 10.4 10.5" Signed-off-by: Mario Kleiner --- src/mapi/stub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/stub.c b/src/mapi/stub.c index dfadbe1..4

Re: [Mesa-dev] [PATCH 02/15] i965/screen: Add basic support for rendering 10 bpc/depth 30 framebuffers. (v2)

2017-10-18 Thread Mario Kleiner
On 10/10/2017 12:51 PM, Tapani Pälli wrote: On 10/06/2017 07:11 PM, Mario Kleiner wrote: Expose formats which are supported at least back to Gen 5 Ironlake, possibly further. Allow creation of 10 bpc winsys buffers for drawables. glxinfo now lists new RGBA 10 10 10 2/0 formats. Works correctly

Re: [Mesa-dev] 10-bit Mesa/Gallium support

2017-11-23 Thread Mario Kleiner
On 11/23/2017 06:45 PM, Ilia Mirkin wrote: On Thu, Nov 23, 2017 at 12:35 PM, Marek Olšák wrote: Hi everybody, Mario, feel free to push your patches if you haven't yet. (except the workaround) Hi, just started 10 minutes ago with rebasing my current patchset against mesa master. Will need

Re: [Mesa-dev] 10-bit Mesa/Gallium support

2017-11-23 Thread Mario Kleiner
On 11/23/2017 07:44 PM, Ilia Mirkin wrote: On Thu, Nov 23, 2017 at 1:31 PM, Mario Kleiner wrote: On 11/23/2017 06:45 PM, Ilia Mirkin wrote: On Thu, Nov 23, 2017 at 12:35 PM, Marek Olšák wrote: Hi everybody, Mario, feel free to push your patches if you haven't yet. (except the worka

[Mesa-dev] [PATCH 02/22] i965: Support xrgb/argb2101010 formats for glx_texture_from_pixmap.

2017-11-28 Thread Mario Kleiner
Makes compositing under X11/GLX work. Signed-off-by: Mario Kleiner --- src/mesa/drivers/dri/i965/intel_tex_image.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c index

[Mesa-dev] [PATCH 03/22] i965: Support accelerated blit for depth 30 formats. (v2)

2017-11-28 Thread Mario Kleiner
h to exclude XRGB2101010 -> ARGB2101010, as intel_miptree_set_alpha_to_one() isn't ready to set 2 bit alpha channels to 1.0 yet. However, couldn't find a test case where this specific blit would be needed, so maybe not much of a point to improve here. Signed-off-by: Mario Klein

[Mesa-dev] [PATCH 10/22] egl/x11: Match depth 30 RGB visuals to 32-bit RGBA EGLConfigs.

2017-11-28 Thread Mario Kleiner
for egl configs, which are fixed by this commit. Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_x11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c index c49cb1f..81b1c80 100644 --- a/

[Mesa-dev] [PATCH 01/22] i965/screen: Add basic support for rendering 10 bpc/depth 30 framebuffers. (v3)

2017-11-28 Thread Mario Kleiner
igned-off-by: Mario Kleiner Reviewed-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_screen.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index b56a61b..39efc1c 100644 ---

[Mesa-dev] [PATCH 04/22] dri: Add 10 bpc formats as available formats. (v2)

2017-11-28 Thread Mario Kleiner
ck of definitions, as suggested by Tapani. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli --- include/GL/internal/dri_interface.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h

[Mesa-dev] Rev 3 of 10 bit color depth support for i965 dri + gallium

2017-11-28 Thread Mario Kleiner
Ok, next iteration. The i965 patches are the same, except i tacked one additional r-b by Tapani to patch 01/22 and adjusted num_formats according to his suggestion, and rebased onto his new sRGB support patch for i965. New patch 02/22 adds back 10 bit handling to intelSetTexBuffer2(). That was dr

[Mesa-dev] [PATCH 07/22] dri/common: Add option to allow exposure of 10 bpc color configs. (v2)

2017-11-28 Thread Mario Kleiner
to option parsing, to make sure it stays before the ->InitScreen(). Signed-off-by: Mario Kleiner --- src/mesa/drivers/dri/common/dri_util.c | 12 src/util/xmlpool/t_options.h | 5 + 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/mesa/drive

[Mesa-dev] [PATCH 06/22] i965/screen: Add XRGB2101010 and ARGB2101010 support for DRI3.

2017-11-28 Thread Mario Kleiner
Allow DRI3/Present buffer sharing for 10 bpc buffers. Otherwise composited desktops under DRI3 will only display black client areas for redirected windows. Signed-off-by: Mario Kleiner --- src/mesa/drivers/dri/i965/intel_screen.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 13/22] egl/wayland: Add Wayland drm support for RGB10 winsys buffers.

2017-11-28 Thread Mario Kleiner
Successfully tested under Weston 3.0. Photometer confirms 10 rgb bits from rendering to display. Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_wayland.c | 37 --- src/egl/wayland/wayland-drm/wayland-drm.c | 6 + 2 files changed, 40 insertions

[Mesa-dev] [PATCH 05/22] loader/dri3: Add XRGB2101010 and ARGB2101010 support.

2017-11-28 Thread Mario Kleiner
To allow DRI3/Present buffer sharing for 10 bpc buffers. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli --- src/loader/loader_dri3_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 7e6b8b2..cc890bc

[Mesa-dev] [PATCH 08/22] i965/screen: Honor 'allow_rgb10_configs' option. (v2)

2017-11-28 Thread Mario Kleiner
Allows to prevent exposing RGB10 configs and visuals to clients. v2: Rename expose_rgb10_configs to allow_rgb10_configs, as suggested by Emil. Signed-off-by: Mario Kleiner --- src/mesa/drivers/dri/i965/intel_screen.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a

[Mesa-dev] [PATCH 18/22] st/dri2: Add buffer handling for BGR[A/X]1010102 formats.

2017-11-28 Thread Mario Kleiner
Signed-off-by: Mario Kleiner --- src/gallium/state_trackers/dri/dri2.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index b8333f6..04c153a 100644 --- a/src/gallium/state_trackers/dri/dri2.c +++ b

[Mesa-dev] [PATCH 11/22] egl/x11: Handle depth 30 drawables under software rasterizer.

2017-11-28 Thread Mario Kleiner
For fixing eglCreateWindowSurface() under swrast, as tested with LIBGL_ALWAYS_SOFTWARE=1. Suggested-by: Eric Engestrom Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_x11.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers

[Mesa-dev] [PATCH 15/22] egl/wayland: Add Wayland shm swrast support for RGB10 winsys buffers.

2017-11-28 Thread Mario Kleiner
Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_wayland.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 7451027..4a0b8c2 100644 --- a/src/egl/drivers

[Mesa-dev] [PATCH 22/22] st/dri: Add option to control exposure of 10 bpc color configs.

2017-11-28 Thread Mario Kleiner
Some clients may not like rgb10 fbconfigs and visuals. Support driconf option 'allow_rgb10_configs' on gallium to allow per application enable/disable. The option defaults to enabled. Signed-off-by: Mario Kleiner --- src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 1 + s

[Mesa-dev] [PATCH 16/22] st/mesa: Handle BGR[A/X]1010102 formats.

2017-11-28 Thread Mario Kleiner
Signed-off-by: Mario Kleiner --- src/mesa/state_tracker/st_cb_fbo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index e2303b4..a982f87 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c +++ b/src/mesa

[Mesa-dev] [PATCH 20/22] nv50, nvc0: Support BGRX1010102 format for visuals.

2017-11-28 Thread Mario Kleiner
Add it as displayable/scanout capable, so it can be exposed as valid visual/fbconfig. Signed-off-by: Mario Kleiner --- src/gallium/drivers/nouveau/nv50/nv50_formats.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_formats.c b/src/gallium/drivers

[Mesa-dev] [PATCH 12/22] egl/x11: Handle depth 30 drawables for EGL_KHR_image_pixmap.

2017-11-28 Thread Mario Kleiner
. Suggested-by: Eric Engestrom Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/platform_x11.c | 3 +++ src/egl/drivers/dri2/platform_x11_dri3.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c index 8e48376

[Mesa-dev] [PATCH 17/22] st/dri2: Add format translations for BGR[A/X]1010102 formats.

2017-11-28 Thread Mario Kleiner
Signed-off-by: Mario Kleiner --- src/gallium/state_trackers/dri/dri2.c | 28 1 file changed, 28 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index a70f37f..b8333f6 100644 --- a/src/gallium/state_trackers

[Mesa-dev] [PATCH 09/22] mesa: Add GL_RGBA + GL_UNSIGNED_INT_2_10_10_10_REV for OES read type.

2017-11-28 Thread Mario Kleiner
-EGL.functional.wide_color.window_1010102_colorspace_default. Signed-off-by: Mario Kleiner --- src/mesa/main/framebuffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c index b17d7cb..a0de669 100644 --- a/src/mesa/main/framebuffer.c +++ b/src/mesa/main/framebuffer.c @@ -889,6

[Mesa-dev] [PATCH 14/22] egl/wayland: Add Wayland dmabuf support for RGB10 winsys buffers. (v2)

2017-11-28 Thread Mario Kleiner
Successfully tested under Weston 3.0. Photometer confirms 10 rgb bits from rendering to display. v2: Rebased onto master for dri2_teardown_wayland(). Signed-off-by: Mario Kleiner --- src/egl/drivers/dri2/egl_dri2.h | 2 ++ src/egl/drivers/dri2/platform_wayland.c | 18

[Mesa-dev] [PATCH 21/22] st/dri: Add support for BGR[A/X]1010102 formats.

2017-11-28 Thread Mario Kleiner
Exposes RGBA 10 10 10 2 and 10 10 10 0 visuals and fbconfigs for rendering. Signed-off-by: Mario Kleiner --- src/gallium/state_trackers/dri/dri_screen.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri_screen.c b/src/gallium

[Mesa-dev] [PATCH 19/22] st/dri: Support texture_from_pixmap for BGR[A/X]1010102 formats.

2017-11-28 Thread Mario Kleiner
Signed-off-by: Mario Kleiner --- src/gallium/state_trackers/dri/dri_drawable.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri_drawable.c b/src/gallium/state_trackers/dri/dri_drawable.c index 92ce9d2..a5999be 100644 --- a/src/gallium/state_trackers/dri

Re: [Mesa-dev] [PATCH 20/22] nv50, nvc0: Support BGRX1010102 format for visuals.

2017-11-30 Thread Mario Kleiner
h 30 from what i can see. Not sure if this is due to the way my demos handle this though and there might be other cases that misbehave like you describe. Unfortunately nv50/g80_defs.xml.h doesn't define a BGR10 surface format without alpha channel. -mario Cheers, -ilia On Tue, Nov 2

Re: [Mesa-dev] [PATCH 22/22] st/dri: Add option to control exposure of 10 bpc color configs.

2017-12-13 Thread Mario Kleiner
h an alpha channel? The third option would be to replace that patch with one that disables the rgb10 support for visuals on nouveau completely until we have a solution for properly emulating xrgb201010 on nouveau to cover such corner cases? -mario On Wed, Nov 29, 2017 at 5:21 AM, Mario Klei

Re: [Mesa-dev] [PATCH 22/22] st/dri: Add option to control exposure of 10 bpc color configs.

2017-12-15 Thread Mario Kleiner
test to do... -mario On 12/13/2017 05:27 PM, Marek Olšák wrote: Mario, can we push these patches? Marek On Wed, Nov 29, 2017 at 5:21 AM, Mario Kleiner wrote: Some clients may not like rgb10 fbconfigs and visuals. Support driconf option 'allow_rgb10_configs' on gallium to allow per app

[Mesa-dev] [PATCH 04/22] loader/dri3: Add XRGB2101010 and ARGB2101010 support.

2017-12-15 Thread Mario Kleiner
To allow DRI3/Present buffer sharing for 10 bpc buffers. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- src/loader/loader_dri3_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c

[Mesa-dev] Mesa 30 bit color depth patches, rev 4.

2017-12-15 Thread Mario Kleiner
This is mostly the same as the last series rev 3, with the following changes: 1. Rebased onto current master, some trivial merge conflict resolved. 2. R-b's of Tapani and Marek tacked onto all patches. Only the new patch 22/22 is new and unreviewed. 3. Following Tapani's suggestion i moved ol

[Mesa-dev] [PATCH 02/22] i965: Support accelerated blit for depth 30 formats. (v2)

2017-12-15 Thread Mario Kleiner
h to exclude XRGB2101010 -> ARGB2101010, as intel_miptree_set_alpha_to_one() isn't ready to set 2 bit alpha channels to 1.0 yet. However, couldn't find a test case where this specific blit would be needed, so maybe not much of a point to improve here. Signed-off-by: Mario Kle

[Mesa-dev] [PATCH 01/22] i965: Support xrgb/argb2101010 formats for glx_texture_from_pixmap.

2017-12-15 Thread Mario Kleiner
Makes compositing under X11/GLX work. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_tex_image.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri

[Mesa-dev] [PATCH 03/22] dri: Add 10 bpc formats as available formats. (v2)

2017-12-15 Thread Mario Kleiner
ck of definitions, as suggested by Tapani. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- include/GL/internal/dri_interface.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/inclu

[Mesa-dev] [PATCH 06/22] i965/screen: Add basic support for rendering 10 bpc/depth 30 framebuffers. (v3)

2017-12-15 Thread Mario Kleiner
require. Thanks Emil! Update num_formats from 3 to 5, to keep the special Android handling intact. v3: Use num_formats = ARRAY_SIZE(formats) - 2 as suggested by Tapani, to only exclude the last 2 Android formats, add Tapani's r-b. Signed-off-by: Mario Kleiner Reviewed-by: Tapani

[Mesa-dev] [PATCH 07/22] dri/common: Add option to allow exposure of 10 bpc color configs. (v2)

2017-12-15 Thread Mario Kleiner
to option parsing, to make sure it stays before the ->InitScreen(). Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- src/mesa/drivers/dri/common/dri_util.c | 12 src/util/xmlpool/t_options.h | 5 + 2 files changed, 13 ins

[Mesa-dev] [PATCH 05/22] i965/screen: Add XRGB2101010 and ARGB2101010 support for DRI3.

2017-12-15 Thread Mario Kleiner
Allow DRI3/Present buffer sharing for 10 bpc buffers. Otherwise composited desktops under DRI3 will only display black client areas for redirected windows. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_screen.c | 6 ++ 1 file changed, 6

[Mesa-dev] [PATCH 12/22] egl/x11: Handle depth 30 drawables for EGL_KHR_image_pixmap.

2017-12-15 Thread Mario Kleiner
. Suggested-by: Eric Engestrom Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- src/egl/drivers/dri2/platform_x11.c | 3 +++ src/egl/drivers/dri2/platform_x11_dri3.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src

[Mesa-dev] [PATCH 11/22] egl/x11: Handle depth 30 drawables under software rasterizer.

2017-12-15 Thread Mario Kleiner
For fixing eglCreateWindowSurface() under swrast, as tested with LIBGL_ALWAYS_SOFTWARE=1. Suggested-by: Eric Engestrom Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- src/egl/drivers/dri2/platform_x11.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[Mesa-dev] [PATCH 08/22] i965/screen: Honor 'allow_rgb10_configs' option. (v2)

2017-12-15 Thread Mario Kleiner
Allows to prevent exposing RGB10 configs and visuals to clients. v2: Rename expose_rgb10_configs to allow_rgb10_configs, as suggested by Emil. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli --- src/mesa/drivers/dri/i965/intel_screen.c | 19 +++ 1 file changed, 19

[Mesa-dev] [PATCH 10/22] egl/x11: Match depth 30 RGB visuals to 32-bit RGBA EGLConfigs.

2017-12-15 Thread Mario Kleiner
for egl configs, which are fixed by this commit. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- src/egl/drivers/dri2/platform_x11.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2

[Mesa-dev] [PATCH 09/22] mesa: Add GL_RGBA + GL_UNSIGNED_INT_2_10_10_10_REV for OES read type.

2017-12-15 Thread Mario Kleiner
-EGL.functional.wide_color.window_1010102_colorspace_default. Signed-off-by: Mario Kleiner Reviewed-by: Tapani Pälli Reviewed-by: Marek Olšák --- src/mesa/main/framebuffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/framebuffer.c b/src/mesa/main/framebuffer.c index b17d7cb..a0de669 100644 --- a/src/mesa/main

[Mesa-dev] [PATCH 14/22] egl/wayland: Add Wayland dmabuf support for RGB10 winsys buffers. (v2)

2017-12-15 Thread Mario Kleiner
Successfully tested under Weston 3.0. Photometer confirms 10 rgb bits from rendering to display. v2: Rebased onto master for dri2_teardown_wayland(). Signed-off-by: Mario Kleiner Reviewed-by: Marek Olšák --- src/egl/drivers/dri2/egl_dri2.h | 2 ++ src/egl/drivers/dri2

[Mesa-dev] [PATCH 20/22] st/dri: Add support for BGR[A/X]1010102 formats.

2017-12-15 Thread Mario Kleiner
Exposes RGBA 10 10 10 2 and 10 10 10 0 visuals and fbconfigs for rendering. Signed-off-by: Mario Kleiner Reviewed-by: Marek Olšák --- src/gallium/state_trackers/dri/dri_screen.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri

[Mesa-dev] [PATCH 16/22] st/mesa: Handle BGR[A/X]1010102 formats.

2017-12-15 Thread Mario Kleiner
Signed-off-by: Mario Kleiner Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_cb_fbo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index e2303b4..a982f87 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c

[Mesa-dev] [PATCH 15/22] egl/wayland: Add Wayland shm swrast support for RGB10 winsys buffers.

2017-12-15 Thread Mario Kleiner
Signed-off-by: Mario Kleiner Reviewed-by: Marek Olšák --- src/egl/drivers/dri2/platform_wayland.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/egl/drivers/dri2/platform_wayland.c b/src/egl/drivers/dri2/platform_wayland.c index 7451027..4a0b8c2

[Mesa-dev] [PATCH 19/22] st/dri: Support texture_from_pixmap for BGR[A/X]1010102 formats.

2017-12-15 Thread Mario Kleiner
Signed-off-by: Mario Kleiner Reviewed-by: Marek Olšák --- src/gallium/state_trackers/dri/dri_drawable.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri_drawable.c b/src/gallium/state_trackers/dri/dri_drawable.c index 92ce9d2..a5999be 100644 --- a/src

[Mesa-dev] [PATCH 13/22] egl/wayland: Add Wayland drm support for RGB10 winsys buffers.

2017-12-15 Thread Mario Kleiner
Successfully tested under Weston 3.0. Photometer confirms 10 rgb bits from rendering to display. Signed-off-by: Mario Kleiner Reviewed-by: Marek Olšák --- src/egl/drivers/dri2/platform_wayland.c | 37 --- src/egl/wayland/wayland-drm/wayland-drm.c | 6 + 2

[Mesa-dev] [PATCH 22/22] mesa: Add GL_UNSIGNED_INT_2_10_10_10_REV OES read type for BGRX1010102.

2017-12-15 Thread Mario Kleiner
gallium r600 driver with a (quickly hacked for RGBA 10 10 10 0) dEQP testcase dEQP-EGL.functional.wide_color.window_1010102_colorspace_default. Suggested-by: Marek Olšák Signed-off-by: Mario Kleiner --- src/mesa/main/framebuffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

  1   2   3   >