On 16/09/17 00:06, Jason Ekstrand wrote:
On Fri, Sep 15, 2017 at 7:11 AM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
This change introduce the concept of planes for image & views. It
matches the planes available in new formats.
We also refa
Reviewed-by: Lionel Landwerlin
On 15/09/17 17:01, Jason Ekstrand wrote:
---
src/intel/vulkan/anv_image.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 63e507a..202becc 100644
Reviewed-by: Lionel Landwerlin
On 15/09/17 17:01, Jason Ekstrand wrote:
---
src/intel/vulkan/anv_image.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 492b341..63e507a 100644
--- a/src/intel/vulkan/anv_image.c
+++ b
Reviewed-by: Lionel Landwerlin
On 19/09/17 21:33, Jason Ekstrand wrote:
Fixes: 1d0be5b3fe548ee33d4520092f583c76d42510a6
Cc: Emil Velikov
---
src/egl/wayland/wayland-drm/wayland-drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/wayland/wayland-drm/wayland
Reviewed-by: Lionel Landwerlin
On 19/09/17 22:49, Jason Ekstrand wrote:
This makes the C code be justified over to the left.
---
src/intel/vulkan/anv_entrypoints_gen.py | 392
1 file changed, 196 insertions(+), 196 deletions(-)
diff --git a/src/intel/vulkan
On 19/09/17 20:02, Jason Ekstrand wrote:
+ if (image->shadow_surface.isl.size > 0 &&
+ isl_format_is_compressed(view.format) &&
+ (flags & ANV_IMAGE_VIEW_STATE_TEXTURE_OPTIMAL)) {
+ assert(isl_format_is_compressed(surface->isl.format));
Reviewed-by: Lionel Landwerlin
On 15/09/17 17:01, Jason Ekstrand wrote:
In order to get support everywhere, this gets a bit complicated. On Sky
Lake and later, everything is fine because HALIGN/VALIGN are specified
in surface elements and are required to be at least 4 so any offsetting
we may
Reviewed-by: Lionel Landwerlin
On 15/09/17 17:01, Jason Ekstrand wrote:
The Broadawell method of handling uncompressed views of compressed
s/Broadawell/Broadwell/
textures was to make the texture linear and have a tiled shadow copy.
This isn't needed on Sky Lake because the HALIG
Reviewed-by: Lionel Landwerlin
On 15/09/17 17:01, Jason Ekstrand wrote:
---
src/intel/vulkan/anv_extensions.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_extensions.py
b/src/intel/vulkan/anv_extensions.py
index acec785..52390fe 100644
--- a/src/intel/vulkan
Reviewed-by: Lionel Landwerlin
On 25/09/17 11:34, kevin.rogo...@intel.com wrote:
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/intel/tools/disasm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c
index
On 25/09/17 11:34, kevin.rogo...@intel.com wrote:
From: Kevin Rogovin
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
b/src/mesa/drivers/dri/i965/genX_state_uplo
My bad, looks good :
Reviewed-by: Lionel Landwerlin
On 25/09/17 13:30, Rogovin, Kevin wrote:
Hi,
The value is the number of entries, not the size in bytes;
BindingTableEntryCount for compute/media is programmed the same way as for all
the other shader stages (where they too are divided
I'm genuinely surprised we didn't noticed this problem before :|
Fixes: 71bfb44005bf ("i965: Port brw_cs_state tracked state to genxml.")
Reviewed-by: Lionel Landwerlin
Cc: "17.2"
On 25/09/17 11:34, kevin.rogo...@intel.com wrote:
From: Kevin Rogovin
Signed-of
On 18/09/17 20:27, Jason Ekstrand wrote:
On Sun, Sep 17, 2017 at 3:31 AM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
On 15/09/17 23:36, Jason Ekstrand wrote:
struct anv_format_plane {
enum isl_format isl_format:16;
struct isl_s
On 15/09/17 23:54, Jason Ekstrand wrote:
On Fri, Sep 15, 2017 at 7:11 AM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
Signed-off-by: Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>>
---
src/intel/vulkan/anv_descriptor_set.c
A few months ago I implemented debug messages in the command stream by
stuffing the unused bits of MI_NOOP :
https://patchwork.freedesktop.org/series/26079/
Aubinator would then read the bits and print the messages.
We might be able to reuse similar idea to get away with any external
interfac
o Maciel
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_cmd_buffer.c | 35 +--
src/intel/vulkan/anv_private.h| 2 +-
2 files changed, 30 insertions(+), 7 deletions(-)
diff --git a/src/intel/vulkan/anv_cmd_buffer.c
b/src/intel/vulkan/anv_cmd_buf
Reviewed-by: Lionel Landwerlin
On 28/09/17 01:02, Jason Ekstrand wrote:
This is just legacy cruft. We don't push these values; we pass them in
as vertex attributes.
---
src/intel/vulkan/anv_private.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/src/intel/vulkan/anv_privat
, 138,466,600 bytes allocated
LEAK SUMMARY:
definitely lost: 1,068 bytes in 11 blocks
indirectly lost: 24,669 bytes in 412 blocks
possibly lost: 0 bytes in 0 blocks
still reachable: 2,441,776 bytes in 882 blocks
suppressed: 0 bytes in 0 blocks
Signed-off-by: Lionel Landwerlin
ors from system memory rather than in BO
streams. (Lionel)
Cc: "17.2 17.1"
Fixes: 9f60ed98e501 ("anv: add VK_KHR_push_descriptor support")
Reported-by: Daniel Ribeiro Maciel
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_cmd_buffer.c | 58
On 29/09/17 01:05, Lionel Landwerlin wrote:
Valgrind stats on
dEQP-VK.pipeline.push_constant.graphics_pipeline.range_size_128 :
I obviously inverted before & after...
Before:
HEAP SUMMARY:
in use at exit: 2,467,381 bytes in 1,304 blocks
total heap usage: 697,853 allocs, 696,531 f
On 29/09/17 04:23, Matt Turner wrote:
On Fri, Sep 15, 2017 at 9:01 AM, Jason Ekstrand wrote:
---
src/intel/blorp/blorp_clear.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/src/intel/blorp/blorp_clear.c b/src/intel/blorp/blorp_clear.c
index 0fe
Make sense, if you could just update the comment in the unreachable(),
should be multiple of 4.
With that changed :
Reviewed-by: Lionel Landwerlin
The dstOffset and fillSize parameters must be multiple of 4.
---
src/intel/vulkan/anv_blorp.c | 2 --
1 file changed, 2 deletions(-)
diff --git
I guess it makes things clearer.
Does this fix something?
On 02/10/17 18:58, Józef Kucia wrote:
The vkCmdFillBuffer() command fills a buffer with an uint32_t value.
---
src/intel/vulkan/anv_blorp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/anv_bl
Thanks, I modified the CTS slightly to reproduce the problem (will try
to send it upstream).
Reviewed-by: Lionel Landwerlin
On 02/10/17 20:41, Józef Kucia wrote:
On Mon, Oct 2, 2017 at 9:19 PM, Lionel Landwerlin
wrote:
I guess it makes things clearer.
Does this fix something?
Yes, it
We handle similar default valid for LOD in the fs backend for TXS/TXL.
Without this we end up generating invalid MOV with a null src.
Signed-off-by: Lionel Landwerlin
Cc: "17.2 17.1"
---
src/intel/compiler/brw_vec4_nir.cpp | 9 +
1 file changed, 9 insertions(+)
diff --git a
Hi all,
Here is a v2 of KHR_sampler_ycbcr_conversion. The major change is the
decoupling of descriptors from the binding table elements (patch 7).
This is available on the following branch :
https://github.com/djdeath/mesa/tree/wip/djdeath/ycbcr_conversion
Cheers,
Lionel Landwerlin (11
Some description was missing.
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl_format_layout.csv | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/isl/isl_format_layout.csv
b/src/intel/isl/isl_format_layout.csv
index f340e30a1bf..ebb3d22bc18 100644
Newer format enums start at offset 10, making it impossible to
have them all in one table. This change splits the formats into sets
that we then access through indirection.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_formats.c | 35 ++-
1
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl.h | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index df275f85c49..98de4c0f57f 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel/isl/isl.h
@@ -994,15
v2: Simplify offset enum computation (Jason)
Signed-off-by: Lionel Landwerlin
---
src/vulkan/util/vk_util.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/vulkan/util/vk_util.h b/src/vulkan/util/vk_util.h
index 2ed601f881e..8c8cb64d513 100644
--- a/src/vulkan/util/vk_util.h
+++ b
v2: Drop a memset by using zalloc (Jason)
Decouple vulkan descriptors from the underlying binding table
(Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c| 24 -
src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 66
Adding new downsampling factors for each planes.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_formats.c| 158 --
src/intel/vulkan/anv_private.h| 10 +++
src/intel/vulkan/vk_format_info.h | 27 +++
3 files changed, 189 insertions
New settings from the KHR_sampler_ycbcr_conversion specifications
might require different sampler settings for luma and chroma planes.
This change makes the sampler table emission ready to handle multiple
planes.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_private.h | 2
This pass implements all the implicit conversions required by the
VK_KHR_sampler_ycbcr_conversion specification.
It also inserts plane sources onto sampling instructions that we then
let the pipeline layout pass deal with, when mapping things correctly
to descriptors.
Signed-off-by: Lionel
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_device.c | 69 +-
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_formats.c | 59
src/intel/vulkan/anv_image.c | 42
A given Vulkan format can now be decomposed into a set of planes. We
now use 'struct anv_format_plane' to represent the format of those
planes.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_blorp.c | 31 +--
src/intel/vulkan/anv_formats
Reviewed-by: Lionel Landwerlin
On 05/09/17 16:12, Jason Ekstrand wrote:
This looks like a copy+paste error. They don't actually write into that
variable as would be implied by putting the return there.
---
src/compiler/glsl/glsl_to_nir.cpp | 2 --
src/compiler/nir/nir_intrinsics.
Reviewed-by: Lionel Landwerlin
On 05/09/17 16:12, Jason Ekstrand wrote:
---
src/intel/compiler/brw_fs_nir.cpp | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/src/intel/compiler/brw_fs_nir.cpp
b/src/intel/compiler/brw_fs_nir.cpp
index d760946..18c5fc6 100644
On 03/10/17 18:09, Chad Versace wrote:
On Tue 03 Oct 2017, Lionel Landwerlin wrote:
Some description was missing.
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl_format_layout.csv | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/isl
On 03/10/17 19:13, Jason Ekstrand wrote:
On Tue, Oct 3, 2017 at 9:43 AM, Chad Versace <mailto:chadvers...@chromium.org>> wrote:
On Tue 03 Oct 2017, Lionel Landwerlin wrote:
> v2: Simplify offset enum computation (Jason)
>
> Signed-off-by:
On 03/10/17 21:21, Chad Versace wrote:
On Tue 03 Oct 2017, Lionel Landwerlin wrote:
On 03/10/17 19:13, Jason Ekstrand wrote:
On Tue, Oct 3, 2017 at 9:43 AM, Chad Versace <[1]chadvers...@chromium.org>
wrote:
On Tue 03 Oct 2017, Lionel Landwerlin wrote:
On 04/10/17 02:16, Jason Ekstrand wrote:
Ok, maybe I'm being a bit dense, but doesn't the aspect imply the
plane? Why can't we just use anv_image_aspect_to_plane here? That
would reduce the churn by a good bit.
enum isl_aux_usage aux_usage,
On 04/10/17 00:54, Jason Ekstrand wrote:
On Tue, Oct 3, 2017 at 9:29 AM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
This pass implements all the implicit conversions required by the
VK_KHR_sampler_ycbcr_conversion specification.
It also inserts plane s
On 04/10/17 00:58, Jason Ekstrand wrote:
+ struct ycbcr_state state = {
+ .builder = builder,
+ .origin_tex = tex,
+ .conversion = sampler->conversion,
What about arrays of samplers? You're not allowed to indirect on them
but they can, in the
On 04/10/17 00:40, Chad Versace wrote:
On Tue 03 Oct 2017, Jason Ekstrand wrote:
On Tue, Oct 3, 2017 at 3:18 PM, Lionel Landwerlin <[1]
lionel.g.landwer...@intel.com> wrote:
On 03/10/17 21:21, Chad Versace wrote:
On Tue 03 Oct 2017, Lionel Landwerlin wrote:
Hi,
A quick update following the comments for the first patches. I suppose
newer comments will appear but probably from patch 7 onwards.
Cheers,
Lionel Landwerlin (12):
vulkan: util: add macros to extract extension/offset number from enums
isl: make format layout channels accessible by
Signed-off-by: Lionel Landwerlin
Reviewed-by: Chad Versace
---
src/intel/isl/isl.h | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index df275f85c49..98de4c0f57f 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel
Suggested by Chad.
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index 98de4c0f57f..e3acb0ec280 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel/isl/isl.h
@@ -1512,6 +1512,8 @@ enum
v2: Simplify offset enum computation (Jason)
v3: capitalize macros (Chad)
Signed-off-by: Lionel Landwerlin
---
src/vulkan/util/vk_util.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/vulkan/util/vk_util.h b/src/vulkan/util/vk_util.h
index 2ed601f881e..4c18a196b71 100644
--- a
Some description was missing.
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl_format_layout.csv | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/isl/isl_format_layout.csv
b/src/intel/isl/isl_format_layout.csv
index f340e30a1bf..ebb3d22bc18 100644
Adding new downsampling factors for each planes.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_formats.c| 158 --
src/intel/vulkan/anv_private.h| 10 +++
src/intel/vulkan/vk_format_info.h | 27 +++
3 files changed, 189 insertions
v2: Drop a memset by using zalloc (Jason)
Decouple vulkan descriptors from the underlying binding table
(Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_descriptor_set.c| 24 -
src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 66
s_fmt() by fmt2()
Introduce fmt_unsupported()
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_blorp.c | 18 +-
src/intel/vulkan/anv_formats.c | 512 +--
src/intel/vulkan/anv_image.c | 12 +-
src/intel/vulkan/anv_private.h | 54 -
s
New settings from the KHR_sampler_ycbcr_conversion specifications
might require different sampler settings for luma and chroma planes.
This change makes the sampler table emission ready to handle multiple
planes.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_private.h | 2
Newer format enums start at offset 10, making it impossible to
have them all in one table. This change splits the formats into sets
that we then access through indirection.
v2: rename format_extract to vk_to_anv_format (Chad/Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan
build (Lionel)
Use nir_frcp() rather than (1.0f / x) (Jason)
Reuse nir_tex_instr_dest_size() rather than handwritten one (Jason)
Return progress (Jason)
Account for array of samplers (Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/Makefile.sources | 1
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_device.c | 51 ++--
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_formats.c | 59 ++
src/intel/vulkan/anv_image.c | 42
All of these changed were made :)
On 04/10/17 22:32, Jason Ekstrand wrote:
On Wed, Oct 4, 2017 at 10:34 AM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
This pass implements all the implicit conversions required by the
VK_KHR_sampler_ycbcr_conv
Some description was missing.
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl_format_layout.csv | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/isl/isl_format_layout.csv
b/src/intel/isl/isl_format_layout.csv
index f340e30a1bf..ebb3d22bc18 100644
Signed-off-by: Lionel Landwerlin
Reviewed-by: Chad Versace
---
src/intel/isl/isl.h | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index df275f85c49..98de4c0f57f 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel
v2: Simplify offset enum computation (Jason)
v3: capitalize macros (Chad)
Signed-off-by: Lionel Landwerlin
---
src/vulkan/util/vk_util.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/vulkan/util/vk_util.h b/src/vulkan/util/vk_util.h
index 2ed601f881e..4c18a196b71 100644
--- a
Hopefully this address most of the comments. The might be improvement
around aspects <-> plane mapping.
Cheers,
Lionel Landwerlin (12):
vulkan: util: add macros to extract extension/offset number from enums
isl: make format layout channels accessible by index
isl: check whether a for
---
src/intel/vulkan/anv_descriptor_set.c| 13 +++
src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 113 ++-
src/intel/vulkan/anv_private.h | 7 ++
src/intel/vulkan/genX_state.c| 2 +
4 files changed, 113 insertions(+), 2
build (Lionel)
Use nir_frcp() rather than (1.0f / x) (Jason)
Reuse nir_tex_instr_dest_size() rather than handwritten one (Jason)
Return progress (Jason)
Account for array of samplers (Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/Makefile.sources | 1
v2: Make GetImageMemoryRequirements2KHR() iterate over all pInfo
structs (Lionel)
Handle VkSamplerYcbcrConversionImageFormatPropertiesKHR (Andrew/Jason)
Iterator over BindImageMemory2KHR's pNext structs correctly (Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/v
New settings from the KHR_sampler_ycbcr_conversion specifications
might require different sampler settings for luma and chroma planes.
This change makes the sampler table emission ready to handle multiple
planes.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_private.h | 2
s_fmt() by fmt2()
Introduce fmt_unsupported()
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_blorp.c | 18 +-
src/intel/vulkan/anv_formats.c | 512 ++---
src/intel/vulkan/anv_image.c | 8 +-
src/intel/vulkan/anv_private.h | 49 +++-
4 files changed,
Newer format enums start at offset 10, making it impossible to
have them all in one table. This change splits the formats into sets
that we then access through indirection.
v2: rename format_extract to vk_to_anv_format (Chad/Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan
Suggested by Chad.
Signed-off-by: Lionel Landwerlin
---
src/intel/isl/isl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index 98de4c0f57f..e3acb0ec280 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel/isl/isl.h
@@ -1512,6 +1512,8 @@ enum
Adding new downsampling factors for each planes.
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_formats.c| 158 --
src/intel/vulkan/anv_private.h| 10 +++
src/intel/vulkan/vk_format_info.h | 27 +++
3 files changed, 189 insertions
On 05/10/17 17:36, Dylan Baker wrote:
Quoting Lionel Landwerlin (2017-10-04 10:34:55)
This pass implements all the implicit conversions required by the
VK_KHR_sampler_ycbcr_conversion specification.
It also inserts plane sources onto sampling instructions that we then
let the pipeline layout
I fixed a similar bug in the vec4 backend a couple of days ago.
Can we maybe put this logic somewhere that could reused across backends?
Or maybe a nir pass to add the missing parameters?
Thanks,
-
Lionel
On 06/10/17 14:07, Jason Ekstrand wrote:
Is there a test case for this?
Reviewed-by: Jas
Reviewed-by: Lionel Landwerlin
On 06/10/17 04:47, Jason Ekstrand wrote:
---
src/compiler/spirv/spirv_to_nir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/compiler/spirv/spirv_to_nir.c
index a2538d6..5dccbf6 100644
--- a/src
Signed-off-by: Lionel Landwerlin
Reviewed-by: Chad Versace
Reviewed-by: Jason Ekstrand
---
src/intel/isl/isl.h | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index df275f85c49..98de4c0f57f 100644
--- a/src
Suggested by Chad.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel/isl/isl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
index 98de4c0f57f..e3acb0ec280 100644
--- a/src/intel/isl/isl.h
+++ b/src/intel/isl/isl.h
v2: Simplify offset enum computation (Jason)
v3: capitalize macros (Chad)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/vulkan/util/vk_util.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/vulkan/util/vk_util.h b/src/vulkan/util/vk_util.h
index
anv_layout_to_aux_usage
anv: Take an image in can_sample_with_hiz
Lionel Landwerlin (12):
vulkan: util: add macros to extract extension/offset number from enums
isl: make format layout channels accessible by index
isl: check whether a format is rgb if colorspace is yuv
isl: fill out layout descriptions for
Adding new downsampling factors for each planes.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_formats.c| 158 --
src/intel/vulkan/anv_private.h| 10 +++
src/intel/vulkan/vk_format_info.h | 27 +++
3
Some description was missing.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel/isl/isl_format_layout.csv | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/intel/isl/isl_format_layout.csv
b/src/intel/isl/isl_format_layout.csv
index
Newer format enums start at offset 10, making it impossible to
have them all in one table. This change splits the formats into sets
that we then access through indirection.
v2: rename format_extract to vk_to_anv_format (Chad/Jason)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_descriptor_set.c| 13 +++
src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 113 ++-
src/intel/vulkan/anv_private.h | 7 ++
src/intel/vulkan/genX_state.c
s_fmt() by fmt2()
Introduce fmt_unsupported()
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan/anv_blorp.c | 18 +-
src/intel/vulkan/anv_formats.c | 512 ++---
src/intel/vulkan/anv_image.c | 8 +-
src/intel/vulkan/anv_private.
New settings from the KHR_sampler_ycbcr_conversion specifications
might require different sampler settings for luma and chroma planes.
This change makes the sampler table emission ready to handle multiple
planes.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel/vulkan
From: Jason Ekstrand
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/genX_cmd_buffer.c | 46 --
1 file changed, 24 insertions(+), 22 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c
b/src/intel/vulkan/genX_cmd_buffer.c
index f19746db442
From: Jason Ekstrand
A good chunk of anv_blorp just wants the aux usage from the image. This
magic aux_usage value means just that.
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_blorp.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git
build (Lionel)
Use nir_frcp() rather than (1.0f / x) (Jason)
Reuse nir_tex_instr_dest_size() rather than handwritten one (Jason)
Return progress (Jason)
Account for array of samplers (Jason)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel
From: Jason Ekstrand
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_blorp.c | 3 +--
src/intel/vulkan/anv_image.c | 2 +-
src/intel/vulkan/anv_private.h | 14 --
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel
From: Jason Ekstrand
Reviewed-by: Lionel Landwerlin
---
src/intel/vulkan/anv_image.c | 21 +
src/intel/vulkan/anv_private.h | 2 +-
src/intel/vulkan/genX_cmd_buffer.c | 10 +-
3 files changed, 15 insertions(+), 18 deletions(-)
diff --git a/src/intel
om v2 (Jason)
Signed-off-by: Lionel Landwerlin
---
src/intel/vulkan/anv_device.c | 45 +
src/intel/vulkan/anv_extensions.py | 1 +
src/intel/vulkan/anv_formats.c | 83 ++
src/intel/vulkan/anv_image.c | 21 +-
src/intel/v
On 06/10/17 15:52, Jason Ekstrand wrote:
to get rid of the reference that he source carries to the load_const
SSA def. Sorry that's not terribly intuitive.
Applied locally.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freed
On 06/10/17 16:31, Samuel Iglesias Gonsálvez wrote:
On Fri, 2017-10-06 at 08:28 -0700, Jason Ekstrand wrote:
On Fri, Oct 6, 2017 at 6:36 AM, Samuel Iglesias Gonsálvez
mailto:sigles...@igalia.com>> wrote:
On Fri, 2017-10-06 at 14:23 +0100, Lionel Landwerlin wrote:
I fixed a similar bug
ors from system memory rather than in BO
streams. (Lionel)
Cc: "17.2 17.1"
Fixes: 9f60ed98e501 ("anv: add VK_KHR_push_descriptor support")
Reported-by: Daniel Ribeiro Maciel
Signed-off-by: Lionel Landwerlin
Reviewed-by: Jason Ekstrand
---
src/intel/
Another roll of this series with a quick change in patch 2 which
reuses anv_cmd_state_reset() to destroy a command buffer cleanly.
Cheers,
Lionel Landwerlin (2):
anv: fix push descriptors with set > 0
anv: fix potential push constant buffer leaks
src/intel/vulkan/anv_cmd_buffer.c |
, 138,466,600 bytes allocated
LEAK SUMMARY:
definitely lost: 1,068 bytes in 11 blocks
indirectly lost: 24,669 bytes in 412 blocks
possibly lost: 0 bytes in 0 blocks
still reachable: 2,441,776 bytes in 882 blocks
suppressed: 0 bytes in 0 blocks
Signed-off-by: Lionel Landwerlin
Looks like pretty much everywhere we're include nir/nir.h
So I guess I should fix the ycbcr pass.
Thanks for digging this though!
On 07/10/17 18:15, Dylan Baker wrote:
Signed-off-by: Dylan Baker
Fixes: f3e91e78a337 ("anv: add nir lowering pass for ycbcr textures")
cc: Li
All over mesa we include "nir/nir.h", we should probably do the same
here. This fixes the meson build that was broken by the ycbcr series.
Thanks to Dylan for finding the issue.
Signed-off-by: Lionel Landwerlin
Fixes: f3e91e78a337 ("anv: add nir lowering pass for ycbcr textu
On 07/10/17 22:44, Jason Ekstrand wrote:
Previously, we allocated memory for image->plane[0].surface.isl.size
which is great if there is no compression. However, on BDW, we can do
CCS_D on X-tiled images so we also have to allocate space for the
auxiliary buffer. This fixes hangs in some of the
On 07/10/17 23:23, Jason Ekstrand wrote:
On Sat, Oct 7, 2017 at 3:10 PM, Lionel Landwerlin
mailto:lionel.g.landwer...@intel.com>>
wrote:
On 07/10/17 22:44, Jason Ekstrand wrote:
Previously, we allocated memory for
image->plane[0].surface.isl.si <http://surfa
Reviewed-by: Lionel Landwerlin
On 09/10/17 06:19, Tapani Pälli wrote:
CID: 1419033
Signed-off-by: Tapani Pälli
---
src/intel/vulkan/anv_image.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 487ff27594..c8ebdce0b4
701 - 800 of 1915 matches
Mail list logo
