[Mesa-dev] [PATCH 01/33] intel: common: expose gen_spec fields

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 13 - src/intel/common/gen_decoder.h | 13 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 85880143f00

[Mesa-dev] [PATCH 08/33] intel: decoder: don't read qword outside instruction/struct limit

: 0x : Dword 3 Immediate Data: 0 Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 11 --- src/intel/common/gen_decoder.h | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH 10/33] intel: decoder: expose helper to test header fields

These fields are of little importance as they're used to recognize instructions. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 6 +++--- src/intel/common/gen_decoder.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decode

[Mesa-dev] [PATCH 05/33] intel: decoder: reorder iterator init function

Making the next change more readable. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 040201541ff

[Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 48d4456cc16..2c4eaab1701 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools

[Mesa-dev] [PATCH 04/33] intel: common: print out all dword with field spanning multiple dwords

Stall At Pixel Scoreboard: false Depth Cache Flush Enable: false 0x000ce138: 0x : Dword 2 Address: 0x 0x000ce140: 0x : Dword 4 Immediate Data: 0 Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 10 ++ 1 file changed, 6

[Mesa-dev] [PATCH 13/33] intel: decoder: pack iterator variable declarations

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 6a6a1f0aca4..cd18580aea8 100644 --- a/src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH 11/33] intel: decoder: add destructor for gen_spec

This makes use of ralloc to simplify the destruction. We can also store instructions in hash tables. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 176 +++-- src/intel/common/gen_decoder.h | 15 ++-- 2 files changed, 90 insertions

[Mesa-dev] [PATCH 15/33] intel: error-decode: implement a rolling window of programs

If we have more programs than what we can store, aubinator_error_decode will assert. Instead let's have a rolling window of programs. v2: Fix overflowing issues (Eric Engestrom) Signed-off-by: Lionel Landwerlin Reviewed-by: Eric Engestrom --- src/intel/tools/aubinator_error_decode.c

[Mesa-dev] [PATCH 16/33] intel: decoder: remove unused platform field

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 2562aa56175..050926f5642 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH 17/33] intel: common: make intel utils available from C++

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.h | 9 + src/intel/common/gen_device_info.h | 8 src/intel/tools/gen_disasm.h | 8 3 files changed, 25 insertions(+) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h

[Mesa-dev] [PATCH 12/33] intel: decoder: simplify creation of struct when 0-allocated

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 4 1 file changed, 4 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 0bf705fa9e1..6a6a1f0aca4 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel/common

[Mesa-dev] [PATCH 21/33] intel: decoder: extract field value computation

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index a63c09cd37e..b0bd161fef3 100644 --- a/src

[Mesa-dev] [PATCH 20/33] intel: decoder: rename field() to field_value()

We would like to avoid collisions with variables named field. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common

[Mesa-dev] [PATCH 14/33] intel: decoder: extract instruction/structs length

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 7 +++ src/intel/common/gen_decoder.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index cd18580aea8..2562aa56175 100644 --- a/src/intel/common

[Mesa-dev] [PATCH 29/33] intel: decoder: change group_get_length() to take first dword

This is a first step in not accessing the dwords through pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 27 +-- src/intel/common/gen_decoder.h| 2 +- src/intel/tools/aubinator.c | 4

[Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

This is required to have output redirected to something else than a file descriptor (stdout). Signed-off-by: Lionel Landwerlin --- src/intel/compiler/brw_compile_clip.c | 5 +- src/intel/compiler/brw_compile_sf.c | 5 +- src/intel/compiler/brw_disasm.c | 645

[Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

We want to introduce a reader interface for accessing memory, so that later on we can use different ways of storing the content of the GTT address space that don't involve a pointer to a linear buffer. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH 07/33] intel: decoder: split out getting the next field and decoding it

Due to the new way we handle fields, we need *not* to forget the first field when decoding instructions. The issue was that the advance function was called first and skipped the first field. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 31

[Mesa-dev] [PATCH 24/33] intel: decoder: enable decoding a single field

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 37 + src/intel/common/gen_decoder.h | 14 ++ 2 files changed, 51 insertions(+) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 1d57d350855

[Mesa-dev] [PATCH 19/33] intel: decoder: rename internal function to free name

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 94e7e15399f..91076e901fe 100644 --- a/src/intel/common/gen_decoder.c +++ b/src/intel

[Mesa-dev] [PATCH 22/33] intel: decoder: expose missing find_enum()

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h index 658dd7f7b09..81b5beb5baf 100644 --- a/src/intel/common/gen_decoder.h +++ b/src/intel/common

[Mesa-dev] [PATCH 23/33] intel: decoder: group enum related declarations

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 8 src/intel/common/gen_decoder.h | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index b0bd161fef3..1d57d350855 100644 --- a/src

[Mesa-dev] [PATCH 30/33] intel: decoder: change find_instruction() to take first dword

Another step into decoupling memory access from pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 4 ++-- src/intel/common/gen_decoder.h| 2 +- src/intel/tools/aubinator.c | 2 +- src/intel/tools

[Mesa-dev] [PATCH 28/33] intel: genxml: rename output urb offset field

"Output Read Offset" is a bit non-sensical, let's just make this match "Output Length". Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml| 6 +++--- src/intel/genxml/gen8.xml | 6 +++--- src/intel/genxml/gen9.xm

[Mesa-dev] [PATCH 18/33] intel: decoder: simplify field_is_header()

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 7 --- src/intel/common/gen_decoder.h | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 050926f5642..94e7e15399f 100644 --- a/src

[Mesa-dev] [PATCH 27/33] intel: genxml: be consistent about register offset naming

Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 8 src/intel/genxml/gen4.xml | 2 +- src/intel/genxml/gen45.xml | 2 +- src/intel/genxml/gen5.xml | 2 +- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml

[Mesa-dev] [PATCH 32/33] intel: decoder: add function to query shader length

Signed-off-by: Lionel Landwerlin --- src/intel/tools/disasm.c | 34 ++ src/intel/tools/gen_disasm.h | 2 ++ 2 files changed, 36 insertions(+) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index e2f5c11f6f5..c038949d9ec 100644 --- a/src

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

On 31/10/17 12:59, Emil Velikov wrote: Hi Lionel, On 30 October 2017 at 16:58, Lionel Landwerlin wrote: create mode 100644 src/intel/tools/aubinator_imgui_widgets.cpp create mode 100644 src/intel/tools/aubinator_imgui_widgets.h create mode 100644 src/intel/tools/aubinator_ui.cpp

Re: [Mesa-dev] [PATCH 09/33] aubinator: print number of dwords per instruction

On 31/10/17 17:59, Scott D Phillips wrote: Lionel Landwerlin writes: Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 48d4456cc16

Re: [Mesa-dev] [PATCH 21/33] intel: decoder: extract field value computation

On 31/10/17 17:29, Scott D Phillips wrote: Lionel Landwerlin writes: Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src

Re: [Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

On 31/10/17 20:54, Scott D Phillips wrote: Lionel Landwerlin writes: We want to introduce a reader interface for accessing memory, so that later on we can use different ways of storing the content of the GTT address space that don't involve a pointer to a linear buffer. I'm kinda

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

Thanks, all fixed locally. On 31/10/17 21:59, Dylan Baker wrote: Quoting Lionel Landwerlin (2017-10-30 09:58:46) [snip] diff --git a/meson.build b/meson.build index 24d997b3e0a..e5e691e276c 100644 --- a/meson.build +++ b/meson.build @@ -43,6 +43,7 @@ pre_args = [ with_vulkan_icd_dir

Re: [Mesa-dev] [PATCH 23/33] intel: decoder: group enum related declarations

On 31/10/17 20:11, Scott D Phillips wrote: Lionel Landwerlin writes: Is this one a rebase error? The commit message doesn't make sense with the patch, and the change from Patch 22 gets reverted here. Yeah, that's wrong. It should be named "enable looking for instruction by n

Re: [Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

On 31/10/17 23:04, Scott D Phillips wrote: Lionel Landwerlin writes: On 31/10/17 20:54, Scott D Phillips wrote: Lionel Landwerlin writes: We want to introduce a reader interface for accessing memory, so that later on we can use different ways of storing the content of the GTT address

Re: [Mesa-dev] [PATCH 25/33] intel: compiler: abstract printing

On 31/10/17 20:25, Scott D Phillips wrote: Lionel Landwerlin writes: This is required to have output redirected to something else than a file descriptor (stdout). an alternative here might be to fdopen() a pipe(). Maybe a bit weird but it could save several hundred lines of change and maybe

Re: [Mesa-dev] [PATCH 31/33] intel: decoder: decouple decoding from memory pointers

On 01/11/17 15:09, Scott D Phillips wrote: Lionel Landwerlin writes: On 31/10/17 23:04, Scott D Phillips wrote: Lionel Landwerlin writes: On 31/10/17 20:54, Scott D Phillips wrote: Lionel Landwerlin writes: We want to introduce a reader interface for accessing memory, so that later on

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

Both patches are : Reviewed-by: Lionel Landwerlin On 01/11/17 16:00, Jason Ekstrand wrote: It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some error cases. ---

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

On 31/10/17 21:11, Scott D Phillips wrote: +} [snip imgui] imgui seems to be the first instance of someone pasting a sizeable third party library into the repo. I'm not sure how everyone feels about that. Unfortunately it seems like imgui isn't packaged by any distros that I can see either. M

[Mesa-dev] [PATCH v2 00/11] intel: UI for aubinator

Hi, A quick update following a number of comments. Scott's suggestion of using aubdumps' mmapped memory to decode instruction instead of another structure isn't implemented yet (I'll probably post a v3 with that). Meanwhile a few other small patches could make it onto mast

[Mesa-dev] [PATCH v2 03/11] intel: decoder: enable search for instruction by name

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 8 src/intel/common/gen_decoder.h | 1 + 2 files changed, 9 insertions(+) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index d09b6ea32b6..736bfd6df16 100644 --- a/src/intel/common

[Mesa-dev] [PATCH v2 01/11] intel: aubinator: factor out MI_BATCH_BUFFER_END

Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 6 -- src/intel/tools/intel_aub.h | 1 + 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 48d4456cc16..728edad37ff 100644 --- a/src/intel/tools

[Mesa-dev] [PATCH v2 02/11] intel: decoder: remove duplicate of gen_spec_find_enum() declaration

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h index 8b00b6edc2f..28bf94b099e 100644 --- a/src/intel/common/gen_decoder.h +++ b/src/intel/common/gen_decoder.h

[Mesa-dev] [PATCH v2 05/11] intel: genxml: be consistent about register offset naming

Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 8 src/intel/genxml/gen4.xml | 2 +- src/intel/genxml/gen45.xml | 2 +- src/intel/genxml/gen5.xml | 2 +- src/intel/genxml/gen6.xml | 2 +- src/intel/genxml/gen7.xml

[Mesa-dev] [PATCH v2 06/11] intel: genxml: rename output urb offset field

"Output Read Offset" is a bit non-sensical, let's just make this match "Output Length". Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml| 6 +++--- src/intel/genxml/gen8.xml | 6 +++--- src/intel/genxml/gen9.xm

[Mesa-dev] [PATCH v2 07/11] intel: decoder: change group_get_length() to take first dword

This is a first step in not accessing the dwords through pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 29 +-- src/intel/common/gen_decoder.h| 2 +- src/intel/tools/aubinator.c | 2

[Mesa-dev] [PATCH v2 08/11] intel: decoder: change find_instruction() to take first dword

Another step into decoupling memory access from pointers. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c| 4 ++-- src/intel/common/gen_decoder.h| 2 +- src/intel/tools/aubinator.c | 2 +- src/intel/tools

[Mesa-dev] [PATCH v2 09/11] intel: decoder: decouple decoding from memory pointers

We want to introduce a reader interface for accessing memory, so that later on we can use different ways of storing the content of the GTT address space that don't involve a pointer to a linear buffer. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c

[Mesa-dev] [PATCH v2 10/11] intel: decoder: add function to query shader length

Signed-off-by: Lionel Landwerlin --- src/intel/tools/disasm.c | 34 ++ src/intel/tools/gen_disasm.h | 2 ++ 2 files changed, 36 insertions(+) diff --git a/src/intel/tools/disasm.c b/src/intel/tools/disasm.c index 251acd313dc..fbf4f9e8999 100644 --- a/src

Re: [Mesa-dev] [PATCH 33/33] intel: add aubinator ui

On 01/11/17 20:30, Dylan Baker wrote: Quoting Scott D Phillips (2017-11-01 10:30:09) Lionel Landwerlin writes: On 31/10/17 21:11, Scott D Phillips wrote: +} [snip imgui] imgui seems to be the first instance of someone pasting a sizeable third party library into the repo. I'm not sur

Re: [Mesa-dev] [PATCH 42.5/48] nir/builder: Add a nir_imm_intN_t helper

Reviewed-by: Lionel Landwerlin On 31/10/17 23:54, Jason Ekstrand wrote: This lets you easily build integer immediates of arbitrary bit size. --- src/compiler/nir/nir_builder.h | 12 1 file changed, 12 insertions(+) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir

Re: [Mesa-dev] [RFC PATCH v1 01/30] anv: Remove unused variable 'gen'

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: In anv_physical_device_get_format_properties(). Reviewed-by: Jason Ekstrand --- src/intel/vulkan/anv_formats.c | 4 1 file changed, 4 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan

Re: [Mesa-dev] [RFC PATCH v1 02/30] anv: Suffix anv-private 'VK' tokens with 'ANV'

ion tokens with the ANV vendor suffix. I found only two such tokens: VK_IMAGE_ASPECT_ANY_COLOR_BIT VK_IMAGE_ASPECT_PLANES_BITS Reviewed-by: Jason Ekstrand Reviewed-by: Lionel Landwerlin ___ mesa-dev mailing list mesa-dev@lists.freedesktop

Re: [Mesa-dev] [RFC PATCH v1 03/30] anv: Refactor get_buffer_format_properties()

On 07/11/17 14:47, Chad Versace wrote: Make it a stand-alone function. Pre-patch, for some formats the function returned incorrect VkFormatFeatureFlags which were cleaned up by the caller. This prepares for a cleaner implementation of VK_EXT_image_drm_format_modifier. Reviewed-by: Jason Ekstran

Re: [Mesa-dev] [RFC PATCH v1 04/30] anv: Better types for 'aspect' function params

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Some functions have a comment that says "Exactly one bit must be in 'aspect'". So change the type of their 'aspect' parameter from VkImageAspectFlags to VkImageAspectFlagBits. --- src/i

Re: [Mesa-dev] [RFC PATCH v1 05/30] anv: Fix get_image_format_properties() - depthstencil (v2)

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Teach it to calculate the features of depthstencil formats. The goal is to incrementally fix get_image_format_properties() to return a correct result. Currently, it returns incorrect VkFormatFeatureFlags which the caller

Re: [Mesa-dev] [RFC PATCH v1 06/30] anv: Fix get_image_format_properties() - ASTC

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Teach it to calculate the format features for ASTC. The goal is to incrementally fix get_image_format_properties() to return a correct result. Currently, it returns incorrect VkFormatFeatureFlags which the caller must

Re: [Mesa-dev] [RFC PATCH v1 07/30] anv: Refactor get_image_format_properties() - plane_format

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Rename parameter 'format' to 'plane_format'. Reviewed-by: Jason Ekstrand --- src/intel/vulkan/anv_formats.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --gi

Re: [Mesa-dev] [RFC PATCH v1 08/30] anv: Refactor get_image_format_properties() - base_isl_format

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Rename parameter 'base' to 'base_isl_format'. --- src/intel/vulkan/anv_formats.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/

Re: [Mesa-dev] [RFC PATCH v1 09/30] anv: Refactor get_image_format_properties() - Reduce params

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Replace parameters 'enum isl_format' and 'struct anv_format_plane' with new parameter 'const struct anv_format *'. The goal is to incrementally fix get_image_format_properties() to return a

Re: [Mesa-dev] [RFC PATCH v1 10/30] anv: Fix get_image_format_properties() - 3-channel formats

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Teach it to calculate the format features for 3-channel formats. The goal is to incrementally fix get_image_format_properties() to return a correct result. Currently, it returns incorrect VkFormatFeatureFlags which the

Re: [Mesa-dev] [RFC PATCH v1 11/30] anv: Fix get_image_format_properties() - YCbCr

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Teach it to calculate the format features for YCbCr. The goal (which is completed in this patch) is to incrementally fix get_image_format_properties() to return a correct result. Previously, it returned incorrect

Re: [Mesa-dev] [RFC PATCH v1 12/30] anv: Rename get_image_format_properties()

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: The name is misleading. It looks like vkGetPhysicalDeviceImageFormatProperties(), but it actually implement vkGetPhysicalDeviceFormatProperties. Let's rename it to what it actually does, get_image_format_features(), be

Re: [Mesa-dev] [RFC PATCH v1 13/30] anv: Simplify anv_get_image_format_properties()

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Now that get_image_format_features() has a VkImageTiling parameter, we can bypass anv_physical_device_get_format_properties() and call get_image_format_features() directly. --- src/intel/vulkan/anv_formats.c | 17

Re: [Mesa-dev] [RFC PATCH v1 14/30] anv: Simplify anv_physical_device_get_format_properties()

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Now that get_image_format_properties() returns the correct VkFormatFeatureFlags, we can remove the unneeded if-branch and some local variables. --- src/intel/vulkan/anv_formats.c | 25 + 1 file

Re: [Mesa-dev] [RFC PATCH v1 16/30] anv: Refactor anv_get_format_plane() - explicit unsupported

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: The same local variable, 'plane_format', was returned on success *and* failure. Be more explicit in distinguishing the two cases: return 'plane_format' on success and return 'unsupported' on

Re: [Mesa-dev] [RFC PATCH v1 15/30] anv: Remove anv_physical_device_get_format_properties()

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Fold its body into its sole caller, anv_GetPhysicalDeviceFormatProperties(). --- src/intel/vulkan/anv_formats.c | 36 +--- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a

Re: [Mesa-dev] [RFC PATCH v1 18/30] anv: Refactor anv_GetImageSubresourceLayout()

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Its helper function, anv_surface_get_subresource_layout(), was not very helpful. So fold it into the main function. --- src/intel/vulkan/anv_image.c | 32 +++- 1 file changed, 11 insertions

Re: [Mesa-dev] [RFC PATCH v1 29/30] RFC: anv: Kill vkCreateDmaBufImageINTEL()

:) Reviewed-by: Lionel Landwerlin On 07/11/17 14:48, Chad Versace wrote: Replaced by VK_EXT_external_memory_dma_buf and VK_EXT_image_drm_format_modifier. --- include/meson.build | 1 - include/vulkan/vulkan_intel.h | 62 - src/amd/vulkan

Re: [Mesa-dev] [RFC PATCH v1 17/30] anv/image: Refactor choice of isl_tiling_flags_t

Reviewed-by: Lionel Landwerlin On 07/11/17 14:47, Chad Versace wrote: Instead of choosing the tiling flags inside make_surface(), which is called once per aspect in a loop, and which chooses the same tiling for each aspect, choose the tiling flags exactly once before entering the aspect loop

Re: [Mesa-dev] [PATCH] anv/pipeline: use BITFIELD64_BIT() to check enable vertex inputs

Can we depend on src/mesa/main/mtypes.h? Regardless, this fixes an actual issue : Reviewed-by: Lionel Landwerlin Thanks! On 13/07/17 15:48, Juan A. Suarez Romero wrote: When initializing the ANV pipeline, one of the tasks is checking which vertex inputs are enabled. This is done by checking

[Mesa-dev] [PATCH 0/9] intel: coverity round of fixes

Hi all, Here are some fixes for coverity issues. Cheers, Lionel Landwerlin (9): isl: use 64bit arithmetic to compute size intel/compiler: remove check unsigned is >= 0 i965: map_gtt: check mapping address before adding offset i965: check pointer before dereferencing it intel/compi

[Mesa-dev] [PATCH 1/9] isl: use 64bit arithmetic to compute size

If we allow the size to be more than 2^32, then we should compute it in 64bit arithmetic otherwise we might run into overflow issues. CID: 1412892, 1412891 Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel

[Mesa-dev] [PATCH 2/9] intel/compiler: remove check unsigned is >= 0

By definition unsigned are always >= 0. CID: 742212 Signed-off-by: Lionel Landwerlin --- src/intel/compiler/brw_eu_emit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_eu_emit.c b/src/intel/compiler/brw_eu_emit.c index 231d6fdaec0..0b0d67a5c56 100

[Mesa-dev] [PATCH 6/9] i965: fix missing NULL return if allocation fails

CID: 1250585 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/intel_buffer_objects.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c b/src/mesa/drivers/dri/i965/intel_buffer_objects.c index 85cc1a694bf..fde6b224cd4 100644 --- a

[Mesa-dev] [PATCH 4/9] i965: check pointer before dereferencing it

Check that irb isn't NULL before accessing irb->Base.Base.NumSamples. CID: 1026046 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/intel_tex_copy.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_copy.

[Mesa-dev] [PATCH 3/9] i965: map_gtt: check mapping address before adding offset

The NULL check might fail if offset isn't 0. CID: 971379 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri

[Mesa-dev] [PATCH 9/9] aubinator: don't leak fd of opened aubfile

CID: 1373563 Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 6c9a8f052c2..48d4456cc16 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c

[Mesa-dev] [PATCH 7/9] intel/compiler: no need to check unsigned is >= 0

CID: 1338342 Signed-off-by: Lionel Landwerlin --- src/intel/compiler/brw_fs_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp index a9dce42c38d..aea2c625630 100644 --- a/src/intel/compiler

[Mesa-dev] [PATCH 5/9] intel/compiler: don't check unsigned is >= 0

CID: 1224468 Signed-off-by: Lionel Landwerlin --- src/intel/compiler/brw_vec4_gs_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compiler/brw_vec4_gs_visitor.cpp b/src/intel/compiler/brw_vec4_gs_visitor.cpp index f763f482365..ca59927cd3a 100644 --- a

[Mesa-dev] [PATCH 8/9] anv: don't use strcpy for copying strings

CID: 1358935 Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 39c907e9f2d..d3607deccfc 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src

Re: [Mesa-dev] [PATCH 1/2] intel/decoder: Reuse the MAX2 macro instead of defining another one.

This series is : Reviewed-by: Lionel Landwerlin Thanks! On 13/07/17 19:37, Eric Anholt wrote: --- src/intel/common/gen_decoder.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index ba3a5139aec6

Re: [Mesa-dev] [PATCH 0/8] vulkan: Update to 1.0.54

I have a series that just squashes all of this (except patch 7), so it didn't get rid of the radv code for external memory. I guess it's nicer to have the code cleanly removed and then added back. Thanks for doing this : Reviewed-by: Lionel Landwerlin On 13/07/17 20:32, Jason Ekst

Re: [Mesa-dev] [PATCH] anv: remove early out from cmd_buffer_setup_attachments

Hi James, I think this patch from Jason might fix the same problem : https://patchwork.freedesktop.org/patch/166280/ Series : https://patchwork.freedesktop.org/series/27142/ Cheers, - Lionel On 14/07/17 17:58, James Legg wrote: Even when there are no attachments, set up cmd_buffer->state->

[Mesa-dev] [PATCH 1/2] i965: miptree: silence coverity warning

This probably can't happen, but we're better off with initialized variables. CID: 1415114 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tre

[Mesa-dev] [PATCH 0/2] anv/i965: coverity fixes

Hi all, Here are another couple of trival coverity fixes. Thanks to Grazvydas for reporting the Anv one (before coverity). Cheers, Lionel Landwerlin (2): i965: miptree: silence coverity warning anv: ensure device name contains terminating character src/intel/vulkan/anv_device.c

[Mesa-dev] [PATCH 2/2] anv: ensure device name contains terminating character

CID: 1415113 Reported-by: Grazvydas Ignotas Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 34d4a675481..26a19e40a4b 100644 --- a/src

[Mesa-dev] [PATCH v2 2/2] anv: ensure device name contains terminating character

v2: Use sizeof() (Chris) CID: 1415113 Reported-by: Grazvydas Ignotas Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 34d4a675481

Re: [Mesa-dev] [PATCH] anv/image: Fix VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT

Oh dear :/ Reviewed-by: Lionel Landwerlin On 17/07/17 23:32, Chad Versace wrote: We incorrectly detected VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT. We looked for the bit in VkImageCreateInfo::usage, but it's actually in VkImageCreateInfo::flags. Found by assertion failures while ena

Re: [Mesa-dev] [PATCH] anv/image: Fix VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT

On 18/07/17 05:07, Jason Ekstrand wrote: On Mon, Jul 17, 2017 at 5:18 PM, Chad Versace mailto:chadvers...@chromium.org>> wrote: On Tue 18 Jul 2017, Lionel Landwerlin wrote: > Oh dear :/ > > Reviewed-by: Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>&

Re: [Mesa-dev] [PATCH mesa] vulkan/util: fix typo in comment

Reviewed-by: Lionel Landwerlin On 18/07/17 11:08, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- src/vulkan/util/gen_enum_to_str.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vulkan/util/gen_enum_to_str.py b/src/vulkan/util/gen_enum_to_str.py index

Re: [Mesa-dev] [PATCH V2] i965 : Optimize atom state flag checks

Just some style comments, feel free to ignore them. On 20/07/17 12:35, aravindan.muthuku...@intel.com wrote: From: Aravindan Muthukumar This patch improves CPI Rate(Cycles per Instruction) and branch mispredict for i965. The function check_state() was showing CPI retired rate. Performance sta

Re: [Mesa-dev] [PATCH] i965: perf: minimize the chances to spread queries across batchbuffers

Hi, I would like to nominate this commit for 17.1. It can be found as commit adafe4b733c0242720ccfe10d391e5d44c0e7401 in the master branch (I believe it's alreadyin 17.2). Thanks, - Lionel On 22/06/17 02:25, Lionel Landwerlin wrote: Counter related to timings will be sensitive to any

Re: [Mesa-dev] [PATCH] i965: perf: minimize the chances to spread queries across batchbuffers

On 24/07/17 16:55, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-06-22 02:25:28) Counter related to timings will be sensitive to any delay introduced by the software. In particular if our begin & end of performance queries end up in different batches, time related counters will exh

Re: [Mesa-dev] [PATCH 2/3] anv: only expose up to 28 vertex attributes

On 21/07/17 09:26, Iago Toral Quiroga wrote: We were exposing 31 because the hardware allows for 33 and we need to reserve one vertex buffer to upload VertexIndex/InstanceIndex and another to upload DrawID when needed, however, there is another restriction in the hardware regarding the size of th

Re: [Mesa-dev] [PATCH 1/3] anv/cmd_buffer: fix off by one error in assertion

The spec even put it out clearly : "The sum of|firstBinding|and|bindingCount|*must*be less than or equal to|VkPhysicalDeviceLimits|::|maxVertexInputBindings"| Reviewed-by: Lionel Landwerlin On 21/07/17 09:26, Iago Toral Quiroga wrote: --- src/intel/vulkan/anv_cmd_buffer.c | 2 +

Re: [Mesa-dev] [PATCH 2/3] anv: only expose up to 28 vertex attributes

Cool, got it :) Reviewed-by: Lionel Landwerlin I think we might want this in stable right? On 25/07/17 09:30, Iago Toral wrote: On Tue, 2017-07-25 at 00:46 +0100, Lionel Landwerlin wrote: On 21/07/17 09:26, Iago Toral Quiroga wrote: We were exposing 31 because the hardware allows for 33

[Mesa-dev] [PATCH] i965: perf: flush batchbuffers at the beginning of queries

amount of commands is huge, but then it's only fair to include reloading request times in the measurements). Fixes: adafe4b733c02 ("i965: perf: minimize the chances to spread queries across batchbuffers") Reported-by: Chris Wilson Signed-off-by: Lionel Landwerlin Cc: 17.1 ---

Re: [Mesa-dev] [PATCH 1/3] i965: Expose get_num_logical_layers outside of intel_mipmap_tree.c.

Patches 1 & 2 are : Reviewed-by: Lionel Landwerlin I'm not knowledgeable enough for the last one :( On 26/07/17 00:34, Kenneth Graunke wrote: I want to use it in brw_clear.c. --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 10 +- src/mesa/drivers/dri/i965/intel_mipm

Re: [Mesa-dev] [PATCH v4 01/18] anv: Transition MCS buffers from the undefined layout

urn; This bit definitely makes sense to me. I've been hitting it on newer work where the anv_image_fast_clear() would assert because there is no auxiliary surface. I'm not familiar with the CCS stuff enough to review the part below though :( Acked-by: Lionel Landwerlin

<    1   2   3   4   5   6   7   8   9   10   >