On 31/10/17 12:59, Emil Velikov wrote:
Hi Lionel,
On 30 October 2017 at 16:58, Lionel Landwerlin
<lionel.g.landwer...@intel.com> wrote:
create mode 100644 src/intel/tools/aubinator_imgui_widgets.cpp
create mode 100644 src/intel/tools/aubinator_imgui_widgets.h
create mode 100644 src/intel/tools/aubinator_ui.cpp
create mode 100644 src/intel/tools/imgui/LICENSE.txt
create mode 100644 src/intel/tools/imgui/imconfig.h
create mode 100644 src/intel/tools/imgui/imgui.cpp
create mode 100644 src/intel/tools/imgui/imgui.h
create mode 100644 src/intel/tools/imgui/imgui_demo.cpp
create mode 100644 src/intel/tools/imgui/imgui_draw.cpp
create mode 100644 src/intel/tools/imgui/imgui_impl_gtk3_cogl.cpp
create mode 100644 src/intel/tools/imgui/imgui_impl_gtk3_cogl.h
create mode 100644 src/intel/tools/imgui/imgui_internal.h
create mode 100644 src/intel/tools/imgui/stb_rect_pack.h
create mode 100644 src/intel/tools/imgui/stb_textedit.h
create mode 100644 src/intel/tools/imgui/stb_truetype.h
create mode 100644 src/intel/tools/memory.c
create mode 100644 src/intel/tools/memory.h
Nit, please sort the following alphabetically.
+tools_aubinator_ui_SOURCES = \
+ tools/imgui/imconfig.h \
+ tools/imgui/imgui.cpp \
+ tools/imgui/imgui_demo.cpp \
+ tools/imgui/imgui_draw.cpp \
+ tools/imgui/imgui.h \
Move this after imgui.cpp
+ tools/imgui/imgui_impl_gtk3_cogl.cpp \
+ tools/imgui/imgui_impl_gtk3_cogl.h \
+ tools/imgui/imgui_internal.h \
+ tools/imgui/stb_rect_pack.h \
+ tools/imgui/stb_textedit.h \
+ tools/imgui/stb_truetype.h \
+ \
+ tools/aubinator_ui.cpp \
And this one goes after aubinator_imgui_widgets.h
+ tools/aubinator_imgui_widgets.cpp \
+ tools/aubinator_imgui_widgets.h \
+ tools/disasm.c \
+ tools/gen_disasm.h \
+ tools/intel_aub.h \
+ tools/memory.c \
+ tools/memory.h
+
+tools_aubinator_ui_CFLAGS = \
Please make this tools_aubinator_ui_CPPFLAGS and drop the AM_CFLAGS
line + CXX hunk below.
Is AM_CPPFLAGS allowed?
Without it, I end up having to include manually logs of gallium
directories and even then, it fails to compile with "struct timespec"
undefined :(
+ $(AM_CFLAGS) \
+ $(AUBINATOR_UI_CFLAGS) \
+ $(EXPAT_CFLAGS) \
+ $(ZLIB_CFLAGS) \
+ -Itools/imgui
+
+tools_aubinator_ui_CXXFLAGS = \
+ $(AUBINATOR_UI_CFLAGS) \
+ -Itools/imgui
+
With that from autotools POV the patch is
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
Thanks for look into this.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
