Re: [Mesa-dev] [PATCH] intel: fix compilation warning on gen_get_device_info

2016-10-03 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 03/10/16 07:32, Tapani Pälli wrote: (warning: 'const' type qualifier on return type has no effect) Signed-off-by: Tapani Pälli --- src/intel/common/gen_device_info.c | 2 +- src/intel/common/gen_device_info.h | 2 +- 2 files changed, 2 insert

[Mesa-dev] [PATCH 2/2] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Lionel Landwerlin
In conjuction with an intel_aubdump change, you can now look at your application's output like this : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota Cc: Kristian Høgsberg --- src/intel/tools/au

[Mesa-dev] [PATCH 1/2] intel: aubinator: generate a standalone binary

2016-10-04 Thread Lionel Landwerlin
Embed the xml files into the binary, so aubinator can be used from any location. Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/Makefile.am | 1 + src/intel/Makefile.aubinator.am | 36 +++ src/intel/Makefile.sources | 7 +++ src/intel/tools

[Mesa-dev] [PATCH 0/2] Enable aubinator to decode a running application

2016-10-04 Thread Lionel Landwerlin
/ Looking forward to comments from Ben and Kenneth who seem to rely a fair bit on brw_state_dump. Cheers, Lionel Landwerlin (2): intel: aubinator: generate a standalone binary intel: aubinator: enable loading dumps from standard input src/intel/Makefile.am | 1 + src/intel/Makefile.au

Re: [Mesa-dev] [PATCH 2/2] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Lionel Landwerlin
On 04/10/16 16:01, Eero Tamminen wrote: Hi, On 04.10.2016 17:38, Lionel Landwerlin wrote: In conjuction with an intel_aubdump change, you can now look at your application's output like this : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app Maybe you could add

[Mesa-dev] [PATCH 4/5] intel: aubinator: generate a standalone binary

2016-10-04 Thread Lionel Landwerlin
Embed the xml files into the binary, so aubinator can be used from any location. v2: Split generation packing into another patch (Jason) Check for xxd (Jason) Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- configure.ac| 1 + src/intel/Makefile.am

[Mesa-dev] [PATCH 1/5] intel: aubinator: pack supported generations into an array

2016-10-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/tools/aubinator.c | 79 + 1 file changed, 30 insertions(+), 49 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 9b32e5b..4e2cafa 100644

[Mesa-dev] [PATCH 3/5] intel: aubinator: retain input file in its own variable

2016-10-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/tools/aubinator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 9939de7..459e3d4 100644 --- a/src/intel/tools/aubinator.c +++ b/src

[Mesa-dev] [PATCH 2/5] intel: aubinator: add missing return characters

2016-10-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- src/intel/tools/aubinator.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 4e2cafa..9939de7 100644 --- a/src/intel/tools/aubinator.c +++ b

[Mesa-dev] [PATCH 5/5] intel: aubinator: enable loading dumps from standard input

2016-10-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota Cc: Kristian Høgsberg --- src/intel/tools/aubinator.c | 166 +++- 1 file changed, 132 insertions(+), 34 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 3

Re: [Mesa-dev] [PATCH 2/2] i965: use L3 data cache for SSBOs

2016-10-05 Thread Lionel Landwerlin
Curro: Ping? :) On 26/09/16 20:02, Jason Ekstrand wrote: Looks good to me. Curro, do you see anything wrong with this? --Jason On Sep 26, 2016 7:31 AM, "Lionel Landwerlin" <mailto:llandwer...@gmail.com>> wrote: Anv programs the hardware to use L3 data cache if we u

[Mesa-dev] [PATCH 4/5] intel: aubinator: enable loading xml files from a given directory

2016-10-05 Thread Lionel Landwerlin
This might be useful for people who debug with out of tree descriptions. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 18 ++--- src/intel/tools/decoder.c | 64 + src/intel/tools/decoder.h | 2 ++ 3 files changed, 81

[Mesa-dev] [PATCH v3 5/5] intel: aubinator: enable loading dumps from standard input

2016-10-05 Thread Lionel Landwerlin
(Eero) v3: Use realloc rather than memcpy/free (Ben) Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 165 ++-- 1 file changed, 129 insertions(+), 36 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 7

[Mesa-dev] [PATCH v2 0/5] Enable aubinator to decoder a running application

2016-10-05 Thread Lionel Landwerlin
Hi, Here is another iteration on making aubinator decode its standard input. Hopefully this addresses all the previous comments. While at it, I took on to the move aubinator to use getopt. Thanks, Lionel Landwerlin (5): intel: aubinator: add missing return characters intel: aubinator: use

[Mesa-dev] [PATCH 1/5] intel: aubinator: add missing return characters

2016-10-05 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 6fc0208..b74885a 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools

[Mesa-dev] [PATCH v3 3/5] intel: aubinator: generate a standalone binary

2016-10-05 Thread Lionel Landwerlin
: Lionel Landwerlin --- configure.ac| 1 + src/intel/tools/.gitignore | 5 +++ src/intel/tools/Makefile.am | 19 + src/intel/tools/aubinator.c | 37 +- src/intel/tools/decoder.c | 94 ++--- src/intel/tools/decoder.h

[Mesa-dev] [PATCH 2/5] intel: aubinator: use getopt to parse arguments

2016-10-05 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 90 + 1 file changed, 33 insertions(+), 57 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index b74885a..44a6bb2 100644 --- a/src/intel/tools

Re: [Mesa-dev] [PATCH 2/2] i965: use L3 data cache for SSBOs

2016-10-05 Thread Lionel Landwerlin
On 05/10/16 17:15, Ilia Mirkin wrote: On Mon, Sep 26, 2016 at 10:31 AM, Lionel Landwerlin wrote: Anv programs the hardware to use L3 data cache if we use either SSBOs or images in the shaders, we can program i965 the same way. gl_shader_program has a bit of a confusing named field with

Re: [Mesa-dev] [PATCH v3 3/5] intel: aubinator: generate a standalone binary

2016-10-05 Thread Lionel Landwerlin
On 05/10/16 17:07, Jason Ekstrand wrote: +$(builddir)/%_aubinator_xml.h: $(srcdir)/../genxml/%.xml Makefile + $(MKDIR_GEN) + $(AM_V_GEN) echo -n "static const uint8_t " > $@; \ + echo -n `basename $@` | sed -e 's,_aubinator_xml.h,,' >> $@; \ + echo "

[Mesa-dev] [PATCH v4] intel: aubinator: generate a standalone binary

2016-10-05 Thread Lionel Landwerlin
generated _xml.h files to genxml/ (Sirisha) Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- configure.ac | 1 + src/intel/Makefile.genxml.am | 10 - src/intel/Makefile.sources | 8 +++- src/intel/genxml/.gitignore | 1 + src/intel/tools/aubinator.c | 37

Re: [Mesa-dev] [PATCH] anv/wsi: Advertise UNORM formats as well as sRGB

2016-10-06 Thread Lionel Landwerlin
Thanks, I was wondering why those weren't available. Reviewed-by: Lionel Landwerlin On 05/10/16 21:26, Jason Ekstrand wrote: Because WSI images are created with VkImageCreateInfo::flags explicitly set to 0, they don't ever have the VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT set. This mean

[Mesa-dev] [PATCH v5] intel: aubinator: generate a standalone binary

2016-10-07 Thread Lionel Landwerlin
generated _xml.h files to genxml/ (Sirisha) v5: Remove newline from makefile (Jason) Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- configure.ac | 1 + src/intel/Makefile.genxml.am | 9 - src/intel/Makefile.sources | 7 +++- src/intel/genxml/.gitignore | 1

[Mesa-dev] [PATCH] anv: pipeline cache: fix return value of vkGetPipelineCacheData

2016-10-07 Thread Lionel Landwerlin
-VK.pipeline.cache.pipeline_from_incomplete_get_data.vertex_stage_fragment_stage dEQP-VK.pipeline.cache.pipeline_from_incomplete_get_data.vertex_stage_geometry_stage_fragment_stage dEQP-VK.pipeline.cache.misc_tests.invalid_size_test Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src

[Mesa-dev] [PATCH] anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

2016-10-07 Thread Lionel Landwerlin
according to the VkSamplerCreateInfo.maxAnisotropy, it seems we can turn this on. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/TODO | 1 - src/intel/vulkan/anv_device.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO

Re: [Mesa-dev] [PATCH] anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures

2016-10-07 Thread Lionel Landwerlin
Does this enable more tests? If so, do we pass them? On Oct 7, 2016 9:50 AM, "Lionel Landwerlin" <mailto:llandwer...@gmail.com>> wrote: According to the Vulkan spec 5.63.4 : samplerAnisotropy indicates whether anisotropic filtering is supported. If thi

Re: [Mesa-dev] [PATCH 02/22] intel/genxml: Add a uint MOCS field to 3DSTATE_STENCIL_BUFFER

2016-10-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 08/10/16 05:41, Jason Ekstrand wrote: Signed-off-by: Jason Ekstrand --- src/intel/genxml/gen6.xml | 1 + src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel/genxml/gen8.xml | 1 + src/intel/genxml/gen9.xml | 1 + 5 files

Re: [Mesa-dev] [PATCH 10/32] genxml: Add a uint MOCS field to VERTEX_BUFFER_STATE

2016-10-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 11/08/16 22:15, Jason Ekstrand wrote: --- src/intel/genxml/gen6.xml | 1 + src/intel/genxml/gen7.xml | 1 + src/intel/genxml/gen75.xml | 1 + src/intel/genxml/gen8.xml | 1 + src/intel/genxml/gen9.xml | 1 + 5 files changed, 5 insertions(+) diff

Re: [Mesa-dev] [PATCH 06/32] genxml: Add a uint MOCS field to DEPTH_BUFFER packets

2016-10-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 11/08/16 22:15, Jason Ekstrand wrote: This is easier than dealing with structs all the time --- src/intel/genxml/gen6.xml | 2 ++ src/intel/genxml/gen7.xml | 2 ++ src/intel/genxml/gen75.xml | 2 ++ src/intel/genxml/gen8.xml | 2 ++ src/intel/genxml

Re: [Mesa-dev] [PATCH] intel: Fix bash-specific redirection.

2016-10-10 Thread Lionel Landwerlin
Thanks, I think that explains a problem I have in another patch. Reviewed-by: Lionel Landwerlin On 10/10/16 17:19, Eric Anholt wrote: --- I went to test-build my previous bash fix, and another area got broken in the meantime. src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 6/6] anv: add dispatch macro to find right function for given generation

2016-10-12 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_cmd_buffer.c | 33 ++--- src/intel/vulkan/anv_device.c | 19 +-- src/intel/vulkan/anv_pipeline.c | 30 -- src/intel/vulkan/anv_private.h| 23

[Mesa-dev] [PATCH 3/6] intel: aubinator: add support for memory register load decoding

2016-10-12 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 0313d5a..b6820f4 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel

[Mesa-dev] [PATCH 1/6] intel: genxml: add SO_WRITE_OFFSET register

2016-10-12 Thread Lionel Landwerlin
One of the register we happen to program but don't have a description for yet. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 5 + src/intel/genxml/gen7.xml | 5 + src/intel/genxml/gen75.xml | 5 + src/intel/genxml/gen8.xml | 5 + src/intel/genxml/gen

[Mesa-dev] [PATCH 2/6] intel: aubinator: use different colors to signal batch start/end

2016-10-12 Thread Lionel Landwerlin
This makes the stream of commands a bit easier to read. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index d716a65..0313d5a 100644

[Mesa-dev] [PATCH 5/6] anv: replace , with ; in anv_batch_emit()

2016-10-12 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/genX_cmd_buffer.c| 20 ++-- src/intel/vulkan/genX_pipeline_util.h | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index

[Mesa-dev] [PATCH 0/6] Anv/Aubinator: unrelated commits

2016-10-12 Thread Lionel Landwerlin
Hi, Here are some commits that do not relate to a particular issue, just cleanups accumulated over the past week. Feel free to nack them if this isn't useful. Thanks, Lionel Landwerlin (6): intel: genxml: add SO_WRITE_OFFSET register intel: aubinator: use different colors to signal

[Mesa-dev] [PATCH 4/6] anv: print finishme messages only once

2016-10-12 Thread Lionel Landwerlin
Some of the new Hiz finishme messages generate a lot of noise, maybe displaying the warning once is a better approach. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_private.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_private.h b

Re: [Mesa-dev] [PATCH 1/5] intel: automake: replace direct basename $@ invokation with $(@F)

2016-10-13 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 12/10/16 19:05, Emil Velikov wrote: From: Emil Velikov Use the shorthand make variable(s) as elsewhere in the build. Signed-off-by: Emil Velikov --- src/intel/Makefile.genxml.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-14 Thread Lionel Landwerlin
Hi Emil, I've not been able to run the deqp gles31 test suite after this commit. Like Eric suggested I think this is introducing a behavior change. Thanks, - Lionel On 03/10/16 19:28, Emil Velikov wrote: From: Emil Velikov Fold duplicate conditional blocks and add a few extra comments ;-)

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-14 Thread Lionel Landwerlin
Thanks a lot, The diff is a bit too complicated for me to tell how it's different. - Lionel On 14/10/16 16:11, Emil Velikov wrote: On 14 October 2016 at 15:58, Lionel Landwerlin wrote: Hi Emil, I've not been able to run the deqp gles31 test suite after this commit. Like Eric s

Re: [Mesa-dev] [PATCH v2 10/30] egl/dri2: rework dri2_make_current code flow

2016-10-14 Thread Lionel Landwerlin
s : if (cctx || ddraw || rdraw) { The bindContext() used to get executed when unbinding a context, now it reports a BAD_MATCH error. - Lionel On 14/10/16 16:13, Lionel Landwerlin wrote: Thanks a lot, The diff is a bit too complicated for me to tell how it's different. - Lionel On 1

[Mesa-dev] [PATCH 0/2] Program multisampling modes on gen7/75

2016-08-08 Thread Lionel Landwerlin
Some of the new CTS tests are failing basic image resolve operations on gen7/75. Turns out we're missing some bits there. Cheers, Lionel Landwerlin (2): anv: genX_pipeline: rename info to rs_info anv: gen7/75: Set multisample modes src/intel/vulkan/gen7_pipeline.c | 10 --

[Mesa-dev] [PATCH 1/2] anv: genX_pipeline: rename info to rs_info

2016-08-08 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/genX_pipeline_util.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline_util.h b/src/intel/vulkan/genX_pipeline_util.h index c17d930..0aa85ba 100644 --- a

[Mesa-dev] [PATCH 2/2] anv: gen7/75: Set multisample modes

2016-08-08 Thread Lionel Landwerlin
-VK.api.copy_and_blit.resolve_image.with_regions_4_bit dEQP-VK.api.copy_and_blit.resolve_image.with_regions_8_bit Tested on IVB/HSW v2: Check pMultisampleState is not NULL v3: Drop rasterization state rename (Anuj) Fix value of MultisampleRasterizationMode in 3DSTATE_SF v4: rebase on master Signed-off-by: Lionel Landwerlin Cc: Jason

[Mesa-dev] [PATCH 1/2] anv: pipeline: gen7: fix assert in debug mode

2016-08-11 Thread Lionel Landwerlin
SampleMask is only 8bits long on gen7. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/genX_pipeline_util.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/genX_pipeline_util.h b/src/intel/vulkan/genX_pipeline_util.h index 64b89cd..d56eeb8

[Mesa-dev] [PATCH 2/2] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

2016-08-11 Thread Lionel Landwerlin
using attachments. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/anv_formats.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index b26e48a..13bde90 100644 --- a/src/intel/v

[Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

2016-08-12 Thread Lionel Landwerlin
using attachments. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/anv_formats.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c index b26e48a..b06e29b 100644 --- a/src/

[Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-19 Thread Lionel Landwerlin
A few inline asserts in anv assume alignments are power of 2, but with formats like R8G8B8 we have odd alignments. Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl.c | 1 + src/intel/isl/isl_priv.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/src/intel/isl/isl.c b/src

Re: [Mesa-dev] [PATCH] anv: GetDeviceImageFormatProperties: fix TRANSFER formats

2016-08-22 Thread Lionel Landwerlin
I should start to remember to put someone in Cc... On 13/08/16 01:30, Jason Ekstrand wrote: Much better. Thanks! Reviewed-by: Jason Ekstrand <mailto:ja...@jlekstrand.net>> On Fri, Aug 12, 2016 at 5:00 PM, Lionel Landwerlin mailto:llandwer...@gmail.com>> wrote: We let t

Re: [Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-22 Thread Lionel Landwerlin
The one I actually wanted to Cc you on :) On 20/08/16 00:44, Lionel Landwerlin wrote: A few inline asserts in anv assume alignments are power of 2, but with formats like R8G8B8 we have odd alignments. Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl.c | 1 + src/intel/isl

[Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-24 Thread Lionel Landwerlin
A few inline asserts in anv assume alignments are power of 2, but with formats like R8G8B8 we have odd alignments. v2: round up to power of 2 (Ilia) Signed-off-by: Lionel Landwerlin Cc: Ilia Mirkin Cc: Jason Ekstrand --- src/intel/isl/isl.c | 1 + src/intel/isl/isl_priv.h | 10

[Mesa-dev] [PATCH] anv: meta_blit2d: adapt texel fetch pitch for fake w-tiled

2016-08-24 Thread Lionel Landwerlin
Outside the shader, our actual tiling is Y0 which pitch is larger that tiling W. Inside the shader we need to bring the pitch back to tiling W. Fixes dEQP-VK.api.copy_and_blit.image_to_image_stencil Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97448 Signed-off-by: Lionel Landwerlin Cc

[Mesa-dev] [PATCH] isl: round format alignment to nearest power of 2

2016-08-24 Thread Lionel Landwerlin
A few inline asserts in anv assume alignments are power of 2, but with formats like R8G8B8 we have odd alignments. v2: round up to power of 2 (Ilia) v3: reuse util_next_power_of_two() from gallium/aux/util/u_math.h (Ilia) Signed-off-by: Lionel Landwerlin Cc: Ilia Mirkin Cc: Jason Ekstrand

[Mesa-dev] [PATCH] anv: meta_blit2d: adapt texel fetch pitch for fake w-tiled

2016-08-24 Thread Lionel Landwerlin
We need to compute detiling coordinates using the physical size of W tiling (128x32) rather than the logical size (64x64). v2: Correct comment (Jason) Fixes dEQP-VK.api.copy_and_blit.image_to_image_stencil Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97448 Signed-off-by: Lionel

[Mesa-dev] [PATCH 1/2] anv: pipeline: use NIR macros to apply passes

2016-08-30 Thread Lionel Landwerlin
It seems the i965 GL driver uses macros in most places and I found it pretty handy to be able to put a printf in a single file (nir.h) to compare the passes applied between the 2 drivers. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/anv_pipeline.c | 30

[Mesa-dev] [PATCH 2/2] anv: pipeline: reorder NIR passes closer to the i965 driver

2016-08-30 Thread Lionel Landwerlin
. It seems that dead variables removal passes should be applied after inlining functions and applying dead code elimination, otherwise variables might still be used by code that isn't useful. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/intel/vulkan/anv_pipeline.c

Re: [Mesa-dev] [PATCH mesa] isl: use existing util_next_power_of_two function

2016-09-01 Thread Lionel Landwerlin
ge says. Fixes: 2dc6930a5a54c0f586ba ("isl: round format alignment to nearest power of 2") CC: Lionel Landwerlin CC: Jason Ekstrand CC: Ilia Mirkin Signed-off-by: Eric Engestrom --- src/intel/isl/isl.c | 4 +++- src/intel/isl/isl_priv.h | 9 - 2 files changed, 3 insertions(+), 10 delet

[Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Lionel Landwerlin
Fixes new CTS tests : dEQP-VK.spirv_assembly.instruction.compute.opatomic.load dEQP-VK.spirv_assembly.instruction.compute.opatomic.store Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/compiler/spirv/spirv_to_nir.c | 33 + 1 file changed, 33

[Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-06 Thread Lionel Landwerlin
Fixes new CTS tests : dEQP-VK.spirv_assembly.instruction.compute.opatomic.load dEQP-VK.spirv_assembly.instruction.compute.opatomic.store v2: don't handle images like ssbo/ubo (Jason) Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH] spirv/nir: Implement OpAtomicLoad/Store for shared variables

2016-09-07 Thread Lionel Landwerlin
Missing bits from 2afb950161f847d9b0a7be03dfb62cacc5ea51ba. Signed-off-by: Lionel Landwerlin Cc: Jason Ekstrand --- src/compiler/spirv/spirv_to_nir.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src

Re: [Mesa-dev] [PATCH] spirv/nir: Implement OpAtomicLoad/Store for shared variables

2016-09-07 Thread Lionel Landwerlin
der making the orders of arguments a bit more consistent for a few functions so that we can use fill_common_atomic_sources for load and store too. --Jason On Wed, Sep 7, 2016 at 3:10 AM, Lionel Landwerlin mailto:llandwer...@gmail.com>> wrote: Missing bits from 2afb950161f847d9b0a7

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

2016-09-07 Thread Lionel Landwerlin
-0700, Mark Janes wrote: > Hi Lionel, > > This patch triggered CID 1372521 in Coverity.  Please let me know if > my > the analysis is correct below: > > Lionel Landwerlin writes: > > > > > Fixes new CTS tests : > > > > dEQP-VK.spir

[Mesa-dev] [PATCH] aubinator: add a custom handler for immediate register load

2016-09-09 Thread Lionel Landwerlin
Register Offset: 0xb020 0x00c7708c: 0x00880038 : Dword 2 Data DWord: 8912952 SLM Enable: 0 URB Allocation: 28 URB Low Bandwidth: 0 RO Allocation: 32 RO Low Bandwidth: 0 DC Allocation: 4 DC Low Bandwidth: 0 Signed-off-by: Lionel Landwerlin --- src/intel/tools

[Mesa-dev] [PATCH 0/3] anv: program compute threads using sublices numbers

2016-09-09 Thread Lionel Landwerlin
issue I'm looking at, but here are the patches. Cheers, Lionel Landwerlin (3): anv: device: calculate compute thread numbers using subslices numbers anv: allocator: correct scratch space for haswell anv: pipeline: use correct number of thread for compute src/intel/vulkan/anv_alloca

[Mesa-dev] [PATCH 1/3] anv: device: calculate compute thread numbers using subslices numbers

2016-09-09 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Cc: Kenneth Graunke Cc: Jason Ekstrand --- src/intel/vulkan/anv_allocator.c | 15 +++--- src/intel/vulkan/anv_device.c| 43 src/intel/vulkan/anv_private.h | 14 + src/intel/vulkan

[Mesa-dev] [PATCH 3/3] anv: pipeline: use correct number of thread for compute

2016-09-09 Thread Lionel Landwerlin
Reproduces this commit : commit 0fb85ac08d61d365e67c8f79d6955e9f89543560 Author: Kenneth Graunke Date: Mon Jun 6 21:37:34 2016 -0700 i965: Use the correct number of threads for compute shaders. Signed-off-by: Lionel Landwerlin Cc: Kenneth Graunke Cc: Jason Ekstrand --- src/intel

[Mesa-dev] [PATCH 2/3] anv: allocator: correct scratch space for haswell

2016-09-09 Thread Lionel Landwerlin
This reproduces this commit : commit 2213ffdb4bb79856f0556bdf2bfd4bdf57720232 Author: Kenneth Graunke Date: Mon Jun 6 21:37:34 2016 -0700 i965: Allocate scratch space for the maximum number of compute threads. Signed-off-by: Lionel Landwerlin Cc: Kenneth Graunke Cc: Jason Ekstrand

[Mesa-dev] [PATCH 5/5] anv: setup appropriate border color structures on gen7/gen75

2016-10-17 Thread Lionel Landwerlin
Up to this point we were using the gen8+ structures. Altough this commit doesn't fixes the border color CTS tests, this is a step in the right direction to fix the following tests : dEQP-VK.pipeline.sampler.view_type.2d.format.*.address_modes.all_mode_clamp_to_border_* Signed-off-by: L

[Mesa-dev] [PATCH 3/5] anv: add util functions to query max bpc & integer formats

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/vk_format_info.h | 300 ++ 1 file changed, 300 insertions(+) diff --git a/src/intel/vulkan/vk_format_info.h b/src/intel/vulkan/vk_format_info.h index 5c5a1f3..0c1d865 100644 --- a/src/intel/vulkan

[Mesa-dev] [PATCH 2/5] intel: aubinator: decode border color

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index d716a65..cda91d1 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -265,13

[Mesa-dev] [PATCH 4/5] anv: add dispatch macro to find right function for given generation

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_cmd_buffer.c | 33 ++--- src/intel/vulkan/anv_device.c | 19 +-- src/intel/vulkan/anv_private.h| 23 +++ 3 files changed, 30 insertions(+), 45 deletions(-) diff

[Mesa-dev] [PATCH 0/5] Anv border colors on IVB/HSW

2016-10-17 Thread Lionel Landwerlin
of what offset is programmed in the "Border Color Pointer" field of the SAMPLER_STATE structure. Maybe some kind of cache invalidation is missing in this series? Any idea/pointer is more than welcome! Cheers, Lionel Landwerlin (5): intel: genxml: add SAMPLER_BORDER_COLOR_STATE stru

[Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 32 src/intel/genxml/gen7.xml | 12 src/intel/genxml/gen75.xml | 40 src/intel/genxml/gen8.xml | 12 src/intel/genxml/gen9.xml

Re: [Mesa-dev] [PATCH v2] intel: aubinator: use different colors to signal batch start/end

2016-10-17 Thread Lionel Landwerlin
Hi Ken, Sure, I guess this all depends on your terminal's background color (mine is white). Let's go with your version, having some distinction already helps :) Reviewed-by: Lionel Landwerlin On 17/10/16 17:11, Kenneth Graunke wrote: From: Lionel Landwerlin This makes the

Re: [Mesa-dev] [PATCH 1/5] intel: genxml: add SAMPLER_BORDER_COLOR_STATE structures

2016-10-17 Thread Lionel Landwerlin
On Mon, 2016-10-17 at 10:56 -0700, Jason Ekstrand wrote: > > > On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin .com> wrote: > > Signed-off-by: Lionel Landwerlin > > --- > >  src/intel/genxml/gen6.xml  | 32 > &

Re: [Mesa-dev] [PATCH 5/5] anv: setup appropriate border color structures on gen7/gen75

2016-10-17 Thread Lionel Landwerlin
On Mon, 2016-10-17 at 11:09 -0700, Jason Ekstrand wrote: > On Mon, Oct 17, 2016 at 8:46 AM, Lionel Landwerlin .com> wrote: > > Up to this point we were using the gen8+ structures. Altough this > > commit > > doesn't fixes the border color CTS tests, this is a step i

Re: [Mesa-dev] [PATCH 0/5] Anv border colors on IVB/HSW

2016-10-17 Thread Lionel Landwerlin
On Mon, 2016-10-17 at 12:34 -0700, Kenneth Graunke wrote: > On Monday, October 17, 2016 4:46:54 PM PDT Lionel Landwerlin wrote: > > Hi, > > > > Spoiler alert, this series doesn't actually make the border colors > > work on > > IvyBridge and Haswell.

[Mesa-dev] [PATCH 2/3] intel: aubinator: load fields values from xml data

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/decoder.c | 31 +++ src/intel/tools/decoder.h | 9 + 2 files changed, 40 insertions(+) diff --git a/src/intel/tools/decoder.c b/src/intel/tools/decoder.c index cab5271..88ba5c0 100644 --- a/src/intel/tools

[Mesa-dev] [PATCH 3/3] intel: aubinator: print field values if available

2016-10-17 Thread Lionel Landwerlin
) Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 ++- src/intel/tools/decoder.c | 31 +++ src/intel/tools/decoder.h | 1 + 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c

[Mesa-dev] [PATCH 1/3] intel: aubinator: print boolean fields to true with colors

2016-10-17 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 6 -- src/intel/tools/decoder.c | 12 +--- src/intel/tools/decoder.h | 5 - 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index

[Mesa-dev] [PATCH 0/3] Aubinator improvments

2016-10-17 Thread Lionel Landwerlin
Hi, Here is another quick set of changes to aubinator to help out with debugging. Thanks, Lionel Landwerlin (3): intel: aubinator: print boolean fields to true with colors intel: aubinator: load fields values from xml data intel: aubinator: print field values if available src/intel

[Mesa-dev] [PATCH v2 0/4] Anv border colors on IVB/HSW

2016-10-19 Thread Lionel Landwerlin
look at patch 4/4 for the details. Cheers, Lionel Landwerlin (4): intel: aubinator: decode border color anv: add utils to query max bpc, channels & integer formats anv: workaround border colors gen7/gen75 anv: setup appropriate border color structures on gen7/gen75 src/intel/tools/au

[Mesa-dev] [PATCH 3/4] anv: workaround border colors gen7/gen75

2016-10-19 Thread Lionel Landwerlin
This replicates the following commit from our GL driver : commit c25e5300cba7628b58df93ead14ebc3cc32f338c Author: Kenneth Graunke Date: Fri Jan 20 03:33:40 2012 -0800 i965: Fix border color on Sandybridge and Ivybridge. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan

[Mesa-dev] [PATCH v2 2/4] anv: add utils to query max bpc, channels & integer formats

2016-10-19 Thread Lionel Landwerlin
v2: Add helper to get the number of channels (Lionel) Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/vk_format_info.h | 508 ++ 1 file changed, 508 insertions(+) diff --git a/src/intel/vulkan/vk_format_info.h b/src/intel/vulkan/vk_format_info.h index

[Mesa-dev] [PATCH v2 4/4] anv: setup appropriate border color structures on gen7/gen75

2016-10-19 Thread Lionel Landwerlin
h exception of : dEQP-VK.pipeline.sampler.view_type.*.format.r32_sint.address_modes.all_mode_clamp_to_border_* v2: Implement Jason's suggestion to have all sampler configuration ready at sampler cration Also fix remaining issues with 1 & 2 components texture Signed-of

[Mesa-dev] [PATCH 1/4] intel: aubinator: decode border color

2016-10-19 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 31c1f89..891b595 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -266,13

[Mesa-dev] [PATCH v2] intel: genxml: add SO_WRITE_OFFSET register

2016-10-20 Thread Lionel Landwerlin
One of the register we happen to program but don't have a description for yet. v2: Add SO_WRITE_OFFSET[1-3] on gen7+ (Kenneth) Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen6.xml | 5 + src/intel/genxml/gen7.xml | 20 src/intel/genxml/gen75.xml

Re: [Mesa-dev] [PATCH v2] intel: genxml: add SO_WRITE_OFFSET register

2016-10-20 Thread Lionel Landwerlin
On 20/10/16 16:13, Jason Ekstrand wrote: On Oct 20, 2016 3:56 AM, "Lionel Landwerlin" <mailto:llandwer...@gmail.com>> wrote: > > One of the register we happen to program but don't have a description for > yet. Heh... I've got more-or less this sam

Re: [Mesa-dev] [PATCH 02/25] intel/genxml: Add SO_WRITE_OFFSET registers for gen7-9

2016-10-24 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin Would adding the single register for gen6 makes sense? On 22/10/16 18:50, Jason Ekstrand wrote: --- src/intel/genxml/gen7.xml | 16 src/intel/genxml/gen75.xml | 16 src/intel/genxml/gen8.xml | 16 src

Re: [Mesa-dev] [PATCH 08/25] intel/genxml: Make some VS/GS fields consistent across gens

2016-10-24 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 22/10/16 18:50, Jason Ekstrand wrote: We use the names from gen8+ --- src/intel/genxml/gen6.xml| 6 +++--- src/intel/genxml/gen7.xml| 6 +++--- src/intel/genxml/gen75.xml | 6 +++--- src/intel/vulkan/gen7_pipeline.c | 6 +++--- 4

Re: [Mesa-dev] [PATCH 02/25] intel/genxml: Add SO_WRITE_OFFSET registers for gen7-9

2016-10-24 Thread Lionel Landwerlin
On 24/10/16 18:02, Jason Ekstrand wrote: On Mon, Oct 24, 2016 at 8:22 AM, Jason Ekstrand <mailto:ja...@jlekstrand.net>> wrote: On Oct 24, 2016 2:58 AM, "Lionel Landwerlin" mailto:lionel.g.landwer...@intel.com>> wrote: > > Reviewed-by: Lionel Lan

[Mesa-dev] [PATCH 0/3] Aubinator fixes

2016-10-25 Thread Lionel Landwerlin
Hi, Here are a bunch of fixes, fallouts from a previous series I sent (dealing with standard input). Cheers, Lionel Landwerlin (3): intel: aubinator: don't print out blocks twice intel: aubinator: fix assumptions on amount of required data intel: aubinator: fix printing missing gen o

[Mesa-dev] [PATCH 3/3] intel: aubinator: fix printing missing gen option

2016-10-25 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 67f1f0d..4fee53c 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c

[Mesa-dev] [PATCH 1/3] intel: aubinator: don't print out blocks twice

2016-10-25 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 31c1f89..11709c8 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -974,7 +974,6

[Mesa-dev] [PATCH 2/3] intel: aubinator: fix assumptions on amount of required data

2016-10-25 Thread Lionel Landwerlin
We require 12 bytes of headers but in some cases we just need 4. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 11709c8..67f1f0d 100644

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

2016-10-28 Thread Lionel Landwerlin
On 28/10/16 19:12, Emil Velikov wrote: From: Emil Velikov There is nothing in here that would require it. Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov --- Not sure why we got that dependency in the first place, Lionel ? Some of the Makefile&#

Re: [Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

2016-10-31 Thread Lionel Landwerlin
On 28/10/16 20:55, Emil Velikov wrote: On 28 October 2016 at 19:18, Lionel Landwerlin wrote: On 28/10/16 19:12, Emil Velikov wrote: From: Emil Velikov There is nothing in here that would require it. Cc: mesa-sta...@lists.freedesktop.org Cc: Lionel Landwerlin Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 3/8] i965: Drop the aux mt when not used

2016-11-03 Thread Lionel Landwerlin
igned-off-by: Ben Widawsky (v1) Signed-off-by: Lionel Landwerlin (v2) --- src/mesa/drivers/dri/i965/brw_blorp.c| 4 ++-- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 6 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 25 src/mesa/drivers

[Mesa-dev] [PATCH 0/8] i965 Sampling from HiZ buffers

2016-11-03 Thread Lionel Landwerlin
Hi all, Here is an updated version of a patchset to enable sampling from HiZ in the i965 driver. The initial series was from Jordan and Ben made a v2 [1]. Ben's version of the series enabled sampling from HiZ from gen8, but unfortunately I don't think we can actually do this, mostly because we're

[Mesa-dev] [PATCH 4/8] i965: Store mcs buffer size

2016-11-03 Thread Lionel Landwerlin
oming patch and we won't have access to the total_height field anymore. v2: drop setting the size in intel_hiz_miptree_buf_create() (Lionel) Signed-off-by: Ben Widawsky (v1) Signed-off-by: Lionel Landwerlin (v2) --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++-- src/mesa/driver

[Mesa-dev] [PATCH 5/8] i965/miptree: Create a hiz mcs type

2016-11-03 Thread Lionel Landwerlin
ionel) Signed-off-by: Ben Widawsky (v1) Signed-off-by: Lionel Landwerlin (v2) --- src/mesa/drivers/dri/i965/brw_blorp.c | 4 +- src/mesa/drivers/dri/i965/gen7_misc_state.c | 6 +-- src/mesa/drivers/dri/i965/gen8_depth_state.c | 6 +-- src/mesa/drivers/dri/i965/intel_mipmap_tree.c

<    1   2   3   4   5   6   7   8   9   10   >