On 05/10/16 17:07, Jason Ekstrand wrote:


    +$(builddir)/%_aubinator_xml.h:  $(srcdir)/../genxml/%.xml Makefile
    +       $(MKDIR_GEN)
    +       $(AM_V_GEN) echo -n "static const uint8_t " > $@; \
    +       echo -n `basename $@` | sed -e 's,_aubinator_xml.h,,' >> $@; \
    +       echo "_xml[] = {" >> $@; \
    +       cat $< | $(XXD) -i >> $@; \
    +       echo "};" >> $@


I talked to Sirisha a bit yesterday and she wasn't terribly happy with the way this "dirtied" things. I *think* what she didn't like was the piles of autogenerated files it dumps in the tools directory. Sirisha, please correct me if I'm misunderstanding you.

One option would be to generate them in the genxml directory as genN_xml.h. We already have genN_pack.h, so it's no big deal to dump more there. Another option would be to add a genxml_include directory to tools/ and dump them there to get them out of the way.

Personally, I don't think it's a big deal, but I'm also ok with trying to keep things clean.

Ok, I'll move that to genxml/ if Sirisha is alright with that.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to