- Original Message -
> Hi everyone, one image is better than a thousand words:
>
> http://people.freedesktop.org/~mareko/gallium-hud.png
>
> So there you have it. This gallium module can draw transparent graphs and
> text on top of what apps are rendering. By default, it can show framer
desktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Series looks good
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
\
>case PIPE_PRIM_LINES_ADJACENCY: \
>case PIPE_PRIM_LINE_STRIP_ADJACENCY: \
> --
> 1.7.10.4
>
>
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Thanks for the cleanup.
Reviewed-by: Jose Fonseca
Jose
- Original Message -
> Instead of void pointers use a base interface.
>
> Signed-off-by: Zack Rusin
> ---
> src/gallium/auxiliary/draw/draw_llvm.c | 77
> ---
> src/gall
Looks good to me Brian.
Just a couple of comments.
- Original Message -
> Let's try to update this when we find other broken applications...
docs/ is growing a lot of stuff, with disparate target audiences. Maybe we
could establish some sort of directory hierachary there:
docs/apps/in
tgsi/tgsi_scan.c
> index c59b3a7..373391d 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_scan.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_scan.c
> @@ -186,6 +186,8 @@ tgsi_scan_shader(const struct tgsi_token *tokens,
>}
>else if (fulldecl->Semantic.Name ==
>TGSI_SEMANTIC_VERTEXID) {
> info->uses_vertexid = TRUE;
> + } else if (fulldecl->Semantic.Name ==
> TGSI_SEMANTIC_PRIMID) {
> + info->uses_primid = TRUE;
>}
> }
> else if (file == TGSI_FILE_OUTPUT) {
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.h
> b/src/gallium/auxiliary/tgsi/tgsi_scan.h
> index 235e6a3..9debc34 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_scan.h
> +++ b/src/gallium/auxiliary/tgsi/tgsi_scan.h
> @@ -71,6 +71,7 @@ struct tgsi_shader_info
> boolean uses_kill; /**< KIL or KILP instruction used? */
> boolean uses_instanceid;
> boolean uses_vertexid;
> + boolean uses_primid;
> boolean origin_lower_left;
> boolean pixel_center_integer;
> boolean color0_writes_all_cbufs;
Looks good to me.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Looks great.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
- Original Message -
> On 03/29/2013 05:30 PM, Brian Paul wrote:
>
> Has this bug been reported to the Topogun developer?
Yes, I have reported via http://www.topogun.com/support/contact-us.htm on 29th
September 2012.
I received no reply since, nor did I try a second time.
Also note tha
- Original Message -
> From: Roland Scheidegger
>
> Conceptually the same as previously done in float_to_half.
> Should cut down number of instructions from 14 to 10 or so, but
> will promote some NaNs to Infs, so it's disabled.
> It gets a bit tricky though handling all the cases corre
I don't see need/benefit in mixing "iround" (ie, float -> int) with "round"
(ie, float -> float).
If this is a one-off, then you should just call
lp_build_intrinsic_unary(builder, "llvm.ppc.altivec.vctsxs", ...)
If you really need an generic intrinsic helper for iround, then please add a new
Looks good to me in principle, but I have some remarks (inline) concerning the
implementation.
Jose
- Original Message -
> From: Adhemerval Zanella
>
> Reviewed-by: Adam Jackson
> Signed-off-by: Adhemerval Zanella
> ---
> src/gallium/auxiliary/gallivm/lp_bld_printf.c | 56
> +++
I only had time to skim through your changes but the series looks great, Roland.
If it's not too much trouble, could you please add a piglit test for explicit
cube derivatives? Also, please confirm there are no piglit regressions.
Jose
- Original Message -
> From: Roland Scheidegger
>
- Original Message -
> I think this was there before and got accidently
> removed during a merge. Same code as for the GS
> context, which is also using an enum instead of
> hardcoded numbers.
>
> Signed-off-by: Zack Rusin
> ---
> src/gallium/auxiliary/draw/draw_llvm.c |8
l/stw_context.h
> +++ b/src/gallium/state_trackers/wgl/stw_context.h
> @@ -28,7 +28,7 @@
> #ifndef STW_CONTEXT_H
> #define STW_CONTEXT_H
>
> -#include
> +#include "stw_icd.h"
Alternatively, you could pre-declare "struct stw_context
ader(hdr);
> +
> + if (hdr->magic != DEBUG_MEMORY_MAGIC) {
> + debug_printf("%s:%u:%s: bad or corrupted memory %p\n",
> + hdr->file, hdr->line, hdr->function, ptr);
> + debug_assert(0);
> + }
> +
> + if (ftr->magic != D
- Original Message -
> > On 04.04.2013 03:45, Zack Rusin wrote:
> > > It's part of SM4 (http://goo.gl/4IpeK). It's also fairly
> > > painful to emulate without branching. Most hardware
> > > supports it natively and even llvm has a 'select' opcode
> > > which can handle it without too muc
- Original Message -
> On 04.04.2013 17:01, Jose Fonseca wrote:
> >
> > - Original Message -
> >>> On 04.04.2013 03:45, Zack Rusin wrote:
> >>>> It's part of SM4 (http://goo.gl/4IpeK). It's also fairly
> >>>> pai
- Original Message -
> > > Erm, unsigned < 0 doesn't make sense.
> >
> > Ah indeed!
> >
> > > Definitely what the description says:
> > > static void
> > > micro_ucmp(union tgsi_exec_channel *dst,
> > > const union tgsi_exec_channel *src0,
> > > const union tgsi_ex
There might be some value in renaming UCMP to be MOVC though. I think
everybody here can agree that UCMP, though semantically correct, is misleading.
Jose
- Original Message -
> Hah, yea, I'm sorry, that's a good point. So movc is a bitcast to unsigned
> followed by ucmp. Alright, I'm w
- Original Message -
> and add a test for it
>
> Signed-off-by: Zack Rusin
> ---
> src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 21
>
> .../tests/graw/fragment-shader/frag-ucmp.sh| 11 ++
> 2 files changed, 32 insertions(+)
> create mo
Looks good Roland.
- Original Message -
> From: Roland Scheidegger
>
> The ar_ge_as_at variable was just very very confusing since the condition
> was actually the other way around (as_at_ge_ar). So change the condition
> (and the selects depending on it) to match the variable name.
> Al
I think that PIPE_BIND_INDIRECT_BUFFER would be more self-descriptive.
Or do you envision other uses of such buffer?
Jose
- Original Message -
> Intended for use with GL_ARB_draw_indirect's DRAW_INDIRECT_BUFFER
> target or for D3D11_RESOURCE_MISC_DRAWINDIRECT_ARGS.
> ---
> src/gallium/d
y xmdpy,
> XMesaBuffer b);
> void
> xmesa_destroy_st_framebuffer(struct st_framebuffer_iface *stfbi);
>
> +struct pipe_resource *
> +xmesa_get_framebuffer_resource(struct st_framebuffer_iface *stfbi,
> + enum st_attachment_type att);
> +
> void
> xmesa_swap_st_framebuffer(struct st_framebuffer_iface *stfbi);
>
> --
> 1.7.3.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Looks good to me.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
SSE2 due to LLVM PR6960. */
> if (!util_cpu_caps.has_sse2)
> return NULL;
> #endif
> --
> 1.8.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-d
,
> + unsigned_cond,
> +uint_bld->zero);
>
> - tmp = lp_build_cmp(&bld_base->base, PIPE_FUNC_NOTEQUAL,
> - emit_data->args[0], bld->bld_base.base.zero);
> -
> - lp_exec_break_condition(&bld->exec_mask, tmp);
> + lp_exec_break_condition(&bld->exec_mask, cond);
> }
>
> static void
> --
> 1.7.10.4
>
>
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
I don't feel strongly about it anyway. Can always change it later.
Jose
- Original Message -
> On 04.04.2013 21:53, Christoph Bumiller wrote:
> > On 04.04.2013 21:44, Jose Fonseca wrote:
> >> I think that PIPE_BIND_INDIRECT_BUFFER would be more self-descriptiv
src->target, src->nr_samples,
> + PIPE_BIND_SAMPLER_VIEW)) {
> + return FALSE;
> +}
> }
>}
> }
> --
> 1.7.3.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Looks good to me.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Zack,
Series looks great to me. I have no further remark (beyond what Roland already
mentioned).
Jose
- Original Message -
> We want to both make sure we never divide by zero to not generate
> sigfpe and that divide by zero is guaranteed to return 0x.
> Based on José idea.
>
>
Series looks good to me.
Jose
- Original Message -
> which means that our execution mask in GS is equal to 1 not 0xf.
>
> Signed-off-by: Zack Rusin
> ---
> src/gallium/auxiliary/tgsi/tgsi_exec.c | 30 +-
> 1 file changed, 17 insertions(+), 13 deletions(-)
Ah.. This indeed rings a bell. I don't recall the details but I'm pretty sure I
was against dual semantics. And the fact that this problem is again showing its
ugly head is the proof of it.
We really should have two IF opcodes. And the state tracker should choose which
one it wants.
Jose
- Original Message -
> - Original Message -
> > Ah.. This indeed rings a bell. I don't recall the details but I'm pretty
> > sure
> > I was against dual semantics. And the fact that this problem is again
> > showing its ugly head is the proof of it.
> >
> > We really should have
- Original Message -
> > - Original Message -
> > > - Original Message -
> > > > Ah.. This indeed rings a bell. I don't recall the details but I'm
> > > > pretty
> > > > sure
> > > > I was against dual semantics. And the fact that this problem is again
> > > > showing its
tive = FALSE;
> - }
> + /* implicit end_primitives, needed in case there are any unflushed
> + vertices in the cache */
> + end_primitive(NULL, bld_base, NULL);
> +
>total_emitted_vertices_vec =
> LLVMBuildLoad(builder, bld->total_emitted_vertices_vec_ptr, "");
>emitted_prims_vec =
> @@ -2767,7 +2797,6 @@ lp_build_tgsi_soa(struct gallivm_state *gallivm,
>/* inputs are always indirect with gs */
>bld.indirect_files |= (1 << TGSI_FILE_INPUT);
>bld.gs_iface = gs_iface;
> - bld.pending_end_primitive = FALSE;
>bld.bld_base.emit_fetch_funcs[TGSI_FILE_INPUT] = emit_fetch_gs_input;
>bld.bld_base.op_actions[TGSI_OPCODE_EMIT].emit = emit_vertex;
>bld.bld_base.op_actions[TGSI_OPCODE_ENDPRIM].emit = end_primitive;
> --
> 1.7.10.4
>
>
Looks good to me.
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
- Original Message -
> This is a basic implementation of the pipeline statistics in the
> draw module. The interface is similar to the stream output statistics
> and also requires that the callers explicitly enable it.
> Included is the implementation of the interface in llvmpipe and
> so
- Original Message -
> From: "gregory"
> To: "gregory hainaut"
FWIW, your emails BCC'ing the list are a bit of a pain. They manage elude most
of my mail filtering rules, and replying-to-all doesn't include the list...
Jose
> Sent: Friday, April 12, 2013 5:22:02 PM
> Subject: [Mesa-dev
- Original Message -
> From: Christoph Bumiller
>
> This is the only sane solution for nv50 and nvc0 (really, trust me),
> but since on other hardware the border colour is tightly coupled with
> texture state they'd have to undo the swizzle, so I've added a cap.
>
> The name of the cap c
- Original Message -
> Not to mention the sheer insanity, ugliness and emotional pain incurred
> when writing that code when it COULD be so easy and simple in the state
> tracker where you know that textures and samplers are tightly coupled,
> while in gallium I cannot assume that to be th
Thanks Christoph. Will do.
Jose
- Original Message -
> You can merge this with the original UIF patch if you want.
> ---
> .../drivers/nv50/codegen/nv50_ir_from_tgsi.cpp |7 ++-
> .../drivers/nv50/codegen/nv50_ir_lowering_nv50.cpp |2 +-
> .../drivers/nvc0/codegen/nv50_ir
- Original Message -
> On 14.04.2013 13:44, Jose Fonseca wrote:
> > - Original Message -
> >> From: Christoph Bumiller
> >>
> >> This is the only sane solution for nv50 and nvc0 (really, trust me),
> >> but since on other hardw
- Original Message -
> Am 14.04.2013 10:12, schrieb jfons...@vmware.com:
> > From: José Fonseca
> >
> > TGSI_OPCODE_IF condition had two possible interpretations:
> >
> > - src.x != 0.0f
> >
> > - Mesa statetracker when PIPE_SHADER_CAP_INTEGERS was false either for
> > vertex and
- Original Message -
> On 14.04.2013 15:34, Jose Fonseca wrote:
> >
> > - Original Message -
> >> On 14.04.2013 13:44, Jose Fonseca wrote:
> >>> - Original Message -
> >>>> From: Christoph Bumiller
> >>>&g
der, level, indexi, "");
> stride1 = LLVMBuildGEP(builder, stride_array, indexes, 2, "");
> stride1 = LLVMBuildLoad(builder, stride1, "");
> --
> 1.7.9.5
>
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
- Original Message -
> The R600 code looks good.
>
> Marek
>
>
When I rebased on top of master, I had a conflict on r600. Below is how I
resolved. Please confirm you're OK with it.
Jose
diff --git a/src/gallium/drivers/r600/r600_shader.c
b/src/gallium/drivers/r600/r600_shader.c
inde
Thanks for the update.
Looks good to me FWIW.
Jose
- Original Message -
> From: Christoph Bumiller
>
> This is the only sane solution for nv50 and nvc0 (really, trust me),
> but since on other hardware the border colour is tightly coupled with
> texture state they'd have to undo the sw
- Original Message -
> >> Those are just ideas. I'm open to discussion.
> >
> > The driver is disabled by default and needs to be enabled via
> > --with-gallium-drivers=i965.
>
> I think a warning + maybe something like
> --with-gallium-drivers=i965g-unofficial might work,
If not, then I
- Original Message -
> On Son, 2013-04-14 at 09:12 +0100, jfons...@vmware.com wrote:
> >
> > diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
> > b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c
> > index 314c963..dfc7cbc 100644
> > --- a/src/gallium/drivers/radeon/r
- Original Message -
> On Wed, Apr 17, 2013 at 8:09 AM, Marek Olšák wrote:
> > On Tue, Apr 16, 2013 at 9:58 PM, Chia-I Wu wrote:
> >>
> >> On Wed, Apr 17, 2013 at 12:58 AM, Matt Turner wrote:
> >>>
> >>> I think everything Marek said was correct. If you could extend Gallium
> >>> to co
Series looks good to me.
Reviewed-by: Jose Fonseca
- Original Message -
> The specification says that the geometry shader should exit if the
> number of emitted vertices is bigger or equal to max_output_vertices and
> we can't do that because we're running in the So
t
> >
> > diff --git a/bin/perf-annotate-jit b/bin/perf-annotate-jit
> > new file mode 100755
> > index 000..7ebc965
> > --- /dev/null
> > +++ b/bin/perf-annotate-jit
> > @@ -0,0 +1,240 @@
> > +#!/usr/bin/env python
> > +#
> > +# Copyrig
IPE_PRIM_TRIANGLES_ADJACENCY:
> - return vertices / 3;
> + return vertices / 6;
> case PIPE_PRIM_TRIANGLE_STRIP_ADJACENCY:
> - return (vertices > 2) ? vertices - 2 : 0;
> + return (vertices > 5) ? 1 + (vertices - 6)/2 : 0;
> case PIPE_PRIM_QUADS:
>
; +
> + This represents the default case in the switch, which is taken if no
> other
> + case matches.
> +
> +
> +.. opcode:: ENDSWITCH - End of switch
> +
> + Ends a switch expression.
> +
> +
> .. opcode:: PUSHA - Push Address Register On Stack
>
>p
Series looks good to me. Thanks for the cleanup.
Jose
- Original Message -
> From: Roland Scheidegger
>
> Now that it is possible to query drivers for the max sampler view it should
> be safe to increase this without crashing.
> Not entirely convinced this really works correctly though
Looks great. Thanks for doing this! Future is now.
Jose
- Original Message -
> This adds a gallium cap that allows us to fake GL3.0 by
> not exposing MSAA on sw rendering. It also forces the
> extra extensions needed for GL3.2. Along with a patch to
> raise the GLSL version in llvmpipe th
This should be possible with:
struct pipe_resource * (*resource_from_handle)(struct pipe_screen *,
const struct pipe_resource
*templat,
struct winsys_handle *handle);
Nothing impedes this to w
- Original Message -
> This patches add MESA_copy_sub_buffer support to the dri sw loader and
> then to gallium state tracker, llvmpipe, softpipe and other bits.
>
> It reuses the dri1 driver extension interface, and it updates the swrast
> loader interface for a new putimage which can t
- Original Message -
> Caching in the vbuf module meant that once a vertex has been
> emitted it was cached, but it's possible for a vertex at the
> same location to be emitted again, but this time with a different
> front-face semantic. Caching was causing the first version of the
> vertex
Sorry for the delay. Thanks for the update.
Please update the other sw_winsys implementations in src/gallium/winsys/sw too.
I think that updating the prototype and ignoring the new parameter should be
fine.
Otherwise looks good.
Jose
- Original Message -
> This patches add MESA_cop
This is worse for SW renderers...
Jose
- Original Message -
> From: Marek Olšák
>
> ---
> src/mesa/state_tracker/st_cb_clear.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_cb_clear.c
> b/src/mesa/state_tracker/st_cb_cl
arek
>
> On Fri, Dec 13, 2013 at 3:21 PM, Jose Fonseca wrote:
> > This is worse for SW renderers...
> >
> > Jose
> >
> > - Original Message -
> >> From: Marek Olšák
> >>
> >> ---
> >> src/mesa/state_tracker/st_cb_
args->e01o = lp_build_broadcast_scalar(&bld, LLVMBuildFSub(b, tmp0,
> tmp1, "e01o"));
> - tmp1 = LLVMBuildShuffleVector(b, p1p2, p1p2, shuf1u3u, "");
> - tmp0 = LLVMBuildFSub(b, p1p2, tmp1, "e12o20o");
> - args->e12o = lp_build_extract_broadcast(gallivm, typef4, typef4, tmp0,
> zeroi);
> - args->e20o = lp_build_extract_broadcast(gallivm, typef4, typef4, tmp0,
> - lp_build_const_int32(gallivm,
> 2));
> - }
> -
> args->dy20_ooa = lp_build_extract_broadcast(gallivm, typef4, typef4,
> dxy20, onei);
> args->dy01_ooa = lp_build_extract_broadcast(gallivm, typef4, typef4,
> dxy01, onei);
>
> --
> 1.7.9.5
>
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
The only way to hit both
> pipe->clear and clear_with_quad for depth and stencil, respectively,
> is to have a partial stencil writemask.
>
> Marek
>
> On Fri, Dec 13, 2013 at 5:46 PM, Jose Fonseca wrote:
> >
> > So, if this provides a significant performance difference
Looks great to me.
- Original Message -
> It's possible to bind a smaller buffer as a constant buffer, than
> what the shader actually uses/requires. This could cause nasty
> crashes. This patch adds the architecture to pass the maximum
> allowable constant buffer index to the jit so let i
- Original Message -
> On Tue, Jan 7, 2014 at 3:59 PM, Brian Paul wrote:
> > On 01/06/2014 05:22 PM, Erik Faye-Lund wrote:
> >>
> >> On Tue, Jan 7, 2014 at 12:12 AM, Brian Paul wrote:
> >>>
> >>> Evidently, there's some other definition of "min" and "max" that
> >>> causes MSVC to choke o
- Original Message -
> On Wed, Jan 8, 2014 at 6:30 PM, wrote:
> > From: José Fonseca
> >
> > This example is very useful to understand the rasterization of lines.
> > And with this change, points too.
> >
> > Adding a key / command-line option to switch modes is left for a future
> > o
- Original Message -
> On Wed, Jan 8, 2014 at 6:27 PM, wrote:
> > }
> > -
> > +
> > + if (0) {
> > + debug_printf(" bbox: (%i, %i) - (%i, %i)\n",
> > + bbox.x0, bbox.y0,
> > + bbox.x1, bbox.y1);
> > + }
> > +
> > if (!u_rect_test_inter
- Original Message -
> Am 08.01.2014 18:27, schrieb jfons...@vmware.com:
> > From: José Fonseca
> >
> > Commit eda21d2a3010d9fc5a68b55a843c5e44b2abf8dd fixed the rasterization
> > of points for Direct3D but ended up breaking the rasterization of OpenGL
> > non-sprite points, in particul
ons.EXT_texture_snorm
> + ? GL_LUMINANCE_ALPHA : 0;
> + case GL_INTENSITY_SNORM:
> + case GL_INTENSITY8_SNORM:
> + case GL_INTENSITY16_SNORM:
> + return _mesa_is_desktop_gl(ctx) && ctx->Extensions.EXT_texture_snorm
> + ? GL_INTENSITY : 0;
> +
> cas
- Original Message -
> Module: Mesa
> Branch: master
> Commit: 84732a982c3eeaca2e2809532c8422dc5f7045c1
> URL:
> https://urldefense.proofpoint.com/v1/url?u=http://cgit.freedesktop.org/mesa/mesa/commit/?id%3D84732a982c3eeaca2e2809532c8422dc5f7045c1&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr
This series is pretty much what I proposed several months ago, rebased on top
of master, with minor if any tweaks.
Still to do is remove the deprecated abstractions (which now are mere wrappers
of the c11 ones).
That said, this series is already useful as is, not only because of the code
de-du
- Original Message -
> The predominant feedback on this adventure has been to make the MESA_FORMATs
> match the PIPE, or gallium formats but every journey I've made down that
> path has been fraught with peril. There are some cases where PIPE_FORMATs
> are even more confusing then MESA_FORM
Looks good AFAICT. Thanks Brian.
Jose
- Original Message -
> Fixes regression from 9baa45f78b8ca7d66280e36009b6a685055d7cd6
>
> v2: incorporate a few small changes suggested by Roland.
> ---
> src/gallium/drivers/llvmpipe/lp_rast.c | 62 ---
> src/gallium/drivers/llvmpipe
nap(v0[0][1]) - adj;
>
> - int int_width = fixed_width >> FIXED_ORDER;
> + int int_width;
> + /* Point size as fixed point integer. For GL legacy points
> + * the point size is always a whole integer.
> + */
> + fixed_width = MAX2(FIXED_ONE
mailing list
> mesa-dev@lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=OUomIkBN13xAFvxxWHODUEiG1q28%2B7LMvw3w3IuPljQ%3D%0A&
- Original Message -
> On 01/17/2014 12:56 PM, Ian Romanick wrote:
> > On 01/17/2014 08:33 AM, jfons...@vmware.com wrote:
> >> diff --git a/src/mesa/drivers/dri/r200/r200_context.c
> >> b/src/mesa/drivers/dri/r200/r200_context.c
> >> index f82424b..f613e56 100644
> >> --- a/src/mesa/drive
Looks good to me AFAICT.
Jose
- Original Message -
> From: Roland Scheidegger
>
> Instead of skipping x/y clipping completely if there's point_tri_clip points
> use guard band clipping. This should be easier (previously we could not
> disable
> generating the x/y bits in the clip mask f
Good catch Brian. Change looks good to me AFAICT.
We do need more this sort of assertions in the draw module. I never fail to
get surprised at how intricate and sensitive draw module is -- mostly due the
fact that it reaches out to the upstream gallium interface from within the
driver. I do h
Series looks great to me.
Jose
- Original Message -
> Fixes several colorbuffer tests, including piglit "fbo-drawbuffers-none"
> for "gl_FragColor" and "glDrawPixels" cases.
>
> v2: rework patch to only avoid creating extra shader variants when
> TGSI_PROPERTY_FS_COLOR0_WRITES_ALL_CBUFS
t; --
> 1.7.10.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOc
Only skimmed through but series looks good to me.
Jose
- Original Message -
> ---
> src/gallium/drivers/svga/svga_tgsi_insn.c | 94
> ++---
> 1 file changed, 47 insertions(+), 47 deletions(-)
>
> diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c
> b/src/g
- Original Message -
> On Thu, Jan 09, 2014 at 11:32:10AM -0800, Jose Fonseca wrote:
> > This series is pretty much what I proposed several months ago, rebased on
> > top of master, with minor if any tweaks.
> >
> > Still to do is remove the deprecated abstr
/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=D2VWSJToZW4odPM75DA3MQ2BLfdEWhzwNh39Und8Xlo%3D%0A&s=480298215bf1be9132dfac454c18e51c19937d6a1ad88091e36d3b5e71b044b8
>
Reviewed-by: Jose Fonseca
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
mmit mailing list
> mesa-com...@lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-commit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=g8fFFoc2clMzXlUCVio0faQ7npLyyWmzG2X93CYOm
.org
> > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-commit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=g8fFFoc2clMzXlUCVio0faQ7npLyyWmzG2X93CYOm9M%3D%0A&s=82b7edeed1e63abc344f02ee3a3d4870f17e9fa90c1b8ac8b34c8d1f1570f674
> >
>
> Reviewed-by: Jose Fonseca
>
Doh. It's a commit message not a review request! *must drink a cup of coffee*
Jose
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
If drivers has issues dealing with NULL cbufs, then we could have the state
trackers using dummy rendertargets. But probably it's more efficent to handle
in the pipe drivers.
My concern is that this ends up being a rare condition in practice, and that
pipe drivers end up having a lot of bugs h
gt; static void
> alloc_image_data(struct llvmpipe_resource *lpr)
> {
> - uint alignment = MAX2(16, util_cpu_caps.cacheline);
> + uint alignment = MAX2(64, util_cpu_caps.cacheline);
> uint level;
> uint offset = 0;
>
> --
> 1.8.1.4
>
> ____
- Original Message -
> Tomorrow or Friday I'm going to send out the last of the
> GL_ARB_separate_shader_objects patches. Shortly after that, I will send
> out patches to enable GL_EXT_separate_shader_objects on GLES. This EXT
> is the GLES subset of the ARB extension.
>
> In preparing f
- Original Message -
> On 04/03/2014 08:57 AM, jfons...@vmware.com wrote:
> > From: José Fonseca
> >
> > This prevents buffer overflow w/ llvmpipe when running piglit
> >
> >bin/gl-3.2-layered-rendering-clear-color-all-types 1d_array single_level
> >-fbo -auto
> > ---
> > src/m
- Original Message -
> Am 03.04.2014 17:56, schrieb Brian Paul:
> > ---
> > src/gallium/drivers/llvmpipe/lp_state_sampler.c | 14 --
> > 1 file changed, 14 deletions(-)
> >
> > diff --git a/src/gallium/drivers/llvmpipe/lp_state_sampler.c
> > b/src/gallium/drivers/llvmpipe/
Pretty neat!
- Original Message -
> Hi everyone,
>
> I've set up a readthedocs.org build to point at the gallium docs:
>
> https://urldefense.proofpoint.com/v1/url?u=http://gallium.readthedocs.org/en/latest/&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDz
To prevent this to ocurr again in the future we should be probably using
os_malloc/os_free and friends instead of the overloaded MALLOC/FREE/etc macros.
We should probably kill MALLOC/FREE completely.
Jose
- Original Message -
> We were using REALLOC() from u_memory.h but FREE() from im
This is not a review but just a side remark: I strongly believe that in the
medium/long term translate_sse and rtasm modules should be abandoned, and
replaced with a new translate_llvm.c module. All the functionality for doing
so is already in draw/gallivm modules, it's really just a re-factor
- Original Message -
> On 04/16/2014 06:18 AM, Jose Fonseca wrote:
> > Module: Mesa
> > Branch: master
> > Commit: e3c58cdfd97d390cb4c1a02852ab0417bd68c861
> > URL:
> > https://urldefense.proofpoint.com/v1/url?u=http://cgit.fre
Thanks for the review.
- Original Message -
> On 04/23/2014 07:55 AM, jfons...@vmware.com wrote:
> > From: José Fonseca
> >
> > This prevents buffer overflow w/ llvmpipe when running piglit
> >
> >bin/gl-3.2-layered-rendering-clear-color-all-types 1d_array single_level
> >-fbo -au
Richard, Michel,
Apologies for the long silence. I flagged this thread as worth following, but
I failed to noticed the RFC to me.
I glanced over it and the series looks good to me AFAICT. I agree that it is a
better to defer the endianess to C-preprocessing time.
Jose
- Original Message
- Original Message -
> On 24.04.2014 03:12, Jose Fonseca wrote:
> > Module: Mesa
> > Branch: master
> > Commit: fd92346c53ed32709c7b56ce58fb9c9bf43ce9a8
> > URL:
> > https://urldefense.proofpoint.com/v1/url?u=http://cgit.fre
Series looks good to me.
Jose
- Original Message -
> ---
> src/mesa/swrast/s_texture.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/swrast/s_texture.c b/src/mesa/swrast/s_texture.c
> index 9273e94..5fd80ca 100644
> --- a/src/mesa/swras
; Marek
>
> On Thu, Apr 24, 2014 at 1:31 PM, Jose Fonseca wrote:
> >
> >
> > - Original Message -
> >> On 24.04.2014 03:12, Jose Fonseca wrote:
> >> > Module: Mesa
> >> > Branch: master
> >> > Commit: fd92346c53ed3270
Oop. Please ignore that. I forgot to specify the filename when producing the
diff.
Jose
- Original Message -
> The patch fixes the issue, but it also contains some unrelated drisw changes.
>
> Marek
>
> On Thu, Apr 24, 2014 at 2:37 PM, Jose Fonseca wrote:
> > No
Looks great to me. Thanks Zack.
Jose
- Original Message -
> Lets make draw_get_option_use_llvm function available unconditionally
> and use it to avoid useless allocations when LLVM paths are active.
> TGSI machine is never used when we're using LLVM.
>
> Signed-off-by: Zack Rusin
> ---
Pushed.
Jose
- Original Message -
> NP, thanks for the review Jose. Please could someone commit the
> series for me? I'll follow up with patches to fix other formats for BE.
>
> Thanks,
> Richard
>
> Jose Fonseca writes:
> > Richard, Michel,
> &
401 - 500 of 2351 matches
Mail list logo
