Re: [Mesa-dev] [PATCH 1/2] glapi: gl_table.py: remove unused variable 'es'

2015-06-19 Thread Dylan Baker
I was planning to do this too. Reviewed-by: Dylan Baker On Jun 19, 2015 5:17 AM, "Emil Velikov" wrote: > None of the three build systems ever set it, as such we can clear things > up a bit. > > Cc: Dylan Baker > Cc: Jose Fonseca > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-19 Thread Dylan Baker
ns build. > > XXX: There are no more users of gl_api.filter_functions_by_api(). Should > we just nuke it ? > > Cc: Dylan Baker > Cc: Jose Fonseca > Signed-off-by: Emil Velikov > --- > src/mapi/glapi/gen/remap_helper.py | 8 > 1 file changed, 8 deletions(-

Re: [Mesa-dev] [PATCH 2/2] glapi: remap_helper.py: remove unused argument 'es'

2015-06-21 Thread Dylan Baker
Cleanups are definitely party of the plan. I'm doing three phases. First is going to mako for generation. Second is using the khronos XML. Finally I want to clean things up and hybridize for python 3 On Jun 21, 2015 7:34 AM, "Emil Velikov" wrote: > On 19/06/15 18:43, Dylan Bak

Re: [Mesa-dev] [RFC shader-db] Add support for shadertoy tests

2015-06-23 Thread Dylan Baker
I have a couple of python pointers for you, feel free to take them or leave them. Dylan On Tue, Jun 16, 2015 at 03:46:50PM -0400, Rob Clark wrote: > Attached script grabs shaders from shadertoy, and dumps them out as > .shader_test files which can be run through shader-db for compiler > testing.

[Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-02 Thread Dylan Baker
One of the plugins I use with vim "helpfully" added an underscore to the front of mode for kicks. Obviously this isn't a feature used very often because it's been broken since d986cb7c70db (since May 20th), and no one has noticed. Signed-off-by: Dylan Baker ---

Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-03 Thread Dylan Baker
I asked about dumping them and was told that they would leave mesa only when x itself died. If be more than happy to see them go if they're not useful On Jul 3, 2015 06:28, "Emil Velikov" wrote: > On 02/07/15 18:25, Dylan Baker wrote: > > One of the plugins I use with

Re: [Mesa-dev] [PATCH] nv50: fix a SIGSEGV with piglit bin/gl-3.1-vao-broken-attrib

2015-07-06 Thread Dylan Baker
On Mon, Jul 06, 2015 at 11:34:23PM +0200, Samuel Pitoiset wrote: > Before validating vertex arrays we need to check if a VBO is present. > Checking if vb->buffer is not NULL fixes the issue. > > Signed-off-by: Samuel Pitoiset > --- > src/gallium/drivers/nouveau/nv50/nv50_vbo.c | 5 + > 1 fil

Re: [Mesa-dev] [PATCH] nv50: fix a SIGSEGV with piglit bin/gl-3.1-vao-broken-attrib

2015-07-06 Thread Dylan Baker
> >> + } else > >> + if (!vb->buffer) { > > > > Should the else and if be on the same line? > > The general style elsewhere is to do it in this weird way. Can't say > I'm a big fan, but I prefer consistency. > > I'd happily take a change that undid that oddity. > Odd, okay. signatur

Re: [Mesa-dev] [PATCH shader-db] Add support for shadertoy tests

2015-07-09 Thread Dylan Baker
There's a few more cleanups you could do if you wanted, but either way: Reviewed-by: Dylan Baker On Thu, Jul 09, 2015 at 10:41:05AM -0400, Rob Clark wrote: > Attached script grabs shaders from shadertoy, and dumps them out as > .shader_test files which can be run through shader-db f

Re: [Mesa-dev] [PATCH] [v3] i965: Split out gen8 push constant state upload

2015-07-13 Thread Dylan Baker
On Fri, Jul 10, 2015 at 02:24:42PM -0700, Ben Widawsky wrote: > On Fri, Jul 10, 2015 at 12:03:54PM -0700, Matt Turner wrote: > > I don't think putting Intel-internal links in the commit message is a good > > idea. > > > > Ken's made similar comments to me. > > > > Also, so much off the wall comm

Re: [Mesa-dev] [PATCH] glapi: fix argument parsing in glX_proto_recv.py

2015-07-21 Thread Dylan Baker
face.h and the gl* headers) for xserver. > > > > Adam can we truly nuke (some of) the generated sources in mesa, or > > does X/xserver relies on them ? > > > > Cheers, > > Emil > > > > On 3 July 2015 at 21:13, Dylan Baker wrote: > >> I asked

Re: [Mesa-dev] [PATCH shader-db] check_dependencies: refactor to a python script

2015-10-12 Thread Dylan Baker
On Sat, Oct 10, 2015 at 06:45:08PM +1100, Rhys Kidd wrote: > Deliver consistency with all other shader-db scripts, which are Python > scripts. > > No change in features or output strings. > > Passed pep8, except for two comment lines suggesting commands to add > dependencies to the [require] sec

Re: [Mesa-dev] [PATCH 5/7] nir/algebraic: Support specifying variable as constant or by type

2015-01-29 Thread Dylan Baker
On Thursday, January 29, 2015 17:00:08 Kenneth Graunke wrote: > On Thursday, January 29, 2015 12:50:20 PM Jason Ekstrand wrote: > > --- > > src/glsl/nir/nir_algebraic.py | 20 +--- > > src/glsl/nir/nir_opt_algebraic.py | 12 +--- > > 2 files changed, 26 insertions(+), 6

Re: [Mesa-dev] [PATCH] glsl: Allow compatibility shaders with MESA_GL_VERSION_OVERRIDE=...

2017-02-02 Thread Dylan Baker
Tested-by: Dylan Baker signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] vulkan/util: Add generator for enum_to_str functions

2017-02-17 Thread Dylan Baker
This adds a python generator to produce enum_to_str functions for Vulkan from the vk.xml API description. It supports extensions as well as core API features, and the generator works with both python2 and python3. CC: Jason Ekstrand Signed-off-by: Dylan Baker --- configure.ac

Re: [Mesa-dev] [PATCH] vulkan/util: Add generator for enum_to_str functions

2017-02-17 Thread Dylan Baker
I'll send out a v2 soon. Quoting Matt Turner (2017-02-17 11:38:17) > On Fri, Feb 17, 2017 at 10:49 AM, Dylan Baker wrote: > > This adds a python generator to produce enum_to_str functions for > > Vulkan from the vk.xml API description. It supports extensions as well > >

[Mesa-dev] [PATCH v2 2/2] vulkan: Combine wsi and util makefiles

2017-02-17 Thread Dylan Baker
cc: Matt Turner Signed-off-by: Dylan Baker v2: - add this patch --- configure.ac | 3 +-- src/Makefile.am| 2 +- src/intel/vulkan/Makefile.am | 4 ++-- src/vulkan/{wsi => }/Makefile.am | 16 ++-- src/vulkan/Makefile.sour

[Mesa-dev] [PATCH v2 1/2] vulkan/util: Add generator for enum_to_str functions

2017-02-17 Thread Dylan Baker
This adds a python generator to produce enum_to_str functions for Vulkan from the vk.xml API description. It supports extensions as well as core API features, and the generator works with both python2 and python3. Signed-off-by: Dylan Baker v2: - Fix automake comments from Matt

[Mesa-dev] [PATCH 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-22 Thread Dylan Baker
This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan

[Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
d if conditions - don't put spaces around brackets - don't import modules as caps (ET -> et) - Use docstrings instead of comments Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 63 ++--- 1 file changed, 34 insertions(+), 29 deletion

[Mesa-dev] [PATCH 01/13] anv: anv_entrypoints_gen.py: use a main function

2017-02-22 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [PATCH 00/13] cleanup anv_entrpoints_gen.py

2017-02-22 Thread Dylan Baker
idize) - generate the header and the code in one go I've put emphasis on the readability of the template rather than the readability of the output code, it's relatively easy to pipe the code through 'indent' to make it more readable. Dylan Baker (13): anv: anv_entrypoints_ge

[Mesa-dev] [PATCH 05/13] anv: split main into two functions in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 + 1 file changed, 50

[Mesa-dev] [RESEND 12/13] anv: don't use Element.get in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
is patch changes the behavior slightly by replacing get with explicit lookup in the Element.attrib dictionary, and using xpath to only iterate over extensions with a "protect" attribute. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 13 +++-- 1 fi

[Mesa-dev] [RESEND 04/13] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
It's slow, and has the potential for encoding issues. Signed-off-by: Dylan Baker --- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_gen.py | 6 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/

[Mesa-dev] [RESEND 03/13] anv: make constants capitals in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_g

[Mesa-dev] [RESEND 01/13] anv: anv_entrypoints_gen.py: use a main function

2017-02-22 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [RESEND 11/13] anv: use dict.get in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel

[Mesa-dev] [RESEND 05/13] anv: split main into two functions in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 + 1 file changed, 50

[Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

2017-02-22 Thread Dylan Baker
This changes the python generator to write the files itself, rather than piping them out. This has a couple of advantages: first, it encapsulates the encoding. Second, it ensures that the header file and code file are generated at the same time with the same data. Signed-off-by: Dylan Baker

[Mesa-dev] [RESEND 02/13] anv: Use python style in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
d if conditions - don't put spaces around brackets - don't import modules as caps (ET -> et) - Use docstrings instead of comments Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 63 ++--- 1 file changed, 34 insertions(+), 29 deletion

[Mesa-dev] [RESEND 07/13] anv: convert C generation to template in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker --- src/intel/v

[Mesa-dev] [RESEND 10/13] anv: anv_entrypoints_gen.py: use reduce function.

2017-02-22 Thread Dylan Baker
Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 0c9812a846..e1c5ac6ddf 1

[Mesa-dev] [RESEND 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-22 Thread Dylan Baker
This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan

[Mesa-dev] [RESEND 09/13] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

2017-02-22 Thread Dylan Baker
hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/in

[Mesa-dev] [RESEND 13/13] anv: use cElementTree in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/in

[Mesa-dev] [RESEND 04/13] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
It's slow, and has the potential for encoding issues. Signed-off-by: Dylan Baker --- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_gen.py | 6 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/Makefile.am b/src/

[Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

2017-02-22 Thread Dylan Baker
This changes the python generator to write the files itself, rather than piping them out. This has a couple of advantages: first, it encapsulates the encoding. Second, it ensures that the header file and code file are generated at the same time with the same data. Signed-off-by: Dylan Baker

[Mesa-dev] [RESEND 12/13] anv: don't use Element.get in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
is patch changes the behavior slightly by replacing get with explicit lookup in the Element.attrib dictionary, and using xpath to only iterate over extensions with a "protect" attribute. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 13 +++-- 1 fi

[Mesa-dev] [RESEND 05/13] anv: split main into two functions in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 96 + 1 file changed, 50

[Mesa-dev] [RESEND 09/13] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

2017-02-22 Thread Dylan Baker
hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/in

[Mesa-dev] [RESEND 01/13] anv: anv_entrypoints_gen.py: use a main function

2017-02-22 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index

[Mesa-dev] [RESEND 07/13] anv: convert C generation to template in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker --- src/intel/v

[Mesa-dev] [RESEND 10/13] anv: anv_entrypoints_gen.py: use reduce function.

2017-02-22 Thread Dylan Baker
Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 0c9812a846..e1c5ac6ddf 1

[Mesa-dev] [RESEND 02/13] anv: Use python style in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
d if conditions - don't put spaces around brackets - don't import modules as caps (ET -> et) - Use docstrings instead of comments Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 63 ++--- 1 file changed, 34 insertions(+), 29 deletion

[Mesa-dev] [RESEND 13/13] anv: use cElementTree in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/in

[Mesa-dev] [RESEND 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-22 Thread Dylan Baker
This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++--- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan

[Mesa-dev] [RESEND 11/13] anv: use dict.get in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel

[Mesa-dev] [RESEND 03/13] anv: make constants capitals in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_g

Re: [Mesa-dev] [PATCH 02/13] anv: Use python style in anv_entrypoints_gen.py

2017-02-22 Thread Dylan Baker
Quoting Jason Ekstrand (2017-02-22 15:28:50) > On Wed, Feb 22, 2017 at 3:15 PM, Dylan Baker wrote: > > These are all fairly small cleanups/tweaks that don't really deserve > their own patch. > > - Prefer comprehensions to map() and filter(), since they&#x

[Mesa-dev] [PATCH] vulkan: Fix gen_enum_to_str in out of tree builds

2017-02-22 Thread Dylan Baker
In some configurations the util directory is created when building out of tree, but not others. This patch ensures that it's created. cc: Matt Turner Signed-off-by: Dylan Baker --- src/vulkan/Makefile.am | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/v

Re: [Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

2017-02-23 Thread Dylan Baker
Quoting Emil Velikov (2017-02-23 02:32:17) > On 22 February 2017 at 23:35, Dylan Baker wrote: > > This changes the python generator to write the files itself, rather than > > piping them out. This has a couple of advantages: first, it encapsulates > > the encoding. Second

Re: [Mesa-dev] [RESEND 04/13] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
mesa. > > On 22 February 2017 at 23:36, Dylan Baker wrote: > > It's slow, and has the potential for encoding issues. > > > > Signed-off-by: Dylan Baker > > --- > > src/intel/vulkan/Makefile.am| 6 ++ > > src/intel/vulkan/anv_entryp

Re: [Mesa-dev] [RESEND 06/13] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-23 Thread Dylan Baker
Sure, I'll add a patch for v2 Quoting Emil Velikov (2017-02-23 03:14:49) > On 22 February 2017 at 23:36, Dylan Baker wrote: > > > +void anv_set_dispatch_devinfo(const struct gen_device_info *info); > Dead declaration since commit 6d557ae4032adafc85a4cb5a76d8653bf0cf663

Re: [Mesa-dev] [RESEND 08/13] anv: generate anv_entrypoints.{h, c} in one command

2017-02-23 Thread Dylan Baker
Quoting Emil Velikov (2017-02-23 09:29:40) > On 23 February 2017 at 17:22, Dylan Baker wrote: > > Quoting Emil Velikov (2017-02-23 02:32:17) > >> On 22 February 2017 at 23:35, Dylan Baker wrote: > >> > This changes the python generator to write the files itself,

[Mesa-dev] [PATCH v2 3/14] anv: make constants capitals in anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v2 4/14] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
It's slow, and has the potential for encoding issues. v2: - pass xml file location via argument - update Android.mk Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 4 ++-- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_g

[Mesa-dev] [PATCH v2 1/14] anv: anv_entrypoints_gen.py: use a main function

2017-02-23 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 - 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 93511ec

[Mesa-dev] [PATCH v2 5/14] anv: split main into two functions in anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 108 - 1 file changed, 56 insertions

[Mesa-dev] [PATCH v2 0/14] cleanup anv_entrpoints_gen.py

2017-02-23 Thread Dylan Baker
ile via an argument - add flag to control output directory - Attempt to update android makefiles Dylan Baker (14): anv: anv_entrypoints_gen.py: use a main function anv: Use python style in anv_entrypoints_gen.py anv: make constants capitals in anv_entrypoints_gen.py anv: don

[Mesa-dev] [PATCH v2 11/14] anv: use dict.get in anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel

[Mesa-dev] [PATCH v2 2/14] anv: Use python style in anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
d if conditions - don't put spaces around brackets - don't import modules as caps (ET -> et) - Use docstrings instead of comments v2: - Replace comprehensions with multiplication Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 63 ++ 1

[Mesa-dev] [PATCH v2 14/14] anv: Remove dead prototype from entrypoints

2017-02-23 Thread Dylan Baker
Spotted by Emil. v2: - Add this patch Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index b498176..44b6d2c 100644 --- a/src/intel

[Mesa-dev] [PATCH v2 9/14] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

2017-02-23 Thread Dylan Baker
hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/in

[Mesa-dev] [PATCH v2 6/14] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-23 Thread Dylan Baker
This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 75 ++ 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan

[Mesa-dev] [PATCH v2 7/14] anv: convert C generation to template in anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker --- src/intel/v

[Mesa-dev] [PATCH v2 13/14] anv: use cElementTree in anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/in

[Mesa-dev] [PATCH v2 8/14] anv: generate anv_entrypoints.{h, c} in one command

2017-02-23 Thread Dylan Baker
-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 7 +- src/intel/vulkan/Makefile.am| 8 ++ src/intel/vulkan/anv_entrypoints_gen.py | 33 +- 3 files changed, 22 insertions(+), 26 deletions(-) diff --git a/src/intel/vulkan/Android.mk b

[Mesa-dev] [PATCH v2 10/14] anv: anv_entrypoints_gen.py: use reduce function.

2017-02-23 Thread Dylan Baker
Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 7386b1d..cb28050 100644

[Mesa-dev] [PATCH v2 12/14] anv: don't use Element.get in anv_entrypoints_gen.py

2017-02-23 Thread Dylan Baker
is patch changes the behavior slightly by replacing get with explicit lookup in the Element.attrib dictionary, and using xpath to only iterate over extensions with a "protect" attribute. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 13 +++-- 1 fi

Re: [Mesa-dev] [PATCH v2 6/14] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-24 Thread Dylan Baker
Quoting Emil Velikov (2017-02-24 05:57:24) > On 24 February 2017 at 10:28, Eric Engestrom > wrote: > > On Thursday, 2017-02-23 10:46:19 -0800, Dylan Baker wrote: > >> This produces an identical file except for whitespace. > >> > >> Signed-off-by: Dylan

[Mesa-dev] [PATCH v3 02/15] anv: Use python style in anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
d if conditions - don't put spaces around brackets - don't import modules as caps (ET -> et) - Use docstrings instead of comments v2: - Replace comprehensions with multiplication Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 63 ++ 1

[Mesa-dev] [PATCH v3 04/15] anv: don't pass xmlfile via stdin anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
It's slow, and has the potential for encoding issues. v2: - pass xml file location via argument - update Android.mk Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 4 ++-- src/intel/vulkan/Makefile.am| 6 ++ src/intel/vulkan/anv_entrypoints_g

[Mesa-dev] [PATCH v3 03/15] anv: make constants capitals in anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
Again, it's standard python style. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py

[Mesa-dev] [PATCH v3 15/15] anv: Remove dead prototype from entrypoints

2017-02-24 Thread Dylan Baker
Spotted by Emil. v2: - Add this patch Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 72d8c17..ecdff13 100644 --- a/src/intel

[Mesa-dev] [PATCH v3 01/15] anv: anv_entrypoints_gen.py: use a main function

2017-02-24 Thread Dylan Baker
This is just good practice. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 458 - 1 file changed, 233 insertions(+), 225 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 93511ec

[Mesa-dev] [PATCH v3 09/15] anv: anv_entrypoints_gen.py: directly write files instead of piping

2017-02-24 Thread Dylan Baker
pdate Android.mk v3: - Don't generate both files at once - Fix Android.mk - drop --outdir, since the filename is passed in as an argument Signed-off-by: Dylan Baker --- src/intel/vulkan/Android.mk | 5 ++-- src/intel/vulkan/Makefile.am| 10 src/in

[Mesa-dev] [PATCH v3 00/15] cleanup anv_entrpoints_gen.py

2017-02-24 Thread Dylan Baker
ile via an argument - add flag to control output directory - Attempt to update android makefiles Notable changes in Version 3: - Fix "do not edit" message to have proper file name - More Android.mk changes - Don't write both files at the same time - Provide the file name to be wr

[Mesa-dev] [PATCH v3 08/15] anv: convert C generation to template in anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
This produces a file that is identical except for whitespace, there is a table that has 8 columns in the original and is easy to do with prints, but is ugly using mako, so it doesn't have columns; the data is not inherently tabular. Signed-off-by: Dylan Baker --- src/intel/v

[Mesa-dev] [PATCH v3 11/15] anv: anv_entrypoints_gen.py: use reduce function.

2017-02-24 Thread Dylan Baker
Reduce is it's own reward. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py index 8460bb5..7a5d0a7 100644

[Mesa-dev] [PATCH v3 07/15] anv: convert header generation in anv_entrypoints_gen.py to mako

2017-02-24 Thread Dylan Baker
This produces an identical file except for whitespace. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 77 ++ 1 file changed, 42 insertions(+), 35 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan

[Mesa-dev] [PATCH v3 13/15] anv: don't use Element.get in anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
is patch changes the behavior slightly by replacing get with explicit lookup in the Element.attrib dictionary, and using xpath to only iterate over extensions with a "protect" attribute. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 13 +++-- 1 fi

[Mesa-dev] [PATCH v3 05/15] anv: split main into two functions in anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
This is groundwork for the next patches, it will allows porting the header and the code to mako separately, and will also allow both to be run simultaneously. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 108 - 1 file changed, 56 insertions

[Mesa-dev] [PATCH v3 06/15] anv: Update "do not edit" comments with proper filename

2017-02-24 Thread Dylan Baker
This is to instruct python to print a literal '{' and '}' respectively, rather than treating the contents as a formatter specifier. v3: - add this patch Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 12 +++- 1 file changed, 7 insertions(+)

[Mesa-dev] [PATCH v3 14/15] anv: use cElementTree in anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
It's written in C rather than pure python and is strictly faster, the only reason not to use it that it's classes cannot be subclassed. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/in

[Mesa-dev] [PATCH v3 10/15] anv: anv-entrypoints_gen.py: rename hash to cal_hash.

2017-02-24 Thread Dylan Baker
hash is reserved name in python, it's the interface to access an object's hash protocol. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/in

[Mesa-dev] [PATCH v3 12/15] anv: use dict.get in anv_entrypoints_gen.py

2017-02-24 Thread Dylan Baker
Instead of using an if and a check, use dict.get, which does the same thing, but more succinctly. Signed-off-by: Dylan Baker --- src/intel/vulkan/anv_entrypoints_gen.py | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel

Re: [Mesa-dev] [PATCH 0/4] glsl/tests: completely broken or strange design ?

2017-02-24 Thread Dylan Baker
- Do we care about those tests ? > - Dylan any interest in giving it a stab ? Not particularly, but I'd be happy to review whatever you come up with ;) > > Thanks > Emil > > Cc: Dylan Baker > Cc: Kenneth Graunke > Cc: Matt Turner > > Emil Velikov (4): &

Re: [Mesa-dev] [PATCH v3 00/15] cleanup anv_entrpoints_gen.py

2017-02-27 Thread Dylan Baker
Quoting Emil Velikov (2017-02-26 10:26:24) > On 24 February 2017 at 18:21, Dylan Baker wrote: > > There are a number of small style cleanups and simplifications in this > > series, > > but the main changes are: > > - use a mako template to generate the header

Re: [Mesa-dev] [PATCH] android: vulkan: add support for libmesa_vulkan_{util, wsi}

2017-02-27 Thread Dylan Baker
gt; -(H_TEMPLATE, 'util/vk_enum_to_str.h')]: > +for template, file_ in [(C_TEMPLATE, > os.path.join(dst_dir,'vk_enum_to_str.c')), > + (H_TEMPLATE, > os.path.join(dst_di

Re: [Mesa-dev] [PATCH 5/8] i965: Add script to gen code for OA counter queries

2017-02-27 Thread Dylan Baker
I have some comments below, some of them are a bit of work, some of them should be pretty easy. Dylan Quoting Robert Bragg (2017-02-24 05:58:00) > --- /dev/null > +++ b/src/mesa/drivers/dri/i965/brw_oa.py > @@ -0,0 +1,543 @@ > +#!/usr/bin/env python2 > +# > +# Copyright (c) 2015 Intel Corporation

[Mesa-dev] [PATCH v2] mesa: Implement ARB_shader_viewport_layer_array for i965

2016-09-19 Thread Dylan Baker
st it on, I've left that for someone else to wire up. Signed-off-by: Dylan Baker Reviewed-by: Ilia Mirkin Reviewed-by: Kenneth Graunke --- v2: - changed messages to gen6+ instead of gen8+. - remove GLL from EXT list. docs/features.txt| 2 +- docs/relno

[Mesa-dev] [PATCH 0/3] Update libGLESv2.so to expose GLES 3.2 symbols

2016-09-22 Thread Dylan Baker
This adds the GLES 3.2 symbols to libGLESv2.so. The first two patches (which have all of the changes in them), do some basic cleanup. The first makes tabs consistent (this is the giant patch), and the second sorts the list alphabetically. Dylan Baker (3): mapi: retab static_data.py to be

[Mesa-dev] [PATCH 3/3] mapi: export all GLES 3.2 functions in libGLESv2.so

2016-09-22 Thread Dylan Baker
See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of this commit. Signed-off-by: Dylan Baker --- src/mapi/glapi/gen/static_data.py | 16 1 file changed, 16 insertions(+) diff --git a/src/mapi/glapi/gen/static_data.py b/src/mapi/glapi/gen/static_data.py

[Mesa-dev] [PATCH 1/3] mapi: retab static_data.py to be consistent

2016-09-22 Thread Dylan Baker
This file currently uses a mixture of 3 and 4 space indent. I have changed it all to 4 space indent, matching the settings in $ROOT/.editorconfig. Signed-off-by: Dylan Baker --- src/mapi/glapi/gen/static_data.py | 2570 ++--- 1 file changed, 1285 insertions

[Mesa-dev] [PATCH 2/3] mapi: sort static_data.py functions

2016-09-22 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/mapi/glapi/gen/static_data.py | 164 +++--- 1 file changed, 82 insertions(+), 82 deletions(-) diff --git a/src/mapi/glapi/gen/static_data.py b/src/mapi/glapi/gen/static_data.py index 396f941..bb11c1d 100644 --- a/src/mapi/glapi

Re: [Mesa-dev] [PATCH 3/3] mapi: export all GLES 3.2 functions in libGLESv2.so

2016-09-22 Thread Dylan Baker
Quoting Ilia Mirkin (2016-09-22 11:57:14) > 2016-09-22 14:53 GMT-04:00 Dylan Baker : > > See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of > > this commit. > > > > Signed-off-by: Dylan Baker > > --- > > src/mapi/glapi/gen/static_da

[Mesa-dev] [PATCH v2 1/3] mapi: retab static_data.py to be consistent

2016-09-22 Thread Dylan Baker
This file currently uses a mixture of 3 and 4 space indent. I have changed it all to 4 space indent, matching the settings in $ROOT/.editorconfig. Signed-off-by: Dylan Baker --- src/mapi/glapi/gen/static_data.py | 2570 ++--- 1 file changed, 1285 insertions

[Mesa-dev] [PATCH v2 2/3] mapi: sort static_data.py functions

2016-09-22 Thread Dylan Baker
Signed-off-by: Dylan Baker --- src/mapi/glapi/gen/static_data.py | 164 +++--- 1 file changed, 82 insertions(+), 82 deletions(-) diff --git a/src/mapi/glapi/gen/static_data.py b/src/mapi/glapi/gen/static_data.py index 396f941..bb11c1d 100644 --- a/src/mapi/glapi

[Mesa-dev] [PATCH v2 3/3] mapi: export all GLES 3.2 functions in libGLESv2.so

2016-09-22 Thread Dylan Baker
See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of this commit. Signed-off-by: Dylan Baker --- v2: - fix TexBufferRange typo (Ilia) - Remove duplicate TexParameterIuiv src/mapi/glapi/gen/static_data.py | 15 +++ 1 file changed, 15 insertions(+) diff --git

  1   2   3   4   5   6   7   8   9   10   >