Add support for XBGR2101010 and ABGR2101010 formats.
Signed-off-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index ed64ad61bf0..b7da65be27b 100644
--- a/src/gbm
Hi Eric,
On 8 February 2018 at 18:40, Eric Engestrom wrote:
> On February 8, 2018 2:06:23 PM UTC, Daniel Stone
> wrote:
>> When 0b2b7191214eb moved from an if tree to a struct to map between
>> wl_drm formats and EGLConfigs, it transposed the mapping between XRGB
>> and
Hi Emil,
On 8 February 2018 at 21:56, Emil Velikov wrote:
> On 8 February 2018 at 14:05, Daniel Stone wrote:
>> Extend the visual map from only containing names and bitmasks, to also
>> carrying the three format enums we need. These are the DRIImage format
>> tokens fo
Hi Carlos,
On 9 February 2018 at 08:33, Carlos Rafael Giani
wrote:
> I want to implement triple buffering instead of double buffering for a
> program that uses EGL on GBM on a KMS-enabled platform. So far, I used
> kmscube as an example.
>
> However, I do not see where I can specify that I want
Hi,
On 8 February 2018 at 22:47, Emil Velikov wrote:
> On 8 February 2018 at 14:05, Daniel Stone wrote:
>> When Ilia asked for suggestions on where to look to add 10bpc BGR
>> support to the GBM and Wayland EGL backends, I had a quick look; the
>> number of places the fo
Hi Carlos,
On 9 February 2018 at 18:26, Carlos Rafael Giani
wrote:
> thanks, I got it to work - almost. I am running this on the i.MX6 with
> etnaviv. I do get some flickering, however.
Flickering shouldn't be seen. It's possible that you're calling things
incorrectly, however.
For example:
/*
Hi Jason,
On 10 February 2018 at 06:50, Jason Ekstrand wrote:
> intel_from_planar(__DRIimage *parent, int plane, void *loaderPrivate)
> {
> int width, height, offset, stride, dri_format, index;
> -const struct intel_image_format *f;
> __DRIimage *image;
>
> -if (parent == NULL
Hi Eric,
On 10 February 2018 at 16:32, Eric Anholt wrote:
> The compiler doesn't know that num_visuals > 0.
Reviewed and pushed, thanks!
Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/list
Hi,
On 10 February 2018 at 06:50, Jason Ekstrand wrote:
> -} else if (parent->planar_format == NULL) {
> +
> +const struct intel_image_format *f = parent->planar_format;
> +const int nplanes = f ? f->nplanes : 1;
> +
> +if (plane > nplanes) {
> + if (parent->modifier == DRM_
Hi,
On 12 February 2018 at 17:16, Jason Ekstrand wrote:
> On Mon, Feb 12, 2018 at 6:36 AM, Daniel Stone wrote:
>> On further thought, I don't see how this could work at all. If we call
>> fromPlanar on plane 0 of a non-planar image with an aux plane, we need
>> to lan
up in the
planar_format == NULL case and the modifier was DRM_FORMAT_MOD_INVALID,
we would end up segfaulting in isl_drm_modifier_has_aux.
Cc: mesa-sta...@lists.freedesktop.org
Fixes: 8f6e54c92966bb94a3f05f2cc7ea804273e125ad
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965
Hi Jason,
This should be titled '... wsi_image', not '... wsi_image_base'.
On 9 February 2018 at 23:43, Jason Ekstrand wrote:
> diff --git a/src/vulkan/wsi/wsi_common_private.h
> b/src/vulkan/wsi/wsi_common_private.h
> index 503b2a0..c5002ec 100644
> --- a/src/vulkan/wsi/wsi_common_private.h
> +
ge_subresource, &image_layout);
> +
> + image->num_planes = 1;
> + image->sizes[0] = reqs.size;
> + image->row_pitches[0] = image_layout.rowPitch;
> + image->offsets[0] = 0;
assert(image_layout.offset == 0)
Unlikely since it's a dedicated-alloc image, but ... (or is this
already guaranteed and I can't read?)
The rest looks good to me though. Thanks very much for taking this on!
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi Jason,
On 9 February 2018 at 23:43, Jason Ekstrand wrote:
> - /* For images using modifiers, we require a dedicated allocation
> - * and we set the BO tiling to match the tiling of the underlying
> - * modifier. This is a bit unfortunate as this is completely
> -
Hi Jason,
On 9 February 2018 at 23:43, Jason Ekstrand wrote:
> +static void
> +get_wsi_format_modifier_properties_list(const struct anv_physical_device
> *physical_device,
> +VkFormat vk_format,
> +struct
> wsi_form
Hi,
On 13 February 2018 at 22:15, Jason Ekstrand wrote:
> On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote:
>> On 9 February 2018 at 23:43, Jason Ekstrand wrote:
>> For actual scanout, the kernel very specifically demands that if the
>> BO is X-tiled, then set_
Hi,
On 13 February 2018 at 22:29, Jason Ekstrand wrote:
> On Tue, Feb 13, 2018 at 10:55 AM, Daniel Stone wrote:
>> > + uint64_t modifiers[] = {
>> > + DRM_FORMAT_MOD_LINEAR,
>> > + I915_FORMAT_MOD_X_TILED,
>> > + I915_FORMAT_MOD_Y_TILED,
On 14 February 2018 at 11:39, Daniel Stone wrote:
> On 13 February 2018 at 22:15, Jason Ekstrand wrote:
>> On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone wrote:
>>> On 9 February 2018 at 23:43, Jason Ekstrand wrote:
>>> For actual scanout, the kernel very speci
On 14 February 2018 at 16:21, Jason Ekstrand wrote:
> On Wed, Feb 14, 2018 at 4:13 AM, Daniel Stone wrote:
>> Suggested fixup: https://hastebin.com/zaheyoriwa
>>
>> This makes sure we only try to allocate with modifiers when _both_
>> winsys and driver support
On 14 February 2018 at 16:27, Jason Ekstrand wrote:
> On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote:
>> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone
>> > wrote:
>> >> For actual scanout, the kernel very specifically demands that if the
>> >
On 14 February 2018 at 17:23, Jason Ekstrand wrote:
> On Wed, Feb 14, 2018 at 8:43 AM, Daniel Stone wrote:
>> Linear is unchanged as it's implicit. X tiling has to take the
>> workaround, in case anyone wants to display it.
>
> I'm not sure I buy that. Fr
On 14 February 2018 at 17:58, Jason Ekstrand wrote:
> I've added the following to the top of wsi_create_native_image:
>
> + /* If we don't support modifiers, the winsys code shouldn't be asking
> for
> +* an image with modifiers.
> +*/
> + assert(wsi->supports_modifiers || num_modifier
/series/31663/
[1]: https://cgit.freedesktop.org/wayland/wayland/commit/?id=9fa60983b579
Signed-off-by: Daniel Stone
Cc: Emil Velikov
Cc: mesa-sta...@lists.freedesktop.org
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=105103
---
src/egl/drivers/dri2/egl_dri2.h | 2 +-
1 file changed, 1 insertio
Hi Eric,
On 15 February 2018 at 11:17, Eric Engestrom wrote:
> Daniel, `w` seemed like the "least bad" thing to return in this case;
> would you prefer `0`?
I guess Coverity doesn't know it can never be invalid. We look up a
visual in the table using dri2_surf->format, whcih is only ever set
fro
height (!).
As the ISL aux surface is not recorded in the DRIimage, we cannot easily
access it to check. Instead, store the aux size from when we do have the
ISL surface to hand, and check against that later when we go to access
the aux surface.
Signed-off-by: Daniel Stone
Fixes: c2c4e5bae3ba
Hi Eric,
On 15 February 2018 at 15:11, Eric Engestrom wrote:
> v2: just tell the compiler to assume the format will always be found, as
> it comes from the table itself to begin with.
Thanks, assume() is a new one on me!
Cheers,
Daniel
___
mesa-dev ma
From: Jason Ekstrand
This adds support for the modifiers portion of the WSI "extension".
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/intel/vulkan/anv_formats.c | 38 ++
src/intel/vulkan/anv_imag
#x27;s clear in the driver when we're using
modifiers and when we're using legacy paths.
v2 (Jason Ekstrand):
- Rename legacy_scanout to needs_set_tiling
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/intel/vulkan/anv_device.c | 22 ++
src/intel/
Hi,
I don't actually know which revision we're up to by now, so I decided to
rebase at v10.
This is a slight evolution of Jason's 16-patch series posted on Feb 9th.
It adds:
- support for multi-plane buffers and modifiers to the Vulkan WSI
- support for zwp_linux_dmabuf_v1 to the Vulkan Waylan
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/egl/drivers/dri2/egl_dri2.c | 2 ++
src/egl/drivers/dri2/egl_dri2.h | 2 ++
src/egl/drivers/dri2/platform_x11_dri3.c | 3 +++
src/loader/loader_dri3_helper.c | 37
src
-Francis Ratté-Boulianne
Reviewed-by: Eric Engestrom
Reviewed-by: Emil Velikov
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/egl/drivers/dri2/egl_dri2.c | 7 +
src/egl/drivers/dri2/egl_dri2.h | 3 +
src/egl/drivers/dri2/platform_x11_dri3.c | 105
Adds support for multiple planes and buffer modifiers.
v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers"
Signed-off-by: Daniel Stone
---
src/vulkan/wsi/wsi_common_x11.c | 183
1 file changed, 166 insertions(+), 17 deletions(-)
dif
As the comment notes: linux-dmabuf has nothing to do with wayland-drm,
but we need a single place to build these files we can use from both EGL
and Vulkan, which is guaranteed to be included before both EGL and
Vulkan WSI.
Signed-off-by: Daniel Stone
Cc: Emil Velikov
---
src/egl/meson.build
ition all of the
structs used in wsi_common to the real extension structs.
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/vulkan/wsi/wsi_common.c | 164
src/vulkan/wsi/wsi_common.h | 23 +
src/vulkan/wsi/wsi_common_private.h
Not yet used anywhere.
Signed-off-by: Daniel Stone
Reviewed-by: Jason Ekstrand
---
src/vulkan/Makefile.am | 1 +
src/vulkan/wsi/meson.build | 2 +-
src/vulkan/wsi/wsi_common.c | 3 +++
src/vulkan/wsi/wsi_common_private.h | 1 +
4 files changed, 6 insertions(+), 1
Not currently used.
Signed-off-by: Daniel Stone
Reviewed-by: Jason Ekstrand
---
src/vulkan/wsi/wsi_common.c | 20
src/vulkan/wsi/wsi_common_private.h | 9 +
src/vulkan/wsi/wsi_common_wayland.c | 11 +++
src/vulkan/wsi/wsi_common_x11.c | 11
zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer
modifiers.
Signed-off-by: Daniel Stone
---
src/vulkan/Makefile.am | 10 +++
src/vulkan/Makefile.sources | 4 +-
src/vulkan/wsi/meson.build | 2 +
src/vulkan/wsi/wsi_common_wayland.c | 138
From: Louis-Francis Ratté-Boulianne
When it is detected that a window could have been flipped
but has been copied because of suboptimal format/modifier.
The Vulkan client should then re-create the swapchain.
Signed-off-by: Louis-Francis Ratté-Boulianne
Reviewed-by: Daniel Stone
Signed-off-by
Hi Michel,
On 15 February 2018 at 16:14, Michel Dänzer wrote:
> On 2018-02-15 04:57 PM, Daniel Stone wrote:
>> @@ -885,6 +901,11 @@ loader_dri3_swap_buffers_msc(struct
>> loader_dri3_drawable *draw,
>>if (!loader_dri3_have_image_blit(draw) &&
height (!).
As the ISL aux surface is not recorded in the DRIimage, we cannot easily
access it to check. Instead, store the aux size from when we do have the
ISL surface to hand, and check against that later when we go to access
the aux surface.
Signed-off-by: Daniel Stone
Fixes: c2c4e5bae3ba
Hi,
On 15 February 2018 at 19:46, Jason Ekstrand wrote:
> On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote:
>> + image_modifier_count = 0;
>> + for (uint32_t l = 0; l < num_modifier_lists; l++) {
>> + /* Walk the modifier lists and const
On 15 February 2018 at 21:38, Jason Ekstrand wrote:
> On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote:
>> @@ -138,7 +140,7 @@ wsi_x11_connection_create(const VkAllocationCallbacks
>> *alloc,
>>return NULL;
>>
>> dri3_cookie = x
Hi,
On 15 February 2018 at 22:44, Jason Ekstrand wrote:
> On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote:
>> + draw->ext->image->queryDmaBufModifiers(draw->dri_screen, format,
>> +
Hi Ilia,
On 10 February 2018 at 01:49, Ilia Mirkin wrote:
> The GBM surface format has to match the DRM mode. Both are used in a
> couple of places, so unify it so that it's only set in one place. Note
> that the GBM and DRM formats are identical.
Pushed this one to master with review, thanks fo
On 16 February 2018 at 13:56, Emil Velikov wrote:
> On 15 February 2018 at 13:13, Emil Velikov wrote:
>> On 15 February 2018 at 09:23, Daniel Stone wrote:
>>> A recent patchset to Wayland[0] migrated Mesa's libwayland-egl backend
>>> into Wayland itself,
Hi Emil,
On 15 February 2017 at 12:23, Emil Velikov wrote:
> On 13 February 2017 at 17:54, Daniel Stone wrote:
>>> From a quick look shm_handle_format() comes to mind. Keep in mind that
>>> I'm not that big of an expert on the Wayland code so I might have
>>
Hey Kristian,
On 13 March 2017 at 17:31, Kristian H. Kristensen wrote:
> Jason Ekstrand writes:
>> I was talking to Daniel today and I think we also need another some sort of
>> GL or GBM api that gives you the modifiers supported for
>> rendering/texturing. One option would be a gbm_get_modifi
Hi,
On Mon, 13 Mar 2017 at 7:08 pm, Jason Ekstrand wrote:
> On Mon, Mar 13, 2017 at 11:53 AM, Kristian H. Kristensen <
> k...@bitplanet.net> wrote:
>
> Daniel Stone writes:
>
> > I guess it depends on how much asymmetry there is between texture and
> > rende
Hi Adrian,
Thanks for the patch! Some comments inline.
On 22 March 2017 at 13:40, Adrian Pielech wrote:
> +struct list_head window_list = {NULL, NULL};
> +
> +/* Checks if a EGLWindow already have a created surface */
> +static inline bool
> +is_window_associated_with_surface(EGLNativeWindowType
Hi,
On 8 March 2017 at 05:31, Ben Widawsky wrote:
> Unlike stride, there was no previous offset getter, so it can be right
> on the first try.
>
> v2: Return EINVAL when plane is greater than total planes to make it
> match the similar APIs.
> Avoid leak after fromPlanar (Daniel)
> Make sure when
Hi Ben,
On 24 January 2017 at 06:21, Ben Widawsky wrote:
> @@ -1018,9 +1018,18 @@ intel_from_planar(__DRIimage *parent, int plane, void
> *loaderPrivate)
> int width, height, offset, stride, dri_format, index;
> struct intel_image_format *f;
> __DRIimage *image;
> -
> -if (par
Hi,
On 23 March 2017 at 14:47, Jason Ekstrand wrote:
> On Thu, Mar 23, 2017 at 6:16 AM, Daniel Stone wrote:
>> Returning int64_t is annoying because the relevant interface demands
>> we need uint32_t, so we need to do casts in users. Given that the
>> offset is useless
. This means that
returning 0 as an error value is harmless, allowing us to change the
return type to uint32_t in order to avoid signed/unsigned confusion in
callers.
Signed-off-by: Daniel Stone
Cc: Ben Widawsky
Cc: Jason Ekstrand
---
src/gbm/backends/dri/gbm_dri.c | 18 +-
src/gbm
Hi,
On 23 March 2017 at 15:24, Jason Ekstrand wrote:
> Reviewed-by: Jason Ekstrand
>
> Please land soon so the old API can exist for as short a time as possible.
> :-)
Landed with such haste that I forgot to change the two of your Cc tags
to R-b. :( Sorry. At least that API unexists now.
To ss
Hi Emil,
On 19 August 2017 at 00:57, Emil Velikov wrote:
> On 11 August 2017 at 11:18, Daniel Stone wrote:
>> On 31 July 2017 at 15:15, Daniel Stone wrote:
>>> Make sure we advertise the new entrypoints to libglvnd's EGL dispatch.
>>
>> Anyone?
>>
Hi Emil,
On 21 August 2017 at 15:18, Emil Velikov wrote:
> On 11 July 2017 at 14:27, Emil Velikov wrote:
>> According to the EGL_KHR_platform_gbm extension:
>>
>> For each EGLConfig that belongs to the GBM platform, the
>> EGL_NATIVE_VISUAL_ID attribute is a GBM color format, such as
>>
Hi,
On 21 August 2017 at 18:30, Emil Velikov wrote:
> On 21 August 2017 at 15:44, Daniel Stone wrote:
>> My take on it is that the visual types are defined by the platform,
>> and 0 is a perfectly sensible visual type for a platform which does
>> not actually have any.
Hi Emil,
On 27 August 2017 at 11:20, Emil Velikov wrote:
> egl: simplify refcounting after screen creation
Acked-by: Daniel Stone
> egl/wayland: plug leaks in dri2_wl_create_window_surface() error path
> egl/wayland: polish object teardown in dri2_wl_destroy_surface
Reviewed-b
On 16 August 2017 at 20:30, Jason Ekstrand wrote:
> + /**
> +* dmabuf format modifier attribute query for a given format and modifier.
> +*
> +* \param fourccThe format to query. If this format is not supported
> by
> +* the driver, return false.
> +* \p
On 16 August 2017 at 20:30, Jason Ekstrand wrote:
> +/** Get the number of planes that are required for a given format+modifier
> + *
> + * \param gbm The gbm device returned from gbm_create_device()
> + * \param format The format to query
> + * \param modifier The modifier to query
> + */
> +int
On 16 August 2017 at 20:30, Jason Ekstrand wrote:
> This gets rid of some compiler warnings.
Reviewed-by: Daniel Stone
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi Emil,
On 29 August 2017 at 11:28, Emil Velikov wrote:
> On 28 August 2017 at 14:50, Daniel Stone wrote:
>>> egl/wayland: plug leaks in dri2_wl_create_window_surface() error path
>>> egl/wayland: polish object teardown in dri2_wl_destroy_surface
>>
&
On 12 September 2017 at 11:11, Tapani Pälli wrote:
> Fixes: d083bc1c4b ("anv: wire up vk_errorf macro to do debug reporting")
> Signed-off-by: Tapani Pälli
Reviewed-by: Daniel Stone
___
mesa-dev mailing list
mesa-dev@lists.freed
rs interact.
So, I've gone through the code and it all makes sense to me. It does
also fix corruption with GLX/BindTexImage compositing managers when
CCS is being used. But without any insight into why the original
codepath is the way it is, the best
On 5 September 2017 at 16:48, Jason Ekstrand wrote:
> +/** Get the number of planes that are required for a given format+modifier
> + *
> + * \param gbm The gbm device returned from gbm_create_device()
> + * \param format The format to query
> + * \param modifier The modifier to query
> + */
> +in
ith the GBM_EXPORT fix, series is:
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
urce_instance_of() call into
wl_resource_get_destroy_listener() would be far more foolproof, but it
doesn't remove the need for linkage.
That being said, all other patches in the series are:
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
mesa-dev
On Tue, 16 Oct 2018 at 08:17, Peter Hutterer wrote:
> On Mon, Oct 15, 2018 at 10:49:24AM -0400, Harry Wentland wrote:
> > + \item Support free and open source projects through the
> > freedesktop.org
> > + infrastructure. For projects outside the scope of item (\ref{1})
> > support
> > +
Hi,
On Fri, 26 Oct 2018 at 11:57, Daniel Vetter wrote:
> On Fri, Oct 26, 2018 at 10:13:51AM +1000, Peter Hutterer wrote:
> > On Wed, Oct 17, 2018 at 02:37:25PM +0200, Daniel Vetter wrote:
> > > On Wed, Oct 17, 2018 at 2:05 PM Daniel Stone wrote:
> > > > Yeah, I thi
If the client has requested that AcquireNextImage not block at all, with
a timeout of 0, then don't make any non-blocking calls.
This will still potentially block infinitely given a non-infinte
timeout, but the fix for that is much more involved.
Signed-off-by: Daniel Stone
Cc: mes
olves removing a 'see
also' for gbm_bo_format, since we can't also use \sa to refer to a
family of anonymous #defines.
Signed-off-by: Daniel Stone
Reported-by: Pekka Paalanen
---
src/gbm/main/gbm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gbm/main/
On Fri, 2 Nov 2018 at 15:58, Emil Velikov wrote:
> Ff| 2 ++
> docs/relnotes/19.0.0.html | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
> create mode 100644 Ff
>
> diff --git a/Ff b/Ff
> new file mode 100644
> index 000..804e31ab99e
> --- /dev/null
> ++
Hi,
On Tue, 6 Nov 2018 at 13:11, Eric Engestrom wrote:
> On Friday, 2018-11-02 14:40:49 -0700, Eric Anholt wrote:
> > +GBM_EXPORT char *
> > +gbm_format_get_name(uint32_t gbm_format, struct gbm_format_name_desc *desc)
> > +{
>
> Actually, This won't work with the two GBM_BO_FORMAT_{X,A}RGB; y
at R8
> libEGL debug: No DRI config supports native format GR88
>
> is a lot easier to understand.
Series is:
Reviewed-by: Daniel Stone
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi Emil,
On Thu, 8 Nov 2018 at 15:26, Emil Velikov wrote:
> On Tue, 30 Oct 2018 at 12:57, Daniel Stone wrote:
> > If the client has requested that AcquireNextImage not block at all, with
> > a timeout of 0, then don't make any non-blocking calls.
> >
> > T
r usage. Due to currently
> only out of tree lima driver need it, and not sure if this is
> the right way to disable it, so I send this RFC before lima be
> able to upstream.
Series is:
Acked-by: Daniel Stone
Cheers,
Daniel
___
mesa-d
der_buffer() to return NULL and breaks
> rendering when using GLX_DOUBLEBUFFER on pixmaps.
>
> Query the root window of the pixmap on first init, and use the root
> window instead of the pixmap drawable for get_supported_modifiers()
> and pixmap_from_buffers().
Looks good to me, thanks
Hi Juan,
On Tue, 5 Jun 2018 at 18:23, Juan A. Suarez Romero wrote:
> On Tue, 2018-06-05 at 12:41 +0100, Daniel Stone wrote:
> > > - In Wayland/Mesa, the surface is not resized at the time the native
> > > window is
> > > resized; this is done in *eglSw
(causing all buffers to be released) by the
time they destroy their EGLSurface, but that's of course never going
to happen. So, assuming there's no unexpected consequences I haven't
seen, this is:
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
tely,
> and if user calls eglQuerySurface() it will return the new resized
> values.
I'm pretty confident that these two patches do the right thing; series is:
Reviewed-by: Daniel Stone
Thanks a lot for your patience & persistence!
Cheers,
Daniel
_
e), and create the
> image.
You can eke out a little bit of a speed improvement by using the
go-faster runes from before 'apt-get update' here:
https://gitlab.freedesktop.org/wayland/weston/blob/master/.gitlab-ci.yml#L6
Anyway, this all looks great, and I'm really excited to
Hi Juan,
On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero wrote:
> On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote:
> > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero
> > wrote:
> > > If color buffer is locked, do not set its wayland buffer to NULL;
>
d any new
ones. So, series is:
Acked-by: Daniel Stone
Cheers,
Daniel
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, 15 Mar 2021 at 20:54, Jason Ekstrand wrote:
> Three comments:
>
> 1. +1
> 2. Khronos has generally standardized on American English in their
> specs so I guess that provides some sort of prior art or something.
> 3. I'd generally be a fan of encouraging American spellings in common
> c
On Tue, 16 Mar 2021 at 13:08, Jason Ekstrand wrote:
> On March 16, 2021 05:06:53 Daniel Stone wrote:
>
>> On Mon, 15 Mar 2021 at 20:54, Jason Ekstrand
>> wrote:
>>
>>> Three comments:
>>>
>>> 1. +1
>>> 2. Khronos has generally st
On Tue, 30 Mar 2021 at 01:34, Ilia Mirkin wrote:
> https://cgit.freedesktop.org/piglit
>
> This still displays the "master" branch by default. I think you're
> supposed to change ... something ... in the repo, which indicates
> which is the default branch.
>
*jedi handwave* no it doesn't
> On
Hi Marek,
On Mon, 19 Apr 2021 at 11:48, Marek Olšák wrote:
> *2. Explicit synchronization for window systems and modesetting*
>
> The producer is an application and the consumer is a compositor or a
> modesetting driver.
>
> *2.1. The Present request*
>
So the 'present request' is an ioctl, rig
Hi,
On Tue, 20 Apr 2021 at 13:01, Daniel Vetter wrote:
> - We live in a post xf86-video-$vendor world, and all these other
> compositors rely on implicit sync. You're not going to be able to get
> rid of them anytime soon. What's worse, all the various EGL/vk buffer
> sharing things also r
Hi,
On Mon, 19 Apr 2021 at 11:48, Marek Olšák wrote:
> Deadlock mitigation to recover from segfaults:
> - The kernel knows which process is obliged to signal which fence. This
> information is part of the Present request and supplied by userspace.
> - If the producer crashes, the kernel signals
On Tue, 20 Apr 2021 at 15:58, Christian König <
ckoenig.leichtzumer...@gmail.com> wrote:
> Am 20.04.21 um 16:53 schrieb Daniel Stone:
>
> On Mon, 19 Apr 2021 at 11:48, Marek Olšák wrote:
>
>> Deadlock mitigation to recover from segfaults:
>> - The kernel knows whic
Hi,
On Tue, 20 Apr 2021 at 16:16, Christian König <
ckoenig.leichtzumer...@gmail.com> wrote:
> Am 20.04.21 um 17:07 schrieb Daniel Stone:
>
> If the compositor no longer has a guarantee that the buffer will be ready
> for composition in a reasonable amount of time (which
Hi,
On Tue, 20 Apr 2021 at 16:46, Jason Ekstrand wrote:
> It's still early in the morning here and I'm not awake yet so sorry if
> this comes out in bits and pieces...
>
No problem, it's helpful. If I weren't on this thread I'd be attempting to
put together a 73-piece chest of drawers whose ins
On Tue, 20 Apr 2021 at 17:25, Marek Olšák wrote:
> Daniel, imagine hardware that can only do what Windows does: future fences
> signalled by userspace whenever userspace wants, and no kernel queues like
> we have today.
>
> The only reason why current AMD GPUs work is because they have a ring
> b
On Tue, 20 Apr 2021 at 19:00, Christian König <
ckoenig.leichtzumer...@gmail.com> wrote:
> Am 20.04.21 um 19:44 schrieb Daniel Stone:
>
> But winsys is something _completely_ different. Yes, you're using the GPU
> to do things with buffers A, B, and C to produce buffer
Hi,
On Tue, 20 Apr 2021 at 19:54, Daniel Vetter wrote:
> So I can mostly get behind this, except it's _not_ going to be
> dma_fence. That thing has horrendous internal ordering constraints
> within the kernel, and the one thing that doesn't allow you is to make
> a dma_fence depend upon a usersp
Hi,
On Tue, 20 Apr 2021 at 20:03, Bas Nieuwenhuizen
wrote:
> On Tue, Apr 20, 2021 at 8:16 PM Daniel Stone wrote:
>
>> It's a jarring transition. If you take a very narrow view and say 'it's
>> all GPU work in shared buffers so it should all work the same&#x
Hi,
On Tue, 20 Apr 2021 at 20:30, Daniel Vetter wrote:
> The thing is, you can't do this in drm/scheduler. At least not without
> splitting up the dma_fence in the kernel into separate memory fences
> and sync fences
I'm starting to think this thread needs its own glossary ...
I propose we us
Hi,
On Fri, 30 Apr 2021 at 10:35, Daniel Vetter wrote:
> On Fri, Apr 30, 2021 at 11:08 AM Christian König
> wrote:
> > This doesn't work in hardware. We at least need to setup a few registers
> > and memory locations from inside the VM which userspace shouldn't have
> > access to when we want th
Hi,
On Tue, 1 Jun 2021 at 14:18, Michel Dänzer wrote:
> On 2021-06-01 2:10 p.m., Christian König wrote:
> > Am 01.06.21 um 12:49 schrieb Michel Dänzer:
> >> There isn't a choice for Wayland compositors in general, since there can
> >> be arbitrary other state which needs to be applied atomically
Hi Christian,
On Tue, 1 Jun 2021 at 13:51, Christian König
wrote:
> Am 01.06.21 um 14:30 schrieb Daniel Vetter:
> > If you want to enable this use-case with driver magic and without the
> > compositor being aware of what's going on, the solution is EGLStreams.
> > Not sure we want to go there, bu
601 - 700 of 802 matches
Mail list logo
