Hi,
On 25 February 2016 at 01:47, Emil Velikov wrote:
> On 24 February 2016 at 18:56, Rob Herring wrote:
>> AOSP master branch has switched to clang from gcc and has major build
>> system changes moving away from GNU make.
>
> Out of curiosity: what are they moving to ? I can see "blueprint"
> (
Hi Lucas,
On 4 March 2016 at 13:49, Lucas Stach wrote:
> this is a first shot at trying to hash out an API to allow bootstrapping
> an EGL context on top of split render/scanout DRM devices. It tries to make
> things really easy for applications, while leaving them in full control over
> swap/fli
Hi,
On 4 March 2016 at 16:08, Lucas Stach wrote:
> Am Freitag, den 04.03.2016, 15:09 + schrieb Daniel Stone:
>> Thanks for taking this on, it looks really good! I just have the one
>> question though - did you look at the EGLDevice extension? Using that
>> to enumera
Hi,
On 7 March 2016 at 10:19, Thierry Reding wrote:
> On Mon, Mar 07, 2016 at 10:46:52AM +0100, Lucas Stach wrote:
>> Am Freitag, den 04.03.2016, 18:34 + schrieb Emil Velikov:
>> > While I'm more inclined to Daniel's suggestion, I wonder why people
>> > moved away from Thierry's approach - cr
Hi,
On 7 March 2016 at 20:45, Emil Velikov wrote:
> On 7 March 2016 at 10:35, Daniel Stone wrote:
>> On 7 March 2016 at 10:19, Thierry Reding wrote:
>>> On Mon, Mar 07, 2016 at 10:46:52AM +0100, Lucas Stach wrote:
>>>> The wrapped driver takes away the abilit
Hey Emil,
On 8 March 2016 at 17:04, Emil Velikov wrote:
> Summarising and stating some unsaid assumptions.
>
> Assumptions:
> - The proposed solution is a replacement of the wrapped drivers
> approach. No, it's meant to introduce an API mostly gears towards
> DRI_PRIME setups.
> - Wrapped drive
Hi,
On 9 March 2016 at 02:57, Michel Dänzer wrote:
> On 08.03.2016 20:36, Daniel Stone wrote:
>> Taking the approach I suggested would allow us to solve multi-GPU
>> with the same approach, whereas with the wrapper driver ... who
>> volunteers to write the Radeon+Int
Hi,
On 29 March 2016 at 15:44, Rob Clark wrote:
> On Tue, Mar 29, 2016 at 10:30 AM, Rob Herring wrote:
>> On Tue, Mar 29, 2016 at 8:43 AM, Rob Clark wrote:
>>> On Mon, Mar 28, 2016 at 12:29 PM, Rob Herring wrote:
However, I found a bigger mismatch is there are no explicit map/unmap
c
Hey,
On 29 March 2016 at 19:06, Rob Clark wrote:
> On Tue, Mar 29, 2016 at 1:51 PM, Daniel Stone wrote:
>> Yep, you got it right: in the original intention, the only mappable
>> GBM BOs were cursor BOs. This is mostly because we lacked modifiers,
>> so it was assumed th
Hi,
On 29 August 2014 08:46, Gwenole Beauchesne wrote:
> Could you please describe in there the ownership model? I think the
> implementation should own the fd, so the clients should dup() it if
> ever necessary.
>
So the fd can be destroyed at any time, particularly with threads? Meaning
that
Reviewed-by: Daniel Stone
On 16 September 2014 22:23, Emil Velikov wrote:
> Hello gents,
>
> Can anyone spare a couple of minutes and review this patch ?
>
> Thanks
> Emil
>
> On 03/09/14 21:43, Andreas Pokorny wrote:
> > This changes enables EGL_KHR_image_pixmap
Reviewed-by: Daniel Stone
On 16 September 2014 22:29, Emil Velikov wrote:
> Another humble ping.
>
> I realise that i915 hardware is not top priority yet 5 minutes of someone
> experienced with the driver will be greatly appreciated :)
>
> Cheers,
> Emil
>
> On 0
Hi Emil,
On 18 May 2017 at 17:22, Emil Velikov wrote:
> On 16 May 2017 at 11:02, Daniel Stone wrote:
>> Ideally get_back_bo() failing should store a failure flag inside the
>> surface and cause the next SwapBuffers to fail, but for the meantime,
>> restore the correc
Hi Lionel,
On 19 May 2017 at 02:31, Lionel Landwerlin
wrote:
> Thanks for doing this.
> Although you seem to have a multithreaded scenario in mind, this will
> probably help single threaded stacks like Clutter/Cogl & Mesa all using the
> same event queue.
Right you are. Thanks a lot for the revi
just makes
having an aux offset possible.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_image.h | 3 +++
src/mesa/drivers/dri/i965/intel_screen.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/src/mesa/drivers/dri
Widawsky
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8
1 file changed, 8 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
index e175f990bf..19c5fca4a0 100644
--- a/src/mesa/drivers
Hi,
This series is an amalgamation of two series: Varad's
EGL_EXT_image_dma_buf_import_modifiers support (last seen at v3), and
Ben's i915 CCS support (last seen at v12). I've fairly heavily rebased
them, fixed up the Intel paths, and Varad had also fixed up the
Gallium/pipe parts from Lucas's revi
rrect fourcc format from DRIimage queries, and
simplifies the multiplane import logic.
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/gallium/state_trackers/dri/dri2.c | 288 +++-
src/gallium/state_trackers/dri/dri_screen.h | 13 ++
2 files changed
From: Pekka Paalanen
Rather than hardcoding 3, use a #define. Makes it easier to bump this
later to 4.
Signed-off-by: Pekka Paalanen
Signed-off-by: Varad Gautam
Reviewed-by: Eric Engestrom
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/egl/drivers/dri2/egl_dri2.c | 8
)
Signed-off-by: Pekka Paalanen
Signed-off-by: Varad Gautam
Reviewed-by: Eric Engestrom
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/egl/drivers/dri2/egl_dri2.c | 2 +-
src/egl/main/egldisplay.h | 1 +
src/egl/main/eglimage.c | 18 ++
src/egl/main
MiB/s
v2: Move all references to the new fourcc code(s) to this patch.
v3: Rebase, remove Yf_CCS (Daniel)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 9 +
1 file changed, 9 inser
From: Varad Gautam
support importing dmabufs into DRIimage while taking format modifiers
in account, as per DRIimage extension version 15.
bump __DRIimageExtension to 15.
v2: initialize winsys modifier to DRM_FORMAT_MOD_INVALID (Daniel Stone)
Signed-off-by: Varad Gautam
Signed-off-by: Daniel
From: Varad Gautam
v2: Rebase and reuse tiling/modifier map. (Daniel Stone)
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 59 +---
1 file changed, 54 insertions(+), 5 deletions(-)
diff --git a/src/mesa
this to a
tiling mode.
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 35
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 69c450a431
able since mt
allocation should work correctly now.
Unref the BO is miptree creation fails (Jason)
v3: Rebase (Daniel)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_context.c | 31 ++
From: Varad Gautam
Signed-off-by: Varad Gautam
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/egl/drivers/dri2/egl_dri2.c | 6 ++
src/egl/main/eglapi.c | 1 +
2 files changed, 7 insertions(+)
diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2
From: Varad Gautam
allow egl clients to query the dmabuf formats supported on this platform.
v2: return EGLBoolean.
v3: Check DRIimageExtension version before querying (Daniel Stone)
Signed-off-by: Louis-Francis Ratté-Boulianne
Signed-off-by: Varad Gautam
Reviewed-by: Daniel Stone
Signed
ely
Cc: Topi Pohjolainen
Cc: Chad Versace
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mes
o have the
CCS_MODIFIER token saved for the last patch, this patch now does less so
it was renamed.
v2: Leave "image+mod" (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965
From: Varad Gautam
introduce modifier field in DRIimage and set it to
DRM_FORMAT_MOD_INVALID for now. support DRIimage modifier
queries.
Suggested-by: Daniel Stone
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/gallium/state_trackers/dri/dri2.c | 15
From: Ben Widawsky
Upper layers of the code will have the need to specify full or partial
resolves (more on this in the next patch). This code simply adds the new
enums and plumbs it in as minimally as necessary.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
From: Ben Widawsky
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++-
src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4
buffer
is the same.
Since there is nothing we can do to detect this properly, just remove
the test for now.
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa
From: Varad Gautam
ask the driver for supported dmabuf formats
v2: rebase to master.
v3: return false on failure.
v4: use pscreen->is_format_supported instead of adding a new query.
(Lucas Stach)
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/gallium/state_trackers/
t;
Signed-off-by: Ben Widawsky
Topi's changes
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_context.c | 3 +++
src/mesa/drivers/dri/i965/intel_fbo.h | 7 +++
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 22 +-
3 files changed, 23 i
-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_fbo.c | 17 -
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 25 -
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 10 ++
src/mesa/drivers/dri/i965
d-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen (v2)
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_context.c | 16 ++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2
exit from intel_miptree_make_shareable() when it's
scanout.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen (v1)
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_context.c | 3 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 9 +++
Make setting the hint more concise (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_blorp.c | 8
src/mesa/drivers/dri/i965/brw_context.c | 13 +++--
src/mesa/dr
zero as valid modifier (Daniel Stone)
- ensure same modifier across all dmabuf planes (Emil Velikov)
v4:
- allow modifiers to add extra planes (Louis-Francis Ratté-Boulianne)
Signed-off-by: Pekka Paalanen
Signed-off-by: Varad Gautam
Signed-off-by: Louis-Francis Ratté-Boulianne
Reviewed-by: Eric
From: Varad Gautam
these allow querying the driver for supported dmabuf formats and
modifiers.
v2: move to __DRIimageExtension version 16.
v3: return GLBoolean for error reporting, document params better.
Signed-off-by: Varad Gautam
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
From: Varad Gautam
query and return supported dmabuf format modifiers for
EGL_EXT_image_dma_buf_import_modifiers.
v2: move format check to the driver instead of making format queries
here and then checking.
v3: Check DRIimageExtension version before query (Daniel Stone)
Signed-off-by
From: Ben Widawsky
v2: move is_aux into if block. (Jason)
Use else block instead of goto (Jason)
v3: Fix up logic for is_aux (Ben)
Fix up size calculations and add FIXME (Ben)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa
pscreen->is_format_supported instead of adding a separate
format query handle, remove PIPE_CAP_QUERY_DMABUF_ATTRIBS.
(Lucas Stach)
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/gallium/include/pipe/p_screen.h | 10 ++
1 file changed, 10 insertions(+)
diff --
When importing a dmabuf, verify that the tiling mode matches what was
expected.
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_bufmgr.c | 12 ++--
src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 ++-
src/mesa/drivers/dri/i965/intel_screen.c | 5 +++--
3 files changed, 15
From: Varad Gautam
adds a pscreen->resource_create_with_modifiers() to create textures
with modifier.
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/gallium/include/pipe/p_screen.h | 18
src/gallium/state_trackers/dri/dri2.c |
does
something incorrectly.
v2: Do proper alignment for X tiling, and make sure non-tiled case is
handled (Jason)
v3: Rebase (Daniel)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c
: Daniel Stone
---
src/gallium/state_trackers/dri/dri2.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/dri/dri2.c
b/src/gallium/state_trackers/dri/dri2.c
index 814a08e3cb..36cd235b3c 100644
--- a/src/gallium/state_trackers/dri
From: Varad Gautam
Add support for createImageFromDmaBufs2, adding a modifier to the
original.
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 ++
src/mesa/drivers/dri/i965/intel_screen.c | 116 +++---
2
ove bogus is_scanout check in miptree_release
v3:
Remove is_scanout assert in intel_miptree_create. It doesn't work with
latest codebase - not sure it ever should have worked.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
From: Pekka Paalanen
add createImageFromDmaBufs2 function which accepts per-plane dmabuf
format modifiers.
Signed-off-by: Pekka Paalanen
Signed-off-by: Varad Gautam
Reviewed-by: Daniel Stone
Signed-off-by: Daniel Stone
---
include/GL/internal/dri_interface.h | 21 -
1
Hi Philipp,
On 19 May 2017 at 23:07, Philipp Zabel wrote:
> Before the swapchain event queue is destroyed, all proxy objects that
> reference
> it must be dropped. Otherwise we risk a use-after-free if a frame callback
> event
> or buffer release events are received afterwards.
> This happens w
Hi Gregory,
On 21 May 2017 at 15:59, Gregory Hainaut wrote:
> +static GLboolean
> +dri_is_thread_safe(void *loaderPrivate)
> +{
> +#ifdef HAVE_X11_PLATFORM
> + struct dri2_egl_surface *dri2_surf = loaderPrivate;
> + _EGLDisplay *display = dri2_surf->base.Resource.Display;
Move these out of
Hi Lucas,
On 22 May 2017 at 11:53, Lucas Stach wrote:
> Am Dienstag, den 02.05.2017, 16:35 +0200 schrieb Lucas Stach:
>> Mostly to pull in the Vivante tiling format modifiers, but some other
>> little changes included.
>
> If there are no objections to this patch, I'm going to push it today.
The
On 22 May 2017 at 11:07, Lionel Landwerlin
wrote:
> We're already verified that 'window' wasn't NULL, I'm guess this
> allocation error is about the newly created queue.
Reviewed-by: Daniel Stone
___
Hey,
On 22 May 2017 at 13:43, Emil Velikov wrote:
> On 19 May 2017 at 10:37, Daniel Stone wrote:
>> The EGL_EXT_dma_buf_import_modifiers extension adds support for a
>> fourth plane, just like DRM KMS API does.
>>
>> Bump maximum dma_buf plane count to four.
>
>
Hi Varad,
On 23 May 2017 at 14:19, Varad Gautam wrote:
> On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote:
>> On 19 May 2017 at 10:37, Daniel Stone wrote:
>> > + if (external_only != NULL) {
>> > + for (i = 0; i < *count && i < max; i++)
&
Hi Jussi,
On 26 May 2017 at 14:55, Jussi Kukkonen wrote:
> On 26 May 2017 at 14:32, Emil Velikov wrote:
>> b) with a wrapper script - see [1].
>> I think that the "export PKG_CONFIG_DIR=" is a typo (should be ..PATH
>> instead) and is not strictly required - feel free to check either way.
>> Not
Hi,
On 5 June 2017 at 09:30, Tapani Pälli wrote:
> Android does not support pixmaps, so this should be set to false there. I
> think otherwise this should be fine.
Wayland, GBM and surfaceless also don't support pixmaps, so I'd
probably lean towards just dropping this patch.
Cheers,
Daniel
Hi,
Getting back to this after holidays ...
On 19 May 2017 at 19:26, Jason Ekstrand wrote:
> On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote:
>>
>> Intel hardware requires that all planes of an image come from the same
>> buffer, which is currently implemented by tes
Hi Varad,
On 30 May 2017 at 12:53, Varad Gautam wrote:
> + /* We only support all planes from the same bo.
> +* brw_bo_gem_create_from_prime() should return the same pointer for all
> +* fds received here */
> + bo = brw_bo_gem_create_from_prime(screen->bufmgr, fds[0], size);
> + fo
Hi Varad,
On 5 June 2017 at 15:13, Varad Gautam wrote:
> On Mon, 2017-06-05 at 14:53 +0100, Daniel Stone wrote:
>> This above takes a ref, which gets leaked.
>>
>>struct brw_bo *aux =
>> brw_bo_gem_create_from_prime(screen->bufmgr, fds[i], size);
>&g
buffer
is the same.
Instead of checking the FDs for equality, we must check if they actually
point to the same buffer (Jason).
Signed-off-by: Daniel Stone
Signed-off-by: Varad Gautam
---
src/mesa/drivers/dri/i965/intel_screen.c | 18 +-
1 file changed, 13 insertions(+), 5
From: Varad Gautam
v2: Rebase and reuse tiling/modifier map. (Daniel Stone)
v3: bump DRIimageExtension to version 15, fill external_only array.
Signed-off-by: Varad Gautam
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 76 ++--
1 file
does
something incorrectly.
v2: Do proper alignment for X tiling, and make sure non-tiled case is
handled (Jason)
v3: Rebase (Daniel)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c
Since the EGL attributes are signed integers, a straight OR would
also perform sign extension,
Fixes: 6f10e7c37a ("egl/dri2: Create EGLImages with dmabuf modifiers")
Cc: Varad Gautam
Signed-off-by: Daniel Stone
---
src/egl/drivers/dri2/egl_dri2.c | 5 ++---
1 file changed, 2 insert
this to a
tiling mode.
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 35
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 22f6d9af03
-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 94 ++--
1 file changed, 76 insertions(+), 18 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 05ac784fa6..e7d2af7852 100644
--- a
Hi,
With the initial modifier enablement patches being merged, and Jason's
comments about doing a lot of work in the vicinity of CCS with blorp/ISL,
I'm cleaving this patch series into 3.
Varad is taking over the Gallium/Freedreno parts as an independent
series, since there are no longer any share
t one level up. This also resolves a
chicken/egg we have when importing bufers without explicit modifiers,
namely that we need the tiling mode to calculate the size, but we need
the BO imported to query the tiling mode.
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_bufmgr.c
Hi,
Building on top of the previous v15 to add support for buffers with
modifiers to i965, this adds CCS support.
I'm parking this until Jason has finished his blorp/etc work, so this
should be purely informational until then. It also depends on a kernel
series which hasn't got any review yet.
Ch
patch (Jason)
Cc: "Pohjolainen, Topi"
Signed-off-by: Ben Widawsky
Signed-off-by: Daniel Stone
Cc: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/mesa/driver
-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_fbo.c | 17 -
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 25 -
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 10 ++
src/mesa/drivers/dri/i965
exit from intel_miptree_make_shareable() when it's
scanout.
v3: Add another assert for mt->mcs_buf->offset. (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_context.c | 3 ++
just makes
having an aux offset possible.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_image.h | 3 +++
src/mesa/drivers/dri/i965/intel_screen.c | 2 ++
2 files changed, 5 insertions(+)
diff --git a/src/mesa/drivers/dri
From: Ben Widawsky
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_blorp.c | 3 ++-
src/mesa/drivers/dri/i965/brw_blorp.h | 3 ++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4
wsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 92 +++
1 file changed, 81 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b/src/mesa/dr
From: Ben Widawsky
Upper layers of the code will have the need to specify full or partial
resolves (more on this in the next patch). This code simply adds the new
enums and plumbs it in as minimally as necessary.
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
able since mt
allocation should work correctly now.
Unref the BO is miptree creation fails (Jason)
v3: Rebase (Daniel)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_context.c | 31 ++
MiB/s
v2: Move all references to the new fourcc code(s) to this patch.
v3: Rebase, remove Yf_CCS (Daniel)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 10 ++
1 file changed, 10 inser
From: Varad Gautam
v2: split this into a separate patch (Jason)
Signed-off-by: Ben Widawsky
Signed-off-by: Daniel Stone
Cc: Jason Ekstrand
---
src/mesa/drivers/dri/i965/brw_context.c | 3 +++
src/mesa/drivers/dri/i965/intel_fbo.h | 7 +++
src/mesa/drivers/dri/i965
From: Ben Widawsky
v2: move is_aux into if block. (Jason)
Use else block instead of goto (Jason)
v3: Fix up logic for is_aux (Ben)
Fix up size calculations and add FIXME (Ben)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Signed-off-by: Daniel Stone
---
src/mesa
Make setting the hint more concise (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_blorp.c | 8
src/mesa/drivers/dri/i965/brw_context.c | 13 +++--
src/mesa/dr
ely
Cc: Topi Pohjolainen
Cc: Chad Versace
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/dri
From: Ben Widawsky
We no longer allocate a miptree for the mcs_buf, so this is not a useful
assertion.
Recommended-by: Topi Pohjolainen
Signed-off-by: Ben Widawsky
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8
1
d-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen (v2)
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965/brw_context.c | 16 ++--
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++---
src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 2
o have the
CCS_MODIFIER token saved for the last patch, this patch now does less so
it was renamed.
v2: Leave "image+mod" (Topi)
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Topi Pohjolainen
Signed-off-by: Daniel Stone
---
src/mesa/drivers/dri/i965
Hi Eric,
On 6 June 2017 at 18:27, Eric Engestrom wrote:
> On Tuesday, 2017-06-06 18:18:31 +0100, Daniel Stone wrote:
>> diff --git a/src/egl/drivers/dri2/egl_dri2.c
>> b/src/egl/drivers/dri2/egl_dri2.c
>> index d31a0bf8e0..7175e827c9 100644
>> --- a/src/egl/drivers/d
Hi Chad,
On 6 June 2017 at 21:36, Chad Versace wrote:
> @@ -254,8 +255,22 @@ create_mt_for_dri_image(struct brw_context *brw,
> struct gl_context *ctx = &brw->ctx;
> struct intel_mipmap_tree *mt;
> uint32_t draw_x, draw_y;
> + mesa_format format = image->format;
> +
> + if (!ctx->
Hi Chad,
On 8 June 2017 at 00:45, Chad Versace wrote:
> On Tue 06 Jun 2017, Daniel Stone wrote:
>> I wonder if it wouldn't be better to do this in
>> intel_create_image_from_name. That way it would be more obvious
>> up-front what's happening,
>
> I ag
Add a simple conversion from ISL tiling to GEM BO tiling flags, and use
that instead of hardcoding I915_TILING_X in the ANV WSI.
Signed-off-by: Daniel Stone
---
src/intel/isl/isl.c| 28
src/intel/isl/isl.h| 8
src/intel/vulkan/anv_wsi.c
Hi,
With full support for modifiers in DRIimage, this patch series adds
support for fully plumbing them through X11. A patchset proposing
an extension to DRI3 to support multiple planes and modifiers can
be found here:
https://lists.x.org/archives/xorg-devel/2017-June/053854.html
The Git trees, al
From: Chad Versace
Signed-off-by: Daniel Stone
---
src/intel/isl/isl.c | 35 +++
src/intel/isl/isl.h | 15 +++
2 files changed, 50 insertions(+)
diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 330c3d6c87..b78a22df8c 100644
--- a/src
From: Chad Versace
It converts a DRM format modifier to and from enum isl_tiling and
aux_usage. That's all.
Signed-off-by: Daniel Stone
---
src/intel/Makefile.isl.am | 1 +
src/intel/isl/isl.c | 59 +++
src/intel/isl/isl.h
From: Chad Versace
Like anv_get_format(), but the returned format is not adjusted, not even
for the aspect.
Add anv_get_raw_isl_format() too, to match anv_get_isl_format().
Signed-off-by: Daniel Stone
---
src/intel/vulkan/anv_formats.c | 7 +++
src/intel/vulkan/anv_private.h | 8
-by: Daniel Stone
---
src/intel/vulkan/anv_image.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 6e7d943014..dae7ed9311 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -162,7
From: Louis-Francis Ratté-Boulianne
Add support for DRI3 v1.1, which allows pixmaps to be backed by
multi-planar buffers, or those with format modifiers. This is both
for allocating render buffers, as well as EGLImage imports from a
native pixmap (EGL_NATIVE_PIXMAP_KHR).
Signed-off-by: Daniel
From: Chad Versace
For now, we support dma_buf images for only a single format,
VK_FORMAT_R8G8B8A8_UNORM. And the image must be a "simple" image: 2D,
single-sample, non-mipmappped, non-array, non-cube.
Signed-off-by: Daniel Stone
---
src/intel/vulkan/anv_device.c | 4 +
Adds support for multiple planes and buffer modifiers.
Signed-off-by: Daniel Stone
---
src/intel/vulkan/anv_wsi.c | 7 +-
src/vulkan/wsi/wsi_common_x11.c | 137
2 files changed, 131 insertions(+), 13 deletions(-)
diff --git a/src/intel/vulkan
From: Chad Versace
The code that chooses the image's tiling flags, extract it into a new
function, choose_isl_tiling_flags(). This reduces the diff in future
patches for the upcoming dma_buf-import extension, in which the the
tiling code will become more complex.
Signed-off-by: Daniel
101 - 200 of 802 matches
Mail list logo
