Hi Chad, On 8 June 2017 at 00:45, Chad Versace <chadvers...@chromium.org> wrote: > On Tue 06 Jun 2017, Daniel Stone wrote: >> I wonder if it wouldn't be better to do this in >> intel_create_image_from_name. That way it would be more obvious >> up-front what's happening, > > I agree that the intent would become more obvious if the format fallback > were done at time of import instead of gl*Storage. But I see two > arguments against it:
Thanks a lot for the detailed explanation! Makes sense. > Anyway, why would it fail during fourcc lookup? The table > intel_screen.c:intel_image_formats[] contains an entry for > __DRI_IMAGE_FOURCC_XBGR8888. And egl_dri2.c:dri2_check_dma_buf_format() > knows about DRM_FORMAT_XBGR8888 too. Apparently I can't read, or type, so missed it in the table. Cheers, Daniel _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
