[Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-07-24 Thread Daniel Scharrer
--- ARB_dsa / GL 4.5 add indexed GL_TEXTURE_BINDING_* and GL_SAMPLER_BINDING queries, as well as a GL_TEXTURE_TARGET query on texture objects. The implementation for the GL_TEXTURE_BINDING_* and GL_SAMPLER_BINDING queries is based on their non-indexed variants. To map the binding enum to a textur

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Daniel Scharrer
Ping. Can someone please review and/or commit this. I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch be Cc'd to that? -- Daniel On 2015-07-25 08:12, Daniel Scharrer wrote: > --- > > ARB_dsa / GL 4.5 add indexed GL_TEXTURE_BINDING_* and GL_SAMPLER_BINDING

Re: [Mesa-dev] [PATCH] mesa: add missing queries for ARB_direct_state_access

2015-08-03 Thread Daniel Scharrer
Hi, thanks for looking at this. On 2015-08-03 16:18, Brian Paul wrote: > On 08/03/2015 06:01 AM, Daniel Scharrer wrote: >> Ping. >> >> Can someone please review and/or commit this. >> >> I noticed ARB_dsa is already exposed in Mesa 10.6 - should this patch b

[Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-06 Thread Daniel Scharrer
CC: "10.6" --- v2: added CC for 10.6 renamed _mesa_tex_target_to_index to tex_target_to_index moved declaration of variable before code added missing spaces in ternary operators src/mesa/main/get.c | 93 src/mesa/main/texparam.c

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Daniel Scharrer
On 2015-08-06 15:46, Brian Paul wrote: > On 08/06/2015 07:44 AM, Daniel Scharrer wrote: >> CC: "10.6" >> >> --- >> >> v2: added CC for 10.6 >> renamed _mesa_tex_target_to_index to tex_target_to_index >> moved declaration of varia

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Daniel Scharrer
On 2015-08-12 17:14, Brian Paul wrote: > Another question below... > > On 08/12/2015 08:31 AM, Daniel Scharrer wrote: >> On 2015-08-06 15:46, Brian Paul wrote: >>> On 08/06/2015 07:44 AM, Daniel Scharrer wrote: >>>> CC: "10.6" >>>> &

Re: [Mesa-dev] [PATCH v2] mesa: add missing queries for ARB_direct_state_access

2015-08-12 Thread Daniel Scharrer
Hi, On 2015-08-12 18:05, Fredrik Höglund wrote: > On Thursday 06 August 2015, Daniel Scharrer wrote: >> CC: "10.6" > > I think the commit message should say which queries are added. > >> >> --- >> >> v2: added CC for 10.6 >>

[Mesa-dev] [PATCH v3 2/2] mesa: return old name for deleted samplers for SAMPLER_BINDING queries

2015-08-17 Thread Daniel Scharrer
If the sampler object has been deleted in the same context the binding will have been cleared. If it has been deleted in another context, the spec does not say what should returned. None of the other binding point queries check for deletion in another context. Also, as names of deleted objects are

[Mesa-dev] [PATCH v3 1/2] mesa: add missing queries for ARB_direct_state_access

2015-08-17 Thread Daniel Scharrer
This adds index queries (glGet*i_v) for GL_TEXTURE_BINDING_* and GL_SAMPLER_BINDING, as well as textue queries (glGetTex{,ture}Parameter*) for GL_TEXTURE_TARGET. CC: "10.6" --- v3: fixed uper limit for texture units don't use extension suffixes for core tokens mention added queries in com

[Mesa-dev] [PATCH v4 1/2] mesa: add missing queries for ARB_direct_state_access

2015-08-28 Thread Daniel Scharrer
This adds index queries (glGet*i_v) for GL_TEXTURE_BINDING_* and GL_SAMPLER_BINDING, as well as textue queries (glGetTex{,ture}Parameter*) for GL_TEXTURE_TARGET. CC: "10.6 11.0" --- v4: fixed trivial merge conflict in texparam.c added 11.0 to stable tag v3: fixed uper limit for texture units

[Mesa-dev] [PATCH v4 2/2] mesa: return old name for deleted samplers for SAMPLER_BINDING queries

2015-08-28 Thread Daniel Scharrer
If the sampler object has been deleted in the same context the binding will have been cleared. If it has been deleted in another context, the spec does not say what should returned. None of the other binding point queries check for deletion in another context. Also, as names of deleted objects are

Re: [Mesa-dev] [PATCH] vbo: disable primitive restart when GL >= 4.5

2016-10-06 Thread Daniel Scharrer
ainst older OpenGL versions. Maybe Mesa should limit the context version to the one requested by the application. The blob drivers seem to do this (at least the AMD one) and the current behaviour has already caused problems before: https://bugs.freedesktop.org/show_bug.cgi?id=95374 -- Da

[Mesa-dev] [PATCH] mesa: Fix fixed function spot lighting on newer hardware (again)

2016-08-13 Thread Daniel Scharrer
This was first fixed in commit b3f9c5c and then broken again in commit fe2d2c7, which removed the abs modifier from input registers. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91342 Signed-off-by: Daniel Scharrer Cc: "12.0" --- src/mesa/main/ffvertex_prog.c | 14 ++-

[Mesa-dev] [PATCH v2] mesa: Fix fixed function spot lighting on newer hardware (again)

2016-08-19 Thread Daniel Scharrer
This was first fixed in commit b3f9c5c and then broken again in commit fe2d2c7, which removed the abs modifier from input registers. v2: Don't change the size of struct ureg. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91342 Signed-off-by: Daniel Scharrer Cc: "12.0"

Re: [Mesa-dev] [PATCH] mesa: Fix fixed function spot lighting on newer hardware (again)

2016-08-19 Thread Daniel Scharrer
On 2016-08-14 06:38, Matt Turner wrote: > On Sat, Aug 13, 2016 at 5:07 PM, Daniel Scharrer wrote: >> This was first fixed in commit b3f9c5c and then broken again in commit >> fe2d2c7, which removed the abs modifier from input registers. >> >> Bugzilla: https://bugs.free

[Mesa-dev] [PATCH] ac/nir/llvm: Fix setting function attributes for intrinsics

2016-11-11 Thread Daniel Scharrer
This fixes a NULL pointer dereference for intrinsics with more than one function attribute introduced in commit 2fdaf38. The fix is ported from the lp_build_intrinsic changes in commit 8bdd52c. --- I'm a bit unsure about the index change from 0 to -1, but the gallium code does this as well and wit

Re: [Mesa-dev] [PATCH] ac/nir/llvm: Fix setting function attributes for intrinsics

2016-11-11 Thread Daniel Scharrer
r / attr_to_str that catches this. > Either way, this patch is > Reviewed-by: Bas Nieuwenhuizen Thanks. I don't have commit access so I'll need someone else to push it. > On Fri, Nov 11, 2016 at 9:36 PM, Daniel Scharrer wrote: >> This fixes a NULL pointer dereference

[Mesa-dev] [PATCH] mesa: Add abs input modifier to base for POW in ffvertex_prog

2015-10-01 Thread Daniel Scharrer
The result of POW for a negative base is undefined. Even when the result is multiplied by zero (which is the case here whenever the base is negative), the Inf and NaNs can propagate past that. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91342 Signed-off-by: Daniel Scharrer Cc: "

Re: [Mesa-dev] [PATCH] mesa: Add abs input modifier to base for POW in ffvertex_prog

2015-10-01 Thread Daniel Scharrer
On 2015-10-01 21:45, Ilia Mirkin wrote: > On Thu, Oct 1, 2015 at 8:36 AM, Daniel Scharrer wrote: >> The result of POW for a negative base is undefined. Even when the result >> is multiplied by zero (which is the case here whenever the base is >> negative), the Inf and NaNs ca

[Mesa-dev] [PATCH 1/2] mesa: Don't advertise GLES 3.1 without compute support

2016-04-19 Thread Daniel Scharrer
The MaxComputeWorkGroupInvocations constant is used in compute_version_es2() instead of extensions->ARB_compute_shader as ES has lower requirements than desktop GL. Both i965 and gallium set this constant before enabling compute support. Signed-off-by: Daniel Scharrer --- This currently cau

[Mesa-dev] [PATCH 2/2] glsl: Remove duplicated defaults in the standalone compiler

2016-04-19 Thread Daniel Scharrer
These are already set in initialize_context_to_defaults(). Signed-off-by: Daniel Scharrer --- src/compiler/glsl/main.cpp | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/compiler/glsl/main.cpp b/src/compiler/glsl/main.cpp index d253575..c410bdd 100644 --- a/src/compiler/glsl