Re: [Mesa-dev] [PATCH] winsys/radeon: Unmap GPU VM address range when destroying BO

On 16.06.2015 10:28, Michel Dänzer wrote: From: Michel Dänzer But only when doing so is safe according to the RADEON_INFO_VA_UNMAP_WORKING kernel query. This avoids GPU VM address range conflicts when the BO has other references than the GEM handle being closed, e.g. when the BO is shared. T

Re: [Mesa-dev] [PATCH] winsys/radeon: Unmap GPU VM address range when destroying BO

On 16.06.2015 10:56, Michel Dänzer wrote: On 16.06.2015 17:34, Christian König wrote: On 16.06.2015 10:28, Michel Dänzer wrote: From: Michel Dänzer But only when doing so is safe according to the RADEON_INFO_VA_UNMAP_WORKING kernel query. This avoids GPU VM address range conflicts when the

Re: [Mesa-dev] [PATCH] winsys/radeon: Unmap GPU VM address range when destroying BO

On 17.06.2015 04:54, Michel Dänzer wrote: On 16.06.2015 20:39, Christian König wrote: On 16.06.2015 10:56, Michel Dänzer wrote: On 16.06.2015 17:34, Christian König wrote: What we would need to really clean that up is to make the VM mappings per GEM handle like you suggested or allow multiple

Re: [Mesa-dev] abundance of branches in mesa.git

Hi Ilia, oh, yes please. Especially since some people tend to completely mirror the mesa master repository including all those old branches. This sometimes creates quite a mess. Regards, Christian. On 20.06.2015 02:10, Ilia Mirkin wrote: Hello, There are a *ton* of branches in the upstream

Re: [Mesa-dev] abundance of branches in mesa.git

On 22.06.2015 15:41, Ilia Mirkin wrote: On Mon, Jun 22, 2015 at 9:39 AM, Tom Stellard wrote: On Mon, Jun 22, 2015 at 12:23:54PM +0200, Marek Olšák wrote: On Mon, Jun 22, 2015 at 5:36 AM, Ilia Mirkin wrote: On Sun, Jun 21, 2015 at 11:33 PM, Michel Dänzer wrote: On 22.06.2015 00:31, Ilia Mir

[Mesa-dev] [PATCH 2/2] st/vdpau: fix mixer size checks

From: Christian König We need to check what the 3D pipe is able to handle for the mixer, not what the decoder is able to decode. This fixes output of resolutions like 720x1280. Signed-off-by: Christian König CC: mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/vdpau/mixer.c

[Mesa-dev] [PATCH 1/2] vl: cleanup video buffer private when the decoder is destroyed

From: Christian König Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=90728 Signed-off-by: Christian König CC: mesa-sta...@lists.freedesktop.org --- src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 24 src/gallium/auxiliary/vl/vl_mpeg12_decoder.h | 4 2 files

Re: [Mesa-dev] [PATCH 0/4] fence refcnting fixes

sted Oh, yes please. That also annoyed me once or twice while hacking on the state trackers. Since I'm not into the drivers those changes are Acked-by: Christian König Do you want to take care of the state trackers as well or should I look into the video state trackers to fix this my

Re: [Mesa-dev] [PATCH] libdrm/amdgpu: Use private fd for amdgpu_device and winsys hash table to fix ZaphodHeads.

tor. That was obviously not implemented like this (we leak the descriptor on destruction), but IIRC there was a reason for doing it like this. The patch is Reviewed-by: Christian König for now, but I'm not 100% sure if that's the last word on the topic. Regards, Christian.

[Mesa-dev] [PATCH 2/2] r600/vce: enable VCE for trinity/richland

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/r600/r600_uvd.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_uvd.c b/src/gallium/drivers/r600/r600_uvd.c index 3a94a5a..e2e9033 100644 --- a

[Mesa-dev] [PATCH 1/2] r600/uvd: disable UVD tiling by default

From: Christian König It has only minimal advantages for post processing and doesn't work with VCE. Signed-off-by: Christian König --- src/gallium/drivers/r600/r600_uvd.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_uvd.c

[Mesa-dev] [PATCH 1/2] Used correct parameter to derive the value of the "h" variable in vlVaCreateImage

From: Indrajit Das Reviewed-by: Christian König --- src/gallium/state_trackers/va/image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/image.c index 022240d..3b36430 100644 --- a/src/gallium

[Mesa-dev] [PATCH 2/2] Added support for NV12 to IYUV conversion in vlVaGetImage

From: Indrajit Das Reviewed-by: Christian König --- src/gallium/state_trackers/va/image.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c b/src/gallium/state_trackers/va/image.c index 3b36430..b37a971 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH 1/2] Used correct parameter to derive the value of the "h" variable in vlVaCreateImage

On 16.10.2015 18:02, Emil Velikov wrote: On 16 October 2015 at 15:53, Christian König wrote: From: Indrajit Das Reviewed-by: Christian König Nicely spotted ! For the future use correct prefix for the summary ("st/va:" here, but git log will show you the way in other places) a

Re: [Mesa-dev] [PATCH] st/omx/dec/h264: fix field picture type 0 poc disorder

Reviewed-by: Christian König For mesa you can push small fixes like this even without a review when nobody objects after a few days. Regards, Christian. On 19.10.2015 16:55, Liu, Leo wrote: Ping... -Original Message- From: Liu, Leo Sent: Wednesday, October 14, 2015 2:49 PM To

Re: [Mesa-dev] [PATCH] radeon/uvd: don't expose HEVC on old UVD hw (v2)

On 22.10.2015 19:50, Alex Deucher wrote: The section for UVD 2 and older was not updated when HEVC support was added. Reported by Kano on irc. v2: integrate the UVD2 and older checks into the main switch statement. Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- src/gal

Re: [Mesa-dev] [PATCH] radeon/uvd: don't expose HEVC on old UVD hw (v3)

statement, so drop encode checks in the lower case statement. Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org Reviewed-by: Christian König --- src/gallium/drivers/radeon/radeon_video.c | 50 +++ 1 file changed, 18 insertions(+), 32 deletions

Re: [Mesa-dev] [PATCH] st/va: pass picture desc to begin and decode

On 23.10.2015 14:25, Julien Isorce wrote: At least vl_mpeg12_decoder uses the picture desc in begin_frame and decode_bitstream. https://bugs.freedesktop.org/show_bug.cgi?id=92634 Signed-off-by: Julien Isorce Reviewed-by: Christian König --- src/gallium/state_trackers/va/picture.c | 4

Re: [Mesa-dev] [PATCH] st/va: pass picture desc to begin and decode

Done, but you should apply for an account. Best regards, Christian. On 26.10.2015 13:46, Julien Isorce wrote: Hi Christian, Would you mind to push this patch ? Thx Cheers Julien On 23 October 2015 at 14:33, Christian König <mailto:deathsim...@vodafone.de>> wrote: On 23.10.2

Re: [Mesa-dev] [PATCH] mesa: set the texture target in VDPAUMapSurfacesNV

th those Reviewed-by: Emil Velikov Yeah that explanation sounds sane to me. Patch is Reviewed-by: Christian König as well. Thanks for digging up why that failed, Christian. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://l

Re: [Mesa-dev] [PATCH v2 07/13] st/va: add headless support, i.e. VA_DISPLAY_DRM

+ drm_info = (struct drm_state *) ctx->drm_state; + if (!drm_info) { + FREE(drv); + return VA_STATUS_ERROR_INVALID_PARAMETER; + } + +#if GALLIUM_STATIC_TARGETS + drm_fd = drm_info->fd; +#else + drm_fd = dup(drm_info->fd); +#endif + + if (drm_fd < 0)

Re: [Mesa-dev] [PATCH 0/7] st/va: VPP, dmabuf import and headless.

Hi Julien, if Emil or Ilia have no further comments please send out your full set of patches once more I would like to get this pusched upstream. Best regards, Christian. On 17.10.2015 01:14, Julien Isorce wrote: This patch serie adds initial support for Video Post Processing. It also implem

Re: [Mesa-dev] [PATCH 1/2] st/va: implement VaDeriveImage

Patch #1: + if (buf->data) + FREE(buf->data); FREE() usually does a NULL check anyway. Apart from that minor nitpick the patch is Reviewed-by: Christian König Regards, Christian. On 29.10.2015 12:47, Julien Isorce wrote: And apply relatives change to: vlVaBufferSetNumEl

Re: [Mesa-dev] [PATCH 2/2] st/va: add support to export a surface as dmabuf

@@ -108,6 +109,9 @@ vlVaMapBuffer(VADriverContextP ctx, VABufferID buf_id, void **pbuff) if (!buf) return VA_STATUS_ERROR_INVALID_BUFFER; + if (buf->export_refcount > 0) + return VA_STATUS_ERROR_INVALID_BUFFER; Why it is illegal to CPU map a buffer which is exported? +

Re: [Mesa-dev] [PATCH v2 6/8] st/va: handle Video Post Processing for configs

On 22.10.2015 18:37, Julien Isorce wrote: Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce Reviewed-by: Christian König

Re: [Mesa-dev] [PATCH v2 7/8] st/va: add colospace conversion through Video Post Processing

+if(src_surface->fence) { + screen->fence_finish(screen, src_surface->fence, PIPE_TIMEOUT_INFINITE); + screen->fence_reference(screen, &src_surface->fence, NULL); +} That shouldn't be necessary cause all render operations to the same surface are pipelined anyway. Regards, Ch

Re: [Mesa-dev] [PATCH v4 1/9] st/va: properly defines VAImageFormat formats and improve VaCreateImage

@@ -80,12 +82,46 @@ YCbCrToPipe(unsigned format) ... +PipeToYCbCr(enum pipe_format p_format) You should probably rename those two functions as well, cause when we start to handle RGB formats as well the name doesn't match any more. BTW when do you use PipeToYCbCr? Regards, Christian. On 2

Re: [Mesa-dev] [PATCH v4 2/9] st/va: do not destroy old buffer when new one failed

ff-by: Julien Isorce Reviewed-by: Christian König Should I push the patches already reviewed? Regards, Christian. --- src/gallium/state_trackers/va/image.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/gallium/state_trackers/va/image.c

Re: [Mesa-dev] [PATCH v4 4/9] st/va: implement dmabuf import for VaCreateSurfaces2

On 29.10.2015 18:40, Julien Isorce wrote: For now it is limited to RGBA, BGRA, RGBX, BGRX surfaces. Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/surface.c | 97 - 1 file changed, 96 insertions(+), 1 deletion(-) diff --git a/src/gallium/state

Re: [Mesa-dev] [PATCH v4 5/9] st/va: handle Video Post Processing for configs

On 29.10.2015 18:40, Julien Isorce wrote: Add support for VA_PROFILE_NONE and VAEntrypointVideoProc in the 4 following functions: vlVaQueryConfigProfiles vlVaQueryConfigEntrypoints vlVaCreateConfig vlVaQueryConfigAttributes Signed-off-by: Julien Isorce Reviewed-by: Christian König But you

Re: [Mesa-dev] [PATCH v4 6/9] st/va: add colospace conversion through Video Post Processing

vlVaQueryVideoProcPipelineCaps Add handleVAProcPipelineParameterBufferType helper. One application is: VASurfaceNV12 -> gstvaapipostproc -> VASurfaceRGBA Signed-off-by: Julien Isorce Reviewed-by: Christian König Are you planning to implement the different filters as well? Most of the shaders for those are a

Re: [Mesa-dev] [PATCH v4 7/9] st/va: add headless support, i.e. VA_DISPLAY_DRM

On 29.10.2015 18:40, Julien Isorce wrote: This patch allows to use gallium vaapi without requiring a X server running for your second graphic card. Signed-off-by: Julien Isorce Reviewed-by: Christian König --- src/gallium/state_trackers/va/Makefile.am | 9 src/gallium

Re: [Mesa-dev] [PATCH v4 8/9] st/va: implement VaDeriveImage

which is normally used for normal user data array. On of the consequences is that it is only possible VaDeriveImage is only useful on surfaces backed with contiguous planes. Implementation inspired from cgit.freedesktop.org/vaapi/intel-driver Signed-off-by: Julien Isorce Reviewed-by: Christian

Re: [Mesa-dev] [PATCH v4 9/9] st/va: add support to export a surface as dmabuf

/intel-driver Tested with gstreamer-vaapi with nouveau driver. Signed-off-by: Julien Isorce Reviewed-by: Christian König --- src/gallium/state_trackers/va/buffer.c | 136 - src/gallium/state_trackers/va/context.c| 4 +- src/gallium/state_trackers/va

Re: [Mesa-dev] Avoid segfault in omx deconstructor

The subject line should have something like "st/omx: ...". Apart from that the patch is Reviewed-by: Christian König Regards, Christian. On 03.11.2015 19:06, StDenis, Tom wrote: Now with the correct email address ... Ch

Re: [Mesa-dev] [PATCH] winsys/radeon: Use CPU page size instead of hardcoding 4096 bytes

(alignment, 4096); -size = align(size, 4096); +size = align(size, mgr->size_align); Since all allocations are round up to the CPU page size it probably doesn't matter, but we might want to adjust the alignment as well. With that fixed the patch is Reviewed-by: Christi

Re: [Mesa-dev] [PATCH] winsys/radeon: Use CPU page size instead of hardcoding 4096 bytes

On 04.11.2015 10:10, Michel Dänzer wrote: On 04.11.2015 18:06, Christian König wrote: On 04.11.2015 09:54, Michel Dänzer wrote: @@ -188,8 +191,11 @@ static uint64_t radeon_bomgr_find_va(struct radeon_bomgr *mgr, uint64_t size, ui struct radeon_bo_va_hole *hole, *n; uint64_t

Re: [Mesa-dev] [PATCH 0/4] st/va: indent, leak fix and RGBx/BGRx for vpp

Patches #1-#3 are Reviewed-by: Christian König Please split patch #4 in two with first adding the new vl_video_buffer formats and then using them in the state tracker. Should I commit that for you as well or do you now have an account? Regards, Christian. On 05.11.2015 09:24, Julien Isorce

Re: [Mesa-dev] [PATCH 2/4] vl: add drm support for vl_screen

+/** + * + * Copyright 2009 Younes Manton. + * All Rights Reserved. You probably want to change the copyright here. With that fixed the whole series is Reviewed-by: Christian König Regards, Christian. On 05.11.2015 19

[Mesa-dev] [PATCH] radeon/uvd: add H.265/HEVC to legal notes

From: Christian König Signed-off-by: Christian König --- docs/README.UVD | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/README.UVD b/docs/README.UVD index 38ea864..b0f4b9d 100644 --- a/docs/README.UVD +++ b/docs/README.UVD @@ -2,8 +2,8 @@ The software may

[Mesa-dev] [PATCH 2/2] radeon/uvd: fix VC-1 simple/main profile decode v2

From: Boyuan Zhang We just needed to set the extra width/height fields to get this working. v2 (chk): rebased, CC stable added, commit message added, fixed coding style Signed-off-by: Boyuan Zhang Signed-off-by: Christian König Cc: "10.6 11.0" --- src/gallium/drivers/radeon/ra

[Mesa-dev] [PATCH 1/2] st/vaapi: fix vaapi VC-1 simple/main corruption v2

From: Boyuan Zhang Apply the start code fix only to advanced profile. v2 (chk): add commit message Signed-off-by: Boyuan Zhang Reviewed-by: Christian König Cc: "10.6 11.0" --- src/gallium/state_trackers/va/picture.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/s

[Mesa-dev] fix VC-1 simple/main profile

Hi list, we haven't fixed all the issues yet, but this is a clearly step in the right direction. If nobody has any more objections I'm going to push these by the end of today. Regards, Christian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [PATCH v2 1/4] st/va: properly indent buffer.c, config.c, image.c and picture.c

from the commit message now that this fix is in a separate patch. With that fixed the whole set is Reviewed-by: Christian König Regards, Christian. --- src/gallium/state_trackers/va/buffer.c | 14 +++--- src/gallium/state_trackers/va/config.c | 12 ++--- src/gallium/state_trackers/va

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

On 06.11.2015 20:10, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan wrote: Hi Emil, Please see the following information about this patch. - Issue: For Mpeg4, the VOP and GOV headers were truncated. With the existing workaround in st/va, playback shows massive corruptions.

Re: [Mesa-dev] [PATCH] st/va: add mpeg4 startcode workaround

On 06.11.2015 20:28, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 2:15 PM, Christian König wrote: On 06.11.2015 20:10, Ilia Mirkin wrote: On Fri, Nov 6, 2015 at 1:48 PM, Zhang, Boyuan wrote: Hi Emil, Please see the following information about this patch. - Issue: For Mpeg4, the VOP and GOV

[Mesa-dev] [PATCH] winsys/radeon: add user pointer support

From: Christian König Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 102 ++ src/gallium/winsys/radeon/drm/radeon_winsys.h | 11 +++ 2 files changed, 113 insertions(+) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b

Re: [Mesa-dev] [PATCH] winsys/radeon: add user pointer support

Alex Thanks, Marek On Thu, Feb 5, 2015 at 6:34 PM, Christian König wrote: From: Christian König Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 102 ++ src/gallium/winsys/radeon/drm/radeon_winsys.h | 11 +++ 2 files changed

Re: [Mesa-dev] [PATCH] winsys/radeon: add user pointer support

ion should have been bumped probably. Marek On Tue, Feb 10, 2015 at 9:35 AM, Christian König wrote: Am 10.02.2015 um 03:41 schrieb Alex Deucher: On Mon, Feb 9, 2015 at 7:29 PM, Marek Olšák wrote: Hi Christian, What hardware is this supported on? SI and later? Or even r600? r300? Theoreti

Re: [Mesa-dev] [PATCH 1/6] mesa: implement GL_AMD_pinned_memory

Sorry for forgetting to bump the driver version, been to busy lately. Patches are Reviewed-by: Christian König Regards, Christian. Am 11.02.2015 um 21:18 schrieb Marek Olšák: From: Marek Olšák It's not possible to query the current buffer binding, because the extension doesn't

Re: [Mesa-dev] 10bit HEVC decoding for RadeonSI

Am 27.01.2017 um 20:44 schrieb Mark Thompson: On 27/01/17 14:27, Christian König wrote: Am 27.01.2017 um 13:51 schrieb Mark Thompson: On 26/01/17 16:59, Christian König wrote: [SNIP] (For that matter, is there a list somewhere of the set of formats/layouts and what they are used for?) Well

Re: [Mesa-dev] [PATCH v2] st/va encode handle ntsc framerate rate control

/gallium/state_trackers/va/picture.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) Tested, LGTM. (0.5fps works nicely now :) Reviewed-by: Mark Thompson Acked-by: Christian König diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va

Re: [Mesa-dev] [PATCH 3/3] winsys/radeon: clamp vram_vis_size to 256MB

NAK, that isn't correct. Especially on APUs we can now use more than 256MB visible VRAM. Christian. Am 30.01.2017 um 01:33 schrieb Marek Olšák: From: Marek Olšák the value from the kernel is wrong --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH] st/va encode handle ntsc framerate rate control

Am 30.01.2017 um 09:17 schrieb Michel Dänzer: On 30/01/17 12:08 AM, Andy Furniss wrote: Christian König wrote: That looks correct to me, but I'm not deeply enough into the H264 encoding any more. Adding Leo and Boyuan to comment as well. I just sent v2 to list and tried to cc Boyuan an

Re: [Mesa-dev] [PATCH] drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl

;t be used for BO migration for some reason). The above was incorrectly used for vram_visible before, resulting in generally too large values being reported. Signed-off-by: Michel Dänzer Good catch, I wonder how long we have that in here. Reviewed-by: Christian König for this one as well the

Re: [Mesa-dev] vdpau_interop extension oddities

Hi Thomas, I'm on sick leave, but will try to quickly answer your questions. But don't be disappointed if you don't hear back from me before Monday. Am 01.02.2017 um 15:56 schrieb Thomas Hellstrom: Hi, Christian, I'm looking through the mesa vdpau interop code and found something that looks s

Re: [Mesa-dev] vdpau_interop extension oddities

Am 01.02.2017 um 16:50 schrieb Thomas Hellstrom: Hi, Again, (No need answering while on sick leave!). Actually I'm bored, but can't concentrate on coding when my body temperature isn't in the normal range :( Hui? That's not how I remembered it. For the dma-buf part we export one layer of

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

Am 01.02.2017 um 13:59 schrieb Nayan Deshmukh: we anyway allow for multiple slices Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/va/picture_mpeg12.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mpeg12.c b/src/gallium/state_trackers/

Re: [Mesa-dev] [PATCH] st/va: remove assert for single slice

Sorry for the delay, as noted in the other mail I was on sick leave for a while. Am 03.02.2017 um 05:52 schrieb Nayan Deshmukh: On Thu, Feb 2, 2017 at 3:34 PM, Christian König wrote: Am 01.02.2017 um 13:59 schrieb Nayan Deshmukh: we anyway allow for multiple slices Signed-off-by: Nayan

Re: [Mesa-dev] [PATCH v2] st/va: remove assert for single slice

Am 10.02.2017 um 16:36 schrieb Nayan Deshmukh: we anyway allow for multiple slices v2: do not remove assert to check for buf->size Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König . --- src/gallium/state_trackers/va/picture_mpeg12.c | 2 +- 1 file changed, 1 insertion(+)

Re: [Mesa-dev] [PATCH 2/2] vdpau: skip vlVdpOutputSurfacePutBitsNative with a zero-area rectangle

27;m not sure if that is an application bug. Trying to put a box with zero width and hight might not make much sense, but the interface doesn't forbids that explicitly. Anyway we need to catch this case in the state tracker and so the patch is Reviewed-by: Christian König . Re

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes / improvements for things I've encountered while looking through and testing the video code in preparation for a virtual hardware video driver. Reviewed-by: Christian König for the whol

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

Am 22.02.2017 um 14:42 schrieb Thomas Hellstrom: mplayer likes putting YV12 data, and if there is a buffer format mismatch, the vdpau state tracker would try to reallocate the video surface as an YV12 surface. A virtual driver doesn't like reallocating and doesn't like YV12 surfaces, so before tr

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22 February 2017 at 09:30, Thomas Hellstrom wrote: On 02/22/2017 09:56 AM, Christian König wrote: Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom: A couple of fixes / improvements for things I&#x

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

Am 22.02.2017 um 17:23 schrieb Thomas Hellstrom: On 02/22/2017 04:46 PM, Christian König wrote: Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22 February 2017 at 09:30, Thomas Hellstrom wrote: On 02/22/2017 09:56 AM, Christian König wrote

Re: [Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

Am 22.02.2017 um 18:05 schrieb Thomas Hellstrom: On 02/22/2017 05:54 PM, Christian König wrote: Am 22.02.2017 um 17:23 schrieb Thomas Hellstrom: On 02/22/2017 04:46 PM, Christian König wrote: Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom: On 02/22/2017 04:00 PM, Emil Velikov wrote: On 22

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: Provide YV12 to NV12 putBits conversion v2

Cc: Christian König Signed-off-by: Thomas Hellstrom Acked-by: Christian König for both patches. --- src/gallium/auxiliary/util/u_video.h | 42 + src/gallium/state_trackers/vdpau/query.c | 13 + src/gallium/state_trackers/vdpau/surface.c | 94 -

Re: [Mesa-dev] Putbits patches

Am 24.02.2017 um 15:40 schrieb Thomas Hellstrom: Hi, Christian! Are you OK with the updated Putbits patches? https://lists.freedesktop.org/archives/mesa-dev/2017-February/145269.html https://lists.freedesktop.org/archives/mesa-dev/2017-February/145258.html Sorry the second patch never made i

Re: [Mesa-dev] [PATCH] vl/mpeg12: Silence GCC unused-variable warning.

Signed-off-by: Vinson Lee Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_mpeg12_bitstream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/vl/vl_mpeg12_bitstream.c b/src/gallium/auxiliary/vl/vl_mpeg12_bitstream.c index 539a991..52ce6c4 100644 ---

Re: [Mesa-dev] [PATCH] gallium/radeon: add a debug flag not to use write combining

can we disable HDP flushes and other flushes for USWC when we don't use write combining and CPU writes to VRAM? Nope, write combining happens in the CPU before the write request is send over the PCIe bus. The HDP is a (rather small) read/write cache in GPUs memory controller as far as I know.

Re: [Mesa-dev] [PATCH] radeon/uvd: remove unused variables

On 18.08.2015 01:51, Grazvydas Ignotas wrote: Recent commits introduced new unused variable warnings, fix them. Reviewed-by: Christian König Do you have commit access? Regards, Christian. --- src/gallium/drivers/radeon/radeon_uvd.c | 5 + 1 file changed, 1 insertion(+), 4 deletions

Re: [Mesa-dev] [PATCH] radeon/uvd: remove unused variables

On 18.08.2015 14:09, Grazvydas Ignotas wrote: On Tue, Aug 18, 2015 at 11:30 AM, Christian König wrote: On 18.08.2015 01:51, Grazvydas Ignotas wrote: Recent commits introduced new unused variable warnings, fix them. Reviewed-by: Christian König Do you have commit access? No, it's on

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

On 21.08.2015 18:30, Ilia Mirkin wrote: On Fri, Aug 21, 2015 at 12:22 PM, Julien Isorce wrote: What is the purpose of checking PIPE_VIDEO_PROFILE_UNKNOWN : http://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/nouveau_vp3_video.c#n486 and http://cgit.freedesktop.org/mesa/mesa/t

Re: [Mesa-dev] [PATCH 00/15] gallium/radeonsi hang debugging and IB parser

Nice work! Finally something that goes into the direction of proper hang debugging for end users. I don't have time to completely review it but the whole set is Acked-by: Christian König Regards, Christian. On 23.08.2015 14:04, Marek Olšák wrote: Hi, Setting GALLIUM_DDEBUG=800 (ti

Re: [Mesa-dev] vlVaQueryImageFormats and vlVdpVideoSurfaceQueryGetPutBitsYCbCrCapabilities also return unsupported formats

make a patch that implements vlVaQuerySurfaceAttributes. Well, badly designed interface would I say, but that's already well known :) Fully implementing vlVaQuerySurfaceAttributes indeed sounds like the right solution to me. Regards, Christian. Thx Julien On 21 August 2015 at 18:31,

Re: [Mesa-dev] [PATCH 00/42] RadeonSI cleaning up states

the INDIRECT_BUFFER packet is used for the init_config state on CIK and later. For the series: Reviewed-by: Alex Deucher Nice cleanup. Whole series is Acked-by: Christian König Regards, Christian. Marek ___ mesa-dev mailing list mesa-dev@lists.

Re: [Mesa-dev] [PATCH v2] st/vdpau: fix argument type to vlVdpOutputSurfaceDMABuf

Am 15.09.2016 um 01:16 schrieb Ilia Mirkin: Signed-off-by: Ilia Mirkin Reviewed-by: Christian König . --- v1 -> v2: adjust typedef in vdpau_dmabuf.h, per Nayan src/gallium/include/state_tracker/vdpau_dmabuf.h | 2 +- src/gallium/state_trackers/vdpau/output.c| 2 +- 2 fi

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

quot; I don't think we have actually tested this with PRIME and I'm pretty sure there are some loose ends which still needs to be fixed for radeon as well. So the patch is Acked-by: Christian König for now, but essentially we need to find a better solution to this. Regard

Re: [Mesa-dev] [PATCH] st/va: Make VAAPI_DISABLE_INTERLACE default true

Am 15.09.2016 um 16:43 schrieb Andy Furniss: Since bf901a2 st/va: also honors interlaced preference when providing a video format existing scripts and most use cases will need true. Signed-off-by: Andy Furniss Reviewed-by: Christian König . --- src/gallium/state_trackers/va/surface.c | 2

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

Am 15.09.2016 um 21:43 schrieb Dave Airlie: On 15 September 2016 at 17:43, Christian König wrote: Am 15.09.2016 um 06:00 schrieb Ilia Mirkin: On Wed, Sep 14, 2016 at 11:58 PM, Dave Airlie wrote: From: Dave Airlie This reverts commit d180de35320eafa3df3d76f0e82b332656530126. This is a

Re: [Mesa-dev] [PATCH] st/va: Make VAAPI_DISABLE_INTERLACE default true

Am 15.09.2016 um 23:07 schrieb Julien Isorce: On 15 September 2016 at 16:02, Leo Liu > wrote: On 09/15/2016 10:43 AM, Andy Furniss wrote: Since bf901a2 st/va: also honors interlaced preference when providing a video format existin

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

Am 16.09.2016 um 09:50 schrieb Michel Dänzer: On 16/09/16 04:33 PM, Christian König wrote: Am 15.09.2016 um 21:43 schrieb Dave Airlie: On 15 September 2016 at 17:43, Christian König wrote: Am 15.09.2016 um 06:00 schrieb Ilia Mirkin: On Wed, Sep 14, 2016 at 11:58 PM, Dave Airlie wrote

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: handle the case of different GPU(v4)

Am 16.09.2016 um 10:07 schrieb Michel Dänzer: On 14/09/16 02:34 PM, Nayan Deshmukh wrote: In case of prime when rendering is done on GPU other then the server GPU, use a seprate linear buffer for each back buffer which will be displayed using present extension. v2: Use a seprate linear buffer f

Re: [Mesa-dev] [PATCH v2] st/vdpau: fix argument type to vlVdpOutputSurfaceDMABuf

Done. Christian. Am 20.09.2016 um 08:49 schrieb Nayan Deshmukh: It hasn't been committed yet. Ilia, Christian can someone push this. Regards, Nayan. On Thu, Sep 15, 2016 at 12:55 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: Am 15.09.2016 um 01:16 schrieb

Re: [Mesa-dev] [PATCH 3/3] st/va: flush the context before calling flush_frontbuffer(v2)

I've just pushed this version of the patchset. Thanks for the help, Christian. Am 20.09.2016 um 06:52 schrieb Nayan Deshmukh: so that the texture is rendered to back buffer before calling flush_frontbuffer and can be copied to a different buffer in the function v2: change comment style Signed

Re: [Mesa-dev] [PATCH 1/3] st/va: Return more useful config attributes

+if (profile == VAProfileHEVCMain10) + value = VA_RT_FORMAT_YUV420_10BPP; We actually don't support that yet. Main10 profiles dither down the 10bit output to 8bits before writing it to the VA-API surface at the moment. Apart from that the set looks good to me, Christia

Re: [Mesa-dev] [PATCH 1/3] vl/dri3: handle the case of different GPU(v4.2)

Sounds like your version of libva ignores the DRI_PRIME environment parameter. Not sure what to do with this, but clearly a loader and not a driver problem. Regards, Christian. Am 20.09.2016 um 15:36 schrieb Mike Lothian: Here's what I currently have: fireburn@axion ~ $ DRI_PRIME=1 vainfo

Re: [Mesa-dev] [PATCH] radeon/vce: add firmware support for version 52.8.3

Am 20.09.2016 um 16:11 schrieb Leo Liu: Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/drivers/radeon/radeon_vce.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_vce.c b/src/gallium/drivers/radeon/radeon_vce.c index 92cb8ce

Re: [Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

Am 21.09.2016 um 16:38 schrieb Andy Furniss: Andy Furniss wrote: Andy Furniss wrote: Andy Furniss wrote: bz2 compressed vid showing the issue - https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms To be clear this is just the test rez vid I used so you can possibly recreate the is

Re: [Mesa-dev] [PATCH] v2 st/va Avoid VBR bitrate calculation overflow

Am 26.09.2016 um 11:44 schrieb Andy Furniss: VBR bitrate calc needs 64 bits at high rates. v2 use float. Signed-off-by: Andy Furniss Reviewed-by: Christian König . Since Leo is on vacation I will probably collect all remaining mesa patches and commit them later today. Christian

Re: [Mesa-dev] [PATCH] st/va: Fix vaSyncSurface with no outstanding operation

I just pushed the patch for now cause this is really a rather obvious bugfix. Please keep digging thinks like this up. Thanks for the help, Christian. Am 27.09.2016 um 02:18 schrieb Mark Thompson: On 27/09/16 00:49, Andy Furniss wrote: Mark Thompson wrote: --- A simple fix to the problem de

Re: [Mesa-dev] [PATCH] v2 st/va Avoid VBR bitrate calculation overflow

Am 27.09.2016 um 12:42 schrieb Emil Velikov: On 26 September 2016 at 14:35, Christian König wrote: Am 26.09.2016 um 11:44 schrieb Andy Furniss: VBR bitrate calc needs 64 bits at high rates. v2 use float. Signed-off-by: Andy Furniss Reviewed-by: Christian König . Since Leo is on vacation

Re: [Mesa-dev] st/omx/dec/h265: Correct the timestamping (derived from commit 3b6bda665a5a890f2c98e19d2939d7de92b8cb4c)

Hi Indrajit, please send this patch once more as text mail. I can't commit it like this. Regards, Christian. Am 20.09.2016 um 13:48 schrieb Das, Indrajit-kumar: From: Indrajit Das Reviewed-by: Christian König Reviewed-by: Nishanth Peethambaran Signed-off-by: Indrajit Das ---

Re: [Mesa-dev] [PATCH 1/4] radeon/vce: allocate at least 4KB of memory for the feedback buffer

regression introduced by the buffer sub-allocation. Cc: Christian König Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97976 --- src/gallium/drivers/radeon/radeon_vce.c | 6 +++--- src/gallium/drivers/radeon/radeon_video.c | 12 src/gallium/drivers/radeon/radeon_v

Re: [Mesa-dev] [PATCH 1/4] radeon/vce: allocate at least 4KB of memory for the feedback buffer

he requirements are fortunately not so problematic. I suggest that just increase the buffer size to 4096. Regards, Christian. Am 29.09.2016 um 18:59 schrieb Nicolai Hähnle: On 29.09.2016 18:52, Christian König wrote: NAK to the whole approach. VCE feedback buffers are completely separated to

Re: [Mesa-dev] [PATCH] st/omx/dec/h265: add scaling list data

Am 29.09.2016 um 23:28 schrieb Leo Liu: Specified by subclause 7.3.4 v2: get the loop optimized Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/state_trackers/omx/vid_dec_h265.c | 102 -- 1 file changed, 97 insertions(+), 5 deletions

Re: [Mesa-dev] [PATCH v2 1/5] radeon/video: don't use sub-allocated buffers

Patches #1-#3 of this series are Reviewed-by: Christian König . Regards, Christian. Am 30.09.2016 um 11:52 schrieb Nicolai Hähnle: From: Nicolai Hähnle Cc: Christian König Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97976 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id

Re: [Mesa-dev] [PATCH v2 1/5] radeon/video: don't use sub-allocated buffers

gards, Christian. Am 30.09.2016 um 11:54 schrieb Nicolai Hähnle: I should add that textures are already never sub-allocated, so with this patch all the buffers used with UVD and VCE should be covered. Nicolai On 30.09.2016 11:52, Nicolai Hähnle wrote: From: Nicolai Hähnle Cc: Christian König Bug

Re: [Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

Am 01.10.2016 um 00:06 schrieb Marek Olšák: On Fri, Sep 30, 2016 at 11:23 PM, Dave Airlie wrote: On 1 October 2016 at 06:11, Marek Olšák wrote: On Fri, Sep 30, 2016 at 4:42 PM, Ilia Mirkin wrote: So is this getting pushed, or should I push my "don't build vdpau for nouveau" patch? Please w

Re: [Mesa-dev] [PATCH] winsys/radeon: add buffer_get_reloc_offset

d for video submissions. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97969 Reviewed-by: Christian König . --- src/gallium/drivers/radeon/radeon_uvd.c | 2 +- src/gallium/drivers/radeon/radeon_vce.c | 2 +- src/gallium/drivers/radeon/radeon_winsys.h| 12

  1   2   3   4   5   6   7   8   9   10   >