Re: [Mesa-dev] [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug

2015-10-17 Thread Charmaine Lee
>From: Brian Paul >Sent: Friday, October 16, 2015 2:25 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Jose Fonseca; Sinclair Yeh >Subject: [PATCH 09/10] vbo: fix GL_LINE_LOOP stray line bug >When long GL_LINE_LOOP primitives don't fit in one vertex buffer

Re: [Mesa-dev] [PATCH] svga: add switch case for PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT

2015-10-20 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Tuesday, October 20, 2015 5:23 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] svga: add switch case for PIPE_SHADER_CAP_MAX_UNROLL_ITERATIONS_HINT A third

Re: [Mesa-dev] [PATCH] svga: fix clip plane regression after recent tgsi_scan change

2015-10-21 Thread Charmaine Lee
A minor nit, please change "num_written_culldistance field was a multiple of four" comment in the commit message to "num_written_clipdistance field was a " Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, October

Re: [Mesa-dev] [PATCH 2/2] svga: use new enum indices_mode type

2015-10-31 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Saturday, October 31, 2015 6:46 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 2/2] svga: use new enum indices_mode type --- src/gallium/drivers/svga

Re: [Mesa-dev] [PATCH] vbo: fix another GL_LINE_LOOP bug

2015-11-04 Thread Charmaine Lee
I concur with Sinclair and Roland that the vbo code is quite tricky. I do have a question, so when the line loop spans multiple vertex buffers, where is 0th vertex stored exactly? In vbo_exec_End, you are changing src = exec->vtx.buffer_map + last_prim->start * exec->vtx.vertex_size; If the 0t

Re: [Mesa-dev] [PATCH] vbo: fix another GL_LINE_LOOP bug

2015-11-04 Thread Charmaine Lee
> >From: Brian Paul >Sent: Wednesday, November 4, 2015 12:03 PM >To: Charmaine Lee; mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] [PATCH] vbo: fix another GL_LINE_LOOP bug >On 11/04/2015 12:40 PM, Charmaine Lee wrote: &

Re: [Mesa-dev] [PATCH 00/11] Gallium common uploaders (v2)

2017-02-09 Thread Charmaine Lee
Series tested with vmware svga driver. Changes looks good. Tested-by: Charmaine Lee From: mesa-dev on behalf of Marek Olšák Sent: Wednesday, February 8, 2017 4:11:01 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH 00/11] Gallium

[Mesa-dev] [PATCH 2/2] st/wgl: flush with ST_FLUSH_WAIT before releasing shared contexts

2017-02-22 Thread Charmaine Lee
Before releasing a shared context, flush the context with ST_FLUSH_WAIT to make sure all commands are executed. This ensures that rendering to any shared resources is completed before they will be referenced by another context. Fixes an intermittent flickering with Photoshop. (VMware bug# 1779340)

[Mesa-dev] [PATCH 1/2] st: add ST_FLUSH_WAIT to st_context_flush()

2017-02-22 Thread Charmaine Lee
When st_context_flush() is called with ST_FLUSH_WAIT, the function will return after the fence is completed. --- src/gallium/include/state_tracker/st_api.h | 1 + src/mesa/state_tracker/st_manager.c| 7 +++ 2 files changed, 8 insertions(+) diff --git a/src/gallium/include/state_tracke

Re: [Mesa-dev] [PATCH] mesa: check for no matrix change in _mesa_LoadMatrixf()

2016-09-15 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, September 15, 2016 8:34 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] mesa: check for no matrix change in _mesa_LoadMatrixf() Some apps issue redundant

Re: [Mesa-dev] [PATCH 2/2] svga: minor simplification in svga_validate_surface_view()

2016-09-21 Thread Charmaine Lee
For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, September 21, 2016 8:25 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 2/2] svga: minor simplification in svga_validate_surface_view() Get rid of

Re: [Mesa-dev] [PATCH 1/8] svga: eliminate unneeded gotos in svga_validate_surface_view()

2016-09-23 Thread Charmaine Lee
>From: Brian Paul >Sent: Friday, September 23, 2016 8:48 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 1/8] svga: eliminate unneeded gotos in >svga_validate_surface_view() >--- > src/gallium/drivers/svga/svga_surface.c | 9 +++-- > 1

Re: [Mesa-dev] [PATCH 1/8] svga: eliminate unneeded gotos in svga_validate_surface_view()

2016-09-23 Thread Charmaine Lee
>From: Brian Paul >Sent: Friday, September 23, 2016 8:48 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 1/8] svga: eliminate unneeded gotos in >svga_validate_surface_view() >--- > src/gallium/drivers/svga/svga_surface.c | 9 +++-- > 1

Re: [Mesa-dev] [PATCH 8/8] st/mesa: small optimization in swizzle_swizzle()

2016-09-23 Thread Charmaine Lee
Series looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, September 23, 2016 8:48 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 8/8] st/mesa: small optimization in swizzle_swizzle() Usually, there&#

Re: [Mesa-dev] [PATCH] svga: remove incorrect buffer invalidation code

2016-08-15 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, August 15, 2016 3:43:22 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: remove incorrect buffer invalidation code Fixes regression with team_fortress_2 trace. This

Re: [Mesa-dev] [PATCH 2/2] svga: fix src/dst typo in can_blit_via_copy_region_vgpu10()

2016-08-17 Thread Charmaine Lee
Series looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, August 17, 2016 7:40:13 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] svga: fix src/dst typo in

Re: [Mesa-dev] [PATCH] svga: s/unsigned/enum pipe_shader_type/

2016-08-29 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, August 29, 2016 9:16:09 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee Subject: [PATCH] svga: s/unsigned/enum pipe_shader_type/ --- src/gallium/drivers/svga/svga_draw.c

Re: [Mesa-dev] [PATCH] svga: minor code improvements in svga_validate_pipe_sampler_view()

2016-10-18 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, October 18, 2016 9:36 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: minor code improvements in svga_validate_pipe_sampler_view() Use the 'texture' lo

Re: [Mesa-dev] [PATCH 6/6] vbo: clean up with 'indent', whitespace fixes, etc in vbo_exec_array.c

2016-10-19 Thread Charmaine Lee
Series looks fine to me. Some minor nit below. Reviewed-by: Charmaine Lee >From: Brian Paul >Sent: Wednesday, October 19, 2016 3:07 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 6/6] vbo: clean up with 'indent', whitespace fixes,

Re: [Mesa-dev] [PATCH] gallium/hud: call fflush() after printing error messages

2016-11-02 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, November 2, 2016 3:08 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] gallium/hud: call fflush() after printing error messages For Windows. Otherwise, we don'

[Mesa-dev] [PATCH] util: fix missing swizzle components in the SINT <-> UINT conversion string

2016-11-22 Thread Charmaine Lee
Fixes tgsi error introduced in commit 3817a7a. The error complains missing swizzle component in the conversion string "UMIN TEMP[0], TEMP[0], IMM[0].x". --- src/gallium/auxiliary/util/u_simple_shaders.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/u

[Mesa-dev] [PATCH] util: fix memory leak from the fragment shaders for SINT <-> UINT blits

2016-11-23 Thread Charmaine Lee
This patch deletes those fragment shaders in util_blitter_destroy(). --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 98b5421..45dc033 100644 --- a/s

Re: [Mesa-dev] [PATCH v3 2/3] svga: Fix a strict-aliasing violation in shader dumper

2016-12-13 Thread Charmaine Lee
Change looks fine to me. Thanks. Reviewed-by: Charmaine Lee From: Roland Scheidegger Sent: Tuesday, December 13, 2016 10:38 AM To: Edward O'Callaghan; mesa-dev@lists.freedesktop.org Cc: Brian Paul; Charmaine Lee Subject: Re: [Mesa-dev] [PATCH v

Re: [Mesa-dev] Mesa commit a5e733c

2016-12-21 Thread Charmaine Lee
>From: Rob Clark >On Wed, Dec 21, 2016 at 12:32 PM, Charmaine Lee wrote: >> >> Hi Rob, >> >> Your mesa commit a5e733c mesa: drop current draw/read buffer when ctx is >> released >> is causing rendering issue when running with vmware svga driver. >

Re: [Mesa-dev] [PATCH 11/16] svga: use copy_region_vgpu10() for region copies when possible

2016-06-29 Thread Charmaine Lee
>From: Brian Paul >Sent: Tuesday, June 28, 2016 4:52 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende; Jose Fonseca; Roland Scheidegger >Subject: [PATCH 11/16] svga: use copy_region_vgpu10() for region copies when >possible > >--- &g

Re: [Mesa-dev] [PATCH 2/2] st/mesa: fix geometry shader memory leak

2014-07-08 Thread Charmaine Lee
Changes looks good. Tested with svga driver. Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Tuesday, July 8, 2014 3:32 PM To: mesa-dev@lists.freedesktop.org Cc: 10.2 Subject: [Mesa-dev] [PATCH 2/2] st/mesa: fix geometry shader

Re: [Mesa-dev] [PATCH] svga: move draw debug code into separate function

2014-04-21 Thread Charmaine Lee
> - case SVGA3D_PRIMITIVE_LINELIST: > -count = range->primitiveCount * 2; > -break; > - case SVGA3D_PRIMITIVE_LINESTRIP: > -count = range->primitiveCount + 1; > -break; > - case SVGA3D_PRIMITIVE_TRIANGLELIST: > -count = range->primitiveCount * 3; > -break; > - case SVGA3D_PRIMITIVE_TRIANGLESTRIP: > -count = range->primitiveCount + 2; > -break; > - case SVGA3D_PRIMITIVE_TRIANGLEFAN: > -count = range->primitiveCount + 2; > -break; > - default: > -assert(0); > -count = 0; > -break; > - } > - > - assert(offset + count * stride <= size); > - } > - } > + check_draw_params(hwtnl, range, min_index, max_index, ib); > #endif > > if (hwtnl->cmd.prim_count + 1 >= QSZ) { > -- > 1.7.10.4 > Reviewed-by: Charmaine Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] svga: clean up the compile_vs/gs/fs() functions

2015-09-10 Thread Charmaine Lee
For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, September 10, 2015 8:04 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH 4/4] svga: clean up the compile_vs/gs/fs() functions Simplify

Re: [Mesa-dev] [PATCH 8/8] mesa: minor clean-up of some memcpy/sizeof() calls in m_matrix.c

2016-01-05 Thread Charmaine Lee
This series looks fine to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, January 4, 2016 4:49 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 8/8] mesa: minor clean-up of some memcpy/sizeof() calls in m_matrix.c

[Mesa-dev] [PATCH 2/3] svga: add num-generate-mipmap HUD query

2016-01-11 Thread Charmaine Lee
The actual increment of the num-generate-mipmap counter will be done in a subsequent patch when hw generate mipmap is supported. --- src/gallium/drivers/svga/svga_context.h| 4 +++- src/gallium/drivers/svga/svga_pipe_query.c | 7 +++ src/gallium/drivers/svga/svga_screen.c | 2 ++ 3 fil

Re: [Mesa-dev] [PATCH] st/mesa: fix incorrect buffer token passed to _mesa_BindFramebuffer()

2016-01-11 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, January 11, 2016 5:24 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Jose Fonseca Subject: [PATCH] st/mesa: fix incorrect buffer token passed to _mesa_BindFramebuffer() I added this

[Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Charmaine Lee
This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. --- src/gallium/docs/source/conte

[Mesa-dev] [PATCH 3/3] svga: add DXGenMips command support

2016-01-11 Thread Charmaine Lee
For those formats that support hw mipmap generation, use the DXGenMips command. Otherwise fallback to the mipmap generation utility. Tested with piglit, OpenGL apps (Heaven, Turbine, Cinebench) --- src/gallium/drivers/svga/svga_cmd.h | 4 ++ src/gallium/drivers/svga/svga_cmd_vgpu10.

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Charmaine Lee
>From: ibmir...@gmail.com on behalf of Ilia Mirkin > >Sent: Monday, January 11, 2016 7:12 PM >To: Charmaine Lee >Cc: mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/st: add >pipe_context::generate_mipmap() >On Mon, Jan 11, 2016 at 9:31

[Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Charmaine Lee
This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. v2: add PIPE_CAP_GENERATE_MIPMAP

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-12 Thread Charmaine Lee
>From: Michel Dänzer >Sent: Monday, January 11, 2016 11:37 PM >To: Charmaine Lee >Cc: mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/st: add >pipe_context::generate_mipmap() >On 12.01.2016 15:18, Charmaine Lee wrote: >> This patch adds

[Mesa-dev] [PATCH v3 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-12 Thread Charmaine Lee
This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. v2: add PIPE_CAP_GENERATE_MIPMAP

[Mesa-dev] [PATCH v4 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-12 Thread Charmaine Lee
This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. v2: add PIPE_CAP_GENERATE_MIPMAP

Re: [Mesa-dev] [PATCH] st/mesa: fix memleak in glDrawPixels cache code

2016-04-12 Thread Charmaine Lee
Looks good to me too. Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Jose Fonseca Sent: Tuesday, April 12, 2016 9:24 AM To: Brian Paul; mesa-dev@lists.freedesktop.org Cc: 11.2 Subject: Re: [Mesa-dev] [PATCH] st/mesa: fix memleak in

Re: [Mesa-dev] [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps()

2016-04-14 Thread Charmaine Lee
Looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, April 14, 2016 2:12 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; 11.1 11.2 Subject: [PATCH] st/mesa: fix sampler view leak in st_DrawAtlasBitmaps() I neglected to

Re: [Mesa-dev] [PATCH] svga: separate HUD counters for state objects

2016-04-15 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, April 15, 2016 2:41 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: separate HUD counters for state objects Count depth/stencil, blend, sampler, etc. state objects

Re: [Mesa-dev] [PATCH] svga: s/Elements/ARRAY_SIZE/

2016-04-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, April 25, 2016 8:48 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: s/Elements/ARRAY_SIZE/ Standardize on the later macro rather than a mix of both. --- src

Re: [Mesa-dev] [PATCH 3/9] draw: use tgsi transform prolog/epilog callbacks in AA point code

2014-09-22 Thread Charmaine Lee
nstruction */ Please remove this comment. It's not relevant in aa_transform_epilog. Reviewed-by: Charmaine Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listin

Re: [Mesa-dev] [PATCH] tgsi: fix Semantic.Name assignment in tgsi_transform_input_decl()

2014-09-30 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Tuesday, September 30, 2014 9:31 AM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] tgsi: fix Semantic.Name assignment in tgsi_transform_input_decl() Assign

Re: [Mesa-dev] [PATCH] st/mesa: use PIPE_BIND_DISPLAY_TARGET when checking for sRGB capability

2014-10-28 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Monday, October 27, 2014 2:04 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [PATCH] st/mesa: use PIPE_BIND_DISPLAY_TARGET when checking for sRGB capability When we&#x

Re: [Mesa-dev] [PATCH 4/7] util: simplify temp register selection in u_pstipple.c

2014-10-31 Thread Charmaine Lee
The series looks good. Just a minor comment below. Reviewed-by: Charmaine Lee >From: mesa-dev on behalf of Brian >Paul >Sent: Thursday, October 30, 2014 8:04 PM >To: mesa-dev@lists.freedesktop.org >Subject: [Mesa-dev] [PATCH 4/7] util: simplify temp register selection in

Re: [Mesa-dev] [PATCH] st/mesa: implement a simple cache for glDrawPixels

2016-02-18 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, February 18, 2016 7:52 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/mesa: implement a simple cache for glDrawPixels Instead of discarding the texture we created

Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

2016-02-18 Thread Charmaine Lee
>From: Brian Paul >Sent: Thursday, February 18, 2016 7:51 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH] svga: allow non-contiguous VS input declarations > >This fixes a glDrawPixels regression since b63fe0552b5f. The new >quad-drawing ut

Re: [Mesa-dev] [PATCH] svga: allow non-contiguous VS input declarations

2016-02-18 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, February 18, 2016 12:30 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: allow non-contiguous VS input declarations This fixes a glDrawPixels regression since

Re: [Mesa-dev] [PATCH 2/3] svga: add new svga_winsys_context::get_command_buffer_size()

2016-02-29 Thread Charmaine Lee
>From: Brian Paul >Sent: Monday, February 29, 2016 1:28 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 2/3] svga: add new >svga_winsys_context::get_command_buffer_size() >To ask how large the current command buffer is. Will be used for >

Re: [Mesa-dev] [PATCH 3/3] svga: add new surface-write-flushes HUD query

2016-03-05 Thread Charmaine Lee
For this series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 4, 2016 5:17 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 3/3] svga: add new surface-write-flushes HUD query To know when we're flushin

Re: [Mesa-dev] [PATCH] st/mesa: 78-column wrapping in st_extensions.c

2016-03-05 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 4, 2016 5:17 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/mesa: 78-column wrapping in st_extensions.c --- src/mesa/state_tracker/st_extensions.c | 175

Re: [Mesa-dev] [PATCH 4/4] st/mesa: clean up st_translate_texture_target()

2016-03-19 Thread Charmaine Lee
For the series: Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, March 16, 2016 5:43 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 4/4] st/mesa: clean up st_translate_texture_target() Reformat code. Improve

Re: [Mesa-dev] [PATCH 11/11] svga: use shader sampler view declarations

2016-03-21 Thread Charmaine Lee
Series looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 18, 2016 4:49 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 11/11] svga: use shader sampler view declarations Previously, we looked at

Re: [Mesa-dev] [PATCH] st/xa: emit sampler view declarations in shaders

2016-03-25 Thread Charmaine Lee
Tested and Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, March 25, 2016 1:08 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/xa: emit sampler view declarations in shaders Fixes recent regressions with the VMware

Re: [Mesa-dev] [PATCH 2/2] svga: fix test for unfilled triangles fallback

2016-05-26 Thread Charmaine Lee
This series looks good to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, May 26, 2016 7:09 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Roland Scheidegger Subject: [PATCH 2/2] svga: fix test for unfilled triangles fallback

Re: [Mesa-dev] [PATCH 2/2] svga: remove unneeded casts in get_query_result_vgpu9() calls

2016-05-26 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, May 26, 2016 5:59 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 2/2] svga: remove unneeded casts in get_query_result_vgpu9() calls --- src/gallium

Re: [Mesa-dev] [PATCH 6/6] llvmpipe: turn on pipe cap for GL_ARB_copy_image support

2016-06-07 Thread Charmaine Lee
For the series: Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, June 7, 2016 12:03 PM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Charmaine Lee Subject: [PATCH 6/6] llvmpipe: turn on pipe cap for GL_ARB_copy_image support --- src

Re: [Mesa-dev] [PATCH] svga: initialize pipe_driver_query_info entries with a macro

2015-12-08 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, December 8, 2015 4:35 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: initialize pipe_driver_query_info entries with a macro To be safe, set all the fields in case

Re: [Mesa-dev] [PATCH] svga: avoid emitting redundant SetIndexBuffer commands

2015-12-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, December 10, 2015 1:09 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Jose Fonseca Subject: [PATCH] svga: avoid emitting redundant SetIndexBuffer commands --- src/gallium/drivers/svga

Re: [Mesa-dev] [PATCH] svga: avoid emitting redundant SetSamplers() commands

2015-12-10 Thread Charmaine Lee
>From: Brian Paul >Sent: Thursday, December 10, 2015 2:05 PM >To: mesa-dev@lists.freedesktop.org >Cc: Jose Fonseca; Charmaine Lee >Subject: [PATCH] svga: avoid emitting redundant SetSamplers() commands >This greatly reduces the number of SetSamplers() commands for some >app

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix prog_optimize.c assertions triggered by SWZ opcode

2014-09-17 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: mesa-dev on behalf of Brian Paul Sent: Wednesday, September 17, 2014 2:56 PM To: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: fix prog_optimize.c assertions triggered by SWZ opcode

Re: [Mesa-dev] [PATCH] gallium: increase pipe_sampler_view::target bitfield size for MSVC

2017-11-01 Thread Charmaine Lee
Nice catch. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, November 1, 2017 7:45:29 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] gallium: increase pipe_sampler_view::target bitfield size for MSVC MSVC treats

Re: [Mesa-dev] [PATCH 1/2] st/mesa: use enum types instead of int/unsigned

2017-11-06 Thread Charmaine Lee
For this series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, November 6, 2017 1:00:30 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 1/2] st/mesa: use enum types instead of int/unsigned Use the proper enum types

Re: [Mesa-dev] [PATCH] st/mesa: Handle st_framebuffer_create returning NULL

2017-07-13 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Michel Dänzer Sent: Thursday, July 13, 2017 12:21 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] st/mesa: Handle st_framebuffer_create returning NULL From: Michel Dänzer

Re: [Mesa-dev] [PATCH] st/mesa: handle stfbi being NULL on entry of st_framebuffer_reuse_or_create

2017-07-13 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Lucas Stach Sent: Thursday, July 13, 2017 10:01 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] st/mesa: handle stfbi being NULL on entry of st_framebuffer_reuse_or_create Apparently

[Mesa-dev] [PATCH] st/mesa: init winsys buffers list only if context creation succeeds

2017-07-17 Thread Charmaine Lee
Fixes piglit test crash when context creation fails. --- src/mesa/state_tracker/st_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 560d94e..8eccad6 100644 --- a/src/mesa/state_track

[Mesa-dev] [PATCH] st/mesa: init winsys buffers list only if context creation succeeds

2017-07-17 Thread Charmaine Lee
Fixes piglit test crash when context creation fails. v2: As suggested by Brian, move the init to st_create_context_priv() --- src/mesa/state_tracker/st_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker

[Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-20 Thread Charmaine Lee
With this patch, the st manager will maintain a hash table for the active framebuffer interface objects. A destroy_drawable interface is added to allow the state tracker to notify the st manager to remove the associated framebuffer interface object from the hash table, so the associated framebuffer

Re: [Mesa-dev] [PATCH] svga: only support 4x, 8x, 16x msaa

2017-07-20 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, July 20, 2017 1:54 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: only support 4x, 8x, 16x msaa Skip 2x MSAA, for example, since it's seldom

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-21 Thread Charmaine Lee
799a1d3 in __libc_start_main () from /usr/lib32/libc.so.6 No symbol table info available. #23 0x5662d159 in _start () No symbol table info available. On 20.07.2017 20:26, Charmaine Lee wrote: > With this patch, the st manager will maintain a hash table for > the active framebuffer inte

[Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table per st manager

2017-07-23 Thread Charmaine Lee
With this patch, framebuffer interface hash table is created per state tracker manager. Fixes crash with steam. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101876 Fixes: 5124bf98239 ("st/mesa: add destroy_drawable interface") Tested-by: Christoph Haag --- src/gallium/include/state_tr

Re: [Mesa-dev] [PATCH 2/2] svga: implement MSAA alpha_to_one feature

2017-07-24 Thread Charmaine Lee
>From: Brian Paul >Sent: Saturday, July 22, 2017 12:24 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende >Subject: [PATCH 2/2] svga: implement MSAA alpha_to_one feature >The device doesn't directly support this feature so we implement it with >ad

Re: [Mesa-dev] [PATCH] st/mesa: add destroy_drawable interface

2017-07-24 Thread Charmaine Lee
Hi Marek, I have pushed the fix for Steam. Commit bbc29393d3beaf6344c7188547b4ff61b63946ae should fix the problem. Can you please try? -Charmaine From: Marek Olšák Sent: Monday, July 24, 2017 3:16:07 PM To: Charmaine Lee Cc: Christoph Haag; mesa-dev

Re: [Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table per st manager

2017-07-25 Thread Charmaine Lee
>From: James Legg >Sent: Tuesday, July 25, 2017 6:24 AM >To: mesa-dev@lists.freedesktop.org; Charmaine Lee >Subject: Re: [Mesa-dev] [PATCH] st/mesa: create framebuffer iface hash table >per st manager >On Sun, 2017-07-23 at 16:37 -0700, Charmaine Lee wrote: >> With

[Mesa-dev] [PATCH] st/mesa: fix the unconditional return in st_framebuffer_iface_remove

2017-07-25 Thread Charmaine Lee
Fixes: bbc29393d3beaf6344c7188547b4ff61b63946ae Tested-by: Christoph Haag --- src/mesa/state_tracker/st_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_manager.c b/src/mesa/state_tracker/st_manager.c index 834bcc9..6447403 100644 --- a/src/

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface hash table per st manager

2017-08-02 Thread Charmaine Lee
Change looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, August 2, 2017 8:30 PM To: Bruce Cherniak; mesa-dev@lists.freedesktop.org Cc: 17 . 2; Charmaine Lee Subject: Re: [Mesa-stable] [PATCH] st/mesa: add osmesa framebuffer iface

Re: [Mesa-dev] [PATCH 1/2] wglgears.c: add -srgb option

2017-04-27 Thread Charmaine Lee
Series looks good. One typo below: >From: Brian Paul >Sent: Thursday, April 27, 2017 10:19 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende >Subject: [PATCH 1/2] wglgears.c: add -srgb option >To test sRGB pixel format selection and sRGB renderi

Re: [Mesa-dev] [PATCH 2/2] wglgears: fix up wglChoosePixelFormatARB() attribute list

2017-05-03 Thread Charmaine Lee
Looks great. For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, May 3, 2017 12:49:40 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] wglgears: fix up wglChoosePixelFormatARB() attribute

Re: [Mesa-dev] [PATCH 3/3] mesa: s/GLint/gl_buffer_index/ for _ColorDrawBufferIndexes

2017-11-09 Thread Charmaine Lee
For this series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, November 9, 2017 11:31:42 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 3/3] mesa: s/GLint/gl_buffer_index/ for _ColorDrawBufferIndexes Also fix

Re: [Mesa-dev] [PATCH] st/mesa: remove 'struct' keyword on function parameter

2017-11-09 Thread Charmaine Lee
Reviewed-by; Charmaine Lee From: Brian Paul Sent: Thursday, November 9, 2017 11:31:16 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] st/mesa: remove 'struct' keyword on function parameter st_src_reg is a class, no

Re: [Mesa-dev] [PATCH] svga: issue debug warning for unsupported two-sided stencil state

2017-11-14 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, November 10, 2017 6:40:26 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: issue debug warning for unsupported two-sided stencil state We only have a single

Re: [Mesa-dev] [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/

2017-11-14 Thread Charmaine Lee
>From: Brian Paul >Sent: Tuesday, November 14, 2017 3:42 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende >Subject: [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/ ... >diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.h >b/src/gallium/auxil

Re: [Mesa-dev] [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases

2017-11-16 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, November 16, 2017 3:36:15 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: add missing PIPE_SHADER_CAP_MAX_HW_ATOMIC_COUNTER* cases --- src/gallium

Re: [Mesa-dev] [PATCH] tgsi: bump tgsi_opcode_info::output_mode size to 4 bits

2017-11-17 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, November 17, 2017 2:40:01 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende; Roland Scheidegger Subject: [PATCH] tgsi: bump tgsi_opcode_info::output_mode size to 4 bits To

Re: [Mesa-dev] [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c

2017-11-21 Thread Charmaine Lee
Series looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Tuesday, November 21, 2017 6:33:22 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] svga: move svga_is_format_supported() to svga_format.c

Re: [Mesa-dev] [PATCH 2/2] draw: check for line_width != 1.0f in validate_pipeline()

2017-06-15 Thread Charmaine Lee
For the series, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, June 15, 2017 10:42:00 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 2/2] draw: check for line_width != 1.0f in validate_pipeline() We

Re: [Mesa-dev] [PATCH] svga: add some missing SVGA_STATS_* enum values, prefix strings

2017-06-16 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, June 16, 2017 12:21 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: add some missing SVGA_STATS_* enum values, prefix strings To fix the build when

Re: [Mesa-dev] [PATCH] svga: add texture size/levels sanity check code in svga_texture_create()

2017-06-28 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, June 28, 2017 3:13 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: add texture size/levels sanity check code in svga_texture_create() The state

Re: [Mesa-dev] [PATCH] wglcontext: assorted updates

2017-07-03 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Sunday, July 2, 2017 8:07 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] wglcontext: assorted updates Print context flags, vendor, renderer strings. Default to not setting the

Re: [Mesa-dev] [PATCH 1/4] svga: fix buffer binding flags initialization

2017-07-03 Thread Charmaine Lee
>From: Brian Paul >Sent: Sunday, July 2, 2017 8:12 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee >Subject: [PATCH 1/4] svga: fix buffer binding flags initialization >If a buffer is created/initialized with glNamedBufferData we will >have no target (GL_ARRAY_BUFF

Re: [Mesa-dev] [PATCH 1/3] st/mesa: find proper mipmap level in st_ClearTexSubImage()

2017-07-06 Thread Charmaine Lee
st_texture_object(texObj)->pt); >+ level = texImage->Level + texObj->MinLevel; >+ box.z += texObj->MinLayer; > } >+ else { >+ /* Texture level sizes may be inconsistent. We my have "loose", >+ * per-image gallium resources. The texImage->Level may not match >+ * the gallium resource texture level. >+ */ >+ level = find_mipmap_level(texImage, pt); >+ } >+ >+ assert(level <= pt->last_level); > pipe->clear_texture(pipe, pt, level, &box, clearValue ? clearValue >: zeros); > } >-- >1.9.1 Series looks good to me. Reviewed-by: Charmaine Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/mesa: remove unused st_framebuffer::Private field

2017-07-07 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, July 7, 2017 7:11 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] st/mesa: remove unused st_framebuffer::Private field --- src/mesa/state_tracker

Re: [Mesa-dev] [PATCH 3/3] vbo: rename target->index in loopback code

2017-07-07 Thread Charmaine Lee
Series looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Friday, July 7, 2017 7:11 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 3/3] vbo: rename target->index in loopback code Because it's

Re: [Mesa-dev] [PATCH] svga: adjust line subpixel position for HWv8

2017-07-07 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, July 5, 2017 7:56 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: adjust line subpixel position for HWv8 This fixes two regressions on HWv8

Re: [Mesa-dev] [PATCH 2/2] mesa: finish implementing glPrimitiveRestartNV() for display lists

2017-07-07 Thread Charmaine Lee
>From: Brian Paul >Sent: Friday, July 7, 2017 7:10 AM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende; Olivier Lauffenburger >Subject: [PATCH 2/2] mesa: finish implementing glPrimitiveRestartNV() for >display lists >If we try to build a dis

Re: [Mesa-dev] [PATCH] svga: fix breakage in create_backed_surface_view()

2017-07-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Sunday, July 9, 2017 1:00 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: fix breakage in create_backed_surface_view() This fixes a regression in some piglit tests since

Re: [Mesa-dev] [PATCH] svga: fix PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE value

2017-07-10 Thread Charmaine Lee
Reviewed-by :Charmaine Lee From: Brian Paul Sent: Monday, July 10, 2017 7:40 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; mesa-sta...@lists.freedesktop.org Subject: [PATCH] svga: fix PIPE_CAP_MAX_TEXTURE_BUFFER_SIZE value This query is

Re: [Mesa-dev] [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/

2017-07-10 Thread Charmaine Lee
Series looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, July 10, 2017 2:50:25 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 5/5] svga: s/unsigned/enum tgsi_texture_type/ --- src/gallium

[Mesa-dev] [PATCH] st/mesa: add a winsys buffers list in st_context

2017-07-11 Thread Charmaine Lee
Commit a5e733c6b52e93de3000647d075f5ca2f55fcb71 fixes the dangling framebuffer object by unreferencing the window system draw/read buffers when context is released. However this can prematurely destroy the resources associated with these window system buffers. The problem is reproducible with Turbi

  1   2   >