Re: [Mesa-dev] [PATCH v4 24/34] i965/gen8: Use the generic ISL-based path for texture surfaces

2016-07-15 Thread Chad Versace
On Wed 13 Jul 2016, Jason Ekstrand wrote: > Reviewed-by: Topi Pohjolainen > --- Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 1/7] egl/android: Remove unused variables in droid_get_buffers_with_format()

2016-08-02 Thread Chad Versace
On 08/02/2016 04:07 AM, Tomasz Figa wrote: Fix compilation warnings due to unused variables left after some earlier code changes. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 3 --- 1 file changed, 3 deletions(-) Reviewed-by: Chad Versace

Re: [Mesa-dev] [PATCH v2 2/7] egl/android: Respect buffer mask in droid_image_get_buffers (v2)

2016-08-02 Thread Chad Versace
of unavailable buffers. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev

Re: [Mesa-dev] [PATCH v2 4/7] egl/android: Refactor image creation to separate flink and prime paths (v2)

2016-08-02 Thread Chad Versace
-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Chad Versace
On 08/02/2016 04:17 PM, Haixia Shi wrote: We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.grau...@intel.com Cc: Chad Versace Change

Re: [Mesa-dev] [PATCH] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Chad Versace
On 08/02/2016 04:35 PM, Chad Versace wrote: On 08/02/2016 04:17 PM, Haixia Shi wrote: We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.g

Re: [Mesa-dev] [PATCH v2] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-02 Thread Chad Versace
On 08/02/2016 05:03 PM, Haixia Shi wrote: We need to include mt->offset in the calculation of src pointer because its value may be non-zero, for example in a cubemap texture. Signed-off-by: Haixia Shi Cc: Jason Ekstrand Cc: kenneth.w.grau...@intel.com Cc: Chad Versace Change

Re: [Mesa-dev] [PATCH v2] i965: use mt->offset in intel_miptree_map_movntdqa().

2016-08-03 Thread Chad Versace
Cc: kenneth.w.grau...@intel.com Cc: Chad Versace Change-Id: I461ad5b204626d5a1c45611fc6b63735dcf29f63 --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Kenneth Graunke And pushed. hshi, for future reference, small bugfix patches like this

Re: [Mesa-dev] non-shared glapi still needed ?

2016-08-03 Thread Chad Versace
On 08/02/2016 06:40 PM, Enrico Weigelt, metux IT consult wrote: Hi folks, is there still a real need for having non-shared glapi ? Otherwise, should we remove it ? +1 I have the same question. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

[Mesa-dev] [PATCH 2/2] i965: Respect miptree offsets in intel_readpixels_tiled_memcpy()

2016-08-04 Thread Chad Versace
Respect intel_miptree_slice::x_offset,y_offset and intel_mipmap_tree::offset. All three may be non-zero when glReadPixels is called on an EGLImage created from the non-base slice of a miptree. Patch 2/2 that fixes test 'dEQP-EGL.functional.image.create.gles2_cubemap_*'. Reported-by: Haixia Shi D

[Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

2016-08-04 Thread Chad Versace
Hi Intel folks, could one of you please run this through Jenkins? I verified manually that it fixes the listed dEQP tests on Skylake. Chad Versace (2): i965: Fix miptree layout for EGLImage-based renderbuffers i965: Respect miptree offsets in intel_readpixels_tiled_memcpy() src/mesa/drivers

[Mesa-dev] [PATCH 1/2] i965: Fix miptree layout for EGLImage-based renderbuffers

2016-08-04 Thread Chad Versace
When glEGLImageTargetRenderbufferStorageOES() was given an EGLImage created from the non-base slice of a miptree, intel_image_target_renderbuffer_storage() forgot to apply the intra-tile offsets __DRIimage::tile_x,tile_y to the miptree layout. This patch fixes the problem with a quick hack suitabl

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

2016-08-04 Thread Chad Versace
On 08/04/2016 02:24 PM, Mark Janes wrote: I saw no regressions from these tests. However, I wasn't able to run the dEQP-EGL tests the last time I tried. What branch of dEQP are you running? InternalError (Runtime check failed: '(m_capabilities & CAPABILITY_GET_DISPLAY_PLATFORM) == 0' at

Re: [Mesa-dev] [PATCH 0/2] i965: Fix dEQP-EGL.functional.image.create.gles2_cubemap_*

2016-08-04 Thread Chad Versace
On 08/04/2016 02:28 PM, Martin Peres wrote: On 05/08/16 00:24, Mark Janes wrote: I saw no regressions from these tests. However, I wasn't able to run the dEQP-EGL tests the last time I tried. What branch of dEQP are you running? InternalError (Runtime check failed: '(m_capabilities &

Re: [Mesa-dev] [PATCH 2/9] i965: Totally switch around how we handle nonzero baselevel-first_level.

2013-09-27 Thread Chad Versace
doesn't regress Piglit. Patch 2 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/9] i965: Always look up from the object's mt when setting up texturing state.

2013-09-27 Thread Chad Versace
e->mt->first_level)); + (intelObj->_MaxLevel - mt->first_level)); if (brw->is_haswell) { /* Handling GL_ALPHA as a surface format override breaks 1.30+ style There is hunk in patch 6 that should be paired with this hunk. Move it and pat

Re: [Mesa-dev] [PATCH 4/9] i965: Stop allocating miptrees with first_level != 0.

2013-09-27 Thread Chad Versace
s/dri/i965/intel_tex_image.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) I like patches 3 and 4. They make the teximage and miptree code cleaner and easier to reason about. They are Reviewed-by: Chad Versace ___ mesa-dev mailing lis

Re: [Mesa-dev] [PATCH 5/9] i965: Don't allocate a 1-level texture when GL_GENERATE_MIPMAP is set.

2013-09-27 Thread Chad Versace
base.Base.Level == 0 && + !intelObj->base.GenerateMipmap) { lastLevel = 0; } else { lastLevel = _mesa_get_tex_max_num_levels(intelObj->base.Target, Simple enough. Reviewed-by: Chad Versace ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH 6/9] i965: Don't relayout a texture just for baselevel changes.

2013-09-27 Thread Chad Versace
On 09/18/2013 12:59 PM, Eric Anholt wrote: As long as the baselevel, maxlevel still sit inside the range we had previously validated, there's no need to reallocate the texture. I also hope this makes our texture validation logic much more obvious. It's taken me enough tries to write this change,

Re: [Mesa-dev] [PATCH 7/9] i965: Always allocate validated miptrees from level 0.

2013-09-27 Thread Chad Versace
please. The possibility of mt->first_level != 0 always confuses me. One less occurrence is welcome. Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 8/9] i965: Add missing license to intel_tex_validate.c.

2013-09-27 Thread Chad Versace
On 09/18/2013 12:59 PM, Eric Anholt wrote: I've rewritten a lot of this file. --- src/mesa/drivers/dri/i965/intel_tex_validate.c | 23 +++ 1 file changed, 23 insertions(+) Reviewed-by: Chad Versace ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 9/9] i965: Add a real native TexStorage path.

2013-09-27 Thread Chad Versace
ureImageBuffer = intel_free_texture_image_buffer; + functions->AllocTextureStorage = intel_alloc_texture_storage; functions->MapTextureImage = intel_map_texture_image; functions->UnmapTextureImage = intel_unmap_texture_image; } Fix the stray printf and patch 9 is Reviewed-by

Re: [Mesa-dev] [PATCH] i965/blorp: retype destination register for texture SEND instruction to UW.

2013-09-30 Thread Chad Versace
I don't understand all the details, but I did confirm that it pacified the simulator. Acked-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/blorp: Use passed in framebuffer rather than ctx->DrawBuffer

2013-09-30 Thread Chad Versace
tions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] Use -Bsymbolic when linking libEGL.so

2013-09-30 Thread Chad Versace
Reviewed-by: Eric Anholt Ditto. Please put in stable. Reviewed-by: Chad Versace Having given my r-b though... we need to alert the Wayland folks to this change. Recent libEGL symbol changes have had unforseen consequences on the Wayland stack. ALERT! Kristian and Joe, we will start building libEGL w

Re: [Mesa-dev] [PATCH] i965/gs: Fix incorrect numbering of DWORDs in 3DSTATE_GS

2013-09-30 Thread Chad Versace
. --- src/mesa/drivers/dri/i965/gen7_gs_state.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] [v4] i965: Use IVB specific formula for depthbuffer

2013-10-01 Thread Chad Versace
ory saved is 1/8 of the original buffer size. Therefore the new buffer size is 7/8 the original size." But, I know the truth is something else. I can recalculate the average again if requested. CC: Chad Versace Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67564 Signed-off-

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-01 Thread Chad Versace
e was used, when we really only needed the region. This allows an upcoming patch to simply allocate the region, and not the whole miptree. v2: Don't use intel_region. Instead use bo + stride. We actually do store the stride in libdrm, but it is inaccessible in the current libdrm version. C

[Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-01 Thread Chad Versace
e same for 3DSTATE_DEPTH_BUFFER, because the hw docs say so. No Piglit regressions (-x glx) on Ivybridge with Wayland. CC: Paul Berry CC: Jordan Justen CC: Ben Widawsky Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/gen7_blorp.cpp| 3 --- src/mesa/drivers/dri/i965/gen7_misc_state.c | 5

Re: [Mesa-dev] [PATCH] i965: extend fast texture upload

2013-10-01 Thread Chad Versace
Ping. Frank, I'm just pinging you because it's been six days since we've corresponded. Just a reminder in case the last message got lost in an email flood. On 09/25/2013 10:18 AM, Chad Versace wrote: On 07/22/2013 03:54 PM, Frank Henigman wrote:> Extend the fast texture u

Re: [Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER

2013-10-02 Thread Chad Versace
On 10/02/2013 10:48 AM, Eric Anholt wrote: Chad Versace writes: In 3DSTATE_DEPTH_BUFFER, we set Width and Height to the miptree slice's physical dimensions. (Logical and physical dimensions may differ for multisample surfaces). However, in SURFACE_STATE, we always set Width and Height t

[Mesa-dev] [PATCH] gen7: Use logical, not physical, dims in 3DSTATE_DEPTH_BUFFER (v2)

2013-10-02 Thread Chad Versace
e same for 3DSTATE_DEPTH_BUFFER, because the hw docs say so. No Piglit regressions (-x glx -x glean) on Ivybridge with Wayland. v2: No Piglit regressions, for real this time. CC: Jordan Justen CC: Eric Anholt Signed-off-by: Chad Versace --- My first patch was garbage. It segfaulted in gen7_misc_state.c an

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-03 Thread Chad Versace
On 10/01/2013 04:36 PM, Ben Widawsky wrote: On Tue, Oct 01, 2013 at 01:06:02PM -0700, Chad Versace wrote: On 09/30/2013 12:35 PM, Ben Widawsky wrote: Starting with Ivybridge, the hierarchical had relaxed requirements for its allocation. Following a "simple" formula in the bspec w

Re: [Mesa-dev] [PATCH 1/2] [v2] i965: Extract region use from hiz depth buffer

2013-10-03 Thread Chad Versace
On 10/01/2013 04:48 PM, Ben Widawsky wrote: On Tue, Oct 01, 2013 at 01:06:02PM -0700, Chad Versace wrote: On 09/30/2013 12:35 PM, Ben Widawsky wrote: diff --git a/src/mesa/drivers/dri/i965/gen6_blorp.cpp b/src/mesa/drivers/dri/i965/gen6_blorp.cpp index da523e5..fc3a331 100644 --- a/src/mesa

[Mesa-dev] [PATCH] doxygen: Generate Doxygen for i965

2013-10-04 Thread Chad Versace
Now, one can do the following to generate and read the i965 Doxygen: cd $MESA_TOP/doxygen make firefox i965/index.html CC: Frank Henigman Signed-off-by: Chad Versace --- doxygen/.gitignore | 1 + doxygen/Makefile | 3 ++- doxygen/i965.doxy | 50

Re: [Mesa-dev] [PATCH 0/6] Support for 10 bpc EGLSurface

2013-10-07 Thread Chad Versace
On 09/15/2013 12:16 AM, Kristian Høgsberg wrote: Hi, This little series adds support for creating EGLSurfaces with color buffers using the ARGB2101010 pixel format. We the new KMS addFB2 ioctl we can create KMS framebuffers with that format and this series ends up adding the pixel format to gbm

Re: [Mesa-dev] [PATCH 7/7] i965/blorp: Allow format conversions.

2013-10-08 Thread Chad Versace
w_blorp_surface_info::set(). +*/ + if ((src_mt->format == MESA_FORMAT_X8_Z24) ^ + (dst_mt->format == MESA_FORMAT_X8_Z24)) { + return false; + } With Daniel's little fix, this series is Reviewed-by: Chad Versace ___

Re: [Mesa-dev] [PATCH 3/3] i965: Fix 3D texture layout by more literally copying from the spec.

2013-10-08 Thread Chad Versace
On 10/08/2013 10:36 AM, Eric Anholt wrote: Fixes 3 texelFetch tests in piglit all.tests. Cc: "9.1 9.2" --- src/mesa/drivers/dri/i965/brw_tex_layout.c | 72 +++--- 1 file changed, 17 insertions(+), 55 deletions(-) Patch 3/3 is Reviewed-by: Chad Ve

Re: [Mesa-dev] [PATCH 1/3] i965: Don't forget the cube map padding on gen5+.

2013-10-08 Thread Chad Versace
src/mesa/drivers/dri/i965/brw_tex_layout.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) Patches 1 and 2 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] thunderbird / firefox segfault with recent

2013-10-08 Thread Chad Versace
On 10/08/2013 12:51 AM, Knut Petersen wrote: Hi everybody! I see lines like [ 362.708791] thunderbird-bin[1888]: segfault at 8 ip b0f3f3aa sp bf93fd54 error 4 in i915_dri.so[b0a02000+fc] [ 846.063129] firefox[2008]: segfault at 8 ip b0af63aa sp bff96c74 error 4 in i915_dri.so[b05b9000+f

[Mesa-dev] Requesting feedback on disallowing handle attribute values in EGLint attribute lists

2013-10-09 Thread Chad Versace
Khronos is proposing a change affecting EGL attribute lists, and they are requesting feedback on this forum thread [1]. They have specifically requested feedback from the opensource community. [1] http://www.khronos.org/message_boards/showthread.php/9138-Requesting-feedback-on-disallowing-handle

Re: [Mesa-dev] [PATCH 2/2] i965: Use IVB specific formula for depthbuffer

2013-10-09 Thread Chad Versace
Chad) Change comments to quote PRM more explicitly (Chad) Use mt->logical_depth0 instead of mt->level[i].depth (Chad) Kill TODO about compressed depth textures (Chad) Use target_to_target (Chad) Add missing GL_TEXTURE_1D, and GL_TEXTURE_CUBE_MAP cases Remove X tiled fallback (Chad) CC: Chad V

Re: [Mesa-dev] [PATCH 1/2] i965: Extract region use from hiz depth buffer

2013-10-09 Thread Chad Versace
mmit message to read better (Matt) Use hiz_buffer.stride instead of hiz_region.pitch Kill temporary depth_mt variable. memset the temporary region variable (Chad) CC: Chad Versace Signed-off-by: Ben Widawsky Patch 1 is Reviewed-by: Chad Versace ___ m

Re: [Mesa-dev] [PATCH 2/2] i965: Use IVB specific formula for depthbuffer

2013-10-09 Thread Chad Versace
On 10/09/2013 03:14 PM, Ian Romanick wrote: On 10/09/2013 02:49 PM, Chad Versace wrote: On 10/08/2013 04:27 PM, Ben Widawsky wrote: + } + hz_height /= 2; + break; + default: + perf_debug("Unknown depthbuffer texture type (%d).", mt->target); I thought I com

Re: [Mesa-dev] [PATCH v2] i965: extend fast texture upload

2013-10-10 Thread Chad Versace
On 10/07/2013 06:17 PM, Frank Henigman wrote: Extend the fast texture upload from BGRA X-tiled to include RGBA, Alpha/Luminance, and Y-tiled. Speed improvements, measured with mesa demos teximage program, on 256 x 256 texture, in MB/s, on a Sandy Bridge (Ivy is comparable): befor

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Chad Versace
Paul, nice work! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Documentation plan: request for comments

2013-10-11 Thread Chad Versace
On 10/10/2013 01:38 AM, Rogovin, Kevin wrote: Hello all, My current goal is to add documentation to Mesa so that the ramp up time of Mesa goes down a great deal. I support that goal. When I see other projects that publish good Doxygen documentation, like http://llvm.org/doxygen/modules.ht

Re: [Mesa-dev] [PATCH 1/3] just change doxy-directory

2013-10-11 Thread Chad Versace
On 10/07/2013 11:00 PM, Kevin Rogovin wrote: really change the doxygen files swrast, tnl and tnl_dd added In the commit message, please explain what the patch is tries to accomplish and how it accomplishes it. Also, each patch should do just one thing. This patch should be separated into one t

[Mesa-dev] Doxygen published online, updated every 4 hours

2013-10-11 Thread Chad Versace
Tom asked me to do this, and it should also help Kevin. I am building Mesa's Doxygen from master every four hours and publishing it here: http://people.freedesktop.org/~chadversary/mesa/doxygen/ It doesn't look very nice. It's incomplete. It's not cross-referenced as well as it should be. If it

Re: [Mesa-dev] EXT_image_dma_buf_import FD ownership

2013-10-11 Thread Chad Versace
On 10/11/2013 03:29 PM, John Sheu wrote: Hello folks: About the ownership of dmabuf file descriptors that are passed into EGL. I'm looking in particular at this blurb from the spec: * If is EGL_LINUX_DMA_BUF_EXT and eglCreateImageKHR fails, EGL does not retain ownership of

Re: [Mesa-dev] EXT_image_dma_buf_import FD ownership

2013-10-11 Thread Chad Versace
On 10/11/2013 06:06 PM, John Sheu wrote: On Fri, Oct 11, 2013 at 5:54 PM, Chad Versace wrote: Yes. Let's update the spec to have a saner interface before we lose a handle on all the consumers. Sweet. To my knowledge, there exists only two implementations. ARM ships an implementatio

Re: [Mesa-dev] [PATCH] i965: add XRGB to fast texture upload

2013-10-11 Thread Chad Versace
(texImage->TexFormat == MESA_FORMAT_XRGB)) { cpp = 4; if (format == GL_BGRA) { mem_copy = memcpy; Looks good to me. Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://l

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-11 Thread Chad Versace
On 10/11/2013 10:17 AM, Courtney Goeltzenleuchter wrote: Support all levels of a supported texture format. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src

[Mesa-dev] [PATCH 0/2] egl: Enable EGL_EXT_client_extensions

2013-10-12 Thread Chad Versace
The extension is simple, and the implementation is simple. This little series lives on my egl-ext-client-extensions branch. I tested it with my Piglit branch of the same name. Chad Versace (2): egl: Kill macro _EGL_DECLARE_MUTEX egl: Enable EGL_EXT_client_extensions src/egl/main/eglapi.c

[Mesa-dev] [PATCH 1/2] egl: Kill macro _EGL_DECLARE_MUTEX

2013-10-12 Thread Chad Versace
abstraction obscured rather than helped. Signed-off-by: Chad Versace Signed-off-by: Chad Versace --- src/egl/main/eglcurrent.c | 2 +- src/egl/main/egldriver.c | 2 +- src/egl/main/eglglobals.c | 3 ++- src/egl/main/eglmutex.h | 4 src/egl/main/eglscreen.c | 2 +- 5 files changed, 5

[Mesa-dev] [PATCH 2/2] egl: Enable EGL_EXT_client_extensions

2013-10-12 Thread Chad Versace
izing the _egl_global::ClientExtension* fields. Signed-off-by: Chad Versace --- src/egl/main/eglapi.c | 8 +++- src/egl/main/eglglobals.c | 7 +++ src/egl/main/eglglobals.h | 7 +++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/egl/main/eglapi.c b/src/egl

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Chad Versace
On 10/13/2013 08:33 PM, Ian Romanick wrote: On 10/13/2013 01:50 PM, Frank Henigman wrote: On Fri, Oct 11, 2013 at 10:00 PM, Chad Versace wrote: On 10/11/2013 10:17 AM, Courtney Goeltzenleuchter wrote: Support all levels of a supported texture format. --- src/mesa/drivers/dri/i965

Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-14 Thread Chad Versace
On 10/14/2013 10:54 AM, Eric Anholt wrote: Courtney Goeltzenleuchter writes: Does anyone know of a test that measures frame 0 time? Or texture upload speed? For Smokin' Guns, I tried measuring the overall time, but an improved frame 0 time has difficulty standing out of a 2607 frame test. I

Re: [Mesa-dev] [PATCH 09/15] i965: Build the driver into a shared mesa_dri_drivers.so .

2013-10-16 Thread Chad Versace
On 10/11/2013 06:03 PM, Eric Anholt wrote: Previously, we've split things such that mesa core is in libdricore, exposing the whole Mesa core interface in the global namespace, and the i965_dri.so code all links against that. Along with polluting application namespace terribly, it requires extra

Re: [Mesa-dev] [PATCH 06/15] gbm: Add support for the new __driDriverGetExtensions interface.

2013-10-16 Thread Chad Versace
Patches 1-6 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 07/15] dri: Pass in the dlsym()ed driver extension to screen creation.

2013-10-16 Thread Chad Versace
On 10/11/2013 06:03 PM, Eric Anholt wrote: This will allow a megadrivers build to reference the actual driver being loaded from the shared dri_util screen creation code. Clever, but not too clever. Reviewed-by: Chad Versace ___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 08/15] dri: Implement a DRI vtable extension to replace the global driDriverAPI.

2013-10-16 Thread Chad Versace
Patch 8 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 09/15] i965: Build the driver into a shared mesa_dri_drivers.so .

2013-10-16 Thread Chad Versace
The bits about globalDriverAPI and megadriver_stub.c feel strongly logically disjoint from the rest of the patch. And, they really aren't related to i965. It looks like they should get separated out into a separate patch the immediately precedes this one. Also, as I said in my first reply, this p

[Mesa-dev] Publishing Doxygen to mesa3d.org

2013-10-18 Thread Chad Versace
Brian, I'm automatically generating Mesa Doxygen from master every 4 hours and publishing it here: http://people.freedesktop.org/~chadversary/mesa/doxygen/master Is there any chance I can start pushing this to the Mesa site instead? ___ mesa-dev maili

Re: [Mesa-dev] Documentation plan: request for comments

2013-10-18 Thread Chad Versace
On 10/18/2013 01:43 PM, Paul Berry wrote: On 11 October 2013 14:40, Chad Versace mailto:chad.vers...@linux.intel.com>> wrote: On 10/10/2013 01:38 AM, Rogovin, Kevin wrote: Hello all, My current goal is to add documentation to Mesa so that the ramp up time of Mes

[Mesa-dev] [PATCH 1/2] i965: Fix glTexImage when packing alignment != cpp

2013-10-21 Thread Chad Versace
70435 Signed-off-by: Chad Versace --- This series lives on my branch bug-70435. Kristian verified that it fixed weston-terminal. src/mesa/drivers/dri/i965/intel_tex_subimage.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri

[Mesa-dev] [PATCH 2/2] i965: Print more debuginfo in intel_texsubimage_memcpy()

2013-10-21 Thread Chad Versace
Print info about packing, format, type, and tiling. This will help debug future issues with this fastpath. CC: Frank Henigman Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa

[Mesa-dev] [PATCH] egl: Enable EGL_EXT_client_extensions

2013-10-21 Thread Chad Versace
Insert two fields into _egl_global to hold the client extensions and statically initialize them: ClientExtensions // a struct of bools ClientExtensionString Post-patch, Mesa supports exactly one client extension, EGL_EXT_client_extensions. Signed-off-by: Chad Versace --- src/egl/main

Re: [Mesa-dev] [PATCH] egl_dri2: Don't use gbm_dri_device when its not there

2013-10-22 Thread Chad Versace
I'm unsure if it makes sense to build EGL with Wayland support but without GBM support. That is, to configure Mesa with --with-egl-platforms=wayland # no drm Also, the patch is corrupt. `git am` is unable to apply it. Did you copy-paste the patch into your email client? Instead, use `git send

Re: [Mesa-dev] [PATCH 09/15] i965: Build the driver into a shared mesa_dri_drivers.so .

2013-10-24 Thread Chad Versace
On 10/23/2013 11:35 AM, Eric Anholt wrote: Chad Versace writes: The bits about globalDriverAPI and megadriver_stub.c feel strongly logically disjoint from the rest of the patch. And, they really aren't related to i965. It looks like they should get separated out into a separate patc

Re: [Mesa-dev] [PATCH 09/15] i965: Build the driver into a shared mesa_dri_drivers.so .

2013-10-24 Thread Chad Versace
On 10/23/2013 11:31 AM, Eric Anholt wrote: Chad Versace writes: On 10/11/2013 06:03 PM, Eric Anholt wrote: Previously, we've split things such that mesa core is in libdricore, exposing the whole Mesa core interface in the global namespace, and the i965_dri.so code all links against

Re: [Mesa-dev] [PATCH] android: add megadriver_stub

2013-10-29 Thread Chad Versace
On 10/28/2013 04:29 PM, Emil Velikov wrote: On 28/10/13 08:07, Adrian Negreanu wrote: From: Adrian Negreanu Fixes linker error: ld: .../libmesa_dri_common_intermediates/libmesa_dri_common.a(dri_util.o): in function globalDriverAPI:dri_util.c(.data.rel+0x0): error: undefined reference

Re: [Mesa-dev] Interesting i965 behavior: more fast color clears not helping dota2

2013-10-30 Thread Chad Versace
On 10/30/2013 06:43 AM, Paul Berry wrote: On 30 October 2013 00:00, Eric Anholt wrote: One of the things I was wondering about for dota2 performance was whether missing the fast clears was a big performance hit -- particularly with the fips numbers indicating a lot of time spent in clears. Ho

Re: [Mesa-dev] [PATCH] wayland: silence unused var warning

2013-10-30 Thread Chad Versace
Thanks, patch is committed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Tagging the 10.0 fork for git-describe

2013-10-30 Thread Chad Versace
For the sake of git-describe, I propose we tag the 10.0 fork point on master as 'mesa-10.0-fork', 'mesa-10.0-base', or something similair. How do people feel about that? It's been a long time since git-describe has given useful info. It's reported snb-magic for a long time. $ git-describ

Re: [Mesa-dev] Tagging the 10.0 fork for git-describe

2013-10-31 Thread Chad Versace
On 10/30/2013 02:16 PM, Paul Berry wrote: On 30 October 2013 14:13, Ian Romanick wrote: On 10/30/2013 01:01 PM, Chad Versace wrote: For the sake of git-describe, I propose we tag the 10.0 fork point on master as 'mesa-10.0-fork', 'mesa-10.0-base', or something similair

Re: [Mesa-dev] [PATCH] i965: Fix compiler warning.

2013-10-31 Thread Chad Versace
+Ken, because he has fought the dragons of GLboolean and know where lie the invisible dragons. On 10/30/2013 02:58 PM, Courtney Goeltzenleuchter wrote: fix: intel_screen.c:1320:4: warning: initialization from incompatible pointer type [enabled by default] --- src/mesa/drivers/dri/i965/brw_cont

[Mesa-dev] [PATCH 1/2] dri: Add driconf option clamp_max_samples

2013-10-31 Thread Chad Versace
This clamps GL_MAX_SAMPLES to the given value. If negative, then no clamping occurs. This patch adds the option, but no driver respects it yet. CC: Eric Anholt Signed-off-by: Chad Versace --- This little series lives on my driconf-clamp-max-samples branch. src/mesa/drivers/dri/common

[Mesa-dev] [PATCH 2/2] i965: Respect driconf option clamp_max_samples

2013-10-31 Thread Chad Versace
Clamp gen7 GL_MAX_SAMPLES to 0, 4, or 8. Clamp gen6 GL_MAX_SAMPLES to 0 or 4. Clamp other gens to 0. CC: Eric Anholt Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_context.c | 35 +++- src/mesa/drivers/dri/i965/intel_screen.c | 1 + 2 files changed

Re: [Mesa-dev] [PATCH 1/2] dri: Add driconf option clamp_max_samples

2013-11-01 Thread Chad Versace
+Eric, because I misspelled your email address in the CC list. On 10/31/2013 06:36 PM, Chad Versace wrote: This clamps GL_MAX_SAMPLES to the given value. If negative, then no clamping occurs. This patch adds the option, but no driver respects it yet. CC: Eric Anholt Signed-off-by: Chad

Re: [Mesa-dev] [PATCH 1/2] dri: Add driconf option clamp_max_samples

2013-11-02 Thread Chad Versace
On 11/01/2013 02:37 PM, Paul Berry wrote: On 31 October 2013 18:36, Chad Versace wrote: This clamps GL_MAX_SAMPLES to the given value. If negative, then no clamping occurs. This patch adds the option, but no driver respects it yet. Do you plan to implement support for this option in all

Re: [Mesa-dev] [PATCH 2/2] i965: Respect driconf option clamp_max_samples

2013-11-02 Thread Chad Versace
On 11/01/2013 02:37 PM, Paul Berry wrote: On 31 October 2013 18:36, Chad Versace wrote: Clamp gen7 GL_MAX_SAMPLES to 0, 4, or 8. Clamp gen6 GL_MAX_SAMPLES to 0 or 4. Clamp other gens to 0. CC: Eric Anholt Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_context.c | 35

[Mesa-dev] [PATCH] i965: Add driconf option clamp_max_samples

2013-11-02 Thread Chad Versace
This clamps GL_MAX_SAMPLES to the given value. If negative, then no clamping occurs. CC: Paul Berry CC: Eric Anholt Signed-off-by: Chad Versace --- This patch lives on my branch driconf-clamp-max_samples. src/mesa/drivers/dri/i965/brw_context.c | 41 src

Re: [Mesa-dev] [PATCH] i965: Add driconf option clamp_max_samples

2013-11-03 Thread Chad Versace
On 11/02/2013 12:21 PM, Kenneth Graunke wrote: On 11/02/2013 08:41 AM, Chad Versace wrote: This clamps GL_MAX_SAMPLES to the given value. If negative, then no clamping occurs. CC: Paul Berry CC: Eric Anholt Signed-off-by: Chad Versace --- This patch lives on my branch driconf-clamp

[Mesa-dev] [PATCH] i965: Add driconf option clamp_max_samples (v3)

2013-11-03 Thread Chad Versace
for clamp_max_samples < 0. v3: (for Ken) - Don't allow clamp_max_samples to alter context version. - Use clearer for-loop and correct comment. - Rename variables. CC: Paul Berry CC: Eric Anholt CC: Kenneth Graunke Signed-off-by: Chad Versace --- This patch lives on my dricon

Re: [Mesa-dev] [PATCH] i965: Add driconf option clamp_max_samples (v3)

2013-11-03 Thread Chad Versace
On 11/03/2013 02:50 PM, Kenneth Graunke wrote: On 11/03/2013 01:51 PM, Chad Versace wrote: The new option clamps GL_MAX_SAMPLES to a hardware-supported MSAA mode. If negative, then no clamping occurs. v2: (for Paul) - Add option to i965 only, not to all DRI drivers. - Do not realy on int

Re: [Mesa-dev] [PATCH] i965: Fix context initialization after 2f896627175384fd5

2013-11-04 Thread Chad Versace
n (int[]){4, 0}; + return gen6_samples; } else { - return (int[]){0}; + return gen4_samples; } } Reviewed-by: Chad Versace http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Let driconf clamp_max_samples affect context version

2013-11-04 Thread Chad Versace
Chromium when clamp_max_samples=0. CC: Eric Anholt CC: Kenneth Graunke Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/brw_context.c | 66 - 1 file changed, 24 insertions(+), 42 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mes

Re: [Mesa-dev] [PATCH 10/37] mesa/program: move source files list to Makefile.sources

2013-11-05 Thread Chad Versace
. * Use GENERATED_FILES, drop the TODO item. * Use explicit 'call' when executing local macros. Cc: Chad Versace Signed-off-by: Emil Velikov --- Andoid changes are _not_ tested (yet). The changes to the Andoid.mk look good to me. It's much easier to understand now. However, I

Re: [Mesa-dev] [PATCH 10/37] mesa/program: move source files list to Makefile.sources

2013-11-05 Thread Chad Versace
On 11/05/2013 10:55 AM, Emil Velikov wrote: On 05/11/13 18:18, Chad Versace wrote: On 11/02/2013 12:00 PM, Emil Velikov wrote: Rip out the source file list from mesa/Makefile.sources, to a more sensible location/file. * Split PROGRAM_FILES and GENERATED_FILES. * Update the automake and Android

Re: [Mesa-dev] [PATCH 2/2] i965: Add an implementation of intel_miptree_map using streaming loads.

2013-11-06 Thread Chad Versace
On 11/05/2013 01:35 PM, Matt Turner wrote: --- Chad has benchmark numbers, I think. Put this in the commit message: Improves performance of RoboHornet's 2D Canvas toDataURL benchmark [http://www.robohornet.org/#e=canvastodataurl] by approximately 5x on Baytrail on ChromiumOS. src/me

Re: [Mesa-dev] [PATCH 1/2] mesa: Add a streaming load memcpy implementation.

2013-11-06 Thread Chad Versace
ds such as ChromiumOS. Seeing that the patch benefits immediately for some distros, I see no reason to block the patch for lack of runtime detection. I would also like to see runtime detection as a follow-up. Patch 1 is Reviewed-by: Chad Versace By the way, I tested this series by playing

Re: [Mesa-dev] [PATCH 2/2] i965: Add an implementation of intel_miptree_map using streaming loads.

2013-11-07 Thread Chad Versace
On 11/07/2013 10:55 AM, Matt Turner wrote: Improves performance of RoboHornet's 2D Canvas toDataURL benchmark [http://www.robohornet.org/#e=canvastodataurl] by approximately 5x on Baytrail on ChromiumOS. --- v2: Added benchmark results Remove unnecessary _mesa_align_free in error case R

[Mesa-dev] [PATCH] i965: Remove some tiny dead code from intel_miptree_map_movntdqa

2013-11-08 Thread Chad Versace
CC: Matt Turner Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 3f56086..bb986bd 100644 --- a/src/mesa/drivers

Re: [Mesa-dev] [PATCH 1/2 v3] i965: add XRGB to tiled_memcpy

2013-11-11 Thread Chad Versace
On 11/07/2013 01:59 PM, Courtney Goeltzenleuchter wrote: MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. This series builds on work from Frank Henigman to optimize the process of uploading a texture to the

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-11 Thread Chad Versace
On 11/08/2013 08:13 AM, Courtney Goeltzenleuchter wrote: Support all levels of a supported texture format. Using 1024x1024, RGBA source, mipmap <> internal-format Before (MB/sec) XRGB (MB/sec) mipmap (MB/sec) GL_RGBA 628.

Re: [Mesa-dev] [PATCH] i965: Delete #define's and use local variables inside function

2013-11-11 Thread Chad Versace
On 11/07/2013 04:51 PM, Anuj Phogat wrote: X_f, Y_f, Xp_f, Yp_f variables are used just inside translate_dst_to_src().So, they can be defined just as local variables. Signed-off-by: Anuj Phogat Reviewed-by: Chad Versace ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH v2] i915, i965: Fix memory leak in intel_miptree_create_for_bo.

2013-11-11 Thread Chad Versace
On 09/27/2013 10:20 PM, Vinson Lee wrote: Fixes "Resource leak" defects reported by Coverity. Signed-off-by: Vinson Lee Thanks. Committed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-d

Re: [Mesa-dev] [PATCH 1/3] dri: Add helpers for implementing allocBuffer/releaseBuffer with __DRIimage

2013-11-11 Thread Chad Versace
On 11/11/2013 01:22 PM, Kristian Høgsberg wrote: Drivers that only call getBuffers to request color buffers can use these generic, __DRIimage based helpers to implement the allocBuffer and releaseBuffer functions of __DRIdri2Extension. For the intel dri driver, this consolidates window system co

Re: [Mesa-dev] [PATCH 1/3] dri: Add helpers for implementing allocBuffer/releaseBuffer with __DRIimage

2013-11-11 Thread Chad Versace
On 11/11/2013 02:20 PM, Kristian Høgsberg wrote: On Mon, Nov 11, 2013 at 1:57 PM, Chad Versace wrote: On 11/11/2013 01:22 PM, Kristian Høgsberg wrote: Drivers that only call getBuffers to request color buffers can use these generic, __DRIimage based helpers to implement the allocBuffer and

<    1   2   3   4   5   6   7   8   9   10   >