On Tue 11 Oct 2016, Emil Velikov wrote:
> From: Emil Velikov
>
> Signed-off-by: Emil Velikov
> ---
> src/intel/isl/isl.c | 4 ++--
> src/intel/isl/isl.h | 10 --
> 2 files changed, 2 insertions(+), 12 deletions(-)
Patches 1-5 are
Revi
t consistency. Do you plan to update all the
headers?
For patches 6-12,
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri 23 Sep 2016, Chad Versace wrote:
> diff --git a/docs/specs/EGL_MESA_platform_surfaceless.txt
> b/docs/specs/EGL_MESA_platform_surfaceless.txt
> new file mode 100644
> index 000..b700370
> --- /dev/null
> +++ b/docs/specs/EGL_MESA_platform_surfaceless.txt
> @@ -0
On Thu 13 Oct 2016, Chad Versace wrote:
> On Fri 23 Sep 2016, Chad Versace wrote:
>
> > diff --git a/docs/specs/EGL_MESA_platform_surfaceless.txt
> > b/docs/specs/EGL_MESA_platform_surfaceless.txt
> > new file mode 100644
> > index 000..b700370
> >
Mesa's set of supported platform extensions depends on the autoconf
option --with-egl-platforms=foo,bar,baz. If --with-egl-platforms lacks
foo, then eglGetPlatformDisplay(EGL_PLATFORM_FOO, ...) unconditonally
fails.
So, if --with-egl-platforms lacks foo, then remove
EGL_VENDOR_platform_foo from th
+
+MESA_platform_surfaceless
+
+Name Strings
+
+EGL_MESA_platform_surfaceless
+
+Contributors
+
+Chad Versace
+Haixia Shi
+Stéphane Marchesin
+Zach Reizner
+Gurchetan Singh
+
+Contacts
+
+Chad Versace
+
+Status
+
+DRAFT
+
+Version
+
+Version 2, 2016-10-13
et/cgit/~chadv/piglit/log/?h=review/EGL_MESA_platform_surfaceless-v01
Chad Versace (6):
docs: Add EGL_MESA_platform_surfaceless.txt (v2)
egl: Don't advertise unsupported platform extensions
egl: Implement EGL_MESA_platform_surfaceless
egl: Move old EGL_MESA_screen_surface spec
doc/specs: R
It was the lone file in src/egl/docs. Move it to where the other specs
live, in $MESA_TOP/docs/specs.
---
.../EGL_MESA_screen_surface => docs/specs/OLD/EGL_MESA_screen_surface.txt | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename src/egl/docs/EGL_MESA_screen_surface =>
docs/specs/OLD/E
Years ago Khronos replaced the registry's spec files with newfangled XML
files. Update the reference in doc/specs/enum.txt accordingly.
---
docs/specs/enums.txt | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/docs/specs/enums.txt b/docs/specs/enums.txt
index
---
include/EGL/eglmesaext.h | 5 +
src/egl/main/eglapi.c | 42 +-
src/egl/main/egldisplay.c | 21 +
src/egl/main/egldisplay.h | 5 +
src/egl/main/eglglobals.c | 3 +++
5 files changed, 75 insertions(+), 1 deletion(-)
dif
Document the EGL enum ranges for Mesa and those values allocated by the
following extensions:
EGL_MESA_drm_image
EGL_MESA_platform_gbm
EGL_MESA_platform_surfaceless
EGL_WL_bind_wayland_display
---
docs/specs/enums.txt | 27 ++-
1 file changed, 26 insertions
Some people privately asked why we need to create this EGL platform.
I want to respond publicly.
Mesa *already* *has* this EGL platform. In my view, the issue at hand
isn't whether to create or to not create the platform. It's whether to
specify its behavior (formally in an extension spec) or not.
On Fri 16 Sep 2016, Emil Velikov wrote:
> From: Emil Velikov
>
> Analogous to previous commit.
>
> v2: Use correct comparison in loop conditional (Eric)
> Use valid C initializer (Gurchetan)
>
> Signed-off-by: Emil Velikov
> Reviewed-by: Gurchetan Singh
> ---
> src/egl/drivers/dri2/platf
On Fri 14 Oct 2016, Emil Velikov wrote:
> From: Emil Velikov
>
> i is used for the driver_configs, while j is for the visuals.
>
> Fixes: 4b8a55809eb ("egl/surfaceless: tweak
> surfaceless_add_configs_for_visuals()")
> Reported-by: Chad Versace
> Cc: C
Fixes GCC warning:
drivers/dri2/platform_surfaceless.c:196:18: warning: comparison
between pointer and integer
Fixes: 4b8a55809eb ("egl/surfaceless: tweak
surfaceless_add_configs_for_visuals()")
Cc: Emil Velikov
---
src/egl/drivers/dri2/platform_surfaceless.c | 2 +-
1 file changed, 1 i
gt; > surfaceless_add_configs_for_visuals()")
> > Reported-by: Chad Versace
> > Cc: Chad Versace
> > Signed-off-by: Emil Velikov
Since master was severely broken for platform_surfaceless, I took the
liberty of pushing the patch (with review tags added, of course).
___
effect, it
simplifies all existing calls to this function, because they all called
get_format() first to convert from native to DRI_IMAGE_FORMAT.
Signed-off-by: Tomasz Figa
Tested-by: Rob Herring
Reviewed-by: Chad Versace
___
mesa-dev mailing list
On 08/02/2016 04:07 AM, Tomasz Figa wrote:
This patch adds support for YV12 pixel format to the Android platform
backend. Only creating EGL images is supported, it is not added to the
list of available visuals.
v2: Use const array defined just for YV12 instead of trying to be overly
generic.
On 08/02/2016 04:07 AM, Tomasz Figa wrote:
Nicolas Boichat (1):
egl/android: Fix support for pbuffers
Tomasz Figa (6):
egl/android: Remove unused variables in
droid_get_buffers_with_format()
egl/android: Respect buffer mask in droid_image_get_buffers
egl/android: Refactor image crea
On 08/08/2016 01:58 PM, Rob Herring wrote:
On Mon, Aug 8, 2016 at 1:39 PM, Chad Versace wrote:
On 08/02/2016 04:07 AM, Tomasz Figa wrote:
This patch adds support for YV12 pixel format to the Android platform
backend. Only creating EGL images is supported, it is not added to the
list of
On 08/09/2016 01:49 PM, Haixia Shi wrote:
> Pinging this thread - any objection to commit this? Thanks.
I pushed it.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 07/26/2016 03:11 PM, Jason Ekstrand wrote:
This patch series builds on the previous one I just sent and reworks the
blorp API to be entirely ISL. The last bits of intel_mipmap_tree are
removed from the ISL internals and shoved into brw_blorp.c/h which simply
serves as a wrapper around the ISL
The new function is identical to _mesa_enum_to_string(), except that it
returns false if the given number is an invalid enum. Bundling
validation and lookup into a single function allows us to do both with
a single lookup into the enum table.
Cc: Haixia Shi
Change-Id: I83d9a6e53223d1a971cf8dc22cb
s patch series lives at
git://git.kiwitree.net/~chadv/mesa
branch review/fix-deqp-framebuffertexture-error
Chad Versace (3):
mesa: Document that _mesa_enum_to_string() returns non-null
mesa: Add _mesa_enum_to_string2()
mesa: Fix glFramebufferTexture* error codes
src/mapi/glapi/
If check_textarget() determined that textarget was incorrect, it emitted
GL_INVALID_OPERATION. This is the correct behavior when textarget is
a valid GLenum but an invalid parameter to the current variant of
glFramebufferTexture*().
However, when textarget is not a GLenum at all, then the GL spec
It always returns non-null, even if the number is an invalid enum.
Cc: Haixia Shi
Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97
---
src/mapi/glapi/gen/gl_enums.py | 4
1 file changed, 4 insertions(+)
diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py
index
On 08/11/2016 10:30 AM, Ian Romanick wrote:
On 08/11/2016 10:22 AM, Ian Romanick wrote:
On 08/11/2016 10:11 AM, Chad Versace wrote:
It always returns non-null, even if the number is an invalid enum.
Cc: Haixia Shi
Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97
---
src/mapi/glapi/gen
On 08/11/2016 10:24 AM, Ian Romanick wrote:
On 08/11/2016 10:11 AM, Chad Versace wrote:
The new function is identical to _mesa_enum_to_string(), except that it
returns false if the given number is an invalid enum. Bundling
validation and lookup into a single function allows us to do both with
a
On 08/11/2016 10:22 AM, Ilia Mirkin wrote:
On Thu, Aug 11, 2016 at 1:11 PM, Chad Versace wrote:
If check_textarget() determined that textarget was incorrect, it emitted
GL_INVALID_OPERATION. This is the correct behavior when textarget is
a valid GLenum but an invalid parameter to the current
If check_textarget() determined that textarget was incorrect, it emitted
GL_INVALID_OPERATION. This is the correct behavior when target and
textarget are mismatched but textarget is a valid textarget enum.
When textarget is not a valid textarget enum, the GL spec requires that
GL_INVALID_ENUM be
s patch series lives at
git://git.kiwitree.net/~chadv/mesa
branch review/fix-deqp-framebuffertexture-error-v02
Chad Versace (3):
mesa: Document that _mesa_enum_to_string() returns non-null
mesa: Add _mesa_enum_to_string2()
mesa: Fix glFramebufferTexture* error codes
src/mapi/glapi/
It always returns non-null, even if the number is an invalid enum.
Cc: Haixia Shi
Reviewed-by: Ian Romanick
Change-Id: I26e8843c96130be972e66f48a49e362442e1bf97
---
src/mapi/glapi/gen/gl_enums.py | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/gl_enu
(GL_IMPLEMENTATION_COLOR_READ_TYPE) and
glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_FORMAT) queries.
TEST=dEQP-GLES3.functional.state_query.integers.*
Does this patch fix all the tests in that group? Just a few tests? Exactly one?
Signed-off-by: Haixia Shi
Cc: Chad Versace
Cc: Stéphane Marchesin
te_query.integers.*
Signed-off-by: Haixia Shi mailto:h...@chromium.org>>
Cc: Chad Versace mailto:chadvers...@chromium.org>>
Cc: Stéphane Marchesin mailto:marc...@chromium.org>>
Change-Id: I81bbc8ccdc7e125edaeae443baf6fa8fdefcc6b6
---
src/mesa/main/framebuffe
| 7 ++-
> src/intel/vulkan/{intel_icd.json => intel_icd.json.in} | 2 +-
> 3 files changed, 8 insertions(+), 2 deletions(-)
> rename src/intel/vulkan/{intel_icd.json => intel_icd.json.in} (59%)
Yes please.
Reviewed-by: Chad Versace
__
layout is used.
>
> stencil
>
> >
> > Signed-off-by: Jason Ekstrand
> > Cc: Chad Versace
> > ---
> > src/intel/isl/isl.c | 28 +++-
> > 1 file changed, 23 insertions(+), 5 deletions(-)
> > + enum isl_dim_layout dim_layout =
>
On Thu 25 Aug 2016, Pohjolainen, Topi wrote:
>
> In the title did you mean GEN_1D?
>
> Otherwise patches two and three look good also:
>
> Reviewed-by: Topi Pohjolainen
Yep. Patches 2 and 3 are
Reviewed-by: Chad Versace
___
mes
Bump.
On Thu 11 Aug 2016, Chad Versace wrote:
> If check_textarget() determined that textarget was incorrect, it emitted
> GL_INVALID_OPERATION. This is the correct behavior when target and
> textarget are mismatched but textarget is a valid textarget enum.
>
> When textarget
Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes
failures on Chrome OS.
On Thu 04 Aug 2016, Chad Versace wrote:
> Hi Intel folks, could one of you please run this through Jenkins?
> I verified manually that it fixes the listed dEQP tests on Skylake.
>
> Cha
On Thu 25 Aug 2016, Martin Peres wrote:
> This mirrors the codepath taken by DRI2 in IntelSetTexBuffer2() and
> fixes many applications when using DRI3:
> - Totem with libva on hw-accelerated decoding
> - obs-studio, using Window Capture (Xcomposite) as a Source
> - gstreamer with VAAPI
>
> Bug
On Thu 25 Aug 2016, Kenneth Graunke wrote:
> On Thursday, August 25, 2016 11:06:01 AM PDT Chad Versace wrote:
> > Bump. Can I get a reviewed-by? Or at least a tested-by? This patch fixes
> > failures on Chrome OS.
>
> Oh, sorry, I thought these had been reviewed a while ago
On Fri 26 Aug 2016, Kenneth Graunke wrote:
> Gen6 only has one additional restriction over Gen7+, so we just add it
> to the existing gen7 function (which actually covers later gens too).
>
> This should stop FINISHME spew when running GL on Sandybridge.
>
> Signed-off-by: Kenneth Graunke
> ---
an/listinfo/mesa-dev to show
> where to subscribe to the list
>
> * Added a link to https://git-scm.com/docs/git-send-email to help new
> users of that command
>
> v2: add signed-off-by
> Signed-off-by: Nicholas Bishop
> ---
> docs/devinfo.html | 12 ----
&
ly needs and it does fix 8 of the new CTS tests.
>
> Reviewed-by: Topi Pohjolainen
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Patches 2, 3 are
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri 19 Aug 2016, Sirisha Gandikota wrote:
> From: Sirisha Gandikota
>
> This is a patch series for adding the aubinator tool to the codebase.
>
> The aubinator tool is designed to help the driver developers to debug
> the driver functionality by decoding the data in the .aub files. This
> too
On Wed 31 Aug 2016, Nanley Chery wrote:
> HiZ is not a color surface, but an auxiliary depth surface.
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/isl/isl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewe
src/intel/isl/isl.c | 39 +--
> 1 file changed, 33 insertions(+), 6 deletions(-)
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed 31 Aug 2016, Nanley Chery wrote:
> From: Chad Versace
>
> Unused.
>
> Nanley Chery (amend):
> - Remove wip! tag
There's no need to document that minor change :)
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_private.h | 2
On Thu 01 Sep 2016, Jason Ekstrand wrote:
> On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
>
> From: Chad Versace
>
> Nanley Chery (amend):
> - Remove wip! tag
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_private.h
On Wed 31 Aug 2016, Nanley Chery wrote:
> From: Chad Versace
>
> Nanley Chery:
> (rebase)
> - Use isl_surf_get_hiz_surf()
> (amend)
> - Only add a HiZ surface onto a depth/stencil attachment
> - Add comment above HiZ surface addition
> - Hide HiZ behind INTEL_VK_H
On Wed 31 Aug 2016, Nanley Chery wrote:
> From: Jason Ekstrand
>
> Signed-off-by: Nanley Chery
> ---
> src/intel/vulkan/anv_device.c | 20
> src/intel/vulkan/anv_image.c | 20
> 2 files changed, 20 insertions(+), 20 deletions(
On Thu 01 Sep 2016, Jason Ekstrand wrote:
>
>
> On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery wrote:
>
> From: Jason Ekstrand
>
> Nanley Chery (amend):
> - Change memset value from 0xff to 0 (a defined value for HiZ).
Yep. 0xff may hang the GPU, but 0x0 is safe.
>
> Signed
On Wed 31 Aug 2016, Nanley Chery wrote:
> From: Chad Versace
>
> Nanley Chery:
> (rebase)
> - Resolve conflicts with new anv_batch_emit macro
> (amend)
> - Remove wip! tag and handle a QPitch TODO
> - Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems
> - Only
On Fri 02 Sep 2016, Nanley Chery wrote:
> On Wed, Aug 31, 2016 at 08:29:55PM -0700, Nanley Chery wrote:
> > From: Jason Ekstrand
> >
> > Nanley Chery:
> > (rebase)
> > - Resolve conflicts with the new anv_batch_emit macro
> > (amend)
> > - Update commit title
> > - Combine all HZ operations in
> + */
> + return devinfo->gen <= 8;
There's an element of surprising elegance in this patch.
For patches 1-3,
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ly.
> ---
> src/intel/isl/isl.c | 18 --
> src/intel/isl/isl_gen7.c | 14 --
> 2 files changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Chad Versace
___
mesa-dev mailing list
me
/* On SKL+, HiZ is always single-sampled */
> - .samples = ISL_DEV_GEN(dev) >= 9 ? 1 : surf->samples,
> + .samples = samples,
> .usage = ISL_SURF_USAGE_HIZ_BIT,
> .tiling_flags = ISL_TILING_HIZ_BIT);
> }
> --
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
utright reject multisampled HiZ surfaces which wasn't intended.
> ---
> src/intel/isl/isl_gen7.c | 10 +++---
> src/intel/isl/isl_gen8.c | 11 ---
> 2 files changed, 7 insertions(+), 14 deletions(-)
Reviewed-by: Chad Versace
__
On Wed 07 Sep 2016, Adam Jackson wrote:
> On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote:
> > From: Kyle Brenneman
> >
> > Only keep track of a single current context, instead of separate
> > contexts for GL and GLES.
>
> In addition to fixing 1.4+ compliance, this fixes the "eglterminate
On Wed 07 Sep 2016, Nanley Chery wrote:
> On Fri, Sep 02, 2016 at 11:42:24AM -0700, Chad Versace wrote:
> > On Thu 01 Sep 2016, Jason Ekstrand wrote:
> > > On Wed, Aug 31, 2016 at 8:29 PM, Nanley Chery
> > > wrote:
> > >
> > > From: Chad
The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so.
But it's needed only if HAVE_PLATFORM_X11.
Fixes build of libvulkan_intel.so on Chromium OS, which has no X11
libraries.
Cc: Kevin Strasser
Cc: Jason Ekstrand
Change-Id: Ib42db7db582c4531cf13db65f2ad5d57db1d774d
---
src/in
On Thu 08 Sep 2016, Emil Velikov wrote:
> On 8 September 2016 at 04:29, Chad Versace wrote:
> > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so.
> > But it's needed only if HAVE_PLATFORM_X11.
> >
> > Fixes build of libvulkan_intel.so
On Thu 08 Sep 2016, Nanley Chery wrote:
> Should the title the say needed instead of unneeded?
Oops :/ It's already pushed.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
should be
That isl format doesn't exist. Did you mean R32B32B32_FLOAT (sans S)?
> okay because you can't render to that format.
>
> Signed-off-by: Jason Ekstrand
> Cc: Chad Versace
> ---
> src/intel/isl/isl_gen7.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 del
tly: Computation of the surface size wants
> the fewest number of horizontal tiles possible while get_intratile_offset
> is far more concerned with things aligning nicely.
>
> Signed-off-by: Jason Ekstrand
> Cc: Chad Versace
> ---
> src/intel/isl/isl.c | 49 +++
Patches 3 and 4, despite their craziness, are
Acked-by: Chad Versace
Just an ack, because I'm not very familiar with the new blorp code.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
m the current
> > + * thread, and stash that in the context we're initializing. Our caller is
> > + * responsible for determining whether that's an API it supports.
> > */
> > EGLBoolean
> > _eglInitContext(_EGLContext *ctx, _EGLDisplay *dpy, _EGLConfig *
On Fri 09 Sep 2016, Jason Ekstrand wrote:
>
> On Sep 9, 2016 12:23 PM, "Chad Versace" wrote:
> > Acked-by: Chad Versace
>
> Sure, review the easy patch and ack the interesting ones...
Yep!
> > Just an ack, because I'm not very familiar with the new blo
isn't a huge deviation.
>
> Signed-off-by: Jason Ekstrand
> Cc: Chad Versace
> ---
> src/intel/isl/isl.h | 6 ++
> src/intel/isl/isl_surface_state.c | 11 +++
> 2 files changed, 13 insertions(+), 4 d
27;t you also update blorp_fast_clear()? Oh right, Sandybridge
can't do fast clears.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon 12 Sep 2016, Jason Ekstrand wrote:
> This reverts commit 6ba88bce64b343761aabe3a6c7ee285c6020a959. The commit
> was erroneous because GL already provides a separate guard on the number of
> layers you are allowed to render into. On Sandy Bridge, we set this guard
> correctly so creating a
Const.MaxCubeTextureLevels = 14; /* 8192 */
> > ctx->Const.MaxArrayTextureLayers = brw->gen >= 7 ? 2048 : 512;
> > ctx->Const.MaxTextureMbytes = 1536;
> >
>
> To clarify...that limit is GL_MAX_FRAMEBUFFER_LAYERS.
Good. If the limit is GL_MAX_FRAMEBUFFER_LAYERS, then I agree with this
patch.
Reviewed-by: Chad Versace
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Since commit 63c5d5c6c46c8472ee7a8241a0f80f13d79cb8cd, the surfaceless
platform has allowed creation of pbuffer surfaces. But the vtable entry
for eglSwapBuffers has remained NULL.
Discovered by running a little pbuffer test.
Cc: Gurchetan Singh
---
src/egl/drivers/dri2/platform_surfaceless.c |
and pbuffer.
>
> Signed-off-by: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98326
> Cc: "12.0 13.0"
> ---
> src/egl/main/eglsurface.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Chad Versace
_
Explain why it's 64-bit and its valid values.
---
src/intel/vulkan/anv_private.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 8f5a95b..0924ccf 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_pri
V_FROM_HANDLE(anv_event, event, _event);
>
> anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) {
> + if (stageMask & PIPELINE_STAGE_PIPELINED_BITS) {
> + pc.StallAtPixelScoreboard = true;
> + pc.CommandStreamerStallEnable = true;
> + }
semaphore, pImageIndex);
> +
> + /* Thanks to implicit sync, the image is ready immediately. */
> + fence->ready = true;
> +
> + return result;
> }
Looks good (at least until explicit sync arrives).
Reviewed-by: Chad Versace
By the way, I
On Wed 02 Nov 2016, Jason Ekstrand wrote:
> Our previous fence implementation was very simple. Fences had two states:
> signaled and unsignaled. However, this didn't properly handle all of the
> edge-cases that we need to handle. In order to handle the case where the
> client calls vkGetFenceSta
On Thu 03 Nov 2016, Jason Ekstrand wrote:
>
>
> On Thu, Nov 3, 2016 at 10:59 AM, Chad Versace
> wrote:
>
> On Wed 02 Nov 2016, Jason Ekstrand wrote:
> > @@ -1116,6 +1117,11 @@ VkResult anv_QueueSubmit(
> > result = anv_device_execbuf(devi
Patches 1-3 are
Reviewed-by: Chad Versace
Tested-by: Chad Versace
I tested them with Rafael's Piglit tests and my in-flight i965 patches.
However, patch 4 causes one of Rafael's tests to segfault. I've replied
to patch 4 separately.
_
On Fri 18 Nov 2016, Rob Clark wrote:
> From: Rob Clark
>
> With fixes from Chad squashed in, plus fixes for issues that Rafael
> found while writing piglit tests.
>
> Cc: Chad Versace
> Cc: Rafael Antognolli
> Signed-off-by: Rob Clark
> ---
> src/eg
' or something similar was required
> to update the out-of-tree headers to allow the build to succeed.
>
> Also avoids having to rebuild the entire thing after every 'make
> install'.
>
> Cc: Rob Clark
> Cc: Jason Ekstrand
> Signed-off-by: Ville Syrjäl
Hi Rob, just checking on the status on the patch set. Do you plan to
send a revised series or commit them as-is? I ask because my i965
patches depend on your patches 1-4, and I'm trying to decide to when to
resend them.
On Fri 18 Nov 2016, Rob Clark wrote:
> This patchset implements support for EG
---
src/intel/vulkan/anv_device.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index d594df7d3b..e3d278df73 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -1246,11 +1246,8
The entire goal of intel_miptree_make_shareable() is to permanently
disable the miptree's aux surfaces. So set
intel_mipmap_tree:disable_aux_buffers after the function's done with
discarding down the aux surfaces.
References: https://bugs.freedesktop.org/show_bug.cgi?id=98329
Cc: Haixia Shi
Cc: T
intel_miptree_make_shareable() discarded and disabled CCS. Fix it so
that it discards and disables HiZ too.
Fixes
dEQP-EGL.functional.image.render_multiple_contexts.gles2_renderbuffer_depth16_depth_buffer
on Skylake.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=98329
Cc: Haixia Shi
Cc: T
The inescapable vortex of HiZ finds me wherever I go...
This series brings us one step closer to passing the Android N CTS.
See https://bugs.freedesktop.org/show_bug.cgi?id=98329.
Chad Versace (2):
i965/mt: Disable aux surfaces after making miptree shareable
i965/mt: Disable HiZ when
intel_miptree_make_shareable() discarded and disabled CCS. Fix it so
that it discards and disables HiZ too.
Fixes
dEQP-EGL.functional.image.render_multiple_contexts.gles2_renderbuffer_depth16_depth_buffer
on Skylake.
v2: Actually do what the commit message says. Discard the HiZ buffer.
Fixes: h
Don't dereference a null EGLDisplay.
Fixes tests
dEQP-EGL.functional.negative_api.create_pbuffer_surface
dEQP-EGL.functional.negative_api.create_pixmap_surface
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=99038
---
src/egl/main/eglapi.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
On Wed 14 Dec 2016, Emil Velikov wrote:
> On 13 December 2016 at 22:40, Chad Versace wrote:
> > Don't dereference a null EGLDisplay.
> >
> > Fixes tests
> > dEQP-EGL.functional.negative_api.create_pbuffer_surface
> > dEQP-EGL.functional.negative_api.crea
On Thu 15 Dec 2016, Emil Velikov wrote:
> Hi Chad,
>
> On 10 December 2016 at 00:40, Chad Versace wrote:
> > intel_miptree_make_shareable() discarded and disabled CCS. Fix it so
> > that it discards and disables HiZ too.
&g
On Fri 16 Dec 2016, Randy Xu wrote:
> From: "Xu,Randy"
>
> The ES specification says that TexImage3D should return GL_INVALID_OPERATION
> if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or STENCIL_INDEX.
> The current code returns INVALID_ENUM as _mesa_error_check_format_and_type is
> u
On Fri 16 Dec 2016, Chad Versace wrote:
> On Fri 16 Dec 2016, Randy Xu wrote:
> > From: "Xu,Randy"
> >
> > The ES specification says that TexImage3D should return GL_INVALID_OPERATION
> > if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or STENCI
Happy Christmas to everyone who's busy squashing dEQP bugs.
I wrote a new GBM backend for dEQP. I even submitted it to dEQP's
upstream Gerrit. Pyry, dEQP's maintainer, told me over beer earlier
this year that he would accept it if I submitted it, and if it wasn't
too crazy. So, maybe it'll be ups
If the provided EGLConfig does not support the requested surface type,
then emit EGL_BAD_MATCH.
Fixes dEQP-EGL.functional.negative_api.create_pbuffer_surface
on GBM.
Cc: "13.0"
---
src/egl/main/eglapi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/egl/main/eglapi.c b/src/
On Fri 16 Dec 2016, Chad Versace wrote:
> Happy Christmas to everyone who's busy squashing dEQP bugs.
>
> I wrote a new GBM backend for dEQP. [...]
> There's probably bugs. No surprises there.
You probably want this Mesa patch before using dEQP on GBM. It fixes
some EG
On Tue 20 Dec 2016, Tapani Pälli wrote:
> This makes better guarantee that the values we return are
> in sync what the underlying drawable currently has.
>
> Together with dEQP change bug #98327 this fixes following test:
>
>dEQP-EGL.functional.resize.surface_size.grow
>
> Signed-off-by: Tap
On Mon 19 Dec 2016, Tapani Pälli wrote:
>
>
> On 12/17/2016 03:58 AM, Chad Versace wrote:
> > Happy Christmas to everyone who's busy squashing dEQP bugs.
> >
> > I wrote a new GBM backend for dEQP. I even submitted it to dEQP's
> > upstream Gerrit.
s no harm in adding yet another.
I have more comments below.
> -Original Message-
> From: Ian Romanick [mailto:i...@freedesktop.org]
> Sent: Saturday, December 17, 2016 6:02 AM
> To: Chad Versace ; Xu, Randy ;
> mesa-dev@lists.freedesktop.org; mesa-sta...@lists.freedesktop.org
201 - 300 of 2787 matches
Mail list logo
