On 08/12/2016 03:02 PM, Jason Ekstrand wrote:
Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net <mailto:ja...@jlekstrand.net>>
I also ran it through our CI system and it didn't find any problems.
On Fri, Aug 12, 2016 at 2:34 PM, Haixia Shi <h...@chromium.org
<mailto:h...@chromium.org>> wrote:
The GL_BGR and GL_UNSIGNED_SHORT_5_6_5_REV are not defined anywhere in
OpenGL ES 3.2 (or earlier) specification, and there are no known extensions
in the Khronos registry that would add these enums as valid responses for
glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_TYPE) and
glGetIntegerv(GL_IMPLEMENTATION_COLOR_READ_FORMAT) queries.
Note that this patch does not change the bit layout returned by the query.
As
defined by the GL spec, the bit layout of GL_RGB + GL_UNSIGNED_SHORT_5_6_5
and
GL_BGR + GL_UNSIGNED_SHORT_5_6_5_REV are identical.
TEST=dEQP-GLES3.functional.state_query.integers.*
Signed-off-by: Haixia Shi <h...@chromium.org <mailto:h...@chromium.org>>
Cc: Chad Versace <chadvers...@chromium.org
<mailto:chadvers...@chromium.org>>
Cc: Stéphane Marchesin <marc...@chromium.org <mailto:marc...@chromium.org>>
Change-Id: I81bbc8ccdc7e125edaeae443baf6fa8fdefcc6b6
---
src/mesa/main/framebuffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for updating the commit message.
Reviewed-by: Chad Versace <chadvers...@chromium.org>
and pushed.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
