On Fri 09 Sep 2016, Jason Ekstrand wrote: > > On Sep 9, 2016 12:23 PM, "Chad Versace" <chadvers...@chromium.org> wrote:
> > Acked-by: Chad Versace <chadvers...@chromium.org> > > Sure, review the easy patch and ack the interesting ones... Yep! > > Just an ack, because I'm not very familiar with the new blorp code. > > The blorp_copy entrypoint does exactly what it looks like it does... Including > handling all the crazy edge-cases... If you're willing to trust it, 3 and 4 > are > trivial. :-) I was unsure exactly what blorp_copy did. Is it a bit-for-bit copy? Does it do format translation? I just read the blorp_copy code, and revisited the glCopyTexImage2D manpage, and yeah... it's not scary. I trust this code now. For patches 3 and 4, Reviewed-by: Chad Versace <chadvers...@chromium.org> Patch 2, though, is still just an ack. I don't have time to review all the implications of patch 2. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
