trand
Cc: Daniel Stone
Cc: Kristian H. Kristensen
Signed-off-by: Ben Widawsky
---
src/gbm/backends/dri/gbm_dri.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index ac7ede87b6..3faa19e3f1 1
On 17-03-07 08:33:32, Jason Ekstrand wrote:
On Mon, Mar 6, 2017 at 6:37 PM, Ben Widawsky wrote:
v2: Preserve legacy behavior when plane is 0 (Jason Ekstrand)
EINVAL when input plane is greater than total planes (Jason Ekstrand)
Don't leak the image after fromPlanar (Daniel)
Move bo-&
plane == 0 (Jason)
- Add a comment about new restriction on planar dumb bo which is not an
earlier patch in the series.
- Correctly refactor from v2 in this patch; it ended up rebased into the
wrong patch.
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/gbm/backend
Jason's recommended change)
Make plane 0 return planar stride. This might break legacy behavior (Jason)
v4: Move bogus hunk for get_handle_for_plane to the right patch (Jason)
Fix error handling path to be cleaner (Jason)
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Reviewed-by: Eric E
Jason's recommendation for handling the non-planar case.
v4: Return int64_t so we can get real errors
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 33 +
src/gbm/gbm-symbols-check | 1 +
as well as
exposing the new entry points.
Ben Widawsky (3):
dri: Add an image creation with modifiers
gbm: Introduce modifiers into surface/bo creation
gbm: Export a get modifiers
include/GL/internal/dri_interface.h | 27 ++-
src/egl/drivers/dri2/platform_drm.c | 19
llow usage + modifiers
v3: Make NAND actually NAND. Bug introduced in v2. (Jason)
Cc: Kristian Høgsberg
Cc: Jason Ekstrand
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom (v1)
Acked-by: Daniel Stone
---
include/GL/internal/dri_interface.h | 27 ++-
s
as well as
exposing the new entry points.
Ben Widawsky (3):
dri: Add an image creation with modifiers
gbm: Introduce modifiers into surface/bo creation
gbm: Export a get modifiers
include/GL/internal/dri_interface.h | 27 ++-
src/egl/drivers/dri2/platform_drm.c | 19
This patch originally had i965 specific code and was named:
commit 61cd3c52b868cf8cb90b06e53a382a921eb42754
Author: Ben Widawsky
Date: Thu Oct 20 18:21:24 2016 -0700
gbm: Get modifiers from DRI
To accomplish this, two new query tokens are added to the extension
t bother with storing modifiers for gbm_bo_create because that's
a synchronous operation and we can actually select the correct modifier
at create time (done in a later patch) (Jason)
Cc: Kristian Høgsberg
Cc: Jason Ekstrand
References (v4):
https://lists.freedesktop.org/archives/intel-gfx/201
On 17-03-09 18:38:15, Jason Ekstrand wrote:
On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote:
Modifiers will be obtains or guessed by the client and passed in during
"obtained"
Got it.
image creation/import.
This requires bumping the DRIimage version.
As of this
On 17-03-10 10:28:42, Emil Velikov wrote:
Hi Ben,
Mostly pointing out a few things that look strange, pardon if some
seem too pedantic.
On 10 March 2017 at 01:48, Ben Widawsky wrote:
---
include/GL/internal/dri_interface.h | 27 ++-
Split the Infra from the
On 17-03-10 11:34:19, Jason Ekstrand wrote:
On Thu, Mar 9, 2017 at 6:52 PM, Jason Ekstrand wrote:
On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote:
The idea behind modifiers like this is that the user of GBM will have
some mechanism to query what properties the hardware supports for its
On 17-03-09 18:52:52, Jason Ekstrand wrote:
On Thu, Mar 9, 2017 at 5:48 PM, Ben Widawsky wrote:
The idea behind modifiers like this is that the user of GBM will have
some mechanism to query what properties the hardware supports for its BO
or surface. This information is directly passed in
On 17-03-10 11:32:35, Emil Velikov wrote:
On 10 March 2017 at 01:48, Ben Widawsky wrote:
The idea behind modifiers like this is that the user of GBM will have
some mechanism to query what properties the hardware supports for its BO
or surface. This information is directly passed in (and stored
This is just a stub for now and will be filled in later.
This was split out of an earlier patch
Requested-by: Emil Velikov
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/intel_screen.c | 38
1 file changed, 34 insertions(+), 4 deletions(-)
diff
t bother with storing modifiers for gbm_bo_create because that's
a synchronous operation and we can actually select the correct modifier
at create time (done in a later patch) (Jason)
Cc: Kristian Høgsberg
Cc: Jason Ekstrand
References (v4):
https://lists.freedesktop.org/archives/intel-gfx/201
Nothing special here other than a brief introduction to modifier
selection. Originally this was part of another patch but was split out
from
gbm: Introduce modifiers into surface/bo creation by request of Emil.
Requested-by: Emil Velikov
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri
This patch originally had i965 specific code and was named:
commit 61cd3c52b868cf8cb90b06e53a382a921eb42754
Author: Ben Widawsky
Date: Thu Oct 20 18:21:24 2016 -0700
gbm: Get modifiers from DRI
To accomplish this, two new query tokens are added to the extension
Split into a separate patch from the previous patch as requested by
Emil.
Requeted-by: Emil Velikov
Signed-off-by: Ben Widawsky
---
src/egl/drivers/dri2/platform_drm.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_drm.c
patch simply makes sure the interface level stuff is correct.
v2: Don't allow usage + modifiers
v3: Make NAND actually NAND. Bug introduced in v2. (Jason)
v4:
- s/obtains/obtained (Jason)
- Pull out i965 imlemnentation into a later patch (Emil)
Cc: Jason Ekstrand
Cc: Emil Velikov
Signed-o
On 17-03-14 08:53:45, Jason Ekstrand wrote:
On Mon, Mar 13, 2017 at 10:24 PM, Ben Widawsky wrote:
The idea behind modifiers like this is that the user of GBM will have
some mechanism to query what properties the hardware supports for its BO
or surface. This information is directly passed in
On 17-03-14 13:31:01, Ben Widawsky wrote:
On 17-03-14 08:53:45, Jason Ekstrand wrote:
On Mon, Mar 13, 2017 at 10:24 PM, Ben Widawsky wrote:
The idea behind modifiers like this is that the user of GBM will have
some mechanism to query what properties the hardware supports for its BO
or
istian Høgsberg
References (v4):
https://lists.freedesktop.org/archives/intel-gfx/2017-January/116636.html
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom (v1)
Reviewed-by: Jason Ekstrand
Acked-by: Daniel Stone
---
src/gbm/backends/dri/gbm_dri.c | 63 --
src/gbm/gbm-
2 MiB
Reads: .8 MiB
Similar functionality was introduced and then reverted here:
commit 6a0d036483caf87d43ebe2edd1905873446c9589
Author: Ben Widawsky
Date: Thu Apr 21 20:14:58 2016 -0700
i965: Always use Y-tiled buffers on SKL+
v2: Use last set bit instead of first set bit in modifiers to
modesetting driver, and Weston (and other GBM clients) to use Y tiled
scanout buffers on gen9+.
Ben Widawsky (5):
i965/dri: Store the screen associated with the image
i965: Enable modifier queries
i965: Handle the linear fb modifier
i965: Handle Y-tiled modifier
i965: Handle X-tiled
surface (ie. stupid clients could be broken before
this patch, but in more ways than this).
Obviously, there are no modifiers being actually stored yet - so this
patch shouldn't do anything other than allow the API to get back 0 (or
the LINEAR modifier).
Signed-off-by: Ben Widawsky
---
src
. As a
result, 0 was repurposed to mean a modifier for a LINEAR layout.
NOTE: This patch was added for v3 of the patch series.
References: https://patchwork.kernel.org/patch/9419157/
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/intel_screen.c | 35
1
I intend to need to get to the devinfo structure, and storing the screen
is an easy way to do that.
It seems to be the consensus that you cannot share an image between
multiple screens.
Scape-goat: Rob Clark
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
st X
tiled.
v2: priority lits was in reverse order.
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/s
All the plumbing is in place so the extension just needs to be
advertised.
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965
On 17-03-20 12:00:44, Jason Ekstrand wrote:
On Fri, Mar 17, 2017 at 5:34 PM, Ben Widawsky wrote:
This patch begins introducing how we'll actually handle the potentially
many modifiers coming in from the API, how we'll store them, and the
structure in the code to support it.
Pri
On 17-03-20 15:36:37, Jason Ekstrand wrote:
On Mon, Mar 20, 2017 at 3:25 PM, Ben Widawsky wrote:
On 17-03-20 12:00:44, Jason Ekstrand wrote:
On Fri, Mar 17, 2017 at 5:34 PM, Ben Widawsky wrote:
This patch begins introducing how we'll actually handle the potentially
many modifiers c
ind me what the reasoning is for support modifiers? I thought we agreed to
just use GET_PLANE2? Supported modifiers is difficult because mesa has no idea
of per plane constraints.
On Sat, Mar 18, 2017 at 1:00 PM, Ben Widawsky wrote:
All the plumbing is in place so the extension just needs to be
adve
On 17-03-20 16:21:53, Jason Ekstrand wrote:
On Mon, Mar 20, 2017 at 4:15 PM, Ben Widawsky wrote:
On 17-03-20 12:03:24, Jason Ekstrand wrote:
My only question here is whether or not we want to add a "supported
modifiers" query to DRIimage before we bump the version number. It'
surface (ie. stupid clients could be broken before
this patch, but in more ways than this).
Obviously, there are no modifiers being actually stored yet - so this
patch shouldn't do anything other than allow the API to get back 0 (or
the LINEAR modifier).
Signed-off-by: Ben Widawsky
---
src
surface (ie. stupid clients could be broken before
this patch, but in more ways than this).
Obviously, there are no modifiers being actually stored yet - so this
patch shouldn't do anything other than allow the API to get back 0 (or
the LINEAR modifier).
Signed-off-by: Ben Widawsky
---
src
. As a
result, 0 was repurposed to mean a modifier for a LINEAR layout.
NOTE: This patch was added for v3 of the patch series.
v2: Rework the algorithm for modifier selection to go from a bitmask
based selection to this priority value.
Requested-by: Jason Ekstrand
Signed-off-by: Ben Widawsky
imilar functionality was introduced and then reverted here:
commit 6a0d036483caf87d43ebe2edd1905873446c9589
Author: Ben Widawsky
Date: Thu Apr 21 20:14:58 2016 -0700
i965: Always use Y-tiled buffers on SKL+
v2: Use last set bit instead of first set bit in modifiers to address
bug found
st X
tiled.
Cc: Kristian Høgsberg
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
---
src/mesa/drivers/dri/i965/intel_screen.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index e4f858ed33..9d458c70
On 17-03-21 08:07:22, Jason Ekstrand wrote:
On Tue, Mar 21, 2017 at 8:04 AM, Jason Ekstrand
wrote:
On Mon, Mar 20, 2017 at 8:35 PM, Ben Widawsky wrote:
This patch begins introducing how we'll actually handle the potentially
many modifiers coming in from the API, how we'll store
Signed-off-by: Ben Widawsky
---
src/gbm/backends/dri/gbm_dri.c | 28
1 file changed, 28 insertions(+)
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
index a7ac149365..283a73454e 100644
--- a/src/gbm/backends/dri/gbm_dri.c
+++ b/src/gbm
before, Y-tiled (as well as X, and linear) modifier can be used for DRI
images at the end of this patch series in i965.
Jason has reviewed most of this already, but since I added a few patches I
thought it was necessary to resend the whole thing.
Ben Widawsky (8):
i965/dri: Disallow image with
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/i965/intel_screen.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index af9c9a45f3..b77933e100 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
I intend to need to get to the devinfo structure, and storing the screen
is an easy way to do that.
It seems to be the consensus that you cannot share an image between
multiple screens.
Scape-goat: Rob Clark
Signed-off-by: Ben Widawsky
Reviewed-by: Eric Engestrom
Acked-by: Daniel Stone
. As a
result, 0 was repurposed to mean a modifier for a LINEAR layout.
NOTE: This patch was added for v3 of the patch series.
v2: Rework the algorithm for modifier selection to go from a bitmask
based selection to this priority value.
Requested-by: Jason Ekstrand
Signed-off-by: Ben Widawsky
surface (ie. stupid clients could be broken before
this patch, but in more ways than this).
Obviously, there are no modifiers being actually stored yet - so this
patch shouldn't do anything other than allow the API to get back 0 (or
the LINEAR modifier).
Signed-off-by: Ben Widawsky
Review
89.10 MiB/s
Similar functionality was introduced and then reverted here:
commit 6a0d036483caf87d43ebe2edd1905873446c9589
Author: Ben Widawsky
Date: Thu Apr 21 20:14:58 2016 -0700
i965: Always use Y-tiled buffers on SKL+
v2: Use last set bit instead of first set bit in modifiers to address
bug found
øgsberg
Signed-off-by: Ben Widawsky
Acked-by: Daniel Stone
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_screen.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 8bb3aca
All the plumbing is in place so the extension just needs to be
advertised.
Signed-off-by: Ben Widawsky
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src
On 17-03-21 13:48:13, Jason Ekstrand wrote:
On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky wrote:
At image creation create a path for dealing with the linear modifier.
This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR
was specified.
During development of this patch
On 17-03-21 13:52:12, Jason Ekstrand wrote:
On Tue, Mar 21, 2017 at 1:45 PM, Ben Widawsky wrote:
This patch begins introducing how we'll actually handle the potentially
many modifiers coming in from the API, how we'll store them, and the
structure in the code to support it.
Pri
of
identifying no modifiers found (because 0 is LINEAR) (Jason)
Requested-by: Jason Ekstrand
Signed-off-by: Ben Widawsky
Reviewed-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_screen.c | 56 +---
1 file changed, 45 insertions(+), 11 deletions(-)
diff --git a
89.10 MiB/s
Similar functionality was introduced and then reverted here:
commit 6a0d036483caf87d43ebe2edd1905873446c9589
Author: Ben Widawsky
Date: Thu Apr 21 20:14:58 2016 -0700
i965: Always use Y-tiled buffers on SKL+
v2: Use last set bit instead of first set bit in modifiers to address
bug found
On 17-03-21 14:15:05, Jason Ekstrand wrote:
On Tue, Mar 21, 2017 at 2:09 PM, Ben Widawsky wrote:
At image creation create a path for dealing with the linear modifier.
This works exactly like the old usage flags where __DRI_IMAGE_USE_LINEAR
was specified.
During development of this patch
of
identifying no modifiers found (because 0 is LINEAR) (Jason)
v4: Remove the logic to prune unknown modifiers (like those from other
vendors) and simply handle is in select_best_modifier (Jason)
Requested-by: Jason Ekstrand
Signed-off-by: Ben Widawsky
Reviewed-by: Jason Ekstrand
---
src/mesa
On 17-08-16 13:26:00, Jason Ekstrand wrote:
For non-CCS images, we were reporting just one plane even though they
may have multiple in the case of YUV.
Cc:
This has been wrong since it's initial implementation in 2014, ie. not stable
material IMO..
Reviewed-by: Ben Widawsky
---
src
On 17-08-24 11:01:34, Matt Turner wrote:
Reviewed-by: Matt Turner
I'm blaming this one on someone else's rebase ;-)
Reviewed-by: Ben Widawsky
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailma
On 17-08-24 14:16:39, kevin.rogo...@intel.com wrote:
From: Kevin Rogovin
Special thanks to Eero Tamminen for reporting rasterizer
numbers being twice what it should be for 2xMSAA under
a benchmark.
Signed-off-by: Kevin Rogovin
---
src/mesa/drivers/dri/i965/intel_screen.c | 14 +++---
1
also let GBM
> users inform the implementation that it intends to use the modifiers.
>
> This reverts commit 6a0d036483caf87d43ebe2edd1905873446c9589.
>
> Signed-off-by: Daniel Stone
> Cc: Ben Widawsky
> Cc: Topi Pohjolainen
> Cc: Kenneth Graunke
I'm going to take a
ar_op = GEN7_PS_RENDER_TARGET_RESOLVE_ENABLE;
>
> /* Note: there is no need to initialize push constants because it doesn't
> * matter what data gets dispatched to the render target. However, we
> must
Reviewed-by: Ben Widawsky
After rebasing this it become
false;
+
/* And finally distinguish between msaa and single sample case. */
return mt->num_samples <= 1;
}
Either way:
Reviewed-by: Ben Widawsky
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, May 05, 2016 at 10:51:32AM -0700, Ben Widawsky wrote:
> On Thu, Apr 21, 2016 at 02:58:57PM +0300, Topi Pohjolainen wrote:
> > Signed-off-by: Topi Pohjolainen
> > ---
> > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 7 ++-
> > 1 file changed,
t; if (brw->gen >= 9 || mt->num_samples == 1)
>assert(mt->halign == 16);
>
> + if (intel_miptree_is_lossless_compressed(brw, mt))
> + return GEN9_SURFACE_AUX_MODE_CCS_E;
> +
> return GEN8_SURFACE_AUX_MODE_MCS;
> }
>
Wouldn't mind if
On Thu, Apr 21, 2016 at 02:58:59PM +0300, Topi Pohjolainen wrote:
> v2: Check explicitly against base type of GL_FLOAT instead of
> using _mesa_is_format_integer_color(). Otherwise we miss
> GL_UNSIGNED_NORMALIZED.
>
> Signed-off-by: Topi Pohjolainen
> ---
> src/mesa/drivers/dri/i965/int
BLE_AUX_CCS_E,
+ MIPTREE_LAYOUT_FORCE_HALIGN16 = 1 << 5,
+
+ MIPTREE_LAYOUT_TILING_Y = 1 << 6,
+ MIPTREE_LAYOUT_TILING_NONE = 1 << 7,
MIPTREE_LAYOUT_TILING_ANY = MIPTREE_LAYOUT_TILING_Y |
MIPTREE_LAYOUT_TILING_NONE,
};
I do like mt->is_scanout though. That seems useful. Either way:
Reviewed-by: Ben Widawsky
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
ptree_alloc_hiz() that sets
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> index bb06522..e0d543b 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> @@
dst_mt->msaa_layout == INTEL_MSAA_LAYOUT_CMS)
> + wm_prog_key.dst_layout = INTEL_MSAA_LAYOUT_NONE;
> +
> wm_prog_key.src_tiled_w = src.map_stencil_as_y_tiled;
> wm_prog_key.dst_tiled_w = dst.map_stencil_as_y_tiled;
> /* Round floating point values to nearest integer to avoid "off by one
> texel"
With sufficient answer to my question:
Reviewed-by: Ben Widawsky
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, May 06, 2016 at 10:19:58AM +0300, Pohjolainen, Topi wrote:
> On Thu, May 05, 2016 at 10:59:16AM -0700, Ben Widawsky wrote:
> > On Thu, May 05, 2016 at 10:51:32AM -0700, Ben Widawsky wrote:
> > > On Thu, Apr 21, 2016 at 02:58:57PM +0300, Topi Pohjolainen wrote:
> >
On Sun, May 08, 2016 at 12:15:00PM +0100, Daniel Stone wrote:
> Hi,
> I'd already suggested the same, but it never got pushed:
> https://lists.freedesktop.org/archives/mesa-dev/2016-May/115501.html
>
> So I guess we can add the Tested-by from the other, for whichever gets
> pushed.
>
Was there a
On Fri, May 06, 2016 at 09:08:41PM +0300, Pohjolainen, Topi wrote:
> On Thu, May 05, 2016 at 07:08:15PM -0700, Ben Widawsky wrote:
> > On Mon, Apr 25, 2016 at 08:10:01PM +0300, Topi Pohjolainen wrote:
> > > Signed-off-by: Topi Pohjolainen
> > > ---
>
heck for gen < 9 and return early in intel_miptree_prepare_mcs()
>
> Signed-off-by: Topi Pohjolainen
> Reviewed-by: Ben Widawsky
v5 is also Reviewed-by: Ben Widawsky
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Mon, May 09, 2016 at 10:29:28AM -0700, Ben Widawsky wrote:
> On Fri, May 06, 2016 at 11:38:25AM +0300, Topi Pohjolainen wrote:
> > Until now mcs was associated to single sampled buffers only for
> > fast clear purposes and it was therefore the responsibility of the
> > cl
On Thu, Apr 21, 2016 at 02:59:02PM +0300, Topi Pohjolainen wrote:
> Blorp blits use sampling engine which is capable of resolving
> on the fly.
We determined blitter does need the resolve? With that info added to the commit
message:
Reviewed-by: Ben Widawsky
>
> Signed-off-by: Topi
On Thu, Apr 21, 2016 at 02:59:03PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
Reviewed-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/gen8_surface_state.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/src/mes
On Thu, Apr 21, 2016 at 02:59:05PM +0300, Topi Pohjolainen wrote:
> Signed-off-by: Topi Pohjolainen
Reviewed-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/brw_wm.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965
- 0.460624%
> Offscreen: 9.31872% +/- 0.463743%
>
> v2 (Ben): Re-use msaa layout type for single sampled case.
> v3: Moved the deferred allocation of mcs to brw_try_draw_prims() and
> brw_blorp_blit_miptrees() instead.
>
> Signed-off-by: Topi Pohjolainen
Reviewed-by: Ben Widaw
On Tue, May 10, 2016 at 08:14:00PM +0300, Pohjolainen, Topi wrote:
> On Thu, Apr 21, 2016 at 02:59:04PM +0300, Topi Pohjolainen wrote:
> > v2: Add support for blorp and removed the support for meta
> >
> > Signed-off-by: Topi Pohjolainen
> > ---
> > src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
the buffer is already cleared. Without
> considering if the previous color value was the same as the new,
> clears that need to be performed are skipped and the buffer ends up
> holding old pixel values.
>
> Signed-off-by: Topi Pohjolainen
> CC: Kenneth Graunke
> CC: Ben Widaw
heck for gen < 9 and return early in intel_miptree_prepare_mcs()
> v4: Check for msaa_layput and number of samples to determine if
> lossless compression is to used. Otherwise one cannot distuingish
> between fast clear with and without compression.
>
> Signed-off-by: Topi Pohjo
On Thu, May 12, 2016 at 06:21:38PM +0100, Plamena Manolova wrote:
> According to the EGL specifications eglQueryString(EGL_CLIENT_APIS)
> should return a string containing a combination of "OpenGL", "OpenGL_ES"
> and "OpenVG", any other values would be considered invalid. Due to this
> when the API
On Thu, May 19, 2016 at 01:51:08PM -0700, Mark Janes wrote:
> This trivial fix to error-handling corrects the sign of drm error
> codes before passing them to strerror.
>
> Identified by Coverity: CID1358581
Reviewed-by: Ben Widawsky
[snip]
On 18-03-31 12:00:16, Chris Wilson wrote:
Quoting Kenneth Graunke (2018-03-30 19:20:57)
On Friday, March 30, 2018 7:40:13 AM PDT Chris Wilson wrote:
> For i915, we are proposing to use a quality-of-service parameter in
> addition to that of just a priority that usurps everyone. Due to our HW,
>
fer placement or cache configuration.
>
> Cheers,
> Daniel
Yeah... leaving an optional usage would have been ideal, however, I think the
way I peddled it, it was required - so we were all wrong :-)
--
Ben Widawsky, Intel Open Source Technology Center
__
On Fri, 28 Dec 2012 21:21:51 -0800
Kenneth Graunke wrote:
> Every generation except Gen7 creates SURFACE_STATE entries via a
> uint32_t array. Only Gen7 uses the older bitfield structure, which we
> moved away from because it was less efficient. Convert it for
> consistency.
>
> This reduces t
On Sat, 29 Dec 2012 13:21:02 -0800
Kenneth Graunke wrote:
> On 12/29/2012 11:58 AM, Ben Widawsky wrote:
> > On Fri, 28 Dec 2012 21:21:51 -0800
> > Kenneth Graunke wrote:
> >
> >> Every generation except Gen7 creates SURFACE_STATE entries via a
> >> ui
mesa-dev is a better place for this question.
Begin forwarded message:
Date: Mon, 21 Jan 2013 22:13:34 +0100
From: Marcel Witte
To: intel-...@lists.freedesktop.org
Subject: [Intel-gfx] Very low performance when streaming textures
Hi,
I'm refering to the example of this article about streaming
This makes the code a lot cleaner, and theoretically faster (not many
real world tests use this GL extension).
Cc: Eric Anholt
Cc: Daniel Vetter
Cc: Mesa Devs
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/intel/intel_buffer_objects.c | 48 ++--
1 files changed, 5
On Fri, 23 Sep 2011 10:15:02 -0700
Eric Anholt wrote:
> On Thu, 22 Sep 2011 16:27:12 -0700, Ben Widawsky
> wrote:
> > This makes the code a lot cleaner, and theoretically faster (not
> > many real world tests use this GL extension).
> >
> > Cc: Eric Anholt
>
On Fri, 23 Sep 2011 11:46:41 -0700
Ben Widawsky wrote:
> On Fri, 23 Sep 2011 10:15:02 -0700
> Eric Anholt wrote:
>
> > On Thu, 22 Sep 2011 16:27:12 -0700, Ben Widawsky
> > wrote:
> > > This makes the code a lot cleaner, and theoretically faster (not
> >
On Fri, 23 Sep 2011 11:56:59 -0700
Ben Widawsky wrote:
> On Fri, 23 Sep 2011 11:46:41 -0700
> Ben Widawsky wrote:
>
> > On Fri, 23 Sep 2011 10:15:02 -0700
> > Eric Anholt wrote:
> >
> > > On Thu, 22 Sep 2011 16:27:12 -0700, Ben Widawsky
> > > wro
Clean the code up, and always use a BO when creating a new buffer. I've
not seen any regressions but haven't yet tried this on < Gen6.
Cc: Chad Versace
Cc: Eric Anholt
Cc: Mesa Devs
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/intel/intel_buffer_obj
When mapping a range of a buffer that has the UNSYNCHRONIZED_BIT, and is
only writable, we can take some shortcuts and let people shoot their
feet.
Cc: Eric Anholt
Cc: Mesa Devs
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/intel/intel_buffer_objects.c | 35 ++--
src
On Fri, 23 Sep 2011 17:36:16 -0700
Ben Widawsky wrote:
> Clean the code up, and always use a BO when creating a new buffer.
> I've not seen any regressions but haven't yet tried this on < Gen6.
>
> Cc: Chad Versace
> Cc: Eric Anholt
> Cc: Mesa Devs
> Sig
When mapping a range of a buffer that has the UNSYNCHRONIZED_BIT, and is
only writable, we can take some shortcuts and let people shoot their
feet.
Cc: Eric Anholt
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/intel/intel_buffer_objects.c | 34 ++--
src/mesa/drivers
Clean the code up, and always use a BO when creating a new buffer. I've
not seen any regressions but haven't yet tried this on < Gen6.
Cc: Chad Versace
Cc: Eric Anholt
Signed-off-by: Ben Widawsky
---
src/mesa/drivers/dri/intel/intel_buffer_objects.c | 114 ++
Yuanhan recently added tests which check for conformance on the API.
This patch goes on top of his to help make a dent in testing
functionality.
Cc: Yuanhan Liu
Cc: Piglit Devs
Signed-off-by: Ben Widawsky
---
tests/all.tests|1 +
tests/spec
atch reworked by Ben]
Cc: Eric Anholt
Signed-off-by: Daniel Vetter
Signed-off-by: Ben Widawsky
---
include/drm/i915_drm.h |7 ++
intel/intel_bufmgr.h |3 +
intel/intel_bufmgr_gem.c | 175 +-
3 files changed, 168 insertions(+), 17 deleti
.
Cc: Daniel Vetter
Cc: Eric Anholt
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_dma.c |1 +
drivers/gpu/drm/i915/i915_drv.h |2 ++
drivers/gpu/drm/i915/i915_gem.c | 22 ++
include/drm/i915_drm.h |7 +++
4 files changed, 32 insertions(
After going back and forth many times, I think Daniel and I have agreed
on the solution for non-blocking maps.
This new interface adds a new call to map buffers non-blocking if
possible. In actuality it may block, but it will track if the buffer
needs flushing or not and does the right thing for t
901 - 1000 of 1066 matches
Mail list logo
