On Mon, Nov 28, 2016 at 5:19 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This isn't fully what we want yet, but is a good step on the way.
>
> This allows the compiler to create the information structures
> for the state setting side, however the state setting still expects
> things to be pret
Series is:
Reviewed by: Bas Nieuwenhuizen
On 8 Dec 2016 1:19 AM, "Dave Airlie" wrote:
> From: Dave Airlie
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/common/ac_nir_to_llvm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/src/amd/common
Reviewed-by: Bas Nieuwenhuizen
On 8 Dec 2016 1:56 AM, "Dave Airlie" wrote:
> From: Dave Airlie
>
> We don't use the nir shader in here at all.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/common/ac_nir_to_llvm.c | 15 ++-
> 1 fil
Inspired by patches from Eric Engestrom.
Signed-off-by: Bas Nieuwenhuizen
Cc: Eric Engestrom
---
src/amd/vulkan/radv_device.c | 41 +
src/amd/vulkan/radv_private.h | 8
2 files changed, 21 insertions(+), 28 deletions(-)
diff --git a/src/amd
Leftovers from anv?
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_private.h | 16
1 file changed, 16 deletions(-)
diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h
index 4b72017..67da46a 100644
--- a/src/amd/vulkan/radv_private.h
+++ b/src
Inspired by patches from Eric Engestrom.
Signed-off-by: Bas Nieuwenhuizen
Cc: Eric Engestrom
---
src/amd/vulkan/radv_device.c | 18 ++
src/amd/vulkan/radv_private.h | 7 +++
2 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src
This series has been reviewed and pushed, thanks.
- Bas
On Sat, Dec 10, 2016 at 8:10 PM, Grazvydas Ignotas wrote:
> Just mark with MAYBE_UNUSED.
>
> Signed-off-by: Grazvydas Ignotas
> ---
> no commit access, somebody please push
>
> src/amd/vulkan/radv_cmd_buffer.c | 34 ++-
dEQP-VK.api.object_management.alloc_callback_fail_multiple.graphics_pipeline
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_pipeline.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd
ueues for DCC reasons.
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta.h | 6 +
src/amd/vulkan/radv_meta_bufimage.c | 302 +++-
src/amd/vulkan/radv_meta_copy.c | 23 ++-
3 files changed, 325 insertions(+), 6 deletions(-)
diff --git a/s
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_radeon_winsys.h | 3 ++-
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 14 +-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_radeon_winsys.h
b/src/amd/vulkan
series is also available at
https://github.com/BNieuwenhuizen/mesa/commits/radv-wip-cs-queue
Yours sincerely,
Bas Nieuwenhuizen
Bas Nieuwenhuizen (10):
radv/winsys: Expose number of compute/dma rings.
radv: Use correct pitch for views with different block size.
radv/winsys: Make Wai
From: Dave Airlie
This will make it easier to add support for clears on compute queues.
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta_clear.c | 245 ---
1 file changed, 128 insertions(+), 117 deletions(-)
diff --git a/src/amd/vulkan
Needed when accessing a comrpessed texture as R32G32B32A32 from a shader. This
was not encountered previously, as we used the CB for the reinterpretation,
which
does not use this pitch.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_image.c | 5 -
1 file changed, 4 insertions
From: Dave Airlie
These aren't used yet but we will want to use them when we
implement a separate compute queue.
Signed-off-by: Dave Airlie
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta_clear.c | 41
1 file changed, 33 insertions(
From: Dave Airlie
v2: Added helper (Bas)
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_cmd_buffer.c | 30 --
src/amd/vulkan/radv_private.h| 7 +++
2 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b
From: Dave Airlie
This is required for having a separate compute queue, we
probably can't use this on GFX queue due to DCC.
v2: Set coord_components = 2 for itoi texture fetch. (Bas)
Signed-off-by: Dave Airlie
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta.h
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/si_cmd_buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index 4b2624cb8e..e3f883f50b 100644
--- a/src/amd/vulkan/si_cmd_buffer.c
+++ b/src/amd
We can't fast clear on compute queues.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_cmd_buffer.c | 40
src/amd/vulkan/radv_image.c | 18 --
src/amd/vulkan/radv_meta_clear.c | 2 +-
src/amd/vulkan/radv_private.h
From: Dave Airlie
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta.h | 7 +
src/amd/vulkan/radv_meta_bufimage.c | 269 ++--
src/amd/vulkan/radv_private.h | 5 +
3 files changed, 272 insertions(+), 9 deletions(-)
diff --git a/src
From: Dave Airlie
v2: Fix error handling and zero init the device (Bas)
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 52 ++-
src/amd/vulkan/radv_private.h | 16 +
2 files changed, 53 insertions(+), 15 deletions
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/common/sid.h| 1 +
src/amd/vulkan/radv_query.c | 29 -
2 files changed, 21 insertions(+), 9 deletions(-)
diff --git a/src/amd/common/sid.h b/src/amd/common/sid.h
index 3b3983fe27..0a2c616e64 100644
--- a/src/amd
From: Dave Airlie
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_cmd_buffer.c | 41
src/amd/vulkan/radv_private.h| 2 ++
src/amd/vulkan/si_cmd_buffer.c | 7 ---
3 files changed, 35 insertions(+), 15 deletions(-)
diff --git a/src/amd
From: Dave Airlie
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
index
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 27 ---
src/amd/vulkan/radv_private.h | 2 +-
2 files changed, 21 insertions(+), 8 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 3aac247f8b..2e802d2b7e
From: Dave Airlie
This is so we can submit on separate queues if needed
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 4 ++--
src/amd/vulkan/radv_radeon_winsys.h | 1 +
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 13 ++---
3 files
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_cmd_buffer.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 7d7f55a145..3c5fe25ce6 100644
--- a/src/amd/vulkan
From: Dave Airlie
v2: Don't expose the SDMA queue and use the CIK check also in the
second if. (Bas)
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 52 ++--
1 file changed, 41 insertions(+), 11 deletions(-)
diff --git a/sr
From: Dave Airlie
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta_bufimage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_meta_bufimage.c
b/src/amd/vulkan/radv_meta_bufimage.c
index 984b3472e8..24e10b2518 100644
--- a/src/amd/vulkan
From: Dave Airlie
Reviewed-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 29 -
src/amd/vulkan/radv_radeon_winsys.h | 9 ++
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 45 +--
3 files changed, 72 insertions
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 10 +--
src/amd/vulkan/radv_radeon_winsys.h | 3 +-
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 34 +--
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.h | 6
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_meta_buffer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_meta_buffer.c
b/src/amd/vulkan/radv_meta_buffer.c
index 42297b9ce9..cd2973fa4a 100644
--- a/src/amd/vulkan/radv_meta_buffer.c
+++ b
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/si_cmd_buffer.c | 36 +---
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
index 5ac2a14809..4b2624cb8e 100644
--- a/src/amd/vulkan
Not sure where the 16k comes from, but pretty sure 2k is the max.
Signed-off-by: Bas Nieuwenhuizen
---
src/amd/vulkan/radv_device.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 6362e9ead1
Reviewed-by: Bas Nieuwenhuizen
Does dual source blending work now with this patch? And do you need me
to commit it?
- Bas
On Fri, Dec 16, 2016 at 2:25 AM, Fredrik Höglund wrote:
> Add the index to the location when assigning driver locations for
> output variables.
>
> Otherwise
ed or not.
>
> Cc: Michel Dänzer
> Cc: Dave Airlie
> Signed-off-by: Emil Velikov
> ---
> Afacit there is no system with more than one Intel GPU, but on the other
> hand one can easily have setup with many AMD cards.
>
> Dave, any reason why we are capped at 1 device ?
Left
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 22, 2016 at 12:46 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> Thanks to Ilia's patch this works fine on radv.
>
> No regressions in CTS, all enabled tests pass.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulka
Not sure why this was disabled in the first place?
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 22, 2016 at 1:21 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> This passes all the CTS tests that get enabled for this.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vul
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 22, 2016 at 2:09 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> it appears from the amdgpu-pro results the hw can do more,
> but let's just align with radeonsi for now.
>
> No CTS regressions.
>
> Signed-off-by: Dave Ai
Reviewed-by: Bas Nieuwenhuizen
On Thu, Dec 22, 2016 at 2:53 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> These are taken from the amdgpu-pro driver, and cause no
> CTS change.
>
> Signed-off-by: Dave Airlie
> ---
> src/amd/vulkan/radv_device.c | 6 +++---
> 1
, as LLVM can merge them.
Reviewed-by: Bas Nieuwenhuizen
>
> Signed-off-by: Dave AIrlie
> ---
> src/amd/common/ac_nir_to_llvm.c | 41
> +
> 1 file changed, 29 insertions(+), 12 deletions(-)
>
> diff --git a/src/amd/common/
Reviewed-by: Bas Nieuwenhuizen
On Fri, Dec 23, 2016 at 7:43 AM, Dave Airlie wrote:
> From: Dave Airlie
>
> doom was causing a printf about an illegal color, it was due the
> non-void returning -1, and the other function checking for 4,
> align these.
>
> Signe
On Fri, Jul 1, 2016 at 1:21 AM, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeonsi/si_debug.c | 4
> src/gallium/drivers/radeonsi/si_pipe.c | 20 +++-
> src/gallium/drivers/radeonsi/si_pipe.h | 1 +
> 3 files changed, 24 insertions(+), 1 deleti
On Fri, Jul 1, 2016 at 2:24 PM, Marek Olšák wrote:
> On Fri, Jul 1, 2016 at 2:16 PM, Bas Nieuwenhuizen
> wrote:
>> On Fri, Jul 1, 2016 at 1:21 AM, Marek Olšák wrote:
>>> From: Marek Olšák
>>>
>>> ---
>>> src/gallium/drivers/radeonsi/si_deb
Series is
Reviewed-by: Bas Nieuwenhuizen
On Fri, Jul 1, 2016 at 1:21 AM, Marek Olšák wrote:
> Hi,
>
> This series adds apitrace call tracking into ddebug and radeonsi and
> other improvements.
>
> It will improve our debugging and profiling possibilities. Just set
> GAL
On Wed, Jul 27, 2016 at 3:33 PM, Emil Velikov wrote:
> On 6 June 2016 at 16:46, Bas Nieuwenhuizen wrote:
>> On Mon, Jun 6, 2016 at 5:14 PM, Nicolai Hähnle wrote:
>>> On 06.06.2016 00:28, Bas Nieuwenhuizen wrote:
>>>>
>>>> This fixes a problem with the C
Reviewed-by: Bas Nieuwenhuizen
for both.
On Thu, Jan 10, 2019 at 11:26 PM Nicolai Hähnle wrote:
>
> From: Nicolai Hähnle
>
> Only on LLVM 8.0+, which supports the new intrinsic.
> ---
> src/amd/common/ac_llvm_build.c | 10 +++---
> 1 file changed, 7 inser
On Thu, Dec 20, 2018 at 8:05 PM Rhys Perry wrote:
>
> Fixes: f4e499ec79 ('radv: add initial non-conformant radv vulkan driver')
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107986
> Signed-off-by: Rhys Perry
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 59 ++
I think this is done with
https://patchwork.freedesktop.org/series/55025/
?
On Sat, Jan 12, 2019 at 12:53 AM Marek Olšák wrote:
>
> From: Marek Olšák
>
> ---
> src/amd/common/ac_llvm_build.c | 18 +-
> .../drivers/radeonsi/si_shader_tgsi_mem.c | 4 ++--
>
On Wed, Jan 9, 2019, 2:37 PM Samuel Pitoiset A simple Vulkan extension that allows apps to query size and
> usage of all exposed memory heaps.
>
> The different usage values are not really accurate because
> they are per drm-fd, but they should be close enough.
>
> v3: - use atomic operations in t
Reviewed-by: Bas Nieuwenhuizen
On Mon, Jan 14, 2019 at 1:49 PM Samuel Pitoiset
wrote:
>
> Fix a crash with
> dEQP-VK.spirv_assembly.instruction.compute.workgroup_memory.float16
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_nir_to_llvm.c | 2 ++
> 1 fi
On Mon, Jan 14, 2019 at 5:55 PM Samuel Pitoiset
wrote:
>
> Fix crashes with
> dEQP-VK.spirv_assembly.instruction.compute.workgroup_memory.*16
>
> v2: - add INT16/UINT16 too
> - update commit description
>
> Signed-off-by: Samuel Pitoiset
> Reviewed-by: Bas Nieuw
Reviewed-by: Bas Nieuwenhuizen
On Tue, Jan 15, 2019 at 12:33 AM Marek Olšák wrote:
>
> From: Marek Olšák
>
> ported from AMDVLK.
>
> Cc: 18.3
> ---
> src/gallium/drivers/radeonsi/si_state_draw.c | 25 +++-
> 1 file changed, 14 insertions(+), 11 de
On Tue, Jan 15, 2019 at 10:59 PM Rhys Perry wrote:
>
> DXVK often sets dynamic state without actually changing it.
>
> Signed-off-by: Rhys Perry
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 92 ++--
> 1 file changed, 76 insertions(+), 16 deletions(-)
>
> diff --git a/sr
On Mon, Jan 14, 2019 at 5:12 PM Rhys Perry wrote:
>
> I did and found small improvements in Rise of the Tomb Raider. I
> measured framerates ~104.3% that of without the changes for the
> Geothermal Valley scene, ~101.2% for Spine of the Mountain and ~102.3%
> for Prophets Tomb.
My main question w
Besides CTS, I'd appreciate if you can test with Talos, as that was
the msot affected by bugs in this code.
Otherwise,
Reviewed-by: Bas Nieuwenhuizen
On Mon, Jan 14, 2019 at 5:02 PM Rhys Perry wrote:
>
> It's common in some applications to bind a new graphics pipeline wit
Reviewed-by: Bas Nieuwenhuizen
for the series.
On Thu, Jan 17, 2019 at 6:08 PM Samuel Pitoiset
wrote:
>
> Totally useless to write the descriptors inside the loop.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_device.c | 47 ++--
->ac.builder, array_idx,
> offset, "");
> + deref_instr = nir_src_as_deref(deref_instr->parent);
> + } else if (deref_instr->deref_type == nir_deref_type_struct) {
> + /* TODO: Probably need to do more here to
On Fri, Jan 18, 2019 at 5:44 PM Marek Olšák wrote:
>
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeonsi/si_buffer.c | 27
> src/gallium/drivers/radeonsi/si_pipe.h | 1 +
> 2 files changed, 28 insertions(+)
>
> diff --git a/src/gallium/drivers/radeonsi/si_buffe
On Fri, Jan 18, 2019 at 5:44 PM Marek Olšák wrote:
>
> From: Marek Olšák
>
> ---
> src/gallium/auxiliary/Makefile.sources | 1 +
> src/gallium/auxiliary/meson.build | 1 +
> src/gallium/auxiliary/util/u_cpu_suballoc.h | 90 +
> 3 files changed, 92 insertions(
Fair, r-b
On Sat, Jan 19, 2019 at 12:17 AM Timothy Arceri wrote:
>
>
>
> On 19/1/19 9:36 am, Bas Nieuwenhuizen wrote:
> > On Thu, Jan 10, 2019 at 6:59 AM Timothy Arceri
> > wrote:
> >>
> >> This builds on the recent interpolate fix by Rhys ee8488ea3b9
On Sat, Jan 19, 2019 at 12:27 AM Bas Nieuwenhuizen
wrote:
> On Sat, Jan 19, 2019 at 12:17 AM Timothy Arceri wrote:
> >
> >
> >
> > On 19/1/19 9:36 am, Bas Nieuwenhuizen wrote:
> > > On Thu, Jan 10, 2019 at 6:59 AM Timothy Arceri
> > > wrote:
> &
On Sat, Jan 19, 2019 at 2:10 AM Marek Olšák wrote:
>
> On Fri, Jan 18, 2019 at 6:08 PM Bas Nieuwenhuizen
> wrote:
>>
>> On Fri, Jan 18, 2019 at 5:44 PM Marek Olšák wrote:
>> >
>> > From: Marek Olšák
>> >
>> > ---
>> > sr
Ack, patches 1-6 are
Reviewed-by: Bas Nieuwenhuizen
On Sat, Jan 19, 2019 at 2:08 AM Marek Olšák wrote:
>
> On Fri, Jan 18, 2019 at 6:05 PM Bas Nieuwenhuizen
> wrote:
>>
>> On Fri, Jan 18, 2019 at 5:44 PM Marek Olšák wrote:
>> >
>> > From: Marek Olšák
Not really a fan of the whole renaming thing due to the blame and
cherrypicking churn, but a bunch of these are long overdue. The series
is
Reviewed-by: Bas Nieuwenhuizen
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https
RADV_FROM_HANDLE(radv_buffer, buffer,
> pCounterBuffers[counter_buffer_idx]);
> @@ -4999,6 +5014,8 @@ void radv_CmdEndTransformFeedbackEXT(
> * that the primitives-emitted query won't increment.
> */
>
Reviewed-by: Bas Nieuwenhuizen
On Sat, Jan 19, 2019 at 2:56 PM Rhys Perry wrote:
>
> It's common in some applications to bind a new graphics pipeline without
> ending up changing any context registers.
>
> This has a pipline have two command buffers: one for setting context
Reviewed-by: Bas Nieuwenhuizen
On Mon, Jan 21, 2019 at 11:38 PM Jason Ekstrand wrote:
>
> Fixes: 63b9aa2e2574 "spirv: Add support for using derefs for..."
> ---
> src/compiler/nir/nir_lower_phis_to_scalar.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletio
Reviewed-by: Bas Nieuwenhuizen
On Tue, Jan 22, 2019 at 10:20 PM Kristian Høgsberg wrote:
>
> On Tue, Jan 22, 2019 at 11:45 AM Rob Clark wrote:
> >
> > Normally modifiers take precendence over use flags, as they are more
> > explicit. But if the driver supports modifie
On Tue, Jan 22, 2019 at 4:32 PM Samuel Pitoiset
wrote:
>
> For some R8 formats, it's useless to export two channels
> when no alpha blending is used. I assume the CB should
> automatically clamps its inputs.
>
> 29077 shaders in 15096 tests
> Totals:
> SGPRS: 1321106 -> 1320970 (-0.01 %)
> VGPRS:
Reviewed-by: Bas Nieuwenhuizen
On Tue, Jan 22, 2019 at 7:27 PM Samuel Pitoiset
wrote:
>
> For example, if a pipeline has two stages VS and FS. And if only
> the fragment stage needs dynamic bindings, we shouldn't allocate
> an extra user SGPR for the vertex stage. Of cour
Reviewed-by: Bas Nieuwenhuizen
On Wed, Jan 23, 2019 at 10:26 AM Samuel Pitoiset
wrote:
>
> Streamout buffers are emitted like push constants.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>
Reviewed-by: Bas Nieuwenhuizen
On Thu, Jan 24, 2019 at 6:02 AM Timothy Arceri wrote:
>
> Fixes: b722b29f10d4 ("radv: add support for 16bit input/output")
> ---
>
> Compile tested only. Noticed when passing by.
>
> src/amd/common/ac_nir_to_llvm.c | 2 +-
>
On Mon, Jan 28, 2019 at 9:38 AM Eduardo Lima Mitev wrote:
>
> On 1/26/19 5:34 PM, Jason Ekstrand wrote:
> > Mind suffixing it with _ir3 or something since it's a back-end-specific
> > intrinsic? Incidentally, this looks a lot like load_image_param_intel.
> >
>
> Yes, I felt inclined to add the su
Reviewed-by: Bas Nieuwenhuizen
for the series.
On Fri, Jan 25, 2019 at 9:19 AM Samuel Pitoiset
wrote:
>
> Instead of using this useless array_params_mask variable.
> This should set these two attributes to streamout buffers too.
>
> Signed-off-by: Samuel Pitoiset
> ---
Well, if it looks good to you and you could reproduce before
Reviewed-by: Bas Nieuwenhuizen
On Mon, Jan 28, 2019 at 5:38 PM Samuel Pitoiset
wrote:
>
> This has been disabled some months ago because it introduced
> rendering issues with Shadow Of Warrier II (DXVK). This game is
&g
On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset
wrote:
>
> This is needed in order to inline some push constants when possible.
> This also adds a new helper for initializing the pass.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 2 ++
> src/amd/vulkan/radv_pri
On Tue, Jan 29, 2019 at 10:16 PM Samuel Pitoiset
wrote:
>
> That shouldn't change anything as we check if the last
> subpass id is the final subpass.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 16 +---
> 1 file changed, 13 insertions(+), 3 deletions
On Fri, Feb 1, 2019 at 8:52 AM Samuel Pitoiset
wrote:
>
>
> On 1/31/19 11:16 AM, Bas Nieuwenhuizen wrote:
> > On Tue, Jan 29, 2019 at 10:16 PM Samuel Pitoiset
> > wrote:
> >> That shouldn't change anything as we check if the last
> >> subpass id i
Reviewed-by: Bas Nieuwenhuizen
On Fri, Feb 1, 2019 at 12:07 PM Timothy Arceri wrote:
>
> Ported from d205faeb6c96.
> ---
> src/amd/vulkan/radv_nir_to_llvm.c | 6 +++---
> src/amd/vulkan/radv_private.h | 3 +++
> src/amd/vulkan/radv_shader.c | 10 --
>
Reviewed-by: Bas Nieuwenhuizen
for the series except 09 where I had comments.
On Tue, Jan 29, 2019 at 10:17 PM Samuel Pitoiset
wrote:
>
> Original patch by Fredrik Höglund.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 16 +++-
On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset
wrote:
>
> This removes some scalar loads from shaders, but it increases
> the number of SET_SH_REG packets. This is currently basic but
> it could be improved if needed. Inlining dynamic offsets might
> also help.
>
> Original idea from Dave Airlie.
On Tue, Feb 5, 2019 at 11:07 AM Samuel Pitoiset
wrote:
>
>
> On 2/5/19 10:58 AM, Bas Nieuwenhuizen wrote:
> > On Fri, Jan 25, 2019 at 5:27 PM Samuel Pitoiset
> > wrote:
> >> This removes some scalar loads from shaders, but it increases
> >> the number o
The variable is not static? (initializing a static member in the
constructor would be nonsense ...)
With that word remove from the title:
Reviewed-by: Bas Nieuwenhuizen
On Fri, Feb 8, 2019 at 6:26 AM Dave Airlie wrote:
>
> From: Dave Airlie
>
> Fixes coverity warning
> ---
&g
Reviewed-by: Bas Nieuwenhuizen
On Mon, Feb 11, 2019 at 1:16 PM Gustaw Smolarczyk wrote:
>
> FWIW,
>
> Reviewed-by: Gustaw Smolarczyk
>
> pon., 11 lut 2019 o 10:15 Samuel Pitoiset
> napisał(a):
> >
> > "The C standard says that compound literals which occu
Reviewed-by: Bas Nieuwenhuizen
I'm assuming the real fix is for the shader to not write the sample
mask if we have 1 sample?
On Tue, Feb 12, 2019 at 6:52 PM Samuel Pitoiset
wrote:
>
> For some reasons, this breaks trees rendering in Project Cars.
>
> Fixes: 85010585cde (&
On Tue, Feb 12, 2019 at 3:07 PM Samuel Pitoiset
wrote:
>
> It's unnecessary to load more channels than the vertex attribute
> format. The remaining channels are filled with 0 for y and z,
> and 1 for w.
>
> 29077 shaders in 15096 tests
> Totals:
> SGPRS: 1321605 -> 1318869 (-0.21 %)
> VGPRS: 93523
Reviewed-by: Bas Nieuwenhuizen
On Fri, Feb 15, 2019 at 3:57 PM Samuel Pitoiset
wrote:
>
> The elements added into a vector should have the same type as the
> first one, otherwise this hits an assertion in LLVM.
>
> Fixes: 4b3549c0846 ("radv: reduce the number of loaded
Reviewed-by: Bas Nieuwenhuizen
On Fri, Feb 15, 2019 at 6:00 PM Samuel Pitoiset
wrote:
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109597
> Cc: 18.3 19.0
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 8
> 1 file
Reviewed-by: Bas Nieuwenhuizen
for both.
On Thu, Feb 14, 2019 at 2:39 PM Samuel Pitoiset
wrote:
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_llvm_build.c | 41 ++
> 1 file changed, 27 insertions(+), 14 deletions(-)
>
>
Fixes: 4bb6c49375e "radv: Allow ETC2 on RAVEN and VEGA10 instead of all GFX9."
---
src/amd/vulkan/radv_device.c | 3 +--
src/amd/vulkan/radv_formats.c | 12 +---
src/amd/vulkan/radv_private.h | 1 +
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/amd/vulkan/radv_devi
Reviewed-by: Bas Nieuwenhuizen
On Sat, Feb 23, 2019 at 1:14 AM Ian Romanick wrote:
>
> Reviewed-by: Ian Romanick
>
> On 2/22/19 4:03 PM, Jason Ekstrand wrote:
> > The nir_swizzle helper is used some on it's own but it's also called by
> > nir_channel and nir_
Reviewed-by: Bas Nieuwenhuizen
On Fri, Mar 1, 2019 at 6:25 PM Samuel Pitoiset
wrote:
>
> This export format is faster. Seems to improve performance in
> Wreckfest.
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_pipeline.c | 2 +-
> 1 file changed, 1
Reviewed-by: Bas Nieuwenhuizen
On Mon, Mar 4, 2019 at 2:22 PM Samuel Pitoiset
wrote:
>
> If alignement is 0, offets returned by
> radv_cmd_buffer_upload_alloc() are always 0. These two
> virtual addresses were pointing at the same location.
>
> v2: - add an asertion that chec
On Tue, Mar 5, 2019 at 10:30 AM Samuel Pitoiset
wrote:
>
> Fixes: 58bcebd987b ("spirv: Allow [i/u]mulExtended to use new nir opcode")
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/common/ac_nir_to_llvm.c | 36 +
> 1 file changed, 36 insertions(+)
>
> diff --git
pace (the internal clear draws allocate space), but
> keep that way for consistency.
Isn't this what check_space does?
Reviewed-by: Bas Nieuwenhuizen
>
> Signed-off-by: Samuel Pitoiset
> ---
> src/amd/vulkan/radv_cmd_buffer.c | 2 +-
> 1 file changed, 1 insertion(+)
I actually think it is partially right, but lets indeed revert for now
Reviewed-by: Bas Nieuwenhuizen
On Fri, Mar 8, 2019 at 2:48 PM Samuel Pitoiset
wrote:
>
> This changes is actually wrong because we have to sync
> before doing image layout transitions.
>
> This fixes rend
oh, also add a Fixes tag please.
On Fri, Mar 8, 2019 at 2:50 PM Bas Nieuwenhuizen
wrote:
>
> I actually think it is partially right, but lets indeed revert for now
>
> Reviewed-by: Bas Nieuwenhuizen
>
> On Fri, Mar 8, 2019 at 2:48 PM Samuel Pitoiset
> wrote:
> >
&
hmm, nothing to disabled them again?
Reviewed-by: Bas Nieuwenhuizen
On Tue, Mar 5, 2019 at 6:06 PM Samuel Pitoiset
wrote:
>
> The mask should be accumulated if two calls are used for
> binding two buffers at different indexes. Otherwise, the
> driver only accounts for the last one.
r-b
On Mon, Mar 11, 2019 at 10:23 AM Samuel Pitoiset
wrote:
>
> The values should match the ones that are emitted.
>
> This fixes new CTS dEQP-VK.rasterization.primitive_size.points.*.
>
> Fixes: f4e499ec791 ("radv: add initial non-conformant radv vulkan driver")
> Signed-off-by: Samuel Pitoiset
r-b for the series
On Tue, Feb 26, 2019 at 1:39 PM Samuel Pitoiset
wrote:
>
> This drastically reduces the number of SGPRs because the driver
> now uses descriptors per vertex binding, instead of per vertex
> attribute format.
>
> 29077 shaders in 15096 tests
> Totals:
> SGPRS: 1354285 -> 1282109
201 - 300 of 2366 matches
Mail list logo
