[Mesa-dev] [PATCH] editorconfig: Add max_line_length property

2019-01-07 Thread Andres Gomez
The property is supported by the most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc: Eric Anholt Signed-off-by: Andres Gomez --- .editorconfig | 1 + 1 file changed, 1 insertion(+) diff --git a

[Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Andres Gomez
Correct a typo introduced by 037f68d81e1 ("glsl: apply align layout qualifier rules to block offsets") Cc: Timothy Arceri Signed-off-by: Andres Gomez --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir

[Mesa-dev] [PATCH] glsl/linker: specify proper direction in location aliasing error

2019-01-07 Thread Andres Gomez
The check for location aliasing was always asuming output variables but this validation is also called for input variables. Fixes: e2abb75b0e4 ("glsl/linker: validate explicit locations for SSO programs") Cc: Iago Toral Quiroga Signed-off-by: Andres Gomez --- src/com

Re: [Mesa-dev] [PATCH] glsl: correct typo in GLSL compilation error message

2019-01-07 Thread Andres Gomez
On Mon, 2019-01-07 at 16:48 +0100, Erik Faye-Lund wrote: > On Mon, 2019-01-07 at 15:50 +0200, Andres Gomez wrote: > > Correct a typo introduced by > > 037f68d81e1 ("glsl: apply align layout qualifier rules to block > > offsets") > > > > Cc: Timo

[Mesa-dev] [PATCH] docs: complete the calendar and release schedule documentation

2019-01-07 Thread Andres Gomez
As suggested by Emil Velikov. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 10 ++ docs/releasing.html| 14 -- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/docs/release

[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Andres Gomez
ngestrom Cc: Dylan Baker Cc: Emil Velikov Signed-off-by: Andres Gomez --- bin/get-pick-list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh index 3099fc69413..d71ff4a708a 100755 --- a/bin/get-pick-list.sh +++ b/bin/get-

[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

2019-01-11 Thread Andres Gomez
"&>" is bash specific. Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid sha") Cc: Juan A. Suarez Cc: Eric Engestrom Cc: Dylan Baker Cc: Emil Velikov Signed-off-by: Andres Gomez --- bin/get-pick-list.sh | 2 +- 1 file changed, 1 insert

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Andres Gomez
I'll start with the 18.3.2 release process and keep with the the following bugfix releases by now. On Mon, 2019-01-07 at 15:33 +0200, Andres Gomez wrote: > Emil, the 18.3.2 should have already happened by the 19th of December. > > Is there anything stopping you from going

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Andres Gomez
On Fri, 2019-01-11 at 15:22 +, Emil Velikov wrote: > Hi Andres, > > On Fri, 11 Jan 2019 at 15:05, Andres Gomez wrote: > > > > I'll start with the 18.3.2 release process and keep with the the > > following bugfix releases by now. > > > > I was

Re: [Mesa-dev] [PATCH] i965/vec4: use a temp register to compute offsets for pull loads

2018-02-20 Thread Andres Gomez
Iago, this looks like a good candidate to nominate for inclusion in the 17.3 stable queue. What do you think? On Wed, 2017-11-29 at 11:49 +0100, Iago Toral Quiroga wrote: > 64-bit pull loads are implemented by emitting 2 separate > 32-bit pull load messages, where the second message loads from >

Re: [Mesa-dev] [PATCH] program: Don't reset SamplersValidated when restoring from shader cache

2018-02-20 Thread Andres Gomez
Jordan, this looks like a good candidate to nominate for inclusion in the 17.3 stable queue. What do you think? On Tue, 2017-12-12 at 14:20 -0800, Jordan Justen wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103988 > Signed-off-by: Jordan Justen > --- > src/mesa/program/ir_to_m

Re: [Mesa-dev] [PATCH] swr: remove dead LLVM code paths

2018-02-23 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Tue, 2018-02-20 at 18:03 +, Emil Velikov wrote: > From: Emil Velikov > > LLVM requirement was bumped to 4.0.0 with earlier commit. > Hence any code tailored for older versions is now unreachable. > > Cc: George Kyriazis > Cc: A

[Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Andres Gomez
3 digits versions in LLVM only started from 3.4.1 on. Hence, if you have installed 3.4 or below, meson will fail even when we may not make use of LLVM. Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Andres Gomez --- meson.build | 13 - 1 file changed, 12 insertions(+), 1

[Mesa-dev] [PATCH 0/2] travis: make meson Vulkan build again

2018-02-28 Thread Andres Gomez
The "meson Vulkan" target has been failing for quite long. These 2 patches will make it work again. Andres Gomez (2): meson: fix LLVM version detection when <= 3.4 travis: make Meson find the proper llvm-config .travis.yml | 28 mes

[Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

2018-02-28 Thread Andres Gomez
patch similar to: https://lists.freedesktop.org/archives/mesa-dev/2017-December/180217.html Cc: Eric Engestrom Cc: Dylan Baker Cc: Emil Velikov Cc: Juan A. Suarez Romero Cc: Gert Wollny Cc: Jon Turney Signed-off-by: Andres Gomez --- .travis.yml | 28 1 file change

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Andres Gomez
On Wed, 2018-02-28 at 17:12 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > > >

Re: [Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

2018-02-28 Thread Andres Gomez
On Wed, 2018-02-28 at 18:53 +0100, Gert Wollny wrote: > Am Mittwoch, den 28.02.2018, 17:52 +0200 schrieb Andres Gomez: [...] > > + test -f /usr/bin/llvm-config && ln -s /usr/bin/llvm-config > > $HOME/prefix/bin > > I'm not sure how the toolchain packag

[Mesa-dev] [PATCH v2] meson: fix LLVM version detection when <= 3.4

2018-02-28 Thread Andres Gomez
3 digits versions in LLVM only started from 3.4.1 on. Hence, if you have installed 3.4 or below, meson will fail even when we may not make use of LLVM. v2: Properly compare LLVM version and set patch version to 0 if < 3.4.1 (Eric). Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: And

[Mesa-dev] [PATCH v2] travis: make Meson find the proper llvm-config

2018-02-28 Thread Andres Gomez
patch similar to: https://lists.freedesktop.org/archives/mesa-dev/2017-December/180217.html v2: Create the link only to the specificly wanted LLVM version (Gert). Cc: Eric Engestrom Cc: Dylan Baker Cc: Emil Velikov Cc: Juan A. Suarez Romero Cc: Gert Wollny Cc: Jon Turney Signed-off-by: Andres

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

2018-03-01 Thread Andres Gomez
On Thu, 2018-03-01 at 09:25 +, Eric Engestrom wrote: [...] > > Oh, my apologies, I didn't think about that! > Can you add that paragraph in the commit message so it's clearer? > (I know there was already a mention of that, but I had not understood it the > first time around) > > > > > You

[Mesa-dev] [PATCH] egl: remove redundant initialization

2018-03-02 Thread Andres Gomez
Found by inspection. Cc: Ian Romanick Cc: Emil Velikov Cc: Eric Engestrom Signed-off-by: Andres Gomez --- src/egl/main/eglcontext.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index 18c1bc59acc..3e5d8ad97bf 100644 --- a/src/egl

[Mesa-dev] [PATCH 0/3] update MESA_GL_VERSION_OVERRIDE usage and documentation

2018-03-02 Thread Andres Gomez
A small series mostly adding up to date documentation for MESA_GL_VERSION_OVERRIDE. Additionally, patch 1/3 keeps OpenGL 3.1 compat profile when setting MESA_GL_VERSION_OVERRIDE=3.1, after the behavior change done at a0c8b49284e. Andres Gomez (3): mesa: override to GL core API only when >=

[Mesa-dev] [PATCH 2/3] mesa: adds some comments regarding MESA_GLES_VERSION_OVERRIDE usage

2018-03-02 Thread Andres Gomez
Fixes: 03fd6704db9 ("mesa: Add support for a new override string MESA_GLES_VERSION_OVERRIDE") Cc: Jordan Justen Cc: Ian Romanick Signed-off-by: Andres Gomez --- src/mesa/main/version.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/versi

[Mesa-dev] [PATCH 3/3] mesa: add documentation for COMPAT suffix for MESA_GL_VERSION_OVERRIDE

2018-03-02 Thread Andres Gomez
Fixes: 2599b92eb97 ("mesa: allow forcing >=3.1 compatibility contexts with MESA_GL_VERSION_OVERRIDE") Cc: Marek Olšák Cc: Jordan Justen Cc: Ian Romanick Cc: Eric Engestrom Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/envvars.html | 6 -- src/mesa/main/versi

[Mesa-dev] [PATCH 1/3] mesa: override to GL core API only when >= 3.2

2018-03-02 Thread Andres Gomez
enGL 3.1 with ARB_compatibility") Cc: Marek Olšák Cc: Jordan Justen Cc: Ian Romanick Cc: Eric Engestrom Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/envvars.html | 12 ++-- src/mesa/main/version.c | 7 --- 2 files changed, 10 insertions(+), 9 deletions(-) diff

[Mesa-dev] [PATCH] dri_util: when overriding, always reset the core version

2018-03-02 Thread Andres Gomez
-deqp-case=KHR-GL46.info.vendor While, this will fail: $ MESA_GL_VERSION_OVERRIDE=4.6COMPAT ./glcts --deqp-case=KHR-GL46.info.vendor Fixes: 464c56d3d5c ("dri_util: Use _mesa_override_gl_version_contextless") Cc: Ian Romanick Cc: Tapani Pälli Cc: Marek Olšák Signed-off-by: Andres Gomez

[Mesa-dev] [PATCH] dri_util: fallback to core with drivers not supporting compat for 3.1

2018-03-02 Thread Andres Gomez
om Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/features.txt | 4 ++-- src/mesa/drivers/dri/common/dri_util.c | 10 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 5eae34bf0df..d53dd805b

[Mesa-dev] [PATCH] travis: keep meson version below 0.45.0

2018-03-05 Thread Andres Gomez
Recently Meson upgraded to 0.45.0 and it needs python 3.5+, which is not available in Trusty. Cc: Eric Engestrom Cc: Dylan Baker Cc: Emil Velikov Cc: Jon Turney Signed-off-by: Andres Gomez --- .travis.yml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.travis.yml

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Andres Gomez
Thanks Mark for bringing this thread to my attention by Ccing me ☺ I'll try to be brief and just comment inline. On Fri, 2018-03-09 at 12:12 -0800, Mark Janes wrote: > Ilia Mirkin writes: > > > On Tue, Mar 6, 2018 at 2:34 PM, Emil Velikov > > wrote: > > > So while others explore ways of impro

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-12 Thread Andres Gomez
Thanks for opening this thread Emil. I will open new branches for other topics that have been boiling in our minds for a while. I hope you, Emil, can forgive us for not having been more diligent with those, as you are already aware of some of them ... 😇 On Tue, 2018-03-06 at 19:34 +, Emil Vel

Re: [Mesa-dev] [RFC] Mesa release improvements - Release schedule

2018-03-12 Thread Andres Gomez
Hi, * Release schedule: move from pre-announce Wed, announcement Fri [0] to pre-announce Mon, announcement Wed. * Why would we want to do this? * We have delays in the release every now and then. When this happens, we step already into the weekend which is bad for the

Re: [Mesa-dev] [RFC] Mesa release improvements - Release calendar

2018-03-12 Thread Andres Gomez
Hi, * Release calendar policy: so far, we are setting the calendar [0] ad- hoc and it may be better to have a clear policy to deal with delays, etc. * If any stable release could be delayed due to high load, rise the hand as soon as possible so other person in the release ma

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

2018-03-12 Thread Andres Gomez
Hi, Juan and I have been talking lately that it is clear that reaching the final version of a feature releases is often getting hard. Therefore, we would like to propose that no stable release will be carried on by the same release team member while on duty doing a feature release. This will help

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

2018-03-12 Thread Andres Gomez
On Mon, 2018-03-12 at 16:45 +0100, Juan A. Suarez Romero wrote: > > > On Mon, 2018-03-12 at 17:17 +0200, Andres Gomez wrote: [...] > > My proposal would be, similarly to what Intel does to track [1] the > > stabilization for a release, 1 week (?) prior to the branching

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

2018-03-14 Thread Andres Gomez
Hi, On Mon, 2018-03-12 at 18:02 +, Emil Velikov wrote: > Hi Andres, > > On 12 March 2018 at 15:57, Andres Gomez wrote: > > [...] > > > > 18.1 example: > > > >1. Create a Metabug for the 18.1 branch point. > >2. Announce the Metabug i

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

2018-03-14 Thread Andres Gomez
On Mon, 2018-03-12 at 15:48 +, Emil Velikov wrote: > On 12 March 2018 at 14:20, Andres Gomez wrote: [...] > > On Tue, 2018-03-06 at 19:34 +, Emil Velikov wrote: > > > > [...] > > > > > A few other ideas that were also came to mind: > > >

Re: [Mesa-dev] [RFC] Mesa release improvements - Feature and Stable releases

2018-03-14 Thread Andres Gomez
On Wed, 2018-03-14 at 16:02 +, Emil Velikov wrote: [...] > > Just double-checking: > I would suspect you're not suggesting removing the existing email/poke scheme? Partially. The "announce" mail for the pre-branching period will still happen, pointing to the "Metabug" in which to add the WIP

[Mesa-dev] [PATCH] configure: remove unneeded XCB_REQUIRED

2018-03-14 Thread Andres Gomez
, respectively. Cc: Emil Velikov Cc: Eric Engestrom Signed-off-by: Andres Gomez --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 621dc328d90..4392a427699 100644 --- a/configure.ac +++ b/configure.ac @@ -90,7 +90,6

Re: [Mesa-dev] [PATCH] configure: remove unneeded XCB_REQUIRED

2018-03-14 Thread Andres Gomez
On Thu, 2018-03-15 at 09:37 +1000, Dave Airlie wrote: > On 15 March 2018 at 09:29, Andres Gomez wrote: > > It is only used for dri3 and xcb-dri3 and xcb-present were already > > mandating the minimal version, which is incoherent with the xcb one. > > We are in the middle o

[Mesa-dev] [PATCH 3/3] vbo: provide 64bits support to print_draw_arrays

2018-01-28 Thread Andres Gomez
Cc: Mathias Fröhlich Cc: Brian Paul Signed-off-by: Andres Gomez --- src/mesa/vbo/vbo_exec_array.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index e80c5baaf79..435f0a0851f 100644 --- a

[Mesa-dev] [PATCH] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

2018-01-28 Thread Andres Gomez
/show_bug.cgi?id=103006 Cc: Alejandro Piñeiro Cc: Juan A. Suarez Romero Cc: Antia Puentes Cc: Rafael Antognolli Cc: Kenneth Graunke Signed-off-by: Andres Gomez --- src/mesa/drivers/dri/i965/genX_state_upload.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --

[Mesa-dev] [PATCH 1/3] vbo: print first element of the VAO when the binding stride is 0

2018-01-28 Thread Andres Gomez
Cc: Mathias Fröhlich Cc: Brian Paul Signed-off-by: Andres Gomez --- src/mesa/vbo/vbo_exec_array.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c index d990fdf7a8d..aa5f3cbf23e 100644 --- a/src/mesa/vbo

[Mesa-dev] [PATCH 0/3] vbo: small improvements to print_draw_arrays

2018-01-28 Thread Andres Gomez
Just a small series adding some bits to the debug function print_draw_arrays. Andres Gomez (3): vbo: print first element of the VAO when the binding stride is 0 vbo: take into account the size when printing VAO elements vbo: provide 64bits support to print_draw_arrays src/mesa/vbo

[Mesa-dev] [PATCH 2/3] vbo: take into account the size when printing VAO elements

2018-01-28 Thread Andres Gomez
When using print_draw_arrays for debugging, we were printing an "n" amount of vertex but that meant not to print all the size in the "n" vertex, depending on the stride used. Now we print the whole size in the "n" vertex. Cc: Mathias Fröhlich Cc: Brian Pau

[Mesa-dev] [PATCH v2] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

2018-01-29 Thread Andres Gomez
jandro and Antía. Fixes: 75968a668e4 ("i965/gen7: expose OpenGL 4.2 on Haswell when supported") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103006 Cc: Alejandro Piñeiro Cc: Juan A. Suarez Romero Cc: Antia Puentes Cc: Rafael Antognolli Cc: Kenneth Graunke Signed-off-by:

[Mesa-dev] [PATCH] i965: check if compare is 0 explicitely, when downsizing a format

2018-02-01 Thread Andres Gomez
downsize_format_if_needed takes an integer as number of uploads parameter. Hence, let's do an integer comparation instead of a boolean check, since that is confusing. Since we are at it, fix a couple of wrongly tabbed indents. Cc: Alejandro Piñeiro Cc: Kenneth Graunke Signed-off-by: A

[Mesa-dev] [PATCH v2] i965: check if upload is 0 explicitely, when downsizing a format

2018-02-01 Thread Andres Gomez
downsize_format_if_needed takes an integer as number of uploads parameter. Hence, let's do an integer comparation instead of a boolean check, since that is confusing. Since we are at it, fix a couple of wrongly tabbed indents. Cc: Alejandro Piñeiro Cc: Kenneth Graunke Signed-off-by: A

[Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

2018-02-06 Thread Andres Gomez
Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") Cc: Marek Olšák Cc: Emil Velikov Cc: Jan Vesely Signed-off-by: Andres Gomez --- Additionally, AMD's support removal for LLVM 3.9 has also affected the distcheck target. Unfortunately, SWR distribution needs 3.9.x, there

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

2018-02-06 Thread Andres Gomez
On Tue, 2018-02-06 at 11:01 -0500, Jan Vesely wrote: > On Tue, 2018-02-06 at 17:42 +0200, Andres Gomez wrote: > > Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") > > Cc: Marek Olšák > > Cc: Emil Velikov > > Cc: Jan Ve

[Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 4.0

2018-02-13 Thread Andres Gomez
") Cc: George Kyriazis Cc: Tim Rowley Cc: Emil Velikov Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Andres Gomez --- .travis.yml | 15 ++- configure.ac| 6 +++--- meson.build | 4 ++-- src/gallium/d

Re: [Mesa-dev] [PATCH] travis: radeonsi and radv need LLVM 4.0

2018-02-13 Thread Andres Gomez
customers. Will > > respond shortly. > > > > Thanks, > > > > George > > > > > On Feb 6, 2018, at 9:42 AM, Andres Gomez > > > wrote: > > > > > > Fixes: 3bf1e036e8a ("amd: remove support for LLVM 3.9") > > > Cc:

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-09 Thread Andres Gomez
On Fri, 2017-03-10 at 08:32 +1100, Timothy Arceri wrote: > On 23/02/17 19:55, Andres Gomez wrote: > > Commit f1293b2f9bc3 split apart buffer block arrays but introduced > > also the possibility of a recount of active > > blocks (NumUniformBlocks/NumShaderStorageB

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-09 Thread Andres Gomez
On Fri, 2017-03-10 at 14:28 +1100, Timothy Arceri wrote: > > On 10/03/17 08:46, Andres Gomez wrote: > > On Fri, 2017-03-10 at 08:32 +1100, Timothy Arceri wrote: > > > On 23/02/17 19:55, Andres Gomez wrote: > > > > Commit f1293b2f9bc3 split apart buffer block array

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-11 Thread Andres Gomez
On Sat, 2017-03-11 at 23:24 +1100, Timothy Arceri wrote: > > On 10/03/17 18:53, Andres Gomez wrote: > > > > According with that text it would be OK to report a different number > > than 0 when asking for the active UBOs to the failed link program but > > it still wi

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-11 Thread Andres Gomez
On Sun, 2017-03-12 at 10:07 +1100, Timothy Arceri wrote: > > On 12/03/17 00:29, Andres Gomez wrote: > > On Sat, 2017-03-11 at 23:24 +1100, Timothy Arceri wrote: > > > > > > On 10/03/17 18:53, Andres Gomez wrote: > > > > > > > > Accordi

Re: [Mesa-dev] [PATCH 1/3] glsl: on UBO/SSBOs link error, the number of active blocks remains 0

2017-03-21 Thread Andres Gomez
On Sun, 2017-03-12 at 16:34 +1100, Timothy Arceri wrote: > > On 12/03/17 12:17, Andres Gomez wrote: > > On Sun, 2017-03-12 at 10:07 +1100, Timothy Arceri wrote: > > > > > > On 12/03/17 00:29, Andres Gomez wrote: > > > > On Sat, 2017-

Re: [Mesa-dev] [PATCH 3/4] ac/nir: fix 64-bit shifts

2017-08-16 Thread Andres Gomez
Connor, it looks like we could want this patch in 17.1 (?) On Fri, 2017-06-30 at 19:56 -0700, Connor Abbott wrote: > From: Connor Abbott > > NIR always makes the shift amount 32 bits, but LLVM asserts if the two > sources aren't the same type. Zero-extend the shift amount to make LLVM > happy. >

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] swr: use the correct variable for no undefined symbols

2017-08-16 Thread Andres Gomez
Emil, this patch breaks SWR build in 17.1, although it states that fixes 9475251145174882b532. Should I assume that this should be dropped for 17.1 or are you planning to send some backport (?). On Fri, 2017-07-21 at 19:05 +0100, Emil Velikov wrote: > From: Emil Velikov > > The variable name wa

Re: [Mesa-dev] [PATCH 3/4] ac/nir: fix 64-bit shifts

2017-08-16 Thread Andres Gomez
Connor, it looks like we could want this patch in 17.1 (?) On Fri, 2017-06-30 at 19:56 -0700, Connor Abbott wrote: > From: Connor Abbott > > NIR always makes the shift amount 32 bits, but LLVM asserts if the two > sources aren't the same type. Zero-extend the shift amount to make LLVM > happy. >

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/4] ac/nir: fix 64-bit shifts

2017-08-17 Thread Andres Gomez
the Vulkan CTS so we > can catch stuff like this easier. > > On Wed, Aug 16, 2017 at 8:49 PM, Andres Gomez wrote: > > Connor, it looks like we could want this patch in 17.1 (?) > > > > On Fri, 2017-06-30 at 19:56 -0700, Connor Abbott wrote: > > > From: Conn

Re: [Mesa-dev] [PATCH] radeon/ac: use ds_swizzle for derivs on si/cik.

2017-08-17 Thread Andres Gomez
Hi Dave, this patch has been collected for 17.2.0-rc3 but, for 17.1.x, the conflicts are not so trivial and the landed commit was tagged for stable without specifying the actual branch. Therefore, unless you intended this also for 17.1.x and would like to provide a backport, I'm more keen on drop

Re: [Mesa-dev] [PATCH] radeonsi/gfx9: use the VI codepath for clamping Z

2017-08-18 Thread Andres Gomez
Hi Marek, This patch landed tagged for 17.2 stable and has been collected for 17.2.0-rc4. However, it seems like it could be also interesting for 17.1.x (?) WDYT? Br. On Thu, 2017-08-10 at 22:33 +0200, Marek Olšák wrote: > From: Marek Olšák > > This fixes corrupted shadows in Unigine Valley.

[Mesa-dev] Mesa 17.1.7 release candidate

2017-08-19 Thread Andres Gomez
Jason Ekstrand (1): i965: Stop looking at NewDriverState when emitting 3DSTATE_URB Queued (33) === Andres Gomez (7): cherry-ignore: add "swr: use the correct variable for no undefined symbols" cherry-ignore: add "radeon/ac: use ds_swizzle for derivs on

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-19 Thread Andres Gomez
On Sat, 2017-08-19 at 21:40 +0100, Emil Velikov wrote: > [Slimming down the CC list] > > Hi Andres, > > On 19 August 2017 at 16:37, Andres Gomez wrote: > > > 4c09f648929fbde25e4be44fa2983c0f3ac2fd11 > > commit 774e77ab64de05d437939110dd11c35a300d47f6 > Seems

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-20 Thread Andres Gomez
On Sat, 2017-08-19 at 17:56 -0400, Ilia Mirkin wrote: > On Sat, Aug 19, 2017 at 11:37 AM, Andres Gomez wrote: > > nouveau's nv50 has gotten a fix for a problem involving ConstantFolding > > with saturation that was visible in Hitman Absolution and, possibly, in > > some

Re: [Mesa-dev] Mesa 17.1.7 release candidate

2017-08-20 Thread Andres Gomez
On Sun, 2017-08-20 at 07:19 -0700, Jason Ekstrand wrote: > On August 19, 2017 8:38:04 AM Andres Gomez wrote: > [...] > > > > Mesa stable queue > > - > > > > Nominated (3) > > = > > > > Ilia Mirkin (1): > &

[Mesa-dev] [ANNOUNCE] mesa 17.1.7

2017-08-21 Thread Andres Gomez
enabled. EGL has gotten a fix to avoid a crash if an invalid display is used. In the DRI2 drivers, the X11 platform received a fix to prevent leaking xfixes_query in the error path. From build and integration point of view, we have added a fix to solve building on old glibc. Andres

Re: [Mesa-dev] [PATCH] isl: Validate row pitch of stencil surfaces.

2017-08-22 Thread Andres Gomez
On Thu, 2017-08-10 at 12:51 -0700, Jason Ekstrand wrote: > On August 10, 2017 12:45:43 PM Ilia Mirkin wrote: > > > On Wed, Aug 9, 2017 at 4:09 PM, Kenneth Graunke > > wrote: > > > Also, silence an obnoxious finishme that started occurring for all > > > GL applications which use stencil after th

Re: [Mesa-dev] [Mesa-stable] [PATCH] i965/tex: Don't pass samples to miptree_create_for_teximage

2017-08-22 Thread Andres Gomez
Jason, 76e2f390f9863a35 didn't land in 17.1 so I understand this is not really needed there and we only need it for 17.2. WDYT? On Sat, 2017-08-19 at 11:07 -0700, Jason Ekstrand wrote: > In 76e2f390f9863a35, when Topi switched num_samples from 0 to 1 for > single-sampled, he accidentally switche

Re: [Mesa-dev] [PATCH] ac/nir: fixup layer/viewport export for GFX9.

2017-08-23 Thread Andres Gomez
Hi Dave, This patch landed tagged for 17.2 only. Was it, then, not nominated for 17.1 intentionally ? Br. On Thu, 2017-08-17 at 14:27 +1000, Dave Airlie wrote: > From: Dave Airlie > > GFX9 moved where the viewport index export goes. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_n

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965: Make a BRW_NEW_FAST_CLEAR_COLOR dirty bit.

2017-08-24 Thread Andres Gomez
Kenneth, for 17.1, this patch depends on f9fd976e8adb and others. If you still want to add it for 17.1, I think we would need a backport. Br. On Thu, 2017-08-17 at 15:16 -0700, Kenneth Graunke wrote: > When changing fast clear colors, we need to emit new SURFACE_STATE > with the updated color at

[Mesa-dev] [PATCH 0/2] docs: update the release calendar until the end of 2017

2017-08-25 Thread Andres Gomez
The first email updates the calendar with a proposal for the future releases until the end of 2017. It also removes versions that have already been released. The second patch is a proposal to add yet another final iteration to the 17.1 cycle. Andres Gomez (2): docs: remove released and extend

[Mesa-dev] [PATCH 1/2] docs: remove released and extend the calendar until the end of 2017

2017-08-25 Thread Andres Gomez
Completed the 17.2 cycle and added the beginning of the 17.3 one. Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/release-calendar.html | 86 ++ 1 file changed, 80 insertions(+), 6 deletions(-) diff --git a/docs

[Mesa-dev] [PATCH 2/2] docs: add an additional final cycle for 17.1

2017-08-25 Thread Andres Gomez
Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/release-calendar.html | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index 1ed3ae14a97..011e37a6765 100644 --- a/docs/release

[Mesa-dev] Mesa 17.1.8 release candidate

2017-08-25 Thread Andres Gomez
ndres Mesa stable queue - Nominated (0) = Queued (15) === Andres Gomez (5):   docs: add sha256 checksums for 17.1.7   cherry-ignore: cherry-ignore: added 17.2 nominations.   cherry-ignore: add "i965/tex: Don't pass samples to miptre

[Mesa-dev] [ANNOUNCE] mesa 17.1.8

2017-08-28 Thread Andres Gomez
radv includes a patch to prevent a potential crash. nouveau's has gotten a fix to properly set the sType for TXF ops to U32. For EGL, the Wayland platform of the the DRI2 drivers has received a fix to prevent a possible indefinite block. Andres Gomez (7):   docs: add sha256 checksums

Re: [Mesa-dev] [PATCH] i965: Set "Subslice Hashing Mode" to 16x16 on Apollolake.

2017-08-28 Thread Andres Gomez
Kenneth, would we want this patch in 17.1 or we shouldn't bother ? On Tue, 2017-05-30 at 16:28 -0700, Kenneth Graunke wrote: > As of 4.11, the kernel isn't bothering to set the subslice hashing mode > on Apollolake, leaving it at the default of 8x8. (It initializes it to > 16x4 on most platforms.

Re: [Mesa-dev] [PATCH] i965: Set "Subslice Hashing Mode" to 16x16 on Apollolake.

2017-09-04 Thread Andres Gomez
Thanks Eero! On Tue, 2017-08-29 at 12:26 +0300, Eero Tamminen wrote: > Hi, > > On 28.08.2017 17:33, Andres Gomez wrote: > > Kenneth, would we want this patch in 17.1 or we shouldn't bother ? > > See this for more extensive info on its impact: > https://bugs.fr

Re: [Mesa-dev] [Mesa-stable] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-09-04 Thread Andres Gomez
Jason, has this patch fallen through the cracks ? On Mon, 2017-08-21 at 22:11 -0700, Jason Ekstrand wrote: > I have no idea how this got missed but it's been missing since forever. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/compiler/spirv/vtn_variables.c | 5 - > 1 file changed, 4

Re: [Mesa-dev] [Mesa-stable] [PATCH] spirv: Add support for the HelperInvocation builtin

2017-09-05 Thread Andres Gomez
On Mon, 2017-09-04 at 09:14 -0700, Jason Ekstrand wrote: > Yeah, just haven't gotten around to pushing it. Feel free. Pushed! ☺ > > > On September 4, 2017 7:33:38 AM Andres Gomez wrote: > > > Jason, has this patch fallen through the cracks ? > > > > On

Re: [Mesa-dev] [PATCH 1/3] docs/releasing: remove -jX instances

2017-09-05 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Tue, 2017-09-05 at 15:21 +0100, Emil Velikov wrote: > From: Emil Velikov > > One can control the number of jobs via MAKEFLAGS. As such there's > little reason to set the number of jobs for each make invocation. > > Cc: Andres

Re: [Mesa-dev] [PATCH 2/3] docs/releasing: polish LLVM_CONFIG wording/handling

2017-09-05 Thread Andres Gomez
On Tue, 2017-09-05 at 15:21 +0100, Emil Velikov wrote: > From: Emil Velikov > > Use concistent way to manage "non-default" llvm installations, clearly ^^ consistent > documenting it. > > AKA, use LLVM_CONFIG throughout and unset for the Windows/mingw b

Re: [Mesa-dev] [PATCH 3/3] docs/release-calendar: update and extend

2017-09-05 Thread Andres Gomez
On Tue, 2017-09-05 at 15:21 +0100, Emil Velikov wrote: > From: Emil Velikov > > Cc: Andres Gomez > Signed-off-by: Emil Velikov > --- > docs/release-calendar.html | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > > diff --git a

Re: [Mesa-dev] [PATCH v2 3/3] docs/release-calendar: update and extend

2017-09-06 Thread Andres Gomez
On Tue, 2017-09-05 at 18:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > v2: Use correct 17.1.10 version, adjust some names. > > Cc: Juan A. Suárez > Cc: Andres Gomez > Signed-off-by: Emil Velikov > Reviewed-by: Eric Engestrom > --- > d

[Mesa-dev] Mesa 17.1.9 release candidate

2017-09-06 Thread Andres Gomez
cherry picked from commit e439908af9665b50443f1196cb55388c69d0c7d7) Cheers, Andres Mesa stable queue - Nominated (0) = Queued (27) === Andres Gomez (7):   docs: add sha256 checksums for 17.1.8   cherry-ignore: added 17.2 nominations.   cherry-ignore: add "nir: F

[Mesa-dev] [ANNOUNCE] mesa 17.1.9

2017-09-08 Thread Andres Gomez
make use of the locale-setting. Andres Gomez (9):   docs: add sha256 checksums for 17.1.8   cherry-ignore: added 17.2 nominations.   cherry-ignore: add "nir: Fix system_value_from_intrinsic for subgroups"   cherry-ignore: add "i965: Fix crash in fallback GTT mapp

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

2017-09-13 Thread Andres Gomez
On Tue, 2017-09-12 at 12:17 +0200, Gert Wollny wrote: > > > This doesn't seem right. GALLIUM_COMMON_LIB_DEPS already has > > > $(LIBUNWIND_LIBS) so this change should not be needed. > > > > I already started looking at this, but haven't been able to figure > > out why in this specific configuratio

Re: [Mesa-dev] [PATCH] intel/eu/validate: Look up types on demand in execution_type()

2017-09-13 Thread Andres Gomez
Jason, this patch landed tagged for mesa-stable but without mentioning any specific branch. For 17.1 it depends on earlier commit 4fab67a4415 which did not land in the branch so I'm keeping it out. I hope this is OK with you. On Thu, 2017-08-31 at 15:48 -0700, Jason Ekstrand wrote: > We are look

Re: [Mesa-dev] [PATCH] radv/ac: bump params array for image atomic comp swap

2017-09-13 Thread Andres Gomez
Hi Dave, This patch landed tagged for 17.2 only. Was it, then, not nominated for 17.1 intentionally ? Br. On Wed, 2017-09-13 at 15:19 +1000, Dave Airlie wrote: > From: Dave Airlie > > For the comp_swap case this was overflowing and crashing > sometimes. > > Fixes: > dEQP-VK.image.atomic_opera

[Mesa-dev] Mesa 18.2.0 release plan

2018-07-17 Thread Andres Gomez
Hi all, Here is the tentative release plan for 18.2.0. Although the initial plan was to have the first release candidate by the end of this week, a slip of mind in my side on sending this plan is shifting the current schedule at mesa3d.org. We'll update the release schedule there soon. Aug 01 2

[Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

2018-07-19 Thread Andres Gomez
or: handle GGTT mappings") Fixes: 7e2af374742 ("travis: split the make target to three separate ones") Cc: Emil Velikov Cc: Juan A. Suarez Romero Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Andres Gomez --- .travis.yml | 27 --- 1 file changed,

[Mesa-dev] [PATCH] docs: move releases from Fridays to Wednesdays

2018-07-19 Thread Andres Gomez
As discussed at: https://lists.freedesktop.org/archives/mesa-dev/2018-March/188525.html Cc: Emil Velikov Cc: Juan A. Suarez Romero Cc: Dylan Baker Cc: Ian Romanick Cc: Carl Worth Cc: Mark Janes Signed-off-by: Andres Gomez --- docs/releasing.html | 4 ++-- 1 file changed, 2 insertions

[Mesa-dev] [PATCH] docs: correct typo in the submitting patches instructions

2018-07-19 Thread Andres Gomez
Cc: Emil Velikov Cc: Eric Engestrom Signed-off-by: Andres Gomez --- docs/submittingpatches.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 178ec5f89ec..e5350bdb2cf 100644 --- a/docs/submittingpatches.html

[Mesa-dev] [PATCH] docs: update calendar to match the 18.2 plan with the one announced

2018-07-19 Thread Andres Gomez
Additionally, I've extended the 18.1 cycle by one more release, tentatively assigned to Dylan, due to the ~2 weeks delay for 18.2. Cc: Dylan Baker Cc: Juan A. Suarez Cc: Emil Velikov Signed-off-by: Andres Gomez --- docs/release-calendar.html | 16 +++- 1 file change

Re: [Mesa-dev] [PATCH] i965/miptree: Fix can_blit_slice()

2018-07-24 Thread Andres Gomez
Hi Nanley, I'm observing regressions for SKL and BDW which doesn't seem to be solved with this new patch, in git master. Therefore, I've gone ahead and reported: https://bugs.freedesktop.org/show_bug.cgi?id=107359 On Mon, 2018-07-23 at 10:17 -0700, Nanley Chery wrote: > Satisfy the BLT engine's r

Re: [Mesa-dev] [PATCH] travis: manually generate sys/syscall.h

2018-07-24 Thread Andres Gomez
On Tue, 2018-07-24 at 09:07 -0700, Dylan Baker wrote: > Quoting Emil Velikov (2018-07-24 08:56:55) > > On 24 July 2018 at 11:29, Eric Engestrom wrote: > > > On Thursday, 2018-07-19 15:33:33 +0300, Andres Gomez wrote: > > > > Until now, the needed bits were wro

[Mesa-dev] Reminder, 18.2 branching on Wednesday, the 1st of August

2018-07-25 Thread Andres Gomez
I just wanted to remind everyone that the plan is to branch for 18.2 on Wednesday, the 1st of August. I plan to take the head of master around 10:00 am EEST, and assuming that all of our CI testing is good that will become the 18.2 branch point with RC1 to follow after that. The status of the *fea

Re: [Mesa-dev] [PATCH] intel/isl: Avoid tiling on 16K-wide render targets

2018-07-30 Thread Andres Gomez
atch. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107359 > Cc: This is: Tested-by: Andres Gomez > --- > > We could probably add an assert when filling out the surface state, but > I think BLORP would need a non-trivial amount of work done as a > prerequ

Re: [Mesa-dev] Mesa 18.2.0 release plan

2018-07-31 Thread Andres Gomez
whenever i need to touch > them again. Also, more work to do on the x-server, weston, side, but > that needs a new baseline in Mesa before it makes sense for me to pile > on more work. > > Thanks, > -mario > > > > > On Wed, Jul 18, 2018 at 12:55 AM, Andres Gomez

Re: [Mesa-dev] [PATCH 1/7] mesa: add ASTC 2D LDR decoder

2018-07-31 Thread Andres Gomez
On Mon, 2018-07-23 at 19:52 -0400, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/Makefile.sources |2 + > src/mesa/main/formats.c| 42 + > src/mesa/main/formats.h|3 + > src/mesa/main/texcompress_astc.cpp | 1871

<    1   2   3   4   5   6   7   >