Emil, this patch breaks SWR build in 17.1, although it states that fixes 9475251145174882b532.
Should I assume that this should be dropped for 17.1 or are you planning to send some backport (?). On Fri, 2017-07-21 at 19:05 +0100, Emil Velikov wrote: > From: Emil Velikov <emil.veli...@collabora.com> > > The variable name was missing a leading LD_, which resulted in the > backend binaries having unresolved symbols. > > With the link addressed with earlier patches, we can correct the typo. > > Thanks to Laurent for the help spotting this. > > v2: Split from a larger patch. > > Cc: mesa-sta...@lists.freedesktop.org > Cc: Bruce Cherniak <bruce.chern...@intel.com> > Cc: Tim Rowley <timothy.o.row...@intel.com> > Cc: Laurent Carlier <lordhea...@gmail.com> > Fixes: 9475251145174882b532 "swr: standardize linkage and check for > unresolved symbols" > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > Reported-by: Laurent Carlier <lordhea...@gmail.com> > Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > --- > src/gallium/drivers/swr/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/swr/Makefile.am > b/src/gallium/drivers/swr/Makefile.am > index bc7abad06af..05fc3b3595b 100644 > --- a/src/gallium/drivers/swr/Makefile.am > +++ b/src/gallium/drivers/swr/Makefile.am > @@ -238,7 +238,7 @@ COMMON_LDFLAGS = \ > -module \ > -no-undefined \ > $(GC_SECTIONS) \ > - $(NO_UNDEFINED) > + $(LD_NO_UNDEFINED) > > lib_LTLIBRARIES = > -- Br, Andres _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
