Re: [Mesa-dev] [PATCH 1/2] r600/shader: reserve first register of vertex shader.

2017-11-14 Thread Andres Gomez
Dave, this nominated patch landed without mentioning any specific stable queue. From what I'm seeing, they depend on ea1b97714d9b which didn't make it for 17.2 so I'm dropping it for that queue. Let me know what you think. On Mon, 2017-11-13 at 14:18 +1000, Dave Airlie wrote: > From: Dave Airli

Re: [Mesa-dev] [ANNOUNCE] mesa 17.3.0-rc4

2017-11-15 Thread Andres Gomez
On Tue, 2017-11-14 at 11:28 -0800, Matt Turner wrote: > On Tue, Nov 14, 2017 at 6:37 AM, Emil Velikov > wrote: > > The fourth release candidate for Mesa 17.3.0 is now available. > > > > As per the issue tracker [1] we still have a number of outstanding bugs > > blocking the release. > > > > [1]

Re: [Mesa-dev] [PATCH] mesa: document _mesa_extension_override_* variables

2017-11-16 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Thu, 2017-11-16 at 14:22 +, Emil Velikov wrote: > From: Emil Velikov > > Currently there are no users of these outside of extensions.c. > Provide some information why they exist and how to use them. > > Cc: Jordan Justen >

Re: [Mesa-dev] [PATCH] i915: add missing extensions.h include

2017-11-16 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez On Thu, 2017-11-16 at 15:55 +, Emil Velikov wrote: > From: Emil Velikov > > Otherwise we'll bail with due to -Werror=implicit-function-declaration. > It went unnoticed since the we had a bug which did consistently set the > compiler

[Mesa-dev] [PATCH] i965: Correct disasm_info usage in eu_validate test

2017-11-17 Thread Andres Gomez
Fixes: 4f82b1728719 ("i965: Rewrite disassembly annotation code") Cc: Matt Turner Signed-off-by: Andres Gomez --- src/intel/compiler/test_eu_validate.cpp | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/intel/compiler/test_eu_validate.cpp b

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Fix passing renderType into glXCreateContext

2017-11-20 Thread Andres Gomez
Hi Adam, This fix is causing the following regression in master (and in the stable 17.2 queue, if cherry-picked): https://bugs.freedesktop.org/show_bug.cgi?id=103825 Hence, I'm leaving it out until the regression is cleared (either with a fix in mesa or by clarifying whether it is a false positiv

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 17.3.0-rc5

2017-11-20 Thread Andres Gomez
On Mon, 2017-11-20 at 14:40 +, Emil Velikov wrote: > The fifth release candidate for Mesa 17.3.0 is now available. > This is the last planned release candidate before the final release. > > We still have a couple of regressions in our tracker [1] although I'm > anticipating for those to be res

Re: [Mesa-dev] [Mesa-stable] [PATCH 01/14] anv/cmd_buffer: Advance the address when initializing clear colors

2017-11-20 Thread Andres Gomez
Jason, this nominated patch landed without mentioning any specific stable queue. From what I'm seeing, it depends on 3735af04152b which didn't make it for 17.2 so I'm dropping it for that queue, unless you want to provide a backport. Let me know what you think. On Mon, 2017-11-13 at 08:12 -0800,

Re: [Mesa-dev] [Mesa-stable] [PATCH 02/14] anv/cmd_buffer: Take bo_offset into account in fast clear state addresses

2017-11-20 Thread Andres Gomez
Jason, this nominated patch landed without mentioning any specific stable queue. Similarly to the 01/14, from what I'm seeing, it depends on a62a97933578 which didn't make it for 17.2 so I'm dropping it for that queue. Let me know what you think. On Mon, 2017-11-13 at 08:12 -0800, Jason Ekstrand

Re: [Mesa-dev] [PATCH 1/2] i965/bufmgr: Add a helper to mark a BO as external

2017-11-20 Thread Andres Gomez
Jason, this nominated series landed without mentioning any specific stable queue. From what I'm seeing, both depend on 2c4097aff1b which didn't make it for 17.2 so I'm dropping them for that queue. Let me know what you think. On Fri, 2017-11-17 at 17:02 -0800, Jason Ekstrand wrote: > --- > src/

Re: [Mesa-dev] [Mesa-stable] [PATCH V2 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

2017-11-20 Thread Andres Gomez
Anuj, these 4 patches series landed in master without the "mesa-stable" tag, hence, just confirming that you dropped the nomination. Let me know if that was not the case. On Fri, 2017-10-06 at 16:30 -0700, Anuj Phogat wrote: > There are few other (duplicate) workarounds which have similar > rec

Re: [Mesa-dev] [PATCH] mesa: add AllowGLSLCrossStageInterpolationMismatch workaround

2017-11-23 Thread Andres Gomez
Acked-by: Andres Gomez On Thu, 2017-11-23 at 07:54 +0200, Tapani Pälli wrote: > This fixes issues seen with certain versions of Unreal Engine 4 editor > and games built with that using GLSL 4.30. > > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedesktop.org/show_b

Re: [Mesa-dev] [PATCH] i965/vec4: fix splitting of interleaved attributes

2017-11-23 Thread Andres Gomez
On Thu, 2017-11-23 at 09:09 +0100, Iago Toral Quiroga wrote: > Whe we split an instruction that reads a uniform value When^ an ^ Acked-by: Andres Gomez > (vstride 0) we need to respect the vstride on the second > half of the instruction (that is, the se

[Mesa-dev] Mesa 17.2.6 release candidate

2017-11-23 Thread Andres Gomez
: Use correct type for sampled images nir/spirv: tg4 requires a sampler Andres Gomez (13): docs: add sha256 checksums for 17.2.5 cherry-ignore: intel/fs: Use a pure vertical stride for large register strides cherry-ignore: intel/nir: Use the correct indirect lowering mask

Re: [Mesa-dev] Mesa 17.2.6 release candidate

2017-11-24 Thread Andres Gomez
On Thu, 2017-11-23 at 15:49 -0800, Matt Turner wrote: > I would like to include the three patch series I sent today in 17.2.6. > It fixes our SHA1 implementation on big endian, adds a test, and fixes > another test. > > I hope it'll be reviewed and in master before the planned 17.2.6 release. OK.

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-24 Thread Andres Gomez
On Fri, 2017-11-24 at 13:32 +, Emil Velikov wrote: > On 24 November 2017 at 10:25, Eric Engestrom > wrote: > > On Thursday, 2017-11-23 11:08:04 -0800, Matt Turner wrote: > > > The code defines a macro blk0(i) based on the preprocessor condition > > > BYTE_ORDER == LITTLE_ENDIAN. If true, blk0

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-25 Thread Andres Gomez
Matt, as Jon and Ilia have reported, this is now breaking with GCC and MSVC. You can check the Appveyor error at: https://ci.appveyor.com/project/mesa3d/mesa/build/6245 Also, for Travis-CI: https://travis-ci.org/Igalia/mesa/builds/307262963 Although the series landed without the mesa-stable tag,

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-25 Thread Andres Gomez
On Sun, 2017-11-26 at 00:59 +0200, Andres Gomez wrote: > > Although the series landed without the mesa-stable tag, I assume that > you wanted to keep the nomination. If that's the case, remember to land > them with the tag in the future since, if it is not included, it i

[Mesa-dev] [ANNOUNCE] mesa 17.2.6

2017-11-25 Thread Andres Gomez
ssing renderType into glXCreateContext Alex Smith (2): spirv: Use correct type for sampled images nir/spirv: tg4 requires a sampler Andres Gomez (15): docs: add sha256 checksums for 17.2.5 cherry-ignore: intel/fs: Use a pure vertical stride for large register strides c

Re: [Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

2017-11-25 Thread Andres Gomez
On Sat, 2017-11-25 at 16:00 -0800, Matt Turner wrote: > On Sat, Nov 25, 2017 at 1:58 PM, Jon Turney > wrote: > > On 25/11/2017 04:24, Matt Turner wrote: > > > > > > diff --git a/src/util/u_endian.h b/src/util/u_endian.h > > > index 7bbd7dc215..3d5c006f35 100644 > > > --- a/src/util/u_endian.h >

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

2017-11-28 Thread Andres Gomez
Julien, this looks like a good candidate to nominate for inclusion in the 17.2 stable queue. What do you think? On Tue, 2017-07-25 at 15:31 +0100, Julien Isorce wrote: > The picture_is was assumed to be a frame number so in 0-31. > But the vaapi client gstreamer-vaapi uses the surfaces handles >

Re: [Mesa-dev] [PATCH] st/va: change frame_idx from array to hash table

2017-11-28 Thread Andres Gomez
Forgot to include mesa-stable ... On Tue, 2017-11-28 at 15:32 +0200, Andres Gomez wrote: > Julien, this looks like a good candidate to nominate for inclusion in > the 17.2 stable queue. > > What do you think? > > On Tue, 2017-07-25 at 15:31 +0100, Julien Isorce wrote: >

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

2017-11-28 Thread Andres Gomez
Denis, this looks like a good candidate to nominate for inclusion in the 17.2 stable queue. What do you think? On Tue, 2017-09-12 at 23:38 +0300, Denis Pauk wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 > > v2: Patch cleanup proposed by Nicolai Hähnle. > * deleted ch

Re: [Mesa-dev] [PATCH 01/12] i965/fs: Unpack count argument to 64-bit shift ops on Atom

2017-11-28 Thread Andres Gomez
Matt, this looks like a good candidate to nominate for inclusion in the 17.2 stable queue. What do you think? On Thu, 2017-09-28 at 23:05 -0700, Matt Turner wrote: > 64-bit operations on Atom parts have additional restrictions over their > big-core counterparts (validated by later patches). > >

Re: [Mesa-dev] [PATCH v4 1/2] glsl: allow any l-value of an input variable as interpolant in interpolateAt*

2017-11-28 Thread Andres Gomez
Nicolai, this looks like a good candidate to nominate for inclusion in all the stable queues. What do you think? On Tue, 2017-10-10 at 14:09 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The intended rule has been clarified in GLSL 4.60, Section 8.13.2 > (Interpolation Functions): >

Re: [Mesa-dev] [PATCH 2/5] r600: use DX10_CLAMP bit in shader setup

2017-11-28 Thread Andres Gomez
Nicolai, this looks like a good candidate to nominate for inclusion in all the stable queues. What do you think? On Thu, 2017-11-09 at 20:00 +0100, srol...@vmware.com wrote: > From: Roland Scheidegger > > The docs are not very concise in what this really does, however both > Alex Deucher and Ni

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/5] r600: use DX10_CLAMP bit in shader setup

2017-11-28 Thread Andres Gomez
On Tue, 2017-11-28 at 16:05 +0200, Andres Gomez wrote: > Nicolai, this looks like a good candidate to nominate for inclusion in ^^^ I meant Roland 😕 > all the stable queues. > > What do you think? > > On Thu, 2017-11-09 at 20:00 +0100, srol...@vmware.com wrote

Re: [Mesa-dev] [PATCH] intel/blorp: Fix possible NULL pointer dereferencing

2017-11-28 Thread Andres Gomez
This is: Reviewed-by: Andres Gomez Vadym, let me know if you need someone to push your change. On Mon, 2017-11-27 at 12:15 +0200, vadim.shovkopl...@gmail.com wrote: > From: Vadym Shovkoplias > > Fix incomplete check of input params in blorp_surf_convert_to_uncompressed() > which

Re: [Mesa-dev] [PATCH v2] util: hash_table: move NULL assert to string hashing function

2017-11-28 Thread Andres Gomez
e dereference --^ This is: Reviewed-by: Andres Gomez > want to be sure it's not NULL. > > v2: Add assert in _mesa_fnv32_1a_accumulate_block (Ian) > > Signed-off-by: Lionel Landwerlin > --- > src/util/hash_table.c | 4 ++-- > src/uti

Re: [Mesa-dev] [PATCH] intel/blorp: Fix possible NULL pointer dereferencing

2017-11-30 Thread Andres Gomez
On Wed, 2017-11-29 at 17:53 +0200, Vadym Shovkoplias wrote: > Hi Andres, > > Thanks for the review! > I'm not familiar with Mesa workflow so far so I'll appreciate any > help in pushing this patch. You are welcome ... ... and pushed ☺ -- Br, Andres

Re: [Mesa-dev] [PATCH] docs/release-calendar: update and extend

2017-11-30 Thread Andres Gomez
On Wed, 2017-11-29 at 18:20 +, Emil Velikov wrote: > From: Emil Velikov > > Cc: Juan A. Suárez > Cc: Andres Gomez > Signed-off-by: Emil Velikov > --- > Gents, I have no objections if you want to do any of the releases listed > ;-) > --- > d

Re: [Mesa-dev] [PATCH] anv: FORMAT_FEATURE_TRANSFER_SRC/DST_BIT_KHR not used with VkFormatProperties.bufferFeatures

2017-06-14 Thread Andres Gomez
On Thu, 2017-06-15 at 01:13 +0100, Lionel Landwerlin wrote: > Out of curiosity, does this fix a test (maybe upcoming one)? Not really, but realized checking an upcoming test for vk-gl-cts. The test was failing on some conditions because of erroneously checking some FORMAT_FEATURE flags against Vk

Re: [Mesa-dev] [PATCH 2/2] bin/get-fixes-pick-list.sh: better identify multiple "fixes:" tags

2017-06-15 Thread Andres Gomez
On Mon, 2017-05-15 at 11:56 +0100, Emil Velikov wrote: > On 13 May 2017 at 01:11, Andres Gomez wrote: > > We were not considering as multiple fixes lines with: > > Fixes: $sha_1, Fixes: $sha_2 > > > > Now, we split the lines so we will consider them individuall

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] amd/common: fix off-by-one in sid_tables.py

2017-06-22 Thread Andres Gomez
On Mon, 2017-06-19 at 12:36 +0100, Emil Velikov wrote: > Hi Nicolai, > > On 12 June 2017 at 20:33, Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > > > The very last entry in the sid_strings_offsets table ended up missing, > > leading to out-of-bounds reads and potential crashes. > > Should

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/glsl_to_tgsi: use correct writemask when converting generic intrinsics

2017-06-22 Thread Andres Gomez
Nicolai, this depends on: https://cgit.freedesktop.org/mesa/mesa/commit/src/mesa?id=944455217b67cb524efef9e628baf09416db5524 Which didn't make it for -stable. Should we cherry-pick that too? On Mon, 2017-06-12 at 21:45 +0200, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This fixes a bug wh

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] amd/common: fix off-by-one in sid_tables.py

2017-06-22 Thread Andres Gomez
On Mon, 2017-06-19 at 12:36 +0100, Emil Velikov wrote: > Hi Nicolai, > > On 12 June 2017 at 20:33, Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > > > The very last entry in the sid_strings_offsets table ended up missing, > > leading to out-of-bounds reads and potential crashes. > > Should

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] i965: Fix broxton 2x6 l3 config

2017-06-26 Thread Andres Gomez
Anuj, this depends on: https://cgit.freedesktop.org/mesa/mesa/commit/src/mesa?id=eb23be1d97da290073d76c2510b8999b250f0139 Which didn't make it for -stable. Should we cherry-pick that too? On Mon, 2017-06-12 at 10:01 -0700, Anuj Phogat wrote: > The new table added in this patch matches with the ta

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] anv: Stop racing relocation offsets

2017-06-26 Thread Andres Gomez
Jason, it doesn't seem like this patch has landed in master. Are you in need of review or is it that this has been superseded? Thanks! On Wed, 2017-05-10 at 16:08 -0700, Jason Ekstrand wrote: > One of the key invariants of the relocation system is the > presumed_offset field. The assumption is m

Re: [Mesa-dev] [Mesa-stable] [PATCH 00/16] anv: Fix our 48-bit problems

2017-06-26 Thread Andres Gomez
Jason, you CCed this whole series for stable. However: * Patch 1/16 already landed, but without the -stable tag. Should it be cherry-picked? It looks like yes. * Patch 2/16 did not land. Is it in need of review or it has been superseded? * Patches 3-15/16 were already cherry-picked in the

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] amd/common: fix off-by-one in sid_tables.py

2017-06-26 Thread Andres Gomez
On Mon, 2017-06-26 at 14:23 +0100, Emil Velikov wrote: > On 23 June 2017 at 00:07, Andres Gomez wrote: > > On Mon, 2017-06-19 at 12:36 +0100, Emil Velikov wrote: > > > Hi Nicolai, > > > > > > On 12 June 2017 at 20:33, Nicolai Hähnle wrote: > > > >

Re: [Mesa-dev] [Mesa-stable] [PATCH] nv50, nvc0: remove IDX from bufctx immediately, to avoid conflicts with clear

2017-06-27 Thread Andres Gomez
Ilia, this patch tries to fix 61d8f3387d which, in turn, tried to fix 330d0607e. None of them did it for 17.1 so I suppose we should leave this out, then. Let me know if you think otherwise. On Sat, 2017-06-24 at 13:24 -0400, Ilia Mirkin wrote: > The idxbuf could linger, and when a clear happene

Re: [Mesa-dev] [PATCH mesa] Fix khrplatform.h not installed if EGL is disabled.

2017-06-27 Thread Andres Gomez
Sound like a good inclusion for -stable (?) On Mon, 2017-06-12 at 12:00 +0100, Eric Engestrom wrote: > From: Eric Le Bihan > > KHR/khrplatform.h is required by the EGL, GLES and VG headers, but is > only installed if Mesa3d is compiled with EGL support. > > This patch installs this header file

Re: [Mesa-dev] [PATCH 1/2] svga: clamp device line width to at least 1 to fix HWv8 line stippling

2017-06-27 Thread Andres Gomez
It looks like we could want these 2 into -stable (?) On Thu, 2017-06-15 at 11:41 -0600, Brian Paul wrote: > The line stipple fallback code for virtual HW version 8 didn't work. > > With HW version 8, we were getting zero when querying the max line > widths (AA and non-AA). This means we were set

[Mesa-dev] Mesa 17.1.4 release candidate

2017-06-28 Thread Andres Gomez
4) === Alex Deucher (1):   radeonsi: add new polaris12 pci id Andres Gomez (2):   cherry-ignore: 17.1.4 rejected commits   cherry-ignore: bin/get-fixes-pick-list.sh: better identify multiple "fixes:" tags Anuj Phogat (2):   i965: Add and initialize l3_banks field for

[Mesa-dev] [ANNOUNCE] mesa 17.1.4

2017-06-30 Thread Andres Gomez
s12 pci id Andres Gomez (4):   cherry-ignore: 17.1.4 rejected commits   cherry-ignore: bin/get-fixes-pick-list.sh: better identify multiple "fixes:" tags   Update version to 17.1.4   docs: add release notes for 17.1.4 Anuj Phogat (2):   i965: Add and initialize l3_

Re: [Mesa-dev] [Mesa-stable] [PATCH 00/16] anv: Fix our 48-bit problems

2017-07-03 Thread Andres Gomez
Never too late! ☺ On Fri, 2017-06-30 at 16:45 -0700, Jason Ekstrand wrote: > I know this is rather late but > > On June 26, 2017 1:15:16 PM Andres Gomez wrote: > > > Jason, you CCed this whole series for stable. However: > > * Patch 1/16 already landed, but without

Re: [Mesa-dev] [PATCH 1/2] intel/isl: Use uint64_t to store total surface size

2017-07-03 Thread Andres Gomez
It looks like we could want these 2 into -stable (?) On Tue, 2017-05-23 at 14:37 -0700, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/isl/isl.c | 3 ++- > src/intel/isl/isl.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/intel/isl/isl.c b/sr

Re: [Mesa-dev] [PATCH 1/6] i965: Make Gen4-5 SF_STATE use the point size calculations from Gen6+.

2017-07-03 Thread Andres Gomez
It looks like we could want this whole series into -stable (?) On Wed, 2017-05-10 at 11:47 -0700, Kenneth Graunke wrote: > Apparently, Nanhai made the Gen4-5 point size calculations round to the > nearest integer in commit 8d5231a3582e4f2769ac0685cf0174e09750700e, > "according to spec". When Eric

Re: [Mesa-dev] [PATCH 1/2] i965: Use true AA line distance on G45/Ironlake.

2017-07-03 Thread Andres Gomez
It looks like we could want these 2 into -stable (?) On Wed, 2017-04-26 at 15:15 -0700, Kenneth Graunke wrote: > The original Broadwater and Crestline platforms computed antialiased > line distances using "manhattan" distance, aka a + b = c. Eaglelake > and Cantiga added "true" distance, aka a^2

Re: [Mesa-dev] [Mesa-stable] [PATCH 00/16] anv: Fix our 48-bit problems

2017-07-04 Thread Andres Gomez
On Mon, 2017-07-03 at 22:48 -0700, Jason Ekstrand wrote: > On July 3, 2017 12:31:48 PM Andres Gomez wrote: > > > Never too late! ☺ > > > > On Fri, 2017-06-30 at 16:45 -0700, Jason Ekstrand wrote: > > > I know this is rather late but > > > >

Re: [Mesa-dev] [PATCH] glsl: gl_Max{Vertex, Fragment}UniformComponents exist in all desktop GL versions

2017-07-06 Thread Andres Gomez
It looks like we could want this into -stable (?) On Fri, 2017-06-16 at 12:05 +0200, Iago Toral Quiroga wrote: > The current implementation assumed that these were replaced in GLSL >= 4.10 > by gl_Max{Vertex,Fragment}UniformVectors, however this is not true: both > built-ins should be produced fro

Re: [Mesa-dev] [PATCH 1/3] mesa/main: Move NULL pointer check.

2017-07-06 Thread Andres Gomez
It looks like we could want this into -stable (?) On Wed, 2017-06-14 at 19:33 +0300, Plamena Manolova wrote: > In blit_framebuffer we're already doing a NULL > pointer check for readFb and drawFb so it makes > sense to do it before we actually use the pointers. > > CID: 1412569 > Signed-off-by: P

Re: [Mesa-dev] [PATCH 1/8] mesa: check for allocation failures in _mesa_new_texture_object()

2017-07-06 Thread Andres Gomez
It looks like we could want patches 1 and 3-8 from this series into -stable (?) On Wed, 2017-06-21 at 11:04 +0200, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/mesa/main/texobj.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/main

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

2017-07-06 Thread Andres Gomez
On Thu, 2017-06-22 at 09:25 +, Namburu, Chandu-babu wrote: > From: Chandu Babu N > Subject: [PATCH] [st/va] Fix leak in VAAPI subpictures >   > sampler view allocated in vaAssociateSubpicture is not cleared > in vaiDeassociateSubpicture. >   > Reviewed-by: Christian König > --- > src/gallium/

Re: [Mesa-dev] [PATCH 1/4] radeonsi: fix DCC fast clear for luminance and alpha formats

2017-07-06 Thread Andres Gomez
Marek, would we want this series in -stable or we shouldn't bother ? On Tue, 2017-06-20 at 19:06 +0200, Marek Olšák wrote: > From: Marek Olšák > > I reproduced this bug on Polaris11 and Raven. > > I can't get this bug on Fiji. The reason might be that Fiji doesn't use > 2D tiling for the test d

Re: [Mesa-dev] [st/va] Fix leak in VAAPI subpictures

2017-07-06 Thread Andres Gomez
It looks like we could want this into -stable (?) On Thu, 2017-07-06 at 21:10 +0300, Andres Gomez wrote: > On Thu, 2017-06-22 at 09:25 +, Namburu, Chandu-babu wrote: > > From: Chandu Babu N > > Subject: [PATCH] [st/va] Fix leak in VAAPI subpictures > >   > >

Re: [Mesa-dev] [Mesa-stable] [st/va] Fix leak in VAAPI subpictures

2017-07-06 Thread Andres Gomez
It looks like we could want this into -stable (?) On Thu, 2017-07-06 at 21:10 +0300, Andres Gomez wrote: > On Thu, 2017-06-22 at 09:25 +, Namburu, Chandu-babu wrote: > > From: Chandu Babu N > > Subject: [PATCH] [st/va] Fix leak in VAAPI subpictures > >   > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] mesa/main: Move NULL pointer check.

2017-07-07 Thread Andres Gomez
On Thu, 2017-07-06 at 18:02 +0100, Emil Velikov wrote: > On 6 July 2017 at 15:35, Andres Gomez wrote: > > It looks like we could want this into -stable (?) > > > > _mesa_update_draw_buffer_bounds is a no-op if the buffer pointer is NULL. > There's no issue to fix,

Re: [Mesa-dev] [Mesa-stable] [Fwd: Re: [PATCH 1/2] intel/isl: Use uint64_t to store total surface size]

2017-07-07 Thread Andres Gomez
On Thu, 2017-07-06 at 18:21 +0100, Emil Velikov wrote: > On 3 July 2017 at 21:14, Andres Gomez wrote: > > Actually, forgot to add -stable into CC. > > > > Forwarded Message ---- > > From: Andres Gomez > > To: Anuj Phogat , mesa-dev@lists.freedeskt

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] radeonsi: fix DCC fast clear for luminance and alpha formats

2017-07-07 Thread Andres Gomez
On Thu, 2017-07-06 at 23:24 +0200, Marek Olšák wrote: > On Thu, Jul 6, 2017 at 8:24 PM, Andres Gomez wrote: > > Marek, would we want this series in -stable or we shouldn't bother ? > > Don't bother. Patch 1 isn't that important. Other patches are for > features

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/8] mesa: check for allocation failures in _mesa_new_texture_object()

2017-07-07 Thread Andres Gomez
On Fri, 2017-07-07 at 09:14 +0200, Samuel Pitoiset wrote: > > On 07/06/2017 08:06 PM, Andres Gomez wrote: > > It looks like we could want patches 1 and 3-8 from this series into > > -stable (?) > > These are not critical fixes, your call. OK. I will leave them out by no

Re: [Mesa-dev] [PATCH] swr: invalidate attachment on transition change

2017-07-07 Thread Andres Gomez
George, would we want this patch in -stable or we shouldn't bother ? On Tue, 2017-06-20 at 11:42 -0500, George Kyriazis wrote: > Consider the following RT attachment order: > 1. Attach surfaces attachments 0 & 1, and render with them > 2. Detach 0 & 1 > 3. Re-attach 0 & 1 to different surfaces > 4

Re: [Mesa-dev] [PATCH 1/3] mesa: GL_TEXTURE_BORDER_COLOR exists in OpenGL 1.0, so don't depend on GL_ARB_texture_border_clamp

2017-07-07 Thread Andres Gomez
Ian, it looks like we could want this patch (and the others from the series when they land) in -stable (?) On Tue, 2017-06-27 at 10:09 -0700, Ian Romanick wrote: > From: Ian Romanick > > On NV20 (and probably also on earlier NV GPUs that lack > GL_ARB_texture_border_clamp) fixes the following pi

[Mesa-dev] [PATCH] nir/spirv: Remove unnecessary comment.

2017-07-08 Thread Andres Gomez
It should have been removed after 00c47e111c. Cc: Jason Ekstrand Cc: Connor Abbott Signed-off-by: Andres Gomez --- src/compiler/spirv/spirv_to_nir.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 1743d8915a

Re: [Mesa-dev] [PATCH] etnaviv: don't dereference etna_resource pointer if allocation fails

2017-07-08 Thread Andres Gomez
It looks like we could want this into -stable (?) On Thu, 2017-07-06 at 11:35 +0200, Aleksander Morgado wrote: > The check for the pointer being non-NULL was being done too late. > > Signed-off-by: Aleksander Morgado > --- > src/gallium/drivers/etnaviv/etnaviv_resource.c | 10 +++--- > 1 fi

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

2017-07-08 Thread Andres Gomez
Marek, is it worth the effort of trying to bring this series into -stable? On Wed, 2017-06-21 at 00:54 +0200, Marek Olšák wrote: > Hi, > > This series updates pipe loaders so that flags such as drirc options > can be passed to create_screen(). I have compile-tested everything > except clover. >

Re: [Mesa-dev] [PATCH] drirc: Add glsl_correct_derivatives_after_discard for The Witcher 2

2017-07-08 Thread Andres Gomez
Related to my previous mail, do we try to pick this for -stable? On Wed, 2017-06-21 at 22:40 +0200, Edmondo Tommasina wrote: > This fixes the long-standing problem with black transitions in The Wicher 2. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98238 > --- > This patch depends o

Re: [Mesa-dev] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData() at times.

2017-07-08 Thread Andres Gomez
Kenneth, worth cherry-picking for -stable? On Wed, 2017-06-28 at 02:44 -0700, Kenneth Graunke wrote: > This patch makes glCopyImageSubData require mipmap completeness when the > texture object's built-in sampler object has a mipmapping MinFilter. > This is apparently the de facto behavior and mand

Re: [Mesa-dev] [PATCH 1/2] st/mesa: check for incomplete texture in st_finalize_texture()

2017-07-08 Thread Andres Gomez
Brian, it looks like we could want this series into -stable (?) On Wed, 2017-06-28 at 16:12 -0600, Brian Paul wrote: > Return early from st_finalize_texture() if we have an incomplete > texture. This avoids trying to create a texture resource with invalid > parameters (too many mipmap levels give

Re: [Mesa-dev] [PATCH 03/14] gallium/radeon: fix a possible crash for buffer exports

2017-07-08 Thread Andres Gomez
Marek, do we want this into -stable? On Thu, 2017-06-29 at 21:47 +0200, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/r600_texture.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-) > > diff --git a/src/gallium/drivers/radeon/r600_

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: Require mipmap completeness for glCopyImageSubData() at times.

2017-07-08 Thread Andres Gomez
On Sat, 2017-07-08 at 07:52 -0700, Kenneth Graunke wrote: > On Saturday, July 8, 2017 7:01:30 AM PDT Andres Gomez wrote: > > Kenneth, worth cherry-picking for -stable? > > I wouldn't - this patch just imposes additional restrictions, making > things we used to support

Re: [Mesa-dev] [Mesa-stable] [PATCH] etnaviv: don't dereference etna_resource pointer if allocation fails

2017-07-08 Thread Andres Gomez
On Sat, 2017-07-08 at 18:45 +0200, Christian Gmeiner wrote: > 2017-07-08 14:42 GMT+02:00 Andres Gomez : > > It looks like we could want this into -stable (?) > > Forgot to add CC during push but I have nominated it for stable now. Great! Thanks a lot! ☺

[Mesa-dev] [PATCH 0/4] docs: update basic testing on the releasing instructions

2017-07-08 Thread Andres Gomez
Some small update on the "Making a new release" section of the releasing instructions. Patches 1-3 add some small modifications for performing the basic testing. Patch 4 merges the section for updating the calendar into the previous one to reflect closer what we are actually doing. An

[Mesa-dev] [PATCH 1/4] docs: add instructions to specify LLVM version for basic testing

2017-07-08 Thread Andres Gomez
The "Perform basic testing" section provides some instructions to do so. We add now some comments in order to use a recent enough LLVM version to test the distcheck and the automake generated binaries. Signed-off-by: Andres Gomez --- docs/releasing.html | 6 ++ 1 file changed, 6

[Mesa-dev] [PATCH 2/4] docs: remove redundant parameter for scons build basic testing

2017-07-08 Thread Andres Gomez
toolchain=crossmingw is the default option for platform=windows when invoking scons. Signed-off-by: Andres Gomez --- docs/releasing.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/releasing.html b/docs/releasing.html index ceb6e365e4..8e6e4d1a6d 100644 --- a/docs

[Mesa-dev] [PATCH 4/4] docs: update master's release notes, news and calendar commit

2017-07-08 Thread Andres Gomez
This reflects closer what we are actually doing. Signed-off-by: Andres Gomez --- docs/releasing.html | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/docs/releasing.html b/docs/releasing.html index 99235d8412..152f5cea73 100644 --- a/docs/releasing.html +++ b

[Mesa-dev] [PATCH 3/4] docs: avoid overwrite of LD_LIBRARY_PATH during basic testing

2017-07-08 Thread Andres Gomez
The LD_LIBRARY_PATH environment variable could be already defined so we extend it and restore it rather than just overwriting it. Signed-off-by: Andres Gomez --- docs/releasing.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/releasing.html b/docs/releasing.html

Re: [Mesa-dev] [PATCH] gallium: improve selection of pixel format

2017-07-08 Thread Andres Gomez
Olivier, Brian, do we want this into -stable? On Thu, 2017-07-06 at 17:08 +0200, Olivier Lauffenburger wrote: > Current selection of pixel format does not enforce the request of > stencil or depth buffer if the color depth is not the same as > requested. > For instance, GLUT requests a 32-bit colo

Re: [Mesa-dev] [PATCH 1/2] vbo: fix glPrimitiveRestartNV crash inside a display list

2017-07-08 Thread Andres Gomez
It looks like we could want this series into -stable (?) On Fri, 2017-07-07 at 08:10 -0600, Brian Paul wrote: > From: Olivier Lauffenburger > > glPrimitiveRestartNV crashes when it is called during the compilation > of a display list. > > There are two reasons: > - ctx->Driver.CurrentSavePrimit

Re: [Mesa-dev] [PATCH 0/5] Gallium: Passing drirc options to create_screen() and fixing Rocket League

2017-07-09 Thread Andres Gomez
On Sun, 2017-07-09 at 14:21 +0200, Marek Olšák wrote: > On Sat, Jul 8, 2017 at 3:56 PM, Andres Gomez wrote: > > Marek, is it worth the effort of trying to bring this series into > > -stable? > > Probably not. The incorrect rendering in Rocket League isn't > noticea

Re: [Mesa-dev] [PATCH] drirc: Add glsl_correct_derivatives_after_discard for The Witcher 2

2017-07-09 Thread Andres Gomez
On Sun, 2017-07-09 at 14:23 +0200, Marek Olšák wrote: > On Sat, Jul 8, 2017 at 3:58 PM, Andres Gomez wrote: > > Related to my previous mail, do we try to pick this for -stable? > > This one actually fixes a very visible incorrect rendering in Witcher > 2. Still, I think the 5-p

Re: [Mesa-dev] [Mesa-stable] [PATCH 03/14] gallium/radeon: fix a possible crash for buffer exports

2017-07-09 Thread Andres Gomez
On Sun, 2017-07-09 at 14:29 +0200, Marek Olšák wrote: > On Sat, Jul 8, 2017 at 4:07 PM, Andres Gomez wrote: > > Marek, do we want this into -stable? > > Yes, this one can go to stable if it applies cleanly. It does. Thanks for the feedback! ☺

Re: [Mesa-dev] [Mesa-stable] [Fwd: Re: [PATCH 1/2] intel/isl: Use uint64_t to store total surface size]

2017-07-10 Thread Andres Gomez
stable for the sake of > completion. > Thanks for marking them for mesa-stable. > > > On Fri, Jul 7, 2017 at 7:25 AM, Andres Gomez wrote: > > On Thu, 2017-07-06 at 18:21 +0100, Emil Velikov wrote: > > > On 3 July 2017 at 21:14, Andres Gomez wrote

Re: [Mesa-dev] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-10 Thread Andres Gomez
Ilia, would we want this patch in -stable ? On Fri, 2017-07-07 at 20:34 -0400, Ilia Mirkin wrote: > Fixes a bunch of gl_BackColor interpolation tests that had explicit > interpolation specified on the fragment shader gl_Color. > > Signed-off-by: Ilia Mirkin > --- > src/compiler/nir/nir_lower_tw

Re: [Mesa-dev] [Mesa-stable] [PATCH] gallium: improve selection of pixel format

2017-07-10 Thread Andres Gomez
algorithm seems to be in line with the behavior of most Windows > drivers (Microsoft, NVIDIA, AMD) and, more important, I can't imagine > a sensible scenario where this change would break an existing > application. > > -Olivier > > -Message d'origine- > D

Re: [Mesa-dev] [Mesa-stable] [PATCH] nir: copy front interpolation when creating fake back color input

2017-07-10 Thread Andres Gomez
es GL 3.0, so the problematic condition can't > happen there.) > > On Mon, Jul 10, 2017 at 1:30 PM, Andres Gomez wrote: > > Ilia, would we want this patch in -stable ? > > > > On Fri, 2017-07-07 at 20:34 -0400, Ilia Mirkin wrote: > > > Fixes a bunch of gl_BackCol

Re: [Mesa-dev] [PATCH] i965/blorp: Use the renderbuffer format for clears

2017-07-10 Thread Andres Gomez
Jason, which is the status of this patch? Has it been superseded or discarded? On Mon, 2017-06-26 at 09:01 -0700, Jason Ekstrand wrote: > This fixes the Piglit ARB_texture_views rendering-formats test. > > Cc: "17.1" > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 10 +- > 1 file chang

Re: [Mesa-dev] [PATCH] meta: Fix BlitFramebuffer temp texture setup

2017-07-10 Thread Andres Gomez
Ville, has this patch fallen through the cracks ? On Fri, 2017-06-23 at 14:58 +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Pass the correct src coordinates to CopyTexSubImage() > when creating the temporary texture, and also take care to adjust > flipX/Y if the original

Re: [Mesa-dev] [PATCH v3 1/3] spirv: Fix reaching unreachable for compare exchange on images

2017-07-10 Thread Andres Gomez
James, it doesn't seem like this patch has landed in master. Are you in need of review or is it that this has been superseded? Thanks! On Mon, 2017-06-26 at 10:46 +0100, James Legg wrote: > We were hitting the > unreachable("Invalid image opcode") > near the end of vtn_handle_image when par

[Mesa-dev] Mesa 17.1.5 release candidate

2017-07-12 Thread Andres Gomez
na_screen etnaviv: don't dereference etna_resource pointer if allocation fails Alex Smith (2): ac/nir: Use correct LLVM intrinsics for atomic ops on imageBuffers ac/nir: Fix ordering of parameters for image atomic cmpswap intrinsics Andres Gomez (2): docs: add

Re: [Mesa-dev] Mesa 17.1.5 release candidate

2017-07-13 Thread Andres Gomez
Hi, On Thu, 2017-07-13 at 12:39 +0900, Michel Dänzer wrote: > Hi Andres, > > > On 13/07/17 04:02 AM, Andres Gomez wrote: > > > > Gallivm has seen a fix for properly checking the line width in order to > > use the wide line stage. The VA library, has seen fixed

Re: [Mesa-dev] [PATCH] util: scons: wire up the sha1 test

2017-12-15 Thread Andres Gomez
Ugh! How did we miss this? This is: Reviewed-by: Andres Gomez On Thu, 2017-12-14 at 19:10 +, Emil Velikov wrote: > From: Emil Velikov > > Cc: > Fixes: 513d7ffa23d ("util: Add a SHA1 unit test program") > Signed-off-by: Emil Velikov > --- > We want t

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: Fix KNOB_MAX_WORKER_THREADS thread creation override.

2017-12-17 Thread Andres Gomez
Bruce, this depends on ead0dfe31ec7 which didn't make it for the 17.2 queue so I will be leaving out from there. Let me know what you think. On Tue, 2017-12-12 at 17:37 -0600, Bruce Cherniak wrote: > Environment variable KNOB_MAX_WORKER_THREADS allows the user to override > default thread creatio

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: Fix KNOB_MAX_WORKER_THREADS thread creation override.

2017-12-18 Thread Andres Gomez
On Mon, 2017-12-18 at 00:28 +, Cherniak, Bruce wrote: > > On Dec 17, 2017, at 10:23 AM, Andres Gomez > > wrote: > > > > Bruce, this depends on ead0dfe31ec7 which didn't make it for the > > 17.2 > > queue so I will be leaving out from there. > &

[Mesa-dev] [PATCH] docs: update 17.3 and 18.0 cycles for the release calendar

2017-12-18 Thread Andres Gomez
Cc: Emil Velikov Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- docs/release-calendar.html | 63 +- 1 file changed, 62 insertions(+), 1 deletion(-) diff --git a/docs/release-calendar.html b/docs/release-calendar.html index 2542bf6a7c2

Re: [Mesa-dev] [PATCH] docs: update 17.3 and 18.0 cycles for the release calendar

2017-12-20 Thread Andres Gomez
On Wed, 2017-12-20 at 15:59 +, Emil Velikov wrote: > Thanks, it aligns perfectly with my holidays ;-) o/\o > Reviewed-by: Emil Velikov ... and pushed! -- Br, Andres ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesk

[Mesa-dev] Mesa 17.2.8 release candidate

2017-12-20 Thread Andres Gomez
76f6a05621e5c75) Cheers, Andres Mesa stable queue - Nominated (0) = Queued (16) === Andres Gomez (5): cherry-ignore: swr: Fix KNOB_MAX_WORKER_THREADS thread creation override. cherry-ignore: added 17.3 nominations. cherry-ignore: radv:

[Mesa-dev] [ANNOUNCE] mesa 17.2.8

2017-12-22 Thread Andres Gomez
e X11 driver has been improved to notify properly a mesa warning rather than using fprintf. Andres Gomez (7): cherry-ignore: swr: Fix KNOB_MAX_WORKER_THREADS thread creation override. cherry-ignore: added 17.3 nominations. cherry-ignore: radv: port merge tess info from anv c

[Mesa-dev] [PATCH] anv: Import mako templates only during execution of anv_extensions

2018-01-10 Thread Andres Gomez
p.org/show_bug.cgi?id=104551 Fixes: 0ab04ba979b ("anv: Use python to generate ICD json files") Cc: Jason Ekstrand Cc: Emil Velikov Signed-off-by: Andres Gomez --- src/intel/vulkan/anv_extensions.py | 50 +++--- 1 file changed, 25 insertions(+), 25 deletions

[Mesa-dev] [PATCH v2] anv: Import mako templates only during execution of anv_extensions

2018-01-10 Thread Andres Gomez
Jason). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104551 Fixes: 0ab04ba979b ("anv: Use python to generate ICD json files") Cc: Jason Ekstrand Cc: Emil Velikov Signed-off-by: Andres Gomez --- src/intel/vulkan/anv_extensions.py | 10 +- 1 file changed, 5 insertions(+), 5 del

<    1   2   3   4   5   6   7   >