nguage_420pack.qualifier_override_layout
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast.h | 3 +-
src/compiler/glsl/ast_type.cpp | 28 ++---
src/compiler/glsl/glsl_parser.yy | 130 +++
3 files changed, 84 insertio
The GLSL parser has been simplified to check for the needed
GL_ARB_shading_language_420pack extension just when merging the
qualifiers in the proper cases.
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_type.cpp | 6 ++
src/compiler/glsl/glsl_parser.yy
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast.h | 3 +--
src/compiler/glsl/ast_type.cpp | 17 +++--
src/compiler/glsl/glsl_parser_extras.cpp | 2 +-
3 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/src/compiler/glsl/ast.h b/src/com
e are pushing this to the global values since
before it was mixed in the merging call and we only run this once all
the processing for layout-qualifiers in a declaration has happened.
Reviewed-by: Timothy Arceri
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast.h | 6 +
src/com
On Fri, 2016-11-25 at 11:07 +1100, Timothy Arceri wrote:
> Thanks.
Thanks for your patience with the review! ☺
> Patches 7 & 8 are:
>
> Reviewed-by: Timothy Arceri
Pushing!
--
Br,
Andres
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
htt
Signed-off-by: Andres Gomez
---
docs/submittingpatches.html | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
index 2d18c74..3d07c5e 100644
--- a/docs/submittingpatches.html
+++ b/docs/submittingpatches.html
outputs.
Therefore, Dave, please, go ahead and land your patch.
Reviewed-by: Andres Gomez
Br.
On Wed, 2016-08-10 at 16:26 +0300, Andres Gomez wrote:
> Hi,
>
> On Mon, 2016-05-23 at 14:18 +1000, Dave Airlie wrote:
> > From: Dave Airlie
> >
> >
Ugh! Thanks for this.
This is
Reviewed-by: Andres Gomez
Br.
On Thu, 2016-12-15 at 20:10 -0800, Ian Romanick wrote:
> From: Ian Romanick
>
> glsl/ast_type.cpp: In function ‘bool validate_point_mode(YYLTYPE*,
> _mesa_glsl_parse_state*, const ast_type_qualifier&, const
>
This reverts commit 644e015f0b9236e955d679cac4bcc7a1523fc475.
PrimitiveMode from the program doesn't hold the proper value when
reaching this code. We rather take it from the linked shader.
Signed-off-by: Andres Gomez
---
src/mesa/drivers/dri/i965/brw_tcs.c | 5 +++--
1 file chang
On Thu, 2016-06-30 at 00:09 +1000, Timothy Arceri wrote:
>
> On 29 June 2016 11:29:17 pm AEST, Andres Gomez
> wrote:
> > This reverts commit 644e015f0b9236e955d679cac4bcc7a1523fc475.
> >
> > PrimitiveMode from the program doesn't hold the proper value when
> &
On Thu, 2016-06-30 at 00:29 -0700, Ian Romanick wrote:
> On 06/29/2016 05:55 PM, Timothy Arceri wrote:
...
> >
>
> So, I don't think there is a clear part of the spec to quote here,
> and
> I looked. :) While the spec doesn't come right out and say it, I
> think
> we can infer that this behavior
On Wed, 2016-06-29 at 18:37 -0700, Ian Romanick wrote:
> On 06/27/2016 08:28 AM, Andres Gomez wrote:
> > The linker deals with atomic counters in terms of uniforms. This is
> > OK
> > but when we want to know the number of used atomic counters since a
> > 2
> > el
On Thu, 2016-06-30 at 10:55 +1000, Timothy Arceri wrote:
> On Mon, 2016-06-27 at 18:28 +0300, Andres Gomez wrote:
> > The linker deals with atomic counters in terms of uniforms. This is
> > OK
> > but when we want to know the number of used atomic counters since a
>
On Thu, 2016-06-30 at 10:21 +1000, Timothy Arceri wrote:
> On Wed, 2016-06-29 at 17:23 +0300, Andres Gomez wrote:
> > On Thu, 2016-06-30 at 00:09 +1000, Timothy Arceri wrote:
> > >
> > > On 29 June 2016 11:29:17 pm AEST, Andres Gomez > > >
>
h that variable will call that
particular function."
Fixes
GL44-CTS.shader_subroutine.subroutines_cannot_be_assigned_float_int_values_or_be_compared
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_to_hir.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/compiler/
Dropping this patch. It seems I overlooked:
https://lists.freedesktop.org/archives/mesa-dev/2016-June/119616.html
On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote:
> subroutine variables are to be used just in the way functions are
> called. Although the spec doesn't say it explic
Hi,
Just dropped:
https://lists.freedesktop.org/archives/mesa-dev/2016-July/123485.html
I didn't realize there was already this thread open.
On Tue, 2016-06-07 at 09:59 -0700, Ian Romanick wrote:
> On 06/06/2016 10:20 PM, Dave Airlie wrote:
> > From: Dave Airlie
> >
> > This fixes:
> > GL45-CT
ontains_subroutine() ?
That way we would be having into account subroutine arrays too.
Other than the open discussion about whether this is allowed by the
specs or not, this is:
Reviewed-by: Andres Gomez
--
Br,
Andres
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, 2016-07-19 at 13:45 -0700, Ian Romanick wrote:
> On 07/19/2016 06:54 AM, Andres Gomez wrote:
...
> > So, what would be the conclusion? Do we allow subroutine variables
> > comparison?
>
> There is no conclusion yet. I opened a Khronos gitlab tracker (right
> afte
On Fri, 2016-07-22 at 06:07 +1000, Dave Airlie wrote:
> >
> > On Mon, 2016-07-18 at 16:39 +0300, Andres Gomez wrote:
> > > subroutine variables are to be used just in the way functions are
> > > called. Although the spec doesn't say it explicitely, this means th
When an argument for a structure constructor or initializer doesn't
match the expected type, only Section 4.1.10 “Implicit Conversions”
are allowed to try to match that expected type.
Fixes GL44-CTS.shading_language_420pack.initializer_list_negative
Andres Gomez (2):
glsl/types: dis
ing to section 4.1.10
"Implicit Conversions". In the latter case, an implicit conversion
will be done on the initializer before the assignment is done."
Fixes GL44-CTS.shading_language_420pack.initializer_list_negative
Signed-off-by: Andres G
Implicit conversions were added in the GLSL 1.20 spec version.
Signed-off-by: Andres Gomez
---
src/compiler/glsl_types.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp
index 8a06695..24aec25 100644
--- a/src/compiler
AST_NUM_OPERATORS stores the dimension of the ast_operators
enumeration but was not updated after its last modification.
This doesn't add any real modification for any code paths but it makes
sense for coherence.
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast.h
On Mon, 2016-08-01 at 09:35 +1000, Timothy Arceri wrote:
> On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote:
> > Implicit conversions were added in the GLSL 1.20 spec version.
>
> Does this help fix the CTS test or are you just adding it because you
> noticed it?
It
On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote:
> On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote:
[snip]
> diff --git a/src/compiler/glsl/ast_function.cpp
> > b/src/compiler/glsl/ast_function.cpp
> > index 9dcec50..9b09cb6 100644
> > --- a/src/compil
On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote:
[snip]
> it allows conversions from a vector or a bigger dimension to a vector
of ---^^
> or a smaller dimension. That was making the CTS test fail.
of^^
(Wake up, Andrés!!!)
--
Br,
On Mon, 2016-08-01 at 14:02 +0100, Eric Engestrom wrote:
> On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote:
[snip]
> > diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h
> > index 157895d..89f531c 100644
> > --- a/src/compiler/glsl/ast.h
> > ++
Signed-off-by: Andres Gomez
---
.dir-locals.el | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/.dir-locals.el b/.dir-locals.el
index 4b53931..9c89a63 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -1,4 +1,5 @@
-((prog-mode
+((nil . ((show-trailing-whitespace . t
On Tue, 2016-08-02 at 17:04 +0100, Eric Engestrom wrote:
> On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote:
[snip]
> > I'm not sure I'm understanding what you mean.
> >
> > If you mean to remove the #define and add the value as and additional
> &g
On Mon, 2016-08-01 at 12:05 +0300, Andres Gomez wrote:
> On Mon, 2016-08-01 at 10:01 +1000, Timothy Arceri wrote:
> > On Sun, 2016-07-31 at 18:43 +0300, Andres Gomez wrote:
>
> [snip]
>
> > diff --git a/src/compiler/glsl/ast_function.cpp
> > > b/src/compiler/
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_function.cpp | 4
src/compiler/glsl/ast_to_hir.cpp | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/compiler/glsl/ast_function.cpp
b/src/compiler/glsl/ast_function.cpp
index ccd070f..52cbf1f 100644
--- a/src
Implicit conversions were added in the GLSL 1.20 spec version.
Signed-off-by: Andres Gomez
---
src/compiler/glsl_types.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/compiler/glsl_types.cpp b/src/compiler/glsl_types.cpp
index 8a06695..24aec25 100644
--- a/src/compiler
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_function.cpp | 79 +++---
1 file changed, 47 insertions(+), 32 deletions(-)
diff --git a/src/compiler/glsl/ast_function.cpp
b/src/compiler/glsl/ast_function.cpp
index 9dcec50..567ad6e 100644
--- a/src
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_function.cpp | 880 +++--
1 file changed, 460 insertions(+), 420 deletions(-)
diff --git a/src/compiler/glsl/ast_function.cpp
b/src/compiler/glsl/ast_function.cpp
index 52cbf1f..817673a 100644
--- a/src
ing to section 4.1.10
"Implicit Conversions". In the latter case, an implicit conversion
will be done on the initializer before the assignment is done."
Fixes GL44-CTS.shading_language_420pack.initializer_list_negative
Signed-off-by: Andres G
When an argument for a structure constructor or initializer doesn't
match the expected type, only Section 4.1.10 “Implicit Conversions”
are allowed to try to match that expected type.
Fixes GL44-CTS.shading_language_420pack.initializer_list_negative
Andres Gomez (5):
glsl/types: dis
On Thu, 2016-08-04 at 08:53 +1000, Timothy Arceri wrote:
> On Wed, 2016-08-03 at 23:51 +0300, Andres Gomez wrote:
> > Implicit conversions were added in the GLSL 1.20 spec version.
> >
> > Signed-off-by: Andres Gomez
> > ---
> > src/compiler/glsl_types.cp
Implicit conversions were added in the GLSL 1.20 spec version.
v2 (Timothy): Join the checks for GLSL 1.10 and ESSL.
Signed-off-by: Andres Gomez
---
src/compiler/glsl_types.cpp | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/compiler/glsl_types.cpp b/src
v2: Refactor also the conversion to constant and replacement code
(Timothy).
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_function.cpp | 166 +++--
1 file changed, 86 insertions(+), 80 deletions(-)
diff --git a/src/compiler/glsl/ast_function.cpp
b
nd the replacement code
(Timothy).
Fixes GL44-CTS.shading_language_420pack.initializer_list_negative
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_function.cpp | 104 -
1 file changed, 55 insertions(+), 49 deletions(-)
diff --git a/src/compiler/glsl/ast_function.cpp
On Fri, 2016-08-05 at 08:35 +1000, Timothy Arceri wrote:
> Thanks for you patience with this series :) The parameter check above
The other way around, thanks to you for reviewing! ☺
> is a nice cleanup too thanks. Patches 2 and 3 are:
>
> Reviewed-by: Timothy Arceri
... and it has already lan
This patch is intended to fix:
https://bugs.freedesktop.org/show_bug.cgi?id=82991
Which is now also exposed through the piglit patch sent at:
http://lists.freedesktop.org/archives/piglit/2014-December/013648.html
Andres Gomez (1):
i965/brw_reg: struct constructor now needs explicit negate and
We were asuming, when constructing a new brw_reg struct, that the
negate and abs register modifiers would not be present by default in
the new register.
Now, we force explicitly setting these values when constructing a new
register.
This will avoid problems like forgetting to properly set them wh
On Mon, 2014-12-15 at 11:24 -0800, Matt Turner wrote:
> On Mon, Dec 15, 2014 at 11:03 AM, Matt Turner wrote:
> > Reviewed-by: Matt Turner
> > Cc: "10.4 10.3"
>
> Oh, I suppose I need to commit this and the piglit test? Just confirm
> and I'll do it.
Yes, please, I don't have commit rights (yet
Gomez wrote:
> On Fri, 2019-01-11 at 15:22 +, Emil Velikov wrote:
> > Hi Andres,
> >
> > On Fri, 11 Jan 2019 at 15:05, Andres Gomez wrote:
> > >
> > > I'll start with the 18.3.2 release process and keep with the the
> > > following bugfix re
On Fri, 2019-01-11 at 15:41 +, Emil Velikov wrote:
> On 2019/01/11, Andres Gomez wrote:
> > "&>" is bash specific.
> >
> > Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid
> > sha")
> > Cc: Juan A. Suare
On Fri, 2019-01-11 at 14:56 +, Eric Engestrom wrote:
> On Friday, 2019-01-11 16:42:25 +0200, Andres Gomez wrote:
> > "--summary" will also print extended header information such as
> > creations, renames and mode changes.
> >
> > Let's just
ion
aliasing is happening for the inputs.
Therefore, we also need to validate the inputs independently from the
outcome of the outputs validation.
Cc: Timothy Arceri
Cc: Iago Toral Quiroga
Cc: Ilia Mirkin
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_varyings.cpp | 13 ++---
1 f
n")
Cc: Timothy Arceri
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_varyings.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/compiler/glsl/link_varyings.cpp
b/src/compiler/glsl/link_varyings.cpp
index 6cebc5b3c5a..ab66ceb0d00 100644
--- a/src/compiler/gl
t succeeds:
"
...
layout (xfb_offset = 0) out vec2 a;
layout (xfb_offset = 0) out vec4 b;
...
"
Cc: Timothy Arceri
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_varyings.cpp | 23 +++
1 file changed, 23 insertions(+)
diff --git a/src/compiler/glsl/link
;glsl: validate and store component layout qualifier in
GLSL IR")
Cc: Timothy Arceri
Cc: Kenneth Graunke
Signed-off-by: Andres Gomez
---
src/compiler/glsl/ast_to_hir.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
This series addresses the problems tested in the piglit series sent
for review at:
https://patchwork.freedesktop.org/series/56099/
Andres Gomez (5):
glsl: correctly validate component layout qualifier for dvec{3,4}
glsl/linker: always validate explicit location among inputs
glsl/linker
mothy Arceri
Cc: Iago Toral Quiroga
Cc: Samuel Iglesias Gonsálvez
Cc: Tapani Pälli
Cc: Ian Romanick
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_varyings.cpp | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/link_varyings.cpp
b/src/c
52e7516a ("glsl/linker: Fix type checks for location aliasing")
Cc: Ilia Mirkin
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_varyings.cpp | 64 +
1 file changed, 46 insertions(+), 18 deletions(-)
diff --git a/src/compiler/glsl/link_varyings
On Sat, 2019-02-02 at 10:10 +1100, Timothy Arceri wrote:
> On 2/2/19 5:05 am, Andres Gomez wrote:
> > Current implementation uses a complicated calculation which relies in
> > an implicit conversion to check the integral part of 2 division
> > results.
> >
> >
On Fri, 2019-02-01 at 13:17 -0500, Ilia Mirkin wrote:
> On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote:
> > Current implementation uses a complicated calculation which relies in
> > an implicit conversion to check the integral part of 2 division
> > results.
> >
&
On Fri, 2019-02-01 at 18:37 -0500, Ilia Mirkin wrote:
> On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote:
> > If there is no Static Use of an input variable, the linker shouldn't
> > fail whenever there is no defined matching output variable in the
> > previous stage.
&
On Wed, 2019-02-06 at 09:42 +1100, Timothy Arceri wrote:
> On 6/2/19 1:11 am, Andres Gomez wrote:
> > On Fri, 2019-02-01 at 18:37 -0500, Ilia Mirkin wrote:
> > > On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote:
> > > > If there is no Static Use of an input
Tapani Pälli
Cc: Ian Romanick
Cc: Ilia Mirkin
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_varyings.cpp | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/compiler/glsl/link_varyings.cpp
b/src/compiler/glsl/link_varyings.cpp
index e5f7d3
ce between vs and gs has a used input that doesn't
> exist in the vs. The test should fail validation, the idea being the
> test would have failed on your v1 of this patch.
>
> Thanks.
>
>
> On 7/2/19 2:58 am, Andres Gomez wrote:
> > If there is no Static Use of
ll be undefined."
Fixes: 1aa5738e666 ("glsl: relax input->output validation for SSO programs")
Cc: Tapani Pälli
Cc: Timothy Arceri
Cc: Ilia Mirkin
Cc: Samuel Iglesias Gonsálvez
Cc: Ian Romanick
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_varyings.cpp | 2 +-
1 fi
On Sat, 2019-02-02 at 10:49 +1100, Timothy Arceri wrote:
> On 2/2/19 5:05 am, Andres Gomez wrote:
> > From page 62 (page 68 of the PDF) of the GLSL 4.50 v.7 spec:
> >
> >" A dvec3 or dvec4 can only be declared without specifying a
> > component."
>
table 8.2.
An INVALID_VALUE error is generated if format is not one of the
formats in table 8.3."
Fixes the following test:
KHR-GL45.direct_state_access.buffers_errors
Cc: Pi Tabred
Cc: Brian Paul
Signed-off-by: Andres Gomez
---
src/mesa/main/bufferobj.c | 8
1 file
t succeeds:
"
...
layout (xfb_offset = 0) out vec2 a;
layout (xfb_offset = 0) out vec4 b;
...
"
v2: use a data structure to track the used components instead of a
nested loop (Ilia).
Cc: Timothy Arceri
Cc: Ilia Mirkin
Signed-off-by: Andres Gomez
---
src/compiler/glsl/li
On Thu, 2019-02-14 at 14:31 +0200, Tapani Pälli wrote:
> LGTM
>
> Reviewed-by: Tapani Pälli
Thanks for the review, Tapani ☺
>
> On 2/12/19 2:17 PM, Andres Gomez wrote:
> > Instead of generating a GL_INVALID_ENUM error when the type or format
> > is incorrect while
nce, I'll understand I can land this with your Rb.
>
> Reviewed-by: Timothy Arceri
>
> Thanks for fixing this!
>
> On 7/2/19 2:58 am, Andres Gomez wrote:
> > If there is no Static Use of an input variable, the linker shouldn't
> > fail whenever th
On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote:
> On 2/2/19 5:05 am, Andres Gomez wrote:
> > From: Iago Toral Quiroga
> >
> > Regarding location aliasing requirements, the OpenGL spec says:
> >
> >"Further, when location aliasing, the aliases
On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote:
> On 2/2/19 5:05 am, Andres Gomez wrote:
> > From: Iago Toral Quiroga
> >
> > Regarding location aliasing requirements, the OpenGL spec says:
> >
> >"Further, when location aliasing, the aliases
On Thu, 2019-03-21 at 00:20 +1100, Timothy Arceri wrote:
> On 20/3/19 9:31 pm, Andres Gomez wrote:
> > On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote:
> > > On 2/2/19 5:05 am, Andres Gomez wrote:
> > > > From: Iago Toral Quiroga
> > > >
> &
On Wed, 2019-03-20 at 16:46 +0200, Andres Gomez wrote:
> On Thu, 2019-03-21 at 00:20 +1100, Timothy Arceri wrote:
> > On 20/3/19 9:31 pm, Andres Gomez wrote:
> > > On Wed, 2019-03-20 at 20:46 +1100, Timothy Arceri wrote:
> > > > On 2/2/19 5:05 am, Andres Gomez wro
-by: Andres Gomez
---
src/compiler/glsl/ast_to_hir.cpp | 316 +--
1 file changed, 171 insertions(+), 145 deletions(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 7c9be81..e4ebc6b 100644
--- a/src/compiler/glsl
Fri, Mar 4, 2016 at 5:43 AM, Andres Gomez > <mailto:ago...@igalia.com>> wrote:
> >
> > Hi,
> >
> > as complementary work to the one done to "Add FP64 support to
> > the i965
> > shader backends" at:
> > https://bu
Hi,
I haven't had any other feedback than Ilia's (thanks Ilia!) so my
doubts still stand.
I'd welcome more info regarding this topic.
Thanks!
Br.
On Tue, 2016-03-15 at 17:46 +0200, Andres Gomez wrote:
> Hi,
>
> as complementary work to the one done to "Add FP64 s
Hi,
this patch is still unreviewed.
I'd welcome some help to get this into mesa :)
--
Br,
Andres
signature.asc
Description: This is a digitally signed message part
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.
amp to destination type range, and NaN gets
> converted to 0. Hence why implementations tend to do this. But still
> undefined in glsl (which, of course, doesn't mean someone might not
> rely
> on d3d10 behaviour there...).
>
> Roland
>
>
> Am 05.04.2016 um 09:33 schrie
Hi,
I would really appreciate if you could find some time to review this
patch.
Thanks!
On Mon, 2016-04-04 at 19:50 +0300, Andres Gomez wrote:
> This generalizes the validation also to be done for variables inside
> interface blocks, which, for some cases, was missing.
>
> For
Hi,
On Tue, 2016-04-19 at 08:53 +1000, Timothy Arceri wrote:
> On Mon, 2016-04-18 at 19:44 +0300, Andres Gomez wrote:
> >
> > Hi,
> >
> > I would really appreciate if you could find some time to review
> > this
> > patch.
> Is there a patch somewhere
Previously, when no pkg-config was available for
libexpat we would just add the needed linking
flags without any extra check.
Now, we check that the library and the headers are
also installed in the building environment.
---
configure.ac | 15 +++
1 file changed, 7 insertions(+), 8 de
---
src/glsl/README | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/glsl/README b/src/glsl/README
index 0a0afcc..2f93f12 100644
--- a/src/glsl/README
+++ b/src/glsl/README
@@ -8,7 +8,7 @@ passed straight through. See glcpp/*
2) lex and yacc-based parser
---
src/glsl/linker.cpp | 4 ++--
src/glsl/lower_offset_array.cpp | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 47a722d..c3f435c 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -1679,7 +167
When using the stand alone compiler, if we try to
link a shader with vertex attributes it will
segfault on linking as the binding hash tables are
not included in the shader program. Obviously, we
cannot make the linking stage succeed without the
bound attributes but we can prevent the crash and
jus
On Mon, 2014-11-17 at 09:25 -0700, Brian Paul wrote:
> Please split up this patch into:
>
> 1. gallium comment fixes
> 2. linker string fixes
> 3. hash table code changes
Sure. I thought it was not worth given the small changes but I suppose
it is always better to have different topics in differe
---
src/gallium/auxiliary/draw/draw_private.h | 2 +-
src/gallium/auxiliary/draw/draw_pt_vsplit.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/draw/draw_private.h
b/src/gallium/auxiliary/draw/draw_private.h
index d8dc2ab..37045eb 100644
--- a/src/
---
src/glsl/linker.cpp | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 2d31801..794efdc 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -642,7 +642,7 @@ validate_geometry_s
When using the stand alone compiler, if we try to
link a shader with vertex attributes it will
segfault on linking as the binding hash tables are
not included in the shader program. Obviously, we
cannot make the linking stage succeed without the
bound attributes but we can prevent the crash and
jus
Also, renamed get_conversion_operation to avoid
future misunderstandings.
---
src/compiler/glsl/ast_to_hir.cpp | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 75abef6..db5ec9a 100644
--- a/src/comp
Hi,
as complementary work to the one done to "Add FP64 support to the i965
shader backends" at:
https://bugs.freedesktop.org/show_bug.cgi?id=92760
I've been working to add piglit tests that would check the new features
added by this addition.
Checking the specification of the extension, when tal
I tried to be careful, and still I introduced a mistake ...
On Fri, 2016-03-04 at 15:43 +0200, Andres Gomez wrote:
...
> The situation with the glslangValidator is (it doesn't support doubles):
> * When using a non-flat integer as a fragment input in the form of
> an
Hi,
as complementary work to the one done to "Add FP64 support to the i965
shader backends" at:
https://bugs.freedesktop.org/show_bug.cgi?id=92760
We've been working to add piglit tests that would check the new features
added by this addition. Because of this, we have created several
generators.
On Fri, 2016-03-04 at 11:49 -0800, Matt Turner wrote:
...
> So to answer your main question, I would generate tests for both
> glsl-4.00 and arb_gpu_shader_fp64, but only manually write tests for
> arb_gpu_shader_fp64.
Thanks for the early reply, Matt!
We will do as you suggest.
--
Br,
Andres
ment shader for (unsigned)
integers and doubles.
* Open a bug in Khronos specs bugzilla about the ambiguity of
this.
Br.
On Fri, 2016-03-04 at 15:43 +0200, Andres Gomez wrote:
> Hi,
>
> as complementary work to the one done to "Add FP64 support to the i965
&
Hi,
as complementary work to the one done to "Add FP64 support to the i965
shader backends" at:
https://bugs.freedesktop.org/show_bug.cgi?id=92760
I've been working to add piglit tests that would check the new features
added by this addition.
One of the topics we have been creating tests for is
On Tue, 2016-03-15 at 12:38 -0400, Ilia Mirkin wrote:
> Not really an answer to your question, but you may be interested in
> this model of the NVIDIA Tesla FPU that mwk RE'd, including fp64
> (which was available on the G200 only in that series). I have no
> reason to believe that Fermi+ are subst
-CTS.arrays_of_arrays_gl.AtomicDeclaration
Signed-off-by: Andres Gomez
---
src/compiler/glsl/link_atomics.cpp | 83 --
1 file changed, 44 insertions(+), 39 deletions(-)
diff --git a/src/compiler/glsl/link_atomics.cpp
b/src/compiler/glsl/link_atomics.cpp
index
Signed-off-by: Andres Gomez
---
docs/release-calendar.html | 2 +-
docs/releasing.html| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/release-calendar.html b/docs/release-calendar.html
index 19f518db1a..730cff8921 100644
--- a/docs/release-calendar.html
+++ b
oga
Cc: Lionel Landwerlin
Signed-off-by: Andres Gomez
---
src/intel/vulkan/anv_formats.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 104d4f7a5fe..0bc81d12dab 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/s
kan_radeon',
> - [libradv_files, radv_entrypoints, nir_opcodes_h, vk_format_table_c],
> + [libradv_files, radv_entrypoints, radv_extensions, nir_opcodes_h,
> vk_format_table_c],
>include_directories : [inc_common, inc_amd, inc_amd_common, inc_compiler,
>
Hi,
Just chipping in to leave a couple of additional notes.
As other have said before me, I also think the organization was very
good.
Things mentioned before:
* Tables layout: kind of agree it was not great for following the
talks but they were also making it easier to talk with other
a
Emil, by 17.2, Clover is still asking only for LLVM 3.6 and "coverage"
doesn't seem to be there.
Hence, I think we should drop or backport this patch. In any case,
check my other mail about this patch series ...
On Thu, 2017-10-05 at 11:19 +0100, Emil Velikov wrote:
> From: Emil Velikov
>
> Cov
101 - 200 of 665 matches
Mail list logo
