Re: [Mesa-dev] [PATCH 06/11] glapi: Fix whitespace droppings when printing the license header

On Mon, 2016-03-28 at 11:19 -0700, Dylan Baker wrote: > Quoting Ian Romanick (2016-03-28 11:03:58) > > > > On 03/25/2016 05:33 PM, Dylan Baker wrote: > > > > > > Quoting Dylan Baker (2016-03-25 16:01:00) > > > > > > > > Quoting Adam Jack

Re: [Mesa-dev] [PATCH 06/11] glapi: Fix whitespace droppings when printing the license header

On Tue, 2016-03-29 at 09:24 -0700, Dylan Baker wrote: > Ah, that's the problem. While we could do something like add .rstrip() > to the string, I think that just fixing this in the template would be > easier. Yeah, have that done locally. I've merged (most of) the reviewed bits of this series, wo

Re: [Mesa-dev] [PATCH] docs: Mark GL_KHR_no_error as done.

On Tue, 2017-10-24 at 19:48 +0200, Samuel Pitoiset wrote: > That's quite right. :) > > Reviewed-by: Samuel Pitoiset > > Though, we still need GLX_ARB_create_context_no_error. Here's the > pending series https://patchwork.freedesktop.org/patch/170204/ (in case > someone more familiar with the c

[Mesa-dev] [PATCH 0/9] Implement {GLX_ARB, EGL_KHR}_context_flush_control

Yet another rebase and resend, as I'm getting to the point where I'd like to be able to use this in xserver. This only enables it for llvmpipe and i965, it's trivial to enable for other drivers but I haven't tested any. - ajax ___ mesa-dev mailing list

[Mesa-dev] [PATCH 2/9] intel: Don't flush the old context in intelMakeCurrent

only added later in 93102b4c. I think that later commit effectively makes the first commit redundant. Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/mesa/drivers/dri/i915/intel_context.c | 9 - src/mesa/drivers/dri/i965/brw_context.c | 9 - 2 files change

[Mesa-dev] [PATCH 5/9] glx: Implement GLX_ARB_context_flush_control

From: Neil Roberts Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/glx/dri2_glx.c | 18 -- src/glx/dri3_glx.c | 14 -- src/glx/dri_common.c| 16 +++- src/glx/dri_common.h| 2 +- src/glx/drisw_glx.c | 17

[Mesa-dev] [PATCH 1/9] egl/dri2: Factor out context attribute initialization

Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/egl_dri2.c | 35 +-- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 503450542e..57226f60a7 100644 --- a/src/egl/drivers

[Mesa-dev] [PATCH 7/9] gallium: Wire up flush control

Reviewed-by: Marek Olšák Signed-off-by: Adam Jackson --- src/gallium/include/state_tracker/st_api.h | 1 + src/gallium/state_trackers/dri/dri_context.c | 6 +- src/mesa/state_tracker/st_manager.c | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 6/9] egl: Implement EGL_KHR_context_flush_control

Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/egl_dri2.c | 11 ++- src/egl/drivers/dri2/egl_dri2.h | 1 + src/egl/main/eglapi.c | 1 + src/egl/main/eglcontext.c | 10 ++ src/egl/main/eglcontext.h | 1 + src/egl/main/egldisplay.h | 1 + 6

[Mesa-dev] [PATCH 4/9] dri: Add a flush control extension

From: Neil Roberts This advertises that the driver can accept a new context attribute __DRI_CTX_ATTRIB_RELEASE_BEHAVIOR. Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- include/GL/internal/dri_interface.h| 25 + src/mesa/drivers/dri/common/dri_util.c

[Mesa-dev] [PATCH 8/9] drisw: Enable flush control for llvmpipe and softpipe

ic, but the testcase wants GL 3.0 and shaders, and that's not a thing classic has, so I figured making it work on softpipe was crime enough. Reviewed-by: Marek Olšák Signed-off-by: Adam Jackson --- src/gallium/state_trackers/dri/drisw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/g

[Mesa-dev] [PATCH 3/9] dri: Change __DriverApiRec::CreateContext to take a struct for attribs

d the attribute has the default value. Drivers will error if unknown bits in the mask are set. Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/gallium/state_trackers/dri/dri_context.c | 32 +++ src/gallium/state_trackers/dri/dri_context.h | 6 +-- src/mesa/driver

[Mesa-dev] [PATCH 9/9] i965: Enable flush control

From: Neil Roberts Reviewed-by: Adam Jackson Signed-off-by: Neil Roberts --- src/mesa/drivers/dri/i965/brw_context.c | 20 +++- src/mesa/drivers/dri/i965/intel_screen.c | 2 ++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH] Enable flush control for hardware gallium drivers

i965 and the software drivers have this, but not any other gallium driver. Sending this out-of-line since it probably wants testing on a broad spectrum of hardware (not all of which I have). - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

[Mesa-dev] [PATCH] gallium/dri2: Enable {GLX_ARB, EGL_KHR}_context_flush_control

Signed-off-by: Adam Jackson --- src/gallium/state_trackers/dri/dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index e0cd0e0bc7..d6f8f7e8d1 100644 --- a/src/gallium/state_trackers/dri/dri2.c +++ b/src

[Mesa-dev] [PATCH 1/3] glx: Relax validate_renderType_against_config for EXT_no_config_context

Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index 10c7c2c3eb..c707d0cedf 100644 --- a/src/glx/glxcmds.c +++ b/src/glx/glxcmds.c @@ -235,19 +235,23

[Mesa-dev] [PATCH 2/3] glx: Prepare the DRI backends for GLX_EXT_no_config_context

eally want the HDC's pixel format to be set. Signed-off-by: Adam Jackson --- src/glx/dri2_glx.c | 4 ++-- src/glx/dri3_glx.c | 5 +++-- src/glx/drisw_glx.c | 4 ++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index e67a15f9da..

[Mesa-dev] [PATCH 3/3] glx: Implement GLX_EXT_no_config_context (v2)

This more or less ports EGL_KHR_no_config_context to GLX. v2: Enable the extension only for those backends that support it. Khronos: https://github.com/KhronosGroup/OpenGL-Registry/pull/102 Reviewed-by: Kenneth Graunke Signed-off-by: Adam Jackson --- src/glx/create_context.c | 41

[Mesa-dev] [PATCH] docs: Update feature list for GL 4.6

ARB_polygon_offset_clamp and ARB_texture_filter_anisotropic look like they'd be pretty trivial to wire up. Signed-off-by: Adam Jackson --- docs/features.txt | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/docs/features.txt b/docs/features.txt

Re: [Mesa-dev] [PATCH] docs: Update feature list for GL 4.6

On Mon, 2017-07-31 at 13:05 -0700, Matt Turner wrote: > > @@ -221,6 +221,20 @@ GL 4.5, GLSL 4.50 -- all DONE: nvc0, radeonsi > >GL_KHR_robustness DONE (i965) > >GL_EXT_shader_integer_mix DONE (all drivers > > that support GLS

[Mesa-dev] [PATCH 1/3] specs: Update Mesa EGL enums

Note that, presumably because Khronos never got a copy of WL_bind_wayland_display in the registry, we've double-allocated some enums into the (now KHR) platform extensions, and we should consider retiring the wayland extension at some point to fix it. Signed-off-by: Adam Jackson --- docs/

[Mesa-dev] [RFC PATCH 0/3] EGL spec updates and proposals

I've been looking at finishing up the EGL_EXT_device_base work properly as I'd like to consume it in xserver. I think I'm going to need some additional extensions to be able to consume it sanely though, so, here's some draft specs. Any feedback would be greatly appreciated. 1/3 is a bit unrelated,

[Mesa-dev] [PATCH 2/3] specs: Add EGL_MESA_device_software

The device extension string is expected to contain the name of the extension defining what kind of device it is, so the caller can know what kinds of operations it can perform with it. So that string had better be non-empty, hence this trivial extension. Signed-off-by: Adam Jackson --- docs

[Mesa-dev] [PATCH 3/3] specs: Add EGL_MESA_platform_device

This extension name is bad, but I don't have an idea for a better one. Signed-off-by: Adam Jackson --- docs/specs/EGL_MESA_platform_device.txt | 94 + 1 file changed, 94 insertions(+) create mode 100644 docs/specs/EGL_MESA_platform_device.txt diff --git a

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_texture_filter_anisotropic

On Wed, 2017-06-28 at 16:50 +0300, Plamena Manolova wrote: > ARB_texture_filter_anisotropic is the ARB variation of > EXT_texture_fitter_anisotropic and it operates in the > same way, so there's no reason not to advertise it. Nak. The ARB version bups the minmax anisotropy to 16x, see issue 2 in t

[Mesa-dev] [PATCH 0/3] Implement more 4.6 extensions

I hadn't seen Plamena's patches for these before writing them, and I think I got right most of the issues that were caught in review (namely: 16x minmax for aniso, updated headers and xml for new dispatch for polygon offset clamp), so in the interest of saving time... - ajax _

[Mesa-dev] [PATCH 1/3] include: Sync Khronos headers for OpenGL 4.6

Taken from c21e602b9fda1d3bbaecb08194592f67e6a0649b from OpenGL-Registry. Signed-off-by: Adam Jackson --- include/GL/glcorearb.h | 66 ++- include/GL/glext.h | 82 +++-- include/GL/glxext.h| 2 +- include/GL/wglext.h| 2 +- src

[Mesa-dev] [PATCH 3/3] mesa: Implement GL_ARB_polygon_offset_clamp

Identical to the EXT version. Signed-off-by: Adam Jackson --- docs/features.txt| 2 +- src/mapi/glapi/gen/GL4x.xml | 9 + src/mesa/drivers/dri/i965/intel_extensions.c | 1 + src/mesa/main/dlist.c| 20

[Mesa-dev] [PATCH 2/3] mesa: Implement GL_ARB_texture_filter_anisotropic

The only difference from the EXT version is bumping the minmax to 16, so just hit all the drivers at once. Signed-off-by: Adam Jackson --- docs/features.txt| 4 +++- src/glx/glxextensions.c | 1 + src/glx/glxextensions.h | 1

Re: [Mesa-dev] [PATCH 3/3] specs: Add EGL_MESA_platform_device

On Mon, 2017-08-07 at 09:24 +0100, Daniel Stone wrote: > On 2 August 2017 at 21:24, Adam Jackson wrote: > > +Overview > > + > > +A system may support multiple devices and multiple window systems. For > > +example, a Wayland environment may drive multiple GPUs an

Re: [Mesa-dev] [PATCH 2/3] specs: Add EGL_MESA_device_software

On Tue, 2017-08-08 at 19:11 +0100, Emil Velikov wrote: > On 2 August 2017 at 21:24, Adam Jackson wrote: > > The device extension string is expected to contain the name of the > > extension defining what kind of device it is, so the caller can know > > what kinds of operation

[Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

If the gbm_create_device() call here actually did fail, any subsequent eglTerminate on the display would segfault. Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/platform_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src

[Mesa-dev] [PATCH 1/3] egl/x11: Honor the EGL_PLATFORM_X11_SCREEN_EXT attribute

Signed-off-by: Adam Jackson --- src/egl/drivers/dri2/platform_x11.c | 2 +- src/egl/main/egldisplay.c | 19 --- src/egl/main/egldisplay.h | 1 + 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl

[Mesa-dev] [PATCH 3/3] egl: Implement EGL_EXT_device_{base, query, enumeration}

From: Jonny Lamb This is a rebase/squash/rewrite of a series Jonny had sent long ago. The major change is implementing this in terms of the drmDevice API. Both relevant piglits go from skip to pass on i965. Signed-off-by: Adam Jackson --- src/egl/Makefile.sources| 2 + src/egl

Re: [Mesa-dev] [PATCH 3/3] egl: Implement EGL_EXT_device_{base, query, enumeration}

On Wed, 2017-05-03 at 12:38 -0700, Eric Anholt wrote: > > Adam Jackson writes: > > +#ifdef HAVE_LIBDRM > > +/* XXX kind of copypasta of drmCompareBusInfo */ > > +static int > > +dri2_bus_info_equal(drmDevicePtr a, drmDevicePtr b) > > +{ > > +if

Re: [Mesa-dev] [PATCH 2/3] egl/platform/drm: Don't take display ownership until gbm is initialized

On Thu, 2017-05-04 at 13:00 +0100, Emil Velikov wrote: > On 3 May 2017 at 16:57, Adam Jackson wrote: > > If the gbm_create_device() call here actually did fail, any > > subsequent > > eglTerminate on the display would segfault. > > > > We do have a couple

Re: [Mesa-dev] [PATCH] egl: EXT_pixel_format_float plumbing

> >dEQP-EGL.functional.choose_config.color_component_type_ext.dont_care >dEQP-EGL.functional.choose_config.color_component_type_ext.fixed >dEQP-EGL.functional.choose_config.color_component_type_ext.float > > Signed-off-by: Tapani Pälli Revi

[Mesa-dev] [PATCH 3/3] glx/dri3: Fix passing renderType into glXCreateContext

Without this, trying to create a GLX_RGBA_FLOAT_TYPE_ARB context would fail, because GLX_RGBA_TYPE would be a mismatch with the fbconfig. Signed-off-by: Adam Jackson --- src/glx/dri3_glx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glx/dri3_glx.c b/src/glx

[Mesa-dev] [PATCH 2/3] glx/drisw: Fix glXMakeCurrent(dpy, None, ctx)

This is perfectly legal in GL 3.0+. Fixes piglit/glx-create-context-no-current-framebuffer. Signed-off-by: Adam Jackson --- src/glx/drisw_glx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c index 2f0675addb..df2467a5c2

[Mesa-dev] [PATCH 0/3] Misc GLX cleanups

Testing the EXT_no_config_context series revealed that a bunch more things were broken than I expected. While I work my way through that, here's one trivial cleanup and a couple of pretty obvious bugfixes. - ajax ___ mesa-dev mailing list mesa-dev@lists

[Mesa-dev] [PATCH 1/3] glx: Lower GLX opcode lookup into SendMakeCurrentRequest

Signed-off-by: Adam Jackson --- src/glx/indirect_glx.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c index 4302a8ff28..cfae12f6c0 100644 --- a/src/glx/indirect_glx.c +++ b/src/glx/indirect_glx.c @@ -62,13

Re: [Mesa-dev] [PATCH] glx/windows: Fix building libwindowsdri when libX11 headers are installed in a non-standard location

On Fri, 2017-11-10 at 14:00 +, Jon Turney wrote: > Signed-off-by: Jon Turney Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

This more or less ports EGL_KHR_no_config_context to GLX. v2: Enable the extension only for those backends that support it. v3: Fix glvnd path and dri2_convert_glx_attribs() Khronos: https://github.com/KhronosGroup/OpenGL-Registry/pull/102 Reviewed-by: Kenneth Graunke Signed-off-by: Adam

[Mesa-dev] [PATCH 0/6] glx: Implement GLX_EXT_no_config_context

The first three here are mostly cleanup, but after that it got complicated. 4/6 addresses a longstanding bug in the GLX client code where direct contexts would generate no protocol on MakeCurrent, which means the server was unable to know what drawables were bound to a context. We're not presently

[Mesa-dev] [PATCH 1/6] glx: Simplify some dummy vtable interactions

The dummy vtable has these slots as NULL already, no need to check for the dummy context explicitly. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c index c707d0cedf

[Mesa-dev] [PATCH 4/6] glx: Lift sending the MakeCurrent request to top-level code

existing behavior of not calling unbind() on the context if its refcount would not drop to zero, which is why the diff is a little uglier than I'd like. Signed-off-by: Adam Jackson --- src/glx/glxcurrent.c | 181 + src/glx/indirect_glx.c

[Mesa-dev] [PATCH 3/6] glx: Move vertex array protocol state into the indirect backend

Only relevant for indirect contexts, so let's get that code out of the common path. Signed-off-by: Adam Jackson --- src/glx/glxcurrent.c | 12 src/glx/indirect_glx.c | 18 +++--- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/glx/glxcurren

[Mesa-dev] [PATCH 5/6] glx: Prepare driFetchDrawable for no-config contexts

When we look up the DRI drawable state we need to associate an fbconfig with the drawable. With GLX_EXT_no_config_context we can no longer infer that from the context and must instead query the server. Signed-off-by: Adam Jackson --- src/glx/dri_common.c | 22 -- src/glx

[Mesa-dev] [PATCH 2/6] glx: Use __glXSendError instead of open-coding it

This also fixes a bug, the error path through MakeCurrent didn't translate the error code by the extension's error base. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c| 10 +- src/glx/glxcurrent.c | 20 +++- 2 files changed, 4 insertions(+), 26 deletion

Re: [Mesa-dev] [PATCH 3/6] glx: Move vertex array protocol state into the indirect backend

On Tue, 2017-11-14 at 13:15 -0800, Ian Romanick wrote: > On 11/14/2017 12:13 PM, Adam Jackson wrote: > > diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c > > index cfae12f6c0..b552b5768a 100644 > > --- a/src/glx/indirect_glx.c > > +++ b/src/glx/indirect_

Re: [Mesa-dev] [PATCH 4/6] glx: Lift sending the MakeCurrent request to top-level code

On Tue, 2017-11-14 at 14:03 -0800, Ian Romanick wrote: > > static void > > indirect_unbind_context(struct glx_context *gc, struct glx_context *new) > > { > > Mark the parameters UNUSED so that I don't get extra warnings. :) How do I provoke these warnings in my own build? - ajax

[Mesa-dev] [PATCH 2/2] egl: Express eglGetDisplay in terms of _eglGetPlatformDisplayCommon

The latter is now the one place where we initialize an _EGLDisplay. Signed-off-by: Adam Jackson --- src/egl/main/eglapi.c | 67 ++- 1 file changed, 45 insertions(+), 22 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index

[Mesa-dev] [PATCH 1/2] egl: Convert int to attrib in eglGetPlatformDisplay

... because converting attrib to int truncates, and that's bad. Signed-off-by: Adam Jackson --- src/egl/main/eglapi.c | 29 ++--- src/egl/main/egldisplay.c | 15 --- src/egl/main/egldisplay.h | 8 3 files changed, 26 insertions(+), 26 dele

Re: [Mesa-dev] [PATCH 2/2] egl: Express eglGetDisplay in terms of _eglGetPlatformDisplayCommon

On Fri, 2017-11-17 at 16:26 +, Eric Engestrom wrote: > On Thursday, 2017-11-16 13:27:28 -0500, Adam Jackson wrote: > > > @@ -402,6 +380,11 @@ _eglGetPlatformDisplayCommon(EGLenum platform, void > > *native_display, > > case EGL_PLATFORM_SURFACEL

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Fix passing renderType into glXCreateContext

On Mon, 2017-11-20 at 18:13 +0200, Andres Gomez wrote: > Hi Adam, > > This fix is causing the following regression in master (and in the > stable 17.2 queue, if cherry-picked): > https://bugs.freedesktop.org/show_bug.cgi?id=103825 > > Hence, I'm leaving it out until the regression is cleared (eit

Re: [Mesa-dev] 10-bit Mesa/Gallium support

On Thu, 2017-11-23 at 18:35 +0100, Marek Olšák wrote: > Hi everybody, > > Mario, feel free to push your patches if you haven't yet. (except the > workaround) > > For AMD, I applied Mario's patches (except Wayland - that didn't > apply) and added initial Gallium support: > https://cgit.freedesktop

Re: [Mesa-dev] [PATCH mesa 0/7] remove upstreamed specs

On Thu, 2017-11-23 at 16:32 +, Emil Velikov wrote: > On 23 November 2017 at 16:04, Eric Engestrom > wrote: > > On Thursday, 2017-11-23 13:32:47 +, Emil Velikov wrote: > > > > > > > - GLX_MESA_release_buffers > > > > > > Extension is implemented only for Xlib based libGL. The DRI codepat

Re: [Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

On Wed, 2017-11-29 at 19:23 +, Emil Velikov wrote: > From: Emil Velikov > > The extension was never implemented and seemingly never will. > The DRI based libGL dropped support for it over 10 years ago. Series is: Reviewed-by: Adam Jackson There's some stubs in src/glx/g

[Mesa-dev] [PATCH] glx: add support for GLX_ARB_create_context_no_error (v2)

From: Grigori Goronzy v2: Only reject no-error contexts for too-old GL if we're actually trying to create a no-error context (Adam Jackson) Reviewed-by: Adam Jackson --- src/glx/dri2_glx.c | 12 src/glx/dri3_glx.c | 8 src/glx/dri_common.c

Re: [Mesa-dev] [PATCH] glx: add support for GLX_ARB_create_context_no_error (v2)

On Wed, 2017-11-29 at 16:20 -0500, Adam Jackson wrote: > From: Grigori Goronzy > > v2: Only reject no-error contexts for too-old GL if we're actually > trying to create a no-error context (Adam Jackson) > > Reviewed-by: Adam Jackson Note that the original series for t

Re: [Mesa-dev] [PATCH] glx: add support for GLX_ARB_create_context_no_error (v2)

On Wed, 2017-11-29 at 16:20 -0500, Adam Jackson wrote: > From: Grigori Goronzy > > v2: Only reject no-error contexts for too-old GL if we're actually > trying to create a no-error context (Adam Jackson) D'oh, this is still busted, sorry for the noise. We're not savin

Re: [Mesa-dev] [PATCH 5/6] glx: Prepare driFetchDrawable for no-config contexts

On Tue, 2017-11-14 at 14:03 -0800, Ian Romanick wrote: > On 11/14/2017 12:13 PM, Adam Jackson wrote: > > diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c > > index 933b5d9ecd..42e7996e37 100644 > > --- a/src/glx/glx_pbuffer.c > > +++ b/src/glx/glx_pbu

[Mesa-dev] [PATCH] glx: GLX_MESA_multithread_makecurrent is direct-only

This extension is not defined for indirect contexts. Marking it as "client only", as the old code did here, would make the extension available in indirect contexts, even though the server would certainly not have it in its extension list. Cc: Signed-off-by: Adam Jackson --

Re: [Mesa-dev] [PATCH 6/6] glx: Implement GLX_EXT_no_config_context (v3)

On Thu, 2017-11-30 at 16:10 +, Emil Velikov wrote: > On 14 November 2017 at 20:13, Adam Jackson wrote: > > > @@ -562,6 +562,10 @@ dri2_convert_glx_attribs(unsigned num_attribs, > > const uint32_t *attribs, > > return false; > > } > &

[Mesa-dev] [PATCH 1/3] glx: Move vertex array protocol state into the indirect backend (v2)

Only relevant for indirect contexts, so let's get that code out of the common path. v2: Add the necessary context setup before calling GetString Signed-off-by: Adam Jackson --- src/glx/glxcurrent.c | 12 src/glx/indirect_glx.c | 26 ++ 2 files change

[Mesa-dev] [PATCH 2/3] glx: Lift sending the MakeCurrent request to top-level code (v2)

. glx-make-glxdrawable-current regresses, but I believe the test is in error, as the fbconfig it uses to create the context is just "something double-buffered and rgba" as opposed to "corresponds to the visual I used to create the windows". v2: Style fixups (Ian Romanick) Si

[Mesa-dev] [PATCH 3/3] glx: Implement GLX_EXT_no_config_context (v4)

/OpenGL-Registry/pull/102 Reviewed-by: Kenneth Graunke Signed-off-by: Adam Jackson Reviewed-by: Ian Romanick --- src/glx/applegl_glx.c | 3 +++ src/glx/create_context.c | 37 +++ src/glx/dri2_glx.c| 1

[Mesa-dev] [PATCH 0/3] GLX_EXT_no_config_context v4

With one exception (noted in 2/3) this is now regression-free in piglit, and passes make check. - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/3] glx: Move vertex array protocol state into the indirect backend (v2)

On Wed, 2017-12-06 at 14:50 +, Emil Velikov wrote: > > + * have setup the context, as it needs to query server attributes. > > + * > > + * At the point this is called gc->currentDpy is not initialized > > + * nor is the thread's current context actually set. Hence the >

Re: [Mesa-dev] [PATCH 2/3] glx: Lift sending the MakeCurrent request to top-level code (v2)

On Wed, 2017-12-06 at 15:14 +, Emil Velikov wrote: > > - if (gc->vtable->bind(gc, oldGC, draw, read) != Success) { > > + if (gc->vtable->bind(gc, gc, draw, read) != Success) { > > __glXSetCurrentContextNull(); > > This line seems inconsistent/wrong. > > The glXMakeCurrent

Re: [Mesa-dev] [Mesa-stable] [PATCH] glx: GLX_MESA_multithread_makecurrent is direct-only

On Wed, 2017-12-06 at 15:01 -0500, Ian Romanick wrote: > On 12/06/2017 10:32 AM, Emil Velikov wrote: > > On 5 December 2017 at 16:10, Adam Jackson wrote: > > > This extension is not defined for indirect contexts. Marking it as > > > "client only", as

Re: [Mesa-dev] [PATCH] link mesautil with pthreads

On Mon, 2018-01-01 at 22:49 +0100, Igor Gnatenko wrote: > ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function > `u_thread_setname': > /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: > undefined reference to `pthread_setname_np' > ../../src/util/.libs

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

On Fri, 2018-01-12 at 13:18 +, Jon Turney wrote: > 'meson -Ddri-drivers= -Dgallium-drivers=swrast -Dglx=dri' fails with 'dri > based GLX requires at least one DRI driver' > > Signed-off-by: Jon Turney > --- > meson.build | 2 +- > src/glx/meson.build | 2 +- > 2 files changed, 2 inse

Re: [Mesa-dev] [PATCH 1/2] meson: Fix configuring dri glx with only gallium drivers

On Mon, 2018-01-15 at 20:01 +, Jon Turney wrote: > On 12/01/2018 17:25, Dylan Baker wrote: > > meson considers classic swrast to be a dri driver, I know it's not exactly > > accurate, but, at least for me, it made the build system easier to reason > > about. > > I think maybe the point here i

[Mesa-dev] [PATCH 1/2] glx: Sort the GLX extension bit enum and table

Not quite asciibetical: ARB, then EXT, then vendor, just like the GL extension enum just below. No functional change, but it bothered me. Signed-off-by: Adam Jackson --- src/glx/glxextensions.c | 22 +++--- src/glx/glxextensions.h | 24 2 files changed

[Mesa-dev] [PATCH 2/2] glx: Implement GLX_EXT_no_config_context

This more or less ports EGL_KHR_no_config_context to GLX. This is currently a draft extension, under review at: https://github.com/KhronosGroup/OpenGL-Registry/pull/102 Signed-off-by: Adam Jackson --- src/glx/create_context.c | 37 +++-- src/glx/glxextensions.c

[Mesa-dev] [PATCH] glx: Be slightly more tolerant in glXImportContext

) and copy in just the ones we know about, as since these will be indirect contexts the client library probably needs to be explicitly aware of any new context state. Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff -

Re: [Mesa-dev] [PATCH] glx: Be slightly more tolerant in glXImportContext

On Tue, 2017-09-26 at 11:59 -0700, Eric Anholt wrote: > Instead of magic numbers, couldn't we just malloc the proplist here and > free it after the loop? Fine. You tyrant. Actually I have a better idea. We've buffered the entire reply by this point, we can just read two dwords at a time until we

[Mesa-dev] [PATCH] glx: Be more tolerant in glXImportContext (v2)

walk through each property one at a time. v2: Now with no arbitrary limits. (Eric Anholt) Signed-off-by: Adam Jackson --- src/glx/glxcmds.c | 70 +++ 1 file changed, 29 insertions(+), 41 deletions(-) diff --git a/src/glx/glxcmds.c b/src/glx

[Mesa-dev] [PATCH] egl: Simplify the "driver" interface

ery, would have the same issue. Fortunately this is a problem that can be solved with the delete key. Signed-off-by: Adam Jackson --- docs/egl.html | 10 -- src/egl/drivers/dri2/egl_dri2.c | 2 +- src/egl/drivers/haiku/egl_haiku.cpp | 2 +- src/egl/mai

Re: [Mesa-dev] [PATCH] egl: Simplify the "driver" interface

On Thu, 2017-10-05 at 10:17 -0700, Eric Anholt wrote: > Adam Jackson writes: > > > "Driver" isn't a great word for what this layer is, it's effectively a > > build-time choice about what OS you're targeting. Despite that both of > > the extant

Re: [Mesa-dev] [PATCH] fixup! EGL: Implement the libglvnd interface for EGL (v2)

On Thu, 2017-01-05 at 14:29 -0700, Kyle Brenneman wrote: > --- >  src/egl/generate/eglFunctionList.py | 6 -- >  1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Adam Jackson Is this too invasive for 13.1? - ajax ___ mesa-de

[Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

GL_LIB expands to GLX_mesa, but applications should not link against that. -lGL is never wrong, just hardcode it. Signed-off-by: Adam Jackson --- src/mesa/gl.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/gl.pc.in b/src/mesa/gl.pc.in index 181724b97b

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

On Tue, 2018-05-29 at 18:35 +0100, Emil Velikov wrote: > On 29 May 2018 at 15:29, Daniel Stone wrote: > > On 29 May 2018 at 15:17, Eric Engestrom wrote: > > > On Tuesday, 2018-05-29 09:50:46 -0400, Adam Jackson wrote: > > > > GL_LIB expands to GLX_mesa, but applic

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

On Tue, 2018-05-29 at 09:54 -0700, Dylan Baker wrote: > Quoting Adam Jackson (2018-05-29 06:50:46) > > GL_LIB expands to GLX_mesa, but applications should not link against > > that. -lGL is never wrong, just hardcode it. > > Actually There is this really stupid option i

Re: [Mesa-dev] drisw Xshm support

ion is now 4 instead of 3. > > I've also tested it works against an cirrus fbdev packed 24bpp X server. Thanks for dusting these off. Series is: Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org h

Re: [Mesa-dev] [PATCH] glx: Fix number of property values to read in glXImportContextEXT

rtContext (v2)" > Signed-off-by: Michel Dänzer Ugh. Truly embarrassing. Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] GitLab personal repos

On Sat, 2018-06-02 at 13:10 -0400, Rob Clark wrote: > On Sat, Jun 2, 2018 at 12:07 PM, Jason Ekstrand wrote: > > 1) Forks share objects behind the user's back so it should use > > significantly less space on the GitLab server if everyone's personal mesa > > repo is an actual GitLab fork and not a

Re: [Mesa-dev] GitLab migration update

On Thu, 2018-06-07 at 08:25 +0100, Daniel Stone wrote: > The following dormant repos were _not_ migrated, but can be migrated > (perhaps to an archive/ section?) if they are still useful: > clover glw libwsbm linux-agp-compat r600_demo rbug-gui Eek. glw has a bugfix in it from me I don't even r

Re: [Mesa-dev] [PATCH mesa] add project README

On Fri, 2018-06-08 at 16:57 +0100, Eric Engestrom wrote: > +Build & install > +--- > + > +You can find more information in our documentation (`docs/install.html > +`_), but the recommdended way is to use 'recommended' - ajax __

Re: [Mesa-dev] [PATCH] pkgconfig: Fix gl.pc when glvnd is enabled

On Fri, 2018-06-15 at 11:23 -0600, Kyle Brenneman wrote: > The Khronos repository basically is a package for the headers. The > challenge is that the pkg-config file has to specify an include path and > a library path. The include path depends on where you put the header > files (which are in t

[Mesa-dev] [PATCH] glx/dri: Take an extra reference on our own GLX drawables

path than I can type quickly, let alone test promptly against a wide enough range of servers and DRIs to have any confidence in. I'll work on the real solution, but in the meantime this is effectively not a memory leak for any real scenario, and fixes a real bug. Signed-off-by: Adam Jackson Cc

Re: [Mesa-dev] [RFC] Fix attempt for Mesa + X-Server 1.20 + modesetting-ddx hangs on KDE5.

On Fri, 2018-05-04 at 15:45 +0200, Mario Kleiner wrote: > The real problem, if i understand it correctly, is the way the life-time > of dri3_drawables and loader_dri3_drawables is managed atm. by Mesa's > bindContext() functions. Whenever glXMakeCurrent() etc. are called to > assign new/different

Re: [Mesa-dev] [PATCH 2/2] loader_dri3: Variant 2: Wait for pending swaps to complete before drawable_fini.

On Tue, 2018-05-08 at 11:42 +0200, Michel Dänzer wrote: > Idle notify events shouldn't need special treatment, since the pixmap > XIDs of the buffers will be different between loader_dri3_drawable > incarnations, aren't they? We're destroying loader_dri3_drawable structs at MakeCurrent time, but

Re: [Mesa-dev] [PATCH] glx/dri: Take an extra reference on our own GLX drawables

On Wed, 2018-05-09 at 18:17 +0200, Michel Dänzer wrote: > On 2018-05-08 09:47 PM, Adam Jackson wrote: > > dri*_bind_context, when switching current drawables, will drop the > > reference on the old one; since that refcount has probably now gone to > > zero that means we

Re: [Mesa-dev] Lets talk about autotools

On Tue, 2018-09-18 at 13:50 -0700, Dylan Baker wrote: > > It would be nice if meson would act like autotools in that regard by > > creating the drivers and libraries in specific directories (also as a > > configure option if there is concern about compilation speed). > > This is impossible by de

Re: [Mesa-dev] [PATCH] docs: Update FAQ with respect to s3tc support

h. > +Prior to 2nd October 2017, the Mesa project did not include s3tc support due > +to intellectual property (IP) and/or patent issues around the s3tc algorithm. > ... phrase it positively here, as in: "Oh, but it is! Prior to..." With that: Reviewed-by: Adam Jackson - a

[Mesa-dev] [PATCH] meson: Add some presets for s390 and ppc

yet. radv should in principle Just Work on ppc64le, but that's true of aarch64 too, and we're not building radv by default there yet either. Signed-off-by: Adam Jackson --- meson.build | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/m

Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}

ink the client side ever saw the light of day. At any rate the empty stubs can't possibly be helping anything. Series is: Reviewed-by: Adam Jackson - ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] dri2: Sync i965_pci_ids.h from Mesa.

On Wed, 2018-03-07 at 07:46 -0800, Rodrigo Vivi wrote: > Copied from Mesa with no modifications. > > Gives us Geminilake and Kaby Lake platform names updates and > sync on Coffee Lake PCI IDs. > > Cc: Timo Aaltonen > Signed-off-by: Rodrigo Vivi Merged, thanks: remote: I: patch #208689 updated

<    1   2   3   4   5   >