inishes the
ShmPutImage, that we'd see an inconsistent screen state for a moment.
So I think this wants an XSync after XShmPutImage (which dings windowed
fps by ~50 but doesn't seem to bother fullscreen at all).
With those two things fixed, the
Without this this extension basically can't work in indirect contexts,
TexImage2D will compute the image size as 0 and we'll send no image data
to the server.
v2: Add EXT_texture_integer to the client extension list too (Ian)
Signed-off-by: Adam Jackson
---
src/glx/compsize.c
'~' [-Wparentheses]
if (!trans & fbs)
It happens to be harmless; if fbs is ever non-zero, it will be VEC_210,
which is 5, so (!trans & 5) == 1 and the branch works as expected. But
logical AND is clearly what was meant.
Signed-off-by: Adam Jackson
---
src/gallium/drivers/
I'm having some difficulty getting llvmpipe working on a Skylake
Pentium, which has the charming property of not having AVX support at
all (Skylake Cores have AVX2, and Xeons have AVX512, but Pentium seems
to be the new way of spelling Celeron). Currently I'm trying this with
llvm 3.6.2 and Mesa 1
On Mon, 2015-10-12 at 21:57 +0200, Roland Scheidegger wrote:
> Note that the vector width doesn't really control if avx is used or not,
> since that's a decision which llvm does on its own (we do set it
> manually if we detect avx on our own, but llvm will use avx anyway even
> if we don't if it t
On Mon, 2015-10-12 at 22:55 +0200, Roland Scheidegger wrote:
> I don't know that looks like a generic string you're getting back.
> x86-64 IIRC implies sse2 in llvm, but not the other sseX flags (and if
> we detected sse41 we're going to use intrinsics for these, which then
> may not be available
a001 and a011 are pineview chips. Say so.
Signed-off-by: Adam Jackson
---
include/pci_ids/i915_pci_ids.h| 4 ++--
src/mesa/drivers/dri/i915/intel_chipset.h | 14 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/pci_ids/i915_pci_ids.h b/include
Starting from:
> commit 320d1191c61a0a82444605c12e5c4b2ee0b241eb
> Author: Jose Fonseca
> Date: Mon Apr 4 00:05:33 2016 +0100
>
> gallivm: Use llvm.fmuladd.*.
>
> Reviewed-by: Roland Scheidegger
'make check' in xserver no longer passes on Xephyr+glamor+llvmpipe. At
least, not on
On Thu, 2017-02-23 at 21:59 +0100, Roland Scheidegger wrote:
> So, what does the failing test do?
Not much, curiously. There are five that fail and they're all fairly
trivial, although the xts harness makes that hard to see.
XClearArea/6 and XClearWindow/4 set the window background pixmap to
Non
: Adam Jackson
---
src/glx/glxext.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glx/glxext.c b/src/glx/glxext.c
index fdc24d4..dc87fb9 100644
--- a/src/glx/glxext.c
+++ b/src/glx/glxext.c
@@ -138,6 +138,9 @@ __glXWireToEvent(Display *dpy, XEvent *event, xEvent *wire)
if (!glxDraw
On Tue, 2015-08-04 at 19:38 -0700, Eric Anholt wrote:
> In the Pbuffer path, we get serial from awire. Why's this one
> different?
Because I copied it from the dri2 path not the pbuffer path. This idiom
is more correct, _XSetLastRequestRead is how you notify xlib of the
advance in serials so it
On Tue, 2016-09-13 at 16:54 +0100, Emil Velikov wrote:
> Going through table 13.2 and the below there are some discrepancies.
>
> AFAICT some of those can be seen as spec bugs (B), while others seem
> to be missing (M)
> - thread - eglBindAPI (M)
Not really missing, but tricky. _EGL_FUNC_START c
On Tue, 2016-09-13 at 17:17 +0100, Emil Velikov wrote:
> > + } else {
> > + _eglDebugReportFull(EGL_BAD_ALLOC, __func__, __func__,
> > + EGL_DEBUG_MSG_CRITICAL_KHR, NULL, NULL);
> > + return EGL_BAD_ALLOC;
> > + }
>
> Nit: Please use the same style as the "
From: Kyle Brenneman
This decorates every EGL entrypoint with _EGL_FUNC_START, which records
the function name and primary dispatch object label in the current
thread state. It also adds debug report functions and calls them when
appropriate.
This would be useful enough for debugging on its own,
From: Kyle Brenneman
Wire up the debug entrypoints to EGL dispatch, and add the extension
string to the client extension list.
v2:
- Lots of style fixes
- Fix missing EGLAPIENTRYs
- Factor out valid attribute check
- Lock display in eglLabelObjectKHR as needed, and use RETURN_EGL_*
- Move "EGL_K
From: Kyle Brenneman
v2:
- Pass disp to RETURN_EGL_ERROR so we unlock the display
---
src/egl/main/eglapi.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index a74e5e4..ba4826a 100644
--- a/src/egl/main/eglap
On Tue, 2016-09-13 at 17:22 +0100, Emil Velikov wrote:
> Actually, current code has a bunch of such bugs which this series addresses.
> Considering there's only a couple of those and they are pretty hard to
> hit I won't bother with respinning the patches.
>
> That is unless we want them for stab
On Tue, 2016-09-13 at 19:18 +0100, Emil Velikov wrote:
> For the series as a whole ?
> Two words which contradict any software's stable scheme - new feature.
Disagree, but I'm not the one running Mesa's stable branch, so my
opinion doesn't count here.
- ajax
_
On Tue, 2016-09-13 at 14:14 -0600, Kyle Brenneman wrote:
> On 09/13/2016 11:57 AM, Adam Jackson wrote:
> > @@ -37,7 +39,7 @@
> >
> > /* This should be kept in sync with _eglInitThreadInfo() */
> > #define _EGL_THREAD_INFO_INITIALIZER \
> > - { EGL_S
On Wed, 2016-09-14 at 11:15 +0100, Emil Velikov wrote:
> Nice one... I wonder if your view will be the same if you were never
> involved in distribution packaging? Guess we'll never know :-\
> In case you've forgotten things have been like that for a long time -
> long before I jumped in.
I wasn'
From: Kyle Brenneman
This decorates every EGL entrypoint with _EGL_FUNC_START, which records
the function name and primary dispatch object label in the current
thread state. It also adds debug report functions and calls them when
appropriate.
This would be useful enough for debugging on its own,
On Wed, 2016-09-14 at 12:08 +0100, Emil Velikov wrote:
> Thanks for reminding me - eglQueryAPI should never throw an error,
> indeed. Since EGL_KHR_debug is applicable for functions_do_ throw an
> error, one should leave the API out of the spec text shouldn't they ?
I mean, sure, but this patch i
On Wed, 2016-09-14 at 14:29 +0100, Emil Velikov wrote:
> It's surprising that you haven't heard about this, considering it's
> been in use for more than three years. Guess you simply forgot ?
Most of my own patches to Mesa have been so far from being "features"
that I've never had to care.
- aja
On Tue, 2016-09-13 at 17:30 +0100, Emil Velikov wrote:
> Everything else (1-12 incl.) is
> Reviewed-by: Emil Velikov
Merged these, thanks.
- ajax
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/m
Signed-off-by: Adam Jackson
---
src/glx/glxglvnd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c
index 098304d..2fc9b00 100644
--- a/src/glx/glxglvnd.c
+++ b/src/glx/glxglvnd.c
@@ -50,6 +50,9 @@ static void __glXGLVNDSetDispatchIndex(const GLubyte
On Mon, 2016-09-05 at 11:23 +0100, Eric Engestrom wrote:
> > +static int
> > +compare(const void *l, const void *r)
> > +{
> > +const char *s = *(const char **)r;
>
> Shouldn't we do the same with `l`?
No. 'l' is the key we're looking for (the function name), r is the
current element of the a
As this array was not actually sorted, FindGLXFunction's binary search
would only sometimes work.
Signed-off-by: Adam Jackson
---
src/glx/g_glxglvnddispatchfuncs.c | 254 ++--
src/glx/g_glxglvnddispatchindices.h | 36 ++---
2 files changed, 144 inser
Signed-off-by: Adam Jackson
---
src/glx/glxglvnd.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c
index 2fc9b00..b6b4151 100644
--- a/src/glx/glxglvnd.c
+++ b/src/glx/glxglvnd.c
@@ -1,11 +1,11
This extension is a prerequisite for EGL 1.5, but the Intel drivers don't
report support for it, and I'm not really sure why, the driver code certainly
looks prepared for it. That said, I haven't tested either of these patches, and
I'm not aware of any apps using the feature (certainly nothing in p
Signed-off-by: Adam Jackson
---
src/mesa/drivers/dri/i965/intel_screen.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
b/src/mesa/drivers/dri/i965/intel_screen.c
index 82d4203..63b02530 100644
--- a/src/mesa/drivers/dri/i965/intel_screen.c
+++ b
Signed-off-by: Adam Jackson
---
src/mesa/drivers/dri/i915/intel_screen.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i915/intel_screen.c
b/src/mesa/drivers/dri/i915/intel_screen.c
index 19f7a6a..a78e250 100644
--- a/src/mesa/drivers/dri/i915/intel_screen.c
+++ b
On Fri, 2016-09-16 at 18:33 +0100, Emil Velikov wrote:
> But regardless, this and v2 14/14 look a lot better and are
>
> Reviewed-by: Emil Velikov
Merged, thanks.
- ajax
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedeskto
Signed-off-by: Adam Jackson
---
REVIEWERS | 4
1 file changed, 4 insertions(+)
diff --git a/REVIEWERS b/REVIEWERS
index f7574b3..f822421 100644
--- a/REVIEWERS
+++ b/REVIEWERS
@@ -104,3 +104,7 @@ F: src/egl/drivers/dri2/platform_wayland.c
FREEDRENO
R: Rob Clark
F: src/gallium
l your X
> > requests have been processed, so that any GL batchbuffer flushes happen
> > after that.
>
> Quoting Adam Jackson:
>
> This is a bit incorrect. For direct contexts, DRI2's WaitX becomes
> DRI2CopyRegion from real-front to fake-front. That _does_ generate a
>
On Wed, 2016-08-17 at 08:17 -0700, Eric Anholt wrote:
> All I'm saying is that it's the thing that was intentionally used for
> this purpose in DRI1 and early DRI2, and maybe if it works we shouldn't
> just accidentally drop it in a refactor.
I don't see how the patch in this thread does that. I
On Wed, 2016-08-17 at 17:50 +0100, Chris Wilson wrote:
> On Wed, Aug 17, 2016 at 12:13:23PM -0400, Adam Jackson wrote:
> >
> > On Wed, 2016-08-17 at 08:17 -0700, Eric Anholt wrote:
> >
> > >
> > > All I'm saying is that it's the thing that was
On Thu, 2016-09-01 at 10:36 +0100, Emil Velikov wrote:
> > From: Emil Velikov
>
> Currently, due to the inverse order, strcmp will produce negative result
> when the needle is towards the start of the haystack. Thus on the next
> iteration(s) we'll end up further towards the end and eventually fa
The dynamic dispatch table needs to be sorted properly, the entrypoints
shouldn't duplicate the 'glX' prefix, and please just use bsearch()
instead of open-coding it.
Signed-off-by: Adam Jackson
---
src/glx/g_glxglvnddispatchfuncs.c | 254 ++
On Wed, 2016-07-06 at 10:33 -0600, Kyle Brenneman wrote:
> @@ -292,6 +292,24 @@ _eglError(EGLint errCode, const char *msg)
> return EGL_FALSE;
> }
>
> +EGLBoolean
> +_eglError(EGLint errCode, const char *msg)
> +{
> + if (errCode != EGL_SUCCESS) {
> + EGLint type;
> + if (errCod
no longer
checks for a conflicting context. In addition, calling eglMakeCurrent
with EGL_NO_CONTEXT will now release the current context regardless of
the current API.
v2: Rebased against master (Adam Jackson)
Reviewed-by: Adam Jackson
---
src/egl/main/eglapi.c | 42
On Wed, 2016-09-07 at 11:15 -0400, Adam Jackson wrote:
> From: Kyle Brenneman
>
> Only keep track of a single current context, instead of separate
> contexts for GL and GLES.
In addition to fixing 1.4+ compliance, this fixes the "eglterminate
then unbind context" p
On Wed, 2016-09-07 at 22:07 +0100, Emil Velikov wrote:
> Was going to mention this but it slipped through. Can we get a proper
> spec quote in the code ?
I guess the logic through eglCreateContext (the only place where the
API difference matters) is a little contorted, certainly took me more
than
Signed-off-by: Adam Jackson
---
src/egl/main/eglcontext.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c
index ebc004d..057b60f 100644
--- a/src/egl/main/eglcontext.c
+++ b/src/egl/main/eglcontext.c
@@ -457,6 +457,16
This rebases Kyle's series atop master (the change to treat GL and GLES
identically created some merge conflicts), and ports a fix from glvnd's
handling of DebugMessageControl.
I'm working on piglits to cover this, and a very basic first test is on the
list now. As glvnd's EGL interface essentiall
From: Kyle Brenneman
Updated eglext.h to revision 32074 from the Khronos repository.
Added two #includes to egltypedefs.h. Both were in the previous version
of eglext.h but not in the new one.
Reviewed-by: Adam Jackson
---
include/EGL/eglext.h | 36
command name and object label parameters from
_eglDebugReport, and made it look them up from the current
_EGLThreadInfo.
Added a separate _eglDebugReportFull function to allow the caller to
specify the command and label.
Reviewed-by: Adam Jackson
---
src/egl/main/eglapi.c | 183
From: Kyle Brenneman
Added a label to the _EGLThreadInfo, _EGLDisplay, and EGLResource
structs. Implemented the function eglLabelObjectKHR.
Reviewed-by: Adam Jackson
---
src/egl/main/eglapi.c | 63 +++
src/egl/main/eglcurrent.c | 9 +++
src
is to replace existing calls to _eglError with
_eglDebugReport.
Reviewed-by: Adam Jackson
---
src/egl/main/eglapi.c | 64 +++
src/egl/main/eglcurrent.c | 37 +--
src/egl/main/eglcurrent.h | 15 +++
src/egl/main
EGL_KHR_debug, since
the callback will be missing object labels and messages in most cases.
Later changes can update the _eglError calls to provide more info.
Reviewed-by: Adam Jackson
---
src/egl/main/eglapi.c | 142 --
src/egl/main/eglcurrent.c | 35
the wrong function name to the EGL_KHR_debug
callback.
[ajax: Fixed up eglWaitClient]
Reviewed-by: Adam Jackson
---
src/egl/main/eglapi.c | 214 +-
1 file changed, 125 insertions(+), 89 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main
Treat a null attribute list as meaning "don't change attributes". This
is semantically equivalent to a list consisting of just EGL_NONE.
Signed-off-by: Adam Jackson
---
src/egl/main/eglapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/main/eglapi.c
On Thu, 2016-09-08 at 11:57 -0600, Kyle Brenneman wrote:
> This one has the a bug in it where it doesn't set the callback if
> (attrib_list == NULL), plus the more minor bug where it doesn't check
> for invalid attributes if (callback == NULL). The first one is the same
> bug you noticed in libg
e KHR behaviour.
Signed-off-by: Adam Jackson
---
src/egl/main/eglcontext.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c
index 58740c3..7eac79a 100644
--- a/src/egl/main/eglcontext.c
+++ b/src/egl/main/eglcont
KHR_no_config_context is virtually identical to MESA_configless_context,
where they differ is only where the Mesa spec is silent, and for the
most part the code already did what the Khronos spec wants. Fix up the
one corner case, and mark the Mesa extension as superseded.
- ajax
_
Keep the old name in the extension string, but refer to the KHR
extension internally.
Signed-off-by: Adam Jackson
---
src/egl/drivers/dri2/egl_dri2.c | 2 +-
src/egl/main/eglapi.c | 6 --
src/egl/main/eglcontext.c | 4 ++--
src/egl/main/egldisplay.h | 2 +-
4 files
Signed-off-by: Adam Jackson
---
docs/specs/MESA_configless_context.spec | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/docs/specs/MESA_configless_context.spec
b/docs/specs/MESA_configless_context.spec
index f2fafb3..d7ba62d 100644
--- a/docs/specs
On Fri, 2016-09-09 at 11:27 +0100, Emil Velikov wrote:
> > On 8 September 2016 at 18:46, Adam Jackson wrote:
> > From: Kyle Brenneman
>
> Added a label to the _EGLThreadInfo, _EGLDisplay, and EGLResource
> structs. Implemented the function eglLabelObjectKHR.
>
>
>
This gets us to basically the same end state as before, but I've
rearranged the sequence of changes to be a little easier to review and
not introduce broken intermediate states.
01 updates eglext.h to the very latest. 02 is a bugfix for leaking images
and syncs at eglTerminate, pointed out in revi
From: Kyle Brenneman
This decorates every EGL entrypoint with _EGL_FUNC_START, which records
the function name and primary dispatch object label in the current
thread state. It also adds debug report functions and calls them when
appropriate.
This would be useful enough for debugging on its own,
From: Kyle Brenneman
---
src/egl/main/eglapi.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index fac2d18..a74e5e4 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -1081,8 +1081,8 @@ eglCopyBuffers(
From: Kyle Brenneman
---
src/egl/main/eglapi.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index ba8305e..df355a5 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -295,9 +295,9 @@ eglGetDis
Signed-off-by: Adam Jackson
---
src/egl/main/egldisplay.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/src/egl/main/egldisplay.c b/src/egl/main/egldisplay.c
index bbc3063..3d4eb81 100644
--- a/src/egl/main/egldisplay.c
+++ b/src/egl/main/egldisplay.c
@@ -44,6 +44,8
From: Kyle Brenneman
---
src/egl/main/eglapi.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index 658d0d7..dc61d5f 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -1384,11 +1384,10 @@ eglDestroy
From: Kyle Brenneman
---
src/egl/main/eglglobals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/egl/main/eglglobals.c b/src/egl/main/eglglobals.c
index 938d953..04bb5ba 100644
--- a/src/egl/main/eglglobals.c
+++ b/src/egl/main/eglglobals.c
@@ -50,7 +50,7 @@ struct _egl
From: Kyle Brenneman
This moves the native window fixup to a helper function so we don't
repeat ourselves.
---
src/egl/main/eglapi.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index df355a5..dd2
From: Kyle Brenneman
---
src/egl/main/eglapi.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index dc61d5f..c285c20 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -1509,11 +1509,9 @@ eglCli
From: Kyle Brenneman
---
src/egl/main/eglapi.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index c285c20..0477ad9 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -1570,11 +1570,9 @@ eglSig
From: Kyle Brenneman
---
src/egl/main/eglcurrent.c | 3 +--
src/egl/main/eglcurrent.h | 8
src/egl/main/egldisplay.h | 4
src/egl/main/eglglobals.c | 5 -
src/egl/main/eglglobals.h | 10 ++
5 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/src/egl/main
From: Kyle Brenneman
This moves the native pixmap fixup to a helper function so we don't
repeat ourselves.
---
src/egl/main/eglapi.c | 36 +---
1 file changed, 21 insertions(+), 15 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index dd2b
From: Kyle Brenneman
Updated eglext.h to revision 33111 from the Khronos repository.
v2:
- Don't (re)move extension includes from eglext.h (Emil Velikov)
- Bump to revision 33111 (Adam Jackson)
Reviewed-by: Adam Jackson
---
include/EGL/eglext.h
From: Kyle Brenneman
Wire up the debug entrypoints to EGL dispatch, and add the extension
string to the client extension list.
---
src/egl/main/eglapi.c | 140 ++
src/egl/main/eglglobals.c | 3 +-
2 files changed, 142 insertions(+), 1 deletion(-)
From: Kyle Brenneman
---
src/egl/main/eglapi.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index a74e5e4..658d0d7 100644
--- a/src/egl/main/eglapi.c
+++ b/src/egl/main/eglapi.c
@@ -1309,11 +1309,10 @@ eglRele
On Fri, 2016-10-14 at 10:48 -0700, Chad Versace wrote:
> Some people privately asked why we need to create this EGL platform.
> I want to respond publicly.
>
> Mesa *already* *has* this EGL platform. In my view, the issue at hand
> isn't whether to create or to not create the platform. It's whethe
On Fri, 2016-09-16 at 19:07 +0100, Emil Velikov wrote:
> On 14 September 2016 at 19:06, Adam Jackson wrote:
> > As this array was not actually sorted, FindGLXFunction's binary search
> > would only sometimes work.
> >
>
> This commit message is a bit
On Fri, 2016-10-28 at 17:11 +0100, Emil Velikov wrote:
> > On 19 October 2016 at 18:39, Adam Jackson wrote:
> > The "implementation" in Mesa would be __glXBindTexImageEXT. One could
> > argue that dispatch_* could be smart enough to recognize their own
> > dispa
On Sat, 2016-10-22 at 11:00 +0100, Chris Wilson wrote:
> @@ -113,6 +113,11 @@ loader_dri3_drawable_fini(struct loader_dri3_drawable
> *draw)
> dri3_free_render_buffer(draw, draw->buffers[i]);
> }
>
> + if (draw->sync_fence) {
> + xcb_sync_destroy_fence(draw->conn, draw->syn
i/i965/intel_screen.c| 5 ++--
> src/mesa/drivers/dri/i965/intel_tex_image.c | 5 ++--
> 8 files changed, 71 insertions(+), 38 deletions(-)
Hm, adding myself to REVIEWERS for src/glx/ doesn't seem to have done
much. Also I'd still really like to see a server-side call chain for
WaitX/Wa
On Mon, 2016-10-31 at 20:28 +, Emil Velikov wrote:
> >
> > One user, xdriinfo(1), which is admittedly pretty useless. But the
> > glvnd code in mesa definitely implements dispatch for it (libglvnd
> > itself does not, but is not expected to).
>
> libglvnd doesn't dispatch to it one cannot rea
On Tue, 2016-11-01 at 20:48 +, Chris Wilson wrote:
> The fence_fd is closed by xcb_dri3_fence_from_fd() as
> xcb_send_request_with_fds() always calls close().
> -Chris
D'oh! You are correct. Objection withdrawn.
- ajax
___
mesa-dev mailing list
mes
On Thu, 2016-11-03 at 16:21 +, Emil Velikov wrote:
> I'm not a fan of keeping legacy stuff with only one (pretty useless)
> user. Not to mention that the glXGetDriverConfig plumbing is missing
> [in here]. But as you feel so strongly in keeping it ...
Maybe I wasn't clear. I don't care at all
On Thu, 2016-11-03 at 17:28 +, Emil Velikov wrote:
> Your earlier reply did not have ack/nack on the topic of dropping it,
> thus the above reads as a justification why one would wants to keep
> it.
I thought "useless" expressed my opinion of the value of the feature
quite well. But I didn't
On Fri, 2015-07-24 at 16:20 +0200, Jonny Lamb wrote:
> This adds a new vfunc to _EGLDriver, QueryDeviceName, which should
> return a const string of the device name (usually in the format
> '/dev/dri/cardN').
>
> The EGLDevice could perhaps be cached in the EGLDisplay but there
> usually aren't lo
On Thu, 2016-07-21 at 16:18 +0100, Daniel Stone wrote:
> On 21 July 2016 at 15:11, Emil Velikov wrote:
> > I'd suggest opting for the drmDevice libdrm API. It can provide a list
> > of devices with all the nodes and other misc info. Thus we could use
> > the render/card/other node as any point as
Signed-off-by: Adam Jackson
---
src/glx/indirect_glx.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c
index f8944a7..d0457fe 100644
--- a/src/glx/indirect_glx.c
+++ b/src/glx/indirect_glx.c
@@ -59,8 +59,9
not fix piglit/glx-create-context-current-no-framebuffer, but
is a prerequisite for fixing it.
Signed-off-by: Adam Jackson
---
src/glx/glxcurrent.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/src/glx/glxcurrent.c b/src/glx/glxcurrent.c
index 3d8893c..a6884cf 100644
--- a
Signed-off-by: Adam Jackson
---
src/glx/indirect_glx.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c
index d0457fe..d27b019 100644
--- a/src/glx/indirect_glx.c
+++ b/src/glx/indirect_glx.c
@@ -132,6 +132,7
_XReply returns 1 on success, but indirect_bind_context returns 0 on
success.
Signed-off-by: Adam Jackson
---
src/glx/indirect_glx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c
index d27b019..28b8cd0 100644
--- a
On Fri, 2013-10-25 at 12:59 -0700, Ian Romanick wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70486
> Reviewed-and-tested-by: Ian Romanick
Pushed, thanks and sorry.
- ajax
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http
On Wed, 2013-02-27 at 14:02 +, Jon TURNEY wrote:
> Attached is a patch to fix.
Pushed, thanks.
- ajax
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
From: Adhemerval Zanella
This adds another rounding mode to the enum, which happens otherwise to
match SSE4.1's rounding modes. This should be safe as long as the
IROUND case never hits the SSE4.1 path.
Reviewed-by: Adam Jackson
Signed-off-by: Adhemerval Zanella
---
src/gallium/auxi
From: Adhemerval Zanella
Reviewed-by: Adam Jackson
Signed-off-by: Adhemerval Zanella
---
src/gallium/auxiliary/gallivm/lp_bld_printf.c | 56 +++
1 file changed, 39 insertions(+), 17 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_printf.c
b/src/gallium
On Mon, 2013-04-01 at 13:04 +1300, Chris Forbes wrote:
> @@ -38,6 +38,7 @@ struct cache_item
> {
> GLuint hash;
> void *key;
> + GLuint keysize;
> struct gl_program *program;
> struct cache_item *next;
> };
Since GLuint is 32 bits, this creates another hole in the struct on
LP
At least on llvm 3.2 this appears to work fine. Tested on an Athlon XP
2600+, which has sse and 3dnow but not sse2.
Signed-off-by: Adam Jackson
---
src/gallium/drivers/llvmpipe/lp_screen.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/llvmpipe
On Sat, 2014-04-12 at 02:25 +0200, Giovanni Campagna wrote:
> Hi everyone,
>
> Some time ago I sent patches to enable the swrast driver on
> GBM/DRM, and I did them in the dumbest way possible (that is,
> having GBM implement the dri-swrast interface), to make sure
> it would work without kernel s
I'm somewhat impressed that current gccs will let you do this, but
sufficiently old ones (including 4.4.7 in RHEL6) won't.
Signed-off-by: Adam Jackson
---
src/gallium/drivers/radeonsi/si_descriptors.c | 6 +++---
src/gallium/drivers/radeonsi/si_hw_context.c | 2 +-
src/gallium/driver
This is entirely pointless. The DRI driver does not need any symbols
from libGL, even if it did libGL would already be available to resolve
them because that's how dlopen works.
Signed-off-by: Adam Jackson
---
src/glx/dri_common.c | 8 +---
1 file changed, 1 insertion(+), 7 dele
On Thu, 2014-05-29 at 15:10 -0700, Ian Romanick wrote:
> That code was originally added by:
>
> commit 061a3fe34051327fba418cc99599ecff0016ee15
> Author: Michel Dänzer
> Date: Mon Aug 14 15:53:37 2006 +
>
> Bug #7169: Attempt to make libGL symbols visible to drivers.
>
> Some
On Thu, 2014-05-15 at 01:58 +0100, Emil Velikov wrote:
> On 05/05/14 17:07, Giovanni Campagna wrote:
> > This is my second attempt to bring swrast to the DRM EGL platform.
> > It includes both the legacy loader, which will work with any
> > swrast driver, and the new gallium winsys which works with
We don't support pre-2.6 kernels anyway - the install docs say 2.6.28
for DRI - and apparently this confuses ld.so's sorting when multiple
libGLs are installed. Just remove it.
Signed-off-by: Adam Jackson
---
src/mapi/entry_x86-64_tls.h | 13 -
src/mapi/entry
Signed-off-by: Adam Jackson
---
src/gallium/auxiliary/gallivm/lp_bld_arit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_arit.c
b/src/gallium/auxiliary/gallivm/lp_bld_arit.c
index ec05026..524a8e7 100644
--- a/src/gallium/auxiliary
1 - 100 of 448 matches
Mail list logo
