[Mesa-dev] [PATCH v2 2/5] Android: remove host libmesa_util

2017-03-21 Thread Rob Herring
The host libmesa_util is never used for Android builds, so remove it. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli --- v2: - no change src/util/Android.mk | 35 --- 1 file changed, 35 deletions(-) diff --git a/src/util/Android.mk b/src/util/Android.mk

[Mesa-dev] [PATCH v2 5/5] Android: drop Android 4.4 (KitKat) support

2017-03-21 Thread Rob Herring
Any users of KitKat are likely using an older version of Mesa and KitKat support adds complexity to the make files. Dropping support allows removing the MESA_LOLLIPOP_BUILD make variable in various make files. Signed-off-by: Rob Herring Reviewed-by: Tapani Pälli --- v2: - keep

Re: [Mesa-dev] [PATCH v2 2/5] intel: Move tools/decoder.[ch] to common/gen_decoder.[ch].

2017-03-22 Thread Rob Herring
On Wed, Mar 22, 2017 at 6:50 AM, Emil Velikov wrote: > n 21 March 2017 at 20:58, Kenneth Graunke wrote: >> On Tuesday, March 21, 2017 4:40:26 AM PDT Emil Velikov wrote: >>> On 21 March 2017 at 11:14, Emil Velikov wrote: >>> > On 20 March 2017 at 22:04, Kenneth Graunke wrote: >>> >> This way the

Re: [Mesa-dev] [android-x86-devel] [PATCH] android: fix gallium_dri.so can't be loaded by drm_gralloc

2017-08-18 Thread Rob Herring
> against libLLVM. > This leads to duplicate symbols and run/build (please correct me) time. > > Fix that by consistently dropping the libLLVMCore + llvm-headers bits > and consistently using a shared libLLVM link. > " > >> Signed-off-by: Qiang Yu >> Signed-off-b

[Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-18 Thread Rob Herring
ework LLVM build support") Reported-by: Mauro Rossi Cc: Emil Velikov Cc: 17.2 Signed-off-by: Qiang Yu Signed-off-by: Rob Herring --- Android.mk | 12 src/amd/Android.common.mk | 4 +--- src/gallium/drivers/radeon/Android.mk | 2

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-20 Thread Rob Herring
On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang wrote: > 2017-08-19 8:27 GMT+08:00 Emil Velikov : >> On 18 August 2017 at 20:46, Rob Herring wrote: >>> Both statically linking libLLVMCore and dynamically linking libLLVM causes >>> duplicated symbols in gallium_dri.so

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-21 Thread Rob Herring
On Fri, Aug 18, 2017 at 7:27 PM, Emil Velikov wrote: > On 18 August 2017 at 20:46, Rob Herring wrote: >> Both statically linking libLLVMCore and dynamically linking libLLVM causes >> duplicated symbols in gallium_dri.so and it fails to dlopen. We don't >> really nee

Re: [Mesa-dev] [PATCH v2] From: Emil Velikov

2017-08-21 Thread Rob Herring
On Mon, Aug 21, 2017 at 9:08 AM, Emil Velikov wrote: > As said in the EGL_KHR_platform_android extensions > > For each EGLConfig that belongs to the Android platform, the > EGL_NATIVE_VISUAL_ID attribute is an Android window format, such as > WINDOW_FORMAT_RGBA_. > > Although it sh

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-21 Thread Rob Herring
On Mon, Aug 21, 2017 at 12:47 PM, Emil Velikov wrote: > On 21 August 2017 at 17:17, Rob Herring wrote: >> On Fri, Aug 18, 2017 at 7:27 PM, Emil Velikov >> wrote: >>> On 18 August 2017 at 20:46, Rob Herring wrote: >>>> Both statically linking libLLVMCore an

[Mesa-dev] [PATCH] Android: gallium_dri: pass dri.sym to linker

2017-08-21 Thread Rob Herring
n error on __driDriverExtensions without the option. Suggested-by: Emil Velikov Signed-off-by: Rob Herring --- src/gallium/targets/dri/Android.mk | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/targets/dri/Android.mk b/src/gallium/targets/dri/Android.mk index 150b2e368e51..313930b76274 100644

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-21 Thread Rob Herring
On Mon, Aug 21, 2017 at 4:44 PM, Mauro Rossi wrote: > 2017-08-18 21:46 GMT+02:00 Rob Herring : >> Both statically linking libLLVMCore and dynamically linking libLLVM causes >> duplicated symbols in gallium_dri.so and it fails to dlopen. We don't >> really need to link

[Mesa-dev] [PATCH v2] Android: gallium_dri: pass dri.sym to linker

2017-08-22 Thread Rob Herring
ystem sets --no-undefined-version by default and we get an error on driver specific symbols if those drivers are disabled without the option. Suggested-by: Emil Velikov Reviewed-by: Emil Velikov Signed-off-by: Rob Herring --- Android.common.mk | 1 + src/gallium/targets/dri/Andr

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-23 Thread Rob Herring
On Sun, Aug 20, 2017 at 2:57 PM, Rob Herring wrote: > On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang > wrote: >> 2017-08-19 8:27 GMT+08:00 Emil Velikov : >>> On 18 August 2017 at 20:46, Rob Herring wrote: >>>> Both statically linking libLLVMCore and d

[Mesa-dev] [PATCH 1/2] Android: fix Android O version check for LLVM

2017-08-23 Thread Rob Herring
With the release of O, the MESA_ANDROID_MAJOR_VERSION has changed to 8. Change the LLVM check to match. There's no point to continue to support 'O' as no one is going to use an old AOSP master. Presumably, we'll be back here again to fix things again for P (or 9). Signed

[Mesa-dev] [PATCH 2/2] Android: EGL: fix missing nativewindow.h include on O

2017-08-23 Thread Rob Herring
The build against AOSP master and O is broken: external/mesa3d/include/EGL/eglplatform.h:100:10: fatal error: 'android/native_window.h' file not found native_window.h has moved and is now part of libnativewindow library, so add this dependency. Signed-off-by: Rob Herring --

Re: [Mesa-dev] [PATCH] Android: Fix LLVM duplicated symbols linking for N and M

2017-08-23 Thread Rob Herring
On Wed, Aug 23, 2017 at 12:31 PM, Emil Velikov wrote: > On 23 August 2017 at 17:50, Rob Herring wrote: >> On Sun, Aug 20, 2017 at 2:57 PM, Rob Herring wrote: >>> On Fri, Aug 18, 2017 at 8:53 PM, Chih-Wei Huang >>> wrote: >>>> 2017-08-19 8:27 GMT+08:00 Em

Re: [Mesa-dev] [PATCH mesa] khronos/egl: remove dependency on Android NDK header

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 7:49 AM, Eric Engestrom wrote: > Khronos: https://github.com/KhronosGroup/EGL-Registry/pull/22 > Cc: Rob Herring > Cc: Emil Velikov > Signed-off-by: Eric Engestrom > --- > include/EGL/eglplatform.h | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [Mesa-dev] [PATCH 2/2] Android: EGL: fix missing nativewindow.h include on O

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 4:08 AM, Chih-Wei Huang wrote: > 2017-08-24 1:25 GMT+08:00 Rob Herring : >> The build against AOSP master and O is broken: >> >> external/mesa3d/include/EGL/eglplatform.h:100:10: fatal error: >> 'android/native_window.h' file not foun

Re: [Mesa-dev] [PATCH mesa] egl/android: add missing include

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 9:22 AM, Eric Engestrom wrote: > Cc: Rob Herring > Signed-off-by: Eric Engestrom > --- > This needs to land before [1], otherwise the latter will break android. > > [1] https://lists.freedesktop.org/archives/mesa-dev/2017-August/167428.html > &g

Re: [Mesa-dev] [PATCH mesa] egl/android: add missing include

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 9:26 AM, Rob Herring wrote: > On Thu, Aug 24, 2017 at 9:22 AM, Eric Engestrom > wrote: >> Cc: Rob Herring >> Signed-off-by: Eric Engestrom >> --- >> This needs to land before [1], otherwise the latter will break android. >> >>

Re: [Mesa-dev] [PATCH mesa] egl/android: add missing include

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 10:09 AM, Tapani Pälli wrote: > > > On 08/24/2017 06:02 PM, Rob Herring wrote: >> >> On Thu, Aug 24, 2017 at 9:26 AM, Rob Herring wrote: >>> >>> On Thu, Aug 24, 2017 at 9:22 AM, Eric Engestrom >>> wrote: >>>&

Re: [Mesa-dev] [PATCH mesa] egl/android: add missing include

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 10:08 AM, Eric Engestrom wrote: > On Thursday, 2017-08-24 10:02:29 -0500, Rob Herring wrote: >> On Thu, Aug 24, 2017 at 9:26 AM, Rob Herring wrote: >> > On Thu, Aug 24, 2017 at 9:22 AM, Eric Engestrom >> > wrote: >> >> Cc: Rob Herri

Re: [Mesa-dev] [PATCH 4/6] ac/debug: annotate IB dumps with the raw values

2017-08-24 Thread Rob Herring
On Tue, Aug 22, 2017 at 10:45 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/amd/common/ac_debug.c | 84 > +-- > 1 file changed, 66 insertions(+), 18 deletions(-) > > diff --git a/src/amd/common/ac_debug.c b/src/amd/common/ac_debug.c >

Re: [Mesa-dev] [PATCH 4/6] ac/debug: annotate IB dumps with the raw values

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 4:24 PM, Rob Herring wrote: > On Tue, Aug 22, 2017 at 10:45 AM, Nicolai Hähnle wrote: >> From: Nicolai Hähnle >> >> --- >> src/amd/common/ac_debug.c | 84 >> +-- >> 1 file changed, 66 in

Re: [Mesa-dev] [PATCH] ac/debug: use util_strchrnul() to fix android build error

2017-08-24 Thread Rob Herring
On Thu, Aug 24, 2017 at 4:52 PM, Mauro Rossi wrote: > Similar to e09d04cd56 "radeonsi: use util_strchrnul() to fix android build > error" > > Android Bionic does not support strchrnul() string function, > gallium auxiliary util/u_string.h provides util_strchrnul() > > This change avoids the follo

Re: [Mesa-dev] [PATCH mesa] util: improve compiler guard

2017-08-31 Thread Rob Herring
t; Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102454 > Cc: Laurent Carlier > Cc: Emil Velikov > Cc: Rob Herring > Signed-off-by: Eric Engestrom > --- > > Rob, any idea if android needs locale-setting? Emil suggested it might > always use "C" anyway. Looking

Re: [Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

2017-09-05 Thread Rob Herring
On Tue, Sep 5, 2017 at 9:23 AM, Emil Velikov wrote: > From: Emil Velikov > > Former is non-deterministic and compilers throw a warning about it. > > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > I think the patch is a good idea, although kind of split about

Re: [Mesa-dev] [PATCH 12/23] intel: Add simple logging façade for Android

2017-09-05 Thread Rob Herring
On Sat, Sep 2, 2017 at 3:17 AM, Chad Versace wrote: > I'm bringing up Vulkan in the Android container of Chrome OS (ARC++). > > On Android, stdio goes to /dev/null. On Android, remote gdb is even more > painful than the usual remote gdb. On Android, nothing works like you > expect and debugging is

Re: [Mesa-dev] [PATCH] Android: fix radeonsi building errors on Android O

2017-09-06 Thread Rob Herring
On Tue, Sep 5, 2017 at 4:16 AM, Chih-Wei Huang wrote: > The radeonsi driver fails in the error: > > [ 5% 200/3583] target C++: libmesa_amd_common_32 <= > external/mesa/src/amd/common/ac_llvm_helper.cpp > In file included from external/mesa/src/amd/common/ac_llvm_helper.cpp:35: > In file include

[Mesa-dev] [PATCH] Android: Add LLVM support for Android P

2017-09-07 Thread Rob Herring
The Android version in AOSP master has changed now to P, so we need to add LLVM flags for it. Duplicating the lines because I expect the version will get bumped at some point and diverge from O. Cc: Chih-Wei Huang Signed-off-by: Rob Herring --- Android.mk | 2 ++ 1 file changed, 2 insertions

Re: [Mesa-dev] [PATCH] Android: fix undeclared identifier 'gfx9d_reg_table'

2017-09-11 Thread Rob Herring
On Sat, Sep 9, 2017 at 12:17 PM, Chih-Wei Huang wrote: > Since commit 552aaa11 the compiler complains: > > external/mesa/src/amd/common/ac_debug.c:124:51: error: use of undeclared > identifier 'gfx9d_reg_table'; did you mean 'sid_reg_table'? > reg = find_register(gfx9d_reg_table,

Re: [Mesa-dev] [PATCH v2 02/12] tgsi/ureg: always emit constants (and their decls) as 2D

2017-09-12 Thread Rob Herring
On Mon, Aug 28, 2017 at 3:58 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Acked-by: Roland Scheidegger > Tested-by: Dieter Nützel > --- > src/gallium/auxiliary/tgsi/tgsi_ureg.c | 22 +++--- > 1 file changed, 7 insertions(+), 15 deletions(-) I bisected to this commit b

Re: [Mesa-dev] [PATCH] virgl: drop const dimensions on first block.

2017-09-13 Thread Rob Herring
Dave Airlie > --- > src/gallium/drivers/virgl/virgl_tgsi.c | 26 ++ > 1 file changed, 26 insertions(+) Tested-by: Rob Herring ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] anv: android build system changes

2017-09-14 Thread Rob Herring
On Thu, Sep 14, 2017 at 1:57 AM, Tapani Pälli wrote: > Following changes are made to support VK_ANDROID_native_buffer: > >- bring in vk_android_native_buffer.xml >- rename target as vulkan.$(TARGET_BOARD_PLATFORM) >- use LOCAL_PROPRIETARY_MODULE to install under vendor path Good to se

Re: [Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

2018-07-18 Thread Rob Herring
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote: > > This series implements kms_swrast support for the Android > platform. And since having to debug a null pointer dereference, > simplify that process for the next guy. So is this working for you now? > As it stands now, any kernel must have th

Re: [Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

2018-07-19 Thread Rob Herring
On Thu, Jul 19, 2018 at 9:52 AM Robert Foss wrote: > > Hey Rob, > > On 2018-07-19 09:26, Tomasz Figa wrote: > > On Thu, Jul 19, 2018 at 12:08 AM Robert Foss > > wrote: > >> > >> Hey Rob, > >> > >> On 2018-07-18 15:30, Rob Herr

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-25 Thread Rob Herring
On Tue, Jul 24, 2018 at 5:21 PM John Stultz wrote: > > From: Yong Yao > > This is a forward port of a patch from the AOSP/master branch: > https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51c7ae3a033b100a8429ae5415%5E%21/ > > Which allows boards to provide their own custo

Re: [Mesa-dev] [RFC][PATCH 4/5] Android.mk: Add option to use vendor version of mesa

2018-07-26 Thread Rob Herring
On Wed, Jul 25, 2018 at 1:52 PM John Stultz wrote: > > On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov > wrote: > > On 25 July 2018 at 00:21, John Stultz wrote: > >> From: Yong Yao > >> > >> This is a forward port of a patch from the AOSP/master branch: > >> https://android.googlesource.com/plat

Re: [Mesa-dev] [PATCH 2/3 v2] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-26 Thread Rob Herring
E%21/ > > Since https://android-review.googlesource.com/c/718518 added > timespec_get() to bionic, mesa3d doesn't build due to redefinition > of timespec_get(). > > Avoid redefinition by defining HAVE_TIMESPEC_GET flag. > > Test: build and boot tested db820c to UI. > &

Re: [Mesa-dev] [PATCH 2/3 v2] Android.common.mk: define HAVE_TIMESPEC_GET

2018-07-27 Thread Rob Herring
Since https://android-review.googlesource.com/c/718518 added > timespec_get() to bionic, mesa3d doesn't build due to redefinition > of timespec_get(). > > Avoid redefinition by defining HAVE_TIMESPEC_GET flag. > > Test: build and boot tested db820c to UI. > > Cc: Rob Herring > Cc: Alis

Re: [Mesa-dev] vulkan.radv build trouble w/ AOSP

2018-08-02 Thread Rob Herring
On Thu, Aug 2, 2018 at 12:47 AM Mauro Rossi wrote: > > Hi, > > Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz > ha scritto: >> >> Just as a heads up, with mesa3d master (plus my other build fixups I >> just sent out), I'm seeing a new build failure when building under >> AOSP/master: >> >>

Re: [Mesa-dev] [PATCH 2/3 v3] Android.common.mk: define HAVE_TIMESPEC_GET

2018-08-02 Thread Rob Herring
flag. > > > > Test: build and boot tested db820c to UI. > > > > Change-Id: I3dcc8034b48785e45cd3fa50e4d9cf2c684694a0 > > Cc: Rob Herring > > Cc: Alistair Strachan > > Cc: Marissa Wall > > Cc: Sumit Semwal > > Cc: Emil Velikov >

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-27 Thread Rob Herring
On Mon, Apr 25, 2016 at 7:53 PM, Eric Anholt wrote: > Rob Herring writes: > >> On Fri, Apr 22, 2016 at 9:08 PM, Rob Herring wrote: >>> On Fri, Apr 22, 2016 at 6:32 PM, Emil Velikov >>> wrote: >>>> Hi Rob, >>>> >>>> On 22 Apri

Re: [Mesa-dev] [PATCH 12/13] i965/fs_surface_builder: Add a helper for converting GL to ISL formats

2016-04-27 Thread Rob Herring
On Sat, Apr 16, 2016 at 2:45 PM, Jason Ekstrand wrote: > --- > .../drivers/dri/i965/brw_fs_surface_builder.cpp| 55 > ++ > 1 file changed, 55 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp > b/src/mesa/drivers/dri/i965/brw_fs_surface_

Re: [Mesa-dev] [PATCH 4/4] gbm: Add map/unmap functions

2016-04-27 Thread Rob Herring
On Wed, Apr 27, 2016 at 5:01 PM, Emil Velikov wrote: > On 27 April 2016 at 19:51, Eric Anholt wrote: >> Rob Herring writes: >> >>> On Mon, Apr 25, 2016 at 7:53 PM, Eric Anholt wrote: >>>> Rob Herring writes: >>>> >>>>> On Fri, Apr

Re: [Mesa-dev] [PATCH 1/4] gbm: Add Android build support

2016-04-28 Thread Rob Herring
On Fri, Apr 22, 2016 at 5:57 PM, Emil Velikov wrote: > Hi Rob, > > On 22 April 2016 at 16:50, Rob Herring wrote: > >> --- /dev/null >> +++ b/src/gbm/Android.mk > >> +LOCAL_EXPORT_C_INCLUDE_DIRS := \ >> + $(LOCAL_PATH)/main >> +

Re: [Mesa-dev] [android-x86-devel] [RFC 0/7] android: enable llvmpipe for software rendering

2016-04-28 Thread Rob Herring
On Thu, Apr 28, 2016 at 9:22 AM, Emil Velikov wrote: > Hi Chih-Wei, > > Thanks for getting these out to the community. > > On 28 April 2016 at 08:34, Chih-Wei Huang wrote: >> This is a series of patches developed by Jide Technolody to enable >> the llvmpipe for software rendering of Android. >> I

Re: [Mesa-dev] [android-x86-devel] [RFC 0/7] android: enable llvmpipe for software rendering

2016-04-28 Thread Rob Herring
On Thu, Apr 28, 2016 at 12:35 PM, Roland Scheidegger wrote: > Am 28.04.2016 um 17:52 schrieb Chih-Wei Huang: >> I clearly understand this point. >> Actually I've spent several days to try to >> make it work on the master branch. >> That's why it was delayed -- I supposed to send them >> in the las

[Mesa-dev] [PATCH] Android: fix build ordering of subdirectories

2016-04-28 Thread Rob Herring
doing "include $(call all-named-subdir-makefiles,...)" twice, so rework things by generating the included makefile list and including them in 2 steps. Signed-off-by: Rob Herring --- Android.mk | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Android.mk b/Android.m

Re: [Mesa-dev] [android-x86-devel] [RFC 0/7] android: enable llvmpipe for software rendering

2016-04-28 Thread Rob Herring
On Thu, Apr 28, 2016 at 1:57 PM, Jose Fonseca wrote: > On 28/04/16 19:50, Rob Herring wrote: >> >> On Thu, Apr 28, 2016 at 12:35 PM, Roland Scheidegger >> wrote: >>> >>> Am 28.04.2016 um 17:52 schrieb Chih-Wei Huang: >>>> >>>> I

[Mesa-dev] [PATCH v2 0/4] Android EGL dma-buf support

2016-04-28 Thread Rob Herring
t out refactoring patches - Copied wayland EGL handling of dri2 loader with render nodes making image loader to be mutually exclusive - factored out back buffer handling code to separate function Rob [1] https://github.com/robherring/mesa.git android-dma-buf-testing Rob Herring (4): egl: an

[Mesa-dev] [PATCH v2 2/4] egl: android: factor out format conversion code to a function

2016-04-28 Thread Rob Herring
Signed-off-by: Rob Herring --- src/egl/drivers/dri2/platform_android.c | 38 + 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c index 02122e3..204931b 100644 --- a

[Mesa-dev] [PATCH v2 3/4] egl: android: factor out back buffer handling code

2016-04-28 Thread Rob Herring
In preparation to use the same code for dma-bufs, factor out the code to a separate function. Signed-off-by: Rob Herring --- src/egl/drivers/dri2/platform_android.c | 36 + 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/src/egl/drivers/dri2

[Mesa-dev] [PATCH v2 4/4] egl: android: add dma-buf fd support

2016-04-28 Thread Rob Herring
tting. Using dma-bufs vs. GEM handles is now a runtime decision similar to the wayland EGL instead of being compile time selection. The dma-buf support is also re-written to use common dri2_create_image_dma_buf function in egl_dri2.c. Cc: Varad Gautam Cc: Rob Clark Cc: Emil Velikov Signed-off-by

[Mesa-dev] [PATCH v2 1/4] egl: android: disable __DRI_DRI2_LOADER support on render nodes

2016-04-28 Thread Rob Herring
Use of __DRI_DRI2_LOADER extension is only supported for card nodes. In order to support dmabufs, Android will be moving to using render nodes and we need to disable the DRI2 loader extension. This is based on the Wayland EGL code. Cc: Rob Clark Cc: Emil Velikov Signed-off-by: Rob Herring

Re: [Mesa-dev] [PATCH v2 2/4] egl: android: factor out format conversion code to a function

2016-04-29 Thread Rob Herring
On Fri, Apr 29, 2016 at 6:24 AM, Emil Velikov wrote: > On 28 April 2016 at 21:37, Rob Herring wrote: >> Signed-off-by: Rob Herring >> --- >> src/egl/drivers/dri2/platform_android.c | 38 >> + >> 1 file changed, 15 insertions(+),

Re: [Mesa-dev] [android-x86-devel] [RFC 7/7] android: support swrast

2016-04-29 Thread Rob Herring
On Thu, Apr 28, 2016 at 2:35 AM, Chih-Wei Huang wrote: > From: WuZhen > > System boots up with gles_mesa/softpipe/llvmpipe. > > NO_REF_TASK > tested: local run > > Change-Id: I629ed0ca9fad12e32270eb8e8bfa9f7681b68474 > Signed-off-by: Chih-Wei Huang > --- > Android.mk

Re: [Mesa-dev] [PATCH 3/3] egl: android: remove explicit glFlush call

2016-05-02 Thread Rob Herring
On Sun, May 1, 2016 at 6:42 AM, Emil Velikov wrote: > The DRI flush extension should already do the same thing. > > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > NOTE: Untested, although based on my humble understanding of things it > should be fine. Seems to

Re: [Mesa-dev] [PATCH 2/4] DRI: Add DRIimage map and unmap functions

2016-05-03 Thread Rob Herring
On Mon, Apr 25, 2016 at 7:42 AM, Daniel Stone wrote: > Hi, > > On 22 April 2016 at 19:12, Eric Anholt wrote: >> I think this needs a longer comment to explain what the interface does: >> >> "Returns a map of the specified region of a __DRIimage for the specified >> usage. >> >> flags must always

[Mesa-dev] [PATCH v2 1/9] Android: Move setting DEFAULT_DRIVER_DIR to shared location

2016-05-03 Thread Rob Herring
Move the defining of DEFAULT_DRIVER_DIR path to a common location so both EGL and GBM can use it. Signed-off-by: Rob Herring --- v2: - new patch Android.common.mk | 7 +++ src/egl/Android.mk | 7 --- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Android.common.mk b

[Mesa-dev] [PATCH v2 0/9] GBM map/unmap support

2016-05-03 Thread Rob Herring
78908/ Rob Herring (9): Android: Move setting DEFAULT_DRIVER_DIR to shared location gbm: split out source file to Makefile.sources gbm: add Android gallium_dri.so library loading support gbm: Add Android build support DRI: Add DRIimage map and unmap functions st/dri: Add support for DRI

[Mesa-dev] [PATCH v2 7/9] gbm: rename gbm_dri_bo_{map, unmap} to gbm_dri_bo_{map, unmap}_dumb

2016-05-03 Thread Rob Herring
In preparation to add public map/unmap functions, rename the existing gbm_dri_bo_{map,unmap} functions to indicate that they are only for dumb buffers. Signed-off-by: Rob Herring --- v2: - moved into new patch src/gbm/backends/dri/gbm_dri.c| 4 ++-- src/gbm/backends/dri/gbm_driint.h | 4

[Mesa-dev] [PATCH v2 6/9] st/dri: Add support for DRIimage extension mapImage/unmapImage

2016-05-03 Thread Rob Herring
Implement support for mapImage/unmapImage functions in version 12 of the DRIimage extension. Signed-off-by: Rob Herring --- v2: - Make READ flag optional src/gallium/state_trackers/dri/dri2.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH v2 2/9] gbm: split out source file to Makefile.sources

2016-05-03 Thread Rob Herring
In preparation to add Android build support, split out the source file lists to Makefile.sources Signed-off-by: Rob Herring --- v2: - fix missing Makefile.sources include - remove spurious whitespace change src/gbm/Makefile.am | 12 src/gbm/Makefile.sources | 12

[Mesa-dev] [PATCH v2 3/9] gbm: add Android gallium_dri.so library loading support

2016-05-03 Thread Rob Herring
GBM needs the same special gallium_dri.so loading as EGL for Android, so copy over the same hunk from the EGL code. Signed-off-by: Rob Herring --- v2: - new patch, moved from Android build support src/gbm/backends/dri/gbm_dri.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src

[Mesa-dev] [PATCH v2 5/9] DRI: Add DRIimage map and unmap functions

2016-05-03 Thread Rob Herring
: Rob Herring --- v2: - expand mapImage comments include/GL/internal/dri_interface.h | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/include/GL/internal/dri_interface.h b/include/GL/internal/dri_interface.h index b38f87f..ed4e018 100644 --- a

[Mesa-dev] [PATCH v2 4/9] gbm: Add Android build support

2016-05-03 Thread Rob Herring
In order to use libgbm for gralloc, add it to the Android build. Signed-off-by: Rob Herring --- v2: - move out gallium lib loading changes Android.mk | 1 + src/gbm/Android.mk | 44 2 files changed, 45 insertions(+) create mode 100644 src

[Mesa-dev] [PATCH v2 8/9] configure.ac: add pthreadstubs support

2016-05-03 Thread Rob Herring
Add pthreadstubs to avoid pulling in full pthreads library. GBM will be the first user. Signed-off-by: Rob Herring --- v2: - new patch configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 023110e..f854f6a 100644 --- a/configure.ac +++ b

[Mesa-dev] [PATCH v2 9/9] gbm: Add map/unmap functions

2016-05-03 Thread Rob Herring
gallium transfer_map() function. This was tested with GBM based gralloc on Android. This still creates a context, but I've moved it into gbm_create_device rather than in the map function. This should remove any need for reference counting and problems with memory leaks. Signed-off-by: Rob He

Re: [Mesa-dev] [android-x86-devel] [PATCH] isl: add support for Android libisl static

2016-05-10 Thread Rob Herring
On Tue, May 10, 2016 at 6:56 PM, Mauro Rossi wrote: > This patch adds support for libisl static, needed to build i965. > > Android.genxml.gen.mk generates the necessary gen%_pack.h headers > > Android.gen.mk generates isl_format_layout.c [...] > diff --git a/src/intel/isl/Makefile.sources b/src/

Re: [Mesa-dev] [PATCH 1/3] egl: android: directly use dri2_create_image_dma_buf()

2016-05-14 Thread Rob Herring
On Sun, May 1, 2016 at 6:42 AM, Emil Velikov wrote: > Make the function non static so that we can use it directly from the > android platform code. > > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/egl_dri2.c | 2 +- > src/egl

Re: [Mesa-dev] [PATCH 2/3] egl: android: drop dri2_create_image_android_native_buffer argument

2016-05-14 Thread Rob Herring
On Sun, May 1, 2016 at 6:42 AM, Emil Velikov wrote: > The drv is no longer used/needed as of last commit. > > Cc: Rob Herring > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/platform_android.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH 03/39] llvmpipe: Fix overflow for 32 bits available memory computation

2016-05-16 Thread Rob Herring
On Sun, May 15, 2016 at 5:45 AM, Axel Davy wrote: > And cap to 2 GB on 32 bits. > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=94561 > > Signed-off-by: Axel Davy > --- > src/gallium/auxiliary/os/os_misc.c | 2 +- > src/gallium/drivers/llvmpipe/lp_screen.c | 5 + > 2 files chang

[Mesa-dev] vc4 Android build broken

2016-05-16 Thread Rob Herring
Eric, The commit d36b28402f542 ("vc4: Reuse QPU disasm's cond flags in QIR.") breaks on Android builds (using clang) with this error: external/mesa3d/src/gallium/drivers/vc4/vc4_qpu_disasm.c:349:33: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]

[Mesa-dev] [PATCH v3 7/9] gbm: rename gbm_dri_bo_{map, unmap} to gbm_dri_bo_{map, unmap}_dumb

2016-05-16 Thread Rob Herring
In preparation to add public map/unmap functions, rename the existing gbm_dri_bo_{map,unmap} functions to indicate that they are only for dumb buffers. Signed-off-by: Rob Herring --- v3: - Add missing rename in platform_drm.c src/egl/drivers/dri2/platform_drm.c | 8 src/gbm/backends

Re: [Mesa-dev] [PATCH 03/39] llvmpipe: Fix overflow for 32 bits available memory computation

2016-05-17 Thread Rob Herring
On Tue, May 17, 2016 at 11:35 AM, Axel Davy wrote: > On 16/05/2016 23:28, Rob Herring wrote: >> >> On Sun, May 15, 2016 at 5:45 AM, Axel Davy wrote: >>> >>> And cap to 2 GB on 32 bits. >>> >>> Fixes https://bugs.freedesktop.org/sho

[Mesa-dev] [PATCH] include/GL: fix the interop header for a --disable-glx build

2016-05-17 Thread Rob Herring
Including glx.h brings in X11 headers. Avoid the include of glx.h and just forward declare the necessary symbols. Signed-off-by: Rob Herring --- I haven't seen any progress and this and builds are still broken. Here's a fix as Emil suggested. Rob include/GL/mesa_glinterop.h | 5 +++

Re: [Mesa-dev] [android-x86-devel] [PATCH] android: fix building error in libmesa_st_mesa

2016-05-17 Thread Rob Herring
l_to_nir.o' > failed > make: *** > [out/target/product/x86/obj/STATIC_LIBRARIES/libmesa_st_mesa_intermediates/state_tracker/st_glsl_to_nir.o] > Error 1 > make: *** Waiting for unfinished jobs > --- > src/mesa/Android.libmesa_st_mesa.mk | 2 ++ > 1 file changed,

[Mesa-dev] CI job for Android builds

2016-05-17 Thread Rob Herring
I'm in the process of setting up a CI job to track Android builds of mesa master (ATM merging in a branch of commits needed to build which are not yet upstream). It is mostly working now though I'm still tweaking the setup a bit. It is built on AOSP master branch as well. Build errors/warnings are

Re: [Mesa-dev] CI job for Android builds

2016-05-17 Thread Rob Herring
On Tue, May 17, 2016 at 5:21 PM, Rob Clark wrote: > On Tue, May 17, 2016 at 6:14 PM, Jose Fonseca wrote: >> On 17/05/16 22:43, Rob Clark wrote: >>> >>> On Tue, May 17, 2016 at 5:13 PM, Rob Herring >>> wrote: >>>> >>>> I'm

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

2016-05-20 Thread Rob Herring
On Mon, May 9, 2016 at 6:38 AM, Marek Olšák wrote: > From: Marek Olšák > > This allows drivers to use their own fast path for texture uploads. > --- > src/mesa/state_tracker/st_cb_texture.c | 43 > ++ > 1 file changed, 39 insertions(+), 4 deletions(-) > > diff --

Re: [Mesa-dev] [PATCH] st/mesa: use transfer_inline_write for memcpy TexSubImage path

2016-05-20 Thread Rob Herring
On Fri, May 20, 2016 at 10:42 AM, Ilia Mirkin wrote: > On Fri, May 20, 2016 at 11:39 AM, Rob Herring wrote: >> On Mon, May 9, 2016 at 6:38 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This allows drivers to use their own fast path for te

[Mesa-dev] [PATCH] virgl: Add missing texture transfer_inline_write

2016-05-20 Thread Rob Herring
Cc: Dave Airlie Signed-off-by: Rob Herring --- src/gallium/drivers/virgl/virgl_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/virgl/virgl_texture.c b/src/gallium/drivers/virgl/virgl_texture.c index f395f1f..34db056 100644 --- a/src/galliu

Re: [Mesa-dev] [PATCH] mesa: Build EGL without X11 headers after interop patchset

2016-05-23 Thread Rob Herring
On Sun, May 22, 2016 at 2:28 PM, Mark Janes wrote: > Tom Stellard writes: > >> On Fri, May 20, 2016 at 04:29:07PM -0700, Mark Janes wrote: >>> Tom Stellard writes: >>> >>> > On Wed, Apr 27, 2016 at 10:33:14PM +, Youry Metlitsky wrote: >>> >> --- >>> >> include/GL/mesa_glinterop.h | 15 +

Re: [Mesa-dev] [RFC PATCH] GBM: Add map/unmap functions

2016-05-23 Thread Rob Herring
On Mon, May 23, 2016 at 7:12 PM, Emil Velikov wrote: > On 23 May 2016 at 22:19, Rob Clark wrote: >> On Mon, May 23, 2016 at 5:16 PM, Mark Janes wrote: >>> I run a buildtest in our CI to help Intel engineers avoid breaking the >>> builds for other Mesa targets. >>> >>> With this commit, it produc

Re: [Mesa-dev] [PATCH] c11/threads: resolve link issues with -O0

2016-05-24 Thread Rob Herring
ead/unreachable code. > > Ideally we'll enable the optimisations locally, yet that does not seem > to work atm. > > Cc: Alejandro Piñeiro > Cc: Ben Widawsky > Cc: Ilia Mirkin > Cc: Mark Janes > Cc: Rob Clark > Cc: Rob Herring > Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH] c11/threads: resolve link issues with -O0

2016-05-24 Thread Rob Herring
On Tue, May 24, 2016 at 8:09 AM, Ilia Mirkin wrote: > On Tue, May 24, 2016 at 9:06 AM, Rob Herring wrote: >> On Tue, May 24, 2016 at 4:57 AM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> Add weak symbol notation for the pthread_mutexattr*

Re: [Mesa-dev] [PATCH] c11/threads: resolve link issues with -O0

2016-05-24 Thread Rob Herring
On Tue, May 24, 2016 at 8:40 AM, Rob Clark wrote: > On Tue, May 24, 2016 at 9:17 AM, Ilia Mirkin wrote: >> On Tue, May 24, 2016 at 9:15 AM, Rob Herring wrote: >>> On Tue, May 24, 2016 at 8:09 AM, Ilia Mirkin wrote: >>>> On Tue, May 24, 2016 at 9:06 AM, Rob Herrin

Re: [Mesa-dev] [PATCH 2/2 v2] nir: mako all the intrinsics

2018-03-28 Thread Rob Herring
On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote: > I threatened to do this a long time ago.. I probably *should* have done > it a long time ago when there where many fewer intrinsics. But the > system of macro/#include magic for dealing with intrinsics is a bit > annoying, and python has the nic

Re: [Mesa-dev] [PATCH 2/2 v2] nir: mako all the intrinsics

2018-03-28 Thread Rob Herring
On Wed, Mar 28, 2018 at 10:18 AM, Rob Clark wrote: > On Wed, Mar 28, 2018 at 10:43 AM, Rob Herring wrote: >> On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote: >>> I threatened to do this a long time ago.. I probably *should* have done >>> it a long time ago

Re: [Mesa-dev] [PATCH 2/2 v2] nir: mako all the intrinsics

2018-03-28 Thread Rob Herring
On Wed, Mar 28, 2018 at 12:24 PM, Mark Janes wrote: > Rob Herring writes: > >> On Wed, Mar 28, 2018 at 10:18 AM, Rob Clark wrote: >>> On Wed, Mar 28, 2018 at 10:43 AM, Rob Herring wrote: >>>> On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote: >>>>

Re: [Mesa-dev] [PATCH 2/2] gallium/util: Android backtrace support

2018-04-13 Thread Rob Herring
liary/Android.mk | 3 +- > .../auxiliary/util/u_debug_stack_android.cpp | 111 > + > src/gallium/targets/dri/Android.mk | 1 + > 3 files changed, 114 insertions(+), 1 deletion(-) > create mode 100644 src/gallium/auxiliary/u

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-03 Thread Rob Herring
ussion. Feel free to propose alternives to this solution. > > [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/drm_gem.c?h=v5.2-rc7#n318 > [2]https://cgit.freedesktop.org/drm/drm-misc/commit/drivers/gpu/drm/panfrost?id=583bbf46133c726bae277e8f4e32bfba2a52

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-03 Thread Rob Herring
On Wed, Jul 3, 2019 at 8:13 AM Steven Price wrote: > > On 03/07/2019 14:56, Boris Brezillon wrote: > > On Wed, 3 Jul 2019 07:45:32 -0600 > > Rob Herring wrote: > > > >> On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon > >> wrote: > >>> > &

Re: [Mesa-dev] [PATCH v2 2/5] panfrost: Allocate shaders in their own BOs

2019-08-07 Thread Rob Herring
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso wrote: > > Instead of all shaders being stored in a single BO, have each shader in > its own. > > This removes the need for a 16MB allocation per context, and allows us > to place transient blend shaders in BOs marked as executable (before > they were al

Re: [Mesa-dev] [PATCH v2 5/5] panfrost: Print errors from kernel

2019-08-07 Thread Rob Herring
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso wrote: > > Signed-off-by: Tomeu Vizoso > Reviewed-by: Alyssa Rosenzweig > --- > src/gallium/drivers/panfrost/pan_drm.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/gallium/drivers/panfrost/pan_drm.c > b/src/

Re: [Mesa-dev] [PATCH v2 2/5] panfrost: Allocate shaders in their own BOs

2019-08-08 Thread Rob Herring
On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso wrote: > > On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote: > > > > On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso > > wrote: > > > > > > Instead of all shaders being stored in a single BO, have each shader in &

Re: [Mesa-dev] [PATCH v2 2/5] panfrost: Allocate shaders in their own BOs

2019-08-08 Thread Rob Herring
On Wed, Aug 7, 2019 at 5:47 PM Alyssa Rosenzweig wrote: > > > This is using the > > untranslated flags, but I think it should be the 'translated_flags' as > > those are the ones changing the allocation. > > It's a little more complex than that. There some hypothetical > untranslated flags that I w

Re: [Mesa-dev] [PATCH v2 2/5] panfrost: Allocate shaders in their own BOs

2019-08-09 Thread Rob Herring
On Fri, Aug 9, 2019 at 3:31 AM Tomeu Vizoso wrote: > > On Thu, 8 Aug 2019 at 16:19, Rob Herring wrote: > > > > On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso > > wrote: > > > > > > On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote: > > > &g

Re: [Mesa-dev] [PATCH v2 3/5] panfrost: Mark BOs as NOEXEC

2019-08-09 Thread Rob Herring
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso wrote: > > Unless a BO has the EXECUTABLE flag, mark it as NOEXEC. > > v2: - Rework version detection (Alyssa). > > Signed-off-by: Tomeu Vizoso > --- > include/drm-uapi/panfrost_drm.h | 27 +++ Next time, I think this shou

<    1   2   3   4   5   6   7   >