>From OpenGL 4.0 spec, page 398:
"The initial internal format of a texel array is RGBA
instead of 1. TEXTURE_COMPONENTS is deprecated; always
use TEXTURE_INTERNAL_FORMAT."
Fixes Khronos OpenGL CTS test failure: proxy_textures_invalid_size
Cc:
Signed-off-by: Anuj Phogat
This patch makes no functional changes to the code.
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index 0519d22..1cd6ade 100644
--- a/src/mesa/main/teximage.c
ATION is generated if one of the base internal
format and format is DEPTH_COMPONENT or DEPTH_STENCIL, and the other
is neither of these values."
Fixes Khronos OpenGL CTS test failure: proxy_textures_invalid_size
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/teximage.c | 13
plelocations;
> + init_teximage_fields_ms(ctx, texImage, width, height, depth, 0,
> + internalformat, texFormat,
> + samples, fixedsamplelocations);
>
>if (width > 0 && height > 0 && depth > 0) {
>
______
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
) & 0xf);
> }
> }
>
> --
> 1.7.10.4
>
> _______
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
gt; --
> 1.7.10.4
>
> ___
> mesa-stable mailing list
> mesa-sta...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-stable
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
GLfloat coords2[4],
> + GLfloat coords3[4]);
> +
> struct temp_texture *
> _mesa_meta_get_temp_texture(struct gl_context *ctx);
>
> --
> 1.9.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
This Series is:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
nly on vertex shader input attributes in OpenGL (2.0 and
above) and OpenGL ES 2.0.
- It is explictly disallowed in OpenGL ES 3.0.
Fixes Khronos CTS failing test:
explicit_attrib_location_vertex_input_aliased.test
See more details about this at below mentioned khronos bug.
Signed-off-by: Anuj Pho
Signed-off-by: Anuj Phogat
---
src/glsl/linker.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index f6b2661..a619bc8 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -297,7 +297,7 @@ linker_warning(gl_shader_program
On Mon, Mar 10, 2014 at 3:27 PM, Ian Romanick wrote:
> On 03/10/2014 11:19 AM, Anuj Phogat wrote:
> > Currently overlapping locations of input variables are not allowed for
> all
> > the shader types in OpenGL and OpenGL ES.
> >
> >>From OpenGL ES 3.0 spec, page
does not have a
single format."
Fixes Khronos CTS test: packed_depth_stencil_parameters.test
Signed-off-by: Anuj Phogat
Cc:
Khronos Bug# 9170
Signed-off-by: Anuj Phogat
---
src/mesa/main/fbobject.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/mesa/main/fbobject
mesa currently returns 4 when GL_VERTEX_ATTRIB_ARRAY_SIZE is queried
for a vertex array initially set up with size=GL_BGRA. This patch
makes changes to return size=GL_BGRA as required by the spec.
Fixes Khronos OpenGL CTS test: vertex_array_bgra_basic.test
Signed-off-by: Anuj Phogat
Cc
n the
error INVALID_OPERATION occurs. If the type parameter is
not UNSIGNED_INT_24_8 or FLOAT_32_UNSIGNED_INT_24_8_REV,
then the error INVALID_ENUM occurs."
Fixes failing Khronos CTS test packed_depth_stencil_error.test
V2: Avoid code duplication
Cc:
Signed-off-by: Anuj Phogat
---
ing a new variable
Signed-off-by: Anuj Phogat
Cc:
---
src/mesa/main/varray.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c
index b4b6fa9..479d872 100644
--- a/src/mesa/main/varray.c
+++ b/src/mesa/main/varray.c
@@ -738,7 +73
On Tue, Mar 11, 2014 at 10:37 AM, Ian Romanick wrote:
> On 03/10/2014 04:15 PM, Anuj Phogat wrote:
> >
> >
> >
> > On Mon, Mar 10, 2014 at 3:27 PM, Ian Romanick > <mailto:i...@freedesktop.org>> wrote:
> >
> > On 03/10/2014 11:19 AM,
should not be used anymore.
> + * It's only present to satisfy linking with older versions of libGL.
> + */
> +unsigned long
> +_glthread_GetID(void)
> +{
> + return 0;
> +}
> +
> void
> _glapi_noop_enable_warnings(unsigned char enable)
> {
I hit this issue ear
rw_context *brw)
>}
>
>/* _NEW_COLOR */
> - if (ctx->Color.DitherFlag && !integer) {
> + if (ctx->Color.DitherFlag && !integer &&
> + rb_internal_format != GL_RGB10_A2) {
> blend[b].blend1.dither_enable = 1;
> blend[b]
Identified 2 bugs in patches 1/4 and 3/4. Will send out V4 of the series
with fixes.
On Fri, Feb 28, 2014 at 11:53 AM, Anuj Phogat wrote:
> GLSL 1.50 spec says:
>"If gl_FragCoord is redeclared in any fragment shader in a program,
> it must be redeclared in all the fragm
fragment shader 2:
in vec4 gl_FragCoord;
void foo()
{
...
}
Signed-off-by: Anuj Phogat
Cc:
---
src/glsl/ast_to_hir.cpp | 5 +++
src/glsl/glsl_parser_extras.cpp | 16 +
src/glsl/glsl_parser_extras.h | 1 +
src/glsl/linker.cpp
ord;
void main()
{
}
Signed-off-by: Anuj Phogat
Cc:
---
src/glsl/ast_to_hir.cpp | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index b241ccf..f3ff77a 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
m
that have a static use of gl_FragCoord. All redeclarations of
gl_FragCoord in all fragment shaders in a single program must have
the same set of qualifiers."
Signed-off-by: Anuj Phogat
Cc:
---
src/glsl/glsl_parser_extras.cpp | 2 ++
src/glsl/linker.cpp | 7 ++-
_FragCoord;
layout(origin_upper_left, pixel_center_integer) in vec4 gl_FragCoord;
V3: Simplify function is_conflicting_fragcoord_redeclaration()
V4: Check for null pointer before doing strcmp(var->name, "gl_FragCoord").
Signed-off-by: Anuj Phogat
Cc:
---
src/glsl/ast_
ckUnorm4x8", _unpackUnorm4x8(shader_packing),
> NULL);
> - add_function("unpackSnorm4x8", _unpackSnorm4x8(shader_packing),
> NULL);
> + add_function("unpackUnorm4x8",
> _unpackUnorm4x8(shade
num_samples, _mesa_get_format_name(dst_mt->format), dst_mt,
> dst_level, dst_layer, dst_x0, dst_y0, dst_x1, dst_y1,
> mirror_x, mirror_y);
>
> --
> 1.9.0
>
> ___
> mesa-dev mailing list
(invalid texture
> size)");
> + return;
> + }
> +
> /* If the new texture's target is TEXTURE_CUBE_MAP or
> * TEXTURE_CUBE_MAP_ARRAY, the width and height of the original texture's
> * levels must be equal otherwise the error INVALID_OPERATI
Object->Target != GL_TEXTURE_2D)
> --
> 1.9.0
>
> _______
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
This patch makes non-functional changes in the code. New helper
function added here will make it easier to support more data
types in the following patches.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/format_unpack.c | 24
src/mesa/main/format_unpack.h | 5
This patch contains non-functional changes. Assertion checks made
earlier in the functions make the if checks redundant. So, remove
the if checks and unindent the code in if block.
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstore.c | 170 ++-
1
Fixes a crash in Khronos CTS packed_pixels tests.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_pixel_read.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/intel_pixel_read.c
b/src/mesa/drivers/dri/i965/intel_pixel_read.c
index
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/mtypes.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index a0d893c..0b754b1 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -3535,6 +3535,7 @@ struct gl_extensions
_mesa_texstore_z24_s8() and _mesa_texstore_z32f_x24s8() are capable of
handling GL_DEPTH_STENCIL format. So, allow it in both the functions.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstore.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main
Depth-stencil teture targets are allowed to use source data of type
GL_UNSIGNED_INT_24_8_EXT and GL_FLOAT_32_UNSIGNED_INT_24_8_REV.
Fixes few crashes in Khronos OpenGL CTS packed_pixels tests.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texstore.c | 8 ++--
1 file changed, 6
>From OpenGL 4.0 spec, page 306:
"Calling GetTexImage with a format of STENCIL_INDEX
causes the error INVALID_ENUM."
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/texgetimage.c b/
Fixes a crash in Khronos OpenGL CTS packed_pixels tests.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 7129d4c..733985b 100644
--- a/src/mesa
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/format_unpack.c | 79 ++-
src/mesa/main/format_unpack.h | 5 +++
2 files changed, 83 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
index 7abbe46
"
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 488b678..2bf0fb4 100644
--- a/src/mesa/main/texgetimage.c
+++ b/src/mesa/main/tex
here location exceeds the maximum allowed attribute
location.
Signed-off-by: Anuj Phogat
Cc: "9.2 10.0 10.1"
Bugzilla: Khronos #9609
---
src/glsl/linker.cpp | 91 -
1 file changed, 76 insertions(+), 15 deletions(-)
diff --git a/src/gls
Sent out a V2 of this patch which fixes a bug I noticed recently.
On Thu, Mar 13, 2014 at 3:39 PM, Anuj Phogat wrote:
>
>
>
> On Tue, Mar 11, 2014 at 10:37 AM, Ian Romanick wrote:
>>
>> On 03/10/2014 04:15 PM, Anuj Phogat wrote:
>> >
>> >
>> >
On Tue, Mar 25, 2014 at 11:41 AM, Ian Romanick wrote:
> On 03/21/2014 03:01 PM, Anuj Phogat wrote:
>> Cc:
>
> Why is this tagged for stable?
[Patch 2 / 10] is a bug fix tagged for stable and it requires this change.
>
>> Signed-off-by: Anuj Phogat
>> ---
>>
This function will be used in the following patch.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/formats.c | 9 +
src/mesa/main/formats.h | 3 +++
2 files changed, 12 insertions(+)
diff --git a/src/mesa/main/formats.c b/src/mesa/main/formats.c
index fb2501c..5c67011 100644
--- a
"
V2: Use helper function _mesa_is_format_integer()
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 488b678..2747540 100644
--- a/src
V2: Follow the new naming convention for unpack functions.
Use double precision for converting Z24 to a float.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/format_unpack.c | 86 ++-
src/mesa/main/format_unpack.h | 5 +++
2 files changed, 90
"
V2: Use helper function _mesa_is_format_integer()
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/texgetimage.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 488b678..754c365 100644
--- a/src/mesa/main/texgetima
V2: Follow the new naming convention for unpack functions.
Use double precision for converting Z24 to a float.
V3: Unpack stencil value to most significant byte.
Use 'struct z32f_x24s8' type.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/format_unp
il packing.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/main/format_unpack.c | 83 ++-
src/mesa/main/format_unpack.h | 5 +++
2 files changed, 87 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/format_unpack.c b/src/mesa/main/format_unpack.c
ind
On Thu, Mar 27, 2014 at 1:29 AM, Samuel Iglesias Gonsalvez
wrote:
> Commit 079bdba05f870807d3ed77fa3093cdb7727aa2fd enabled the use of BLORP
> engine for single sample scaled blit with bilinear filter.
>
> However piglit fails when running fbo-blit-stretch test on SandyBridge.
> This patch makes t
NG, "No EGL platform enabled.");
>return EGL_FALSE;
> }
> }
> --
> 2.0.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Review
"GL_", $4, 3) == 0)
> glcpp_error(& @1, parser, "Built-in (pre-defined)"
> " macro names can not be undefined.");
>
> --
> 2.1.3
>
> _______
> mesa-dev mailing list
> mesa-dev@lis
4
> --- a/src/mesa/main/texobj.h
> +++ b/src/mesa/main/texobj.h
> @@ -38,6 +38,11 @@
> #include "samplerobj.h"
>
>
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +
> /**
> * \name Internal functions
> */
> @@
Keep the subject of commit message short (under 50 chars) and use present tense.
Here you can use "mesa: Add utility function _mesa_lookup_texture_error()".
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> Most ARB_DIRECT_STATE_ACCESS functions take an object's ID and use it to look
> up
How about using below subject?
i965: intel_get_tex_image() now accepts TEXTURE_CUBE_MAP as a valid target
It's more specific than using a file name. I'll leave it up to you if
you want to make this change.
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> ARB_DIRECT_STATE_ACCESS permits t
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 36 +++
> src/mesa/main/teximage.c | 343
> +++--
> src/mesa/main/teximage.h | 30 +++
> 3 files changed, 333 insertio
Your adsa-textures branch on fdo fails make check.
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> This implements all of the texture functions for ARB_direct_state_access,
> with the exception of glTextureBufferRange. There is an outstanding bug on
> the specification for glTextureBu
On Tue, Dec 16, 2014 at 7:46 AM, Brian Paul wrote:
> On 12/15/2014 06:22 PM, Laura Ekstrand wrote:
>>
>> The following preparations were made in texstate.c and texstate.h to
>> better facilitate the BindTextureUnit function:
>>
>> Dylan Noblesmith:
>> mesa: add _mesa_get_tex_unit()
>> mesa: factor
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> Beginning in the OpenGL 4.3 core specification, some error handling has
> changed. As an example, changing sampler states with a multisample target
> throws INVALID_ENUM rather than INVALID_OPERATION.
Patch also changes error handling for GL
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> This is a convenience function for *Texture*Parameter functions.
> ---
> src/mesa/main/texparam.c | 38 ++
> 1 file changed, 38 insertions(+)
>
> diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texp
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++
> src/mesa/main/texparam.c | 52
> +-
> src/mesa/main/texparam.h | 20 ++
> 3 files changed, 68 inse
On Tue, Dec 16, 2014 at 11:54 PM, Laura Ekstrand wrote:
> No. I have a 78 column line highlight in my editor.
>
It does fit when you remove the whitespaces in function braces.
> On Tue, Dec 16, 2014 at 7:46 AM, Brian Paul wrote:
>>
>> On 12/15/2014 06:22 PM, Laura Ekstrand wrote:
>>>
>>> ---
>>>
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> In implementing ARB_DIRECT_STATE_ACCESS functions, it is often necessary to
> abstract the functionality of a traditional GL API function into a backend
> that both the traditional and dsa API functions can share. For instance,
> glTexParam
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 9 +
> src/mesa/main/texgetimage.c| 315
> +++--
> src/mesa/main/texgetimage.h| 9 +
> 3 files changed, 267 insertions(+
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +
> src/mesa/main/texgetimage.c| 169
> ++---
> src/mesa/main/texgetimage.h| 12 ++
> 3 files changed, 143 insertions(
On Wed, Dec 31, 2014 at 11:21 AM, Anuj Phogat wrote:
> On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
>> ---
>> src/mapi/glapi/gen/ARB_direct_state_access.xml | 9 +
>> src/mesa/main/texgetimage.c| 315
>> +++--
>
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 4 ++
> src/mesa/main/genmipmap.c | 73
> +++---
> src/mesa/main/genmipmap.h | 6 +++
> 3 files changed, 64 insertions(+
Use shorter commit messages in present tense:
"main: Fix texObj->Immutable flag update in _mesa_texture_image_multisample"
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/teximage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/mai
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> This is part of a potential solution to Khronos Bug 13223. Cube completeness
> is a concept from glGenerateMipmap, but it seems reasonable to check for it in
> GetTextureImage when the target is GL_TEXTURE_CUBE_MAP.
Add this to the comment
l be sending out a new patch "Checking for cube completeness in
> GetTextureImage" and another new one for "Checking for cube completeness in
> TextureSubImage." I will also send a patch to add a function
> _mesa_cube_level_complete.
>
Good catch.
> On Wed, Dec 31,
On Wed, Dec 31, 2014 at 5:26 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/texobj.c | 23 ++-
> src/mesa/main/texobj.h | 4
> 2 files changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
> index 126b523..82d52c5 100
On Tue, Dec 16, 2014 at 10:59 AM, Laura Ekstrand wrote:
> This happens almost everywhere. I prefer to call _mesa_error(ctx,
> "glTex%sStorage" rather than _mesa_error(ctx, "%s" because it's
> more obvious when reading the code which API function you're in (texture
> storage rather than c
I think you can squash all the patches fixing the white space issues.
Patch 09/41, 36/41 and 37/41.
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/texstate.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/src/mesa/main/te
I ran gles3 conformance on your adsa-textures branch. Your patches
cause no regressions.
With all the comments fixed, and no piglit regressions, this series is
Reviewed-by: Anuj Phogat
On Tue, Dec 30, 2014 at 4:27 PM, Laura Ekstrand wrote:
> That is now fixed. Each added entry point in
um
> +_mesa_is_format_color_format(mesa_format format);
> +
> extern GLenum
> _mesa_get_format_color_encoding(mesa_format format);
>
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop
= ((s >> 5 ) & 0x3f) * (1.0F / 63.0F);
> + texel[BCOMP] = ((s >> 11) & 0x1f) * (1.0F / 31.0F);
> texel[ACOMP] = 1.0F;
> }
>
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Below comment in formats.h also needs a fix to show correct ordering of
components:
* examples: msb <-- TEXEL BITS ---> lsb
* MESA_FORMAT_A8B8G8R8_UNORM,
* MESA_FORMAT_R5G6B5_UNORM RGGG GGGB
* MESA_FORMAT_B4G4R4X4_UNORM
With this comment fixed, this patch is:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Fri, Jan 9, 2015 at 5:21 PM, wrote:
> From: Mike Mason
>
> Changes the initial internal format of a render buffer
> to GL_RGBA4. This fixes a failure in the following
> DrawElements test:
>
> dEQP-GLES3.functional.state_query.rbo.renderbuffer_internal_format
> ---
> src/mesa/main/renderbuffe
GBA4;
> + } else {
> + rb->InternalFormat = GL_RGBA;
> + }
> +
> rb->Format = MESA_FORMAT_NONE;
> }
>
> --
> 1.9.1
>
> _______
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
a
> symbolic constant that is not one of those specified as allowable
> for that command, an INVALID_ENUM error is generated."
>
> The ES3.1 spec is also specific on this point:
>
> An INVALID_ENUM error is generated by any combinations of
> framebuffer type an
On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev wrote:
> The specification states that glTexImage2D and glTexImage3D should return
> GL_INVALID_VALUE if the internal format is invalid, and GL_INVALID_ENUM is
> the format type is invalid. However, current error check only considers the
> combin
opagate UD negations becuse we
> +* end up accessing the resulting values as signed integers
> +* instead. See also resolve_ud_negate().
> */
> - if (inst->conditional_mod &&
> - value.negate &&
> + if (value.negate &&
> value.type ==
yload, BRW_REGISTER_TYPE_UD));
> brw_inst_set_sfid(devinfo, send, sfid);
> --
Reviewed-by: Anuj Phogat
> 2.20.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
__
Fixes all subgroup test failures in vulkancts on Icelake.
Series is:
Tested-by: Anuj Phogat
On Fri, Jan 18, 2019 at 4:09 PM Francisco Jerez wrote:
>
> Currently the execution type calculation will return a bogus value in
> cases like:
>
> mov_indirect(8) vgrf0:w, vgrf1:w
On Sun, Sep 6, 2015 at 9:37 AM, Chris Wilson wrote:
> glCopyTexImage behaves similarly to glReadPixels with respect to the
> pixel transfer operations. Therefore if any are set we cannot use the
> simply blit fast paths.
>
> Signed-off-by: Chris Wilson
> Cc: Jason Ekstrand
> Cc: Kenneth Graunke
On Tue, Sep 8, 2015 at 12:58 PM, Chris Wilson wrote:
> On Tue, Sep 08, 2015 at 12:33:05PM -0700, Anuj Phogat wrote:
>> On Sun, Sep 6, 2015 at 9:37 AM, Chris Wilson
>> wrote:
>> > glCopyTexImage behaves similarly to glReadPixels with respect to the
>> > pixel
On Tue, Sep 1, 2015 at 6:58 AM, Emil Velikov wrote:
> Hi all
>
> On 21 August 2015 at 23:04, Anuj Phogat wrote:
>> We have a similar check in meta pbo path.
>>
>> Cc:
>> Signed-off-by: Anuj Phogat
>> ---
>> src/mesa/drivers/dri/i965/intel_pixel_rea
(coord.x))]);
>
> Since the coord parameter of this macro is a vec2 at all invocations, no
> expansion of this macro will even compile.
>
> Signed-off-by: Ian Romanick
> Cc: Anuj Phogat
> Cc: Topi Pohjolainen
> Cc: Jordan Justen
> ---
> src/mesa/drivers/common/meta_bli
array
>>> texture case could possibly work. This will generate code for the
>>> TEXEL_FETCH macro like:
>>>
>>> #define TEXEL_FETCH(coord) texelFetch(texSampler, ivec3(coord),
sample_map[int(2 * fract(coord.x))]);
>>>
>>> Since the co
On Wed, Sep 9, 2015 at 6:19 PM, Ian Romanick wrote:
> On 09/09/2015 04:55 PM, Anuj Phogat wrote:
>> On Wed, Sep 9, 2015 at 11:30 AM, Ian Romanick
wrote:
>>> I'm pretty sure our implementation of this extension is complete
>>> rubbish. I have attached an image
s(1, &mipmap->Sampler);
> --
> 2.1.0
>
> ___
> mesa-stable mailing list
> mesa-sta...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-stable
>
You can now remove the temporary variable currentTexU
cX0, srcY0, srcX1, srcY1,
>dstX0, dstY0, dstX1, dstY1,
> - mask, filter);
> + mask);
> if (mask == 0x0)
>return;
>
> --
> 2.1
ap_tree.h
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> index c28162a..81e5f52 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> @@ -517,8 +517,7 @@ struct intel_mipmap_tree
> };
>
> void
> -i
id) layer;
> +
> assert(level >= mt->first_level);
> assert(level <= mt->last_level);
> assert(layer < mt->level[level].depth);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesk
ntel_mipmap_tree.h
> @@ -774,12 +774,6 @@ brw_miptree_layout(struct brw_context *brw,
> struct intel_mipmap_tree *mt,
> uint32_t layout_flags);
>
> -void *intel_miptree_map_raw(struct brw_context *brw,
> -struct intel_mipmap_tree *mt);
>
struct intel_mipmap_tree *mt);
>
> void *intel_miptree_map_raw(struct intel_context *intel,
> struct intel_mipmap_tree *mt);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.fr
On Thu, Sep 10, 2015 at 11:47 AM, Ian Romanick wrote:
> On 09/10/2015 11:27 AM, Anuj Phogat wrote:
> >
> >
> > On Wed, Sep 9, 2015 at 7:18 PM, Ian Romanick > <mailto:i...@freedesktop.org>> wrote:
> >
> > From: Ian Romanick > <mailto
2,7 +102,7 @@ intel_blit_texsubimage(struct gl_context * ctx,
>_mesa_error(ctx, GL_OUT_OF_MEMORY, "intelTexSubImage");
> }
>
> - intel_miptree_unmap_raw(intel, temp_mt);
> + intel_miptree_unmap_raw(temp_mt);
>
> bool ret;
>
> --
> 2.1.0
tt(brw, mt, map, level, slice);
> + intel_miptree_unmap_gtt(mt);
> }
>
> intel_miptree_release_map(mt, level, slice);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
width, height, 1,
> - true);
> + width, height, 1);
> if (intel_image->mt == NULL)
> return;
> intel_region_reference(&intel_image-
el_batchbuffer_advance(struct brw_context *brw)
>abort();
> }
> batch->total = 0;
> +#else
> + (void) brw;
> #endif
> }
>
> --
> 2.1.0
>
> _______
> mesa-dev mailing list
> mesa-dev@lists.f
On Thu, Sep 10, 2015 at 12:20 PM, Chad Versace
wrote:
> On Wed 19 Aug 2015, Anuj Phogat wrote:
> > V2:
> > - Do the tile width/height computations in the new helper
> > function and use it later in intel_miptree_get_tile_masks().
> > - Change the name to intel_get_t
d_format(GLenum format);
>
> +extern bool
> +_mesa_is_specific_np_compressed_format(GLenum format);
> +
> extern GLenum
> _mesa_compressed_format_to_glenum(struct gl_context *ctx, mesa_format
> mesaFormat);
>
> --
> 2.5.0
>
> ___
> mesa
ernalFormat) {
>case GL_ETC1_RGB8_OES:
> return GL_RGB;
> --
> 2.5.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Reviewed-by: An
701 - 800 of 1807 matches
Mail list logo
