this fix to both glReadPixels and glGetTexImage.
Cc:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_tex_subimage.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/drivers/common/meta_tex_subimage.c
b/src/mesa/drivers/common/meta_tex_subimage.c
index 6d7c1eb..03
enough? */
> + GLint iparams[1] = {0}; /* XXX is one element enough? */
> _mesa_GetObjectParameterivARB(object, pname, iparams);
> params[0] = (GLfloat) iparams[0];
> }
> --
> 1.9.1
>
> _______
> mesa-dev mailing list
> mesa-de
ent */
>
> This patch fixes the segmentation fault for cases like that.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91290
> Signed-off-by: Samuel Iglesias Gonsalvez
> Cc: Anuj Phogat
> Cc: Carl Worth
> ---
> src/glsl/glcpp/glcpp-parse.y | 4 ++--
> 1 fil
gt;
> On Fri, 2015-07-17 at 10:28 -0700, Anuj Phogat wrote:
>> After recent addition of pbo testing in piglit test getteximage-luminance,
>> it fails on i965. This patch makes a sub test pass.
>>
>> This patch adds a clear color operation to meta pbo path, which I think is
>
/**
> @@ -1306,7 +1305,7 @@ _mesa_CreateTextures(GLenum target, GLsizei n, GLuint
> *textures)
>return;
> }
>
> - create_textures(ctx, target, n, textures, true);
> + create_textures(ctx, target, n, textures, "glCreateTextures");
> }
>
> /**
> --
> 1.9.1
>
&
_
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
tx, GL_INVALID_OPERATION,
> "glEGLImageTargetRenderbufferStorage(unsupported image format");
>return;
> - break;
> - default:
> - break;
> }
>
> irb = intel_renderbuffer(rb);
> --
> 2.1.0
>
> ____
On Thu, Aug 13, 2015 at 2:51 PM, Anuj Phogat wrote:
> Vertical alignment is not applicable to 1D textures.
>
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/dri/i965/brw_tex_layout.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/s
On Tue, Oct 20, 2015 at 12:56 AM, Pohjolainen, Topi
wrote:
> On Mon, Oct 19, 2015 at 02:29:04PM -0700, Anuj Phogat wrote:
>> On Thu, Aug 13, 2015 at 2:51 PM, Anuj Phogat wrote:
>> > Vertical alignment is not applicable to 1D textures.
>> >
>> > Signed-off-by:
SABLE);
> - struct brw_reg reg = retype(stride(src1, 1, 4, 0), BRW_REGISTER_TYPE_UW);
> + struct brw_reg reg = stride(src1, 1, 4, 0);
> if (dispatch_width == 8) {
>brw_ADD(p, dst, src0, reg);
> } else if (dispatch_width == 16) {
> --
> 2.4.9
>
Verifi
texCoords;\n"
> @@ -507,7 +496,6 @@ setup_glsl_msaa_blit_shader(struct gl_context *ctx,
>"{\n"
>"%s\n" /* sample_resolve */
>"}\n",
> - arb_sample_shading_extension_string,
>vec4_prefix,
>vec4_prefix,
>sampler_array_suffix,
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
"#version 130\n"
>"#extension GL_ARB_texture_multisample :
> enable\n"
>"#extension GL_ARB_sample_shading :
> enable\n"
> + "#extension GL_ARB_gpu_shader5 : enable\n"
>"#define gvec4 %svec4\n"
>"uniform %ssampler2DMS%s texSampler;\n"
>"in %s texCoords;\n"
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Looks good to me. I couldn't think of a better way to fix this problem.
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>case PLAIN_CLEAR:
> plain_clear_buffers |= 1 << index;
> - get_buffer_rect(brw, fb, irb, &clear_rect);
> + get_buffer_rect(fb, &clear_rect);
> continue;
> }
> }
> --
> 2.1.0
>
> ___
GLuint attrib, GLint size, GLenum type,
> + GLenum format, GLboolean normalized,
> + GLboolean integer, GLboolean doubles,
> + GLuint relativeOffset, bool flush_vertices);
> +
> +extern void
> _mesa_bind_vertex_buffer(struct gl
buffer_object *vbo,
> + GLintptr offset, GLsizei stride);
> +
> extern void GLAPIENTRY
> _mesa_VertexPointer(GLint size, GLenum type, GLsizei stride,
> const GLvoid *ptr);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
mt->fast_clear_state = INTEL_FAST_CLEAR_STATE_RESOLVED;
> get_resolve_rect(brw, mt, &rect);
>
> - brw_draw_rectlist(ctx, &rect, 1);
> + brw_draw_rectlist(brw, &rect, 1);
>
> set_fast_clear_op(brw, 0);
> use_rectlist(brw
te)
> _mesa_update_state(ctx);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
gl_context *ctx,
> + struct gl_vertex_array_object *vao,
> + unsigned attrib);
> +
> +extern void
> _mesa_bind_vertex_buffer(struct gl_context *ctx,
> struct gl_vertex
; *rect, int num_instances)
> verts[5] = rect->y0;
>
> /* upload new vertex data */
> - _mesa_NamedBufferData(clear->vbo, sizeof(verts), verts,
> - GL_DYNAMIC_DRAW);
> + _mesa_buffer_data(ctx, clear->buf_obj, GL_NONE, sizeof(verts), verts,
> +
gt; - _mesa_DeleteBuffers(1, &clear->vbo);
> + _mesa_reference_buffer_object(&brw->ctx, &clear->buf_obj, NULL);
> _mesa_DeleteProgram(clear->shader_prog);
> free(clear);
>
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
0);
> }
>
> _mesa_GenTextures(1, tmp_tex);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>VBO, sizeof(verts), verts,
> + GL_DYNAMIC_DRAW);
>
> _mesa_meta_bind_fbo_image(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
> dstImage, layer);
>
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
dims.dst_x1 - dims.dst_x0, dims.dst_y1 - dims.dst_y0);
> _mesa_ColorMask(GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> htt
2, 4, 0);
>_mesa_meta_setup_blit_shader(ctx, target, false, &mipmap->shaders);
> } else {
> - _mesa_meta_setup_ff_tnl_for_blit(&mipmap->VAO, &mipmap->VBO, 3);
> + _mesa_meta_setup_ff_tnl_for_blit(ctx, &mipmap->
dstImage, layer);
>
> diff --git a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
> b/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
> index ddb6826..619dda9 100644
> --- a/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
> +++ b/src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c
> @@ -279,7 +279,8 @@ setup_program(struct brw_context *brw, bool msaa_tex)
> char *fs_source;
> const struct sampler_and_fetch *sampler = &samplers[msaa_tex];
>
> - _mesa_meta_setup_vertex_objects(ctx, &blit->VAO, &blit->VBO, true, 2, 2,
> 0);
> + _mesa_meta_setup_vertex_objects(&brw->ctx, &blit->VAO, &blit->buf_obj,
> true,
> + 2, 2, 0);
>
> GLuint *prog_id = &brw->meta_stencil_blit_programs[msaa_tex];
>
> @@ -360,7 +361,7 @@ adjust_mip_level(const struct intel_mipmap_tree *mt,
> }
>
> static void
> -prepare_vertex_data(GLuint vbo)
> +prepare_vertex_data(struct gl_context *ctx, struct gl_buffer_object *buf_obj)
> {
> static const struct vertex verts[] = {
>{ .x = -1.0f, .y = -1.0f },
> @@ -368,7 +369,7 @@ prepare_vertex_data(GLuint vbo)
>{ .x = 1.0f, .y = 1.0f },
>{ .x = -1.0f, .y = 1.0f } };
>
> - _mesa_NamedBufferSubData(vbo, 0, sizeof(verts), verts);
> + _mesa_buffer_sub_data(ctx, buf_obj, 0, sizeof(verts), verts, __func__);
> }
>
> static bool
> @@ -448,7 +449,7 @@ brw_meta_stencil_blit(struct brw_context *brw,
> _mesa_Uniform1i(_mesa_GetUniformLocation(prog, "dst_num_samples"),
> dst_mt->num_samples);
>
> - prepare_vertex_data(ctx->Meta->Blit.VBO);
> + prepare_vertex_data(ctx, ctx->Meta->Blit.buf_obj);
> _mesa_set_viewport(ctx, 0, dims.dst_x0, dims.dst_y0,
>dims.dst_x1 - dims.dst_x0, dims.dst_y1 - dims.dst_y0);
> _mesa_ColorMask(GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
er(ctx, array_obj, VERT_ATTRIB_COLOR0,
> + *buf_obj, 0, sizeof(struct vertex));
> +_mesa_enable_vertex_array_attrib(ctx, array_obj,
> VERT_ATTRIB_COLOR0);
> }
>}
> } else {
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
* but there are no DSA functions to bind a VBO to a VAO for
> + * fixed-function vertex attributes.
> + */
> + {
> +struct save_state *save =
> &ctx->Meta->Save[ctx->Meta->SaveStackDepth - 1];
> +_mesa_BindBuffer
* setup vertex arrays */
>if (use_generic_attributes) {
> assert(color_size == 0);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
p;mipmap->shaders);
> }
> --
> 2.1.0
>
> ___
> mesa-stable mailing list
> mesa-sta...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-stable
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
0, sizeof(verts), verts);
> }
>
> _mesa_DrawArrays(GL_TRIANGLE_FAN, 0, 4);
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_state
> struct drawtex_state
> {
> GLuint VAO;
> - GLuint VBO;
> + struct gl_buffer_object *buf_obj;
> };
>
> #define MAX_META_OPS_DEPTH 8
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
er_object(ctx, &blit->buf_obj, NULL);
> }
>
> _mesa_meta_blit_shader_table_cleanup(&blit->shaders_with_depth);
> diff --git a/src/mesa/drivers/common/meta_generate_mipmap.c
> b/src/mesa/drivers/common/meta_generate_mipmap.c
> index 7fb82e1..
zeof(struct
> vertex));
> + _mesa_enable_vertex_array_attrib(ctx, array_obj,
> VERT_ATTRIB_TEX(i));
>}
> -
> - /* restore client active texture */
> - _mesa_ClientActiveTexture(GL_TEXTURE0 + active_texture);
> }
>
L;
> @@ -448,7 +454,7 @@ _mesa_meta_pbo_GetTexSubImage(struct gl_context *ctx,
> GLuint dims,
> fail:
> _mesa_DeleteFramebuffers(2, fbos);
> _mesa_DeleteTextures(1, &pbo_tex);
> - _mesa_DeleteBuffers(1, &pbo);
> + _mesa_reference_buffer_object(ctx, &pbo, NULL);
>
> _mesa_meta_end(ctx);
>
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
ct *CurrentTexture[NUM_TEXTURE_TARGETS];
> /** mask of TEXTURE_2D_BIT, etc */
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
ommon/meta.h
> @@ -155,7 +155,6 @@ struct save_state
>
> /** MESA_META_VERTEX */
> struct gl_vertex_array_object *VAO;
> - struct gl_buffer_object *ArrayBufferObj;
>
> /** MESA_META_VIEWPORT */
> GLfloat ViewportX, ViewportY, ViewportW, ViewportH;
> --
= GL_FRAMEBUFFER_COMPLETE_EXT) {
>_mesa_perf_debug(ctx, MESA_DEBUG_SEVERITY_HIGH,
> --
> 2.1.0
>
> ___
> mesa-stable mailing list
> mesa-sta...@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-stable
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
st
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, Jan 27, 2015 at 9:09 AM, Eduardo Lima Mitev wrote:
> On 01/21/2015 03:26 AM, Anuj Phogat wrote:
>> On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev wrote:
>>> The specification states that glTexImage2D and glTexImage3D should return
>>> GL_INVALID_VALU
age->TexFormat == MESA_FORMAT_R8G8B8X8_UNORM)
> + return false;
> +
> if (!intel_get_memcpy(texImage->TexFormat, format, type, &mem_copy, &cpp))
>return false;
>
> --
> 2.2.2
>
> ___
> mesa-
;
> --
> 1.9.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Both patches are:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
LE_POS:
> reg = emit_samplepos_setup();
> --
> 2.2.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Series is:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
otherwise samples=0 passes the check, which is invalid.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_blit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/common/meta_blit.c
b/src/mesa/drivers/common/meta_blit.c
index bf893be..9498817
create_texture_for_pbo() is used by both _mesa_meta_pbo_GetTexSubImage()
and _mesa_meta_pbo_TexSubImage() functions with different PBO targets.
Use GL_STREAM_READ with GL_PIXEL_PACK_BUFFER and GL_STREAM_DRAW with
GL_PIXEL_UNPACK_BUFFER.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common
No functional changes in the patch. Just makes the code look cleaner.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 40 +++
1 file changed, 29 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
b
before calling _mesa_meta_pbo_TexSubImage(). This will be used in
later patches and will be required in Skylake to get the tile
resource mode of miptree before calling _mesa_meta_pbo_TexSubImage().
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_tex_image.c | 13 +++--
1
should get some speedup in above cases.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_tex_subimage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/common/meta_tex_subimage.c
b/src/mesa/drivers/common/meta_tex_subimage.c
index 8b26ba7
This will be used by next patch in the series.
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/brw_tex_layout.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_tex_layout.c
b/src/mesa/drivers/dri/i965/brw_tex_layout.c
On Tue, Feb 24, 2015 at 8:31 AM, Neil Roberts wrote:
> Anuj Phogat writes:
>
>> using a flag passed in as function parameter. This will enable
>> _mesa_meta_pbo_GetTexSubImage to be used for reading in to
>> non-pbo buffers.
>>
>> This will be useful to suppo
return;
>
> + /* Check target (proxies not allowed). */
> + if (!legal_texsubimage_target(ctx, 3, texObj->Target, true)) {
> + _mesa_error(ctx, GL_INVALID_ENUM,
> + "glCopyTextureSubImage3D(invalid target %s)",
> +
{
> + return;
> + }
> +
> texObj = _mesa_get_current_tex_object(ctx, target);
> if (!texObj)
>return;
> @@ -4874,6 +4918,12 @@ _mesa_CompressedTextureSubImage3D(GLuint texture,
> GLint level, GLint xoffset,
> if (!texObj)
>return;
>
> + if (compressed_subt
a-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Series is:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
t;total_width;
> + mt->qpitch = mt->total_width;
> } else if (brw->gen >= 9) {
>GLenum base_format;
>
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesk
dw6 |= (64 - 2) << HSW_PS_MAX_THREADS_SHIFT;
>
> if (prog_data->base.nr_params > 0)
>dw6 |= GEN7_PS_PUSH_CONSTANT_ENABLE;
> --
> 1.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/teximage.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 6e45cc9..dfad9ed 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
On Tue, Mar 3, 2015 at 4:15 PM, Anuj Phogat wrote:
> On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote:
>> ---
>> src/mesa/main/teximage.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/teximage.c | 204
> ---
> src/mesa/main/teximage.h | 3 +-
> 2 files changed, 179 insertions(+), 28 deletions(-)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/te
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/texgetimage.c | 51
> -
> 1 file changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
> index 24df5b6..327a397 1
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/bufferobj.c | 19 +++
> src/mesa/main/bufferobj.h | 4
> 2 files changed, 23 insertions(+)
>
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index f026fc3..617242b 100644
> --
3, 2015 at 5:24 PM, Fredrik Höglund wrote:
>>
>> On Wednesday 04 March 2015, Anuj Phogat wrote:
>> > On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand
>> > wrote:
>> > > ---
>> > > src/mesa/main/bufferobj.c | 19 +++
>>
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand wrote:
> Uses _mesa_lookup_bufferobj_err to clean up buffer object retrieval. Moves
> error checking statements into separate functions to allow code sharing
> between traditional and ARB_direct_state_access entry points.
It's little difficult to fo
e slack due to the lack
> of
> * Sandybridge PIPE_CONTROL madness.
> */
> -#define BATCH_RESERVED 146
> +#define BATCH_RESERVED 152
>
> struct intel_batchbuffer;
>
> --
> 2.2.2
>
> ___
in different fragment shaders. This also applies to a case when gl_FragCoord
is redeclared with no layout qualifiers in one fragment shader and not
declared but used in other fragment shader.
Signed-off-by: Anuj Phogat
Khronos Bug#12957
Cc: "10.5"
Cc: Ian Romanick
---
src/glsl/linke
_
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand wrote:
> Adds a useful comment and some whitespace. Fixes an error message.
>
> v2: Review from Anuj Phogat
>- Split rebase of Tex[ture]Buffer[Range]
> ---
> src/mesa/main/teximage.c | 12 ++--
> 1 file changed
On Mon, Mar 9, 2015 at 9:43 AM, Laura Ekstrand wrote:
> I'm confused which hunk you talking about. Can you be more specific?
>
> On Mon, Mar 9, 2015 at 8:47 AM, Anuj Phogat wrote:
>>
>> On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand
>> wrote:
>> >
On Wed, Mar 4, 2015 at 4:41 PM, Laura Ekstrand wrote:
> This divides a major rework of Tex[ture]Buffer[Range] into multiple patches as
> recommended by Anuj Phogat.
>
> Laura Ekstrand (7):
> main: Add utility function _mesa_lookup_bufferobj_err.
> main: Use _mesa_looku
On Mon, Mar 9, 2015 at 11:09 AM, Anuj Phogat wrote:
> On Wed, Mar 4, 2015 at 3:44 PM, Laura Ekstrand wrote:
>> This cleans up ARB_direct_state_access texture cube map functions
>> (mostly in response to reviews from Anuj Phogat).
>>
>> Laura Ekstrand (6):
>>
On Wed, Mar 4, 2015 at 3:44 PM, Laura Ekstrand wrote:
> This cleans up ARB_direct_state_access texture cube map functions
> (mostly in response to reviews from Anuj Phogat).
>
> Laura Ekstrand (6):
> main: _mesa_cube_level_complete checks NumLayers.
> main: Remove redundan
nks.
>
> Laura
>
> On Mon, Mar 9, 2015 at 1:13 PM, Laura Ekstrand wrote:
>>
>> Oh, thanks! I didn't see the new line there when I read your review. I
>> will remove it.
>>
>> On Mon, Mar 9, 2015 at 10:45 AM, Anuj Phogat
>> wrote:
>>>
define GEN8_HIZ_NP_PMA_FIX_ENABLE(1 << 11)
> # define GEN8_HIZ_NP_EARLY_Z_FAILS_DISABLE (1 << 13)
> +# define GEN9_PARTIAL_RESOLVE_DISABLE_IN_VC (1 << 1)
> # define GEN8_HIZ_PMA_MASK_BITS \
> ((GEN8_HIZ_NP_PMA_FIX_ENABLE | GEN8_HIZ_NP_EARLY_Z
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky
wrote:
> Signed-off-by: Ben Widawsky
> ---
> src/mesa/drivers/dri/i965/intel_blit.c| 11 ++-
> src/mesa/drivers/dri/i965/intel_blit.h| 3 +++
> src/mesa/drivers/dri/i965/intel_copy_image.c | 7 ---
> src/mesa/drivers/dri
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky
wrote:
> The blit engine in GEN hardware has constraints. These constraints are a
> function of tile parameters as well as height. The current code is very dumb
> in
> terms of determine max blit parameters. Since we'll be expanding on it, having
deter
On Mon, Mar 9, 2015 at 9:43 PM, Ben Widawsky
wrote:
> The blit engine is limited to 32Kx32K transfer. In cases where we have to fall
> back to the blitter, and when trying to blit a slice of a 2d texture array, or
> face of a cube map, we don't need to transfer the entire texture.
>
> I doubt this
tiling when larger than estimated aperture size.
>
> v2: This was rebased on a recent commit than Anuj pushed since I originally
> authored the patch.
> commit 524a729f68c15da3fc6c42b3158a13e0b84c2728
> Author: Anuj Phogat
> Date: Tue Feb 17 10:40:58 2015 -0800
>
> i965: Fix condition
}
> } else {
> + assert(desc->nsrc < 4);
>return desc->nsrc;
> }
>
> --
> 2.11.0.453.g787f75f05
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.o
0644
> --- a/src/compiler/glsl/glsl_parser_extras.h
> +++ b/src/compiler/glsl/glsl_parser_extras.h
> @@ -348,6 +348,7 @@ struct _mesa_glsl_parse_state {
> } supported_versions[16];
>
> bool es_shader;
> + bool compat_shader;
> unsigned language_version;
> unsigned forced_language_version;
> bool zero_init;
> --
> 2.10.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
LGTM.
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> --
> 2.11.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Series is doing what it says and changes look fine to me.
Series is:
Reviewed-by: Anuj Ph
T be programmed to
> + *value = SCS_ALPHA."
> + */
> + assert(info->view->swizzle.a == ISL_CHANNEL_SELECT_ALPHA);
> + }
> s.ShaderChannelSelectRed = info->view->swizzle.r;
> s.ShaderChannelSelectGreen = info->view->s
haven't been getting hangs or anything, we should probably obey the
> docs. This commit just sanitizes all render swizzles so that the alpha
> channel maps to ALPHA.
>
> Cc: Anuj Phogat
> ---
> src/intel/vulkan/anv_blorp.c | 9 ++---
> src/intel/vulkan/anv_p
On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand wrote:
> Nothing uses this yet but it serves as a nice bit of documentation
> that's relatively easy to find.
> ---
> src/intel/isl/isl.h| 2 ++
> src/intel/isl/isl_format.c | 15 +++
> 2 files changed, 17 insertions(+)
>
> diff
On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand wrote:
> On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat wrote:
>>
>> On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand
>> wrote:
>> > Nothing uses this yet but it serves as a nice bit of documentation
>&
> }
> }
>}
> --
> 2.5.0.400.gff86faf
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Patch v2 3/5] and rest of the series is:
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Feb 2, 2017 at 9:52 AM, Jason Ekstrand wrote:
> Cc: Anuj Phogat
> ---
> src/intel/isl/isl_format.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/intel/isl/isl_format.c b/src/intel/isl/isl_format.c
> index 1cd941c..0fdc716 100644
> --- a/sr
quot;__intrinsic_memory_barrier_image",
> -compute_shader),
> +compute_shader_supported),
> NULL);
> add_function("memoryBarrierShared",
> _memory_barrier("__intrinsi
RRENT_MATRIX_STACK_DEPTH_ARB:
> diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
> index 1cb06c7..2582323 100644
> --- a/src/mesa/main/readpix.c
> +++ b/src/mesa/main/readpix.c
> @@ -1033,8 +1033,8 @@ _mesa_ReadnPixelsARB( GLint x, GLint y, GLsizei width,
> GLsizei height,
>
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> From: Timothy Arceri
>
> This uses disk_cache.c to write out a serialization of various
> state that's required in order to successfully load and use a
> binary written out by a drivers backend, this state is referred to as
> "metadata" thro
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> From: Carl Worth
>
> The three additional tables are AttributeBindings, FragDataBindings,
> and FragDataIndexBindings.
>
> The first table (AttributeBindings) was identified as missing by
> trying to test the shader cache with a program that
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> From: Timothy Arceri
>
> This initially adds support for simple uniforms and varyings.
> ---
> src/compiler/glsl/shader_cache.cpp | 121
> +
> 1 file changed, 121 insertions(+)
>
> diff --git a/src/compi
On Mon, Feb 6, 2017 at 7:42 PM, Timothy Arceri wrote:
> From: Timothy Arceri
>
> This uses disk_cache.c to write out a serialization of various
> state that's required in order to successfully load and use a
> binary written out by a drivers backend, this state is referred to as
> "metadata" thro
c/mesa/program/ir_to_mesa.cpp
> +++ b/src/mesa/program/ir_to_mesa.cpp
> @@ -3096,7 +3096,7 @@ _mesa_glsl_link_shader(struct gl_context *ctx, struct
> gl_shader_program *prog)
>
> _mesa_clear_shader_program_data(ctx, prog);
>
> - prog->data->LinkStatus = GL_TRUE;
> + prog->data
goto fail;
> }
>
> - ralloc_free(filename);
> + free(filename);
> close(fd);
>
> if (size)
> @@ -776,7 +775,7 @@ disk_cache_get(struct disk_cache *cache, cache_key key,
> size_t *size)
> if (data)
>free(data);
> if (filename
Passes the newly added piglit test for this extension on i965.
Signed-off-by: Anuj Phogat
---
A quick look at other drivers didn't show any issues with
this new extension. Let me know if you think it won't work
for any driver.
---
docs/features.txt| 3 +++
sr
On Fri, Feb 10, 2017 at 1:21 PM, Ilia Mirkin wrote:
> On Fri, Feb 10, 2017 at 4:15 PM, Anuj Phogat wrote:
>> Passes the newly added piglit test for this extension on i965.
>>
>> Signed-off-by: Anuj Phogat
>> ---
>> A quick look at other drivers didn't show
On Fri, Feb 10, 2017 at 1:38 PM, Ilia Mirkin wrote:
> On Fri, Feb 10, 2017 at 4:36 PM, Anuj Phogat wrote:
>> On Fri, Feb 10, 2017 at 1:21 PM, Ilia Mirkin wrote:
>>> On Fri, Feb 10, 2017 at 4:15 PM, Anuj Phogat wrote:
>>>> Passes the newly added piglit t
Passes the newly added piglit test for this extension on i965.
V2: Fix comments by Ilia.
Signed-off-by: Anuj Phogat
---
src/compiler/glsl/builtin_variables.cpp | 3 +++
src/compiler/glsl/glsl_parser_extras.cpp | 1 +
src/compiler/glsl/glsl_parser_extras.h | 2 ++
src/mesa/main
"%s(transform feedback active)", caller);
> --
> 2.11.0.483.g087da7b7c-goog
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
YYLTYPE *locp, int version,
>const char *ident);
>
> --
> 2.11.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Anuj Phogat
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
onst unsigned slots = var->type->count_attribute_slots();
>
>/* From GL4.5 core spec, section 11.1.1 (Vertex Attributes):
> --
> 2.1.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.
101 - 200 of 1807 matches
Mail list logo
