[Mesa-dev] [Bug 106394] Black Mesa cannot compile shaders because of missing GL_EXT_gpu_shader4

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106394 Gregor Münch changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX

[Mesa-dev] [PATCH 2/5] anv/apply_pipeline_layout: Add to the bind map instead of replacing it

2018-08-08 Thread Jason Ekstrand
This commit makes three changes. One is to only walk the descriptors once and set bind map sizes at the same time as filling out the entries. The second is to make the pass additive so that we can put stuff in the bind map before applying the pipeline layout. Third, we switch to using designated

[Mesa-dev] [PATCH 3/5] anv/pipeline: Use more fields from stage in compile_cs

2018-08-08 Thread Jason Ekstrand
--- src/intel/vulkan/anv_pipeline.c | 37 +++-- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c index 23af0f1c924..e6a97aa8ca7 100644 --- a/src/intel/vulkan/anv_pipeline.c +++ b/src/intel/

[Mesa-dev] [PATCH 1/5] anv/lower_ycbcr: Use the binding array size for bounds checks

2018-08-08 Thread Jason Ekstrand
Because lower_ycbcr gets called before apply_pipeline_layout, the indices are all logical and the binding layout HW size is actually too big for the bounds check. We should just use the regular logical array size instead. Fixes: f3e91e78a33 "anv: add nir lowering pass for ycbcr textures" --- src

[Mesa-dev] [PATCH 4/5] anv/pipeline: Set tess IO read/written key fields in compile_*

2018-08-08 Thread Jason Ekstrand
We want these to be set as close to the final compile as possible so that they are guaranteed to happen after nir_shader_gather_info is called. The next commit is going to move nir_shader_gather_info to after the linking step which makes this necessary. --- src/intel/vulkan/anv_pipeline.c | 19 ++

[Mesa-dev] [PATCH 5/5] anv/pipeline: Lower pipeline layouts etc. after linking

2018-08-08 Thread Jason Ekstrand
This allows us to use the link-optimized shader for determining binding table layouts and, more importantly, URB layouts. For apps running on DXVK, this is extremely important as DXVK likes to declare max-size inputs and outputs and this lets is massively shrink our URB space requirements. VkPipe

Re: [Mesa-dev] [PATCH v2] i965: do not emit empty surface state

2018-08-08 Thread Lionel Landwerlin
On 07/08/18 20:31, Erik Faye-Lund wrote: If called with an empty size, brw_emit_buffer_surface_state asserts. We already have a dedicated helper for uploading nothing, so let's use that instead. Signed-off-by: Erik Faye-Lund Looks good to me. Maybe Ken can confirm? Reviewed-by: Lionel Landwe

Re: [Mesa-dev] [PATCH v2 09/11] intel: tools: add aubinator viewer

2018-08-08 Thread Lionel Landwerlin
On 08/08/18 00:42, Rafael Antognolli wrote: On Tue, Aug 07, 2018 at 06:35:20PM +0100, Lionel Landwerlin wrote: A graphical user interface version of aubinator. Allows you to : - simultaneously look at multiple points in the aub file (using all the goodness of the existing decoding in

Re: [Mesa-dev] [PATCH 1/4] vulkan: Add central copy of entrypoints/extensions code.

2018-08-08 Thread Emil Velikov
Hi Bas, On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: Please mention the origin and/or changes of the files, in the commit summary. > --- > src/vulkan/Makefile.am| 3 + > src/vulkan/util/meson.build | 2 + > src/vulkan/util/vk_entrypoints_gen.py | 515 ++

Re: [Mesa-dev] [PATCH 2/4] vulkan/util: Add support to not generate the trampolines.

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > @@ -146,7 +148,7 @@ static const uint16_t string_map[${strmap.hash_size}] = { > }; > > int > -${name_prefix}_string_map_lookup(const char *str) > +${name_prefix}_get_entrypoint_index(const char *str) Unrelated - did you mean to have this as

[Mesa-dev] [PATCH] travis: remove libedit-dev dependency in LLVM 6.0 targets

2018-08-08 Thread Juan A. Suarez Romero
In LLVM <6.0 we added explicitly libedit-dev, as it was required to satisfy apt dependencies. In LLVM 6.0, this is not required anymore, so let's remove it. CC: Emil Velikov --- .travis.yml | 6 -- 1 file changed, 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 9e07c4b8fe1..9f9

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 00:49, Dylan Baker wrote: > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) >> >> anv_extensions_c = custom_target( >> @@ -36,10 +37,11 @@ anv_extensions_c = custom_target( >>input : ['anv_extensions_gen.py', vk_api_xml], >>output : 'anv_extensions.c', >>command :

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > This became kind of messy as python imports cannot really look up > parent/sibling directories. I saw some scripts use sys.path but > that became even more messy due to import locations. > > I also move the selections of the dispatch table out

Re: [Mesa-dev] [PATCH 2/4] vulkan/util: Add support to not generate the trampolines.

2018-08-08 Thread Bas Nieuwenhuizen
On Wed, Aug 8, 2018 at 12:19 PM, Emil Velikov wrote: > On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > >> @@ -146,7 +148,7 @@ static const uint16_t string_map[${strmap.hash_size}] = { >> }; >> >> int >> -${name_prefix}_string_map_lookup(const char *str) >> +${name_prefix}_get_entrypoint_i

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-08 Thread Eric Engestrom
On Wednesday, 2018-08-08 11:31:09 +0100, Emil Velikov wrote: > On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > > This became kind of messy as python imports cannot really look up > > parent/sibling directories. I saw some scripts use sys.path but > > that became even more messy due to import

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-08 Thread Bas Nieuwenhuizen
On Wed, Aug 8, 2018 at 12:39 PM, Eric Engestrom wrote: > On Wednesday, 2018-08-08 11:31:09 +0100, Emil Velikov wrote: >> On 8 August 2018 at 00:14, Bas Nieuwenhuizen >> wrote: >> > This became kind of messy as python imports cannot really look up >> > parent/sibling directories. I saw some scrip

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-08 Thread Eric Engestrom
On Tuesday, 2018-08-07 16:49:17 -0700, Dylan Baker wrote: > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > > > > anv_extensions_c = custom_target( > > @@ -36,10 +37,11 @@ anv_extensions_c = custom_target( > >input : ['anv_extensions_gen.py', vk_api_xml], > >output : 'anv_extensions.c',

Re: [Mesa-dev] [PATCH 4/4] radv: Integrate with common generators.

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 00:14, Bas Nieuwenhuizen wrote: > Replace some functions to use the anv idioms. However, I did not > introduce dispatch tables in the instance/device since that seemed > like overkill. like an overkill > --- > src/amd/vulkan/Android.mk | 16 +- > src/amd/vulkan/

Re: [Mesa-dev] [PATCH] travis: remove libedit-dev dependency in LLVM 6.0 targets

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 11:20, Juan A. Suarez Romero wrote: > In LLVM <6.0 we added explicitly libedit-dev, as it was required to > satisfy apt dependencies. > > In LLVM 6.0, this is not required anymore, so let's remove it. > > CC: Emil Velikov Bit-by-bit we'll remove all the hacks/workarounds. Than

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 06:42, Marek Olšák wrote: > From: Marek Olšák > > This is needed for exposing the samplerBuffer functions under > EXT_gpu_shader4. > > glTexBufferEXT is defined in glapi, but "make check" fails. > What am I doing wrong? There should be one in src/mapi/glapi/gen/ One of these d

Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

2018-08-08 Thread Lionel Landwerlin
On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge them. I took the anv generators as the templat

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 6.0

2018-08-08 Thread Eric Engestrom
On Monday, 2018-08-06 11:52:48 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 6.0 or greater, and thus we can't build dist > tarball because swr requires LLVM 5.0. > > Let's bump required LLVM to 6.0 in swr too. > > Fixes: fd1121e839 ("amd: remove support for LLVM 5.0") > Cc: Tim Ro

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 6.0

2018-08-08 Thread Juan A. Suarez Romero
On Mon, 2018-08-06 at 11:52 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 6.0 or greater, and thus we can't build dist > tarball because swr requires LLVM 5.0. > > Let's bump required LLVM to 6.0 in swr too. > > Fixes: fd1121e839 ("amd: remove support for LLVM 5.0") > Cc: Tim Rowle

[Mesa-dev] [Bug 106394] Black Mesa cannot compile shaders because of missing GL_EXT_gpu_shader4

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106394 --- Comment #5 from Gregor Münch --- Just tested the patch series with Black Mesa (non beta) and it started working. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Ilia Mirkin
Aliased functions shouldn't be added separately to the function list. On Wed, Aug 8, 2018 at 1:42 AM, Marek Olšák wrote: > From: Marek Olšák > > This is needed for exposing the samplerBuffer functions under > EXT_gpu_shader4. > > glTexBufferEXT is defined in glapi, but "make check" fails. > What

[Mesa-dev] [Bug 107457] [Tracker] Mesa 18.2 release tracker

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107457 Mark Janes changed: What|Removed |Added Depends on||107223 Referenced Bugs: https://bugs.fre

[Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

2018-08-08 Thread Eric Engestrom
Cc: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/tools/error2aub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c index 3407dcec0b795168c4c8..2030593691cc4ba6dba0 100644 --- a/src/intel/tools/error2au

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

2018-08-08 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin bo_addr doesn't have a warning? On 08/08/18 15:27, Eric Engestrom wrote: Cc: Lionel Landwerlin Signed-off-by: Eric Engestrom --- src/intel/tools/error2aub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/tools/error2aub.c b/src

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

2018-08-08 Thread Eric Engestrom
On Wednesday, 2018-08-08 15:27:13 +0100, Eric Engestrom wrote: > Cc: Lionel Landwerlin Actually: Cc: Jason Ekstrand Fixes: 6a60beba4089315685b8 "intel/tools: Add an error state to aub translator" > Signed-off-by: Eric Engestrom > --- > src/intel/tools/error2aub.c | 2 +- > 1 file changed, 1 i

Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

2018-08-08 Thread Lionel Landwerlin
On 08/08/18 12:05, Lionel Landwerlin wrote: On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this repetition makes even less sense, so lets merge t

Re: [Mesa-dev] [PATCH mesa] intel/tools: add missing variable initialisation

2018-08-08 Thread Eric Engestrom
On Wednesday, 2018-08-08 15:29:49 +0100, Lionel Landwerlin wrote: > Reviewed-by: Lionel Landwerlin > > bo_addr doesn't have a warning? Nope; I guess bo_type guards it perfectly ;) > > On 08/08/18 15:27, Eric Engestrom wrote: > > Cc: Lionel Landwerlin > > Signed-off-by: Eric Engestrom > > ---

[Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

2018-08-08 Thread Juan A. Suarez Romero
Like in the autotools target, make the list of drivers to be built in each of the Meson targets explicit. This will help to identify missing dependencies and other issues more easily. CC: Emil Velikov --- .travis.yml | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH mesa] anv: set error in all failure paths

2018-08-08 Thread Eric Engestrom
Cc: Jason Ekstrand Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeli

Re: [Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

2018-08-08 Thread Danylo Piliaiev
Hi, Since the exact value is not important for users,  Roland offered compelling explanation and the value is also 8 on Windows - could the patch be reviewed/pushed? - Danil On 06/19/2018 03:44 PM, Roland Scheidegger wrote: My guess would be 8 because that's what the rasterization subpixel p

Re: [Mesa-dev] [PATCH] travis: make drivers explicit in Meson targets

2018-08-08 Thread Eric Engestrom
On Wednesday, 2018-08-08 16:36:55 +0200, Juan A. Suarez Romero wrote: > Like in the autotools target, make the list of drivers to be built in > each of the Meson targets explicit. > > This will help to identify missing dependencies and other issues more > easily. > > CC: Emil Velikov Technicall

Re: [Mesa-dev] [PATCH mesa] anv: set error in all failure paths

2018-08-08 Thread Tapani Pälli
Yep currently result is not set on this path; Reviewed-by: Tapani Pälli On 08.08.2018 17:45, Eric Engestrom wrote: Cc: Jason Ekstrand Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 4 +++-

[Mesa-dev] [Bug 107488] gl.h:2090: error: redefinition of typedef ‘GLeglImageOES’

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107488 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH mesa] anv: set error in all failure paths

2018-08-08 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 08/08/18 15:45, Eric Engestrom wrote: Cc: Jason Ekstrand Fixes: 5b196f39bddc689742d3 "anv/pipeline: Compile to NIR in compile_graphics" Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_pipeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

Re: [Mesa-dev] [PATCH 0/4] Merge vulkan API generators.

2018-08-08 Thread Tapani Pälli
On 08.08.2018 17:31, Lionel Landwerlin wrote: On 08/08/18 12:05, Lionel Landwerlin wrote: On 08/08/18 00:14, Bas Nieuwenhuizen wrote: radv was always just mirroring a derived version of the anv version, sometimes hacked together and sometimes very behind. As we grow more vulkan drivers this

[Mesa-dev] [PATCH 0/3] Use GitLab CI to build Mesa

2018-08-08 Thread Juan A. Suarez Romero
Hello. This is a first part of a more complete proposal to use GitLab CI to build and test Mesa. This first part just adds the required pieces to build Mesa, using the different supported tools (meson, autotools, and scons). A second part, to be sent in the future, will use the results of the fo

[Mesa-dev] [PATCH 1/3] gitlab-ci: build Mesa using GitLab CI

2018-08-08 Thread Juan A. Suarez Romero
Creates different Docker images containing Mesa built with different tools (autotools, meson, scons, etc). The build is done in 3 levels: the first level creates a base image with all the requirements to build Mesa. The second level (based of the first one), builds different images with different

[Mesa-dev] [PATCH 2/3] gitlab-ci: build base images if dependencies changed

2018-08-08 Thread Juan A. Suarez Romero
Most of times, the base and LLVM images do not require to be rebuilt, as the dependencies remains the same. To avoid rebuilding these images everytime, store in the image the Dockerfile's sha256sum: if the Dockerfile changes (because new dependencies were added or changed), then rebuild the image

[Mesa-dev] [PATCH 3/3] gitlab-ci: Build from the released tarballs

2018-08-08 Thread Juan A. Suarez Romero
The `distcheck` stage creates a tarball ready for the distribution, and compiles it with the autotools to ensure everything works fine. But it does not try with the other tools: scons and meson. Hence, let's add a new stage that takes the generated tarball and builds it using meson and scons. Si

Re: [Mesa-dev] [PATCH 3/7] dri: Define DRI_MutableRenderBuffer extensions

2018-08-08 Thread Tapani Pälli
On 07.08.2018 21:16, Chad Versace wrote: On Mon 06 Aug 2018, Chad Versace wrote: On Fri 03 Aug 2018, Tapani Pälli wrote: One tiny nit below but for patches 3,4 and 5: Reviewed-by: Tapani Pälli Special thanks for the documentation. I want to go through rest of changes within Android but I'm

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
What does that mean? Marek On Wed, Aug 8, 2018 at 9:05 AM, Ilia Mirkin wrote: > Aliased functions shouldn't be added separately to the function list. > > On Wed, Aug 8, 2018 at 1:42 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This is needed for exposing the samplerBuffer functions under

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Ilia Mirkin
Sorry, I thought I was answering your question. If glTexBufferEXT is aliased to glTexBuffer (/glTexBufferARB), which are already in the list of dispatch functions, you should not add the aliased name, otherwise you'll get failures. I did not, however, check if glTexBufferEXT is aliased in the disp

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
Yes, it's aliased. It's weird, because adding other aliased functions into dispatch_sanity didn't break the test. Marek On Wed, Aug 8, 2018 at 12:00 PM, Ilia Mirkin wrote: > Sorry, I thought I was answering your question. > > If glTexBufferEXT is aliased to glTexBuffer (/glTexBufferARB), which >

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Ilia Mirkin
It's not the alias itself that breaks it -- but you can only have one entry per alias group. On Wed, Aug 8, 2018 at 12:03 PM, Marek Olšák wrote: > Yes, it's aliased. It's weird, because adding other aliased functions > into dispatch_sanity didn't break the test. > > Marek > > On Wed, Aug 8, 2018

Re: [Mesa-dev] [PATCH 3/4] anv: Use central api generation scripts.

2018-08-08 Thread Dylan Baker
Quoting Eric Engestrom (2018-08-08 03:46:05) > On Tuesday, 2018-08-07 16:49:17 -0700, Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-08-07 16:14:33) > > > > > > anv_extensions_c = custom_target( > > > @@ -36,10 +37,11 @@ anv_extensions_c = custom_target( > > >input : ['anv_extensions_g

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107524 Bug ID: 107524 Summary: Broken packDouble2x32 at llvmpipe Product: Mesa Version: git Hardware: All OS: Linux (All) Status: NEW Severity: normal

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107524 Matwey V. Kornilov changed: What|Removed |Added CC||bri...@vmware.com -- You are rece

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
Thanks. I'll remove the dispatch_sanity change. Marek On Wed, Aug 8, 2018 at 12:07 PM, Ilia Mirkin wrote: > It's not the alias itself that breaks it -- but you can only have one > entry per alias group. > > On Wed, Aug 8, 2018 at 12:03 PM, Marek Olšák wrote: >> Yes, it's aliased. It's weird, be

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 12:04, Emil Velikov wrote: > On 8 August 2018 at 06:42, Marek Olšák wrote: >> From: Marek Olšák >> >> This is needed for exposing the samplerBuffer functions under >> EXT_gpu_shader4. >> >> glTexBufferEXT is defined in glapi, but "make check" fails. >> What am I doing wrong?

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
Hi Juan, On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero wrote: > If color buffer is locked, do not set its wayland buffer to NULL; > otherwise it can not be freed later. It can: see the 'if (i == ARRAY_SIZE(...))' branch inside wl_buffer_release. > This also fixes dEQP-EGL.functional.swap_b

Re: [Mesa-dev] [PATCH v4 2/2] wayland/egl: update surface size on window resize

2018-08-08 Thread Daniel Stone
Hi Juan, On Tue, 7 Aug 2018 at 16:50, Juan A. Suarez Romero wrote: > According to EGL 1.5 spec, section 3.10.1.1 ("Native Window Resizing"): > > "If the native window corresponding to _surface_ has been resized >prior to the swap, _surface_ must be resized to match. _surface_ will >norm

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Dylan Baker
Quoting Emil Velikov (2018-08-08 04:04:51) > On 8 August 2018 at 06:42, Marek Olšák wrote: > > From: Marek Olšák > > > > This is needed for exposing the samplerBuffer functions under > > EXT_gpu_shader4. > > > > glTexBufferEXT is defined in glapi, but "make check" fails. > > What am I doing wrong

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Marek Olšák
On Wed, Aug 8, 2018 at 12:17 PM, Emil Velikov wrote: > On 8 August 2018 at 12:04, Emil Velikov wrote: >> On 8 August 2018 at 06:42, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This is needed for exposing the samplerBuffer functions under >>> EXT_gpu_shader4. >>> >>> glTexBufferEXT is defin

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Juan A. Suarez Romero
On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > Hi Juan, > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > wrote: > > If color buffer is locked, do not set its wayland buffer to NULL; > > otherwise it can not be freed later. > > It can: see the 'if (i == ARRAY_SIZE(...))' branch

Re: [Mesa-dev] [PATCH 0/3] Use GitLab CI to build Mesa

2018-08-08 Thread Daniel Stone
Hi Juan, On Wed, 8 Aug 2018 at 16:45, Juan A. Suarez Romero wrote: > This is a first part of a more complete proposal to use GitLab CI to build and > test Mesa. This first part just adds the required pieces to build Mesa, using > the > different supported tools (meson, autotools, and scons). Th

Re: [Mesa-dev] [PATCH 10/11] mesa: expose EXT_texture_buffer_object

2018-08-08 Thread Emil Velikov
On 8 August 2018 at 17:29, Marek Olšák wrote: > On Wed, Aug 8, 2018 at 12:17 PM, Emil Velikov > wrote: >> On 8 August 2018 at 12:04, Emil Velikov wrote: >>> On 8 August 2018 at 06:42, Marek Olšák wrote: From: Marek Olšák This is needed for exposing the samplerBuffer functions u

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Juan A. Suarez Romero
On Wed, 2018-08-08 at 18:39 +0200, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > Hi Juan, > > > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL; > > > otherwise it c

Re: [Mesa-dev] [PATCH] egl/wayland: do not leak wl_buffer when it is locked

2018-08-08 Thread Daniel Stone
Hi Juan, On Wed, 8 Aug 2018 at 17:40, Juan A. Suarez Romero wrote: > On Wed, 2018-08-08 at 17:21 +0100, Daniel Stone wrote: > > On Thu, 2 Aug 2018 at 10:02, Juan A. Suarez Romero > > wrote: > > > If color buffer is locked, do not set its wayland buffer to NULL; > > > otherwise it can not be fre

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107524 Roland Scheidegger changed: What|Removed |Added CC||airl...@freedesktop.org --- Commen

[Mesa-dev] [Bug 106394] Black Mesa cannot compile shaders because of missing GL_EXT_gpu_shader4

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106394 --- Comment #6 from b...@besd.de --- While the patches allow the non-beta and beta version of Black-Mesa to start, I still get out of memory errors for both. The beta version does this right after you select to start a new game (in the loading g

[Mesa-dev] [PATCH] intel: Switch the order of the 2x MSAA sample positions

2018-08-08 Thread Jason Ekstrand
The Vulkan 1.1.82 spec flipped the order to better match D3D. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/blorp/blorp_blit.c | 11 ++- src/intel/common/gen_sample_positions.h| 8 src/mesa/drivers/dri/i965/brw_multisample_state.h | 8 ++

Re: [Mesa-dev] [PATCH v2 05/11] intel: tools: create libaub

2018-08-08 Thread Rafael Antognolli
Reviewed-by: Rafael Antognolli On Tue, Aug 07, 2018 at 06:35:16PM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/meson.build | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/src/intel/tools/meson.build b/src/in

Re: [Mesa-dev] [PATCH v3 14/48] meson: Make shader-cache a trillean instead of boolean

2018-08-08 Thread Dylan Baker
Quoting Eric Anholt (2018-08-07 10:58:52) > Dylan Baker writes: > > > So that it can be implicitly disabled on windows, where it doesn't > > compile. > > I don't see how this option successfully controls the shader cache being > built. The entire shader cache code in src/util/disk_cache.[ch] is

[Mesa-dev] [PATCH] Revert "intel/nir: Call nir_lower_io_to_scalar_early"

2018-08-08 Thread Jason Ekstrand
Commit 4434591bf56a6b0 caused substantially more URB messages in geometry and tessellation shaders. Before we can really enable this sort of optimization, We either need some way of combining them back together into vectors or we need to do cross-stage vector element elimination without splitting

Re: [Mesa-dev] [PATCH v2 07/11] intel: tools: aub_mem: reuse already mapped ppgtt buffers

2018-08-08 Thread Rafael Antognolli
On Tue, Aug 07, 2018 at 06:35:18PM +0100, Lionel Landwerlin wrote: > When we map a PPGTT buffer into a continous address space of aubinator > to be able to inspect it, we currently add it to the list of BOs to > unmap once we're finished. An optimization we can apply it to look up > that list befor

Re: [Mesa-dev] [PATCH v2 10/11] intel: aubinator_viewer: store urb state during decoding

2018-08-08 Thread Rafael Antognolli
I'm not that familiar with this code yet, so take this review with a grain of salt, but it looks good to me. Reviewed-by: Rafael Antognolli Just a few comments below but nothing really important. On Tue, Aug 07, 2018 at 06:35:21PM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerl

Re: [Mesa-dev] [PATCH v2 11/11] intel: aubinator_viewer: add urb view

2018-08-08 Thread Rafael Antognolli
On Tue, Aug 07, 2018 at 06:35:22PM +0100, Lionel Landwerlin wrote: > This is available through a "Show URB" button on the 3DPRIMITIVE > instructions. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator_viewer.cpp | 75 > src/intel/tools/aubinator_viewer_

Re: [Mesa-dev] [PATCH v3] mesa: enable EXT_render_snorm extension

2018-08-08 Thread Nanley Chery
On Thu, Aug 02, 2018 at 02:14:31PM +0300, Tapani Pälli wrote: > Patch sets additional formats renderable and enables the extension > when OpenGL ES 3.1 is supported. > > v2: instead of dummy_true, have a separate toggle for extension > (Eric Anholt) > > v3: add missing checks, simplify some e

Re: [Mesa-dev] [PATCH v2 07/11] intel: tools: aub_mem: reuse already mapped ppgtt buffers

2018-08-08 Thread Lionel Landwerlin
On 08/08/18 20:07, Rafael Antognolli wrote: On Tue, Aug 07, 2018 at 06:35:18PM +0100, Lionel Landwerlin wrote: When we map a PPGTT buffer into a continous address space of aubinator to be able to inspect it, we currently add it to the list of BOs to unmap once we're finished. An optimization we

Re: [Mesa-dev] [PATCH v3 1/4] nv50/ir: add preliminary support for OP_XMAD

2018-08-08 Thread Karol Herbst
On Mon, Jul 23, 2018 at 12:40 PM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/gallium/drivers/nouveau/codegen/nv50_ir.h | 26 > ++ > .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 18 +-- > .../drivers/nouveau/codegen/nv50_ir_print.cpp

[Mesa-dev] [Bug 107524] Broken packDouble2x32 at llvmpipe

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107524 --- Comment #2 from Dave Airlie --- Having a piglit shader_runner example test for this would be nice, if you had some time to make one. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the b

Re: [Mesa-dev] [PATCH v2 11/11] intel: aubinator_viewer: add urb view

2018-08-08 Thread Lionel Landwerlin
On 08/08/18 22:09, Rafael Antognolli wrote: + /* URB allocation */ + hovered = _Hovered(mouse_pos, window_hovered, alloc_tl, alloc_br); + ImGui::ColorConvertHSVtoRGB((2 * s) * 1.0f / (2 * n_stages), + 1.0f, hovered ? 1.0f : 0.8f, +

Re: [Mesa-dev] [PATCH v2 10/11] intel: aubinator_viewer: store urb state during decoding

2018-08-08 Thread Lionel Landwerlin
On 08/08/18 21:55, Rafael Antognolli wrote: t @@ -790,6 +892,7 @@ aub_viewer_render_batch(struct aub_viewer_decode_ctx *ctx, for (unsigned i = 0; i < ARRAY_SIZE(info_decoders); i++) { if (strcmp(inst_name, info_decoders[i].cmd_name) == 0) { +ctx->stage = info_de

[Mesa-dev] [Bug 107530] [Regression] widgets rendered black in gtk

2018-08-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107530 Bug ID: 107530 Summary: [Regression] widgets rendered black in gtk Product: Mesa Version: 18.1 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH 03/14] mesa: don't include compute resources in MAX_COMBINED_* limits

2018-08-08 Thread Marek Olšák
From: Marek Olšák 5 is the maximum number of shader stages that can be used by 1 execution call at the same time (e.g. a draw call). The limit ensures that each stage can use all of its binding points. Compute is separate and doesn't need the 5x multiplier. --- src/mesa/main/config.h | 22 +

[Mesa-dev] [PATCH 00/14] Adjusting OpenGL limits and constants

2018-08-08 Thread Marek Olšák
Hi, The idea is to expose similar limits as our closed driver. There are also some bug fixes. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 02/14] mesa: bump GL_MAX_ELEMENTS_INDICES and GL_MAX_ELEMENTS_VERTICES

2018-08-08 Thread Marek Olšák
From: Marek Olšák same number as our closed GL driver --- src/mesa/main/config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h index 6a2f766222a..fdf90d8956f 100644 --- a/src/mesa/main/config.h +++ b/src/mesa/main/config.h

[Mesa-dev] [PATCH 01/14] mesa: remove incorrect change for EXT_disjoint_timer_query

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/queryobj.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index 7547fa1bb4d..e97a0138e96 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryobj.c @@ -815,22 +815,21 @@ get_q

[Mesa-dev] [PATCH 06/14] glsl: fix error checking against MAX_UNIFORM_LOCATIONS

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/link_uniforms.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp index 8d3f95fe114..434ecefb289 100644 --- a/src/compiler/glsl/link_uniforms.cpp +++ b/s

[Mesa-dev] [PATCH 08/14] st/mesa: don't include compute resources in "Combined" limits

2018-08-08 Thread Marek Olšák
From: Marek Olšák The combined limits should only include shader stages that can be active at the same time. --- src/mesa/state_tracker/st_extensions.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st

[Mesa-dev] [PATCH 05/14] mesa: make MaxCombinedUniformComponents 64-bit to allow large UBOs

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/main/get_hash_params.py | 12 ++-- src/mesa/main/mtypes.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py index dcfeac39190..ed5328df7cb 100644 --- a/src/m

[Mesa-dev] [PATCH 09/14] st/mesa: fix up uniform limits to be able to expose large UBOs

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 31 +++--- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 5e580aad2e4..1a0c4500c63 100644 --- a/src/mesa/state

[Mesa-dev] [PATCH 13/14] radeonsi: bump MAX_GS_INVOCATIONS

2018-08-08 Thread Marek Olšák
From: Marek Olšák same as the closed driver --- src/gallium/drivers/radeonsi/si_get.c | 4 +++- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 -- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 10/14] tgsi/ureg: don't call tgsi_sanity when it's too slow

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index 92c98c763eb..c1c8851486e 100644 --- a/src/gallium/auxiliary/tgsi/t

[Mesa-dev] [PATCH 04/14] mesa: add ctx->Const.MaxGeometryShaderInvocations

2018-08-08 Thread Marek Olšák
From: Marek Olšák radeonsi wants to report a different value --- src/compiler/glsl/glsl_parser_extras.cpp | 3 ++- src/compiler/glsl/glsl_parser_extras.h | 1 + src/mesa/main/context.c | 1 + src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 11/14] gallium: add PIPE_CAP_MAX_GS_INVOCATIONS

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 3 ++- src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ src/gallium/drivers/i915/i915_screen.c | 3 +++ src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 12/14] gallium: add PIPE_CAP_MAX_SHADER_BUFFER_SIZE

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 3 +++ src/gallium/drivers/freedreno/freedreno_screen.c | 3 +++ src/gallium/drivers/i915/i915_screen.c | 3 +++ src/gallium/drivers/llvmpipe/lp_screen.c

[Mesa-dev] [PATCH 07/14] st/mesa: set ctx->Const.SubPixelBits

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index 1c01495e937..5287dff6703 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/stat

[Mesa-dev] [PATCH 14/14] radeonsi: increase the maximum UBO size to 2 GB

2018-08-08 Thread Marek Olšák
From: Marek Olšák Same as the closed driver. This causes a failure in GL45-CTS.compute_shader.max, which has a trivial bug. --- src/gallium/drivers/radeonsi/si_get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/

[Mesa-dev] [ANNOUNCE] Mesa 18.2.0-rc2

2018-08-08 Thread Andres Gomez
Hello list, The second release candidate for the Mesa 18.2.0 is now available. Currently we have: - 17 queued - 10 nominated (outstanding) - and 0 rejected patches In the current queue we have: Multiple fixes for the broadcom drivers while individual fixes for the swr and nouveau drivers and

[Mesa-dev] [PATCH 1/4] ddebug: implement set_window_rectangles

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/driver_ddebug/dd_context.c | 12 1 file changed, 12 insertions(+) diff --git a/src/gallium/auxiliary/driver_ddebug/dd_context.c b/src/gallium/auxiliary/driver_ddebug/dd_context.c index dd7b3e086cd..a1b6c971e89 100644 --- a/src/gallium/au

[Mesa-dev] [PATCH 4/4] radeonsi: implement EXT_window_rectangles

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- docs/relnotes/18.3.0.html | 1 + src/amd/common/sid.h | 16 src/gallium/drivers/radeonsi/si_blit.c| 4 + src/gallium/drivers/radeonsi/si_get.c | 2 +- src/gallium/drivers/radeonsi/si_gfx_cs.c | 4 +

[Mesa-dev] [PATCH 2/4] noop: implement set_window_rectangles

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/driver_noop/noop_state.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/auxiliary/driver_noop/noop_state.c b/src/gallium/auxiliary/driver_noop/noop_state.c index 80cfae8ad49..11e2c173a37 100644 --- a/src/gallium/auxiliary/driv

[Mesa-dev] [PATCH 3/4] gallium/u_blitter: save/restore window rectangles

2018-08-08 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 10 ++ src/gallium/auxiliary/util/u_blitter.h | 19 +++ 2 files changed, 29 insertions(+) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index a9df71108b4..fc86f

[Mesa-dev] [PATCH 7/8] st/mesa: expose EXT_disjoint_timer_query

2018-08-08 Thread Marek Olšák
From: Marek Olšák same cap as ARB_timer_query, no changes needed, tested by piglit --- docs/relnotes/18.3.0.html | 1 + src/mesa/state_tracker/st_extensions.c | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html index 3d6081708b

[Mesa-dev] [PATCH 4/8] mesa: expose AMD_query_buffer_object

2018-08-08 Thread Marek Olšák
From: Marek Olšák it's a subset of the ARB extension. --- docs/relnotes/18.3.0.html| 1 + src/mesa/main/extensions_table.h | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/relnotes/18.3.0.html b/docs/relnotes/18.3.0.html index cf3bb80ceae..c0132311a25 100644 --- a/docs/relnotes

  1   2   >