On 08/08/18 22:09, Rafael Antognolli wrote:
+         /* URB allocation */
+         hovered = _Hovered(mouse_pos, window_hovered, alloc_tl, alloc_br);
+         ImGui::ColorConvertHSVtoRGB((2 * s) * 1.0f / (2 * n_stages),
+                                     1.0f, hovered ? 1.0f : 0.8f,
+                                     r, g, b);
+         draw_list->AddRectFilled(alloc_tl, alloc_br, ImColor(r, g, b));
+         if (hovered) {
+            ImGui::SetTooltip("%s: start=%u end=%u",
+                              stage_names[s],
+                              stages[s].start,
+                              stages[s].n_entries * stages[s].size);
Maybe you should add stages[s].start to the "end" case? It seems
a little inconsistent right now.

Other than that, and taking into account how much I understand about
imgui, consider this:

Reviewed-by: Rafael Antognolli<rafael.antogno...@intel.com>

Oh indeed, my bad!

-

Lionel

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to