Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

On Fri, 2018-06-15 at 12:47 -0400, Ilia Mirkin wrote: > On Fri, Jun 15, 2018 at 12:36 PM, Dylan Baker wrote: > > I don't even understand why we make these announcements TBH. I have a public > > 18.1-proposed branch that I push to *every weekday*. Anyone can pull that > > branch > > *anytime* to g

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 4:39 GMT+02:00 Timothy Arceri : > This is required for compatibility profile support. --- > src/mesa/main/ff_fragment_shader.cpp | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/ff_fragment_shader.cpp > b/src/mesa/main/ff_fragment_shader.cpp

[Mesa-dev] [Bug 106915] [GLSL] Unused arrays declared without a size should be handled like arrays of size 1.

https://bugs.freedesktop.org/show_bug.cgi?id=106915 --- Comment #7 from Neil Roberts --- The nvidia proprietary driver fails to link that test with the following error message: error: different buffer variables (named a.a[0] and a.s[0]) sharing the same offset within a storage block (named a) be

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #15 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #11) > You have to grab and build renderdoc from > https://github.com/baldurk/renderdoc > > Then, you can do "export ENABLE_VULKAN_RENDERDOC_CAPTURE=1", sta

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > 2018-06-18 4:39 GMT+02:00 Timothy Arceri : > > This is required for compatibility profile support. > > > > --- > > > > src/mesa/main/ff_fragment_shader.cpp | 6 +- > > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > >

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 10:39 GMT+02:00 Iago Toral : > On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > > 2018-06-18 4:39 GMT+02:00 Timothy Arceri : > > This is required for compatibility profile support. > --- > src/mesa/main/ff_fragment_shader.cpp | 6 +- > 1 file changed, 5 insertions(+),

Re: [Mesa-dev] [PATCH] radv: Use less conservative approximation for context rolls.

Reviewed-by: Samuel Pitoiset On 06/17/2018 03:40 AM, Bas Nieuwenhuizen wrote: Drops the number of time we set the scissor by 4x for F1 2017, which results in a consistent performance improvement of about 4%. --- src/amd/vulkan/radv_cmd_buffer.c | 9 ++--- 1 file changed, 6 insertions(+),

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #16 from Samuel Pitoiset --- Unfortunately, I can't replay the trace because it's not the same hardware. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

On 2018-06-16 08:23 AM, Jason Ekstrand wrote: > On Fri, Jun 15, 2018 at 4:44 PM, Eric Anholt wrote: > >> Michel Dänzer writes: >> >>> On 2018-06-15 05:25 PM, Jason Ekstrand wrote: On June 15, 2018 01:14:24 Michel Dänzer wrote: > On 2018-06-15 07:31 AM, Jason Ekstrand wrote: >>

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

On Mon, 2018-06-18 at 10:45 +0200, Gustaw Smolarczyk wrote: > 2018-06-18 10:39 GMT+02:00 Iago Toral : > > On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > > > 2018-06-18 4:39 GMT+02:00 Timothy Arceri : > > > > This is required for compatibility profile support. > > > > --- > > > > sr

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

2018-06-18 11:19 GMT+02:00 Iago Toral : > On Mon, 2018-06-18 at 10:45 +0200, Gustaw Smolarczyk wrote: > > 2018-06-18 10:39 GMT+02:00 Iago Toral : > > > On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: > > > > 2018-06-18 4:39 GMT+02:00 Timothy Arceri : > > > > > This is required for comp

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

On 18/06/18 18:45, Gustaw Smolarczyk wrote: 2018-06-18 10:39 GMT+02:00 Iago Toral >: On Mon, 2018-06-18 at 09:43 +0200, Gustaw Smolarczyk wrote: 2018-06-18 4:39 GMT+02:00 Timothy Arceri mailto:tarc...@itsqueeze.com>>: This is required for compatibility p

Re: [Mesa-dev] [PATCH] anv: Use a single global API patch version

I was wondering whether we should pick up the patch version from the registry. Anyway : Reviewed-by: Lionel Landwerlin On 18/06/18 00:29, Jason Ekstrand wrote: The Vulkan API has only one patch version shared among all of the major.minor versions. We should also advertise the same patch vers

Re: [Mesa-dev] [PATCH] mesa: add better GLSL override support for compat profile

On Mon, 2018-06-18 at 12:51 +1000, Timothy Arceri wrote: > --- > src/mesa/main/version.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c > index 1bdccf4a1df..0d2597a61f4 100644 > --- a/src/mesa/main/version.c > +++

Re: [Mesa-dev] [PATCH] mesa: add better GLSL override support for compat profile

On 18/06/18 19:38, Iago Toral wrote: On Mon, 2018-06-18 at 12:51 +1000, Timothy Arceri wrote: --- src/mesa/main/version.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c index 1bdccf4a1df..0d2597a61f4 100644 --- a/

[Mesa-dev] [Bug 106843] Cannot build osmesa with GLES support using Scons and MSVC

https://bugs.freedesktop.org/show_bug.cgi?id=106843 Alex Granni changed: What|Removed |Added Severity|major |critical -- You are receiving this mail

[Mesa-dev] [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere

We should we have all the kinks worked out and full-ppgtt now works reliably on gen7 (Ivybridge, Valleyview/Baytrail and Haswell). If we can let userspace have full control over their own ppgtt, it makes softpinning far more effective, in turn making GPU dispatch far more efficient and more secure

[Mesa-dev] [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses

We believe we have all the kinks worked out, even for the early Valleyview devices, for whom we currently disable all ppgtt. References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3") Signed-off-by: Chris Wilson Cc: Ville Syrjälä Cc: Joonas Lahtinen Reviewed-by: Joonas Lahtinen

Re: [Mesa-dev] [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere

Quoting Chris Wilson (2018-06-18 11:10:23) > We should we have all the kinks worked out and full-ppgtt now works > reliably on gen7 (Ivybridge, Valleyview/Baytrail and Haswell). If we can > let userspace have full control over their own ppgtt, it makes softpinning > far more effective, in turn maki

[Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

As of 66673bef941af344314f ("mesa: Unconditionally enable floating-point textures"), the `bind` argument is no longer used, and the format check is now a simple enum range check, so inline it and remove the unnecessary argument from callers. Cc: Timothy Arceri Cc: Matt Turner Cc: Ian Romanick S

Re: [Mesa-dev] [PATCH] i965: Fix fractional viewport coordinates handling on gen8+

Could anyone review this patch? Here is a Wine dev reporting similar bug to Nvidia . Test in Wine source to enable a workaround for this issue

[Mesa-dev] [PATCH mesa] mesa: add missing return in error path

Fixes: 67f40dadaadacd90 "mesa: add support for ARB_sample_locations" Cc: Rhys Perry Cc: Brian Paul Signed-off-by: Eric Engestrom --- src/mesa/main/fbobject.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 5d7e

Re: [Mesa-dev] [PATCH] r600: fix copy/paste bug for sampleMaskIn workaround

On Friday, 2018-06-15 23:38:58 +0200, srol...@vmware.com wrote: > From: Roland Scheidegger > > The sampleMaskIn workaround (b936f4d1ca0d2ab1e828ff6a6e617f12469687fa) > tries to figure out if the shader is running at per-sample frequency, but > there's a typo bug so it will only recognize per-samp

[Mesa-dev] [Bug 106915] [GLSL] Unused arrays declared without a size should be handled like arrays of size 1.

https://bugs.freedesktop.org/show_bug.cgi?id=106915 Eleni Maria Stea changed: What|Removed |Added CC||es...@igalia.com --- Comment #8 from

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

TGSI already has a invariant field on declarations, we are running into a bug with virgl because st_glsl_to_tgsi completely drops the invariant flag on the floor when it comes to declarations (tho precise is added to the ops). But virgl can't express precise ops (only invariant and precise declarat

Re: [Mesa-dev] [PATCH] r600: fix copy/paste bug for sampleMaskIn workaround

Am 18.06.2018 um 12:43 schrieb Eric Engestrom: > On Friday, 2018-06-15 23:38:58 +0200, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> The sampleMaskIn workaround (b936f4d1ca0d2ab1e828ff6a6e617f12469687fa) >> tries to figure out if the shader is running at per-sample frequency, but >>

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #17 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #16) > Unfortunately, I can't replay the trace because it's not the same hardware. I want to help you, but tell me please how I can do it? Regards. -- You

Re: [Mesa-dev] [PATCH] r600: fix copy/paste bug for sampleMaskIn workaround

On Monday, 2018-06-18 13:07:12 +0200, Roland Scheidegger wrote: > Am 18.06.2018 um 12:43 schrieb Eric Engestrom: > > On Friday, 2018-06-15 23:38:58 +0200, srol...@vmware.com wrote: > >> From: Roland Scheidegger > >> > >> The sampleMaskIn workaround (b936f4d1ca0d2ab1e828ff6a6e617f12469687fa) > >> t

Re: [Mesa-dev] [PATCH v2 1/5] util: manually extract the program name from program_invocation_name

On Friday, 2018-06-15 12:56:04 +1000, Timothy Arceri wrote: > On 14/06/18 19:40, Eric Engestrom wrote: > > > On Thursday, 2018-06-14 11:00:21 +1000, Timothy Arceri wrote: > > > Glibc has the same code to get program_invocation_short_name. However > > > for some reason the short name gets mangled f

Re: [Mesa-dev] [PATCH v2 1/5] util: manually extract the program name from program_invocation_name

On Monday, 2018-06-18 12:37:59 +0100, Eric Engestrom wrote: > On Friday, 2018-06-15 12:56:04 +1000, Timothy Arceri wrote: > > On 14/06/18 19:40, Eric Engestrom wrote: > > > > > On Thursday, 2018-06-14 11:00:21 +1000, Timothy Arceri wrote: > > > > Glibc has the same code to get program_invocation_s

Re: [Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

Reviewed-by: Timothy Arceri On 18/06/18 20:15, Eric Engestrom wrote: As of 66673bef941af344314f ("mesa: Unconditionally enable floating-point textures"), the `bind` argument is no longer used, and the format check is now a simple enum range check, so inline it and remove the unnecessary argumen

[Mesa-dev] [Bug 106843] Cannot build osmesa with GLES support using Scons and MSVC

https://bugs.freedesktop.org/show_bug.cgi?id=106843 --- Comment #4 from Eric Engestrom --- Hi Alex, First off, note that I don't know anything about scons, msvc or windows, but Dylan has been adding Windows support to Meson (https://lists.freedesktop.org/archives/mesa-dev/2018-June/197325.html).

[Mesa-dev] [PATCH kmscube 1/2] gbm: fix fallback for drivers that don't support modifiers

Gallium drivers that do not implement resource_create_with_modifiers() will fail gbm_surface_create_with_modifiers() so fall back to the old way. Fixes: 4f7cec0 Use weak functions to handle lack of gbm modifiers Signed-off-by: Rob Clark --- common.c | 5 - 1 file changed, 4 insertions(+), 1

[Mesa-dev] [PATCH kmscube 2/2] add MSAA

Signed-off-by: Rob Clark --- common.c | 5 +++-- common.h | 12 ++-- cube-smooth.c | 4 ++-- cube-tex.c| 4 ++-- cube-video.c | 4 ++-- kmscube.c | 12 +--- 6 files changed, 24 insertions(+), 17 deletions(-) diff --git a/common.c b/common.c index 931fc06..d

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

On Mon, Jun 18, 2018 at 12:06:42PM +0100, Jakob Bornecrantz wrote: > TGSI already has a invariant field on declarations, we are running > into a bug with virgl because st_glsl_to_tgsi completely drops the > invariant flag on the floor when it comes to declarations (tho precise > is added to the ops

Re: [Mesa-dev] [PATCH mesa] mesa: add missing return in error path

Reviewed-by: Iago Toral Quiroga On Mon, 2018-06-18 at 11:40 +0100, Eric Engestrom wrote: > Fixes: 67f40dadaadacd90 "mesa: add support for > ARB_sample_locations" > Cc: Rhys Perry > Cc: Brian Paul > Signed-off-by: Eric Engestrom > --- > src/mesa/main/fbobject.c | 4 +++- > 1 file changed,

Re: [Mesa-dev] [PATCH] Plumb invariant output attrib thru TGSI

On Mon, Jun 18, 2018 at 1:06 PM Elie Tournier wrote: > > On Mon, Jun 18, 2018 at 12:06:42PM +0100, Jakob Bornecrantz wrote: > > TGSI already has a invariant field on declarations, we are running > > into a bug with virgl because st_glsl_to_tgsi completely drops the > > invariant flag on the floor

[Mesa-dev] [PATCH] virgl: Remove debugging left-overs

Some fprintfs were probably left unintentionally a few years ago and are a bit of a nuisance. Signed-off-by: Tomeu Vizoso Cc: Signed-off-by: Rob Herring Fixes: 2d3301e4d513 ("virgl: fix reference counting of prime handles") --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 -- 1 file chan

[Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

We use floating-points for viewport bounds so VIEWPORT_SUBPIXEL_BITS should reflect this. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105975 Signed-off-by: Danylo Piliaiev --- src/mesa/drivers/dri/i965/brw_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

RADV now requires LLVM 5.0 or greater, and thus we can't build dist tarball because swr requires LLVM 4.0. Let's bump required LLVM to 5.0 in swr too. Fixes: f9eb1ef870 ("amd: remove support for LLVM 4.0") Cc: George Kyriazis Cc: Tim Rowley Cc: Emil Velikov Cc: Dylan Baker Cc: Eric Engestrom

Re: [Mesa-dev] [PATCH] i965: Advertise 8 bits subpixel precision for viewport bounds on gen6+

Hey Danylo, Thanks for this patch. I'm not really an expert here but my understanding is that it should reflect the number of bits in fixed point precision. We use 32bits floats in the packets sent to the hardware. Quoting the spec : "If the implementation truely has floating point viewport bo

Re: [Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

On Mon, Jun 18, 2018 at 3:15 AM Eric Engestrom wrote: > > As of 66673bef941af344314f ("mesa: Unconditionally enable floating-point > textures"), the `bind` argument is no longer used, and the format check > is now a simple enum range check, so inline it and remove the > unnecessary argument from c

[Mesa-dev] [PATCH 2/2] ac/surface: Set compressZ for stencil-only surfaces.

We HTILE compress stencil-only surfaces too. CC: 18.1 --- src/amd/common/ac_surface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 6600ff6b7ef..618b755afc7 100644 --- a/src/amd/common/ac_surface.c +++ b/src/am

[Mesa-dev] [PATCH 1/2] amd/addrlib: Use correct tile index for S8 on SI.

Tile index 3 is "16 bpp depth PRT (non-MSAA), don't support uncompressed depth" while tile index 0 is "non-AA compressed depth or any stencil" per the comments at the top of the file. On my Cape Verde this caused assertions due to the bank height of tile index 3 being too low. (2 while needs to be

Re: [Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

On Monday, 2018-06-18 07:31:49 -0700, Matt Turner wrote: > On Mon, Jun 18, 2018 at 3:15 AM Eric Engestrom > wrote: > > > > As of 66673bef941af344314f ("mesa: Unconditionally enable floating-point > > textures"), the `bind` argument is no longer used, and the format check > > is now a simple enum

[Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

Tile index 3 is "16 bpp depth PRT (non-MSAA), don't support uncompressed depth" while tile index 0 is "non-AA compressed depth or any stencil" per the comments at the top of the file. On my Cape Verde this caused assertions due to the bank height of tile index 3 being too low. (2 while needs to be

[Mesa-dev] [PATCH] freedreno: add initial a20x support

the bare minimum to get a20x running with kmscube and some glmark2 scenes: different CP_DRAW_INDX format and the different clear color register Signed-off-by: Jonathan Marek --- src/gallium/drivers/freedreno/a2xx/fd2_draw.c | 15 +++-- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 10 +

[Mesa-dev] [PATCH] freedreno: a2xx: fix clear color

the format of the CLEAR_COLOR register doesn't depend on the target format this fixes clear color when rendering to 32-bit RGBA and 16-bit targets Signed-off-by: Jonathan Marek --- src/gallium/drivers/freedreno/a2xx/fd2_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH] swr: bump minimum supported LLVM version to 5.0

On Monday, 2018-06-18 16:23:41 +0200, Juan A. Suarez Romero wrote: > RADV now requires LLVM 5.0 or greater, and thus we can't build dist > tarball because swr requires LLVM 4.0. > > Let's bump required LLVM to 5.0 in swr too. > > Fixes: f9eb1ef870 ("amd: remove support for LLVM 4.0") > Cc: George

[Mesa-dev] [Bug 106955] Mesa 18.1.2 not tagged in git

https://bugs.freedesktop.org/show_bug.cgi?id=106955 Bug ID: 106955 Summary: Mesa 18.1.2 not tagged in git Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: minor Priority:

Re: [Mesa-dev] [PATCH mesa] radv: fix reported number of available VGPRs

Reviewed-by: Alex Smith On 15 June 2018 at 17:52, Eric Engestrom wrote: > It's a bit late to round up after an integer division. > > Fixes: de889794134e6245e08a2 "radv: Implement VK_AMD_shader_info" > Cc: Alex Smith > Signed-off-by: Eric Engestrom > --- > src/amd/vulkan/radv_shader.c | 2 +-

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

Do you need this if you set compressZ = true for stencil? Marek On Mon, Jun 18, 2018 at 11:00 AM, Bas Nieuwenhuizen wrote: > Tile index 3 is "16 bpp depth PRT (non-MSAA), don't support > uncompressed depth" while tile index 0 is "non-AA compressed depth > or any stencil" per the comments at the

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: > Do you need this if you set compressZ = true for stencil? Technically not, then you don't hit the path anymore. Anyway even though neither AMDVLK or RADV anymore if we do that, it still bugged me that the index is wrong. - Bas > > Marek > >

Re: [Mesa-dev] [PATCH] anv: Use a single global API patch version

On Mon, Jun 18, 2018 at 2:33 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > I was wondering whether we should pick up the patch version from the > registry. > I've thought about that. However, I like the manual step of someone saying "Yes, I've been paying attention and I'm pret

[Mesa-dev] [Bug 106420] segfault in dri2_allocate_textures(), radeonsi_dri.so 18.1-rc3 using mpv

https://bugs.freedesktop.org/show_bug.cgi?id=106420 Axel Rohde changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

On 2018-06-14 04:54, Tomasz Figa wrote: On Thu, Jun 14, 2018 at 4:14 AM Rob Herring wrote: On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote: On 13 June 2018 at 20:45, Rob Herring wrote: +Amit and John On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss wrote: This patch both adds support

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

Quoting Juan A. Suarez Romero (2018-06-18 00:22:02) > On Fri, 2018-06-15 at 12:47 -0400, Ilia Mirkin wrote: > > On Fri, Jun 15, 2018 at 12:36 PM, Dylan Baker wrote: > > > I don't even understand why we make these announcements TBH. I have a > > > public > > > 18.1-proposed branch that I push to *

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

On Mon, 2018-06-18 at 09:56 -0700, Dylan Baker wrote: > Quoting Juan A. Suarez Romero (2018-06-18 00:22:02) > > On Fri, 2018-06-15 at 12:47 -0400, Ilia Mirkin wrote: > > > On Fri, Jun 15, 2018 at 12:36 PM, Dylan Baker wrote: > > > > I don't even understand why we make these announcements TBH. I ha

[Mesa-dev] [PATCH 00/19] intel: extract performance query code

Hi all, This series can be broken in 3 parts : - Making the performace query code API agnostic so that it can be reused on other APIs (patches 1 -> 10) - Adding a new pma stall metric on gen 8 & 9 (patches 17) - Adding performance query support on gen 11 (patch 19) Cheers

[Mesa-dev] [PATCH 06/19] i965: move brw_timebase_scale to device info

Signed-off-by: Lionel Landwerlin --- src/intel/dev/gen_device_info.h | 7 +++ src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/brw_performance_query.c | 8 ++-- .../dri/i965/brw_performance_query_mdapi.c| 6 +++--- src/mesa/d

[Mesa-dev] [PATCH 01/19] intel: genxml: add mask fields for INSTPM/CS_DEBUG_MODE2 registers

Those 2 registers have masks on the upper 16bits of field values that should be applied in HW. Signed-off-by: Lionel Landwerlin --- src/intel/genxml/gen10.xml | 3 +++ src/intel/genxml/gen11.xml | 3 +++ src/intel/genxml/gen7.xml | 4 src/intel/genxml/gen75.xml | 4 src/intel/genxml/g

[Mesa-dev] [PATCH 03/19] i965: extract performance query metrics

We would like to reuse performance query metrics in other APIs. Let's make the query code dealing with the processing of raw counters into human readable values API agnostic. Signed-off-by: Lionel Landwerlin --- src/intel/Android.mk | 1 + src/intel/Android.perf.mk

[Mesa-dev] [PATCH 04/19] i965: move mdapi data structure to intel/perf

We'll want to reuse those structures later on. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.sources| 3 +- src/intel/perf/gen_perf_mdapi.h | 119 ++ .../dri/i965/brw_performance_query_mdapi.c| 103 ++- 3 files changed

[Mesa-dev] [PATCH 07/19] i965: move mdapi result data format to intel/perf

We want to reuse this in Anv. Signed-off-by: Lionel Landwerlin --- src/intel/Makefile.sources| 3 +- src/intel/perf/gen_perf_mdapi.c | 116 ++ src/intel/perf/gen_perf_mdapi.h | 8 ++ src/intel/perf/meson.build

[Mesa-dev] [PATCH 05/19] i965: move OA accumulation code to intel/perf

We'll want to reuse this in our Vulkan extension. Signed-off-by: Lionel Landwerlin --- src/intel/perf/gen_perf.c | 135 ++ src/intel/perf/gen_perf.h | 81 ++- .../drivers/dri/i965/brw_performance_query.c | 134 +++-- .

[Mesa-dev] [PATCH 14/19] intel: perf: kbl: add pma stall metric

Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-kblgt2.xml | 103 ++- src/intel/perf/oa-kblgt3.xml | 103 ++- 2 files changed, 204 insertions(+), 2 deletions(-) diff --git a/src/intel/perf/oa-kblgt2.xml b/src/intel/perf/oa-kb

[Mesa-dev] [PATCH 02/19] i965: store device revision in gen_device_info

Signed-off-by: Lionel Landwerlin --- src/intel/dev/gen_device_info.h | 1 + src/mesa/drivers/dri/i965/brw_performance_query.c | 3 +-- src/mesa/drivers/dri/i965/intel_screen.c | 4 +++- src/mesa/drivers/dri/i965/intel_screen.h | 3 --- 4 files changed, 5 insert

[Mesa-dev] [PATCH 13/19] intel: perf: skl: add pma stall metric

Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-sklgt2.xml | 103 ++- src/intel/perf/oa-sklgt3.xml | 103 ++- src/intel/perf/oa-sklgt4.xml | 103 ++- 3 files changed, 306 insertions(+), 3 deleti

[Mesa-dev] [PATCH 09/19] intel/perf: stub gen10/11 missing definitions

--- src/intel/perf/gen_perf_mdapi.h | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/perf/gen_perf_mdapi.h b/src/intel/perf/gen_perf_mdapi.h index a2f8066dcf4..45fe171b030 100644 --- a/src/intel/perf/gen_perf_mdapi.h +++ b/src/intel/perf/gen_perf_mdapi.h @@ -108,6 +108,10 @@ struc

[Mesa-dev] [PATCH 15/19] intel: perf: cfl: add pma stall metric

Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-cflgt2.xml | 103 ++- src/intel/perf/oa-cflgt3.xml | 103 ++- 2 files changed, 204 insertions(+), 2 deletions(-) diff --git a/src/intel/perf/oa-cflgt2.xml b/src/intel/perf/oa-cf

[Mesa-dev] [PATCH 16/19] intel: perf: bxt: add pma stall metric

Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-bxt.xml | 113 +- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git a/src/intel/perf/oa-bxt.xml b/src/intel/perf/oa-bxt.xml index 5b18369b2cb..db018a3d62b 100644 --- a/src/intel/perf/oa-bxt.xml +

[Mesa-dev] [PATCH 08/19] i965: move mdapi guid into intel/perf

One more thing we want to share between the different APIs. Signed-off-by: Lionel Landwerlin --- src/intel/perf/gen_perf_mdapi.h | 3 +++ src/mesa/drivers/dri/i965/brw_performance_query_mdapi.c | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/in

[Mesa-dev] [PATCH 12/19] intel: perf: bdw: add pma stall metric

Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-bdw.xml | 203 +- 1 file changed, 202 insertions(+), 1 deletion(-) diff --git a/src/intel/perf/oa-bdw.xml b/src/intel/perf/oa-bdw.xml index 258fcacfd59..714a1f08ea7 100644 --- a/src/intel/perf/oa-bdw.xml +

[Mesa-dev] [PATCH 18/19] intel: perf: chv: fixup counter names

No functional changes, just cleaning up the names of the counters. Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-chv.xml | 50 +++ 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/intel/perf/oa-chv.xml b/src/intel/perf/oa-chv.xml in

[Mesa-dev] [PATCH 11/19] intel: perf: update HSW configuration

One register that was in the configuration turned out to be IVB specific. Let's just drop it. Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-hsw.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/perf/oa-hsw.xml b/src/intel/perf/oa-hsw.xml index 861cc1212

[Mesa-dev] [PATCH 17/19] intel: perf: glk: add pma stall metric

Signed-off-by: Lionel Landwerlin --- src/intel/perf/oa-glk.xml | 113 +- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git a/src/intel/perf/oa-glk.xml b/src/intel/perf/oa-glk.xml index 68fcd2d6dde..e3da757f46f 100644 --- a/src/intel/perf/oa-glk.xml +

[Mesa-dev] [PATCH 10/19] i965: perf: add mdapi pipeline statistics queries on gen10/11

The Gen10+ expected format adds an additional counter which we can't disclose yet. We can still make the size of the expected query result match. Signed-off-by: Lionel Landwerlin --- src/intel/perf/gen_perf_mdapi.h| 1 + .../drivers/dri/i965/brw_performance_query_mdapi.c

Re: [Mesa-dev] [PATCH 00/19] intel: extract performance query code

I forgot that the last patch won't make it (too big). The branch is here : https://github.com/djdeath/mesa/tree/wip/djdeath/perf-extract Cheers, - Lionel On 18/06/18 18:39, Lionel Landwerlin wrote: Hi all, This series can be broken in 3 parts : - Making the performace query code API

Re: [Mesa-dev] [PATCH shaderdb] run: shader program file created via GetProgramBinary (v5)

On Wed, May 23, 2018 at 3:12 PM Dongwon Kim wrote: > > Thanks, Matt!! > I am glad to see it is finally merged. By the way, not sure if you > saw this patch. > > [PATCH shaderdb] run: handling binding of attribute variable name (v2) > https://lists.freedesktop.org/archives/mesa-dev/2018-March/19017

[Mesa-dev] [Bug 106915] [GLSL] Unused arrays declared without a size should be handled like arrays of size 1.

https://bugs.freedesktop.org/show_bug.cgi?id=106915 --- Comment #9 from Ian Romanick --- Okay... this doesn't work on any desktop implementation of GLSL. In previous cases like this we have decided we have decided that the spec is either unclear or wrong. Either way, please submit a Khronos spe

Re: [Mesa-dev] [PATCH] virgl: Remove debugging left-overs

On 18 June 2018 at 22:50, Tomeu Vizoso wrote: > Some fprintfs were probably left unintentionally a few years ago and are > a bit of a nuisance. > > Signed-off-by: Tomeu Vizoso > Cc: Signed-off-by: Rob Herring > Fixes: 2d3301e4d513 ("virgl: fix reference counting of prime handles") Reviewed-by:

Re: [Mesa-dev] [PATCH mesa] meson: fix i965/anv/isl genX static lib names

Quoting Eric Engestrom (2018-06-15 04:15:31) > Shouldn't make any functional difference, just that `liblibanv_gen90.a` > will now be called `libanv_gen90.a`. > > Fixes: 3218056e0eb375eeda470 "meson: Build i965 and dri stack" > Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan drive

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

On Mon, Jun 18, 2018 at 12:12 PM, Bas Nieuwenhuizen wrote: > On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: > > Do you need this if you set compressZ = true for stencil? > > Technically not, then you don't hit the path anymore. Anyway even > though neither AMDVLK or RADV anymore if we do th

Re: [Mesa-dev] [PATCH mesa] gallium: simplify util_format_is_supported()

The function can be removed completely, because it doesn't do anything now. Marek On Mon, Jun 18, 2018 at 10:55 AM, Eric Engestrom wrote: > On Monday, 2018-06-18 07:31:49 -0700, Matt Turner wrote: > > On Mon, Jun 18, 2018 at 3:15 AM Eric Engestrom > wrote: > > > > > > As of 66673bef941af344314

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

On Mon, Jun 18, 2018 at 10:39 PM, Marek Olšák wrote: > On Mon, Jun 18, 2018 at 12:12 PM, Bas Nieuwenhuizen > wrote: >> >> On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: >> > Do you need this if you set compressZ = true for stencil? >> >> Technically not, then you don't hit the path anymore.

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] ac/surface: Set compressZ for stencil-only surfaces.

Reviewed-by: Marek Olšák Marek On Mon, Jun 18, 2018 at 10:32 AM, Bas Nieuwenhuizen wrote: > We HTILE compress stencil-only surfaces too. > > CC: 18.1 > --- > src/amd/common/ac_surface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_surface.c b/src

Re: [Mesa-dev] [PATCH] radeonsi: enable OpenGL 3.3 compat profile

Reviewed-by: Marek Olšák Marek On Mon, Jun 18, 2018 at 1:29 AM, Timothy Arceri wrote: > Cc: Marek Olšák > --- > > This is intended to apply on top of: > https://patchwork.freedesktop.org/patch/229981/ > > All the high importance pieces are now implemented and > we have a reasonable nu

Re: [Mesa-dev] [PATCH] mesa: add ff fragment shader support for geom and tess shaders

Reviewed-by: Marek Olšák Marek On Sun, Jun 17, 2018 at 10:39 PM, Timothy Arceri wrote: > This is required for compatibility profile support. > --- > src/mesa/main/ff_fragment_shader.cpp | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/main/ff_fragment_sh

Re: [Mesa-dev] [PATCH v2 1/2] amd/addrlib: Use correct tile index for S8 on SI.

On Mon, Jun 18, 2018 at 4:41 PM, Bas Nieuwenhuizen wrote: > On Mon, Jun 18, 2018 at 10:39 PM, Marek Olšák wrote: > > On Mon, Jun 18, 2018 at 12:12 PM, Bas Nieuwenhuizen > > wrote: > >> > >> On Mon, Jun 18, 2018 at 6:08 PM, Marek Olšák wrote: > >> > Do you need this if you set compressZ = true

Re: [Mesa-dev] [PATCH] tgsi: add some atomic opcodes to tgsi_opcode_infer_type

Reviewed-by: Marek Olšák Marek On Thu, Jun 14, 2018 at 7:35 PM, Gurchetan Singh < gurchetansi...@chromium.org> wrote: > We don't have cases for atomic types, some of which are explicitly > signed or unsigned. > > The other opcodes could have uint or int return types, based on the > sources. >

Re: [Mesa-dev] [PATCH v3 1/2] gallium: add scalar isa shader cap

Reviewed-by: Marek Olšák Marek On Fri, Jun 15, 2018 at 6:29 AM, Christian Gmeiner < christian.gmei...@gmail.com> wrote: > v1 -> v2: > - nv30 is _NOT_ scalar as suggested by Ilia Mirkin. > - Change from a screen cap to a shader cap as suggested >by Eric Anholt. > - radeonsi is scalar as

Re: [Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

What about non-sRGB formats? Marek On Wed, May 23, 2018 at 4:54 AM, Tomeu Vizoso wrote: > When Mesa itself implements ETC2 decompression, it currently > decompresses to formats in the GL_BGRA component order. > > That can be problematic for drivers which cannot upload the texture data > as GL_B

Re: [Mesa-dev] [PATCH 2/9] intel/tools/aubinator: aubinate ppgtt aubs

Hi Lionel, I've been going through the patch and I think the content so far is mostly fine. However, it has a lot of things going on for a single patch IMHO. I see changes for the execution list submission port, ppgtt, using the RB tree for ggtt too, etc... It definitely make it more painful to r

Re: [Mesa-dev] [PATCH 7/9] intel: aubinator: move address masking

Patches 4-7 are: Reviewed-by: Rafael Antognolli On Thu, Jun 14, 2018 at 06:11:43PM +0100, Lionel Landwerlin wrote: > The Masking is only needed for entry matching. > > Signed-off-by: Lionel Landwerlin > --- > src/intel/tools/aubinator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions

Re: [Mesa-dev] [PATCH] nir: add pass to move load_const

On 06/11/2018 08:23 AM, Rob Clark wrote: > Run this pass late (after opt loop) to move load_const instructions back > into the basic blocks which use the result, in cases where a load_const > is only consumed in a single block. > > This helps reduce register usage in cases where the backend driver

Re: [Mesa-dev] [PATCH] nir: evaluate if condition uses inside the if branches

On 06/17/2018 05:15 PM, Timothy Arceri wrote: > Since we know what side of the branch we ended up on we can just > replace the use with a constant. > > All helped shaders are from Unreal Engine 4 besides one shader from > Dirt Showdown. > > shader-db results SKL: > > total instructions in shared

Re: [Mesa-dev] [PATCH] [RFC] i965/blit: bump some limits to 64k

On Thu, Jun 14, 2018 at 07:50:54PM +0100, Chris Wilson wrote: > Quoting Nanley Chery (2018-06-14 19:46:09) > > On Thu, Jun 14, 2018 at 10:01:18AM -0700, Nanley Chery wrote: > > > On Thu, Jun 14, 2018 at 04:18:30PM +0300, Martin Peres wrote: > > > > This fixes screenshots using 8k+ wide display setu

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

Jordan's version is awesome. But in general most people are concerned that WebGL will crash browsers. One idea is to look into using three.js, which is a front-end library for web graphics. It's backed by multiple frameworks including WebGL. On Sun, Jun 17, 2018, 9:23 PM Jordan Justen wrote:

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

This looks like a useful check for WebGL compatibility: https://threejs.org/docs/index.html#manual/introduction/WebGL-compatibility-check On Mon, Jun 18, 2018, 3:50 PM Laura Ekstrand wrote: > Jordan's version is awesome. But in general most people are concerned > that WebGL will crash browsers.

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

Not sure how much voting power I have, but I really like Erik's version at https://codepen.io/kusma/pen/vrXppL It uses CSS3 animation on hover, so it's pretty low impact. Some slight cleverness could even include a fallback for a browser that doesn't support SVG. IMO solutions like three.js and

  1   2   >