[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #5 from Tapani Pälli --- (In reply to Tapani Pälli from comment #4) > I've noticed that if I skip uniform removal in opt_dead_code (even builtin > uniforms), then this test passes. I have no idea why this is though. I have > been run

Re: [Mesa-dev] [PATCH] anv: reduce maxFragmentInputComponents

2018-06-14 Thread Samuel Iglesias Gonsálvez
This patch is still unreviewed. Sam On 29/05/18 09:07, Samuel Iglesias Gonsálvez wrote: > If the application asks for the maximum number of fragment input > components (128), use all of them plus some builtins that are > passed in the VUE, then we exceed the maximum number of used VUE > slots (3

Re: [Mesa-dev] [PATCH v3 3/3] egl/android: Add DRM node probing and filtering

2018-06-14 Thread Amit Pundir
On 13 June 2018 at 20:45, Rob Herring wrote: > > +Amit and John > > On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss > wrote: > > This patch both adds support for probing & filtering DRM nodes > > and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD > > gralloc call. > > > > Currently

Re: [Mesa-dev] [PATCH] anv: reduce maxFragmentInputComponents

2018-06-14 Thread Jason Ekstrand
Makes sense. Reviewed-by: Jason Ekstrand On Tue, May 29, 2018 at 12:07 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > If the application asks for the maximum number of fragment input > components (128), use all of them plus some builtins that are > passed in the VUE, then we exc

[Mesa-dev] [Bug 106807] Failed to parse macro "#line"

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106807 --- Comment #2 from Juan A. Suarez --- As Kenneth said, Khronos voted to consider #line with an expression as undefined behaviour, and thus these tests were removed https://github.com/KhronosGroup/VK-GL-CTS/commit/4ff5a922a15bcdb93e59313221033b

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@lis

Re: [Mesa-dev] [PATCH] radv: Fix output for sparse MRTs.

2018-06-14 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 06/13/2018 11:35 PM, Bas Nieuwenhuizen wrote: We need to init the cb_shader_format correctly with the changed col_format, so this moves the col_format adjustment to before the adjustment to before the cb_shader_mask gets generated. Fixes: 06d3c650980 "radv: fix

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-14 Thread Michel Dänzer
On 2018-06-13 10:26 PM, Jason Ekstrand wrote: > The current BO cache puts BOs back into the recycle bucket the moment the > refcount hits zero. If the BO is busy, we just don't re-use it until it > isn't or we re-use it for a render target which we assume will be used > first for drawing. This pa

[Mesa-dev] [PATCH] radv: allow RADV_PERFTEST=dccmsaa on GFX9

2018-06-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5936b43093..e7fc45ef35 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_devi

[Mesa-dev] [Bug 105396] tc compatible htile sets depth of htiles of discarded fragments to 1.0

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105396 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 1/5] util: manually extract the program name from program_invocation_name

2018-06-14 Thread Eric Engestrom
On Thursday, 2018-06-14 11:00:21 +1000, Timothy Arceri wrote: > Glibc has the same code to get program_invocation_short_name. However > for some reason the short name gets mangled for some wine apps. > > For example with Google Earth VR I get: > > program_invocation_name: > "/home/tarceri/.local/

[Mesa-dev] [PATCH] glsl: serialize data from glTransformFeedbackVaryings

2018-06-14 Thread Tapani Pälli
While XFB has been enabled for cache, we did not serialize enough data for the whole API to work (such as glGetProgramiv). Fixes: 6d830940f7 "Allow shader cache usage with transform feedback" Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- src/compil

[Mesa-dev] [Bug 106903] radv: Fragment shader output goes to wrong attachments when render targets are sparse

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106903 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #6 from Tapani Pälli --- Fix proposal sent here: https://lists.freedesktop.org/archives/mesa-dev/2018-June/197678.html -- You are receiving this mail because: You are the QA Contact for the bug._

[Mesa-dev] [Bug 106915] [GLSL] Unused arrays declared without a size should be handled like arrays of size 1.

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106915 Bug ID: 106915 Summary: [GLSL] Unused arrays declared without a size should be handled like arrays of size 1. Product: Mesa Version: unspecified Hardware: All

[Mesa-dev] [Bug 106915] [GLSL] Unused arrays declared without a size should be handled like arrays of size 1.

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106915 Neil Roberts changed: What|Removed |Added CC||nrobe...@igalia.com -- You are receivin

[Mesa-dev] [PATCH 2/3] mesa: add a space between headers and source (trivial)

2018-06-14 Thread Tapani Pälli
There used to be one and it looks like it was removed by eb63640c1d. Signed-off-by: Tapani Pälli --- src/mesa/main/program_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c index 41024d68ce..fedd1f183c 100644 --- a/

[Mesa-dev] [PATCH 3/3] i965: small cleanup in blorp debug printing output (trivial)

2018-06-14 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/drivers/dri/i965/brw_blorp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 8c6d77e1b7..5f99e51bc2 100644 --- a/src/mesa/drivers/dri/i965/brw_blorp.c

[Mesa-dev] [PATCH 1/3] features.txt: mark some extensions as done

2018-06-14 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- docs/features.txt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index b32606d223..423b03a9a9 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -322,12 +322,14 @@ Khronos, ARB, and OES extensi

[Mesa-dev] [PATCH 1/6] radv: update the fast color clear values only if the image is bound

2018-06-14 Thread Samuel Pitoiset
It's unnecessary to update the fast color clear values if the fast cleared color image isn't currently bound. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 35 +--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/r

[Mesa-dev] [PATCH 3/6] radv: update the fast ds clear values only if the image is bound

2018-06-14 Thread Samuel Pitoiset
It's unnecessary to update the fast depth/stencil clear values if the fast cleared depth/stencil image isn't currently bound. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 37 +++- 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/

[Mesa-dev] [PATCH 2/6] radv: clean up radv_{set, load}_color_clear_regs() helpers

2018-06-14 Thread Samuel Pitoiset
And replace _regs by _metadata because it makes more sense. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 67 +++- src/amd/vulkan/radv_meta_clear.c | 3 +- src/amd/vulkan/radv_private.h| 10 +++-- 3 files changed, 47 insertions(+), 33 dele

[Mesa-dev] [PATCH 4/6] radv: always set/load both depth and stencil clear values

2018-06-14 Thread Samuel Pitoiset
I don't think that matter much to emit both values and that makes the code a bit simpler. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 33 +--- 1 file changed, 5 insertions(+), 28 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/s

[Mesa-dev] [PATCH 6/6] radv: update ZRANGE_PRECISION in radv_update_bound_fast_clear_ds()

2018-06-14 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 46 +++- 1 file changed, 15 insertions(+), 31 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 894960461a..56dbb759cb 100644 --- a/src/amd/vulkan/r

[Mesa-dev] [PATCH 5/6] radv: clean up radv_{set, load}_depth_clear_regs() helpers

2018-06-14 Thread Samuel Pitoiset
And replace _regs by _metadata because it makes more sense. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 62 ++-- src/amd/vulkan/radv_meta_clear.c | 5 +-- src/amd/vulkan/radv_private.h| 9 ++--- 3 files changed, 44 insertions(+), 32 del

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #8 from Giovanni ongaro --- i did build mesa with debug mode but how do i activate it also i submitted the same bug to DXVK devs and they said that all the shaders are validated and is not an DXVK bug probably now i do not know if i

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #9 from Samuel Pitoiset --- Well, the LLVM documentation [1] says: "BUILD_SHARED_LIBS is only recommended for use by LLVM developers. If you want to build LLVM as a shared library, you should use the LLVM_BUILD_LLVM_DYLIB option."

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #10 from Pavel Ondračka --- BTW regarding the debug information from winedbg. It might help to specifically build mesa (and maybe llvm) with CFLAGS="-g -gdwarf-2", since some distros (like Fedora) default to newer dwarf version which

[Mesa-dev] [PATCH] radv: add RADV_DEBUG=checkir

2018-06-14 Thread Samuel Pitoiset
This allows to run the LLVM verifier pass. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c | 1 + src/amd/vulkan/radv_nir_to_llvm.c | 10 +++--- src/amd/vulkan/radv_shader.c | 1 + src/amd/vulkan/radv_shader.h | 1 +

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #11 from Samuel Pitoiset --- I can reproduce the issue with https://patchwork.freedesktop.org/patch/229503/. Not sure why it doesn't crash for me... I will fix it. Anyway, I highly recommend you to not use BUILD_SHARED_LIBS. -- Yo

Re: [Mesa-dev] [PATCH 3/8] i965/bufmgr: Drop the BO_ALLOC_BUSY flag

2018-06-14 Thread Lionel Landwerlin
On 13/06/18 21:26, Jason Ekstrand wrote: --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 46 ++ src/mesa/drivers/dri/i965/brw_bufmgr.h | 1 - 2 files changed, 10 insertions(+), 37 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #12 from Giovanni ongaro --- I build it with dylib still crashes Inviato da smartphone Samsung Galaxy. Messaggio originale Da: bugzilla-dae...@freedesktop.org Data: 14/06/18 14:41 (GMT+01:00) A: giovanni.nic...@t

Re: [Mesa-dev] [PATCH 01/14] intel/compiler: general 8/16/32/64-bit shuffle_src_to_dst function

2018-06-14 Thread Chema Casanova
El 14/06/18 a las 02:46, Jason Ekstrand escribió: > On Wed, Jun 13, 2018 at 5:07 PM, Chema Casanova > wrote: > > On 13/06/18 22:46, Jason Ekstrand wrote: > > On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com> >

Re: [Mesa-dev] [PATCH 3/8] i965/bufmgr: Drop the BO_ALLOC_BUSY flag

2018-06-14 Thread Lionel Landwerlin
On 14/06/18 14:01, Lionel Landwerlin wrote: On 13/06/18 21:26, Jason Ekstrand wrote: ---   src/mesa/drivers/dri/i965/brw_bufmgr.c | 46 ++   src/mesa/drivers/dri/i965/brw_bufmgr.h |  1 -   2 files changed, 10 insertions(+), 37 deletions(-) diff --git a/src/mesa/drivers/dr

[Mesa-dev] [PATCH] configure: use compliant grep regex checks

2018-06-14 Thread Emil Velikov
From: Emil Velikov The current `grep "foo\|bar"' trips on some grep implementations, like the FreeBSD one. Instead use `egrep "foo|bar"' as suggested by Stefan. Cc: Stefan Esser Reported-by: Stefan Esser Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228673 Fixes: 1914c814a6c ("co

Re: [Mesa-dev] [PATCH] radv: add RADV_DEBUG=checkir

2018-06-14 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jun 14, 2018 at 2:28 PM, Samuel Pitoiset wrote: > This allows to run the LLVM verifier pass. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_debug.h | 1 + > src/amd/vulkan/radv_device.c | 1 + > src/amd/vulkan/radv_nir_to_llvm

[Mesa-dev] [PATCH] [RFC] i965/blit: bump some limits to 64k

2018-06-14 Thread Martin Peres
This fixes screenshots using 8k+ wide display setups in modesetting. Chris Wilson even recommended the changes in intel_mipmap_tree.c should read 131072 instead of 65535, but I for sure got confused by his explanation. In any case, I would like to use this RFC patch as a forum to discuss why the

[Mesa-dev] [PATCH] radv: fix emitting the TCS regs on GFX9

2018-06-14 Thread Samuel Pitoiset
The primitive ID is NULL if the vertex shader is LS. This generates an invalid select instruction which crashes because one operand is NULL. This fixes crashes in The Long Journey Home, Quantum Break and Just Cause 3 with DXVK. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106756 CC: Si

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #13 from Samuel Pitoiset --- This should be fixed with https://patchwork.freedesktop.org/patch/229508/ Can you confirm? Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for t

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #7 from xinghua --- (In reply to Tapani Pälli from comment #6) > Fix proposal sent here: > https://lists.freedesktop.org/archives/mesa-dev/2018-June/197678.html Hi, Tapani, thank you for your patch, seems that this patch could resol

Re: [Mesa-dev] [PATCH] radv: fix emitting the TCS regs on GFX9

2018-06-14 Thread Bas Nieuwenhuizen
On Thu, Jun 14, 2018 at 3:23 PM, Samuel Pitoiset wrote: > The primitive ID is NULL if the vertex shader is LS. This > generates an invalid select instruction which crashes > because one operand is NULL. > > This fixes crashes in The Long Journey Home, Quantum Break > and Just Cause 3 with DXVK. >

[Mesa-dev] [Bug 106907] Correct Transform Feedback Varyings information is expected after using ProgramBinary

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106907 --- Comment #8 from Tapani Pälli --- (In reply to xinghua from comment #7) > (In reply to Tapani Pälli from comment #6) > > Fix proposal sent here: > > https://lists.freedesktop.org/archives/mesa-dev/2018-June/197678.html > > Hi, Tapani, thank

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.0 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #11 from erhar...@mailbox.org --- Built 18.0.5 and 17.3.9, same test failures here. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #14 from Giovanni ongaro --- thank you for the quick response i can confirm that all 3 games now work on vega 64 under dxvk with this patch applied you did a very good job -- You are receiving this mail because: You are the assigne

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #15 from Giovanni ongaro --- it also fixes NFS Payback -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing li

[Mesa-dev] [PATCH] st/mesa: add missing switch cases in glsl_to_tgsi_visitor::visit()

2018-06-14 Thread Brian Paul
To silence compiler warning about unhandled switch cases. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index b321112..673c0f6 100644 --- a/src/mesa/state

Re: [Mesa-dev] [PATCH mesa 1/9] vulkan: Add KHR_display extension using DRM [v8]

2018-06-14 Thread Keith Packard
Jason Ekstrand writes: > I'm trusting that not much changed other than what was explicitly called > out. I didn't want to re-read in *that* much detail again. :-) You are correct, all of the changes from the previous patch were listed in the commit message. > Reviewed-by: Jason Ekstrand Than

Re: [Mesa-dev] [PATCH] st/mesa: add missing switch cases in glsl_to_tgsi_visitor::visit()

2018-06-14 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, June 14, 2018 8:13:01 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] st/mesa: add missing switch cases in glsl_to_tgsi_visitor::visit() To silence compil

Re: [Mesa-dev] [PATCH] configure: use compliant grep regex checks

2018-06-14 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-14 Thread dylan
Hello list, The candidate for the Mesa 18.1.2 is now available. Currently we have: - 42 queued - 6 nominated (outstanding) - and 0 rejected patches Notable changes in this release: - numerous fixes for radv - libatomic checks for meson, as well as fixing coverage for less common (not arm or

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-14 Thread Bas Nieuwenhuizen
On Thu, Jun 14, 2018 at 6:13 PM, wrote: > Hello list, > > The candidate for the Mesa 18.1.2 is now available. Currently we have: > - 42 queued > - 6 nominated (outstanding) > - and 0 rejected patches > > Notable changes in this release: > - numerous fixes for radv > - libatomic checks for meso

Re: [Mesa-dev] [PATCH] [RFC] i965/blit: bump some limits to 64k

2018-06-14 Thread Nanley Chery
On Thu, Jun 14, 2018 at 04:18:30PM +0300, Martin Peres wrote: > This fixes screenshots using 8k+ wide display setups in modesetting. > > Chris Wilson even recommended the changes in intel_mipmap_tree.c > should read 131072 instead of 65535, but I for sure got confused by > his explanation. > > In

[Mesa-dev] [PATCH 3/9] intel/batch-decoder: handle non-contiguous binding table / surface state

2018-06-14 Thread Lionel Landwerlin
From: Scott D Phillips Reviewed-by: Lionel Landwerlin --- src/intel/common/gen_batch_decoder.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c index 3852f32de36..2b6978da92d 1006

[Mesa-dev] [PATCH 0/9] intel: aubinator: handle ppgtt & softpin

2018-06-14 Thread Lionel Landwerlin
Hi all, This series is based of what Scott did earlier this year to handle aubs with ppgtt. This has the nice side effect of also fixing recent softpin changes that allocate virtual addresses from the top addresses. Because we didn't have more than 1Tb of GTT mapping, we just couldn't deal with th

[Mesa-dev] [PATCH 2/9] intel/tools/aubinator: aubinate ppgtt aubs

2018-06-14 Thread Lionel Landwerlin
From: Scott D Phillips v2: by Lionel Fix memfd_create compilation issue Fix pml4 address stored on 32 instead of 64bits Return no buffer if first ppgtt page is not mapped Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 460 1

[Mesa-dev] [PATCH 6/9] intel: aubinator: move handle trace function around

2018-06-14 Thread Lionel Landwerlin
No functional changes. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 95 +++-- 1 file changed, 49 insertions(+), 46 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 99cd010dd9d..2a1b91c0e54 100644 ---

[Mesa-dev] [PATCH 1/9] util: rb-tree: A simple, invasive, red-black tree

2018-06-14 Thread Lionel Landwerlin
From: Jason Ekstrand This is a simple, invasive, liberally licensed red-black tree implementation. It's an invasive data structure similar to the Linux kernel linked-list where the intention is that you embed a rb_node struct the data structure you intend to put into the tree. The implementation

[Mesa-dev] [PATCH 4/9] intel: batch-decoder: don't asks for constant BO until decoding

2018-06-14 Thread Lionel Landwerlin
With PPGTT mappings, our aubinator implementation can be quite slow if we request a buffer that doesn't exist. Instead of doing a PPGTT walk for invalid addresses (0 lengths), wait until we're sure we want to decode the data. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_batch_decode

[Mesa-dev] [PATCH 5/9] intel: batch-decoder: add missing return line

2018-06-14 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_batch_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c index 81d8298c28b..fc0ff95a476 100644 --- a/src/intel/common/gen_batch_decoder

[Mesa-dev] [PATCH 9/9] intel: aubinator: remove standard input processing option

2018-06-14 Thread Lionel Landwerlin
Now that we rely on mmap of the data to parse, we can't process the standard input anymore. This isn't much of a big deal because we have in-process batch decoder (run with INTEL_DEBUG=batch) that supports essentially doing the same thing. Signed-off-by: Lionel Landwerlin --- src/intel/tools/au

[Mesa-dev] [PATCH 7/9] intel: aubinator: move address masking

2018-06-14 Thread Lionel Landwerlin
The Masking is only needed for entry matching. Signed-off-by: Lionel Landwerlin --- src/intel/tools/aubinator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 2a1b91c0e54..6f2e0d503df 100644 --- a/src/intel/

[Mesa-dev] [PATCH 8/9] intel: aubinator: drop the 1Tb GTT mapping

2018-06-14 Thread Lionel Landwerlin
We reuse the existing mechanism introduced in 482a7d1593c621 ("intel/tools/aubinator: aubinate ppgtt aubs") that is a list of GTT address and their corresponding mmapped pointer so that we can get rid of the 1Tb of mmapped memory and instead just use the already mmapped aub file. Sorry Kristian.

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.2 release candidate

2018-06-14 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-06-14 09:21:49) > On Thu, Jun 14, 2018 at 6:13 PM, wrote: > > Hello list, > > > > The candidate for the Mesa 18.1.2 is now available. Currently we have: > > - 42 queued > > - 6 nominated (outstanding) > > - and 0 rejected patches > > > > Notable changes in this

Re: [Mesa-dev] [PATCH 1/3] features.txt: mark some extensions as done

2018-06-14 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On 2018-06-14 04:08:09, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > docs/features.txt | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/docs/features.txt b/docs/features.txt > index b32606d223..423b03a9a9 100644 > ---

Re: [Mesa-dev] [PATCH v2] meson: fix private libs when building without glx

2018-06-14 Thread Lukas Rusak
How can I get some traction on this? On Mon, Jun 4, 2018 at 12:38 PM Lukas Rusak wrote: > I noticed that the generated pkg-config files will include > glx and x11 dependencies even when x11 isn't a selected platform. > > This fixes the private libs and was tested by building kmscube > > V2: >

Re: [Mesa-dev] [PATCH] meson: only build vl_winsys_dri.c when x11 platform is used

2018-06-14 Thread Lukas Rusak
any updates here? On Fri, Jun 1, 2018 at 2:09 PM Lukas Rusak wrote: > This seems to have been missed in the move from autotools > > This fixes the following build issue: > > ../src/gallium/auxiliary/vl/vl_winsys_dri.c:34:10: fatal error: > X11/Xlib-xcb.h: No such file or directory > #include >

Re: [Mesa-dev] [PATCH] glsl: serialize data from glTransformFeedbackVaryings

2018-06-14 Thread Jordan Justen
On 2018-06-14 02:58:33, Tapani Pälli wrote: > While XFB has been enabled for cache, we did not serialize enough > data for the whole API to work (such as glGetProgramiv). > > Fixes: 6d830940f7 "Allow shader cache usage with transform feedback" > Signed-off-by: Tapani Pälli > Bugzilla: https://bug

Re: [Mesa-dev] [PATCH 0/8] i965: Don't recycle BOs until they are idle

2018-06-14 Thread Jason Ekstrand
On June 14, 2018 01:43:12 Michel Dänzer wrote: On 2018-06-13 10:26 PM, Jason Ekstrand wrote: The current BO cache puts BOs back into the recycle bucket the moment the refcount hits zero. If the BO is busy, we just don't re-use it until it isn't or we re-use it for a render target which we ass

Re: [Mesa-dev] [PATCH 3/8] i965/bufmgr: Drop the BO_ALLOC_BUSY flag

2018-06-14 Thread Jason Ekstrand
On June 14, 2018 06:01:33 Lionel Landwerlin wrote: On 13/06/18 21:26, Jason Ekstrand wrote: --- src/mesa/drivers/dri/i965/brw_bufmgr.c | 46 ++ src/mesa/drivers/dri/i965/brw_bufmgr.h | 1 - 2 files changed, 10 insertions(+), 37 deletions(-) diff --git a/src/mesa/driver

Re: [Mesa-dev] [PATCH] meson: only build vl_winsys_dri.c when x11 platform is used

2018-06-14 Thread Dylan Baker
Quoting Lukas Rusak (2018-06-14 10:25:43) > any updates here? > > On Fri, Jun 1, 2018 at 2:09 PM Lukas Rusak wrote: > > This seems to have been missed in the move from autotools > > This fixes the following build issue: > > ../src/gallium/auxiliary/vl/vl_winsys_dri.c:34:10: fatal e

[Mesa-dev] [Bug 106774] GLSL IR copy propagates loads of SSBOs

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106774 Ian Romanick changed: What|Removed |Added CC||i...@freedesktop.org,

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-14 Thread Keith Packard
Jason Ekstrand writes: >> + if (instance->enabled_extensions.KHR_display) { >> + master_fd = open(path, O_RDWR | O_CLOEXEC); >> > > Is this supposed to be opening primary_path instead? Yes, and this section of code needs to occur before anv_init_wsi. I appear to have skipped testing this

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-14 Thread Keith Packard
Jason Ekstrand writes: >> Signed-off-by: Keith Packard >> >> fixup >> > > Did you mean to leave this in here? Nope; just rebasing/squashing noise. I noticed this in passing and have already removed it. -- -keith signature.asc Description: PGP signature _

Re: [Mesa-dev] [PATCH] [RFC] i965/blit: bump some limits to 64k

2018-06-14 Thread Nanley Chery
On Thu, Jun 14, 2018 at 10:01:18AM -0700, Nanley Chery wrote: > On Thu, Jun 14, 2018 at 04:18:30PM +0300, Martin Peres wrote: > > This fixes screenshots using 8k+ wide display setups in modesetting. > > > > Chris Wilson even recommended the changes in intel_mipmap_tree.c > > should read 131072 ins

Re: [Mesa-dev] [PATCH] [RFC] i965/blit: bump some limits to 64k

2018-06-14 Thread Chris Wilson
Quoting Nanley Chery (2018-06-14 19:46:09) > On Thu, Jun 14, 2018 at 10:01:18AM -0700, Nanley Chery wrote: > > On Thu, Jun 14, 2018 at 04:18:30PM +0300, Martin Peres wrote: > > > This fixes screenshots using 8k+ wide display setups in modesetting. > > > > > > Chris Wilson even recommended the chan

Re: [Mesa-dev] [PATCH mesa 7/9] vulkan: Add EXT_acquire_xlib_display [v3]

2018-06-14 Thread Keith Packard
Jason Ekstrand writes: >> Signed-off-by: Keith Packard >> >> fixup for acquire >> >> fixup for RROutput type >> >> Signed-off-by: Keith Packard >> >> fixup >> > > Lots of "fixup". Did you mean to actually comment on what that was? Sorry; I was squashing patches and moving comments into the ma

Re: [Mesa-dev] [PATCH v5] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

2018-06-14 Thread Nanley Chery
On Thu, Jun 07, 2018 at 09:34:41AM +0300, Eleni Maria Stea wrote: > Gen 7 GPUs store the compressed EAC/ETC2 images in other non-compressed > formats that can render. When GetCompressed* functions are called, the > pixels are returned in the non-compressed format that is used for the > rendering. >

Re: [Mesa-dev] [PATCH v5] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

2018-06-14 Thread Eleni Maria Stea
On 06/14/2018 10:27 PM, Nanley Chery wrote: > +Jason, Ken > > Hello, > > I recently did some miptree work relating to the r8stencil_mt and I > think I now have a more informed opinion about how things should be > structured. I'd like to propose an alternative solution. > > I had initially thoug

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-14 Thread Jason Ekstrand
On Thu, Jun 14, 2018 at 11:42 AM, Keith Packard wrote: > Jason Ekstrand writes: > > >> + if (instance->enabled_extensions.KHR_display) { > >> + master_fd = open(path, O_RDWR | O_CLOEXEC); > >> > > > > Is this supposed to be opening primary_path instead? > > Yes, and this section of code n

[Mesa-dev] [PATCH 1/4] mesa: add header for share bptc decompress functions

2018-06-14 Thread Denis Pauk
Make functions public: * fetch_rgba_unorm_from_block * fetch_rgb_float_from_block * compress_rgba_unorm * compress_rgb_float Functions will be reused in gallium/auxiliary code. --- src/mesa/Makefile.sources | 1 + src/mesa/main/texcompress_bptc.c | 9 ++--- src/mesa/main/texc

[Mesa-dev] Add support GL_ARB_texture_compression_bptc in llvmpipe and softpipe.

2018-06-14 Thread Denis Pauk
Add code for reuse bptc decode logic from mesa/main/texcompress_bptc.c by make several function public(nonstatic) and define functions in texcompress_bptc_share.h. I have made minimal changes in code without possible performance improvements. And code decodes image by pixels instead possible

[Mesa-dev] [PATCH 2/4] gallium/auxiliary: Add helper support for bptc format compress/decompress

2018-06-14 Thread Denis Pauk
Reuse code shared with mesa/main/texcompress_bptc. --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/meson.build| 2 + src/gallium/auxiliary/util/u_format_bptc.c | 322 +++ src/gallium/auxiliary/util/u_format_bptc.h | 122 +++ src

[Mesa-dev] [PATCH 4/4] gallium/llvmpipe: Enable support bptc format.

2018-06-14 Thread Denis Pauk
--- src/gallium/drivers/llvmpipe/lp_screen.c | 3 +-- src/gallium/drivers/llvmpipe/lp_test_format.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index f12ad09298..c1a2fd3379 100644

[Mesa-dev] [PATCH 3/4] gallium/softpipe: Enable support bptc format.

2018-06-14 Thread Denis Pauk
--- src/gallium/drivers/softpipe/sp_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index f9c916d938..676cd0812a 100644 --- a/src/gallium/drivers/softpipe/sp_screen.c +++ b/src/galli

Re: [Mesa-dev] [PATCH] [RFC] i965/blit: bump some limits to 64k

2018-06-14 Thread Ian Romanick
On 06/14/2018 06:18 AM, Martin Peres wrote: > This fixes screenshots using 8k+ wide display setups in modesetting. > > Chris Wilson even recommended the changes in intel_mipmap_tree.c > should read 131072 instead of 65535, but I for sure got confused by > his explanation. > > In any case, I would

Re: [Mesa-dev] [PATCH 44/48] meson: add windows specific linker flags

2018-06-14 Thread Jose Fonseca
On 12/06/18 17:50, Dylan Baker wrote: Quoting Eric Engestrom (2018-06-12 04:38:04) On Monday, 2018-06-11 15:56:11 -0700, Dylan Baker wrote: --- meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/meson.build b/meson.build index a244694fd4a..e1b3afbe688 1006

[Mesa-dev] [Bug 106922] Tangrams demo: LLVM ERROR: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106922 Bug ID: 106922 Summary: Tangrams demo: LLVM ERROR: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8 Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH mesa 7/9] vulkan: Add EXT_acquire_xlib_display [v3]

2018-06-14 Thread Jason Ekstrand
On Thu, Jun 14, 2018 at 12:24 PM, Keith Packard wrote: > Jason Ekstrand writes: > > >> Signed-off-by: Keith Packard > >> > >> fixup for acquire > >> > >> fixup for RROutput type > >> > >> Signed-off-by: Keith Packard > >> > >> fixup > >> > > > > Lots of "fixup". Did you mean to actually comme

Re: [Mesa-dev] [PATCH 44/48] meson: add windows specific linker flags

2018-06-14 Thread Dylan Baker
Quoting Jose Fonseca (2018-06-14 14:02:39) > On 12/06/18 17:50, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-06-12 04:38:04) > >> On Monday, 2018-06-11 15:56:11 -0700, Dylan Baker wrote: > >>> --- > >>> meson.build | 21 + > >>> 1 file changed, 21 insertions(+) > >>> >

[Mesa-dev] [Bug 106922] Tangrams demo: LLVM ERROR: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106922 --- Comment #1 from Bas Nieuwenhuizen --- Can reproduce a LLVM error here. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev ma

[Mesa-dev] [Bug 106922] Tangrams demo: LLVM ERROR: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106922 --- Comment #2 from Bas Nieuwenhuizen --- If this is any indication it may just be not checking exts: SPIR-V WARNING: In file ../mesa/src/compiler/spirv/spirv_to_nir.c:3312 Unsupported SPIR-V capability: SpvCapabilityInt16 28 bytes

Re: [Mesa-dev] [PATCH 02/14] intel/compiler: new shuffle_for_32bit_write and shuffle_from_32bit_read

2018-06-14 Thread Chema Casanova
On 14/06/18 03:02, Jason Ekstrand wrote: > On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > These new shuffle functions deal with the shuffle/unshuffle operations > needed for read/write operations using 32-bit components when the >

[Mesa-dev] [Bug 106922] Tangrams demo: LLVM ERROR: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8

2018-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106922 --- Comment #3 from Bas Nieuwenhuizen --- So top level is a f32 -> i16 bitcast: Cannot select: 0x7e8d8750: i16 = bitcast 0x7e8d8af8 which is not allowed. Is in LLVM source: %76 = call float @llvm.amdgcn.buffer.load.f32(<4 x i32> %75, i32 0, i

[Mesa-dev] [PATCH] ac: Clear meminfo to avoid valgrind warning.

2018-06-14 Thread Bas Nieuwenhuizen
Somehow valgrind misses that the value is initialized by the ioctl. --- src/amd/common/ac_gpu_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index e908cc6fa96..e885c0538e9 100644 --- a/src/amd/common/ac_gpu_inf

Re: [Mesa-dev] [PATCH 07/14] intel/compiler: shuffle_from_32bit_read for 64-bit do_untyped_vector_read

2018-06-14 Thread Chema Casanova
On 14/06/18 03:26, Jason Ekstrand wrote: > On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > do_untyped_vector_read is used at load_ssbo and load_shared. > > The previous MOVs are removed because shuffle_from_32bit_read > can hand

Re: [Mesa-dev] [PATCH 13/14] intel/compiler: use new shuffle_32bit_write for all 64-bit storage writes

2018-06-14 Thread Chema Casanova
On 14/06/18 03:44, Jason Ekstrand wrote: > On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > --- >  src/intel/compiler/brw_fs_nir.cpp | 13 ++--- >  1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/src/int

[Mesa-dev] [PATCH] radv: remove multisample bit from shader key.

2018-06-14 Thread Dave Airlie
From: Dave Airlie This wasn't being used anywhere inside the shader from what I can see. --- src/amd/vulkan/radv_pipeline.c | 2 -- src/amd/vulkan/radv_private.h | 1 - src/amd/vulkan/radv_shader.h | 1 - 3 files changed, 4 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/v

Re: [Mesa-dev] [PATCH] radv: remove multisample bit from shader key.

2018-06-14 Thread Bas Nieuwenhuizen
On Fri, Jun 15, 2018 at 12:51 AM, Dave Airlie wrote: > From: Dave Airlie > > This wasn't being used anywhere inside the shader from what I can see. Well it was used for the BC optimize, but then Samuel enabled it for non-multisample too, so now we don't use it anymore. (or rather we were already

[Mesa-dev] [PATCH] tgsi: add some atomic opcodes to tgsi_opcode_infer_type

2018-06-14 Thread Gurchetan Singh
We don't have cases for atomic types, some of which are explicitly signed or unsigned. The other opcodes could have uint or int return types, based on the sources. --- src/gallium/auxiliary/tgsi/tgsi_info.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_i

Re: [Mesa-dev] [PATCH 02/14] intel/compiler: new shuffle_for_32bit_write and shuffle_from_32bit_read

2018-06-14 Thread Jason Ekstrand
On Thu, Jun 14, 2018 at 2:39 PM, Chema Casanova wrote: > On 14/06/18 03:02, Jason Ekstrand wrote: > > On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com>> wrote: > > > > These new shuffle functions deal with the shuffle/unshuffle > operations > > n

  1   2   >