[Mesa-dev] [Bug 106823] Failed to recongnize keyword of shader code

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106823 Bug ID: 106823 Summary: Failed to recongnize keyword of shader code Product: Mesa Version: 17.1 Hardware: ARM OS: Linux (All) Status: NEW Severity: norma

[Mesa-dev] [Bug 106824] glDrawElements: Invalid cast!

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106824 Bug ID: 106824 Summary: glDrawElements: Invalid cast! Product: Mesa Version: 18.0 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: major

[Mesa-dev] [Bug 106823] Failed to recongnize keyword of shader code

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106823 --- Comment #1 from Kenneth Graunke --- That is indeed a bug, GLSL ES 1.0.17 specifies that "double" is a keyword reserved for future use. The fix is to change glsl_lexer.ll to be double TYPE_WITH_ALT(130, 100, 130, 300, yyextra->ARB_

[Mesa-dev] Getting started on DriConf replacement - EVoC 2018

2018-06-05 Thread Veluri Mithun
Dear developers, I'm of the undergraduate students at India having experience in C++, Java, Python programming languages. Being an Electronics student I've fair enough knowledge in architectures of few Microcontrollers and Embedded C, Verilog & VHDL. I'm very enthusiastic to take part in this pro

[Mesa-dev] [Bug 106823] Failed to recongnize keyword of shader code

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106823 --- Comment #2 from Zhaowei Yuan --- (In reply to Kenneth Graunke from comment #1) > That is indeed a bug, GLSL ES 1.0.17 specifies that "double" is a keyword > reserved for future use. The fix is to change glsl_lexer.ll to be > > double

Re: [Mesa-dev] [PATCH 0/3] intel: implement an optimization pass to clean-up boolean conversions

2018-06-05 Thread Iago Toral
This isn't reviewed yet, any feedback? Iago On Tue, 2018-05-15 at 13:05 +0200, Iago Toral Quiroga wrote: > NIR assumes that all booleans are 32-bit, so drivers need to produce > 32-bit > booleans even if they can produce native booleans of a different bit- > size, like > Intel does. This means th

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-05 Thread Juan A. Suarez Romero
On Mon, 2018-06-04 at 13:22 +0100, Daniel Stone wrote: > Hi Juan, > > On 4 June 2018 at 12:43, Juan A. Suarez Romero wrote: > > On Fri, 2018-06-01 at 16:32 +0100, Daniel Stone wrote: > > > I think you're right, and this needs more rework to be consistent. > > > > > > wl_egl_window_get_attached_s

[Mesa-dev] [PATCH] glsl: Take 'double' as reserved after GLSL ES 1.0

2018-06-05 Thread zhaowei yuan
GLSL ES 1.0.17 specifies that "double" is a keyword reserved Signed-off-by: zhaowei yuan --- src/compiler/glsl/glsl_lexer.ll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll index b7cf100..de6dc64 100644 --- a/s

[Mesa-dev] [Bug 106779] Files missing from tarball - u_debug_stack_android.cpp

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106779 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 106778] Files missing from tarball - intel_sanitize_gpu.*

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106778 --- Comment #4 from Eric Engestrom --- (In reply to Kevin Rogovin from comment #2) > I suggest assigning the bug to whoever the git log lists as the > author for the git commit that added those files. That would be why I assigned it to you :P

[Mesa-dev] [PATCH] anv: intel: add softpin flag on imported BOs

2018-06-05 Thread Lionel Landwerlin
Looks like we forgot to update this bit of the driver for softpin. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_intel.c b/src/intel/vulkan/anv_intel.c index 431cef5c6ac..06db5787a9c 100644 --- a/src/i

[Mesa-dev] [PATCH mesa] travis: use correct form for array options

2018-06-05 Thread Eric Engestrom
I'd like to eventually drop support for the confusing "an array of a single empty string is meant to be interpreted as an empty array", so let's start by not using it anymore. Signed-off-by: Eric Engestrom --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.t

Re: [Mesa-dev] [PATCH] anv: intel: add softpin flag on imported BOs

2018-06-05 Thread Lionel Landwerlin
On 05/06/18 11:28, Lionel Landwerlin wrote: Looks like we forgot to update this bit of the driver for softpin. Signed-off-by: Lionel Landwerlin I guess : Fixes: 4affeba1e9eb42 ("anv: Soft-pin everything else") --- src/intel/vulkan/anv_intel.c | 2 ++ 1 file changed, 2 insertions(+) dif

Re: [Mesa-dev] [PATCH] anv: intel: add softpin flag on imported BOs

2018-06-05 Thread Tapani Pälli
On 05.06.2018 14:29, Lionel Landwerlin wrote: On 05/06/18 11:28, Lionel Landwerlin wrote: Looks like we forgot to update this bit of the driver for softpin. Signed-off-by: Lionel Landwerlin I guess : Fixes: 4affeba1e9eb42 ("anv: Soft-pin everything else") LGTM Reviewed-by: Tapani Pälli

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-05 Thread Tapani Pälli
On 05.06.2018 11:51, Juan A. Suarez Romero wrote: On Mon, 2018-06-04 at 13:22 +0100, Daniel Stone wrote: Hi Juan, On 4 June 2018 at 12:43, Juan A. Suarez Romero wrote: On Fri, 2018-06-01 at 16:32 +0100, Daniel Stone wrote: I think you're right, and this needs more rework to be consistent.

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

2018-06-05 Thread Daniel Stone
Hi Juan, On 5 June 2018 at 09:51, Juan A. Suarez Romero wrote: > On Mon, 2018-06-04 at 13:22 +0100, Daniel Stone wrote: >> The first query will correctly return (w1,h1). The second query will >> incorrectly also return (w1,h1), even though the surface will never >> have that size. The third query

[Mesa-dev] [PATCH 08/24] gallium/aux/tgsi_exec.c: Remove unused parameter from fetch_src_file_channel

2018-06-05 Thread Gert Wollny
remove unused parameter chan_index from fetch_src_file_channel, fixes warning: tgsi/tgsi_exec.c: In Funktion »fetch_src_file_channel«: tgsi/tgsi_exec.c:1480:35: Warning: unused parameter »chan_index« [-Wunused-parameter] const uint chan_index,

[Mesa-dev] [PATCH 03/24] gallium/aux/tgsi/tgsi_dump.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
tgsi_dump.c: In function 'iter_property': tgsi_dump.c:443:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < prop->Property.NrTokens - 1; ++i) { ^ tgsi_dump.c:459:13: warning: comparison between signed and unsigned integer

[Mesa-dev] [PATCH 00/24] Fix some warnings in gallium/aux

2018-06-05 Thread Gert Wollny
Dear all, this series fixes a number of warnings that are issued when compiling with -Wextra. Since this flag also includes -Wmissing-field-initializers - a warning that is rather mis-leading, I also propose to always silence this warning. thanks for reviewing, Gert PS: I have no commit righ

[Mesa-dev] [PATCH 05/24] gallium/aux/tgsi_sanity.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
tgsi_sanity.c: In function 'iter_instruction': tgsi_sanity.c:316:29: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (ctx->index_of_END != ~0) { ^~ tgsi_sanity.c: In function 'epilog': tgsi_sanity.c:488:26: warning: compari

[Mesa-dev] [PATCH 09/24] gallium/aux/tgsi_exec.c: remove superfluous parameter from store_dest_dstret

2018-06-05 Thread Gert Wollny
remove unused parameter inst from store_dest_dstret (and consequently also from store_dest_double), fixes warning: tgsi/tgsi_exec.c: In Funktion »store_dest_dstret«: tgsi/tgsi_exec.c:1765:47: Warning: unused parameter »inst« [-Wunused-parameter] const struct tgsi_full_instruction *inst)

[Mesa-dev] [PATCH 01/24] configure.ac: Add CFLAG -Wno-missing-field-initializers

2018-06-05 Thread Gert Wollny
This warning is misleading: When a struct is partially initialized without assigning to the structure members by name, then the remaining fields will be zeroed out, and this warning will be issued (if enabled). If, on the other hand, the partial initialization is done by assigning to named members,

[Mesa-dev] [PATCH 11/24] gallium/aux/tgsi_exec.c: Fix various -Wsign-compare

2018-06-05 Thread Gert Wollny
tgsi/tgsi_exec.c: In function 'exec_tex': tgsi/tgsi_exec.c:2254:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] assert(shadow_ref >= dim && shadow_ref < ARRAY_SIZE(args)); ^ ./util/u_debug.h:189:30: note:

[Mesa-dev] [PATCH 06/24] gallium/aux/tgsi_aa_point.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
tgsi/tgsi_aa_point.c:32:0: tgsi/tgsi_aa_point.c: In Funktion »aa_decl«: ./util/u_math.h:660:29: Comparison between signed and unsigned in conditional expressions [-Wsign-compare] #define MAX2( A, B ) ( (A)>(B) ? (A) : (B) ) ^ tgsi/tgsi_aa_point.c:76:21: Remark: when

[Mesa-dev] [PATCH 04/24] gallium/aux/tgsi/tgsi_parse.c: Fix two warnings

2018-06-05 Thread Gert Wollny
tgsi_parse.c: In function 'tgsi_parse_free': tgsi_parse.c:54:31: warning: unused parameter 'ctx' [-Wunused-parameter] struct tgsi_parse_context *ctx ) ^~~ tgsi_parse.c: In function 'tgsi_parse_end_of_tokens': tgsi_parse.c:62:25: warning: comparison between signed

[Mesa-dev] [PATCH 02/24] gallium/aux/cso_cache: Fix various warnings

2018-06-05 Thread Gert Wollny
cso_cache.c: In Function »delete_blend_state«: cso_cache/cso_cache.c:90:51: Warning: unused parameter »data« [-Wunused- parameter] static void delete_blend_state(void *state, void *data) ^~~~ cso_cache/cso_cache.c: In Funktion »delete_depth_stenci

[Mesa-dev] [PATCH 20/24] gallium/aux/tgsi_ureg.c: remove unused parameter from match_or_expand_immediate64

2018-06-05 Thread Gert Wollny
remove "type" from "match_or_expand_immediate64", fixes: tgsi/tgsi_ureg.c: In function 'match_or_expand_immediate64': tgsi/tgsi_ureg.c:837:34: warning: unused parameter 'type' [-Wunused- parameter] int type, ^~~~ Signed-off-by: Gert

[Mesa-dev] [PATCH 07/24] gallium/aux/tgsi_exec.c: Remove paramater inst from exec_kill

2018-06-05 Thread Gert Wollny
Fixes warning: tgsi/tgsi_exec.c: In Funktion »exec_kill«: tgsi/tgsi_exec.c:2049:47: Warning: unused parameter »inst« [-Wunused-parameter] const struct tgsi_full_instruction *inst) ^~~~ Signed-off-by: Gert Wollny --- src/gallium/auxiliary/

[Mesa-dev] [PATCH 13/24] gallium/aux/tgsi_build.c: Remove now unused variable

2018-06-05 Thread Gert Wollny
Removing the unused prev_tocken from the function calls made this local variable also unused. Signed-off-by: Gert Wollny --- src/gallium/auxiliary/tgsi/tgsi_build.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c b/src/gallium/a

[Mesa-dev] [PATCH 21/24] gallium/aux/util: Fix some warnings

2018-06-05 Thread Gert Wollny
util/u_cpu_detect.c: In function 'util_cpu_detect': util/u_cpu_detect.c:377:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (util_cpu_caps.nr_cpus == ~0u) ^~ util/u_hash_table.c:274:21: warning: unused parameter 'k' [-Wu

[Mesa-dev] [PATCH 22/24] gallium/aux/util/u_debug.h: Fix "noreturn" warnings in debug mode

2018-06-05 Thread Gert Wollny
Only decorate function as noreturn when DEBUG is not defined, because when compiled in DEBUG mode the function actually executes an int3 and may return, fixes: u_debug.c: In function '_debug_assert_fail': u_debug.c:309:1: warning: 'noreturn' function does return Signed-off-by: Gert Wollny --- sr

[Mesa-dev] [PATCH 16/24] gallium/aux/tgsi_point_sprite.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
tgsi/tgsi_lowering.c: In function 'emit_twoside': tgsi/tgsi_lowering.c:1179:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c:1208:18: warning: comparison between signed

[Mesa-dev] [PATCH 18/24] gallium/aux/tgsi_ureg.c: Fix various warnings

2018-06-05 Thread Gert Wollny
tgsi/tgsi_ureg.c: In function 'ureg_DECL_sampler': tgsi/tgsi_ureg.c:721:34: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (ureg->sampler[i].Index == nr) ^~ tgsi/tgsi_ureg.c: In function 'match_or_expand_immediate64':

[Mesa-dev] [PATCH 24/24] gallium/aux/os: Fix warning/handle failure to read from /proc/self/cmdline

2018-06-05 Thread Gert Wollny
Handle the failure to read from /proc/self/cmdline by printing an error message and fix the -Wsign-compare warning: In file included from ./util/u_memory.h:39:0, from os/os_process.c:31: os/os_process.c: In function 'os_get_command_line': os/os_process.c:140:16: warning: compariso

[Mesa-dev] [PATCH 23/24] gallium/aux/util/u_cpu_detect.h: Fix -Wsign-compare warning in u_cpu_detect.c

2018-06-05 Thread Gert Wollny
Change the type of util_cpu_caps::nr_cpus to int because sysconfig returns a signed value, fixes: u_cpu_detect.c: In function 'util_cpu_detect': u_cpu_detect.c:317:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (util_cpu_caps.nr_cpus == -1) Signed-

[Mesa-dev] [PATCH 10/24] gallium/aux/tgsi_exec.c: remove superfluous parameter from etch_source_d

2018-06-05 Thread Gert Wollny
Remove unused parameter src_datatype from fetch_source_d, fixes warning; tgsi/tgsi_exec.c: In function 'fetch_source_d': tgsi/tgsi_exec.c:1594:40: warning: unused parameter 'src_datatype' [-Wunused-parameter] enum tgsi_exec_datatype src_datatype)

[Mesa-dev] [PATCH 19/24] gallium/aux/tgsi_two_side.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
Integer propagation rules can sometimes be irritating. With "unsigned x" "x + 1" gets propagated to a signed integer, so explicitely assign the sum to an unsigned and use that for comaprison. In file included from tgsi/tgsi_two_side.c:41:0: tgsi/tgsi_two_side.c: In function 'xform_decl': ./util/u_

[Mesa-dev] [PATCH 17/24] gallium/aux/tgsi_text.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
tgsi/tgsi_text.c: In function 'parse_identifier': tgsi/tgsi_text.c:218:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (i == len - 1) ^~ tgsi/tgsi_text.c: In function 'parse_optional_swizzle': tgsi/tgsi_text.c:873:21: warning: co

[Mesa-dev] [PATCH 15/24] gallium/aux/tgsi_lowering.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
tgsi/tgsi_lowering.c: In function 'emit_twoside': tgsi/tgsi_lowering.c:1179:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < ctx->two_side_colors; i++) { ^ tgsi/tgsi_lowering.c:1208:18: warning: comparison between signed

[Mesa-dev] [PATCH 12/24] gallium/aux/tgsi_build.c: Remove unused parameters prev_token from various functions

2018-06-05 Thread Gert Wollny
remove parameter prev_token unused in tgsi_build_instruction_label tgsi_build_instruction_texture tgsi_build_instruction_memory tgsi_build_texture_offset This fixes the following warnings: tgsi/tgsi_build.c: In function 'tgsi_build_instruction_label': tgsi/tgsi_build.c:716:24: warning

[Mesa-dev] [PATCH 14/24] gallium/aux/tgsi_build.c: Fix -Wsign-compare warnings

2018-06-05 Thread Gert Wollny
tgsi/tgsi_build.c: In function 'tgsi_build_full_immediate': tgsi/tgsi_build.c:622:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for( i = 0; i < full_imm->Immediate.NrTokens - 1; i++ ) { ^ tgsi/tgsi_build.c: In function 'tgsi_build_ful

Re: [Mesa-dev] [PATCH] anv: intel: add softpin flag on imported BOs

2018-06-05 Thread Jason Ekstrand
Rb On June 5, 2018 03:28:40 Lionel Landwerlin wrote: Looks like we forgot to update this bit of the driver for softpin. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_intel.c b/src/intel/vulkan/anv

[Mesa-dev] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Emil Velikov
From: Emil Velikov Recently the wayland-egl library and pkg-config file were moved to the Wayland repository. With that a strange conflict came to be - which one should be used and when. The long term goal is to remove the Mesa copies, but with this patch we allow builders to explicitly select i

[Mesa-dev] [PATCH 2/5] wayland-egl: force disable --enable-bundled-wayland-egl

2018-06-05 Thread Emil Velikov
From: Emil Velikov We want to remove all the respective code, so force it off. As people miss the warning messages produced by autoconf leave the toggle as-is, thus anyone who explicitly enables it will get an lovely error and effectively failure ;-) If anyone is interested in doing the same fo

[Mesa-dev] [PATCH 3/5] wayland-egl: remove now that we're using the Wayland one

2018-06-05 Thread Emil Velikov
From: Eric Engestrom Cc: Emil Velikov Cc: Daniel Stone Signed-off-by: Eric Engestrom --- src/egl/wayland/wayland-egl/Makefile.am| 24 --- src/egl/wayland/wayland-egl/meson.build| 50 - .../wayland/wayland-egl/wayland-egl-abi-check.c| 235 -

[Mesa-dev] [PATCH 5/5] travis: bump the wayland version to 1.15.0

2018-06-05 Thread Emil Velikov
From: Emil Velikov As covered earlier - this is the version which ships wayland-egl{,-backend} and associated files. Signed-off-by: Emil Velikov --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d05c40bf9d7..7d3d6d1e10d 100644 -

[Mesa-dev] [PATCH 4/5] docs: add note about moving to libwayland-egl in 18.2.0

2018-06-05 Thread Emil Velikov
From: Eric Engestrom v2 [Emil]: s/libwayland/Wayland/ Cc: Emil Velikov Cc: Daniel Stone Cc: Andres Gomez Cc: Dylan Baker Signed-off-by: Eric Engestrom Signed-off-by: Emil Velikov --- docs/relnotes/18.2.0.html | 8 1 file changed, 8 insertions(+) diff --git a/docs/relnotes/18.2.0

Re: [Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl

2018-06-05 Thread Emil Velikov
On 4 June 2018 at 17:15, Matt Turner wrote: > On Thu, May 31, 2018 at 10:22 AM, Emil Velikov > wrote: >> On 29 May 2018 at 15:41, Eric Engestrom wrote: >>> Cc: Emil Velikov >>> Cc: Daniel Stone >>> Signed-off-by: Eric Engestrom >>> --- >>> A couple things worth mentioning: >>> - I chose to a

Re: [Mesa-dev] [PATCH] opencl: autotools: Fix linking order for OpenCL target

2018-06-05 Thread Emil Velikov
Hi all, Seems like I've got this stuck in the drafts queue. While the patch has been merged, I'm hitting "Send" for posterity. On 2 May 2018 at 21:38, Jan Vesely wrote: > @Emil, are you OK with this patch? > In a Tl;Dr; yes, patch is fine and is Reviewed-by: Emil Velikov A bit more detail on

Re: [Mesa-dev] [PATCH 5/5] travis: bump the wayland version to 1.15.0

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 15:14:34 +0100, Emil Velikov wrote: > From: Emil Velikov > > As covered earlier - this is the version which ships > wayland-egl{,-backend} and associated files. > > Signed-off-by: Emil Velikov > --- > .travis.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Mesa-dev] [PATCH 00/21] Towards NIR support for etnaviv

2018-06-05 Thread Philipp Zabel
Hi! we have been interested in NIR support for etnaviv for a while, for the obvious reasons: gaining access to common optimizations, better support for non-trivial code transformations, better register allocation, and the promise of OpenCL and SPIR-V support in the future. Michael and I have used

[Mesa-dev] [PATCH 03/21] etnaviv: compiler: extract compile shader from tgsi

2018-06-05 Thread Philipp Zabel
From: Michael Tretter Prepare for compilation from NIR. etna_compile_shader will call either etna_compile_shader_tgsi or etna_compile_shader_nir, depending on whether the input is TGSI or NIR. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- .../drivers/etnaviv/etnaviv_compiler

[Mesa-dev] [PATCH 01/21] etnaviv: prefix COMPARE_FUNC enum values in rnndb

2018-06-05 Thread Philipp Zabel
The COMPARE_FUNC enum values from rnndb state_3d.xml conflict with the enum compare_func values from shader_enums.h, but they are not used anywhere. Move them out of the way by adding a prefix. TODO: The state_3d.xml.h header is generated and actually the generator must be fixed to generate the pr

[Mesa-dev] [PATCH 02/21] etnaviv: extract get_mystery_meat_load_balancing

2018-06-05 Thread Philipp Zabel
From: Michael Tretter Extract the mystery meat load balancing calculation into a function that can also be called from the NIR compiler implementation. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- .../drivers/etnaviv/etnaviv_compiler.c| 60 +++ 1 fil

[Mesa-dev] [PATCH 05/21] etnaviv: generate and optimize NIR

2018-06-05 Thread Philipp Zabel
If the "nir" debug option is enabled, actually process NIR shaders if passed from the upper layers, or convert TGSI shaders to NIR before processing them. We use a few common NIR lowering and optimization passes as well as a few custom ones that are specific to the Vivante hardware: - etna_move_lo

[Mesa-dev] [PATCH 07/21] etnaviv: nir: merge mov of result into alu op

2018-06-05 Thread Philipp Zabel
Remove unnecessary mov instructions. If the destination of an ALU instruction is only used in a following mov, merge that mov into the ALU instruction. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- src/gallium/drivers/etnaviv/etnaviv_nir.c | 43 +++ 1 file

[Mesa-dev] [PATCH 09/21] etnaviv: compiler: setup registers from nir

2018-06-05 Thread Philipp Zabel
From: Michael Tretter Add etna_compile_shader_nir, set up shader inputs and outputs, and start emitting instructions for optimized NIR shaders. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- .../drivers/etnaviv/etnaviv_compiler.c| 224 +- 1 file change

[Mesa-dev] [PATCH 08/21] etnaviv: nir: add virtual register classes

2018-06-05 Thread Philipp Zabel
Since all threads share a global temporary vec4 register file, it is important to reduce temporary register use of shaders. Using source swizzles and destination write mask of ALU operations we can layer smaller virtual registers on top of the physical base registers that overlap with their base re

[Mesa-dev] [PATCH 10/21] etnaviv: compiler: avoid using tgsi_shader_info

2018-06-05 Thread Philipp Zabel
From: Michael Tretter For NIR shaders, get the shader stage from the nir_shader structure instead from tgsi_shader_info. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- .../drivers/etnaviv/etnaviv_compiler.c| 37 ++- 1 file changed, 35 insertions(+), 2

[Mesa-dev] [PATCH 13/21] etnaviv: nir: add a nop intrinsic to empty shaders

2018-06-05 Thread Philipp Zabel
The Vivante instruction set does not allow empty shaders. If the shader is empty, add a nop to allow execution. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- src/gallium/drivers/etnaviv/etnaviv_nir.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gal

[Mesa-dev] [PATCH 14/21] etnaviv: nir: remove undefined variables

2018-06-05 Thread Philipp Zabel
From: Michael Tretter If the source to a mov instruction is undefined, the result is undefined as well. In that case it is valid to drop the mov instruction. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_nir.c | 35 +++

[Mesa-dev] [PATCH 18/21] etnaviv: nir: implement conditionals

2018-06-05 Thread Philipp Zabel
Emit conditional branches for nir_cf_code_if blocks following a comparison operation. The NIR compiler does not assign registers to the comparison operations, and the emitter does not emit any instructions for them. Instead, the nir_cf_code_if blocks cause emission of a conditional branch instructi

[Mesa-dev] [PATCH 17/21] etnaviv: nir: add texture fixup path before register assignment

2018-06-05 Thread Philipp Zabel
The texture instructions expect the source register to have the correct number of components. Since we only have vec4 hardware registers, rewrite the number of components to 4 and insert a mov instruction to a new vec4 SSA right before the texture load instruction. TODO: To support destination reg

[Mesa-dev] [PATCH 11/21] etnaviv: compiler: add code emitter for alu operations

2018-06-05 Thread Philipp Zabel
From: Michael Tretter Start emitting ALU instructions for nir_alu_instr structures from the NIR shader's main function implementation. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- .../drivers/etnaviv/etnaviv_compiler.c| 290 ++ 1 file changed, 290 in

[Mesa-dev] [PATCH 16/21] etnaviv: compiler: generate texture loads

2018-06-05 Thread Philipp Zabel
Emit TEXLD, TEXLDB, and TEXLDL instructions from nir_texop_tex, nir_texop_txb, and nir_texop_txl texture loads, respectively. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- .../drivers/etnaviv/etnaviv_compiler.c| 65 +++ 1 file changed, 65 insertions(+)

[Mesa-dev] [PATCH 20/21] etnaviv: nir: avoid multiple uniform src for alu ops

2018-06-05 Thread Philipp Zabel
From: Michael Tretter The hardware does not allow two different uniform registers to be used as sources in the same ALU instruction. Emit mov instructions to temporary registers for all but one uniform register in this case. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- src/

[Mesa-dev] [PATCH 12/21] etnaviv: compiler: generate instructions for log2

2018-06-05 Thread Philipp Zabel
From: Michael Tretter flog2 is implemented as 2 instructions in the Vivante machine code. The log calculates x and y, which have to be multiplied to get the actual log result. We need to allocate a temporary register for this, which will fail if to many flog2 instructions are used (e.g. in the g

[Mesa-dev] [PATCH 04/21] etnaviv: add debug option to report NIR as supported and preferred shader IR

2018-06-05 Thread Philipp Zabel
Add a debug option ETNA_MESA_DEBUG="nir" that will cause the etnaviv gallium pipe driver to advertise support and preference for NIR shaders. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- src/gallium/drivers/etnaviv/etnaviv_debug.h | 3 +++ src/gallium/drivers/etnaviv/etnavi

[Mesa-dev] [PATCH 19/21] etnaviv: nir: add extra mov for uniforms used as output

2018-06-05 Thread Philipp Zabel
From: Michael Tretter If a uniform is source to an output store operation, we have to emit an actual mov instruction that copies from the uniform register into the temporary register that is used as a shader output. Signed-off-by: Michael Tretter Signed-off-by: Philipp Zabel --- src/gallium/d

[Mesa-dev] [PATCH 06/21] etnaviv: nir: hardwire position location

2018-06-05 Thread Philipp Zabel
The temporary input/output register 0 is reserved for position in the fragment shader. Hardwire it to 0 and start other input/output variables at 1. The intrinsic input load and output store base corresponds to the temporary register number. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tre

[Mesa-dev] [PATCH 21/21] etnaviv: nir: globalize local registers

2018-06-05 Thread Philipp Zabel
We represent allocated temporaries as NIR global registers. Turn local registers left over by the nir_convert_from_ssa pass into global registers with the correct temporary number. Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_nir.c | 21 + 1 file chang

[Mesa-dev] [PATCH 15/21] etnaviv: compiler: ignore nir_instr_type_ssa_undef

2018-06-05 Thread Philipp Zabel
From: Michael Tretter Ignore ssa_undef nir instructions when generating code, because all users of the undefined values are removed and undefined values are not used. The instructions should be removed while rewriting the users of undefined variables, but are not removed yet. Signed-off-by: Mich

Re: [Mesa-dev] [PATCH v4 000/129] nir: Move to using instructions for derefs

2018-06-05 Thread Jason Ekstrand
On Sun, Jun 3, 2018 at 4:18 PM, Bas Nieuwenhuizen wrote: > On Sat, Jun 2, 2018 at 2:48 AM, Rob Clark wrote: > > On Fri, Jun 1, 2018 at 1:01 AM, Jason Ekstrand > wrote: > >> This is something that Connor and I have been talking about for some > time > >> now. The basic idea is to replace the cu

Re: [Mesa-dev] [PATCH 5/5] travis: bump the wayland version to 1.15.0

2018-06-05 Thread Emil Velikov
On 5 June 2018 at 15:36, Eric Engestrom wrote: > On Tuesday, 2018-06-05 15:14:34 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> As covered earlier - this is the version which ships >> wayland-egl{,-backend} and associated files. >> >> Signed-off-by: Emil Velikov >> --- >> .travis.yml |

Re: [Mesa-dev] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 15:14:30 +0100, Emil Velikov wrote: > From: Emil Velikov > > Recently the wayland-egl library and pkg-config file were moved to the > Wayland repository. With that a strange conflict came to be - which one > should be used and when. > > The long term goal is to remove the

Re: [Mesa-dev] [PATCH 5/5] travis: bump the wayland version to 1.15.0

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 16:03:14 +0100, Emil Velikov wrote: > On 5 June 2018 at 15:36, Eric Engestrom wrote: > > On Tuesday, 2018-06-05 15:14:34 +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> As covered earlier - this is the version which ships > >> wayland-egl{,-backend} and associa

Re: [Mesa-dev] [PATCH mesa] travis: use correct form for array options

2018-06-05 Thread Dylan Baker
This seems fine to me, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-06-05 03:59:40) > I'd like to eventually drop support for the confusing "an array of > a single empty string is meant to be interpreted as an empty array", so > let's start by not using it anymore. > > Signed-off-by: E

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Emil Velikov
On 5 June 2018 at 16:07, Eric Engestrom wrote: > On Tuesday, 2018-06-05 15:14:30 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Recently the wayland-egl library and pkg-config file were moved to the >> Wayland repository. With that a strange conflict came to be - which one >> should be us

Re: [Mesa-dev] [PATCH 5/5] travis: bump the wayland version to 1.15.0

2018-06-05 Thread Emil Velikov
On 5 June 2018 at 16:15, Eric Engestrom wrote: > On Tuesday, 2018-06-05 16:03:14 +0100, Emil Velikov wrote: >> On 5 June 2018 at 15:36, Eric Engestrom wrote: >> > On Tuesday, 2018-06-05 15:14:34 +0100, Emil Velikov wrote: >> >> From: Emil Velikov >> >> >> >> As covered earlier - this is the vers

[Mesa-dev] [PATCH] FIXUP: nir: convert lower_io_arrays_to_elements to deref instructions

2018-06-05 Thread Bas Nieuwenhuizen
--- Forgot this one ... src/amd/vulkan/radv_pipeline.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index 34249bf843d..375f7c357d3 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -2039,8 +

Re: [Mesa-dev] [PATCH mesa] travis: use correct form for array options

2018-06-05 Thread Dylan Baker
You might also be interested in this: https://github.com/mesonbuild/meson/pull/3696 Quoting Eric Engestrom (2018-06-05 03:59:40) > I'd like to eventually drop support for the confusing "an array of > a single empty string is meant to be interpreted as an empty array", so > let's start by not using

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 16:24:59 +0100, Emil Velikov wrote: > On 5 June 2018 at 16:07, Eric Engestrom wrote: > > On Tuesday, 2018-06-05 15:14:30 +0100, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> Recently the wayland-egl library and pkg-config file were moved to the > >> Wayland reposito

Re: [Mesa-dev] [PATCH 08/21] etnaviv: nir: add virtual register classes

2018-06-05 Thread Rob Clark
On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote: > Since all threads share a global temporary vec4 register file, it is > important to reduce temporary register use of shaders. > Using source swizzles and destination write mask of ALU operations we > can layer smaller virtual registers on top

Re: [Mesa-dev] [PATCH 00/21] Towards NIR support for etnaviv

2018-06-05 Thread Christian Gmeiner
Am Di., 5. Juni 2018 um 16:40 Uhr schrieb Philipp Zabel : > > Hi! > > we have been interested in NIR support for etnaviv for a while, for the > obvious reasons: gaining access to common optimizations, better support > for non-trivial code transformations, better register allocation, and > the promi

Re: [Mesa-dev] [PATCH mesa] travis: use correct form for array options

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 08:37:55 -0700, Dylan Baker wrote: > You might also be interested in this: > https://github.com/mesonbuild/meson/pull/3696 I am, thanks for doing this :) > > Quoting Eric Engestrom (2018-06-05 03:59:40) > > I'd like to eventually drop support for the confusing "an array of

Re: [Mesa-dev] [PATCH 06/21] etnaviv: nir: hardwire position location

2018-06-05 Thread Rob Clark
On Tue, Jun 5, 2018 at 10:38 AM, Philipp Zabel wrote: > The temporary input/output register 0 is reserved for position in the > fragment shader. Hardwire it to 0 and start other input/output variables > at 1. The intrinsic input load and output store base corresponds to the > temporary register nu

[Mesa-dev] [Bug 106784] 18.1.1 autotools build fail without mako

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106784 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Jason Ekstrand
Given the discussion below, I think we'll make piglit a sub-project of mesa. Those who need commit access to piglit but not mesa can be added directly to the piglit project. Unless someone objects strongly, I'll plan to migrate piglit on Thursday along with all the other mesa repos. On Mon, Jun

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Emil Velikov
On 5 June 2018 at 16:38, Eric Engestrom wrote: > On Tuesday, 2018-06-05 16:24:59 +0100, Emil Velikov wrote: >> On 5 June 2018 at 16:07, Eric Engestrom wrote: >> > On Tuesday, 2018-06-05 15:14:30 +0100, Emil Velikov wrote: >> >> From: Emil Velikov >> >> >> >> Recently the wayland-egl library and

Re: [Mesa-dev] [PATCH] virgl: enable ARB_gpu_shader_fp64

2018-06-05 Thread Gurchetan Singh
Tested-by: Gurchetan Singh Reviewed-by: Gurchetan Singh On Mon, Jun 4, 2018 at 9:32 PM Dave Airlie wrote: > > From: Dave Airlie > > This enables ARB_gpu_shader_fp64 if the host provides it. > --- > src/gallium/drivers/virgl/virgl_screen.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

[Mesa-dev] [PATCH] i965: verify intermediate steps when converting format

2018-06-05 Thread Lionel Landwerlin
An invalid format could be computed through the modifier_is_supported() helper. Better verify each step. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10664 Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 src/mesa/drivers/dri/i965/intel_scre

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 09:11:58 -0700, Jason Ekstrand wrote: > Given the discussion below, I think we'll make piglit a sub-project of > mesa. Those who need commit access to piglit but not mesa can be added > directly to the piglit project. > > Unless someone objects strongly, I'll plan to migrat

Re: [Mesa-dev] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Matt Turner
On Tue, Jun 5, 2018 at 7:14 AM, Emil Velikov wrote: > From: Emil Velikov > > Recently the wayland-egl library and pkg-config file were moved to the > Wayland repository. With that a strange conflict came to be - which one > should be used and when. > > The long term goal is to remove the Mesa cop

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Daniel Stone
Hi Eric, On 5 June 2018 at 17:49, Eric Engestrom wrote: > On Tuesday, 2018-06-05 09:11:58 -0700, Jason Ekstrand wrote: >> Given the discussion below, I think we'll make piglit a sub-project of >> mesa. Those who need commit access to piglit but not mesa can be added >> directly to the piglit pro

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/5] wayland-egl: allow shipping the library or not

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 17:17:03 +0100, Emil Velikov wrote: > On 5 June 2018 at 16:38, Eric Engestrom wrote: > > On Tuesday, 2018-06-05 16:24:59 +0100, Emil Velikov wrote: > >> On 5 June 2018 at 16:07, Eric Engestrom wrote: > >> > On Tuesday, 2018-06-05 15:14:30 +0100, Emil Velikov wrote: > >> >>

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Eric Engestrom
On Tuesday, 2018-06-05 17:52:17 +0100, Daniel Stone wrote: > Hi Eric, > > On 5 June 2018 at 17:49, Eric Engestrom wrote: > > On Tuesday, 2018-06-05 09:11:58 -0700, Jason Ekstrand wrote: > >> Given the discussion below, I think we'll make piglit a sub-project of > >> mesa. Those who need commit a

[Mesa-dev] [Bug 106823] Failed to recongnize keyword of shader code

2018-06-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106823 --- Comment #3 from Mark Janes --- Mesa passes the GLES3 variant of this test. Also, the test is listed in the following dEQP source file: android/cts/master/src/gles2-failures.txt Are we sure that this test should pass on GLES2? -- You a

Re: [Mesa-dev] [Piglit] GitLab migration of Piglit

2018-06-05 Thread Daniel Stone
On 5 June 2018 at 17:55, Eric Engestrom wrote: > On Tuesday, 2018-06-05 17:52:17 +0100, Daniel Stone wrote: >> > I assume that's now mesa, libdrm, piglit, shader-db, crucible, kmscube, >> > mesa-demos; what about igt? Anything else? >> >> We currently have under /git/mesa: >> clover.git >> crucibl

[Mesa-dev] [PATCH v8 13/21] configure.ac, meson: Check for SPIRV-Tools and llvm-spirv

2018-06-05 Thread Pierre Moreau
Reviewed-by: Karol Herbst Reviewed-by: Dylan Baker Signed-off-by: Pierre Moreau --- Notes: Changes in: * v8: * Properly align LLVMSPIRVLib comment (Dylan Baker) * Only define CLOVER_ALLOW_SPIRV when **both** dependencies are found: autotools was only requiring one

[Mesa-dev] [PATCH v8 16/21] clover/spirv: Add functions for validating SPIR-V binaries

2018-06-05 Thread Pierre Moreau
Signed-off-by: Pierre Moreau --- Notes: Changes in: * v8: Add DEFINES to libclspirv and libclover, in autotools, as they would otherwise never know whether CLOVER_ALLOW_SPIRV has been defined (Dave Airlie) * v7: Update the dependency name (meson) and the libs variable (Make

  1   2   >