Re: [Mesa-dev] [v4, 21/23] anv/batch_chain: Simplify secondary batch return chaining

Jason Ekstrand writes: > Previously, we did this weird thing where we left space and an empty > relocation for use in a hypothetical MI_BATCH_BUFFER_START that would be > added to the secondary later. Then, when it came time to chain it into > the primary, we would back that out and emit an MI_B

Re: [Mesa-dev] [PATCH v4 13/23] anv/blorp: Write relocated values into surface states

Jason Ekstrand writes: > From: Scott D Phillips > > v2 (Jason Ekstrand): > - Split the blorp bit into it's own patch and re-order a bit > - Use anv_address helpers > > Reviewed-by: Jason Ekstrand Reviewed-by: Scott D Phillips ___ mesa-dev mailing

Re: [Mesa-dev] [v4, 08/23] anv: Use an anv_address in anv_buffer_view

Jason Ekstrand writes: > Instead of storing a BO and offset separately, use an anv_address. This > changes anv_fill_buffer_surface_state to use anv_address and we now call > anv_address_physical and pass that into ISL. Reviewed-by: Scott D Phillips _

Re: [Mesa-dev] [v4,06/23] anv: Add some anv_address helpers

Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 05/23] anv: Add vma_heap allocators in anv_device

Jason Ekstrand writes: > From: Scott D Phillips > > These will be used to assign virtual addresses to soft pinned > buffers in a later patch. > > Two allocators are added for separate 'low' and 'high' virtual > memory areas. Another alternative would have been to add a > double-sided allocator,

Re: [Mesa-dev] [v4, 09/23] anv/cmd_buffer: Use anv_address for handling indirect parameters

Jason Ekstrand writes: Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [v4, 12/23] anv: Use an address for each anv_image plane

Jason Ekstrand writes: > This is better than having BO and offset fields. Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [v4, 07/23] anv: Use full anv_addresses in anv_surface_state

Jason Ekstrand writes: > This refactors surface state filling to work entirely in terms of > anv_addresses instead of offsets. This should make things simpler for > when we go to soft-pin image buffers. Among other things, > add_image_view_relocs now only cares about the addresses in the surfac

Re: [Mesa-dev] [v4,19/23] anv: Soft-pin client-allocated memory

Jason Ekstrand writes: > Now that we've done all that refactoring, addresses are now being > directly written into surface states by ISL and BLORP whenever a BO is > pinned so there's really nothing to do besides enable it. Reviewed-by: Scott D Phillips _

Re: [Mesa-dev] [v4,10/23] anv: Use an anv_address in anv_buffer

Jason Ekstrand writes: Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v4 23/23] anv: Soft-pin everything else

Jason Ekstrand writes: > From: Scott D Phillips > > v2 (Jason Ekstrand): > - Break up Scott's mega-patch > > Reviewed-by: Jason Ekstrand Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop

Re: [Mesa-dev] [v4, 20/23] anv/batch_chain: Call batch_bo_finish at the end of end_batch_buffer

Jason Ekstrand writes: > The only reason we were calling it in the middle was that one of the > cases for figuring out the secondary command buffer execution type > wanted batch_bo->length which gets set by batch_bo_finish. It's easy > enough to recalculate and now batch_bo_finish is called in a

Re: [Mesa-dev] [v4, 11/23] anv/cmd_buffer: Rework surface relocation helpers

Jason Ekstrand writes: > This commit renames add_surface_state_reloc to add_surface_reloc and > makes it takes an address. We also rename add_image_view_relocs to > add_surface_state_relocs because it takes an anv_surface_state and > doesn't really care about the image view anymore. Reviewed-by

Re: [Mesa-dev] [v4, 04/23] intel/common: Add an address de-cannonicalization helper

Jason Ekstrand writes: > --- > src/intel/common/gen_gem.h | 10 ++ > 1 file changed, 10 insertions(+) > Reviewed-by: Kenneth Graunke > > diff --git a/src/intel/common/gen_gem.h b/src/intel/common/gen_gem.h > index 842a455..eef6a5e 100644 > --- a/src/intel/common/gen_gem.h > +++ b/src/in

Re: [Mesa-dev] [v4, 17/23] anv/allocator: Set the BO flags in bo_cache_alloc/import

Jason Ekstrand writes: > It's safer to set them there because we have the opportunity to properly > handle combining flags if a BO is imported more than once. Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https

Re: [Mesa-dev] [v4, 18/23] anv/allocator: Support softpin in the BO cache

Jason Ekstrand writes: > --- > src/intel/vulkan/anv_allocator.c | 54 > +++- > 1 file changed, 53 insertions(+), 1 deletion(-) > > diff --git a/src/intel/vulkan/anv_allocator.c > b/src/intel/vulkan/anv_allocator.c > index 697da5f..f18e015 100644 > --- a/src/

Re: [Mesa-dev] [PATCH v4 22/23] anv: Soft-pin batch buffers

Jason Ekstrand writes: > From: Scott D Phillips > > Co-authored-by: Jason Ekstrand Reviewed-by: Scott D Phillips ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote: > Hi Laura, > > On 30 May 2018 at 23:53, Laura Ekstrand wrote: > > @@ -0,0 +1,9 @@ > > +pages: > > + stage: deploy > > + script: > > + - mkdir .public > > + - cp -r docs/* .public > > + - mv .public public > > You should be able to

Re: [Mesa-dev] [PATCH] android: gallium/util: fix u_debug_stack_android build

A related note on this: Seems this file (src/gallium/auxiliary/util/u_debug_stack_android.cpp) doesn't make it into the tarballs (didn't for 18.1.0). Probably needs to be added to Makefile.source and meson.build somewhere so that building the tarball finds it. I checked for commits to both since 1

Re: [Mesa-dev] [PATCH 3/3] radv: Handle GFX9 merged shaders in radv_flush_constants()

On 31 May 2018 at 21:15, Bas Nieuwenhuizen wrote: > On Thu, May 31, 2018 at 5:44 PM, Alex Smith > wrote: > > This was not previously handled correctly. For example, > > push_constant_stages might only contain MESA_SHADER_VERTEX because > > only that stage was changed by CmdPushConstants or > > C

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

On 06/01/2018 02:17 AM, Ian Romanick wrote: On 05/30/2018 10:06 AM, Samuel Pitoiset wrote: Similar for max(). Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h| 3 +++ src/compiler/nir/nir_opt_algebraic.py | 8 2 files changed, 11 insertions(+) diff --gi

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

On Thu, 2018-05-31 at 16:57 +0100, Daniel Stone wrote: > Hi Juan, > Thanks for picking this up! > > On 31 May 2018 at 16:44, Juan A. Suarez Romero wrote: > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGLDriver *drv, > > _EGLDisplay *disp, > >goto cleanup_surf; > > } > > >

Re: [Mesa-dev] [PATCH 0/2] Prevent regression with changes to nir_opt_if

Thanks! I guess you are now okay with my nir_opt_if changes? I have one minor regression with one shader of RoTR but that shouldn't matter. Series is: Reviewed-by: Samuel Pitoiset On 06/01/2018 02:21 AM, Ian Romanick wrote: This series fixes the most agregious regressions caused by the nir

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

On Thu, 2018-05-31 at 17:24 +0100, Daniel Stone wrote: > Hi Eric, > > On 31 May 2018 at 17:13, Eric Engestrom wrote: > > On Thursday, 2018-05-31 16:57:17 +0100, Daniel Stone wrote: > > > Not initialising attached_{width,height} should not cause any problems > > > with these checks. By definition

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

On Fri, 2018-06-01 at 09:39 +0100, Brendan King wrote: > The IMG patch Eric was referring to was to dEQP. I submitted bug > reports to Google and Khronos: > > https://issuetracker.google.com/issues/64059452 > > https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/594 > > I'v

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

The IMG patch Eric was referring to was to dEQP. I submitted bug reports to both Google and Khronos: https://issuetracker.google.com/issues/64059452 https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/594 I've attached the patch to this email. The problem is that the dEQP  *resize.surface_size

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

The IMG patch Eric was referring to was to dEQP. I submitted bug reports to Google and Khronos: https://issuetracker.google.com/issues/64059452 https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/594 I've attached the patch to this email. The problem is that the dEQP *resize.surface_size* tes

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #3 from Samuel Pitoiset --- Can you explain how to reproduce the crash ingame? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___

Re: [Mesa-dev] [PATCH] glsl: Add ir_binop_vector_extract in NIR

On Wed, 2018-05-30 at 15:10 -0700, Eric Anholt wrote: > "Juan A. Suarez Romero" writes: > > > Implement ir_binop_vector_extract using NIR operations. Based on SPIR-V > > to NIR approach. > > > > This fixes: > > dEQP-GLES3.functional.shaders.indexing.moredynamic.with_value_from_indexing_expressio

Re: [Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

On Thursday, 2018-05-31 14:00:24 -0700, Dylan Baker wrote: > Quoting Laura Ekstrand (2018-05-24 17:27:09) > > From: Jean Hertel > > > > This tells Sphinx how to build our website from reStructured Text. > > > > Signed-off-by: Jean Hertel > > --- > > docs/conf.py | 162 > >

Re: [Mesa-dev] [PATCH 00/16] Move the Mesa Website to Sphinx

On Thursday, 2018-05-31 21:33:16 -0400, mesa-dev-boun...@lists.freedesktop.org wrote: > On Thu, May 31, 2018 at 8:31 PM, Jordan Justen > wrote: > > On 2018-05-31 16:06:13, Laura Ekstrand wrote: > >> A little bit of messing around this afternoon, led to this: > >> https://drive.google.com/file/d/1

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

On Friday, 2018-06-01 09:43:48 +0200, Juan A. Suarez Romero wrote: > On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote: > > Hi Laura, > > > > On 30 May 2018 at 23:53, Laura Ekstrand wrote: > > > @@ -0,0 +1,9 @@ > > > +pages: > > > + stage: deploy > > > + script: > > > + - mkdir .public

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #4 from Giovanni ongaro --- How to Reproduce Crash Start Quantum break trough steam after the intro video the screen turns black for a while and then crashes before going ingame this on VEGA64 FC27 RYZEN 2700x if i start it with the

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: > If you could deal with Daniel's feedback and v3 just this patch sooner > rather than later, that would be good. I'd like to merge it before we > switch to gitlab so we can start using gitlab CI artifacts for the website > right away.

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

On 1 June 2018 at 11:10, Eric Engestrom wrote: > On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: >> If you could deal with Daniel's feedback and v3 just this patch sooner >> rather than later, that would be good. I'd like to merge it before we >> switch to gitlab so we can start usi

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

On Friday, 2018-06-01 11:16:29 +0100, Daniel Stone wrote: > On 1 June 2018 at 11:10, Eric Engestrom wrote: > > On Thursday, 2018-05-31 14:59:58 -0700, Jason Ekstrand wrote: > >> If you could deal with Daniel's feedback and v3 just this patch sooner > >> rather than later, that would be good. I'd

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: > My question then: is mandatory to call eglSwapBuffers() to ensure > wl_egl_window_get_attached_size() returns the right window size? Because I > found nothing related about this. If it is mandatory, then calling > eglSwapBuffers() in the

Re: [Mesa-dev] [PATCH] glsl: Add ir_binop_vector_extract in NIR

On Fri, 2018-06-01 at 11:25 +0200, Juan A. Suarez Romero wrote: > On Wed, 2018-05-30 at 15:10 -0700, Eric Anholt wrote: > > "Juan A. Suarez Romero" writes: > > > > > Implement ir_binop_vector_extract using NIR operations. Based on > > > SPIR-V > > > to NIR approach. > > > > > > This fixes: > > >

Re: [Mesa-dev] [PATCH] glsl: Add ir_binop_vector_extract in NIR

On Fri, 2018-06-01 at 12:26 +0200, Iago Toral wrote: > On Fri, 2018-06-01 at 11:25 +0200, Juan A. Suarez Romero wrote: > > On Wed, 2018-05-30 at 15:10 -0700, Eric Anholt wrote: > > > "Juan A. Suarez Romero" writes: > > > > > > > Implement ir_binop_vector_extract using NIR operations. Based > > >

Re: [Mesa-dev] [PATCH 00/53] intel/fs: SIMD32 support for fragment shaders

Hi, On 30.05.2018 17:30, Jason Ekstrand wrote: On May 30, 2018 06:45:29 Eero Tamminen wrote: On 29.05.2018 18:58, Eero Tamminen wrote: On 25.05.2018 00:55, Jason Ekstrand wrote: This patch series adds back-end compiler support for SIMD32 fragment shaders.  Support is added and everything wor

Re: [Mesa-dev] [PATCH v4 054/129] nir,spirv: Rework function calls

The casts are not lowered away in some of the CTS tests for radv: shader: MESA_SHADER_COMPUTE local-size: 1, 1, 1 shared-size: 1 inputs: 0 outputs: 0 uniforms: 0 shared: 0 decl_var uniform INTERP_MODE_NONE sampler2D @0 (0, 0, 0) decl_var uniform INTERP_MODE_NONE sampler2D @1 (0, 0, 1) decl_var uni

Re: [Mesa-dev] [PATCH v4 120/129] ac/nir: Remove deref chain support.

On Fri, Jun 1, 2018 at 7:07 AM, Jason Ekstrand wrote: > From: Bas Nieuwenhuizen > > --- > src/amd/common/ac_nir_to_llvm.c | 404 > +--- > 1 file changed, 50 insertions(+), 354 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_n

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

On Fri, 2018-06-01 at 10:57 +0100, Eric Engestrom wrote: > On Friday, 2018-06-01 09:43:48 +0200, Juan A. Suarez Romero wrote: > > On Thu, 2018-05-31 at 08:52 +0100, Daniel Stone wrote: > > > Hi Laura, > > > > > > On 30 May 2018 at 23:53, Laura Ekstrand wrote: > > > > @@ -0,0 +1,9 @@ > > > > +page

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

On Fri, 2018-06-01 at 11:23 +0100, Daniel Stone wrote: > Hi, > > On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: > > My question then: is mandatory to call eglSwapBuffers() to ensure > > wl_egl_window_get_attached_size() returns the right window size? Because I > > found nothing related abo

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

Hi, On 1 June 2018 at 11:23, Eric Engestrom wrote: > On Friday, 2018-06-01 11:16:29 +0100, Daniel Stone wrote: >> https://docs.gitlab.com/ee/user/project/pages/introduction.html >> > Be aware that Pages are by default branch/tag agnostic and their >> > deployment relies solely on what you specify

Re: [Mesa-dev] [PATCH v4 038/129] nir: Support deref instructions in opt_undef

On Fri, Jun 1, 2018 at 7:02 AM, Jason Ekstrand wrote: > Reviewed-by: Caio Marcelo de Oliveira Filho > --- > src/compiler/nir/nir_opt_undef.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/compiler/nir/nir_opt_undef.c > b/src/compiler/nir/nir_opt_undef.c > index b

Re: [Mesa-dev] [PATCH v4 054/129] nir,spirv: Rework function calls

Actually something post inlining that actually shows the problem: shader: MESA_SHADER_COMPUTE local-size: 1, 1, 1 shared-size: 1 inputs: 0 outputs: 0 uniforms: 0 shared: 0 decl_var uniform INTERP_MODE_NONE sampler2D @0 (0, 0, 0) decl_var uniform INTERP_MODE_NONE sampler @1 (0, 0, 1) decl_var syste

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

https://bugs.freedesktop.org/show_bug.cgi?id=106769 Bug ID: 106769 Summary: radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample Product: Mesa Version: git Hardware: Other OS: A

Re: [Mesa-dev] [PATCH v4 006/129] nir: Add helpers for working with deref instructions

On Fri, Jun 1, 2018 at 7:01 AM, Jason Ekstrand wrote: > This commit adds a pass for lowering deref instructions to deref chains > as well as some smaller helpers to ease the transition. > > Reviewed-by: Caio Marcelo de Oliveira Filho > --- > src/compiler/Makefile.sources | 1 + > src/compiler

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

https://bugs.freedesktop.org/show_bug.cgi?id=106769 --- Comment #1 from Samuel Pitoiset --- VK_EXT_shader_viewport_index_layer is already supported. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug._

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

https://bugs.freedesktop.org/show_bug.cgi?id=106769 --- Comment #2 from Philip Rebohle --- Ah right, my vulkaninfo returned info for the 18.0 version, sorry for the noise. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

[Mesa-dev] [Bug 106769] radv: Support VK_EXT_shader_viewport_index_layer and shaderStorageImageMultisample

https://bugs.freedesktop.org/show_bug.cgi?id=106769 zefkerri...@gmail.com changed: What|Removed |Added CC||zefkerri...@gmail.com -- You ar

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #5 from Bas Nieuwenhuizen --- To confirm, did you build your LLVM (32-bit is needed looks like?) with: BUILD_SHARED_LIBS=OFF LLVM_BUILD_LLVM_DYLIB=ON LLVM_LINK_LLVM_DYLIB=ON ? -- You are receiving this mail because: You are the a

[Mesa-dev] [PATCH] radv: fix a GPU hang when MRTs are sparse

When the i-th target format is set, all previous target formats must be non-zero to avoid hangs. In other words, without this if a fragment shader exports mrt0, mrt2 and mrt3, the GPU hangs because the target format of mrt1 is zero. This fixes a GPU hang with "Seven: The Days Long Gone" with DXVK.

Re: [Mesa-dev] [PATCH 06/16] docs: Add Sphinx configuration file.

Quoting Eric Engestrom (2018-06-01 02:41:36) > On Thursday, 2018-05-31 14:00:24 -0700, Dylan Baker wrote: > > Quoting Laura Ekstrand (2018-05-24 17:27:09) > > > From: Jean Hertel > > > > > > This tells Sphinx how to build our website from reStructured Text. > > > > > > Signed-off-by: Jean Hertel

Re: [Mesa-dev] [PATCH] meson: only build vl_winsys_dri.c when x11 platform is used

Quoting Lukas Rusak (2018-06-01 00:20:10) > This seems to have been missed in the move from autotools > > This fixes the following build issue: > > ../src/gallium/auxiliary/vl/vl_winsys_dri.c:34:10: fatal error: > X11/Xlib-xcb.h: No such file or directory > #include > ^~~

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

Quoting Alex Smith (2018-05-31 08:44:18) > With GFX9 merged shaders, active_stages would be set to the original > stages specified if shaders were not cached, but to the stages still > present after merging if they were. > > Be consistent and use the original stages. > > Signed-off-by: Alex Smith

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

On 1 June 2018 at 15:48, Dylan Baker wrote: > Quoting Alex Smith (2018-05-31 08:44:18) > > With GFX9 merged shaders, active_stages would be set to the original > > stages specified if shaders were not cached, but to the stages still > > present after merging if they were. > > > > Be consistent an

Re: [Mesa-dev] [PATCH v4 054/129] nir,spirv: Rework function calls

On Fri, Jun 1, 2018 at 4:51 PM, Jason Ekstrand wrote: > Can you give me an exact CI test name? I ran exactly this branch through > our CI prior to sending it out and everything passed which is really weird > given that this is happening at a fairly high level in NIR. I think I have > some notion

Re: [Mesa-dev] [PATCH] compiler/spirv: reject invalid shader code properly

Reviewed-by: Jason Ekstrand On Fri, Jun 1, 2018 at 5:27 AM, Martin Pelikán wrote: > After bebe3d626e5, b->fail_jump is prepared after vtn_create_builder > which can longjmp(3) to it through its vtx_assert()s. This corrupts > the stack and creates confusing core dumps, so we need to avoid it. >

[Mesa-dev] [PATCH v3 0/5] Implement ARB_sample_locations for nvc0

This patch set adds support for GL_ARB_sample_locations in mesa core, gallium, the mesa OpenGL state tracker and the nvc0 driver. Changes in v3: - Fix non-althabetical order of new extensions in extensions_table.h - Implement glEvaluateDepthValuesARB()/glResolveDepthValuesNV() - Stylistic changes

[Mesa-dev] [PATCH v3 2/5] gallium: add support for programmable sample locations

Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) Reviewed-by: Marek Olšák (v2) --- src/gallium/auxiliary/util/u_framebuffer.c | 30 + src/gallium/auxiliary/util/u_framebuffer.h | 5 +++ src/gallium/docs/source/context.rst | 14 src/galliu

[Mesa-dev] [PATCH v3 1/5] mesa: add support for ARB_sample_locations

Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) Reviewed-by: Marek Olšák (v2) --- src/mapi/glapi/gen/gl_API.xml | 104 + src/mesa/main/config.h | 9 ++ src/mesa/main/dd.h | 8 + src/mesa/main/extensions_table.h| 2

[Mesa-dev] [PATCH v3 3/5] st/mesa: add support for ARB_sample_locations

Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) Reviewed-by: Marek Olšák (v2) --- src/mesa/state_tracker/st_atom.h | 2 +- src/mesa/state_tracker/st_atom_list.h | 2 +- src/mesa/state_tracker/st_atom_msaa.c | 77 +- src/mesa/state_tracker/st_cb_f

[Mesa-dev] [PATCH v3 4/5] nvc0: add support for programmable sample locations

Signed-off-by: Rhys Perry --- .../drivers/nouveau/codegen/nv50_ir_driver.h | 2 + .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 7 + .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 102 -- .../nouveau/codegen/nv50_ir_lowering_nvc0.h| 2 + src/gallium/dr

[Mesa-dev] [PATCH v3 5/5] docs: document addition of GL_ARB_sample_locations for nvc0

Signed-off-by: Rhys Perry Reviewed-by: Brian Paul (v2) --- docs/features.txt | 2 +- docs/relnotes/18.2.0.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index e786bbecf4..2eac14fb32 100644 --- a/docs/features.txt +++ b/do

Re: [Mesa-dev] [PATCH] compiler/spirv: reject invalid shader code properly

And pushed. On Fri, Jun 1, 2018 at 8:04 AM, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > > On Fri, Jun 1, 2018 at 5:27 AM, Martin Pelikán wrote: > >> After bebe3d626e5, b->fail_jump is prepared after vtn_create_builder >> which can longjmp(3) to it through its vtx_assert()s. This cor

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

On 01/06/18 12:09, Juan A. Suarez Romero wrote: On Fri, 2018-06-01 at 11:23 +0100, Daniel Stone wrote: Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: My question then: is mandatory to call eglSwapBuffers() to ensure wl_egl_window_get_attached_size() returns the right window size? B

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

On 01/06/18 12:09, Juan A. Suarez Romero wrote: On Fri, 2018-06-01 at 11:23 +0100, Daniel Stone wrote: Hi, On 1 June 2018 at 09:47, Juan A. Suarez Romero wrote: My question then: is mandatory to call eglSwapBuffers() to ensure wl_egl_window_get_attached_size() returns the right window size?

[Mesa-dev] [ANNOUNCE] mesa 18.1.1

Hi List, 18.1.1 is now available. In this release we have: Numerous fixes for radv, a few fixes for i965, tegra, amd/addrlib, dri3, virgl, tgsi, nv30, opencl, core mesa, core vulkan, st/mesa, etnaviv and spirv all got fixes. A few specifically: Radv fixed one extension and several features on

Re: [Mesa-dev] [PATCH] wayland/egl: initialize window surface size to window size

Hi, On 1 June 2018 at 15:35, Brendan King wrote: > IMG has a similar patch to the one you describe, but without the changes to > the resize_callback, so just this bit: > > @@ -255,6 +257,12 @@ dri2_wl_create_window_surface(_EGLDriver *drv, > _EGLDisplay *disp, >goto cleanup_surf; > }

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

Quoting Alex Smith (2018-06-01 07:56:38) > On 1 June 2018 at 15:48, Dylan Baker wrote: > > Quoting Alex Smith (2018-05-31 08:44:18) > > With GFX9 merged shaders, active_stages would be set to the original > > stages specified if shaders were not cached, but to the stages still > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

On 06/01/2018 05:48 PM, Dylan Baker wrote: Quoting Alex Smith (2018-06-01 07:56:38) On 1 June 2018 at 15:48, Dylan Baker wrote: Quoting Alex Smith (2018-05-31 08:44:18) > With GFX9 merged shaders, active_stages would be set to the original > stages specified if shaders were no

Re: [Mesa-dev] [ANNOUNCE] mesa 18.1.1

On Fri, 2018-06-01 at 08:33 -0700, Dylan Baker wrote: > Hi List, > > 18.1.1 is now available. > A couple of points about the announcement :) - It doesn't contain the author list (like in git short log) - You didn't send the required pre-announcement, that should happen 48h before the final rel

Re: [Mesa-dev] [PATCH v4 120/129] ac/nir: Remove deref chain support.

On Fri, Jun 1, 2018 at 3:57 AM, Bas Nieuwenhuizen wrote: > On Fri, Jun 1, 2018 at 7:07 AM, Jason Ekstrand > wrote: > > From: Bas Nieuwenhuizen > > > > --- > > src/amd/common/ac_nir_to_llvm.c | 404 +- > -- > > 1 file changed, 50 insertions(+), 354 deletions(

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

On 1 June 2018 at 16:58, Samuel Pitoiset wrote: > > > On 06/01/2018 05:48 PM, Dylan Baker wrote: > >> Quoting Alex Smith (2018-06-01 07:56:38) >> >>> On 1 June 2018 at 15:48, Dylan Baker wrote: >>> >>> Quoting Alex Smith (2018-05-31 08:44:18) >>> > With GFX9 merged shaders, active_stag

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

On Wed, May 30, 2018 at 10:06 AM, Samuel Pitoiset wrote: > Similar for max(). > > Signed-off-by: Samuel Pitoiset What are the shader-db results? That should be in the commit message. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://list

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

On 06/01/2018 06:47 PM, Matt Turner wrote: On Wed, May 30, 2018 at 10:06 AM, Samuel Pitoiset wrote: Similar for max(). Signed-off-by: Samuel Pitoiset What are the shader-db results? That should be in the commit message. In the second one?

Re: [Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

On Thursday, 2018-05-31 10:04:25 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-05-31 07:04:33) > > Some people have mentioned they don't like the current get_reviewers.pl > > script (the one from the kernel) because it is way too greedy in its > > search for reviewers. > > > > I tried t

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

On Fri, Jun 1, 2018 at 9:50 AM, Samuel Pitoiset wrote: > On 06/01/2018 06:47 PM, Matt Turner wrote: >> On Wed, May 30, 2018 at 10:06 AM, Samuel Pitoiset >> wrote: >>> >>> Similar for max(). >>> >>> Signed-off-by: Samuel Pitoiset >> >> >> What are the shader-db results? That should be in the comm

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] radv: Set active_stages the same whether or not shaders were cached

On 06/01/2018 06:28 PM, Alex Smith wrote: On 1 June 2018 at 16:58, Samuel Pitoiset > wrote: On 06/01/2018 05:48 PM, Dylan Baker wrote: Quoting Alex Smith (2018-06-01 07:56:38) On 1 June 2018 at 15:48, Dylan Baker mailto:dy...@pnwbak

Re: [Mesa-dev] [PATCH v4 006/129] nir: Add helpers for working with deref instructions

On Fri, Jun 1, 2018 at 6:03 AM, Bas Nieuwenhuizen wrote: > On Fri, Jun 1, 2018 at 7:01 AM, Jason Ekstrand > wrote: > > This commit adds a pass for lowering deref instructions to deref chains > > as well as some smaller helpers to ease the transition. > > > > Reviewed-by: Caio Marcelo de Oliveira

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

Daniel, I literally just followed the example: https://docs.gitlab.com/ee/ci/yaml/#pages As I recall, there's a recursive loop if you don't use .public. On Fri, Jun 1, 2018, 4:17 AM Daniel Stone wrote: > Hi, > > On 1 June 2018 at 11:23, Eric Engestrom wrote: > > On Friday, 2018-06-01 11:16:2

[Mesa-dev] [Bug 106756] Wine 3.9 crashes with DXVK on Just Cause 3 and Quantum Break on VEGA but works ON POLARIS

https://bugs.freedesktop.org/show_bug.cgi?id=106756 --- Comment #6 from Giovanni ongaro --- I did build with BUILD_SHARED_LIBS=on and 64 bits is required Inviato da smartphone Samsung Galaxy. Messaggio originale Da: bugzilla-dae...@freedesktop.org Data: 01/06/18 15:37 (GMT+01

[Mesa-dev] [PATCH] glx: Fix number of property values to read in glXImportContextEXT

From: Michel Dänzer We were trying to read twice as many as the X server sent us, which upset XCB: [xcb] Too much data requested from _XRead [xcb] This is most likely caused by a broken X extension library [xcb] Aborting, sorry about that. glx-free-context: ../../src/xcb_io.c:732: _XRead: Assert

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

Samuel Pitoiset writes: > On 06/01/2018 02:17 AM, Ian Romanick wrote: >> On 05/30/2018 10:06 AM, Samuel Pitoiset wrote: >>> Similar for max(). >>> >>> Signed-off-by: Samuel Pitoiset >>> --- >>> src/compiler/nir/nir.h| 3 +++ >>> src/compiler/nir/nir_opt_algebraic.py | 8 ++

Re: [Mesa-dev] [PATCH v2 01/15] Added ci yaml file for Gitlab.

On Fri, Jun 1, 2018 at 9:57 AM, Laura Ekstrand wrote: > Daniel, > > I literally just followed the example: > > https://docs.gitlab.com/ee/ci/yaml/#pages > > As I recall, there's a recursive loop if you don't use .public. > Ah, I see what's going on. The glob character "*" will list all director

Re: [Mesa-dev] [PATCH 1/2] nir: optimize min(min(a, b), c) to min3(a, b, c) under an option

On 06/01/2018 10:17 AM, Eric Anholt wrote: > Samuel Pitoiset writes: > >> On 06/01/2018 02:17 AM, Ian Romanick wrote: >>> On 05/30/2018 10:06 AM, Samuel Pitoiset wrote: Similar for max(). Signed-off-by: Samuel Pitoiset --- src/compiler/nir/nir.h| 3 +++

Re: [Mesa-dev] [PATCH 2/2] nir: add opt_if_loop_terminator()

On 05/31/2018 10:37 PM, Timothy Arceri wrote: > This pass detects potential loop terminators and moves intructions > from the non breaking branch after the if. > > This enables both the new opt_if_simplification() pass and loop > unrolling to potentially progress further. > > Unexpectedly this ch

Re: [Mesa-dev] [PATCH mesa 3/5] bin: rewrite get_reviewers as opt-in only

Quoting Eric Engestrom (2018-06-01 09:50:34) > On Thursday, 2018-05-31 10:04:25 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-05-31 07:04:33) > > > Some people have mentioned they don't like the current get_reviewers.pl > > > script (the one from the kernel) because it is way too greed

[Mesa-dev] [PATCH 2/3] trace: Fix parsing of recent traces.

--- src/gallium/tools/trace/dump_state.py | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/gallium/tools/trace/dump_state.py b/src/gallium/tools/trace/dump_state.py index 4531843279e..2622d130bf8 100755 --- a/src/gallium/tools/trace/dump_state.p

[Mesa-dev] [PATCH 3/3] scons: Fix MinGW cross compilation with LLVM 5.0.

LLVM 5.0 requires additional Win32 libraries, and MinGW with pthreads. --- scons/llvm.py | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scons/llvm.py b/scons/llvm.py index 79118be371d..a34edfb4b67 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -123,6 +123,10 @@ def

[Mesa-dev] [PATCH 1/3] trace: Fix trace_context_transfer_unmap methods.

The emitted buffer_subdata/texture_subdata call didn't match the respective signatures. --- .../auxiliary/driver_trace/tr_context.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/gallium/auxiliary/driver_trace/tr_context.c b/src/gallium/auxilia

[Mesa-dev] [PATCH v4.1 18/23] anv/allocator: Support softpin in the BO cache

--- src/intel/vulkan/anv_allocator.c | 51 +++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index 697da5f..117851f 100644 --- a/src/intel/vulkan/anv_allocator.c +++ b/src/intel

[Mesa-dev] [PATCH 002.1/129] FIXUP! Check the deref type first in is_trivial_deref_cast

--- src/compiler/nir/nir_opt_copy_propagate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_opt_copy_propagate.c b/src/compiler/nir/nir_opt_copy_propagate.c index c35e8e1..c8821c3 100644 --- a/src/compiler/nir/nir_opt_copy_propagate.c +++ b/src/com

[Mesa-dev] [PATCH 006.1/129] FIXUP! Don't reach through casts in get_variable

If something uses get_variable, it's likely that it doesn't know what to do with casts. If there are any casts in the chain, just return NULL. --- src/compiler/nir/nir.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index

[Mesa-dev] [PATCH 054.1/129] FIXUP! spirv: Use the right storage class for image pointers

The special case in load_param_pointer is for images and samplers which are definitely in the UniformConstant storage class. --- src/compiler/spirv/vtn_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 6c411c

Re: [Mesa-dev] [PATCH 006.1/129] FIXUP! Don't reach through casts in get_variable

On Fri, Jun 1, 2018 at 3:39 PM, Jason Ekstrand wrote: > If something uses get_variable, it's likely that it doesn't know what to > do with casts. If there are any casts in the chain, just return NULL. > --- > src/compiler/nir/nir.h | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >

[Mesa-dev] [Bug 106774] NIR "copy propagates" loads of SSBOs

https://bugs.freedesktop.org/show_bug.cgi?id=106774 Bug ID: 106774 Summary: NIR "copy propagates" loads of SSBOs Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Pr

[Mesa-dev] [PATCH] meson: only build vl_winsys_dri.c when x11 platform is used

This seems to have been missed in the move from autotools This fixes the following build issue: ../src/gallium/auxiliary/vl/vl_winsys_dri.c:34:10: fatal error: X11/Xlib-xcb.h: No such file or directory #include ^~~~ --- src/gallium/auxiliary/meson.build | 2 +- 1 file ch

  1   2   >