Re: [Mesa-dev] [PATCH] radeon/vcn: use enc profile instead of pic profile

Am 28.02.2018 um 00:56 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Picture profile might not be set in some cases. Therefore, better to use the profile stored in encoder base. Signed-off-by: Boyuan Zhang NAK, when the picture profile isn't set the picture structure isn't valid. Please

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

https://bugs.freedesktop.org/show_bug.cgi?id=104302 --- Comment #10 from gloriouseggr...@gmail.com --- to clarify on my previous post, this is -WITH- Samuel Pitoiset's two out of tree patches -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH v4] anv: enable VK_EXT_shader_stencil_export

Reviewed-by: Iago Toral Quiroga On Tue, 2018-02-27 at 22:34 -0800, Gustavo Lima Chaves wrote: > v2: > An attempt to support SpvExecutionModeStencilRefReplacingEXT's > behavior > also follows, with the interpretation to said mode being we prevent > writes to the built-in FragStencilRefEXT variable

Re: [Mesa-dev] [RFC 1/2] spirv: add/hookup SpvCapabilityStencilExportEXT

Reviewed-by: Iago Toral Quiroga On Sun, 2018-02-11 at 18:26 -0800, Gustavo Lima Chaves wrote: > --- > src/compiler/shader_info.h | 1 + > src/compiler/spirv/spirv_to_nir.c | 4 > src/compiler/spirv/vtn_variables.c | 4 > 3 files changed, 9 insertions(+) > > diff --git a/src/c

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

https://bugs.freedesktop.org/show_bug.cgi?id=104302 --- Comment #11 from Samuel Pitoiset --- Yeah, so that makes sense. Thanks for testing :-) By the way, here's a potential fix for the shoot issue https://reviews.llvm.org/D43831 -- You are receiving this mail because: You are the QA Contact f

Re: [Mesa-dev] [PATCH v4] anv: enable VK_EXT_shader_stencil_export

Reviewed-by: Samuel Iglesias Gonsálvez On 28/02/18 07:34, Gustavo Lima Chaves wrote: > v2: > An attempt to support SpvExecutionModeStencilRefReplacingEXT's behavior > also follows, with the interpretation to said mode being we prevent > writes to the built-in FragStencilRefEXT variable when the

Re: [Mesa-dev] [PATCH] radv/gfx9: add a workaround for viewing a slice of 3D as a 2D image

On 02/27/2018 04:09 PM, Marek Olšák wrote: On Mon, Feb 26, 2018 at 11:50 PM, Dave Airlie wrote: On 26 February 2018 at 23:04, Samuel Pitoiset wrote: Ported from RadeonSI. That doesn't fix anything known but I think we need it. I'd really like it to fix something :-) How come we don't al

[Mesa-dev] [PATCH v4 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

When multiview is active a subpass clear may only clear a subset of the attachment layers. Other subpasses in the same render pass may also clear too and we want to honor those clears as well, however, we need to ensure that we only clear a layer once, on the first subpass that uses a particular la

[Mesa-dev] [PATCH v4 2/2] anv/cmd_buffer: honor pending clear views for depth/stencil attachments

v2: rebased on top of subpass rework. v3: rebased --- src/intel/vulkan/genX_cmd_buffer.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index c422ec8e1a..cf02c207dc 100644 --- a/sr

Re: [Mesa-dev] [PATCH 19/22] i965/fs: Merge CMP and SEL into CSEL on Gen8+

Reviewed-by: Samuel Iglesias Gonsálvez On 24/02/18 00:56, Ian Romanick wrote: > From: Ian Romanick > > Skylake > total instructions in shared programs: 14514547 -> 14503025 (-0.08%) > instructions in affected programs: 2008312 -> 1996790 (-0.57%) > helped: 5816 > HURT: 0 > helped stats (abs) m

Re: [Mesa-dev] [PATCH 18/22] i965/fs: Add infrastructure for generating CSEL instructions.

On 24/02/18 00:56, Ian Romanick wrote: > From: Kenneth Graunke > > v2 (idr): Don't allow CSEL with a non-float src2. > > v3 (idr): Add CSEL to fs_inst::flags_written. Suggested by Matt. > > Signed-off-by: Kenneth Graunke > Signed-off-by: Ian Romanick > --- > src/intel/compiler/brw_eu.h

Re: [Mesa-dev] [PATCH 15/22] nir: Use De Morgan's Law on logic compounded comparisons

Reviewed-by: Samuel Iglesias Gonsálvez On 24/02/18 00:56, Ian Romanick wrote: > From: Ian Romanick > > The replacement of the comparison operators must happen during this > step. If it does not, the next pass of nir_opt_algebraic will reapply > De Morgan's Law in the "opposite direction" befor

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

On Tuesday, 2018-02-27 18:01:11 +, Daniel Stone wrote: > On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as > 'aarch64'), only build swrast for DRI drivers. The commit message and the code don't align anymore in v2; which one was intended? > The only classic drivers > whic

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

Hi, On 28 February 2018 at 09:33, Eric Engestrom wrote: > On Tuesday, 2018-02-27 18:01:11 +, Daniel Stone wrote: >> On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as >> 'aarch64'), only build swrast for DRI drivers. > > The commit message and the code don't align anymore

Re: [Mesa-dev] [PATCH] radeonsi: fix radeon create encoder return

On Tuesday, 2018-02-27 17:43:56 -0500, boyuan.zh...@amd.com wrote: > From: Boyuan Zhang > > Previous patch missed a "return" when trying to modify the create encoder > function, which made the whole logic fail. Therefore, add the return back. > > Signed-off-by: Boyuan Zhang Fixes: b38b208ff888

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

What is the idea for src/intel/dev/ ? I'm not against this patch, just asking. Patches 2-4 are, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 27/02/18 21:32, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/intel/Android.dev.mk | 35 > +

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

On Fri, Jan 19, 2018 at 12:51:30AM +0300, Greg V wrote: > On 01/18/2018 22:49, Dylan Baker wrote: > > Quoting Emil Velikov (2018-01-18 10:40:40) > > > On 18 January 2018 at 17:13, Dylan Baker wrote: > > > > I'm not sure how Emil feels about this (and the related patches) but I > > > > think it >

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

On 28/02/18 10:58, Samuel Iglesias Gonsálvez wrote: > > What is the idea for src/intel/dev/ ? > > I'm not against this patch, just asking. > Anyway, this patch has my R-b too. Sam > Patches 2-4 are, > > Reviewed-by: Samuel Iglesias Gonsálvez > > Sam > > > On 27/02/18 21:32, Jordan Justen wrote:

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

On Wednesday, 2018-02-28 09:36:51 +, Daniel Stone wrote: > Hi, > > On 28 February 2018 at 09:33, Eric Engestrom > wrote: > > On Tuesday, 2018-02-27 18:01:11 +, Daniel Stone wrote: > >> On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as > >> 'aarch64'), only build swra

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: > What is the idea for src/intel/dev/ ? > > I'm not against this patch, just asking. Ken noticed a lot of duplicate lines in the xml for surface formats. (Patch 4). But, then we noticed that removing them makes aubinator fail to nicely prin

[Mesa-dev] [PATCH] util: use clock_gettime() on PIPE_OS_BSD

OpenBSD, FreeBSD, NetBSD and DragonFlyBSD all have clock_gettime() so use it when PIPE_OS_BSD is defined. Signed-off-by: Jonathan Gray --- src/util/os_time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/os_time.c b/src/util/os_time.c index 72dc7e49c0..ac488b2287 1

[Mesa-dev] [PATCH] gallium/util: use sockets on PIPE_OS_UNIX in u_network

Instead of listing all the UNIX PIPE_OS platforms just use PIPE_OS_UNIX. Makes BSD sockets available on PIPE_OS_BSD. Signed-off-by: Jonathan Gray --- src/gallium/auxiliary/util/u_network.c | 9 +++-- src/gallium/auxiliary/util/u_network.h | 5 + 2 files changed, 4 insertions(+), 10 dele

Re: [Mesa-dev] [PATCH v2 1/8] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit

On 27/02/18 19:53, Jason Ekstrand wrote: > On Tue, Feb 27, 2018 at 5:27 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > The surfaces that backup the GPU buffers have a boundary check that > considers that access to partial dwords are considered out-of-bounds. >

Re: [Mesa-dev] [PATCH 2/2] softpipe: don't iterate through PIPE_MAX_SHADER_SAMPLER_VIEWS

On 28/02/18 04:08, srol...@vmware.com wrote: From: Roland Scheidegger We were setting view to NULL if the iteration was larger than i. But in fact if the view is NULL the code did nothing anyway... --- src/gallium/drivers/softpipe/sp_state_sampler.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

On 28/02/18 11:15, Jordan Justen wrote: > On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: >> What is the idea for src/intel/dev/ ? >> >> I'm not against this patch, just asking. > Ken noticed a lot of duplicate lines in the xml for surface formats. > (Patch 4). But, then we noticed that

Re: [Mesa-dev] [PATCH v2 2/8] i965/fs: shuffle_32bit_load_result_to_16bit_data now skips components

On 27/02/18 20:00, Jason Ekstrand wrote: > On Tue, Feb 27, 2018 at 5:27 AM, Jose Maria Casanova Crespo > mailto:jmcasan...@igalia.com>> wrote: > > This helper used to load 16bit components from 32-bits read now allows > skipping components with the new parameter first_component. The >

[Mesa-dev] Status of radeonsi NIR

Hi all, I thought I'd provide a quick status overview of the radeonsi NIR backend. I'll attempt to list all outstanding tasks (that I'm aware of) so if you are interested in working on one of those just give me a heads up so we don't overlap. Also feel free to reply with any feedback on perf

Re: [Mesa-dev] [PATCH] RFC: gallium: increase PIPE_MAX_SHADER_SAMPLER_VIEWS to 128

On 27/02/18 02:38, srol...@vmware.com wrote: From: Roland Scheidegger Some state trackers require 128. (There are no plans to increase PIPE_MAX_SAMPLERS too, since with gl state tracker it's unlikely more than 32 will be needed, if you need more use bindless.) --- src/gallium/include/pipe/p_s

[Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

Patch by "Tomas Chvatal" with modifications by "Michal Srb" to not break python 2. https://bugzilla.suse.com/show_bug.cgi?id=1082303 v2: - open parse file in binary mode (default changed from binary to unicode text mode with python3) - make use of 'from __future__ import print_function', so s

Re: [Mesa-dev] [Mesa-users] GraphicsFuzz metamorphic testing of shader compilers

Hi Brian, all, Thanks for the follow-up, and congrats to the team for the prompt bug fix! We've just tweeted about it: https://twitter.com/GraphicsFuzz/status/968815766681333760 We'll be pleased to report further Mesa issues as we find them, yet as a three-people team we unfortunately do not have

Re: [Mesa-dev] [PATCH] r600/egd_tables.py: make the script python 2+3 compatible

On Wed, Feb 28, 2018 at 12:12:25PM +0100, Stefan Dirsch wrote: > Patch by "Tomas Chvatal" with modifications > by "Michal Srb" to not break python 2. > > https://bugzilla.suse.com/show_bug.cgi?id=1082303 > > v2: > - open parse file in binary mode (default changed from binary to unicode > text

[Mesa-dev] [PATCH v2 3/8] i965/fs: Support 16-bit do_read_vector with VK_KHR_relaxed_block_layout (v3)

16-bit load_ubo/ssbo operations that call do_untyped_read_vector don't guarantee that offsets are multiple of 4-bytes as required by untyped_read message. This happens for example in the case of f16mat3x3 when then VK_KHR_relaxed_block_layout is enabled. Vectors reads when we have non-constant off

Re: [Mesa-dev] [PATCH] radeon/vcn: use enc profile instead of pic profile

Boyuan, please also make sure whether this patch along with other one are needed to Cc stable or not. Regards, Leo On 02/28/2018 03:03 AM, Christian König wrote: Am 28.02.2018 um 00:56 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Picture profile might not be set in some cases. Therefore

[Mesa-dev] [PATCH] gallium/aux/hud: Avoid possible buffer overflow

Limit the length of acceptable cpu names for use in hud_get_num_cpufreq in order to avoid a buffer overflow later in add_object when this name is copied into cpufreq_info::name. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105274 Signed-off-by: Gert Wollny --- Submitter has no git writ

Re: [Mesa-dev] [PATCH 08/21] intel/isl: Implement correct tile size calculations for Ys/Yf

On Tue, Feb 27, 2018 at 11:42:48AM -0800, Jason Ekstrand wrote: > On Tue, Feb 27, 2018 at 6:13 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Thu, Feb 22, 2018 at 11:06:48PM -0800, Jason Ekstrand wrote: > > > The tile size calculations use a clever bit of math to make them s

[Mesa-dev] [Bug 105291] r600 [CEDAR]: GPU stalls when running shadertoy "ladybug"

https://bugs.freedesktop.org/show_bug.cgi?id=105291 Bug ID: 105291 Summary: r600 [CEDAR]: GPU stalls when running shadertoy "ladybug" Product: Mesa Version: git Hardware: Other URL: https://www.shadertoy.com/

[Mesa-dev] [PATCH] ttn: remove {varying_slot, frag_result}_to_tgsi_semantic helpers

From: Emil Velikov The respective drivers have been updated and the helpers are no longer needed. Signed-off-by: Emil Velikov --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 73 - src/gallium/auxiliary/nir/tgsi_to_nir.h | 6 --- 2 files changed, 79 deletions(-)

[Mesa-dev] [Bug 105292] vkGetQueryPoolResults returns incorrect query status for large query buffers (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=105292 Bug ID: 105292 Summary: vkGetQueryPoolResults returns incorrect query status for large query buffers (bisected) Product: Mesa Version: git Hardware: Other

Re: [Mesa-dev] [PATCH] RFC: gallium: increase PIPE_MAX_SHADER_SAMPLER_VIEWS to 128

Am 28.02.2018 um 11:54 schrieb Jose Fonseca: > On 27/02/18 02:38, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Some state trackers require 128. >> (There are no plans to increase PIPE_MAX_SAMPLERS too, since with gl >> state tracker it's unlikely more than 32 will be needed, if you

Re: [Mesa-dev] [PATCH] gallium/util: use sockets on PIPE_OS_UNIX in u_network

On 02/28/2018 03:21 AM, Jonathan Gray wrote: Instead of listing all the UNIX PIPE_OS platforms just use PIPE_OS_UNIX. Makes BSD sockets available on PIPE_OS_BSD. Signed-off-by: Jonathan Gray --- src/gallium/auxiliary/util/u_network.c | 9 +++-- src/gallium/auxiliary/util/u_network.h | 5

Re: [Mesa-dev] [PATCH] util: use clock_gettime() on PIPE_OS_BSD

On 02/28/2018 03:19 AM, Jonathan Gray wrote: OpenBSD, FreeBSD, NetBSD and DragonFlyBSD all have clock_gettime() so use it when PIPE_OS_BSD is defined. Signed-off-by: Jonathan Gray --- src/util/os_time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/os_time.c b/

Re: [Mesa-dev] [PATCH] [RFC] gallivm: Use new LLVM fast-math-flags API

Hi, Could this (commit 5d61fa4e68b7eb6d481a37efdbb35fdce675a6ad on master) be backported to the 17.3 branch to allow it to build with LLVM 6? Thanks, Alex On 6 November 2017 at 21:16, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek > > On Mon, Nov 6, 2017 at 10:09 PM, Tobias Droste w

Re: [Mesa-dev] [PATCH 1/2] cso: don't cycle through PIPE_MAX_SHADER_SAMPLER_VIEWS on context destroy

On 02/27/2018 09:08 PM, srol...@vmware.com wrote: From: Roland Scheidegger There's no point, we know the highest non-null one. --- src/gallium/auxiliary/cso_cache/cso_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/cso_cache/cso_context.

[Mesa-dev] [PATCH] svga: fix blending regression

The earlier Mesa commit 3d06c8afb5 ("st/mesa: don't translate blend state when it's disabled for a colorbuffer") subtly changed the details of gallium's per-RT blend state. In particular, when pipe_rt_blend_state[i].blend_enabled is true, we have to get the src/dst blend terms from pipe_rt_blend_s

Re: [Mesa-dev] [PATCH] r600/shader: when using images always load thread id gpr at start (v2)

For me this also fixed tests/spec/arb_compute_shader/execution/ multiple-texture-reading.shader_test With that Tested-by: Gert Wollny Am Mittwoch, den 28.02.2018, 16:47 +1000 schrieb Dave Airlie: > From: Dave Airlie > > The delayed loading code was fail if we had control flow. >

Re: [Mesa-dev] [PATCH] svga: fix blending regression

Can st/mesa instead be fixed to maintain the original API? Other drivers look in rt[0] in the non-independent_blend_enable case. For example, freedreno and nouveau. On Wed, Feb 28, 2018 at 10:29 AM, Brian Paul wrote: > The earlier Mesa commit 3d06c8afb5 ("st/mesa: don't translate blend > state wh

[Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

3 digits versions in LLVM only started from 3.4.1 on. Hence, if you have installed 3.4 or below, meson will fail even when we may not make use of LLVM. Cc: Dylan Baker Cc: Eric Engestrom Signed-off-by: Andres Gomez --- meson.build | 13 - 1 file changed, 12 insertions(+), 1 deletio

[Mesa-dev] [PATCH 0/2] travis: make meson Vulkan build again

The "meson Vulkan" target has been failing for quite long. These 2 patches will make it work again. Andres Gomez (2): meson: fix LLVM version detection when <= 3.4 travis: make Meson find the proper llvm-config .travis.yml | 28 meson.build | 13 - 2

[Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

Travis CI has moved to LLVM 5.0, and meson is detecting automatically the available version in /usr/local/bin based on the PATH env variable order preference. As for 0.44.x, Meson cannot receive the path to the llvm-config binary as a configuration parameter. See https://github.com/mesonbuild/meso

[Mesa-dev] [Bug 105292] vkGetQueryPoolResults returns incorrect query status for large query buffers (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=105292 --- Comment #1 from Samuel Pitoiset --- Yeah, I think it's because we don't emit the cache flushes after resetting the query pool with a compute shader. -- You are receiving this mail because: You are the QA Contact for the bug. You are the as

[Mesa-dev] [Bug 105292] vkGetQueryPoolResults returns incorrect query status for large query buffers (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=105292 --- Comment #2 from Samuel Pitoiset --- Created attachment 137690 --> https://bugs.freedesktop.org/attachment.cgi?id=137690&action=edit workaround This fixes the issue for me, but I will probably come with a better solution a bit later. --

Re: [Mesa-dev] [PATCH 05/21] intel/isl: Use a 4D physical total extent for size calculations

On Tue, Feb 27, 2018 at 11:48:51AM -0800, Jason Ekstrand wrote: > On Tue, Feb 27, 2018 at 4:33 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Thu, Feb 22, 2018 at 11:06:45PM -0800, Jason Ekstrand wrote: > > > With Yf and Ys tiling, everything is actually four dimensional bec

Re: [Mesa-dev] [PATCH 06/21] intel/isl: Expose isl_tiling_get_info

On Tue, Feb 27, 2018 at 02:40:46PM +0200, Pohjolainen, Topi wrote: > On Thu, Feb 22, 2018 at 11:06:46PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/isl/isl.c | 7 +-- > > src/intel/isl/isl.h | 7 +++ > > 2 files changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/src/int

Re: [Mesa-dev] [PATCH 11/21] intel/isl: Use the depth field of phys_level0_sa for GEN4_2D 3D surfaces

On Thu, Feb 22, 2018 at 11:06:51PM -0800, Jason Ekstrand wrote: > This makes things a tiny bit stickier in isl_calc_phys_total_extent_el > but will be worth it when we enable Yf and Ys. > --- > src/intel/isl/isl.c | 18 +++--- > 1 file changed, 3 insertions(+), 15 deletions(-) > > dif

Re: [Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

On Wednesday, 2018-02-28 17:52:06 +0200, Andres Gomez wrote: > Travis CI has moved to LLVM 5.0, and meson is detecting automatically > the available version in /usr/local/bin based on the PATH env variable > order preference. > > As for 0.44.x, Meson cannot receive the path to the llvm-config bina

[Mesa-dev] [PATCH] radv: make sure to emit cache flushes before starting a query

If the query pool has been previously resetted using the compute shader path. Fixes: a41e2e9cf5 ("radv: allow to use a compute shader for resetting the query pool") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105292 Cc: "18.0" Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_p

[Mesa-dev] [Bug 105292] vkGetQueryPoolResults returns incorrect query status for large query buffers (bisected)

https://bugs.freedesktop.org/show_bug.cgi?id=105292 --- Comment #3 from Samuel Pitoiset --- Here's the fix https://patchwork.freedesktop.org/patch/207416/ -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

Re: [Mesa-dev] [PATCH v2 3/8] i965/fs: Support 16-bit do_read_vector with VK_KHR_relaxed_block_layout (v3)

Reviewed-by: Jason Ekstrand On Wed, Feb 28, 2018 at 5:38 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > 16-bit load_ubo/ssbo operations that call do_untyped_read_vector don't > guarantee that offsets are multiple of 4-bytes as required by untyped_read > message. This happens fo

Re: [Mesa-dev] [PATCH v2 1/8] isl/i965/fs: SSBO/UBO buffers need size padding if not multiple of 32-bit

On Wed, Feb 28, 2018 at 2:24 AM, Chema Casanova wrote: > On 27/02/18 19:53, Jason Ekstrand wrote: > > On Tue, Feb 27, 2018 at 5:27 AM, Jose Maria Casanova Crespo > > mailto:jmcasan...@igalia.com>> wrote: > > > > The surfaces that backup the GPU buffers have a boundary check that > > consi

Re: [Mesa-dev] [PATCH v2 0/8] anv: VK_KHR_16bit_storage enabling SSBO/UBO/PushConstant

I think all the interesting patches are reviewed now. All the boring "turn stuff on" patches are Reviewed-by: Jason Ekstrand On Tue, Feb 27, 2018 at 5:27 AM, Jose Maria Casanova Crespo < jmcasan...@igalia.com> wrote: > This v2 series includes several fixes to allow enabling the > VK_KHR_16bit_

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > have installed 3.4 or below, meson will fail even when we may not make > use of LLVM. > > Cc: Dylan Baker > Cc: Eric Engestrom > Signed-off-by: Andres Gomez > ---

Re: [Mesa-dev] [PATCH 06/21] intel/isl: Expose isl_tiling_get_info

On Wed, Feb 28, 2018 at 8:21 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Tue, Feb 27, 2018 at 02:40:46PM +0200, Pohjolainen, Topi wrote: > > On Thu, Feb 22, 2018 at 11:06:46PM -0800, Jason Ekstrand wrote: > > > --- > > > src/intel/isl/isl.c | 7 +-- > > > src/intel/isl/isl

Re: [Mesa-dev] [PATCH 11/21] intel/isl: Use the depth field of phys_level0_sa for GEN4_2D 3D surfaces

On Wed, Feb 28, 2018 at 8:32 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Thu, Feb 22, 2018 at 11:06:51PM -0800, Jason Ekstrand wrote: > > This makes things a tiny bit stickier in isl_calc_phys_total_extent_el > > but will be worth it when we enable Yf and Ys. > > --- > > src/i

Re: [Mesa-dev] [PATCH] radv: make sure to emit cache flushes before starting a query

On Wed, Feb 28, 2018 at 6:00 PM, Samuel Pitoiset wrote: > If the query pool has been previously resetted using the compute > shader path. > > Fixes: a41e2e9cf5 ("radv: allow to use a compute shader for resetting the > query pool") > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105292 >

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > > have installed 3.4 or below, meson will fail even when we may not make > > use of LLVM. > > > >

Re: [Mesa-dev] [PATCH 11/21] intel/isl: Use the depth field of phys_level0_sa for GEN4_2D 3D surfaces

On Wed, Feb 28, 2018 at 09:07:17AM -0800, Jason Ekstrand wrote: > On Wed, Feb 28, 2018 at 8:32 AM, Pohjolainen, Topi < > topi.pohjolai...@gmail.com> wrote: > > > On Thu, Feb 22, 2018 at 11:06:51PM -0800, Jason Ekstrand wrote: > > > This makes things a tiny bit stickier in isl_calc_phys_total_exten

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

On Wednesday, 2018-02-28 17:08:41 +, Eric Engestrom wrote: > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > > > have installed 3.4 or belo

[Mesa-dev] [PATCH] nir/serialize: handle var->name being NULL

var->name could be true under ARB_gl_spirv for example. And in any case, the code is already handing var name being NULL when reading a variable, so it is consistent to do it writing a variable too. --- src/compiler/nir/nir_serialize.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] anv: remove anv_gem_set_context_priority helper

anv_gem_set_context_param is to be used directly instead! Fixes: 6d8ab53303 "anv: implement VK_EXT_global_priority extension" Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_device.c | 5 +++-- src/intel/vulkan/anv_gem.c | 9 - src/intel/vulkan/anv_private.h | 1 - 3 files chan

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

Quoting Eric Engestrom (2018-02-28 09:08:41) > On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: > > On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: > > > 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you > > > have installed 3.4 or below, meson will fail

Re: [Mesa-dev] Status of radeonsi NIR

On Wed, Feb 28, 2018 at 2:53 AM, Timothy Arceri wrote: > Hi all, > > I thought I'd provide a quick status overview of the radeonsi NIR backend. > I'll attempt to list all outstanding tasks (that I'm aware of) so if you > are interested in working on one of those just give me a heads up so we > do

Re: [Mesa-dev] [PATCH] anv: remove anv_gem_set_context_priority helper

Fine by me. I even considered suggesting it yesterday. Reviewed-by: Jason Ekstrand On Wed, Feb 28, 2018 at 9:13 AM, Tapani Pälli wrote: > anv_gem_set_context_param is to be used directly instead! > > Fixes: 6d8ab53303 "anv: implement VK_EXT_global_priority extension" > Signed-off-by: Tapani P

Re: [Mesa-dev] [PATCH 15/21] intel/blorp: Use isl_surf_get_uncompressed_surf

On Thu, Feb 22, 2018 at 11:06:55PM -0800, Jason Ekstrand wrote: > --- > src/intel/blorp/blorp_blit.c | 58 > +--- > 1 file changed, 17 insertions(+), 41 deletions(-) > > diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c > index 87649

Re: [Mesa-dev] [PATCH 1/4] intel: Split gen_device_info out into libintel_dev

On Wed, Feb 28, 2018 at 02:15:19AM -0800, Jordan Justen wrote: > On 2018-02-28 01:58:24, Samuel Iglesias Gonsálvez wrote: > > What is the idea for src/intel/dev/ ? > > > > I'm not against this patch, just asking. > > Ken noticed a lot of duplicate lines in the xml for surface formats. > (Patch 4)

Re: [Mesa-dev] [PATCH v2 0/7] Merged 2 patchsets

Reviewed-by: Bruce Cherniak > On Feb 27, 2018, at 2:12 PM, George Kyriazis > wrote: > > v2 is a merged patchset of the following email threads: > <1519312447-27403-1-git-send-email-george.kyria...@intel.com> > <1519317122-3529-1-git-send-email-george.kyria...@intel.com> > > The cc to mesa-st

Re: [Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

Quoting Andres Gomez (2018-02-28 07:52:06) > Travis CI has moved to LLVM 5.0, and meson is detecting automatically > the available version in /usr/local/bin based on the PATH env variable > order preference. > > As for 0.44.x, Meson cannot receive the path to the llvm-config binary > as a configur

Re: [Mesa-dev] [PATCH] ttn: remove {varying_slot, frag_result}_to_tgsi_semantic helpers

Emil Velikov writes: > From: Emil Velikov > > The respective drivers have been updated and the helpers are no longer > needed. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.or

Re: [Mesa-dev] [RFC 2/2] anv: enable VK_EXT_shader_viewport_index_layer

On Wed, Feb 28, 2018 at 08:27:31AM +0100, Iago Toral wrote: > Reviewed-by: Iago Toral Quiroga > > However, I think we should not push this until we have testing coverage > for using gl_Layer from Vertex and TessEval shaders. For now you only > submitted a test for gl_ViewportIndex to CTS right?

Re: [Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

Reviewed-by: Juan A. Suarez On Wed, 2018-02-28 at 17:52 +0200, Andres Gomez wrote: > Travis CI has moved to LLVM 5.0, and meson is detecting automatically > the available version in /usr/local/bin based on the PATH env variable > order preference. > > As for 0.44.x, Meson cannot receive the pat

Re: [Mesa-dev] [PATCH 16/21] intel/isl: Support Ys and Yf in isl_surf_get_uncompressed_surf

On Thu, Feb 22, 2018 at 11:06:56PM -0800, Jason Ekstrand wrote: > --- > src/intel/isl/isl.c | 47 ++- > 1 file changed, 46 insertions(+), 1 deletion(-) > > diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c > index 74e248d..f93db0c 100644 > --- a/sr

Re: [Mesa-dev] [PATCH 21/21] intel/isl: Enable Yf tiling

On Thu, Feb 22, 2018 at 11:07:01PM -0800, Jason Ekstrand wrote: > --- > src/intel/isl/isl_gen7.c | 1 - > 1 file changed, 1 deletion(-) Patches 18-21 are: Reviewed-by: Topi Pohjolainen > > diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c > index 4fa9851..2aa3916 100644 > --- a

Re: [Mesa-dev] [PATCH 1/2] meson: fix LLVM version detection when <= 3.4

Am 28.02.2018 um 18:18 schrieb Dylan Baker: > Quoting Eric Engestrom (2018-02-28 09:08:41) >> On Wednesday, 2018-02-28 17:02:50 +, Eric Engestrom wrote: >>> On Wednesday, 2018-02-28 17:52:05 +0200, Andres Gomez wrote: 3 digits versions in LLVM only started from 3.4.1 on. Hence, if you

Re: [Mesa-dev] [PATCH 2/2] travis: make Meson find the proper llvm-config

Am Mittwoch, den 28.02.2018, 17:52 +0200 schrieb Andres Gomez: > Travis CI has moved to LLVM 5.0, and meson is detecting automatically > the available version in /usr/local/bin based on the PATH env > variable > order preference. > > As for 0.44.x, Meson cannot receive the path to the llvm-config

Re: [Mesa-dev] [PATCH 16/21] intel/isl: Support Ys and Yf in isl_surf_get_uncompressed_surf

On February 28, 2018 09:37:15 "Pohjolainen, Topi" wrote: On Thu, Feb 22, 2018 at 11:06:56PM -0800, Jason Ekstrand wrote: --- src/intel/isl/isl.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel

[Mesa-dev] [Bug 105285] Mesa-utils -8.4 - glxinfo report has a blank value in GL_NUM_SHADING_LANGUAGE_VERSIONS subsection and also the aligniment below 4.3 seems not correct

https://bugs.freedesktop.org/show_bug.cgi?id=105285 --- Comment #1 from Brian Paul --- Regarding GL_NUM_SHADING_LANGUAGE_VERSIONS, the GL spec says that if GLSL 1.10 is supported, the name of the shading language is "" (an empty string). So it appears as a blank line. Yeah, that's kind of goofy

Re: [Mesa-dev] [PATCH 15/21] intel/blorp: Use isl_surf_get_uncompressed_surf

On February 28, 2018 09:23:59 "Pohjolainen, Topi" wrote: On Thu, Feb 22, 2018 at 11:06:55PM -0800, Jason Ekstrand wrote: --- src/intel/blorp/blorp_blit.c | 58 +--- 1 file changed, 17 insertions(+), 41 deletions(-) diff --git a/src/intel/blorp/blorp_b

Re: [Mesa-dev] [PATCH v2 1/2] meson: Add default DRI drivers for ARM/AArch64

Quoting Daniel Stone (2018-02-28 01:36:51) > Hi, > > On 28 February 2018 at 09:33, Eric Engestrom > wrote: > > On Tuesday, 2018-02-27 18:01:11 +, Daniel Stone wrote: > >> On all Arm architectures (ARMv7 and below as 'arm', ARMv8 and above as > >> 'aarch64'), only build swrast for DRI drivers

Re: [Mesa-dev] [PATCH 15/21] intel/blorp: Use isl_surf_get_uncompressed_surf

On Wed, Feb 28, 2018 at 10:11:56AM -0800, Jason Ekstrand wrote: > On February 28, 2018 09:23:59 "Pohjolainen, Topi" > wrote: > > >On Thu, Feb 22, 2018 at 11:06:55PM -0800, Jason Ekstrand wrote: > >>--- > >> src/intel/blorp/blorp_blit.c | 58 > >> +--- > >>

[Mesa-dev] [Bug 105296] Account request for Chema Casanova

https://bugs.freedesktop.org/show_bug.cgi?id=105296 Bug ID: 105296 Summary: Account request for Chema Casanova Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 105296] Account request for Chema Casanova

https://bugs.freedesktop.org/show_bug.cgi?id=105296 --- Comment #1 from Chema Casanova --- Created attachment 137698 --> https://bugs.freedesktop.org/attachment.cgi?id=137698&action=edit SSH Publick Key - Chema Casanova -- You are receiving this mail because: You are the QA Contact for the bu

Re: [Mesa-dev] [PATCH v2 0/8] anv: VK_KHR_16bit_storage enabling SSBO/UBO/PushConstant

On 28/02/18 18:02, Jason Ekstrand wrote: > I think all the interesting patches are reviewed now.  All the boring > "turn stuff on" patches are > > Reviewed-by: Jason Ekstrand > Thanks a lot for the quick review of the series. One step less to enable the VK_KHR_16bit_

[Mesa-dev] [PATCH 18.0] swr/rast: Fix index buffer overfetch issue for non-indexed draws

Populate pLastIndex, even for the non-indexed case. An zero pLastIndex can cause the index offsets inside the fetcher to have non-sensical values that can be either very large positive or very large negative numbers. Cherry-pick of 539de78633 for 18.0. Surrounding context is different for 18.0 b

Re: [Mesa-dev] [PATCH] swr/rast: Fix macOS macro.

Yes, a typo on our end. Thank you! Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Feb 24, 2018, at 5:55 PM, Vinson Lee mailto:v...@freedesktop.org>> wrote: Fixes: a25093de7188 ("swr/rast: Implement JIT shader caching to disk") Signed-off-by: Vinson Lee mailto:v...@freedesk

[Mesa-dev] [PATCH 1/3] radv: make sure to emit cache flushes before starting a query

If the query pool has been previously resetted using the compute shader path. v2: handle multiple commands buffers with same pool Fixes: a41e2e9cf5 ("radv: allow to use a compute shader for resetting the query pool") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105292 Cc: "18.0" Signe

[Mesa-dev] [PATCH 2/3] radv: keep track of the query pool size

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_private.h | 1 + src/amd/vulkan/radv_query.c | 9 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index b76d2eb5cb..752b6a7592 100644 --- a/src/amd/vulka

[Mesa-dev] [PATCH 3/3] radv: only emit cache flushes when the pool size is large enough

This is an optimization which reduces the number of flushes for small pool buffers. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_buffer.c | 6 -- src/amd/vulkan/radv_private.h | 6 ++ src/amd/vulkan/radv_query.c | 12 3 files changed, 14 insertions

[Mesa-dev] [PATCH 00/13] nir/vtn/compiler: first batch of compute support

This is by no means everything needed for clover/OpenCL.. but I took a bit of time this morning to extract some parts of our growing stack of patches which where plausibly mergable (or at least not complete hacks), with the idea that review could start in parallel with further clover/compute hackin

[Mesa-dev] [PATCH 02/13] nir: add load_param

From: Karol Herbst OpenCL kernels have parameters (see pipe_grid_info::input), and so we need a way to access them. Signed-off-by: Rob Clark --- src/compiler/nir/nir_intrinsics.h | 2 ++ src/compiler/nir/nir_lower_io.c | 13 ++--- 2 files changed, 12 insertions(+), 3 deletions(-) d

[Mesa-dev] [PATCH 03/13] nir: kernel entrypoints can have arguments

This assert is not valid for OpenCL kernels. TODO can we somehow conditionally assert based on glsl vs cl?? Signed-off-by: Rob Clark --- src/compiler/nir/nir.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 2acd9511f57..29181694a35 10064

[Mesa-dev] [PATCH 05/13] nir: expose 'C' wrappers for std430 size/alignment

Signed-off-by: Rob Clark --- src/compiler/nir_types.cpp | 12 src/compiler/nir_types.h | 4 2 files changed, 16 insertions(+) diff --git a/src/compiler/nir_types.cpp b/src/compiler/nir_types.cpp index cbdd452dc81..0085a19248a 100644 --- a/src/compiler/nir_types.cpp +++ b/src

  1   2   >