[Mesa-dev] [PATCH v2] anv/blorp: multisample resolve all attachment layers

2018-02-15 Thread Iago Toral Quiroga
We were only resolving the first. v2: - Do not require that the number of layers on dst and src are an exact match, it is okay if the dst has more layers so long as it has at least the same that we are going to resolve. - Do not always resolve array_len layers, we should resolve on

Re: [Mesa-dev] [PATCH v2] anv/blorp: multisample resolve all attachment layers

2018-02-15 Thread Iago Toral
On Thu, 2018-02-15 at 09:24 +0100, Iago Toral Quiroga wrote: > We were only resolving the first. > > v2: > - Do not require that the number of layers on dst and src are an > exact match, it is okay if the dst has more layers so long as > it has at least the same that we are going to reso

[Mesa-dev] [PATCH v3] anv/blorp: multisample resolve all attachment layers

2018-02-15 Thread Iago Toral Quiroga
We were only resolving the first. v2: - Do not require that the number of layers on dst and src are an exact match, it is okay if the dst has more layers so long as it has at least the same that we are going to resolve. - Do not always resolve array_len layers, we should resolve on

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

2018-02-15 Thread Bas Nieuwenhuizen
On Thu, Feb 15, 2018 at 8:54 AM, Connor Abbott wrote: > On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri > wrote: >> >> >> On 15/02/18 04:39, Marek Olšák wrote: >>> >>> Reviewed-by: Marek Olšák >>> >>> Marek >>> >>> On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri >>> wrote: Fixes gls

[Mesa-dev] [PATCH] glsl: Fix memory leak with known glsl_type instances

2018-02-15 Thread Tapani Pälli
From: Simon Hausmann When looking up known glsl_type instances in the various hash tables, we end up leaking the key instances used for the lookup, as the glsl_type constructor allocates memory on the global mem_ctx. This patch changes glsl_type to manage its own memory, which fixes the leak and

[Mesa-dev] [Bug 105103] Wayland master causes Mesa to fail to compile

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105103 Daniel Stone changed: What|Removed |Added Component|wayland |EGL/Wayland QA Contact|

[Mesa-dev] [Bug 105103] Wayland master causes Mesa to fail to compile

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105103 --- Comment #1 from Daniel Stone --- Ugh. This should fix it: https://patchwork.freedesktop.org/patch/204873/ -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev m

[Mesa-dev] [PATCH] egl/wayland: Always use in-tree wayland-egl-backend.h

2018-02-15 Thread Daniel Stone
A recent patchset to Wayland[0] migrated Mesa's libwayland-egl backend into Wayland itself, so implementations could provide backends. Mesa still uses its own, and the two have already diverged[1]. The include from egl_dri2.h could pick up either the installed Wayland wayland-egl-backend.h (with a

Re: [Mesa-dev] [PATCH mesa] dri: use a supported API in driCreateNewContext

2018-02-15 Thread Eric Engestrom
On Wednesday, 2018-02-14 09:06:41 -0500, Ilia Mirkin wrote: > On Feb 14, 2018 7:38 AM, "Eric Engestrom" wrote: > > From: Brendan King > > Don't assume the screen supports OpenGL when creating a new context, > use an API that the screen supports. > > Signed-off-by: Brendan King > Reviewed-by:

Re: [Mesa-dev] [PATCH 07/15] util/bitset: Add C++ wrapper for static-size bitsets.

2018-02-15 Thread Eric Engestrom
On Wednesday, 2018-02-14 13:18:29 -0800, Francisco Jerez wrote: > --- > src/util/bitset.h | 114 > ++ > 1 file changed, 114 insertions(+) > > diff --git a/src/util/bitset.h b/src/util/bitset.h > index 2404ce7f630..7bb5f3c83cf 100644 > --- a/src

[Mesa-dev] [PATCH mesa] glsl: fix sizeof(pointer) bug

2018-02-15 Thread Eric Engestrom
Doesn't really change anything to the test though ¯\_(ツ)_/¯ CID: 1429511 Fixes: e8495646afb06a9dd7786 "glsl/tests: changes to test_disk_cache_create test" Signed-off-by: Eric Engestrom --- src/compiler/glsl/tests/cache_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

Re: [Mesa-dev] [PATCH] radv: compact varyings after removing unused ones

2018-02-15 Thread Samuel Pitoiset
On 02/14/2018 11:24 PM, Timothy Arceri wrote: On 15/02/18 01:10, Samuel Pitoiset wrote: It makes no sense to compact before, and the description of nir_compact_varyings() confirms that. Reviewed-by: Timothy Arceri Your right this seems to be in the wrong place. There was a lot of restruct

[Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

2018-02-15 Thread Eric Engestrom
CID: 1429516 Fixes: d32b23f3830099a328b91 "egl/wayland: Add bpp to visual map" Cc: Daniel Stone Signed-off-by: Eric Engestrom --- Daniel, `w` seemed like the "least bad" thing to return in this case; would you prefer `0`? --- src/egl/drivers/dri2/platform_wayland.c | 5 + 1 file changed, 5 i

Re: [Mesa-dev] [PATCH] nir: add is_used_once for fmul(fexp2(a), fexp2(b)) to fexp2(fadd(a, b))

2018-02-15 Thread Samuel Pitoiset
On 02/15/2018 02:49 AM, Ian Romanick wrote: On 02/14/2018 05:36 PM, Ian Romanick wrote: Do you have shader-db results? Did you try having only one is_used_once? I think you sent out a hastebin link with results before, but it's not loading now. Ah yeah, the hastebin link is outdated. Timo

Re: [Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

2018-02-15 Thread Daniel Stone
Hi Eric, On 15 February 2018 at 11:17, Eric Engestrom wrote: > Daniel, `w` seemed like the "least bad" thing to return in this case; > would you prefer `0`? I guess Coverity doesn't know it can never be invalid. We look up a visual in the table using dri2_surf->format, whcih is only ever set fro

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104662 --- Comment #4 from mirh --- https://lists.freedesktop.org/archives/mesa-dev/2018-February/185646.html Compatibility context is very, very shyly advancing.. Maybe this bug should be renamed to just that? -- You are receiving this mail becaus

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

2018-02-15 Thread Marek Olšák
On Thu, Feb 15, 2018 at 3:40 AM, Dieter Nützel wrote: > For the series: > > Tested-by: Dieter Nützel > > on RX580 with SPECviewperf from the phoronix test suite. ;-) > > Viewset Composite Mulitsample Performance > 3dsmax-0411.97 no result > catia-02 9.19 no result > ensig

[Mesa-dev] [Bug 105103] Wayland master causes Mesa to fail to compile

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105103 --- Comment #2 from n3rdopolis --- That works! -- You are receiving this mail because: You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freede

[Mesa-dev] [Bug 105105] Suffixless KHR_robustness functions aren't exposed in ES 3.2

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105105 --- Comment #1 from Tapani Pälli --- It looks like these 2 tests fail for different reasons: - 'readnpix' hits generic_nop (glapi issue) - 'getnuniform', problem seems to be that according to Mesa these uniforms are inactive and therefore no u

[Mesa-dev] [ANNOUNCE] mesa 17.3.4

2018-02-15 Thread Emil Velikov
Mesa 17.3.4 is now available. In this release we have: Dozens of fixes in the i965, ANV and RADV drivers. Additionally the r600, virgl, etnaviv and renderonly drivers have also seen some love. The experimental Vulkan extension VK_KHX_multiview was disabled. On the video decoding drivers side: r

Re: [Mesa-dev] [PATCH] radeonsi/nir: set TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL correctly

2018-02-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Feb 15, 2018 at 5:14 AM, Timothy Arceri wrote: > We set this for post_depth_coverage in addition to early_fragment_tests. > --- > > This doesn't fix any piglit tests but it's what the glsl->tgsi state > tracker does. > > src/gallium/drivers/radeonsi/si_

[Mesa-dev] [Bug 105105] Suffixless KHR_robustness functions aren't exposed in ES 3.2

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105105 --- Comment #2 from Tapani Pälli --- (In reply to Tapani Pälli from comment #1) > It seems compiler/linker should realize that they are written to shared > values so we should not optimize those away. and alternative theory: since we never writ

Re: [Mesa-dev] [PATCH mesa] dri: use a supported API in driCreateNewContext

2018-02-15 Thread Emil Velikov
On 15 February 2018 at 09:51, Eric Engestrom wrote: > On Wednesday, 2018-02-14 09:06:41 -0500, Ilia Mirkin wrote: >> On Feb 14, 2018 7:38 AM, "Eric Engestrom" wrote: >> >> From: Brendan King >> >> Don't assume the screen supports OpenGL when creating a new context, >> use an API that the screen

Re: [Mesa-dev] [Mesa-stable] [PATCH] egl/wayland: Always use in-tree wayland-egl-backend.h

2018-02-15 Thread Emil Velikov
On 15 February 2018 at 09:23, Daniel Stone wrote: > A recent patchset to Wayland[0] migrated Mesa's libwayland-egl backend > into Wayland itself, so implementations could provide backends. Mesa > still uses its own, and the two have already diverged[1]. > > The include from egl_dri2.h could pick u

Re: [Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

2018-02-15 Thread Eric Engestrom
On Thursday, 2018-02-15 11:25:33 +, Daniel Stone wrote: > Hi Eric, > > On 15 February 2018 at 11:17, Eric Engestrom > wrote: > > Daniel, `w` seemed like the "least bad" thing to return in this case; > > would you prefer `0`? > > I guess Coverity doesn't know it can never be invalid. We look

Re: [Mesa-dev] [PATCH mesa] dri: use a supported API in driCreateNewContext

2018-02-15 Thread Ilia Mirkin
On Thu, Feb 15, 2018 at 8:10 AM, Emil Velikov wrote: > On 15 February 2018 at 09:51, Eric Engestrom > wrote: >> On Wednesday, 2018-02-14 09:06:41 -0500, Ilia Mirkin wrote: >>> On Feb 14, 2018 7:38 AM, "Eric Engestrom" wrote: >>> >>> From: Brendan King >>> >>> Don't assume the screen supports O

Re: [Mesa-dev] [PATCH mesa] glsl: fix sizeof(pointer) bug

2018-02-15 Thread Brian Paul
On 02/15/2018 04:01 AM, Eric Engestrom wrote: Doesn't really change anything to the test though ¯\_(ツ)_/¯ CID: 1429511 Fixes: e8495646afb06a9dd7786 "glsl/tests: changes to test_disk_cache_create test" Signed-off-by: Eric Engestrom --- src/compiler/glsl/tests/cache_test.c | 2 +- 1 file chan

[Mesa-dev] [PATCH mesa v2] egl/wayland: check for invalid format index

2018-02-15 Thread Eric Engestrom
v2: just tell the compiler to assume the format will always be found, as it comes from the table itself to begin with. CID: 1429516 Fixes: d32b23f3830099a328b91 "egl/wayland: Add bpp to visual map" Cc: Daniel Stone Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/platform_wayland.c | 2 ++

[Mesa-dev] [PATCH] i965: Fix aux-surface size check

2018-02-15 Thread Daniel Stone
The previous commit reworked the checks intel_from_planar() to check the right individual cases for regular/planar/aux buffers, and do size checks in all cases. Unfortunately, the aux size check was broken, and required the aux surface to be allocated with the correct aux stride, but full image he

Re: [Mesa-dev] [PATCH mesa] glsl: fix sizeof(pointer) bug

2018-02-15 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 15.02.2018 13:01, Eric Engestrom wrote: Doesn't really change anything to the test though ¯\_(ツ)_/¯ CID: 1429511 Fixes: e8495646afb06a9dd7786 "glsl/tests: changes to test_disk_cache_create test" Signed-off-by: Eric Engestrom --- src/compiler/glsl/tests/cache_te

Re: [Mesa-dev] [PATCH mesa v2] egl/wayland: check for invalid format index

2018-02-15 Thread Daniel Stone
Hi Eric, On 15 February 2018 at 15:11, Eric Engestrom wrote: > v2: just tell the compiler to assume the format will always be found, as > it comes from the table itself to begin with. Thanks, assume() is a new one on me! Cheers, Daniel ___ mesa-dev ma

[Mesa-dev] [PATCH 05/11] anv/image: Add support for modifiers for WSI

2018-02-15 Thread Daniel Stone
From: Jason Ekstrand This adds support for the modifiers portion of the WSI "extension". Reviewed-by: Daniel Stone Signed-off-by: Daniel Stone --- src/intel/vulkan/anv_formats.c | 38 ++ src/intel/vulkan/anv_image.c | 40 ++

[Mesa-dev] [PATCH 04/11] anv/image: Separate modifiers from legacy scanout

2018-02-15 Thread Daniel Stone
From: Jason Ekstrand For a bit there, we had a bug in i965 where it ignored the tiling of the modifier and used the one from the BO instead. At one point, we though this was best fixed by setting a tiling from Vulkan. However, we've decided that i965 was just doing the wrong thing and have fixe

[Mesa-dev] [PATCH v10 00/11] Modifiers for X11 EGL/Vulkan, WL/VK

2018-02-15 Thread Daniel Stone
Hi, I don't actually know which revision we're up to by now, so I decided to rebase at v10. This is a slight evolution of Jason's 16-patch series posted on Feb 9th. It adds: - support for multi-plane buffers and modifiers to the Vulkan WSI - support for zwp_linux_dmabuf_v1 to the Vulkan Waylan

[Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne If PresentCompleteNotify event says the pixmap was presented with mode PresentCompleteModeSuboptimalCopy, it means the pixmap could possibly have been flipped instead if allocated with a different format/modifier. Signed-off-by: Louis-Francis Ratté-Boulianne

[Mesa-dev] [PATCH 10/11] egl/x11: Support DRI3 v1.1

2018-02-15 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne Add support for DRI3 v1.1, which allows pixmaps to be backed by multi-planar buffers, or those with format modifiers. This is both for allocating render buffers, as well as EGLImage imports from a native pixmap (EGL_NATIVE_PIXMAP_KHR). Signed-off-by: Louis-Fra

[Mesa-dev] [PATCH 08/11] vulkan/wsi: Add support for DRI3 v1.1

2018-02-15 Thread Daniel Stone
Adds support for multiple planes and buffer modifiers. v4: Rename "has_dri3_v1_1" to "has_dri3_modifiers" Signed-off-by: Daniel Stone --- src/vulkan/wsi/wsi_common_x11.c | 183 1 file changed, 166 insertions(+), 17 deletions(-) diff --git a/src/vulkan/ws

[Mesa-dev] [PATCH 06/11] meson: Move Wayland dmabuf to wayland-drm

2018-02-15 Thread Daniel Stone
As the comment notes: linux-dmabuf has nothing to do with wayland-drm, but we need a single place to build these files we can use from both EGL and Vulkan, which is guaranteed to be included before both EGL and Vulkan WSI. Signed-off-by: Daniel Stone Cc: Emil Velikov --- src/egl/meson.build

[Mesa-dev] [PATCH 03/11] vulkan/wsi: Add modifiers support to wsi_create_native_image

2018-02-15 Thread Daniel Stone
From: Jason Ekstrand This involves extending our fake extension a bit to allow for additional querying and passing of modifier information. The added bits are intended to look a lot like the draft of VK_EXT_image_drm_format_modifier. Once the extension gets finalized, we'll simply transition all

[Mesa-dev] [PATCH 02/11] vulkan/wsi: Add drm_modifier member to wsi_image

2018-02-15 Thread Daniel Stone
Not yet used anywhere. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/Makefile.am | 1 + src/vulkan/wsi/meson.build | 2 +- src/vulkan/wsi/wsi_common.c | 3 +++ src/vulkan/wsi/wsi_common_private.h | 1 + 4 files changed, 6 insertions(+), 1 d

[Mesa-dev] [PATCH 01/11] vulkan/wsi: Add multiple planes to wsi_image

2018-02-15 Thread Daniel Stone
Not currently used. Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/vulkan/wsi/wsi_common.c | 20 src/vulkan/wsi/wsi_common_private.h | 9 + src/vulkan/wsi/wsi_common_wayland.c | 11 +++ src/vulkan/wsi/wsi_common_x11.c | 11 +

[Mesa-dev] [PATCH 07/11] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-15 Thread Daniel Stone
zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer modifiers. Signed-off-by: Daniel Stone --- src/vulkan/Makefile.am | 10 +++ src/vulkan/Makefile.sources | 4 +- src/vulkan/wsi/meson.build | 2 + src/vulkan/wsi/wsi_common_wayland.c | 138 ++

[Mesa-dev] [PATCH 09/11] vulkan/wsi: Return VK_SUBOPTIMAL_KHR for X11

2018-02-15 Thread Daniel Stone
From: Louis-Francis Ratté-Boulianne When it is detected that a window could have been flipped but has been copied because of suboptimal format/modifier. The Vulkan client should then re-create the swapchain. Signed-off-by: Louis-Francis Ratté-Boulianne Reviewed-by: Daniel Stone Signed-off-by:

Re: [Mesa-dev] [PATCH] svga: call tgsi_scan_shader() for dummy shaders

2018-02-15 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, February 14, 2018 6:57:21 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: call tgsi_scan_shader() for dummy shaders If we fail to compi

Re: [Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Michel Dänzer
On 2018-02-15 04:57 PM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > If PresentCompleteNotify event says the pixmap was presented > with mode PresentCompleteModeSuboptimalCopy, it means the pixmap > could possibly have been flipped instead if allocated with a > different format/m

Re: [Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Daniel Stone
Hi Michel, On 15 February 2018 at 16:14, Michel Dänzer wrote: > On 2018-02-15 04:57 PM, Daniel Stone wrote: >> @@ -885,6 +901,11 @@ loader_dri3_swap_buffers_msc(struct >> loader_dri3_drawable *draw, >>if (!loader_dri3_have_image_blit(draw) && draw->cur_blit_source != -1) >> opt

Re: [Mesa-dev] [PATCH 11/11] egl/x11: Re-allocate buffers if format is suboptimal

2018-02-15 Thread Michel Dänzer
On 2018-02-15 05:17 PM, Daniel Stone wrote: > Hi Michel, > > On 15 February 2018 at 16:14, Michel Dänzer wrote: >> On 2018-02-15 04:57 PM, Daniel Stone wrote: >>> @@ -885,6 +901,11 @@ loader_dri3_swap_buffers_msc(struct >>> loader_dri3_drawable *draw, >>>if (!loader_dri3_have_image_blit(

[Mesa-dev] [PATCH] svga: replace gotos with else clauses

2018-02-15 Thread Brian Paul
Simple clean-up. --- src/gallium/drivers/svga/svga_state_fs.c | 19 +-- src/gallium/drivers/svga/svga_state_gs.c | 9 - src/gallium/drivers/svga/svga_state_vs.c | 15 +++ 3 files changed, 20 insertions(+), 23 deletions(-) diff --git a/src/gallium/drivers/svga/

Re: [Mesa-dev] [PATCH] svga: replace gotos with else clauses

2018-02-15 Thread Charmaine Lee
Looks good. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, February 15, 2018 8:31:12 AM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: replace gotos with else clauses Simple clean-up. --- src/galli

Re: [Mesa-dev] [PATCH] loader_dri3/glx/egl: Reinstate the loader_dri3_vtable get_dri_screen callback

2018-02-15 Thread Brian Paul
I'm not too familiar with this code, but your changes look OK to me. Reviewed-by: Brian Paul On 02/09/2018 01:37 AM, Thomas Hellstrom wrote: Removing this callback caused rendering corruption in some multi-screen cases, so it is reinstated but without the drawable argument which was never used

Re: [Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri to link_with unconditionally

2018-02-15 Thread Emil Velikov
On 12 February 2018 at 19:27, Dylan Baker wrote: > Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") > Signed-off-by: Dylan Baker > --- > src/gallium/targets/d3dadapter9/meson.build | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/src/gallium/

Re: [Mesa-dev] [PATCH 01/16] intel/genxml/icl: Add gen11.xml

2018-02-15 Thread Emil Velikov
Hi Anuj, On 13 February 2018 at 22:41, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > This patch adds a big xml file. So I couldn't send the patch > to the list. Clamping down the patch so that reviewers can > actually see what i'm doing in [PATCH 01/16 ]. The whole > patch can be found

Re: [Mesa-dev] [PATCH 1/7] vulkan: Add KHR_display extension to anv and radv using DRM

2018-02-15 Thread Keith Packard
Jason Ekstrand writes: > It seems a little odd to me to default to opening the master node and then > fall back to the render node if it doesn't work. I suppose that's probably > ok so long as we ensure that vkGetPhysicalDeviceDisplayPropertiesKHR > returns no displays if we're on the render nod

Re: [Mesa-dev] [PATCH 02/16] intel/genxml/icl: Generate packing headers

2018-02-15 Thread Emil Velikov
On 13 February 2018 at 19:15, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/Android.genxml.mk | 5 + > src/intel/Makefile.sources| 3 ++- > src/intel/genxml/genX_pack.h | 2 ++ > src/intel/genxml/gen_macros.h | 3 +++ > 4 files changed, 12 insertions(+), 1 deletion

Re: [Mesa-dev] [PATCH 05/16] intel/isl/icl: Build and use gen11 surface state emit functions

2018-02-15 Thread Emil Velikov
On 13 February 2018 at 19:15, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/intel/Android.isl.mk | 20 > src/intel/Makefile.isl.am | 4 > src/intel/Makefile.sources | 4 > src/intel/isl/isl.c| 3 +++ > src/intel/isl/isl_priv.h | 3 +++

Re: [Mesa-dev] [PATCH 06/11] meson: Move Wayland dmabuf to wayland-drm

2018-02-15 Thread Emil Velikov
On 15 February 2018 at 15:57, Daniel Stone wrote: > As the comment notes: linux-dmabuf has nothing to do with wayland-drm, > but we need a single place to build these files we can use from both EGL > and Vulkan, which is guaranteed to be included before both EGL and > Vulkan WSI. > > Signed-off-by

Re: [Mesa-dev] [PATCH 01/29] blorp: Handle the RGB workaround more like other workarounds

2018-02-15 Thread Pohjolainen, Topi
On Fri, Jan 26, 2018 at 05:59:30PM -0800, Jason Ekstrand wrote: > The previous version was sort-of strapped on in that it just adjusted > the blit rectangle and trusted in the fact that we would use texelFetch > and round to the nearest integer to ensure that the component positions > matched. Thi

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

2018-02-15 Thread Marek Olšák
FYI, these GLSL 1.40 tests pass: https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp&id=eeccd7b98e74e7dfefd02611563b0edbf2358327 glslparsertest dependency: https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp&id=e3f6d5fc68b61c23c7327083bed6c90333119d75 I plan to send out those piglit

Re: [Mesa-dev] [PATCH 07/15] util/bitset: Add C++ wrapper for static-size bitsets.

2018-02-15 Thread Francisco Jerez
Eric Engestrom writes: > On Wednesday, 2018-02-14 13:18:29 -0800, Francisco Jerez wrote: >> --- >> src/util/bitset.h | 114 >> ++ >> 1 file changed, 114 insertions(+) >> >> diff --git a/src/util/bitset.h b/src/util/bitset.h >> index 2404ce7f6

Re: [Mesa-dev] [PATCH v4 02/12] meson: add libswdri and libswkmsdri to link_with unconditionally

2018-02-15 Thread Dylan Baker
Quoting Emil Velikov (2018-02-15 09:37:01) > On 12 February 2018 at 19:27, Dylan Baker wrote: > > Fixes: 6b4c7047d571 ("meson: build gallium nine state_tracker") > > Signed-off-by: Dylan Baker > > --- > > src/gallium/targets/d3dadapter9/meson.build | 13 +++-- > > 1 file changed, 3 inser

Re: [Mesa-dev] [PATCH 02/16] intel/genxml/icl: Generate packing headers

2018-02-15 Thread Anuj Phogat
On Thu, Feb 15, 2018 at 9:49 AM, Emil Velikov wrote: > On 13 February 2018 at 19:15, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/intel/Android.genxml.mk | 5 + >> src/intel/Makefile.sources| 3 ++- >> src/intel/genxml/genX_pack.h | 2 ++ >> src/intel/genxml/gen_mac

[Mesa-dev] [PATCH 14/16] intel/common/icl: Add has_sample_with_hiz flag in gen_device_info

2018-02-15 Thread Anuj Phogat
Sampling from hiz is enabled in i965 for GEN9+ but this feature has been removed from gen11. So, this new flag will be useful to turn the feature on/off for different gen h/w. It will be used later in a patch adding device info for gen11. Suggested-by: Kenneth Graunke Signed-off-by: Anuj Phogat

[Mesa-dev] [PATCH V2 16/16] i965/icl: Add render target flush after uploading binding table

2018-02-15 Thread Anuj Phogat
From PIPE_CONTROL command description in gfxspecs: "Whenever a Binding Table Index (BTI) used by a Render Taget Message points to a different RENDER_SURFACE_STATE, SW must issue a Render Target Cache Flush by enabling this bit. When render target flush is set due to new association of BTI, PS S

Re: [Mesa-dev] [PATCH 07/11] vulkan/wsi/wayland: Add support for zwp_dmabuf

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > zwp_linux_dmabuf_v1 lets us use multi-planar images and buffer > modifiers. > > Signed-off-by: Daniel Stone > --- > src/vulkan/Makefile.am | 10 +++ > src/vulkan/Makefile.sources | 4 +- > src/vulkan/wsi/meson.build

Re: [Mesa-dev] [PATCH 06/11] meson: Move Wayland dmabuf to wayland-drm

2018-02-15 Thread Dylan Baker
Quoting Daniel Stone (2018-02-15 07:57:36) > As the comment notes: linux-dmabuf has nothing to do with wayland-drm, > but we need a single place to build these files we can use from both EGL > and Vulkan, which is guaranteed to be included before both EGL and > Vulkan WSI. > > Signed-off-by: Danie

Re: [Mesa-dev] [PATCH 03/11] vulkan/wsi: Add modifiers support to wsi_create_native_image

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > From: Jason Ekstrand > > This involves extending our fake extension a bit to allow for additional > querying and passing of modifier information. The added bits are > intended to look a lot like the draft of VK_EXT_image_drm_format_modifier

[Mesa-dev] [PATCH 03/13] vbo: Remove get_vp_mode() and enum vp_mode.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Is now unused. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_private.h | 27 --- 1 file changed, 27 deletions(-) diff --git a/src/mesa/vbo/vbo_private.h b/src/mesa/vbo/vbo_private.h index e44a521b11..49922892e5 100644 --- a/src/mesa/vbo/vb

[Mesa-dev] [PATCH 01/13] mesa: Provide an alternative to get_vp_mode()

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich To get equivalent information than get_vp_mode(), track the vertex processing mode in a per context variable at gl_vertex_program_state::_VPMode. This aims to replace get_vp_mode() as seen in the vbo module. But instead of the get_vp_mode() implementation which only gives c

[Mesa-dev] [PATCH 10/13] vbo: Implement tool functions for vbo specific VAO setup.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Correct VBO_MATERIAL_SHIFT value. The functions will be used next in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_attrib.h | 4 ++-- src/mesa/vbo/vbo_private.h | 53 ++ 2 files changed, 55 insertions(+),

[Mesa-dev] [PATCH 02/13] vbo: Use _VPMode instead of get_vp_mode().

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich At those places where we used get_vp_mode() use gl_vertex_program_state::_VPMode instead. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec.c | 4 ++-- src/mesa/vbo/vbo_exec_array.c | 11 ++- src/mesa/vbo/vbo_exec_draw.c | 5 +++-- src/mesa/vbo/v

[Mesa-dev] [PATCH 11/13] vbo: Make use of _DrawVAO from immediate mode draw

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Finally use an internal VAO to execute immediate mode draws. Avoid duplicate state validation for immediate mode draws. Remove client arrays previously used exclusively for immediate mode draws. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_context.c | 8 +++

[Mesa-dev] [PATCH 09/13] mesa: Add flush_vertices to _mesa_bind_vertex_buffer.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 16 +--- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/varray.c | 15 --- src/mesa/main/varray.h

[Mesa-dev] [PATCH 13/13] vbo: Make use of _DrawVAO from the dlist code.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Finally use an internal VAO to execute display list draws. Avoid duplicate state validation for display list draws. Remove client arrays previously used exclusively for display lists. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_save.c | 37 ++-- sr

[Mesa-dev] [PATCH 12/13] mesa: Use atomics for shared VAO reference counts.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich VAOs will be used in the next change as immutable object across multiple contexts. Only reference counting may write concurrently on the VAO. So, make the reference count thread safe for those and only those VAO objects. Signed-off-by: Mathias Fröhlich --- src/mesa/main/

[Mesa-dev] [PATCH 00/13] Switch over to use VAOs for drawing.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi, The following series moves over to draw via a VAO in all draw paths. At the current stage this introduces an additional indirection for the immediate mode and display list draws. But in the mid term using a VAO should enable drivers to make use of the binding informati

[Mesa-dev] [PATCH 07/13] mesa: Add flush_vertices to _mesa_{enable, disable}_vertex_array_attrib.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich We will need the flush_vertices argument later in this series. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c | 18 +++--- src/mesa/main/enable.c | 4 ++-- src/mesa/main/varray.c | 30 +++--- src/me

[Mesa-dev] [PATCH 06/13] vbo: Use _DrawVAO for array type draw commands.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the _DrawVAO for all the array type draws. The _DrawVAO needs to be set before we enter _mesa_update_state, so move setting the draw method in front of the first call to _mesa_update_state which is in turn called from the *validate*Draw* calls. Using the

[Mesa-dev] [PATCH 05/13] vbo: Implement method to track the inputs array.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Provided the _DrawVAO and the derived state that is maintained if we have the _DrawVAO set, implement a method to incrementally update the array of gl_vertex_array input pointers. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo.h | 28 + src/

[Mesa-dev] [PATCH 04/13] mesa: Introduce a yet unused _DrawVAO.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich During the patch series this VAO gets populated with either the currently bound VAO or an internal VAO that will be used for immediate mode and dlist rendering. Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.c | 4 src/mesa/main/attrib.c | 2 ++ src/

[Mesa-dev] [PATCH 08/13] mesa: Make _mesa_vertex_attrib_binding public.

2018-02-15 Thread Mathias . Froehlich
From: Mathias Fröhlich Change vertex_attrib_binding() to _mesa_vertex_attrib_binding(), add a flush_vertices argument, and make it publically available. The function will be needed later in the series. Signed-off-by: Mathias Fröhlich --- src/mesa/main/varray.c | 38

[Mesa-dev] [PATCH 1/1] clover: Fix build after llvm r325155 and r325160

2018-02-15 Thread Jan Vesely
r325155 ("Pass a reference to a module to the bitcode writer.") and r325160 ("Pass module reference to CloneModule") change function interface from pointer to reference. Signed-off-by: Jan Vesely --- .../state_trackers/clover/llvm/codegen/bitcode.cpp | 2 +- .../state_trackers/clover/llvm/code

Re: [Mesa-dev] [PATCH 07/21] vulkan: Add EXT_acquire_xlib_display

2018-02-15 Thread Keith Packard
Eric Engestrom writes: > Can be simplified a bit: > > _xlib_lease = get_option('xlib-lease') > if _xlib_lease == 'auto' > with_xlib_lease = with_platform_x11 and with_platform_display > else > with_xlib_lease = _xlib_lease == 'true' > endif > > (We also usually try to avoid changi

[Mesa-dev] [PATCH] radv: Always lower indirect derefs after nir_lower_global_vars_to_local.

2018-02-15 Thread Bas Nieuwenhuizen
Otherwise new local variables can cause hangs on vega. CC: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- src/amd/vulkan/radv_pipeline.c | 11 +-- src/amd/vulkan/radv_shader.c | 74 +++--- src/amd/vulkan/radv_shader.h | 4 +++ 3 fil

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105098 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from Bas Ni

Re: [Mesa-dev] [PATCH] i965: Fix aux-surface size check

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:42 AM, Daniel Stone wrote: > The previous commit reworked the checks intel_from_planar() to check the > right individual cases for regular/planar/aux buffers, and do size > checks in all cases. > > Unfortunately, the aux size check was broken, and required the aux > surf

[Mesa-dev] [PATCH] meson: Add Haiku platform support

2018-02-15 Thread Alexander von Gluck IV
--- include/meson.build| 8 + meson.build| 18 +++--- src/egl/meson.build| 33 + src/gallium/meson.build| 9 + src/gallium/state_trackers/hgl/meson.buil

[Mesa-dev] [PATCH] meson: Add Haiku platform support v2

2018-02-15 Thread Alexander von Gluck IV
--- include/meson.build| 8 + meson.build| 18 +++--- src/egl/meson.build| 35 +- src/gallium/meson.build| 9 + src/gallium/state_trackers/hgl/meson.bui

Re: [Mesa-dev] [PATCH 14/16] intel/common/icl: Add has_sample_with_hiz flag in gen_device_info

2018-02-15 Thread Kenneth Graunke
On Thursday, February 15, 2018 11:09:09 AM PST Anuj Phogat wrote: > Sampling from hiz is enabled in i965 for GEN9+ but this feature has > been removed from gen11. So, this new flag will be useful to turn > the feature on/off for different gen h/w. It will be used later > in a patch adding device in

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- Comment #6 from Lukas Kahnert --- My App is more or less the same than the triangle demo(I try to learn Vulkan, but this issue was definitely not normal for invalid API usage ;)). With this patch it does't hang now and works as expected. Th

Re: [Mesa-dev] [PATCH] meson: Add Haiku platform support v2

2018-02-15 Thread Alexander von Gluck IV
February 15, 2018 3:22 PM, "Alexander von Gluck IV" wrote: > --- > include/meson.build | 8 + > meson.build | 18 +++--- > src/egl/meson.build | 35 +- > src/gallium/meson.build | 9 + > src/gallium/state_trackers/hgl/meson.build | 41 + > src/gallium/ta

Re: [Mesa-dev] [PATCH 09/11] vulkan/wsi: Return VK_SUBOPTIMAL_KHR for X11

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > When it is detected that a window could have been flipped > but has been copied because of suboptimal format/modifier. > The Vulkan client should then re-create the swapchain. > > Signed-off-by: Louis-

Re: [Mesa-dev] [PATCH] nir: add is_used_once for fmul(fexp2(a), fexp2(b)) to fexp2(fadd(a, b))

2018-02-15 Thread Timothy Arceri
Here are the IVB shader-db results: instructions helped: shaders/closed/steam/dex/63.shader_test FS SIMD8: 1303 -> 1300 (-0.23%) instructions helped: shaders/closed/steam/gang-beasts/111.shader_test FS SIMD8: 1303 -> 1300 (-0.23%) instructions helped: shaders/closed/steam/rocketsrocketsroc

Re: [Mesa-dev] [PATCH] radv: Always lower indirect derefs after nir_lower_global_vars_to_local.

2018-02-15 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 16/02/18 07:40, Bas Nieuwenhuizen wrote: Otherwise new local variables can cause hangs on vega. CC: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- src/amd/vulkan/radv_pipeline.c | 11 +-- src/amd/vulkan/radv_shader.c | 74

[Mesa-dev] [Bug 105119] Desktop-wide input freeze when vulkan (radv)

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105119 Bug ID: 105119 Summary: Desktop-wide input freeze when vulkan (radv) Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Sev

[Mesa-dev] [Bug 105119] Desktop-wide input freeze when vulkan (radv)

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105119 --- Comment #1 from Jakub Okoński --- Created attachment 137385 --> https://bugs.freedesktop.org/attachment.cgi?id=137385&action=edit single frame render that exits cleanly -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 105119] Desktop-wide input freeze when vulkan (radv)

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105119 Jakub Okoński changed: What|Removed |Added CC||ja...@okonski.org -- You are receiving

Re: [Mesa-dev] [PATCH 1/1] clover: Fix build after llvm r325155 and r325160

2018-02-15 Thread Francisco Jerez
Jan Vesely writes: > r325155 ("Pass a reference to a module to the bitcode writer.") > and > r325160 ("Pass module reference to CloneModule") > > change function interface from pointer to reference. > > Signed-off-by: Jan Vesely > --- > .../state_trackers/clover/llvm/codegen/bitcode.cpp | 2 +-

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

2018-02-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104662 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH V2 16/16] i965/icl: Add render target flush after uploading binding table

2018-02-15 Thread Anuj Phogat
+Ken On Thu, Feb 15, 2018 at 11:11 AM, Anuj Phogat wrote: > From PIPE_CONTROL command description in gfxspecs: > > "Whenever a Binding Table Index (BTI) used by a Render Taget Message > points to a different RENDER_SURFACE_STATE, SW must issue a Render > Target Cache Flush by enabling this bit.

Re: [Mesa-dev] [PATCH 10/11] egl/x11: Support DRI3 v1.1

2018-02-15 Thread Jason Ekstrand
On Thu, Feb 15, 2018 at 7:57 AM, Daniel Stone wrote: > From: Louis-Francis Ratté-Boulianne > > Add support for DRI3 v1.1, which allows pixmaps to be backed by > multi-planar buffers, or those with format modifiers. This is both > for allocating render buffers, as well as EGLImage imports from a

  1   2   >