Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

2018-01-29 Thread Alejandro Piñeiro
On 27/01/18 12:09, Roland Scheidegger wrote: > Am 27.01.2018 um 09:52 schrieb Alejandro Piñeiro: >> On 27/01/18 01:59, srol...@vmware.com wrote: >>> From: Roland Scheidegger >>> >>> The size/type query is always legal (if we made it that far). >>> This causes a difference for GL_TEXTURE_BUFFER -

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104820 Tapani Pälli changed: What|Removed |Added Resolution|NOTOURBUG |--- Status|RESOLVED

Re: [Mesa-dev] [PATCH] anv/pipeline: lower constant initializers on output variables earlier

2018-01-29 Thread Iago Toral
Ping :) On Wed, 2018-01-24 at 08:26 +0100, Iago Toral wrote: > This is still waiting for review, any takers? > > On Wed, 2018-01-17 at 09:08 +0100, Iago Toral Quiroga wrote: > > If a shader only writes to an output via a constant initializer we > > need to lower it before we call nir_remove_dead_

Re: [Mesa-dev] [PATCH] spirv: split constant initializers on in/out structs

2018-01-29 Thread Iago Toral
Anyone willing to review this? On Tue, 2018-01-23 at 14:11 +0100, Iago Toral Quiroga wrote: > The SPIR-V parser splits in/out struct variables and creates > a separate variable for each first-level member of the struct. > When the struct variable has an initializer this means that we also > need t

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104820 Tapani Pälli changed: What|Removed |Added CC||lem...@gmail.com -- You are receiving t

Re: [Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

2018-01-29 Thread Elie Tournier
On Fri, Jan 26, 2018 at 02:34:03PM +0200, Tapani Pälli wrote: > Hi; > > On 01/25/2018 05:18 PM, Elie Tournier wrote: > > texture_format_error_check_gles() displays error like "glTexImage%dD". > > This patch just replace the %d by the correct dimension. > > > > Signed-off-by: Elie Tournier > > --

Re: [Mesa-dev] [PATCH] mesa: remove DummyShader from atifragshader.c

2018-01-29 Thread Emil Velikov
On 28 January 2018 at 12:46, Miklós Máté wrote: > On 24/01/18 17:16, Emil Velikov wrote: >> >> On 20 December 2017 at 16:33, Miklós Máté wrote: >>> >>> It's much cleaner to allocate a normal shader struct when >>> GenFragmentShadersATI is called. >>> >>> Signed-off-by: Miklós Máté >>> --- >>>

Re: [Mesa-dev] [PATCH] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

2018-01-29 Thread Antia Puentes
Hi, the patch looks good to me. Some small comments: On 29/01/18 01:26, Andres Gomez wrote: The emission of vertex attributes corresponding to dvec3 and dvec4 vertex shader input variables was not correct when the passed to the VertexAttribL* commands was <= 2. In 61a8a55f557 ("i965/gen8: Fix

[Mesa-dev] [Bug 104820] White screen in SDDM after upgrade to latest padoka

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104820 Tapani Pälli changed: What|Removed |Added See Also||https://bugs.freedesktop.or

[Mesa-dev] [Bug 104818] mesa fails to build on ia64

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104818 --- Comment #4 from Emil Velikov --- Thanks for the report Jason. For the future, please include a snippet of the failure in the report. Namely: ./build/src/util/../../../src/util/u_thread.h:48: undefined reference to `pthread_sigmask' ... col

Re: [Mesa-dev] [PATCH 3/5] disk cache: initialize cache path and index only when used

2018-01-29 Thread Tapani Pälli
Reviewing own code ... This change does not work well with existing unit tests for disk cache. I'll have to do some changes to those tests. On 01/22/2018 03:00 PM, Tapani Pälli wrote: This patch makes disk_cache initialize path and index lazily so that we can utilize disk_cache without a path

Re: [Mesa-dev] [PATCH] link mesautil with pthreads

2018-01-29 Thread Emil Velikov
On 1 January 2018 at 21:49, Igor Gnatenko wrote: > ../../src/util/.libs/libmesautil.a(libmesautil_la-u_queue.o): In function > `u_thread_setname': > /builddir/build/BUILD/mesa-17.3.1/src/util/../../src/util/u_thread.h:66: > undefined reference to `pthread_setname_np' > ../../src/util/.libs/libme

Re: [Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

2018-01-29 Thread Tapani Pälli
On 01/29/2018 12:05 PM, Elie Tournier wrote: On Fri, Jan 26, 2018 at 02:34:03PM +0200, Tapani Pälli wrote: Hi; On 01/25/2018 05:18 PM, Elie Tournier wrote: texture_format_error_check_gles() displays error like "glTexImage%dD". This patch just replace the %d by the correct dimension. Signed-

Re: [Mesa-dev] [PATCH] mesa: Correctly print glTexImage dimensions

2018-01-29 Thread Elie Tournier
On Mon, Jan 29, 2018 at 01:24:42PM +0200, Tapani Pälli wrote: > > > On 01/29/2018 12:05 PM, Elie Tournier wrote: > > On Fri, Jan 26, 2018 at 02:34:03PM +0200, Tapani Pälli wrote: > > > Hi; > > > > > > On 01/25/2018 05:18 PM, Elie Tournier wrote: > > > > texture_format_error_check_gles() displays

[Mesa-dev] [PATCH 1/3] radv: do not allocate one extra SGPR for the draw ID

2018-01-29 Thread Samuel Pitoiset
We always emit 0 in there, just remove the allocated user SGPR and return a constant instead. This will free one SGPR for apps that need the draw ID. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 17 +++-- src/amd/vulkan/radv_cmd_buffer.c | 6 ++ src/amd/

[Mesa-dev] [ANNOUNCE] mesa 18.0.0-rc3

2018-01-29 Thread Emil Velikov
The third release candidate for Mesa 18.0.0 is now available. Bas Nieuwenhuizen (1): radeonsi: Export signalled sync file instead of -1. Brian Paul (1): vbo: fix incorrect min/max_index values in display list draw call Christoph Haag (1): meson: remove lib prefix from libd3dad

[Mesa-dev] [PATCH 2/3] ac/shader: scan if vertex shaders need base_vertex or start_instance

2018-01-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_shader_info.c | 35 --- src/amd/common/ac_shader_info.h | 2 ++ 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/src/amd/common/ac_shader_info.c b/src/amd/common/ac_shader_info.c index d771cd250d.

[Mesa-dev] [PATCH 3/3] radv: only emit first_instance and base_vertex when VS needs them

2018-01-29 Thread Samuel Pitoiset
This should reduce the number of emitted SH_REG packets. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 23 +++ src/amd/vulkan/radv_cmd_buffer.c | 27 +-- src/amd/vulkan/radv_pipeline.c | 11 +++ src/amd/vulkan/radv_pri

[Mesa-dev] [Bug 104818] mesa fails to build on ia64

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104818 Jason Duerstock changed: What|Removed |Added OS|All |Linux (All) --- Comment #5 from Jason

[Mesa-dev] [Bug 104818] mesa fails to build on ia64

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104818 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-29 Thread Robert Foss
On 01/25/2018 08:52 PM, Rob Herring wrote: On Thu, Jan 25, 2018 at 10:21 AM, Robert Foss wrote: Hey Tomasz, On 01/24/2018 11:04 AM, Tomasz Figa wrote: Hi Robert, On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss wrote: This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, sinc

Re: [Mesa-dev] [PATCH] swr: don't export swr_create_screen_internal

2018-01-29 Thread Emil Velikov
On 22 January 2018 at 17:52, Emil Velikov wrote: > From: Emil Velikov > > With earlier rework the user and provider of the symbol are within the > same binary. Thus there's no point in exporting the function. > > Spotted while reviewing patch from Chuck, that nearly added another > unneeded PUBLI

[Mesa-dev] [PATCH] r600/sb: Force ELSE path if the byte code started off with it

2018-01-29 Thread Gert Wollny
sb optimized away the ELSE in a construct like while (foo) { if (bar ) { do something; } else { break; } } resulting in while (foo) { if (bar ) { do something; break; } } which is obviously wrong. With this patch an

[Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: Mark first write as unconditional when apropriate

2018-01-29 Thread Gert Wollny
In the register lifetime estimation if the first write is unconditional or conditional but not within a loop than this is an unconditional dominant write in the sense of register life time estimation. Add a test case and record the write accordingly. Fixes: 807e2539e512ca6c96f059da855473eb7be99ba1

[Mesa-dev] [PATCH] i965: move disk cache from brw_context to intel_screen

2018-01-29 Thread Tapani Pälli
Now every context refers to same disk_cache instance in screen. Signed-off-by: Tapani Pälli Suggested-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_context.c| 4 +--- src/mesa/drivers/dri/i965/brw_disk_cache.c | 6 +++--- src/mesa/drivers/dri/i965/brw_state.h | 2 +- src/mesa/driv

[Mesa-dev] [Bug 104803] SIGSEGV in state_tracker/st_glsl_to_tgsi_temprename.cpp

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104803 --- Comment #7 from Brad King --- Gert, yes that fixes all the tests. Thanks! -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-de

Re: [Mesa-dev] [PATCH] i965: move disk cache from brw_context to intel_screen

2018-01-29 Thread Emil Velikov
On 29 January 2018 at 12:39, Tapani Pälli wrote: > Now every context refers to same disk_cache instance in screen. > > Signed-off-by: Tapani Pälli > Suggested-by: Emil Velikov Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.

[Mesa-dev] [Bug 104836] Missing library link breaks mesa on Debian/ia64

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104836 Bug ID: 104836 Summary: Missing library link breaks mesa on Debian/ia64 Product: Mesa Version: git Hardware: Other OS: Linux (All) Status: NEW Severity:

[Mesa-dev] [Bug 104836] Missing library link breaks mesa on Debian/ia64

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104836 --- Comment #1 from Jason Duerstock --- I forgot to add that the same failure will show up under amd64 if the ld --gc-sections is disabled. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for th

Re: [Mesa-dev] [PATCH 1/3] radv: do not allocate one extra SGPR for the draw ID

2018-01-29 Thread Bas Nieuwenhuizen
We don't always emit 0 for that SGPR. See radv_cs_emit_indirect_draw_packet. On Mon, Jan 29, 2018 at 12:39 PM, Samuel Pitoiset wrote: > We always emit 0 in there, just remove the allocated user SGPR > and return a constant instead. This will free one SGPR for apps > that need the draw ID. > > Si

Re: [Mesa-dev] [PATCH 3/3] radv: only emit first_instance and base_vertex when VS needs them

2018-01-29 Thread Bas Nieuwenhuizen
I don't think we can do this either, as the indirect draw packets require a group of 2 SGPRs to put them in, even if you don't use them. On Mon, Jan 29, 2018 at 12:40 PM, Samuel Pitoiset wrote: > This should reduce the number of emitted SH_REG packets. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH v2 2/2] radv: use separate bindings for graphics and compute descriptors

2018-01-29 Thread Samuel Pitoiset
The Vulkan spec says: "pipelineBindPoint is a VkPipelineBindPoint indicating whether the descriptors will be used by graphics pipelines or compute pipelines. There is a separate set of bind points for each of graphics and compute, so binding one does not disturb the other." v2: - m

[Mesa-dev] [PATCH v2 1/2] radv: store the bind point when creating descriptors with templates

2018-01-29 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_descriptor_set.c | 1 + src/amd/vulkan/radv_private.h| 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index b1ef66308d..bbabfa9b27 100644 --- a/src/amd/

Re: [Mesa-dev] [PATCH 1/3] radv: do not allocate one extra SGPR for the draw ID

2018-01-29 Thread Samuel Pitoiset
On 01/29/2018 02:36 PM, Bas Nieuwenhuizen wrote: We don't always emit 0 for that SGPR. See radv_cs_emit_indirect_draw_packet. Oh right, missed that.. Ignore this series then. On Mon, Jan 29, 2018 at 12:39 PM, Samuel Pitoiset mailto:samuel.pitoi...@gmail.com>> wrote: We always emit 0

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 Michel Dänzer changed: What|Removed |Added Version|XOrg git|unspecified Product|DRI

[Mesa-dev] [Bug 104836] Missing library link breaks mesa on Debian/ia64

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104836 Jason Duerstock changed: What|Removed |Added CC||jason.duerst...@gmail.com -- You are

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 --- Comment #2 from Rafael Ristovski --- Created attachment 137024 --> https://bugs.freedesktop.org/attachment.cgi?id=137024&action=edit Output of DRI_PRIME=1 glxinfo -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 --- Comment #3 from Rafael Ristovski --- Created attachment 137025 --> https://bugs.freedesktop.org/attachment.cgi?id=137025&action=edit Xorg.0.log -- You are receiving this mail because: You are the QA Contact for the bug. You are the assig

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 --- Comment #4 from Rafael Ristovski --- (In reply to Michel Dänzer from comment #1) > This is a Mesa or xserver (or maybe GLVND?) issue, the dmesg messages are > unrelated and harmless. > > Please attach the glxinfo output and the Xorg log fil

Re: [Mesa-dev] [PATCH v2 14/24] intel/blorp: Add a CCS ambiguation pass

2018-01-29 Thread Pohjolainen, Topi
On Fri, Jan 26, 2018 at 05:58:25PM +0200, Pohjolainen, Topi wrote: > On Wed, Jan 24, 2018 at 12:29:05PM -0800, Jason Ekstrand wrote: > > On Wed, Jan 24, 2018 at 6:15 AM, Pohjolainen, Topi < > > topi.pohjolai...@gmail.com> wrote: > > > > > On Fri, Jan 19, 2018 at 03:47:31PM -0800, Jason Ekstrand wr

Re: [Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: Mark first write as unconditional when apropriate

2018-01-29 Thread Brian Paul
On 01/29/2018 05:24 AM, Gert Wollny wrote: In the register lifetime estimation if the first write is unconditional or conditional but not within a loop than this is an unconditional dominant than -> then write in the sense of register life time estimation. Add a test case and record the write

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

2018-01-29 Thread Roland Scheidegger
Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: > > > On 27/01/18 12:09, Roland Scheidegger wrote: >> Am 27.01.2018 um 09:52 schrieb Alejandro Piñeiro: >>> On 27/01/18 01:59, srol...@vmware.com wrote: From: Roland Scheidegger The size/type query is always legal (if we made it th

Re: [Mesa-dev] [PATCH] mesa: Remove unused gl_fog_attrib::_Scale.

2018-01-29 Thread Brian Paul
Reviewed-by: Brian Paul On 01/27/2018 08:38 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi all, The patch removes a variable that is only written to. Please review. best Mathias Signed-off-by: Mathias Fröhlich --- src/mesa/main/fog.c| 16 src/mes

Re: [Mesa-dev] [PATCH] swr: don't export swr_create_screen_internal

2018-01-29 Thread Chuck Atkins
Lgtm, should probably get a rb from Intel though to make sure it doesn't break anything they're trying to do. Tested-by: Chuck Atkins On Jan 29, 2018 07:09, "Emil Velikov" wrote: On 22 January 2018 at 17:52, Emil Velikov wrote: > From: Emil Velikov > > With earlier rework the user and provid

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #5 from

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 --- Comment #6 from Rafael Ristovski --- (In reply to Mike Lothian from comment #5) > What version of GCC are you using? Testing was done with GCC 7 and GCC 8.0 alpha -- You are receiving this mail because: You are the assignee for the bug. Y

[Mesa-dev] [Bug 104837] 'radeonsi: Failed to create context' with 32 bit applications

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104837 --- Comment #7 from Rafael Ristovski --- I just rebuilt libdrm from git. It seems like it was the only one I missed while rebuilding the whole stack 2 days ago. Which means my libdrm version lacked following commit by one day: 1cc17744b988106b4

Re: [Mesa-dev] [PATCH 3/3] mesa: skip validation of legality of size/type queries for format queries

2018-01-29 Thread Alejandro Piñeiro
On 29/01/18 16:38, Roland Scheidegger wrote: > Am 29.01.2018 um 09:09 schrieb Alejandro Piñeiro: >> >> On 27/01/18 12:09, Roland Scheidegger wrote: >>> Am 27.01.2018 um 09:52 schrieb Alejandro Piñeiro: On 27/01/18 01:59, srol...@vmware.com wrote: > From: Roland Scheidegger > > The

Re: [Mesa-dev] [PATCH 7/8] mesa: Reduce ffvertex_prog state_key to 36 bytes.

2018-01-29 Thread Brian Paul
On 01/27/2018 12:09 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Using lower alignment restrictions for the state key fields finally yields to a smaller hasing "hashing" And this 3-line comment could fit into two lines. state key. Signed-off-by: Mathias Fröhlich The serie

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-29 Thread Robert Foss
Hey Tomasz, I'm tempted to split this work into two parts. 1) Move gbm&drm gralloc struct 2) Accessor functions I would like to get 1) out the door to support John Stultzs current HiKey 960 efforts. As for 2), it would seem that we have some more discussing to do. But I'll keep pushing that fo

Re: [Mesa-dev] [PATCH 02/20] gallium: introduce PIPE_CAP_SEMAPHORE_SIGNAL

2018-01-29 Thread Marek Olšák
On Tue, Jan 23, 2018 at 7:04 PM, Andres Rodriguez wrote: > Protects semaphore signaling functionality required by GL_EXT_semaphore. > > Signed-off-by: Andres Rodriguez > --- > src/gallium/docs/source/screen.rst | 2 ++ > src/gallium/drivers/etnaviv/etnaviv_screen.c | 1 + > src

Re: [Mesa-dev] [PATCH 01/20] mesa: replace GLenum with GLenum16 in common structures (v2)

2018-01-29 Thread Brian Paul
Just FYI, I've rebased this patch to ToT Mesa and incorporated Ian's nit-picks. I checked with Marek and he's good with me pushing it. I'll do so today if there's no other concerns. -Brian On 11/22/2017 02:00 PM, Ian Romanick wrote: There are a couple small nits below. I haven't reviewed thi

Re: [Mesa-dev] [PATCH 04/20] gallium: add fence_server_signal()

2018-01-29 Thread Marek Olšák
On Tue, Jan 23, 2018 at 7:04 PM, Andres Rodriguez wrote: > Calling this function will emit a fence signal operation into the > GPU's command stream. > > Signed-off-by: Andres Rodriguez > --- > src/gallium/docs/source/context.rst | 31 +++ > src/gallium/include/pipe/p

[Mesa-dev] [PATCH v2] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

2018-01-29 Thread Andres Gomez
The emission of vertex attributes corresponding to dvec3 and dvec4 vertex shader input variables was not correct when the passed to the VertexAttribL* commands was <= 2. In 61a8a55f557 ("i965/gen8: Fix vertex attrib upload for dvec3/4 shader inputs"), for gen8+ we needed to determine if the attri

[Mesa-dev] [PATCH] radv: remove predication on cache flushes

2018-01-29 Thread Matthew Nicholls
This can lead to a situation where cache flushes could get conditionally disabled while still clearing the flush_bits, and thus flushes due to application pipeline barriers may never get executed. Cc: mesa-sta...@lists.freedesktop.org --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/r

[Mesa-dev] [RFC][PATCH xserver] Multi-buffered flips on subsurfaces seg fault in Mesa

2018-01-29 Thread Roman Gilg
The above patch series only allows flips on a child window with the same dimensions as its parent xwl_window. For flips on child windows (for example the video view port of a video player in windowed mode, see here: http://www.subdiff.de/assets/images/2017-07-28-a-new-beginning.jpg) I wanted to use

[Mesa-dev] [PATCH xserver] xwayland: Flips on subsurfaces

2018-01-29 Thread Roman Gilg
Do flips for child windows via subsurfaces if the Wayland server supports them. Signed-off-by: Roman Gilg --- hw/xwayland/xwayland-present.c | 57 +- hw/xwayland/xwayland.c | 6 - hw/xwayland/xwayland.h | 2 ++ present/present_wnmd.c

Re: [Mesa-dev] [PATCH v2] i965: perform 2 uploads with dual slot *64*PASSTHRU formats on gen<8

2018-01-29 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 29/01/18 17:25, Andres Gomez wrote: > The emission of vertex attributes corresponding to dvec3 and dvec4 > vertex shader input variables was not correct when the passed > to the VertexAttribL* commands was <= 2. > > In 61a8a55f557 ("i965/gen8: Fix vertex attrib

Re: [Mesa-dev] [RFC][PATCH xserver] Multi-buffered flips on subsurfaces seg fault in Mesa

2018-01-29 Thread Roman Gilg
Sorry, somewhat part of my message got removed. It should begin with: "This is a RFC on a follow-up patch to my recently posted patch series on the xorg-devel mailing list to enable per window flips of Present Pixmaps to Wayland surfaces: https://lists.freedesktop.org/archives/xorg-devel/2018-Janu

[Mesa-dev] [PATCH v2 0/6] Implement commont gralloc_handle_t in libdrm

2018-01-29 Thread Robert Foss
This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, since at least 4 implementations exist, and share a lot of contents. The idea is to keep the common stuff defined in one place, and libdrm is the common codebase to all of these platforms. Additionally, having this struct defined

[Mesa-dev] [PATCH v2 1/6] android: Move gralloc handle struct to libdrm

2018-01-29 Thread Robert Foss
This struct is used in mesa and drm_hwcomposer. Versions of if have been implemented in several grallocs: drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. Other than the 1:1 move of the struct a new generic name has been chosen and variables have had comments added to them. Signed-off-by: Rob

[Mesa-dev] [PATCH v2 4/6] android: Remove member name from gralloc_handle_t

2018-01-29 Thread Robert Foss
The name member of gralloc_handle_t is no longer needed and has been removed. The version field has also been bumped. Signed-off-by: Robert Foss --- android/gralloc_handle.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h

[Mesa-dev] [PATCH v2 3/6] android: Mark gralloc_handle_t magic variable as const

2018-01-29 Thread Robert Foss
Mark magic member of gralloc_handle_t as const. Sign-off-by: Robert Foss Signed-off-by: Robert Foss --- android/gralloc_handle.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h index 8abc83de4626..64196c0b40e7 100644 --- a/

[Mesa-dev] [PATCH v2 2/6] android: Add version variable to gralloc_handle_t

2018-01-29 Thread Robert Foss
The version variable will be used for versioning of this struct and the corresponding accessor functions. Signed-off-by: Robert Foss --- android/gralloc_handle.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h index 7

[Mesa-dev] [PATCH v2 5/6] android: Change gralloc_handle_t format from Android format to fourcc

2018-01-29 Thread Robert Foss
Change the gralloc_handle_t format to signify the fourcc pixel format code instead of the Android pixel format definition. This is desirable since the fourcc code is what is used within the DRM subsystem. Naturally translation will still have to happen somewhere. Also bump the gralloc_handle_t ve

[Mesa-dev] [PATCH v2 6/6] android: Change gralloc_handle_t members to be fixed width

2018-01-29 Thread Robert Foss
In order to lessen future alignment issues, lets switch to fixed width integers where possible. This excludes the data_owner since it is a pid_t which in theory could be larger than 32 bits. Signed-off-by: Robert Foss --- android/gralloc_handle.h | 20 +++- 1 file changed, 11 in

[Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures (v4)

2018-01-29 Thread Brian Paul
From: Marek Olšák v2: - fix glGet* - also use GLenum16 for DrawBuffers v3: - rebase to top of tree (BrianP) and incorporate Ian's suggestions v4: - fix a GLenum16 bug in VBO/save code, add some STATIC_ASSERT()s gl_context = 152432 -> 136840 bytes vbo_context = 22096 -> 20608 bytes Reviewed-

Re: [Mesa-dev] [PATCH 08/20] mesa/st: add support for semaphore object create/import/delete v2

2018-01-29 Thread Marek Olšák
The new files are missing the license. Marek On Tue, Jan 23, 2018 at 7:04 PM, Andres Rodriguez wrote: > Add basic semaphore object operations. > > v2: s/semaphore/fence for pipe objects > > Signed-off-by: Andres Rodriguez > --- > src/mesa/Makefile.sources | 2 + > src/me

Re: [Mesa-dev] [PATCH] mesa: replace GLenum with GLenum16 in common structures (v4)

2018-01-29 Thread Marek Olšák
Looks good to me. Marek On Mon, Jan 29, 2018 at 6:54 PM, Brian Paul wrote: > From: Marek Olšák > > v2: - fix glGet* > - also use GLenum16 for DrawBuffers > v3: - rebase to top of tree (BrianP) and incorporate Ian's suggestions > v4: - fix a GLenum16 bug in VBO/save code, add some STATIC_ASS

[Mesa-dev] [PATCH mesa 1/2] meson: centralise the libdrm versions information

2018-01-29 Thread Eric Engestrom
The big comment is taken from the equivalent block in configure.ac Signed-off-by: Eric Engestrom --- meson.build | 30 + src/gallium/targets/d3dadapter9/meson.build | 2 +- src/mesa/drivers/dri/meson.build| 2 +- 3 files c

[Mesa-dev] [PATCH mesa 2/2] meson: move dep_libdrm_intel with the other dep_libdrm_*

2018-01-29 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- meson.build | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/meson.build b/meson.build index 6d7a8e976ff6ad002d9a..b70c03637beb705f1f9f 100644 --- a/meson.build +++ b/meson.build @@ -211,11 +211,6 @@ if with_gallium_pl111 and not with_

Re: [Mesa-dev] [PATCH 10/11] vbo: optimize loops in bind_vertex_list(), vbo_exec_bind_arrays()

2018-01-29 Thread Brian Paul
On 01/27/2018 08:01 AM, Mathias Fröhlich wrote: Hi Brian, The change should not change the current behavior. Nevertheless the current behavior as well as past your change the code has a corner case that will not work correctly. Can you elaborate? I do have a hand full of unpublished changes

Re: [Mesa-dev] [PATCH 11/20] mesa/st: add support for semaphore object signal/wait v3

2018-01-29 Thread Marek Olšák
On Tue, Jan 23, 2018 at 7:05 PM, Andres Rodriguez wrote: > Bits to implement ServerWaitSemaphoreObject/ServerSignalSemaphoreObject > > v2: > - corresponding changes for gallium fence->semaphore rename > - flushing moved to mesa/main > > v3: s/semaphore/fence for pipe objects > > Signed-off-by:

Re: [Mesa-dev] [PATCH 11/11] vbo: overhaul display list vertex array setup/binding code

2018-01-29 Thread Brian Paul
On 01/27/2018 08:01 AM, Mathias Fröhlich wrote: Hi Brian, That one will not work as is. Display lists are shared objects across contexts. Means past that change the const struct gl_vertex_array *inputs[VBO_ATTRIB_MAX]; may be concurrently written to from different threads filling in curre

Re: [Mesa-dev] [PATCH 12/20] mesa: implement buffer/texture barriers for semaphore signal/wait v2

2018-01-29 Thread Marek Olšák
On Tue, Jan 23, 2018 at 7:05 PM, Andres Rodriguez wrote: > Make sure memory is accessible to the external client, for the specified > memory object, before the signal/after the wait. > > v2: fixed flush order with respect to wait/signal emission > > Signed-off-by: Andres Rodriguez > --- > src/me

Re: [Mesa-dev] [PATCH 12/20] mesa: implement buffer/texture barriers for semaphore signal/wait v2

2018-01-29 Thread Marek Olšák
On Mon, Jan 29, 2018 at 7:53 PM, Marek Olšák wrote: > On Tue, Jan 23, 2018 at 7:05 PM, Andres Rodriguez wrote: >> Make sure memory is accessible to the external client, for the specified >> memory object, before the signal/after the wait. >> >> v2: fixed flush order with respect to wait/signal em

Re: [Mesa-dev] [PATCH 00/20] Add support for GL_EXT_semaphore v3

2018-01-29 Thread Marek Olšák
On Tue, Jan 23, 2018 at 10:16 PM, Andres Rodriguez wrote: > Also, the associated piglit patches: > https://lists.freedesktop.org/archives/piglit/2017-December/023600.html You can just push the piglit patches if you get no review there. Marek ___ mesa-d

Re: [Mesa-dev] [PATCH] swr: don't export swr_create_screen_internal

2018-01-29 Thread Kyriazis, George
Yep, tested on our side, and looks good. Reviewed-By: George Kyriazis mailto:george.kyria...@intel.com>> On Jan 29, 2018, at 9:42 AM, Chuck Atkins mailto:chuck.atk...@kitware.com>> wrote: Lgtm, should probably get a rb from Intel though to make sure it doesn't break anything they're trying t

Re: [Mesa-dev] [PATCH 1/8] radeonsi/nir: add interpolate at intrinsics to scan_instruction()

2018-01-29 Thread Marek Olšák
The case statements should set these variables instead: boolean uses_persp_opcode_interp_centroid; boolean uses_persp_opcode_interp_offset; boolean uses_persp_opcode_interp_sample; boolean uses_linear_opcode_interp_centroid; boolean uses_linear_opcode_interp_offset; boolean uses_

[Mesa-dev] [PATCH shaderdb 2/3] run: fallback to 3.1 core context

2018-01-29 Thread Rob Clark
If we can't create a 3.2 core context, fall back to a 3.1 context. --- run.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/run.c b/run.c index 79d771e..2056ebd 100644 --- a/run.c +++ b/run.c @@ -383,9 +383,22 @@ create_context(EGLDisplay egl_dpy, EGLConfig

[Mesa-dev] [PATCH shaderdb 1/3] run: split out helper to create contexts

2018-01-29 Thread Rob Clark
Since we need to create contexts on both the main thread and omp threads, combine things into a single helper. This reduces some duplication of logic in the following patches. --- run.c | 72 ++- 1 file changed, 50 insertions(+), 22

[Mesa-dev] [PATCH shaderdb 3/3] run: add GLES support

2018-01-29 Thread Rob Clark
--- run.c | 63 --- 1 file changed, 60 insertions(+), 3 deletions(-) diff --git a/run.c b/run.c index 2056ebd..23d2b07 100644 --- a/run.c +++ b/run.c @@ -60,6 +60,7 @@ enum shader_type { TYPE_NONE, TYPE_CORE, TYPE_COMPAT,

Re: [Mesa-dev] [PATCH] r600/sb: Force ELSE path if the byte code started off with it

2018-01-29 Thread Roland Scheidegger
Am 29.01.2018 um 13:15 schrieb Gert Wollny: > sb optimized away the ELSE in a construct like > >while (foo) { > if (bar ) { > do something; > } else { > break; > } >} > > resulting in > >while (foo) { > if (bar ) { > do something; >

[Mesa-dev] [Bug 104843] Mesa version not updated for rebuild

2018-01-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104843 Bug ID: 104843 Summary: Mesa version not updated for rebuild Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Pr

Re: [Mesa-dev] [PATCH 3/8] radeonsi/nir: add si_nir_lookup_interp_param() helper

2018-01-29 Thread Marek Olšák
On Mon, Jan 15, 2018 at 4:46 AM, Timothy Arceri wrote: > --- > src/amd/common/ac_nir_to_llvm.c | 4 --- > src/amd/common/ac_nir_to_llvm.h | 5 > src/amd/common/ac_shader_abi.h| 2 ++ > src/gallium/drivers/radeonsi/si_shader_internal.

Re: [Mesa-dev] [PATCH shaderdb 2/3] run: fallback to 3.1 core context

2018-01-29 Thread Ilia Mirkin
On Mon, Jan 29, 2018 at 2:26 PM, Rob Clark wrote: > If we can't create a 3.2 core context, fall back to a 3.1 context. > --- > run.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/run.c b/run.c > index 79d771e..2056ebd 100644 > --- a/run.c > +++ b/run.

Re: [Mesa-dev] [PATCH 4/8] radeonsi/nir: add si_nir_load_sample_position() helper

2018-01-29 Thread Marek Olšák
It would be better to adjust the interface of load_sample_position as needed instead of adding a new wrapper. Marek On Mon, Jan 15, 2018 at 4:46 AM, Timothy Arceri wrote: > --- > src/gallium/drivers/radeonsi/si_shader.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/gallium/

Re: [Mesa-dev] [PATCH shaderdb 2/3] run: fallback to 3.1 core context

2018-01-29 Thread Rob Clark
On Mon, Jan 29, 2018 at 2:39 PM, Ilia Mirkin wrote: > On Mon, Jan 29, 2018 at 2:26 PM, Rob Clark wrote: >> If we can't create a 3.2 core context, fall back to a 3.1 context. >> --- >> run.c | 17 +++-- >> 1 file changed, 15 insertions(+), 2 deletions(-) >> >> diff --git a/run.c b/run

Re: [Mesa-dev] [PATCH] r600/sb: Force ELSE path if the byte code started off with it

2018-01-29 Thread Gert Wollny
Am Montag, den 29.01.2018, 20:32 +0100 schrieb Roland Scheidegger: > > Am I correct assuming that for something like >while (foo) { > if (bar) { > do something; > } else { > /* nothing */ > } >} > The else clause wouldn't get optimized away neither? > (T

Re: [Mesa-dev] [PATCH] r600/sb: Force ELSE path if the byte code started off with it

2018-01-29 Thread Dave Airlie
On 30 January 2018 at 06:25, Gert Wollny wrote: > Am Montag, den 29.01.2018, 20:32 +0100 schrieb Roland Scheidegger: >> >> Am I correct assuming that for something like >>while (foo) { >> if (bar) { >> do something; >> } else { >> /* nothing */ >> } >>}

[Mesa-dev] [PATCH 3/8] mesa: trivial comment typo fix in arrayobj.c

2018-01-29 Thread Brian Paul
--- src/mesa/main/arrayobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 2810647..b862f0f 100644 --- a/src/mesa/main/arrayobj.c +++ b/src/mesa/main/arrayobj.c @@ -222,7 +222,7 @@ _mesa_reference_vao_(struct gl_contex

[Mesa-dev] [PATCH 2/8] mesa: add an assertion in _mesa_enable_vertex_array_attrib()

2018-01-29 Thread Brian Paul
Some of the enable/disable vertex array functions take a zero-based generic index, while others take a VERT_ATTRIB_GENERIC0-based value. Add an assertion to clarify that in one place. --- src/mesa/main/varray.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/varray.c b/src/mesa/m

[Mesa-dev] [PATCH 6/8] mesa: s/src/attribs/ in _mesa_update_client_array()

2018-01-29 Thread Brian Paul
--- src/mesa/main/varray.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/varray.h b/src/mesa/main/varray.h index 93f2f47..19506bf 100644 --- a/src/mesa/main/varray.h +++ b/src/mesa/main/varray.h @@ -55,19 +55,19 @@ _mesa_vertex_attrib_address(

[Mesa-dev] [PATCH 4/8] mesa: improve comment for gl_array_attributes::BufferBindingIndex

2018-01-29 Thread Brian Paul
--- src/mesa/main/mtypes.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index b0eeeaf..95f6319 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -1538,7 +1538,8 @@ struct gl_array_attributes GLboolean In

[Mesa-dev] [PATCH 1/8] mesa: rename some vars in client_state()

2018-01-29 Thread Brian Paul
--- src/mesa/main/enable.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c index c859a7a..0b3de52 100644 --- a/src/mesa/main/enable.c +++ b/src/mesa/main/enable.c @@ -64,46 +64,

[Mesa-dev] [PATCH 7/8] mesa: rename some 'client' array functions

2018-01-29 Thread Brian Paul
A long time ago gl_vertex_array was gl_client_array. Update some function names to be consistent. --- src/mesa/main/arrayobj.c | 6 +++--- src/mesa/main/arrayobj.h | 4 ++-- src/mesa/main/attrib.c | 2 +- src/mesa/main/state.c| 2 +- src/mesa/main/varray.c | 4 ++-- src/mesa/main/varray.h

[Mesa-dev] [PATCH 8/8] mesa: use gl_vert_attrib enum type in more places

2018-01-29 Thread Brian Paul
Slightly better readbility. --- src/mesa/main/arrayobj.c | 2 +- src/mesa/main/varray.c | 12 ++-- src/mesa/main/varray.h | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index ea9b316..1951638 100644 --- a/s

[Mesa-dev] [PATCH 5/8] mesa: check/assert array index in _mesa_bind_vertex_buffer()

2018-01-29 Thread Brian Paul
--- src/mesa/main/varray.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index bda1c5a..2801a6f 100644 --- a/src/mesa/main/varray.c +++ b/src/mesa/main/varray.c @@ -166,6 +166,7 @@ _mesa_bind_vertex_buffer(struct gl_context *ctx,

Re: [Mesa-dev] [PATCH shaderdb 2/3] run: fallback to 3.1 core context

2018-01-29 Thread Adam Jackson
On Mon, 2018-01-29 at 15:08 -0500, Rob Clark wrote: > Hmm, does that mean there is no way to create a 3.1 core profile if a > driver supports 3.1 compat? This is where the "forward-compatible" bit matters, iirc. If you ask for 3.1FC you shouldn't get ARB_compatibility. - ajax ___

Re: [Mesa-dev] [PATCH shaderdb 2/3] run: fallback to 3.1 core context

2018-01-29 Thread Matt Turner
On Mon, Jan 29, 2018 at 12:08 PM, Rob Clark wrote: > On Mon, Jan 29, 2018 at 2:39 PM, Ilia Mirkin wrote: >> On Mon, Jan 29, 2018 at 2:26 PM, Rob Clark wrote: >>> If we can't create a 3.2 core context, fall back to a 3.1 context. >>> --- >>> run.c | 17 +++-- >>> 1 file changed, 15 i

  1   2   >