[Mesa-dev] [PATCH] anv: avoid segmentation fault due to vk_error()

vk_error() is a macro that calls __vk_errorf() with instance == NULL. Then, __vk_errorf() passes a pointer to instance->debug_report_callbacks to vk_debug_error(), which segfaults as this pointer is invalid but not NULL. Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_util.c |

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #4 from Gert Wollny --- Created attachment 136842 --> https://bugs.freedesktop.org/attachment.cgi?id=136842&action=edit resduce stuttering This change is taken from Dave Airlie CS WIP tree and is one of the hacks that didn't make

[Mesa-dev] [PATCH 2/2] i965/compiler: clean up nir_intrinsic_load_input for vertex shaders

This code to re-set the type of the source and destination is not necessary since we never manipulate the types. Looks like a left over from a time where we had to retype to float temporarily to handle 64-bit inputs. --- src/intel/compiler/brw_fs_nir.cpp | 13 ++--- 1 file changed, 2 inser

[Mesa-dev] [PATCH 1/2] intel/compiler: fix first_component for 64-bit types on vertex inputs

Divide it by two as we do for other stages. This is because the component layout qualifier is always in 32-bit units. Fixes issues in a new CTS test (still WIP): KHR-GL45.enhanced_layouts.varying_double_components --- src/intel/compiler/brw_fs_nir.cpp | 3 +++ 1 file changed, 3 insertions(+) dif

Re: [Mesa-dev] [PATCH] anv: avoid segmentation fault due to vk_error()

Reviewed-by: Tapani Pälli (Fixes e5b1bd6ab8) On 01/19/2018 09:59 AM, Samuel Iglesias Gonsálvez wrote: vk_error() is a macro that calls __vk_errorf() with instance == NULL. Then, __vk_errorf() passes a pointer to instance->debug_report_callbacks to vk_debug_error(), which segfaults as this poi

Re: [Mesa-dev] [PATCH] mesa: Only require independent blending for GLES 3.2.

Yep, that is addition to GLES 3.2 spec. Reviewed-by: Tapani Pälli On 01/19/2018 07:36 AM, Eric Anholt wrote: We've been requiring this since GLES 3.0 was introduced, but the GLES 3.2 spec is the one that has "Supporting blending on a per-draw-buffer basis" in the new features. V3D 3.3 would r

Re: [Mesa-dev] [PATCH 2/2] st/vdpau: release held lock in error path

Sorry, my Reviewed-by accounted for both patches in this series. Christian. Am 19.01.2018 um 00:23 schrieb Grazvydas Ignotas: Anyone cares about vdpau? Gražvydas On Tue, Jan 16, 2018 at 12:03 AM, Grazvydas Ignotas wrote: Signed-off-by: Grazvydas Ignotas --- src/gallium/state_trackers/vdp

Re: [Mesa-dev] [ANNOUNCE] mesa 17.2.8

On Thu, 2018-01-18 at 15:14 +, Emil Velikov wrote: > On 18 January 2018 at 13:43, Andres Gomez wrote: > > On Thu, 2018-01-18 at 09:56 +0100, Juan A. Suarez Romero wrote: > > > On Wed, 2018-01-17 at 18:03 +, Emil Velikov wrote: > > > > On 22 December 2017 at 23:05, Andres Gomez wrote: > >

Re: [Mesa-dev] [PATCH 4/5] docs: move untar line in basic testing instructions for coherence

On Thu, 2018-01-18 at 23:26 +, Eric Engestrom wrote: > On Thursday, 2018-01-18 23:06:40 +, Andres Gomez wrote: > > For scons, windows/mingw dealing with LLVM_CONFIG is done before > > untarring. > > Isn't this a no-op change? Yes, it is. A real nitpick to be able to copy and paste more co

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 2018-01-18 22:08:17, Tapani Pälli wrote: > > > On 01/18/2018 08:18 PM, Jordan Justen wrote: > > On 2018-01-15 04:31:43, Tapani Pälli wrote: > >> This can/should be modified depending on needs. AFAIK by default, > >> this is the only path that can be read/written to by anyone. > >> > >> Signed-

Re: [Mesa-dev] [PATCH] ac/nir: Fix TCS output LDS offsets.

Reviewed-by: Timothy Arceri On 19/01/18 11:23, Bas Nieuwenhuizen wrote: When a channel was not set we also did not increase the LDS address, while that obviously should happen. The output loading code was inadvertently fixed which resulted in a mismatch causing the SaschaWillems tessellation d

Re: [Mesa-dev] [PATCH 2/6] st/omx/tizonia: Add --enable-omx-tizonia flag and build files

Hi Leo, Do you have enough data to start the merge ? Thx Julien On 18 January 2018 at 02:28, Gurkirpal Singh wrote: > > > On Wed, Jan 17, 2018 at 10:39 PM, Dylan Baker wrote: > >> The meson build for omx-bellagio has landed along with the other media >> state >> trackers that are in tree. Cur

[Mesa-dev] [PATCH v2 2/5] util: emulate futex on FreeBSD using umtx

Obtained from: FreeBSD ports --- src/util/futex.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/util/futex.h b/src/util/futex.h index 4402893069..425e34a2cd 100644 --- a/src/util/futex.h +++ b/src/util/futex.h @@ -51,6 +51,28 @@ static inline int futex_wait(uint32

[Mesa-dev] [PATCH v2 0/5] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Rebased, updated and improved patches. Now with util headers for anonymous fds (memfd/SHM_ANON/mkostemp) and physical memory size, reducing code duplication across the codebase. A few other meson patches were sent as https://patchwork.freedesktop.org/series/36714/ Greg V (5): meson: fix miss

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

On 01/18/2018 22:49, Dylan Baker wrote: Quoting Emil Velikov (2018-01-18 10:40:40) On 18 January 2018 at 17:13, Dylan Baker wrote: I'm not sure how Emil feels about this (and the related patches) but I think it might be better to handle this at the build system level, for meson it would look s

[Mesa-dev] [PATCH v2 3/5] util: add anon_file.h for all memfd/temp file usage

Move the Weston os_create_anonymous_file code from egl/wayland into util, add support for Linux memfd and FreeBSD SHM_ANON, use that code in anv instead of explicit memfd calls for portability. --- src/egl/drivers/dri2/platform_wayland.c | 116 +- src/intel/vulkan/anv_allocator

Re: [Mesa-dev] [PATCH v2 0/4] Fix unm_sampes and some warnings

Am Donnerstag, den 18.01.2018, 14:15 -0800 schrieb Ian Romanick: > Patches 2, 3, and 4 are > > Reviewed-by: Ian Romanick > Thanks, I send out a lot of patches that fix warnings.  I like to copy-and- paste the warnings that are eliminated into the commit message.  It's not required, but I feel

Re: [Mesa-dev] [PATCH 11/14] meson: fix missing dependencies

On 01/18/2018 20:58, Emil Velikov wrote: On 6 January 2018 at 01:50, Dylan Baker wrote: On January 5, 2018 5:00:59 PM PST, Greg V wrote: On 01/06/2018 01:36, Dylan Baker wrote: Quoting Greg V (2017-12-31 08:55:25) --- ../src/gallium/include/state_tracker/vdpau_dmabuf.h:37:10: fatal error

[Mesa-dev] [PATCH v2 5/5] anv: add MAP_POPULATE fallback define for portability

FreeBSD does not have MAP_POPULATE --- src/intel/vulkan/anv_allocator.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index aa669359d7..1fe00f9ef6 100644 --- a/src/intel/vulkan/anv_allocator.c +++ b/src/intel/vulkan/anv_

[Mesa-dev] [PATCH v2 1/5] meson: fix missing dependencies

--- src/gallium/drivers/radeonsi/meson.build | 2 +- src/mesa/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/meson.build b/src/gallium/drivers/radeonsi/meson.build index 97c7a41244..f41c0b4f18 100644 --- a/src/ga

[Mesa-dev] [PATCH v2 4/5] util: add phys_memory.h for all memory measurements

Move the os_get_total_physical_memory function from gallium to util, simplify it (all BSDs support sysconf, no need for sysctl), use it in gallium, anv, dri/i915, dri/i965 and dri/swrast. --- src/gallium/auxiliary/os/os_misc.c | 60 --- src/gallium/auxiliary/os/os_misc.h

Re: [Mesa-dev] [PATCH] ac/nir: fix user sgpr allocations on gfx9

Hi Dave Am 19.01.2018 um 00:22 schrieb Dave Airlie: From: Dave Airlie The code to decide how to allocate sgprs didn't take into account the merged shaders on gfx9. This updates the code to count the correct number of requires sgprs, which means we should be able to enable push const inlining

[Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

Signed-off-by: Tapani Pälli --- Small crucible test available here: https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority src/intel/vulkan/anv_device.c | 25 +++ src/intel/vulkan/anv_extensions.py | 2 ++ src/intel/vulkan/anv_gem.c | 49 +++

Re: [Mesa-dev] [PATCH] mesa: enable ASTC/ETC1 compressed textures

Anyone could take a look at this patch? Thanks in advance! J.A. On Thu, 2018-01-11 at 16:35 +0100, Juan A. Suarez Romero wrote: > Enable these kind of texture when proper extensions are available. > > Fixes KHR-GLES2.texture_3d.* with these textures. > --- > src/mesa/main/teximage.c

Re: [Mesa-dev] [PATCH 0/5] docs: add missing final release of series notes

For the series, Reviewed-by: Juan A. Suarez J.A. On Fri, 2018-01-19 at 00:29 +0200, Andres Gomez wrote: > Just a series to add the missing "final release" note for 17.1.10 and > 17.2.8, as commented at: > https://lists.freedesktop.org/archives/mesa-dev/2018-January/182322.html > > Addi

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #56 from Sven --- (In reply to Juan A. Suarez from comment #55) > Is this bug already fixed? With commit: > > commit 897c54d522ab960a879b763a15e489f630c491ee > Author: Thomas Hellstrom > Date: Thu Jan 11 10:19:23 2018 +0100 > >

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

Quoting Tapani Pälli (2018-01-19 10:44:49) > diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c > index 34c0989108..46069dcdc7 100644 > --- a/src/intel/vulkan/anv_gem.c > +++ b/src/intel/vulkan/anv_gem.c > @@ -302,6 +302,55 @@ close_and_return: > return swizzled; > } > > +s

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 01/19/2018 11:22 AM, Jordan Justen wrote: On 2018-01-18 22:08:17, Tapani Pälli wrote: On 01/18/2018 08:18 PM, Jordan Justen wrote: On 2018-01-15 04:31:43, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default, this is the only path that can be read/written

[Mesa-dev] [PATCH] radeonsi/nir: add nir_intrinsic_load_sample_mask_in to ir scan

Fixes a bunch of ARB_sample_shading piglit tests. --- src/gallium/drivers/radeonsi/si_shader_nir.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c b/src/gallium/drivers/radeonsi/si_shader_nir.c index a9e852c0bc..4455322392 100644 --- a/src/galli

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 01/19/2018 01:00 PM, Chris Wilson wrote: Quoting Tapani Pälli (2018-01-19 10:44:49) diff --git a/src/intel/vulkan/anv_gem.c b/src/intel/vulkan/anv_gem.c index 34c0989108..46069dcdc7 100644 --- a/src/intel/vulkan/anv_gem.c +++ b/src/intel/vulkan/anv_gem.c @@ -302,6 +302,55 @@ close_and_retur

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 19/01/18 11:44, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > > Small crucible test available here: > https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority > > src/intel/vulkan/anv_device.c | 25 +++ > src/intel/vulkan/anv_extensions.

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

Oh, Chris was faster :) Sam On 19/01/18 12:08, Samuel Iglesias Gonsálvez wrote: > > On 19/01/18 11:44, Tapani Pälli wrote: >> Signed-off-by: Tapani Pälli >> --- >> >> Small crucible test available here: >> https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority >> >> src

[Mesa-dev] [PATCH] radv: add an option that allows to dump pre-optimization ir

With RADV_DEBUG=preoptir. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 3 +++ src/amd/common/ac_nir_to_llvm.h | 1 + src/amd/vulkan/radv_debug.h | 1 + src/amd/vulkan/radv_device.c| 1 + src/amd/vulkan/radv_shader.c| 2 ++ 5 files changed, 8 insertions(+) dif

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 01/19/2018 01:08 PM, Samuel Iglesias Gonsálvez wrote: On 19/01/18 11:44, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- Small crucible test available here: https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority src/intel/vulkan/anv_device.c | 25

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 19/01/18 12:11, Tapani Pälli wrote: > > > On 01/19/2018 01:08 PM, Samuel Iglesias Gonsálvez wrote: >> >> >> On 19/01/18 11:44, Tapani Pälli wrote: >>> Signed-off-by: Tapani Pälli >>> --- >>> >>> Small crucible test available here: >>> https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

https://bugs.freedesktop.org/show_bug.cgi?id=104654 mirh changed: What|Removed |Added CC||m...@protonmail.ch -- You are receiving this ma

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 01/19/2018 01:03 PM, Tapani Pälli wrote: On 01/19/2018 11:22 AM, Jordan Justen wrote: On 2018-01-18 22:08:17, Tapani Pälli wrote: On 01/18/2018 08:18 PM, Jordan Justen wrote: On 2018-01-15 04:31:43, Tapani Pälli wrote: This can/should be modified depending on needs. AFAIK by default,

Re: [Mesa-dev] [PATCH] anv: implement VK_EXT_global_priority extension

On 01/19/2018 01:20 PM, Samuel Iglesias Gonsálvez wrote: On 19/01/18 12:11, Tapani Pälli wrote: On 01/19/2018 01:08 PM, Samuel Iglesias Gonsálvez wrote: On 19/01/18 11:44, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- Small crucible test available here: https://cgit.freedesktop

[Mesa-dev] [PATCH v2] anv: implement VK_EXT_global_priority extension

v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris) use unreachable with unknown priority (Samuel) Signed-off-by: Tapani Pälli --- Small crucible test available here: https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_EXT_global_priority src/intel/vulkan/anv_device.c | 25 ++

[Mesa-dev] [PATCH] radeonsi/nir: add primitive id to inputs scan

Fixes the following piglit tests: arb_tessellation_shader/fs-primitiveid-instanced glsl-1.50/primitive-id-no-gs glsl-1.50/primitive-id-no-gs-first-vertex glsl-1.50/primitive-id-no-gs-instanced glsl-1.50/primitive-id-no-gs-strip glsl-1.50/primitive-id-no-gs-strip-first-vertex --- src/gallium/drive

Re: [Mesa-dev] [PATCH v2] anv: implement VK_EXT_global_priority extension

Reviewed-by: Samuel Iglesias Gonsálvez Sam On 19/01/18 12:36, Tapani Pälli wrote: > v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris) > use unreachable with unknown priority (Samuel) > > Signed-off-by: Tapani Pälli > --- > > Small crucible test available here: > https://cgit.freedesktop.org/~tp

Re: [Mesa-dev] [PATCH 5/5] docs: correct a typo in releasing instructions

On 18 January 2018 at 22:29, Andres Gomez wrote: > Cc: Emil Velikov > Cc: Juan A. Suarez Romero > Signed-off-by: Andres Gomez > --- > docs/releasing.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/releasing.html b/docs/releasing.html > index d105bc96f6a..a022

Re: [Mesa-dev] [PATCH v2] anv: implement VK_EXT_global_priority extension

Quoting Samuel Iglesias Gonsálvez (2018-01-19 11:58:24) > Reviewed-by: Samuel Iglesias Gonsálvez Me too! Reviewed-by: Chris Wilson -Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

https://bugs.freedesktop.org/show_bug.cgi?id=104214 Thomas Hellström changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] ac: fix emit vertex stream parameter

On Jan 19, 2018 1:28 AM, "Timothy Arceri" wrote: Fixes the following piglit test on radeonsi: ./bin/arb_enhanced_layouts-gs-stream-location-aliasing --- src/amd/common/ac_nir_to_llvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 17.2.8

We missed to mention this. NOTE: It is anticipated that 17.2.8 will be the final release in the 17.2 series. Users of 17.2 are encouraged to migrate to the 17.3 series in order to obtain future fixes. On Sat, 2017-12-23 at 01:05 +0200, Andres Gomez wrote: > Mesa 17.2.8 is now available. > > In

Re: [Mesa-dev] [PATCH v2 1/4] meson: fix BSD build

On Wednesday, 2018-01-17 23:54:15 +0300, Greg V wrote: > Reviewed-by: Dylan Baker A couple questions and a nit-pick for the error messages, but with that: Reviewed-by: Eric Engestrom > --- > meson.build | 44 +++- > 1 file changed, 23 insertions(+), 21 d

[Mesa-dev] [PATCH] radv: restore previous stencil reference after depth-stencil clear

Cc: mesa-sta...@lists.freedesktop.org --- src/amd/vulkan/radv_meta_clear.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index b42ecedfc9..98fb8fa6a7 100644 --- a/src/amd/vulkan/radv_meta_clear.c +++ b/src/amd/vulkan/r

Re: [Mesa-dev] [PATCH v2 4/4] mesa/program: Fix -Wunused-param warning

On 18 January 2018 at 08:57, Gert Wollny wrote: > v2: Remove the unused ctx parameter from _mesa_optimize_program. > > v1: Annotate the unused parameter > v1 was reviewed by Reviewed-by: Emil Velikov > > Signed-off-by: Gert Wollny For the future please make the changelog something like: v2: Don

[Mesa-dev] [PATCH] winsys/amdgpu: Set RADEON_FLAG_GTT_WC for UVD buffer

without this flag, it fails an assertion with assertions disabled it retries with this flag set --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

On Tuesday, 2018-01-16 18:35:40 +, Emil Velikov wrote: > On 15 January 2018 at 22:03, Grazvydas Ignotas wrote: > > Found with the help of following Coccinelle semantic patch: > > // > > @@ > > expression E; > > @@ > > > > \(pthread_mutex_lock\|mtx_lock\|simple_mtx_lock\)(E) > > ... > > (

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

On 19 January 2018 at 14:46, Eric Engestrom wrote: > On Tuesday, 2018-01-16 18:35:40 +, Emil Velikov wrote: >> On 15 January 2018 at 22:03, Grazvydas Ignotas wrote: >> > Found with the help of following Coccinelle semantic patch: >> > // >> > @@ >> > expression E; >> > @@ >> > >> > \(pthre

Re: [Mesa-dev] [PATCH v2] anv: implement VK_EXT_global_priority extension

On 19 January 2018 at 11:36, Tapani Pälli wrote: > +#define ANV_CONTEXT_LOW_PRIORITY ((I915_CONTEXT_MIN_USER_PRIORITY-1)/2) > +#define ANV_CONTEXT_MEDIUM_PRIORITY (I915_CONTEXT_DEFAULT_PRIORITY) > +#define ANV_CONTEXT_HIGH_PRIORITY ((I915_CONTEXT_MAX_USER_PRIORITY+1)/2) You want to document why t

Re: [Mesa-dev] [PATCH] radv: restore previous stencil reference after depth-stencil clear

Reviewed-by: Samuel Pitoiset On 01/19/2018 03:11 PM, Matthew Nicholls wrote: Cc: mesa-sta...@lists.freedesktop.org --- src/amd/vulkan/radv_meta_clear.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/amd/vulkan/radv_meta_clear.c b/src/amd/vulkan/radv_meta_clear.c index b42ecedf

Re: [Mesa-dev] [PATCH] radv: restore previous stencil reference after depth-stencil clear

Reviewed-by: Alex Smith On 19 January 2018 at 15:14, Samuel Pitoiset wrote: > Reviewed-by: Samuel Pitoiset > > > On 01/19/2018 03:11 PM, Matthew Nicholls wrote: > >> Cc: mesa-sta...@lists.freedesktop.org >> --- >> src/amd/vulkan/radv_meta_clear.c | 6 ++ >> 1 file changed, 6 insertions(

[Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

From: Emil Velikov Already used as such through the codebase. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h index 79e

Re: [Mesa-dev] [PATCH] i965: make brw_context::num_samples unsigned int

Why? I think it's probably fine but changing signedness of a variable is always a bit tricky. On January 19, 2018 08:04:24 Emil Velikov wrote: From: Emil Velikov Already used as such through the codebase. Signed-off-by: Emil Velikov --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1

Re: [Mesa-dev] [PATCH 13/14] swr: fix clang 5 null cast warning

On 18 January 2018 at 19:01, Cherniak, Bruce wrote: > Apologies for not seeing this over the holidays. > > Reviewed-by: Bruce Cherniak > No worries - we all need to chill sometimes ;-) Pushed to master. -Emil ___ mesa-dev mailing list mesa-dev@lists.fr

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

On 18 January 2018 at 21:30, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-18 10:57:02) >> On 18 January 2018 at 18:29, Greg V wrote: >> > >> > On 01/18/2018 21:18, Emil Velikov wrote: >> >> >> >> Hi Greg, >> >> >> >> On 31 December 2017 at 16:55, Greg V wrote: >> >>> >> >>> Hello everyone

Re: [Mesa-dev] [PATCH 07/14] anv: FreeBSD support in the allocator

I'm not 100% sure why but GMail has decided that every single e-mail you send to the mailing list is spam. You might want to check that out. :) On Sun, Dec 31, 2017 at 8:55 AM, Greg V wrote: > Use umtx for futex, and SHM_ANON for memfd. > > Also use temp files as memfd fallback for other OSes.

Re: [Mesa-dev] [PATCH 00/14] BSD portability (Meson, ANV, RADV, VC4/5, SWR)

Hi, On 19 January 2018 at 16:26, Emil Velikov wrote: > On 18 January 2018 at 21:30, Dylan Baker wrote: >> I'm willing to defer to you on this, if you think that checking headers for >> ETIME is too fragile then we can leave it (you definitely have more >> experience >> in these things). I'm jus

Re: [Mesa-dev] [PATCH 02/14] vc4, vc5: add ETIME fallback define

On 18 January 2018 at 21:51, Greg V wrote: > On 01/18/2018 22:49, Dylan Baker wrote: >> >> Quoting Emil Velikov (2018-01-18 10:40:40) >>> >>> On 18 January 2018 at 17:13, Dylan Baker wrote: I'm not sure how Emil feels about this (and the related patches) but I think it might b

Re: [Mesa-dev] [PATCH v2] anv: implement VK_EXT_global_priority extension

On Fri, Jan 19, 2018 at 3:36 AM, Tapani Pälli wrote: > v2: add ANV_CONTEXT_REALTIME_PRIORITY (Chris) > use unreachable with unknown priority (Samuel) > > Signed-off-by: Tapani Pälli > --- > > Small crucible test available here: > https://cgit.freedesktop.org/~tpalli/crucible/commit/?h=VK_ >

[Mesa-dev] [PATCH] st/mesa: provide static inline st_init_vdpau_functions

From: Emil Velikov The ifdef spaghetty in st_vdpau.c is rather confusing and misleading. Simplily it by introducing a static inline helper noop (when HAVE_ST_VDPAU is not defined) in the header. Signed-off-by: Emil Velikov --- src/mesa/state_tracker/st_vdpau.c | 9 +++-- src/mesa/state_tra

Re: [Mesa-dev] [PATCH 11/14] meson: fix missing dependencies

On 18 January 2018 at 20:49, Greg V wrote: >> Actually a better solution is to remove the unnecessary includes, all >> together: >> - vdpau_dmabuf.h - add forward declaration for VdpVideoSurface and >> drop the header > > There's more than VdpVideoSurface, it also uses VdpOutputSurface and > Vd

Re: [Mesa-dev] [PATCH v2 3/5] util: add anon_file.h for all memfd/temp file usage

On 18 January 2018 at 22:54, Greg V wrote: > Move the Weston os_create_anonymous_file code from egl/wayland into util, > add support for Linux memfd and FreeBSD SHM_ANON, > use that code in anv instead of explicit memfd calls for portability. > --- Looks quite good - a few small suggestions below

Re: [Mesa-dev] [PATCH v2 2/5] util: emulate futex on FreeBSD using umtx

Don't know enough of FreeBSD to actually review this but it looks sane. Acked-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 04/17] mesa: update comment on gl_display_list

--- src/mesa/main/mtypes.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index fe5f9d7..bcec9d7 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -4372,9 +4372,7 @@ union gl_dlist_node; /** - * Provide

[Mesa-dev] [PATCH 01/17] vbo: move DLIST_DANGLING_REFS from mtypes.h to vbo_save_api.c

It's only used in this file. --- src/mesa/main/mtypes.h | 9 - src/mesa/vbo/vbo_save_api.c | 5 + 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 1f1792e..ec51d41 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mes

[Mesa-dev] [PATCH 02/17] mesa: remove unused MAT_INDEX_AMBIENT/DIFFUSE/SPECULAR contants

--- src/mesa/main/mtypes.h | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index ec51d41..5fda348 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -291,10 +291,6 @@ struct gl_config #define MAT_ATTRIB_SHININESS(f)(MAT_ATTRI

[Mesa-dev] [PATCH 05/17] mesa: move vbo_count_tessellated_primitives() to api_validate.c

It's only used in this file and has nothing VBO-specific about it. --- src/mesa/main/api_validate.c | 68 ++-- src/mesa/vbo/vbo.h | 4 --- src/mesa/vbo/vbo_exec.c | 65 -- 3 files changed, 65 insertions

[Mesa-dev] [PATCH 06/17] vbo: move vbo_sizeof_ib_type() into vbo_exec_array.c

It's only used in this one file. --- src/mesa/vbo/vbo.h| 16 src/mesa/vbo/vbo_exec_array.c | 31 --- 2 files changed, 24 insertions(+), 23 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index c1c3e0e..7fc7c55 100644 --- a

[Mesa-dev] [PATCH 08/17] nouveau: remove vbo_context() call

_vbo_DestroyContext() can be safely called even if there's no VBO module. Removes a dependency on the vbo_context() function. --- src/mesa/drivers/dri/nouveau/nouveau_context.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_context.c b/

[Mesa-dev] [PATCH 03/17] mesa: whitespace clean-ups in mtypes.h

--- src/mesa/main/mtypes.h | 150 +++-- 1 file changed, 82 insertions(+), 68 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 5fda348..fe5f9d7 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -270,11 +27

[Mesa-dev] [PATCH 10/17] vbo: move VBO-private types, prototypes, etc. into new vbo_private.h header

Things which should not be used outside the VBO module. More public/private clean-ups coming. --- src/mesa/vbo/vbo.h | 9 -- src/mesa/vbo/vbo_context.c | 19 src/mesa/vbo/vbo_context.h | 158 +--- src/mesa/vbo/vbo_exec.c

[Mesa-dev] [PATCH 11/17] vbo: move remaining items from vbo_context.h to vbo.h

Non-VBO sources files sometimes included vbo.h while others included vbo_context.h. We're moving all public types, functions to the former. --- src/mesa/vbo/vbo.h | 6 ++ src/mesa/vbo/vbo_context.c | 2 +- src/mesa/vbo/vbo_context.h | 40 ---

[Mesa-dev] [PATCH 12/17] vbo: remove vbo_context.h and change includes to use vbo.h instead

Now vbo.h is the public interface to the VBO module. --- src/mesa/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_context.c | 2 +- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/nouveau/nouveau_render.h | 2 +- src/mesa/main/state.c

[Mesa-dev] [PATCH 09/17] mesa: use new _vbo_install_exec_vtxfmt() function

Instead of reaching into the vbo_context object in vtxfmt.c --- src/mesa/main/vtxfmt.c | 3 +-- src/mesa/vbo/vbo_context.c | 10 ++ src/mesa/vbo/vbo_context.h | 4 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/vtxfmt.c b/src/mesa/main/vtxfmt.c ind

[Mesa-dev] [PATCH 07/17] i965: use vbo_set_[indirect]_draw_func()

Instead of poking into the vbo_context object. --- src/mesa/drivers/dri/i965/brw_draw.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index fc349ad..73f2e1f 100644 --- a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 13/17] vbo: remove unneeded #includes

--- src/mesa/vbo/vbo_primitive_restart.c | 1 - src/mesa/vbo/vbo_save.c | 1 - src/mesa/vbo/vbo_split.c | 2 -- src/mesa/vbo/vbo_split_inplace.c | 1 - 4 files changed, 5 deletions(-) diff --git a/src/mesa/vbo/vbo_primitive_restart.c b/src/mesa/vbo/vbo_primitive_rest

[Mesa-dev] [PATCH 14/17] vbo: remove unused vbo_any_varyings_in_vbos() function

--- src/mesa/vbo/vbo.h| 3 --- src/mesa/vbo/vbo_rebase.c | 10 -- 2 files changed, 13 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index ec2ac0e..0007029 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@ -153,10 +153,7 @@ void vbo_split_prims( struc

[Mesa-dev] [PATCH 15/17] vbo/i965: move vbo_all_varyings_in_vbos() to brw_draw.c

It's only used in brw_draw_prims(). s/GLboolean/bool/, etc. --- src/mesa/drivers/dri/i965/brw_draw.c | 18 +- src/mesa/vbo/vbo.h | 2 -- src/mesa/vbo/vbo_rebase.c| 11 --- 3 files changed, 17 insertions(+), 14 deletions(-) diff --git a/src/m

[Mesa-dev] [PATCH 16/17] vbo: whitespace/formatting fixes in vbo.h

--- src/mesa/vbo/vbo.h | 112 - 1 file changed, 68 insertions(+), 44 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index 30c83fc..164477f 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@ -42,7 +42,8 @@ struct gl_ve

[Mesa-dev] [PATCH 17/17] vbo: whitespace/formatting fixes in vbo_split_inplace.c

--- src/mesa/vbo/vbo_split_inplace.c | 215 --- 1 file changed, 111 insertions(+), 104 deletions(-) diff --git a/src/mesa/vbo/vbo_split_inplace.c b/src/mesa/vbo/vbo_split_inplace.c index a2717ab..2c363c2 100644 --- a/src/mesa/vbo/vbo_split_inplace.c +++ b/src/m

Re: [Mesa-dev] [PATCH v2 1/5] meson: fix missing dependencies

On 18 January 2018 at 22:54, Greg V wrote: > --- > src/gallium/drivers/radeonsi/meson.build | 2 +- > src/mesa/meson.build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/meson.build > b/src/gallium/drivers/radeonsi/mes

Re: [Mesa-dev] [PATCH] autotools: include meson build files in tarball

On 18 January 2018 at 00:22, Dylan Baker wrote: > This adds the meson.build, meson_options.txt, and a few scripts that are > used exclusively by the meson build. > > Signed-off-by: Dylan Baker > --- With the nit mentioned by Eric, the patch is Reviewed-by: Emil Velikov -Emil ___

Re: [Mesa-dev] [PATCH 0/6] meson: fix gallium media target linkage

On 18 January 2018 at 19:36, Dylan Baker wrote: > Quoting Emil Velikov (2018-01-18 11:12:30) >> On 17 January 2018 at 18:34, Dylan Baker wrote: >> > The linkage of all of the gallium media targets is broken in various >> > ways in the meson build. This series should correct that by doing more >>

Re: [Mesa-dev] [PATCH 7/7] android: set '/sdcard/' as MESA_GLSL_CACHE_DIR by default

On 2018-01-19 03:03:43, Tapani Pälli wrote: > On 01/19/2018 11:22 AM, Jordan Justen wrote: > > On 2018-01-18 22:08:17, Tapani Pälli wrote: > >> On 01/18/2018 08:18 PM, Jordan Justen wrote: > >>> On 2018-01-15 04:31:43, Tapani Pälli wrote: > This can/should be modified depending on needs. AFAIK

Re: [Mesa-dev] [PATCH v2] meson: Don't confuse the install and search paths for dri drivers

On 17 January 2018 at 21:34, Dylan Baker wrote: > Currently there is not a separate option for setting the search path of > DRI drivers in meson, like there is in scons and autotools. This is an > oversight and needs to be fixed. This adds an extra option > `dri-search-path`, which will default to

Re: [Mesa-dev] [7/6] meson: use va-api version reported by pkg-config

Am Donnerstag, 18. Januar 2018, 19:05:41 CET schrieb Dylan Baker: > Signed-off-by: Dylan Baker > --- > meson.build | 2 +- > src/gallium/state_trackers/va/meson.build | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) vainfo reports no longer an error, s

[Mesa-dev] [PATCH v2 01/12] anv/image: Do not override lower bits of dword.

The lower bits seem to have extra fields in every platform but gen8 (even though we don't use them in gen9). So just go ahead and avoid using them for the address. Signed-off-by: Rafael Antognolli --- src/intel/vulkan/anv_image.c | 30 +- 1 file changed, 17 insertions

[Mesa-dev] [PATCH v2 00/12] Use clear color address in surface state.

Second version of this series, with (hopefully) full support for this in Vulkan. Rafael Antognolli (12): anv/image: Do not override lower bits of dword. genxml: Preserve fields that share dword space with addresses. intel/genxml: Use a single field for clear color address on gen10. intel/i

[Mesa-dev] [PATCH v2 07/12] i965/miptree: Add space to store the clear value in the aux surface.

Similarly to vulkan where we store the clear value in the aux surface, we can do the same in GL. v2: Remove unneeded extra function. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/drive

[Mesa-dev] [PATCH v2 04/12] intel/isl: Add support to emit clear value address.

gen10 can emit the clear color by setting it on a buffer somewhere, and then adding only the address to the surface state. This commit add support for that on isl_surf_fill_state, and if that is requested, skip setting the clear value itself. v2: Add assert to make sure we are at least on gen10.

[Mesa-dev] [PATCH v2 02/12] genxml: Preserve fields that share dword space with addresses.

Some instructions contain fields that are either an address or a value of some type based on the content of other fields, such as clear color values vs address. That works fine if these fields are in the less significant dword, the lower 32 bits of the address, because they get OR'ed with the addre

[Mesa-dev] [PATCH v2 08/12] i965/blorp: Update the fast clear color entry buffer.

On Gen10, whenever the fast clear color changes, update it on the clear color entry buffer. This allow us to use it directly when emitting the surface state. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_blorp.c | 26 ++ 1 file changed, 26 insertions(

[Mesa-dev] [PATCH v2 03/12] intel/genxml: Use a single field for clear color address on gen10.

genxml does not support having two address fields with different names but same position in the state struct. Both "Clear Color Address" and "Clear Depth Address Low" mean the same thing, only for different surface types. To workaround this genxml limitation, rename "Clear Color Address" to "Clear

[Mesa-dev] [PATCH v2 09/12] i965/surface_state: Emit the clear color address instead of value.

On Gen10, when emitting the surface state, use the value stored in the clear color entry buffer by using a clear color address in the surface state. Signed-off-by: Rafael Antognolli --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 16 1 file changed, 16 insertions(+) diff

[Mesa-dev] [PATCH v2 05/12] anv: Make the clear address 64 bytes aligned.

On Gen10+, if we use the clear state address field in the surface state instead of the clear color directly, there's a restriction that the address must point to the lower part of a 64 byte cache-line. So we add a padding to the state buffer to make it align to 64 bytes when multiple LOD is present

[Mesa-dev] [PATCH v2 06/12] intel/blorp: Add suport for fast clear address.

On gen10+, if surface->clear_color_addr is present, use it directly intead of copying it to the surface state. Signed-off-by: Rafael Antognolli --- src/intel/blorp/blorp_genX_exec.h | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/intel/blorp/blorp_genX_exec.h

  1   2   >