Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Christian König
Reviewed-by: Christian König Do you have commit right by now or should Leo or I commit that for you? Thanks for the help, Christian. Am 15.01.2018 um 23:03 schrieb Grazvydas Ignotas: Found with the help of following Coccinelle semantic patch: // @@ expression E; @@ \(pthread_mutex_lock\|

Re: [Mesa-dev] DRI Configurator replacement announcement

2018-01-16 Thread Gustaw Smolarczyk
2018-01-16 8:33 GMT+01:00 Gert Wollny : > Hello Jean, > > Am Montag, den 15.01.2018, 20:15 + schrieb Jean Hertel: > > I have written a simply application like DRI Conf tool. > > It is written using GTKmm and C++. > Great! > > Unfortunately, it didn't link properly, so I send you a pull request

Re: [Mesa-dev] [PATCH 6/7] android: ignore MESA_GLSL_CACHE_DISABLE setting

2018-01-16 Thread Jordan Justen
On 2018-01-15 04:31:42, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/mesa/drivers/dri/i965/brw_disk_cache.c | 2 ++ > src/util/disk_cache.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_disk_cache.c > b/src/mesa/d

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

2018-01-16 Thread Gurkirpal Singh
On Mon, Jan 15, 2018 at 9:24 PM, Leo Liu wrote: > Hi lists, > > > If there is no more questions, and no objection, I would like to commit > this new OMX st. to upstream. > > @Gurkipal, If you can send me or lists your rebased patches set for > committing, that would be appreciated. > I wanted to

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

2018-01-16 Thread Christian König
Am 16.01.2018 um 10:40 schrieb Gurkirpal Singh: On Mon, Jan 15, 2018 at 9:24 PM, Leo Liu > wrote: Hi lists, If there is no more questions, and no objection, I would like to commit this new OMX st. to upstream. @Gurkipal, If you can send me or lists y

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Grazvydas Ignotas
On Tue, Jan 16, 2018 at 10:15 AM, Christian König wrote: > Reviewed-by: Christian König > > Do you have commit right by now or should Leo or I commit that for you? Yes I do. > > Thanks for the help, > Christian. > > > Am 15.01.2018 um 23:03 schrieb Grazvydas Ignotas: >> >> Found with the help o

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Christian König
Am 16.01.2018 um 11:20 schrieb Grazvydas Ignotas: On Tue, Jan 16, 2018 at 10:15 AM, Christian König wrote: Reviewed-by: Christian König Do you have commit right by now or should Leo or I commit that for you? Yes I do. Of course you have :) My fault I mixed up the mails/names, Christian.

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104654 Bug ID: 104654 Summary: r600/sb: Alien Isolation GPU lock Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Prior

Re: [Mesa-dev] [PATCH 02/10] i965: Use the translated color logic op from the context

2018-01-16 Thread Samuel Iglesias Gonsálvez
For patches 2, 5-9, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 12/01/18 23:56, Ian Romanick wrote: > From: Ian Romanick > > And delete the resulting dead code. > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_context.h | 1 - > src/mesa/drivers/dri/i965/genX_st

[Mesa-dev] Please include the already existing support for VAAPI H264 decoding to mainline

2018-01-16 Thread Uum8x0
For already long time there is the known existing and working implementation for decoding H264 on the X4500HD chipset. Please include it into mainline driver so that it gets finally usable for the "normal" people. Because exactly those are not able to compile their drivers by themself. Also the

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #1 from Gert Wollny --- It also locks up if the KILL instruction is not issued at all, so it's scheduling should not be the problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee f

[Mesa-dev] [Bug 104655] AMD R9 Fury + BenQ XL2546: Setting 240 Hz results in screen distortion

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104655 Bug ID: 104655 Summary: AMD R9 Fury + BenQ XL2546: Setting 240 Hz results in screen distortion Product: Mesa Version: unspecified Hardware: x86-64 (AMD64)

[Mesa-dev] Mesa 17.3.3 release candidate

2018-01-16 Thread Juan A. Suarez Romero
Hello list, The candidate for the Mesa 17.3.3 is now available. Currently we have: - 32 queued - 1 nominated (outstanding) - and 2 rejected patches The current queue consists of: The RADV driver gets several fixes around the resolve pass. It also gets fixes to solve a mpv hang, pipeline stat

Re: [Mesa-dev] [PATCH 1/7] gallium: Refactor out vl_put_screen and vl_get_screen

2018-01-16 Thread Leo Liu
On 01/16/2018 04:48 AM, Christian König wrote: Am 16.01.2018 um 10:40 schrieb Gurkirpal Singh: On Mon, Jan 15, 2018 at 9:24 PM, Leo Liu > wrote: Hi lists, If there is no more questions, and no objection, I would like to commit this new OMX st. to upstr

[Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

2018-01-16 Thread Topi Pohjolainen
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546 CC: xinghua@intel.com Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/brw_draw.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i

Re: [Mesa-dev] [PATCH v1] egl/android: Implement the eglSwapinterval for Android.

2018-01-16 Thread Emil Velikov
On 16 January 2018 at 07:43, Zhongmin Wu wrote: > Implement the eglSwapinterval for Android platform to > enable the async mode for some GFX benchmarks. > For the future, feel free to mention the benchmarks you've tried. > Signed-off-by: Zhongmin Wu > --- > src/egl/drivers/dri2/platform_android

Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

2018-01-16 Thread Vadim Shovkoplias
Tested-by: Vadym Shovkoplias 2018-01-16 15:31 GMT+02:00 Topi Pohjolainen : > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546 > CC: xinghua@intel.com > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_draw.c | 6 -- > 1 file changed, 4 insertions(+), 2

[Mesa-dev] [PATCH v3] spirv_extensions: add GL_ARB_spirv_extensions boilerplate

2018-01-16 Thread Alejandro Piñeiro
v2: * Mention extension gap at gl_API.xml (Emil Velikov) * Bail with INVALID_ENUM if extension not available on getStringi (Emil Velikov) * Use EXTRA_EXT macro when defining the extension at get.c/get_hash_params.py (Emil Velikov) * Rename source files (spirvextensions.[ch] -> spirv_ex

Re: [Mesa-dev] [PATCH 1/3] mesa: make Visual.samples to be of type unsigned int and propagate this

2018-01-16 Thread Emil Velikov
On 15 January 2018 at 16:10, Gert Wollny wrote: > According to the ARB_multisample Visual.samples is a non-negative Integer. > Consequently define it, and related functions and values as such and fail > in glx/choose_visual if a negative number is given. > > Signed-off-by: Gert Wollny > --- > The

Re: [Mesa-dev] [PATCH 3/3] mesa/program/prog_optimize.c: Silence two warnings

2018-01-16 Thread Emil Velikov
On 15 January 2018 at 16:10, Gert Wollny wrote: > Specifically, -Wsign-compare (explicite cast) and -Wunused-param (annotate) > > Signed-off-by: Gert Wollny > --- > src/mesa/program/prog_optimize.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/program/prog

Re: [Mesa-dev] [PATCH v1] egl/android: Implement the eglSwapinterval for Android.

2018-01-16 Thread Eric Engestrom
On Tuesday, 2018-01-16 07:56:53 +, Zhongmin Wu wrote: > Implement the eglSwapinterval for Android platform to > enable the async mode for some GFX benchmarks. > > Signed-off-by: Zhongmin Wu Like Tomasz, I thought this was a mistake, given the recall email. I have now looked at it, and it lo

[Mesa-dev] [PATCH 2/2] swr: suppress debug output from loader unless LIBGL_DEBUG is set.

2018-01-16 Thread Chuck Atkins
Signed-off-by: Chuck Atkins CC: Tim Rowley CC: Bruce Cherniak --- src/gallium/drivers/swr/swr_loader.cpp | 41 +- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/swr/swr_loader.cpp b/src/gallium/drivers/swr/swr_loader.cpp inde

[Mesa-dev] [PATCH 1/2] swr: allow a single architecture to be builtin

2018-01-16 Thread Chuck Atkins
When only a single SWR architecture is being used, this allows that architecture to be builtin rather than as a separate libswrARCH.so that gets loaded via dlopen. Since there are now several different code paths for each detected CPU architecture, the log output is also adjusted to convey where t

Re: [Mesa-dev] [PATCH] draw: fix vsplit code when the (post-bias) index value is -1

2018-01-16 Thread Brian Paul
On 01/15/2018 07:18 PM, srol...@vmware.com wrote: From: Roland Scheidegger vsplit_add_cache uses the post-bias index for hashing, but the vsplit_add_cache_uint/ushort/ubyte ones used the pre-bias index, therefore the code for handling the special case (because -1 matches the initialization valu

Re: [Mesa-dev] [PATCH v2 1/4] anv/query: implement multiview interactions

2018-01-16 Thread Jason Ekstrand
On Mon, Jan 8, 2018 at 4:57 AM, Iago Toral Quiroga wrote: > From the Vulkan spec with KHX extensions: > > "If queries are used while executing a render pass instance that has >multiview enabled, the query uses N consecutive query indices >in the query pool (starting at query) where N is

Re: [Mesa-dev] [PATCH v3 1/2] isl: don't crash when creating a huge image

2018-01-16 Thread Jason Ekstrand
I'm a bit unclear here. Was ISL crashing before or was it returning false and anv crashing? If it was anv crashing due to an assert(ok), then maybe it's best to just make anv fail gracefully with VK_ERROR_OUT_OF_DEVICE_MEMORY. Setting size to UINT64_MAX seems really ugly to me. On Mon, Jan 15,

Re: [Mesa-dev] [PATCHv2] glx: fix non-dri build

2018-01-16 Thread Emil Velikov
On 15 January 2018 at 14:38, Samuel Thibault wrote: > glXGetDriverConfig parameters do not provide a context to dynamically > check for the presence of the function, so the dispatcher directly calls > glXGetDriverConfig, but in non-dri builds dri_glx.c didn't provide > glXGetDriverConfig. > > This

Re: [Mesa-dev] [PATCH] draw: fix vsplit code when the (post-bias) index value is -1

2018-01-16 Thread Roland Scheidegger
Am 16.01.2018 um 16:49 schrieb Brian Paul: > On 01/15/2018 07:18 PM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> vsplit_add_cache uses the post-bias index for hashing, but the >> vsplit_add_cache_uint/ushort/ubyte ones used the pre-bias index, >> therefore >> the code for handling

[Mesa-dev] [PATCH] draw: remove VSPLIT_CREATE_IDX macro

2018-01-16 Thread sroland
From: Roland Scheidegger Just inline the little bit of code. --- src/gallium/auxiliary/draw/draw_pt_vsplit.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pt_vsplit.c b/src/gallium/auxiliary/draw/draw_pt_vsplit.c in

Re: [Mesa-dev] st/omx_bellagio: Update default intra matrix per MPEG2 spec

2018-01-16 Thread Emil Velikov
On 5 January 2018 at 09:38, Christian König wrote: > Am 05.01.2018 um 10:36 schrieb Das, Indrajit-kumar: >> >> From: Indrajit Das >> >> Signed-off-by: Indrajit Das > > > Reviewed-by: Christian König > > Still wondering how we messed up that initially. > Pretty sure we want this alongside the ot

Re: [Mesa-dev] [PATCH] i965: Don't try to disable render buffers for compute

2018-01-16 Thread Pohjolainen, Topi
On Tue, Jan 16, 2018 at 03:58:03PM +0200, Vadim Shovkoplias wrote: > Tested-by: Vadym Shovkoplias Thanks :) > > 2018-01-16 15:31 GMT+02:00 Topi Pohjolainen : > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104546 > > CC: xinghua@intel.com > > Signed-off-by: Topi Pohjolainen >

[Mesa-dev] [Bug 104558] Building Vulkan Radeon driver fails

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104558 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock with X11

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #4 from Emil Velikov --- Care to do a simple crucible test [1]? Devs might be more tempted if there's a simple reproducer ;-) [1] https://cgit.freedesktop.org/mesa/crucible/ -- You are receiving this mail because: You are the assi

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock with X11

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #5 from Henri Verbeet --- (In reply to Emil Velikov from comment #4) > Care to do a simple crucible test [1]? Devs might be more tempted if there's > a simple reproducer ;-) > I'd be tempted, but isn't crucible headless? This is a W

Re: [Mesa-dev] [PATCH] vbo: optimize some display list drawing (v2)

2018-01-16 Thread Ian Romanick
Reviewed-by: Ian Romanick On 01/15/2018 11:37 AM, Brian Paul wrote: > The vbo_save_vertex_list structure records one or more glBegin/End > primitives which all have the same vertex format. > > To draw these primitives, we setup the vertex array state, then > issue the drawing command. Before, t

Re: [Mesa-dev] [PATCH] draw: fix vsplit code when the (post-bias) index value is -1

2018-01-16 Thread Brian Paul
On 01/16/2018 09:46 AM, Roland Scheidegger wrote: Am 16.01.2018 um 16:49 schrieb Brian Paul: On 01/15/2018 07:18 PM, srol...@vmware.com wrote: From: Roland Scheidegger vsplit_add_cache uses the post-bias index for hashing, but the vsplit_add_cache_uint/ushort/ubyte ones used the pre-bias inde

Re: [Mesa-dev] [PATCH] draw: remove VSPLIT_CREATE_IDX macro

2018-01-16 Thread Brian Paul
Reviewed-by: Brian Paul On 01/16/2018 09:55 AM, srol...@vmware.com wrote: From: Roland Scheidegger Just inline the little bit of code. --- src/gallium/auxiliary/draw/draw_pt_vsplit.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH v1 6/7] android: Change gralloc_handle_t members to be fixed width

2018-01-16 Thread Robert Foss
In order to lessen future alignment issues, lets switch to fixed width integers where possible. This excludes the data_owner since it is a pid_t which in theory could be larger than 32 bits. Signed-off-by: Robert Foss --- android/gralloc_handle.h | 22 -- 1 file changed, 12

[Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

2018-01-16 Thread Robert Foss
This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm, since at least 4 implementations exist, and share a lot of contents. The idea is to keep the common stuff defined in one place, and libdrm is the common codebase to all of these platforms. Additionally, having this struct defined

[Mesa-dev] [PATCH v1 2/7] android: Add version variable to gralloc_handle_t

2018-01-16 Thread Robert Foss
The version variable will be used for versioning of this struct and the corresponding accessor functions. Signed-off-by: Robert Foss --- android/gralloc_handle.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h index

[Mesa-dev] [PATCH v1 1/7] android: Move gralloc handle struct to libdrm

2018-01-16 Thread Robert Foss
This struct is used in mesa and drm_hwcomposer. Versions of if have been implemented in several grallocs: drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. Other than the 1:1 move of the struct a new generic name has been chosen and variables have had comments added to them. Sign-off-by: Rober

[Mesa-dev] [PATCH v1 3/7] android: Mark gralloc_handle_t magic variable as const

2018-01-16 Thread Robert Foss
Mark magic member of gralloc_handle_t as const. Sign-off-by: Robert Foss Signed-off-by: Robert Foss --- android/gralloc_handle.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h index 647351eedaf7..e4ef8179f584 100644 --- a/

[Mesa-dev] [PATCH v1 4/7] android: Remove member name from gralloc_handle_t

2018-01-16 Thread Robert Foss
The name member of gralloc_handle_t is no longer needed and has been removed. The version field has also been bumped. Signed-off-by: Robert Foss --- android/gralloc_handle.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h

[Mesa-dev] [PATCH v1 5/7] android: Change gralloc_handle_t format from Android format to fourcc

2018-01-16 Thread Robert Foss
Change the gralloc_handle_t format to signify the fourcc pixel format code instead of the Android pixel format definition. This is desirable since the fourcc code is what is used within the DRM subsystem. Naturally translation will still have to happen somewhere. Also bump the gralloc_handle_t ve

[Mesa-dev] [PATCH v1 7/7] android: Add accessor functions for gralloc_handle_t variables

2018-01-16 Thread Robert Foss
Supply accessor functions for most of the common gralloc_handle_t variables. Signed-off-by: Robert Foss --- android/gralloc_handle.h | 57 1 file changed, 57 insertions(+) diff --git a/android/gralloc_handle.h b/android/gralloc_handle.h index bff

Re: [Mesa-dev] [PATCH 5/7] report.py: Add option to only display measurements that have changes

2018-01-16 Thread Ian Romanick
On 01/12/2018 12:23 PM, Dylan Baker wrote: > Quoting Ian Romanick (2018-01-12 12:06:59) >> From: Ian Romanick >> >> This is useful for preparing data to go in a Mesa commit message. >> >> Signed-off-by: Ian Romanick >> --- >> report.py | 53 +++-- >

Re: [Mesa-dev] [PATCH 2/7] egl: add support for EGL_ANDROID_blob_cache

2018-01-16 Thread Emil Velikov
Hi Tapani, On 15 January 2018 at 12:31, Tapani Pälli wrote: > +static void > +update_blob_cache_functions(struct dri2_egl_display *dri2_dpy, > +struct dri2_egl_context *dri2_ctx) > +{ > + if (!dri2_dpy || !dri2_ctx) > + return; AFAICT dri2_dpy can never be NULL

Re: [Mesa-dev] [PATCH 1/2] swr: allow a single architecture to be builtin

2018-01-16 Thread Eric Engestrom
On Tuesday, 2018-01-16 10:36:49 -0500, Chuck Atkins wrote: > When only a single SWR architecture is being used, this allows that > architecture to be builtin rather than as a separate libswrARCH.so that > gets loaded via dlopen. Since there are now several different code > paths for each detected

Re: [Mesa-dev] [PATCH 2/2] swr: suppress debug output from loader unless LIBGL_DEBUG is set.

2018-01-16 Thread Eric Engestrom
On Tuesday, 2018-01-16 10:36:50 -0500, Chuck Atkins wrote: > Signed-off-by: Chuck Atkins > CC: Tim Rowley > CC: Bruce Cherniak > --- > src/gallium/drivers/swr/swr_loader.cpp | 41 > +- > 1 file changed, 25 insertions(+), 16 deletions(-) > > diff --git a/src/gal

Re: [Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

2018-01-16 Thread Ian Romanick
On 01/13/2018 01:47 PM, Jason Ekstrand wrote: > On January 12, 2018 14:56:26 "Ian Romanick" wrote: > >> From: Ian Romanick >> >> With the exception of NVIDIA hardware, these are is the values that all >> hardware and Gallium want.  The remapping is currently implemented in at >> least 6 places. 

Re: [Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

2018-01-16 Thread Ian Romanick
On 01/15/2018 11:23 AM, Brian Paul wrote: > On 01/12/2018 03:56 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> With the exception of NVIDIA hardware, these are is the values that all >> hardware and Gallium want.  The remapping is currently implemented in at >> least 6 places.  This starts th

[Mesa-dev] [Bug 103538] vkDestroySwapchain causes deadlock with X11

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103538 --- Comment #6 from Emil Velikov --- Hmm it seems to be - thanks for the correction. Might be worth poking the devs if they're OK with the idea of having WSI tests. -- You are receiving this mail because: You are the assignee for the bug._

Re: [Mesa-dev] [PATCH] draw: fix vsplit code when the (post-bias) index value is -1

2018-01-16 Thread Jose Fonseca
On 16/01/18 02:18, srol...@vmware.com wrote: From: Roland Scheidegger vsplit_add_cache uses the post-bias index for hashing, but the vsplit_add_cache_uint/ushort/ubyte ones used the pre-bias index, therefore the code for handling the special case (because -1 matches the initialization value of

Re: [Mesa-dev] [PATCH] draw: remove VSPLIT_CREATE_IDX macro

2018-01-16 Thread Jose Fonseca
On 16/01/18 16:55, srol...@vmware.com wrote: From: Roland Scheidegger Just inline the little bit of code. --- src/gallium/auxiliary/draw/draw_pt_vsplit.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_pt_vsplit.c

Re: [Mesa-dev] [PATCH 1/2] st/va: release held locks in error paths

2018-01-16 Thread Emil Velikov
On 15 January 2018 at 22:03, Grazvydas Ignotas wrote: > Found with the help of following Coccinelle semantic patch: > // > @@ > expression E; > @@ > > \(pthread_mutex_lock\|mtx_lock\|simple_mtx_lock\)(E) > ... > ( > \(pthread_mutex_unlock\|mtx_unlock\|simple_mtx_unlock\)(E); > ... > ret

Re: [Mesa-dev] Allocator Nouveau driver, Mesa EXT_external_objects, and DRM metadata import interfaces

2018-01-16 Thread Miguel Angel Vico
Hi, Besides the DRM modifiers discussion in the other forks or this thread (I should've probably started separate threads), has anyone gotten the chance to look at least at the mesa changes and allocator changes I shared below? With respect to Mesa changes, I think it might be worth merging the E

Re: [Mesa-dev] [PATCH 1/2] swr: allow a single architecture to be builtin

2018-01-16 Thread Emil Velikov
On 16 January 2018 at 17:57, Eric Engestrom wrote: > On Tuesday, 2018-01-16 10:36:49 -0500, Chuck Atkins wrote: >> When only a single SWR architecture is being used, this allows that >> architecture to be builtin rather than as a separate libswrARCH.so that >> gets loaded via dlopen. Since there

Re: [Mesa-dev] [PATCH 01/10] mesa: Also track a remapped version of the color logic op

2018-01-16 Thread Brian Paul
On 01/16/2018 11:12 AM, Ian Romanick wrote: On 01/15/2018 11:23 AM, Brian Paul wrote: On 01/12/2018 03:56 PM, Ian Romanick wrote: From: Ian Romanick With the exception of NVIDIA hardware, these are is the values that all hardware and Gallium want.  The remapping is currently implemented in at

[Mesa-dev] Mesa 18.0.0 release plan

2018-01-16 Thread Emil Velikov
Hi all, As you've know the Mesa 18.0.0 release plan has been available for a while on the mesa3d.org website [1]. In case you've missed it here it is: Jan 19 2018 - Feature freeze/Release candidate 1 Jan 26 2018 - Release candidate 2 Feb 02 2018 - Release candidate 3 Feb 09 2018 - Release ca

Re: [Mesa-dev] [PATCH 2/2] swr: suppress debug output from loader unless LIBGL_DEBUG is set.

2018-01-16 Thread Chuck Atkins
> > +#define debug_printf(...) if(mesa_debug) { fprintf(stderr, > __VA_ARGS__); } > > `do {} while(0)` > Forgive me but I don't understand, what you're saying here. > Why only replace some of the printfs? > The fprintf's I replaced with debug_printf are informational status messages, while the

Re: [Mesa-dev] [PATCH 1/2] swr: allow a single architecture to be builtin

2018-01-16 Thread Chuck Atkins
> > Perhaps one can split out the .cpp and build changes somehow. > Good idea. It's easy enough to split and without the autoconf changes the existing behavior will still be preserved so the other two builds can still work as they normally do, they just won't have the builtin-swr feature. - Chuc

Re: [Mesa-dev] Mesa 18.0.0 release plan

2018-01-16 Thread Chuck Atkins
Hi Emil, I'd like to try to get the builtin swr arch feature baked in. There's also a bug related to missing propagation of static dependencies, but I can't commit to having that one ready in time (although I'm aiming to). - Chuck On Tue, Jan 16, 2018 at 2:18 PM, Emil Velikov wrote: > Hi all,

[Mesa-dev] [PATCH 1/3] swr: (autoconf) allow a single swr architecture to be builtin

2018-01-16 Thread Chuck Atkins
Part 1 of 2 (part 1 is autoconf changes, part 2 is C++ changes) When only a single SWR architecture is being used, this allows that architecture to be builtin rather than as a separate libswrARCH.so that gets loaded via dlopen. Since there are now several different code paths for each detected CP

[Mesa-dev] [PATCH 3/3] swr: suppress debug output from loader unless LIBGL_DEBUG is set.

2018-01-16 Thread Chuck Atkins
Signed-off-by: Chuck Atkins CC: Tim Rowley CC: Bruce Cherniak --- src/gallium/drivers/swr/swr_loader.cpp | 41 +- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/swr/swr_loader.cpp b/src/gallium/drivers/swr/swr_loader.cpp inde

[Mesa-dev] [PATCH 2/3] swr: allow a single swr architecture to be builtin

2018-01-16 Thread Chuck Atkins
Part 2 of 2 (part 1 is autoconf changes, part 2 is C++ changes) When only a single SWR architecture is being used, this allows that architecture to be builtin rather than as a separate libswrARCH.so that gets loaded via dlopen. Since there are now several different code paths for each detected CP

Re: [Mesa-dev] [PATCH 06/29] anv/image: Add a helper for determining when fast clears are supported

2018-01-16 Thread Nanley Chery
On Sat, Jan 13, 2018 at 11:11:35AM -0800, Jason Ekstrand wrote: > Sorry for all the list spam, but I'm sort of thinking out-loud and writing > it on the list for all to read. > > I'm thinking that what we want this list to return is not a bool but an enum > > /* The ordering of this enum is impor

Re: [Mesa-dev] [PATCH 1/2] swr: allow a single architecture to be builtin

2018-01-16 Thread Cherniak, Bruce
On Jan 16, 2018, at 1:40 PM, Chuck Atkins mailto:chuck.atk...@kitware.com>> wrote: Perhaps one can split out the .cpp and build changes somehow. Good idea. It's easy enough to split and without the autoconf changes the existing behavior will still be preserved so the other two builds can stil

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104662 Bug ID: 104662 Summary: OpenGL 4.5 needs to be active by default instead of using 3.0 by default Product: Mesa Version: 17.3 Hardware: x86-64 (AMD64) OS: L

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104662 --- Comment #1 from Adam Jackson --- 4.5 _is_ the default, for core contexts. If steam is requesting a compat context that's not really Mesa's fault. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Cont

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104662 --- Comment #2 from Stewart Little --- How do I then get steam to switch to the 4.5 OpenGL and get it as default on Arch Linux then? Any help would be appreciated I seriously don't know how to change the setting from 3.0 to 4.5 on Linux. -- Yo

Re: [Mesa-dev] Mesa 18.0.0 release plan

2018-01-16 Thread Kyriazis, George
Hello Emil, For the swr driver we are planning on getting some features in in the last couple of days, but one extra week will help us out. Specifically, we are thinking of checking in: - FE 16-wide shader support. This will entail calling lp_build_tgsi_soa() with width 16. Having some proble

Re: [Mesa-dev] [PATCHv2] intel/fs: Optimize and simplify the copy propagation dataflow logic.

2018-01-16 Thread Francisco Jerez
Francisco Jerez writes: > Previously the dataflow propagation algorithm would calculate the ACP > live-in and -out sets in a two-pass fixed-point algorithm. The first > pass would update the live-out sets of all basic blocks of the program > based on their live-in sets, while the second pass wou

Re: [Mesa-dev] [PATCH 1/3] swr: (autoconf) allow a single swr architecture to be builtin

2018-01-16 Thread Cherniak, Bruce
With a minor comment change (below) Reviewed-by: Bruce Cherniak > On Jan 16, 2018, at 1:59 PM, Chuck Atkins wrote: > > Part 1 of 2 (part 1 is autoconf changes, part 2 is C++ changes) > > When only a single SWR architecture is being used, this allows that > architecture to be builtin rather th

[Mesa-dev] [PATCH 4/5] st/glsl_to_tgsi: add st_get_program_binary_driver_sha1() helper

2018-01-16 Thread Timothy Arceri
This will be used by ARB_get_program_binary. Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_shader_cache.c | 6 ++ src/mesa/state_tracker/st_shader_cache.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/mesa/state_tracker/st_shader_cache.c b/src/mesa/state_tracker/st_sh

[Mesa-dev] [Resend] Gallium ARB_get_program_binary support (Dead Island fix)

2018-01-16 Thread Timothy Arceri
I've been contacted by people waiting for this to land so they can play Dead Island so it would be really great if someone could review this before the 18.0 freeze in two days. The feature is enable for any driver that currently enables a tgsi disk cache so it will be enabled for r600, radeonsi an

[Mesa-dev] [PATCH 1/5] st/glsl_to_tgsi: store num_tgsi_tokens in st_*_program

2018-01-16 Thread Timothy Arceri
We will need this for ARB_get_program_binary binary support. Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_program.c | 21 - src/mesa/state_tracker/st_program.h | 12 src/mesa/state_tracker/st_shader_cache.c | 15 +-- src/mesa/state

[Mesa-dev] [PATCH 5/5] st/glsl_to_tgsi: add ARB_get_program_binary support using TGSI

2018-01-16 Thread Timothy Arceri
This resolves a game bug in Deal Island. The game doesn't properly handle ARB_get_program_binary with 0 supported formats, and ends up crashing. This will enable ARB_get_program_binary binary support for any driver that currently enables the on-disk shader cache. Tested-by: Dieter Nützel Bugzill

[Mesa-dev] [PATCH 2/5] st/glsl_to_tgsi: stop passing pipe_shader_state to st_store_tgsi_in_disk_cache()

2018-01-16 Thread Timothy Arceri
We can instead just get this from st_*_program. V2: store tokens to to st_compute_program before attempting to write to cache (fixes crash). Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_program.c | 8 src/mesa/state_tracker/st_shader_cache.c | 22 ---

[Mesa-dev] [PATCH 3/5] st/glsl_to_tgsi: add (de)serialise program helpers

2018-01-16 Thread Timothy Arceri
These will be shared between the on-disk shader cache and ARB_get_program_binary. Tested-by: Dieter Nützel --- src/mesa/state_tracker/st_shader_cache.c | 265 --- src/mesa/state_tracker/st_shader_cache.h | 8 + 2 files changed, 146 insertions(+), 127 deletions(-) d

[Mesa-dev] [PATCH] meson: add llvm dependency for swr build

2018-01-16 Thread George Kyriazis
cc: Dylan Baker --- src/gallium/drivers/swr/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/meson.build b/src/gallium/drivers/swr/meson.build index c8c69b0..8dffb4c 100644 --- a/src/gallium/drivers/swr/meson.build +++ b/src/gallium/drivers/swr/meson.build

[Mesa-dev] [Bug 104665] r600: computer shaders break Bioshock on barts (bisected)

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104665 Bug ID: 104665 Summary: r600: computer shaders break Bioshock on barts (bisected) Product: Mesa Version: git Hardware: Other OS: All Status: NE

Re: [Mesa-dev] [PATCH 2/3] swr: allow a single swr architecture to be builtin

2018-01-16 Thread Cherniak, Bruce
> On Jan 16, 2018, at 1:59 PM, Chuck Atkins wrote: > > Part 2 of 2 (part 1 is autoconf changes, part 2 is C++ changes) > > When only a single SWR architecture is being used, this allows that > architecture to be builtin rather than as a separate libswrARCH.so that > gets loaded via dlopen. Sin

Re: [Mesa-dev] [PATCHv2] intel/fs: Optimize and simplify the copy propagation dataflow logic.

2018-01-16 Thread Ian Romanick
On 12/20/2017 11:27 AM, Francisco Jerez wrote: > Previously the dataflow propagation algorithm would calculate the ACP > live-in and -out sets in a two-pass fixed-point algorithm. The first > pass would update the live-out sets of all basic blocks of the program > based on their live-in sets, whil

Re: [Mesa-dev] [PATCHv2] intel/fs: Optimize and simplify the copy propagation dataflow logic.

2018-01-16 Thread Francisco Jerez
Ian Romanick writes: > On 12/20/2017 11:27 AM, Francisco Jerez wrote: >> Previously the dataflow propagation algorithm would calculate the ACP >> live-in and -out sets in a two-pass fixed-point algorithm. The first >> pass would update the live-out sets of all basic blocks of the program >> base

Re: [Mesa-dev] Mesa 18.0.0 release plan

2018-01-16 Thread Kenneth Graunke
On Tuesday, January 16, 2018 11:18:13 AM PST Emil Velikov wrote: > Hi all, > > As you've know the Mesa 18.0.0 release plan has been available for a while > on the mesa3d.org website [1]. > > In case you've missed it here it is: > > Jan 19 2018 - Feature freeze/Release candidate 1 > Jan 26 2018

Re: [Mesa-dev] [PATCH] st/dri: Default ALLOW_RGB10_CONFIGS to false on gallium as well.

2018-01-16 Thread Marek Olšák
Why? Marek On Tue, Jan 16, 2018 at 5:39 AM, Mario Kleiner wrote: > For consistency with the i965 default of "off". > > Signed-off-by: Mario Kleiner > --- > src/gallium/auxiliary/pipe-loader/driinfo_gallium.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/a

[Mesa-dev] [Bug 104662] OpenGL 4.5 needs to be active by default instead of using 3.0 by default

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104662 --- Comment #3 from Vedran Miletić --- (In reply to Stewart Little from comment #2) > How do I then get steam to switch to the 4.5 OpenGL and get it as default on > Arch Linux then? Any help would be appreciated I seriously don't know how to > c

Re: [Mesa-dev] [PATCH] st/mesa: enable ARB_enhanced_layouts on nir drivers

2018-01-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jan 12, 2018 at 6:52 AM, Timothy Arceri wrote: > I'm guessing this may have been disable because of missing > component packing support. However recent nir linking changes > required nir based gallium drivers to support component packing > so this should n

Re: [Mesa-dev] [PATCH] radeon: remove unneeded semicolons

2018-01-16 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Sun, Jan 14, 2018 at 10:59 PM, Grazvydas Ignotas wrote: > Trivial. Found by Coccinelle. > --- > src/gallium/drivers/radeon/radeon_vcn_dec.c | 6 +++--- > src/mesa/drivers/dri/radeon/radeon_debug.c | 2 +- > src/mesa/drivers/dri/radeon/radeon_state_init.c

Re: [Mesa-dev] [PATCH 1/3] i965/gen6-7/sol: Restructure primitive counter into a separate type.

2018-01-16 Thread Kenneth Graunke
On Friday, November 17, 2017 2:28:47 PM PST Francisco Jerez wrote: > A primitive counter encapsulates a scalar aggregating counter for each > vertex stream along with a section within the primitive tally buffer > which hasn't been read out yet. Defining this as a separate type will > allow us to k

Re: [Mesa-dev] [PATCH 1/3] i965: Call brw_cache_flush_for_render in predraw_resolve_framebuffer

2018-01-16 Thread Jason Ekstrand
This makes sure we flush things out of other caches prior to using a surface through the render cache. Currently, this is a no-op because GL won't let you bind anything other than a color surface as color so it should never end up in the depth cache. However, this does complete the flush/add_bo p

Re: [Mesa-dev] [PATCH v1 1/7] android: Move gralloc handle struct to libdrm

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new generic name > has been chosen a

Re: [Mesa-dev] [PATCH v1 1/7] android: Move gralloc handle struct to libdrm

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > This struct is used in mesa and drm_hwcomposer. > Versions of if have been implemented in several grallocs: > drm_gralloc, gbm_gralloc, minigbm and intel-minigbm. > > Other than the 1:1 move of the struct a new generic name > has been chosen a

Re: [Mesa-dev] [PATCH 4/6] i965/miptree: Refactor CCS_E and CCS_D cases in render_aux_usage

2018-01-16 Thread Kenneth Graunke
On Wednesday, January 10, 2018 11:22:38 AM PST Jason Ekstrand wrote: > This commit unifies the CCS_E and CCS_D cases. This should fix a couple > of subtle issues. One is that when you use INTEL_DEBUG=norbc to disable > CCS_E, we don't get the sRGB blending workaround. By unifying the code, > we

Re: [Mesa-dev] [PATCH 2/6] i965: Track format and aux usage in the render cache

2018-01-16 Thread Kenneth Graunke
On Wednesday, January 10, 2018 11:22:36 AM PST Jason Ekstrand wrote: > This lets us perform render cache flushes whenever a surface goes from > being used with one aux+format to a different aux+format. > > This is the "proper" fix for https://bugs.freedesktop.org/102435. > ee57b15ec764736e2d5360be

Re: [Mesa-dev] [PATCH v1 7/7] android: Add accessor functions for gralloc_handle_t variables

2018-01-16 Thread Rob Herring
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote: > Supply accessor functions for most of the common gralloc_handle_t > variables. > > Signed-off-by: Robert Foss > --- > android/gralloc_handle.h | 57 > > 1 file changed, 57 insertions(+) > > d

Re: [Mesa-dev] [PATCH 5/6] i965/draw: Do resolves properly for textures used by TXF

2018-01-16 Thread Kenneth Graunke
On Wednesday, January 10, 2018 11:22:39 AM PST Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_draw.c | 41 > > 1 file changed, 41 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_draw.c > b/src/mesa/drivers/dri/i965/brw_draw.c > inde

Re: [Mesa-dev] Mesa 18.0.0 release plan

2018-01-16 Thread Jordan Justen
On 2018-01-16 13:57:37, Kenneth Graunke wrote: > On Tuesday, January 16, 2018 11:18:13 AM PST Emil Velikov wrote: > > Hi all, > > > > As you've know the Mesa 18.0.0 release plan has been available for a while > > on the mesa3d.org website [1]. > > > > In case you've missed it here it is: > > > >

Re: [Mesa-dev] [PATCH 6/6] i965: Enable CCS_E sampling of sRGB textures as UNORM

2018-01-16 Thread Kenneth Graunke
On Wednesday, January 10, 2018 11:22:40 AM PST Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [Bug 104654] r600/sb: Alien Isolation GPU lock

2018-01-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104654 --- Comment #2 from Gert Wollny --- Actually, the GPU lockups also happen without sb, only not to the point that one has to kill the program. It is likely that #104665 is actually a duplicate of this. -- You are receiving this mail because: Yo

  1   2   >