On 16 January 2018 at 07:43, Zhongmin Wu <zhongmin...@intel.com> wrote:
> Implement the eglSwapinterval for Android platform to
> enable the async mode for some GFX benchmarks.
>
For the future, feel free to mention the benchmarks you've tried.
> Signed-off-by: Zhongmin Wu <zhongmin...@intel.com>
> ---
> src/egl/drivers/dri2/platform_android.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/src/egl/drivers/dri2/platform_android.c
> b/src/egl/drivers/dri2/platform_android.c
> index f6a24cd..09f1159 100644
> --- a/src/egl/drivers/dri2/platform_android.c
> +++ b/src/egl/drivers/dri2/platform_android.c
> @@ -476,6 +476,19 @@ droid_destroy_surface(_EGLDriver *drv, _EGLDisplay
> *disp, _EGLSurface *surf)
> return EGL_TRUE;
> }
>
> +static EGLBoolean
> +droid_swap_interval(_EGLDriver *drv, _EGLDisplay *dpy,
> + _EGLSurface *surf, EGLint interval)
> +{
> + struct dri2_egl_surface *dri2_surf = dri2_egl_surface(surf);
> + struct ANativeWindow *window = dri2_surf->window;
Nit: add blank line
> + if (window->setSwapInterval(window, interval)) {
> + return EGL_FALSE;
> + }
Nit: drop the braces
> + surf->SwapInterval = interval;
> + return EGL_TRUE;
> +}
> +
> static int
> update_buffers(struct dri2_egl_surface *dri2_surf)
> {
> @@ -1300,6 +1313,7 @@ static const struct dri2_egl_display_vtbl
> droid_display_vtbl = {
> .swap_buffers = droid_swap_buffers,
> .swap_buffers_with_damage = dri2_fallback_swap_buffers_with_damage, /*
> Android implements the function */
> .swap_buffers_region = dri2_fallback_swap_buffers_region,
> + .swap_interval = droid_swap_interval,
> #if ANDROID_API_LEVEL >= 23
> .set_damage_region = droid_set_damage_region,
> #else
> @@ -1443,6 +1457,8 @@ dri2_initialize_android(_EGLDriver *drv, _EGLDisplay
> *dpy)
>
> dri2_setup_screen(dpy);
>
> + dri2_setup_swap_interval(dpy, 1);
> +
Add a comment why is 1 the maximum swap interval supported on Android.
For reference we have a nice hunk in platform_wayland.c.
Considering there are no dEQP regressions + the above comment.
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
Thanks
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
