Re: [Mesa-dev] [PATCH] radv: Add support for ETC2 textures.

2018-01-04 Thread Bas Nieuwenhuizen
Interestingly enough radeonsi also exposes it as far as I can see since commit d214b95e9a113733865546f3388a38bdee69a95f Author: Marek Olšák Date: Sat Oct 15 14:28:01 2016 +0200 radeonsi/gfx9: enable ETC2 Reviewed-by: Nicolai Hähnle Thanks for the warning though. On Thu, Jan 4, 2018

Re: [Mesa-dev] [PATCH] radv: Use correct flush bits for flushing L2 during CB/DB flushes.

2018-01-04 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 01/04/2018 02:29 AM, Bas Nieuwenhuizen wrote: Copied from radeonsi. Putting in the correct metadata flush commands for eventually not flushing L2 on CB/DB switch. Does not remove the need for V_028A90_CACHE_FLUSH_AND_INV_TS_EVENT at the moment. --- src/amd/vu

Re: [Mesa-dev] [PATCH 1/2] ac: add ac_build_fmin/fmax helpers

2018-01-04 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 01/04/2018 01:55 AM, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 32 ++-- src/amd/common/ac_llvm_build.h | 5 - 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/src/amd/common/ac

Re: [Mesa-dev] [PATCH 2/2] radeonsi: use pknorm_i16/u16 and pk_i16/u16 LLVM intrinsics

2018-01-04 Thread Samuel Pitoiset
How about performance? Few weeks ago, I fixed a bug (5f81a43535e8512cef26ea3dcd1e3a489bd5a1bb) which affected F1 2017 and DOW3 on RADV, and it was also a nice performance boost, this is why I'm asking. On 01/04/2018 01:55 AM, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/ac_llv

Re: [Mesa-dev] [PATCH] radv: Add support for ETC2 textures.

2018-01-04 Thread Samuel Pitoiset
Well, if RadeonSI enables ETC2 I guess it's "safe". Reviewed-by: Samuel Pitoiset On 01/04/2018 01:38 AM, Bas Nieuwenhuizen wrote: Was surprised that is even supported by Vega. --- src/amd/vulkan/radv_device.c| 4 +++- src/amd/vulkan/radv_formats.c | 36 +++

[Mesa-dev] [Bug 104214] Dota crashes when switching from game to desktop

2018-01-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104214 --- Comment #20 from Cyril --- Sven, to enable debug symbol you have to add options=(debug !strip) in the PKGBUILB. And then you have: GAME_DEBUGGER=gdb steam to attach gdb to the game. I wasn't able to reproduce the crash with the alt

Re: [Mesa-dev] [PATCH] radv: Invildate L1 for VK_ACCESS_VERTEX_ATTRIBUTE_READ_BIT.

2018-01-04 Thread Samuel Pitoiset
typo: "Invalidate" Reviewed-by: Samuel Pitoiset On 01/04/2018 01:49 AM, Bas Nieuwenhuizen wrote: These are just shaders reads, so we need to invalidate L1. Fixes: 6dbb0eaccc "radv: handle subpass cache flushes" --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2018-01-04 Thread Samuel Pitoiset
On 12/28/2017 11:08 PM, Matt Arsenault wrote: On Dec 28, 2017, at 16:55, Samuel Pitoiset wrote: Similar to RadeonSI. This fixes: dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat Signed-of

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2018-01-04 Thread Bas Nieuwenhuizen
Looking at AMDGPUAsmPrinter::EmitProgramInfoSI in LLVM that is only set for compute shaders. So fix radv to default to the proposed value and fix LLVM to pass it through for all shaders? On Thu, Jan 4, 2018 at 11:54 AM, Samuel Pitoiset wrote: > > > On 12/28/2017 11:08 PM, Matt Arsenault wrote: >>

[Mesa-dev] [PATCH] anv: Add missing unlock in anv_scratch_pool_alloc

2018-01-04 Thread Alex Smith
Fixes hangs seen due to the lock not being released here. Signed-off-by: Alex Smith Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_allocator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.

Re: [Mesa-dev] [PATCH] anv: Add missing unlock in anv_scratch_pool_alloc

2018-01-04 Thread Lionel Landwerlin
Thanks Alex, Reviewed-by: Lionel Landwerlin On 04/01/18 11:33, Alex Smith wrote: Fixes hangs seen due to the lock not being released here. Signed-off-by: Alex Smith Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_allocator.c | 4 +++- 1 file changed, 3 insertions(+), 1 dele

Re: [Mesa-dev] [RFC PATCH 0/6] r600: speed up tesselation shaders

2018-01-04 Thread Gert Wollny
On 29.12.2017 08:18, Dave Airlie wrote: > > I think the top patch un my tree fixes the LDS reordering, nop still > doesn't work > though which is annoying. maybe you can spot the problem I've been > staring too long. Unfortunately my monitor decided to die while I was testing the code. When I have

[Mesa-dev] Mesa 17.3.2 release candidate

2018-01-04 Thread Emil Velikov
Hello list, The release candidate for Mesa 17.3.2 is now available. Currently we have: - 13 queued - 18 nominated (outstanding) - and 0 rejected patches In the current queue we have: Multiple fixes in the RADV Vulkan driver, workaround when using slibtool and a GLSL workaround for various ti

[Mesa-dev] [PATCH] anv: Make sure state on primary is correct after CmdExecuteCommands

2018-01-04 Thread Alex Smith
After executing a secondary command buffer, we need to update certain state on the primary command buffer to reflect changes by the secondary. Otherwise subsequent commands may not have the correct state set. This fixes various issues (rendering errors, GPU hangs) seen after executing secondary co

Re: [Mesa-dev] [PATCH] egl/android: Fix build break with dri2_initialize_android _EGLDisplay parameter

2018-01-04 Thread Eric Engestrom
On Wednesday, 2018-01-03 10:28:37 -0600, Rob Herring wrote: > Commit 2f421651aca9 ("egl: let each platform decided how to handle > LIBGL_ALWAYS_SOFTWARE") broke the build due to copy-n-paste of misnamed > function parameter.: > > src/egl/drivers/dri2/platform_android.c:1183:8: error: use of undecl

Re: [Mesa-dev] [PATCH] anv: Make sure state on primary is correct after CmdExecuteCommands

2018-01-04 Thread Jason Ekstrand
Ugh... I think as a rule, I think I'd rather set them to NULL and just re-emit on the primary if we have to. Also, there is probably other state we're not resetting and/or marking dirty. I'll give it a think. Thanks for catching this! --Jason On January 4, 2018 08:16:35 Alex Smith wrote:

Re: [Mesa-dev] [PATCH] anv: Add missing unlock in anv_scratch_pool_alloc

2018-01-04 Thread Jason Ekstrand
Wow, I have no idea how that hasn't been caught yet. Rb On January 4, 2018 05:33:53 Alex Smith wrote: Fixes hangs seen due to the lock not being released here. Signed-off-by: Alex Smith Cc: mesa-sta...@lists.freedesktop.org --- src/intel/vulkan/anv_allocator.c | 4 +++- 1 file changed, 3

[Mesa-dev] [PATCH v2 03/31] nvir: move common converter code in base class

2018-01-04 Thread Karol Herbst
v2: remove TGSI related bits Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/Makefile.sources | 2 + .../nouveau/codegen/nv50_ir_from_common.cpp| 107 + .../drivers/nouveau/codegen/nv50_ir_from_common.h | 58 +++ .../drivers/nouveau/codeg

[Mesa-dev] [PATCH v2 06/31] nvc0/debug: add env var to make nir default

2018-01-04 Thread Karol Herbst
v2: allow for non debug builds as well Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c index

[Mesa-dev] [PATCH v2 05/31] nvc0: add support for NIR

2018-01-04 Thread Karol Herbst
not all those nir options are actually required, it just made the work a little easier. TODO: there is a little memory leak, because the nir shader is duplicated twice. this has to be done though, we just need to clean it up properly v2: fix asserts parse compute shaders don't lower bitfi

[Mesa-dev] [PATCH v2 00/31] Nir support for Nouveau

2018-01-04 Thread Karol Herbst
significant changes to last series: * support for geometry, tessellation and compute shaders * support for more intrinsics and operations * lot of fixes for 64 bit types * NV50_PROG_USE_NIR=1 can be used to enable NIR for non debug builds There are some outstanding issues triggered by having 64 bi

[Mesa-dev] [PATCH v2 01/31] st/nir: treat tess shader input/outputs the same as geom shaders

2018-01-04 Thread Karol Herbst
this is enough to get tessellation working in Unigine heaven Signed-off-by: Karol Herbst --- src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_nir.cpp b/src/mesa/state_tracker/st_glsl_to_nir.cpp ind

[Mesa-dev] [PATCH v2 04/31] nvir: add lowering helper

2018-01-04 Thread Karol Herbst
this is mostly usefull for lazy IR converters not wanting to deal with 64 bit lowering and other illegal stuff Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/Makefile.sources | 2 + .../nouveau/codegen/nv50_ir_lowering_helper.cpp| 204 + .../nouveau/c

[Mesa-dev] [PATCH v2 02/31] nvir: print the shader type when dumping headers

2018-01-04 Thread Karol Herbst
this makes debugging the shader header a little easier Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_program.c b/src/gallium/drivers/nouveau/nvc0/nvc0_program.c index 46a1

[Mesa-dev] [PATCH v2 07/31] nvir/nir: run some passes to make the conversion easier

2018-01-04 Thread Karol Herbst
v2: add constant_folding Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 40 ++ 1 file changed, 40 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir

[Mesa-dev] [PATCH v2 09/31] nvir/nir: add nir type helper functions

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 116 + 1 file changed, 116 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index c0e733a67d..b0

[Mesa-dev] [PATCH v2 12/31] nvir/nir: parse NIR shader info

2018-01-04 Thread Karol Herbst
v2: parse a few more fields Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 55 ++ 1 file changed, 55 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_

[Mesa-dev] [PATCH v2 08/31] nvir/nir: track defs and provide easy access functions

2018-01-04 Thread Karol Herbst
v2: add helper function for indirects Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 125 + 1 file changed, 125 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv

[Mesa-dev] [PATCH v2 13/31] nvir/nir: implement CFG handling

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 255 - 1 file changed, 253 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp inde

[Mesa-dev] [PATCH v2 14/31] nvir/nir: implement nir_load_const_instr

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 20 1 file changed, 20 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 82645f5ef1..eee

[Mesa-dev] [PATCH v2 11/31] nvir/nir: run assignSlots

2018-01-04 Thread Karol Herbst
v2: add support for geometry shaders set idx add some missing mappings fix for 64bit inputs/outputs fix up some FP color output index messup parse centroid flag Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 531 + 1 f

[Mesa-dev] [PATCH v2 10/31] nvir/nir: use lowering helper

2018-01-04 Thread Karol Herbst
this helps with a bunch of piglit tests testing 64 bit types Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/c

[Mesa-dev] [PATCH v2 18/31] nvir/nir: implement nir_intrinsic_store_(per_vertex_)output

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 47 ++ 1 file changed, 47 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 9835b916bf..8a3

[Mesa-dev] [PATCH v2 20/31] nvir/nir: implement intrinsic_discard(_if)

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 6795baa704..d5b6

[Mesa-dev] [PATCH v2 16/31] nvir/nir: implement nir_alu_instr handling

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst v2: user bitfield_insert instead of bfi rework switch helper macros remove some lowering code (LoweringHelper is now used for this) Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 468 - 1 file changed,

[Mesa-dev] [PATCH v2 15/31] nvir/nir: add skeleton for nir_intrinsic_instr

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp| 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index eeefadbfd0..e84

[Mesa-dev] [PATCH v2 19/31] nvir/nir: implement nir_intrinsic_load_input

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 8a3b897e26..679

[Mesa-dev] [PATCH v2 17/31] nvir/nir: implement nir_intrinsic_load_uniform

2018-01-04 Thread Karol Herbst
v2: use new getIndirect helper fixes symbols for 64 bit types Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium

[Mesa-dev] [PATCH v2 21/31] nvir/nir: implement loading system values

2018-01-04 Thread Karol Herbst
v2: support more sys values fixed a bug where for multi component reads all values ended up in x Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 81 ++ 1 file changed, 81 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/

[Mesa-dev] [PATCH v2 22/31] nvir/nir: implement nir_ssa_undef_instr

2018-01-04 Thread Karol Herbst
v2: use mkOp Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index a1

[Mesa-dev] [PATCH v2 23/31] nvir/nir: implement nir_instr_type_tex

2018-01-04 Thread Karol Herbst
a lot of those fields are not valid for a lot of tex ops. Not quite sure if it's worth the effort to check for those or just keep it like that. It seems to kind of work. v2: reworked offset handling add tex support with indirect R/S arguments handle GLSL_SAMPLER_DIM_EXTERNAL drop refer

[Mesa-dev] [PATCH v2 24/31] nvir/nir: add getOperation for intrinsics

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 24 ++ 1 file changed, 24 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 9391f57f87..cb8

[Mesa-dev] [PATCH v2 26/31] nvir/nir: implement variable indexing

2018-01-04 Thread Karol Herbst
we store those arrays in local memory and reserve some space for each of the arrays. The arrays are stored in a packed format, because we know quite easily the context of each index. We don't do that in TGSI so far. This causes various issues to come up in the MemoryOpt pass, because ld/st with in

[Mesa-dev] [PATCH v2 25/31] nvir/nir: implement vote and ballot

2018-01-04 Thread Karol Herbst
v2: add vote_eq support use the new subop intrinsic helper add ballot Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 25 ++ 1 file changed, 25 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b

[Mesa-dev] [PATCH v2 27/31] nvir/nir: implement geometry shader nir_intrinsics

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 31 ++ 1 file changed, 31 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 1ac5436153..252

[Mesa-dev] [PATCH v2 28/31] nvir/nir: implement nir_intrinsic_load_ubo

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 252092a391..18b99

[Mesa-dev] [PATCH v2 30/31] nvir/nir: implement images

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 287 +++-- 1 file changed, 269 insertions(+), 18 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp ind

[Mesa-dev] [PATCH v2 31/31] nvir/nir: add memory barriers

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 9f865bad10..c0783bed

[Mesa-dev] [PATCH v2 29/31] nvir/nir: implement ssbo intrinsics

2018-01-04 Thread Karol Herbst
Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_from_nir.cpp | 97 ++ 1 file changed, 97 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_nir.cpp index 18b998d22c..9d3

[Mesa-dev] [PATCH] r600: Allow egd_tables.py to run with python3 too

2018-01-04 Thread Michal Srb
From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Chv=C3=A1tal?= Makes the egd_tables.py compatible with both python 2 and 3. --- src/gallium/drivers/r600/egd_tables.py | 52 +- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/src/gallium/drivers/r600/egd_tables.py

[Mesa-dev] [PATCH] amd/common: use ac_image_load when lod is zero

2018-01-04 Thread Samuel Pitoiset
This might decrease VGPR spilling, because we no longer have to use v4i32 for 2D fetches when level == 0. We now use v2i32 for those cases. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_

[Mesa-dev] [PATCH] radv: limit the scissor bug workaround to Vega 10 and Raven

2018-01-04 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 6dc80acef0..a6975097b9 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/am

Re: [Mesa-dev] [RFC libdrm 0/5] Move alloc_handle_t from gralloc impls.

2018-01-04 Thread Robert Foss
On Fri, 2017-12-22 at 21:09 +0900, Tomasz Figa wrote: > On Fri, Dec 22, 2017 at 10:09 AM, Gurchetan Singh > wrote: > > So the plan is for alloc_handle_t to not be sub-classed by the > > implementations, but have all necessary information that an > > implementation > > would need? > > > > If so, h

Re: [Mesa-dev] [PATCH] radv: Add support for ETC2 textures.

2018-01-04 Thread Marek Olšák
On Thu, Jan 4, 2018 at 4:43 AM, Mao, David wrote: > Hi Bas, > AMD does not support ETC2 officially on the GFX9. > It would be risky for Radv to export that feature for gfx9 family. > Anyway, t’s just a heads up, and it is up to you to make the final call. > FYI: AMDVLK and proprietary AMD vulkan d

Re: [Mesa-dev] [PATCH] radv: limit the scissor bug workaround to Vega 10 and Raven

2018-01-04 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jan 4, 2018 at 4:24 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/ra

Re: [Mesa-dev] [PATCH] egl/android: Fix build break with dri2_initialize_android _EGLDisplay parameter

2018-01-04 Thread Rob Herring
On Thu, Jan 4, 2018 at 8:16 AM, Eric Engestrom wrote: > On Wednesday, 2018-01-03 10:28:37 -0600, Rob Herring wrote: >> Commit 2f421651aca9 ("egl: let each platform decided how to handle >> LIBGL_ALWAYS_SOFTWARE") broke the build due to copy-n-paste of misnamed >> function parameter.: >> >> src/egl

[Mesa-dev] [PATCH 1/4] glsl/standalone: point which arguments are mandatory

2018-01-04 Thread Alejandro Piñeiro
Every now and then I execute the standalone compiler, get the non-version error, and need to remember what I'm doing wrong --- src/compiler/glsl/main.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/main.cpp b/src/compiler/glsl/main.cpp index 123e41f9dc

[Mesa-dev] [PATCH 2/4] glsl/standalone: set MaxUniformBufferBindings

2018-01-04 Thread Alejandro Piñeiro
Used to handle how many ubo you can define on the context. Minimimum defined as 36 on ARB_uniform_buffer_object spec, up to 84 on OpenGL 4.6 (12 per stage at each moment). --- src/compiler/glsl/standalone.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/compiler/glsl/standalone.cpp

[Mesa-dev] [PATCH 3/4] glsl/standalone: set MaxVertexStreams

2018-01-04 Thread Alejandro Piñeiro
ARB_transform_feedback3 sets a minimum of 1, ARB_gpu_shader5 a minimum of 4. It shouldn't matter too much, so choosing the later. --- src/compiler/glsl/standalone.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl/standalone.cpp b/src/compiler/glsl/standalone.cpp index 34

[Mesa-dev] [PATCH 4/4] glsl/standalone: set MaxTransformFeedbackBuffers

2018-01-04 Thread Alejandro Piñeiro
Using 4, as it is the default value on mesa. See mesa/main/config.h and the following commit that introduced the value: 15ac66e331abdab12e882d80a6b4f647bc905298 --- src/compiler/glsl/standalone.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/glsl/standalone.cpp b/src/compil

[Mesa-dev] [PATCH 0/4] Minor glsl/standalone fixes

2018-01-04 Thread Alejandro Piñeiro
Using a shader as simple as this: layout(location=1) out vec4 outVar; layout(binding=2) uniform U { vec4 a; }; void main() { outVar = a; } Start to complains because MaxUniformBufferBindings, MaxVertexStreams and MaxTransformFeedbackBuffers has values too small (0, -1, etc) Seem

[Mesa-dev] [PATCH] swr/rast: fix invalid sign masks in avx512 simdlib code

2018-01-04 Thread Tim Rowley
Should be 0x8000 instead of 0x800. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/swr/rasterizer/common/simdlib_128_avx512.inl | 2 +- src/gallium/drivers/swr/rasterizer/common/simdlib_256_avx512.inl | 2 +- src/gallium/drivers/swr/rasterizer/common/simdlib_512_avx512.inl |

Re: [Mesa-dev] [PATCH 1/1] Use getprogname from stdlib.h on all BSDs and APPLE

2018-01-04 Thread Eric Engestrom
On Thursday, 2017-12-21 04:05:59 +, co...@sdf.org wrote: > On Wed, Dec 20, 2017 at 09:54:09AM -0600, Rob Herring wrote: > > Android could be added here. Android has had getprogname since > > Lollipop and we don't support versions older than that. It could be a > > follow-on patch too. > > Atta

Re: [Mesa-dev] [PATCH v2 03/31] nvir: move common converter code in base class

2018-01-04 Thread Pierre Moreau
With the comments below addressed, this patch is Reviewed-by: Pierre Moreau On 2018-01-04 — 16:01, Karol Herbst wrote: > v2: remove TGSI related bits > > Signed-off-by: Karol Herbst > --- > src/gallium/drivers/nouveau/Makefile.sources | 2 + > .../nouveau/codegen/nv50_ir_from_common.c

Re: [Mesa-dev] [PATCH] amd/common: use ac_image_load when lod is zero

2018-01-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jan 4, 2018 at 4:24 PM, Samuel Pitoiset wrote: > This might decrease VGPR spilling, because we no longer > have to use v4i32 for 2D fetches when level == 0. We now > use v2i32 for those cases. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_

Re: [Mesa-dev] [PATCH v2 01/31] st/nir: treat tess shader input/outputs the same as geom shaders

2018-01-04 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jan 4, 2018 at 4:01 PM, Karol Herbst wrote: > this is enough to get tessellation working in Unigine heaven > > Signed-off-by: Karol Herbst > --- > src/mesa/state_tracker/st_glsl_to_nir.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > di

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

2018-01-04 Thread Marek Olšák
Is the renaming necessary? It looks like everything would be fine if we used the "fence" name for semaphores. Marek On Fri, Dec 22, 2017 at 1:41 AM, Andres Rodriguez wrote: > Rename fences -> semaphores in preparation for upgrading fence > functionality. > > This series renames the following sym

Re: [Mesa-dev] [PATCH] egl/android: Fix build break with dri2_initialize_android _EGLDisplay parameter

2018-01-04 Thread Eric Engestrom
On Thursday, 2018-01-04 10:17:49 -0600, Rob Herring wrote: > On Thu, Jan 4, 2018 at 8:16 AM, Eric Engestrom > wrote: > > On Wednesday, 2018-01-03 10:28:37 -0600, Rob Herring wrote: > >> Commit 2f421651aca9 ("egl: let each platform decided how to handle > >> LIBGL_ALWAYS_SOFTWARE") broke the build

Re: [Mesa-dev] [PATCH 02/22] gallium: rename pipe fences to semaphores

2018-01-04 Thread Andres Rodriguez
On 2018-01-04 12:33 PM, Marek Olšák wrote: Is the renaming necessary? It looks like everything would be fine if we used the "fence" name for semaphores. The rename was requested by nha. We could keep going with the fences name. Or we could do the whole rename afterwards. I'm fine with eith

[Mesa-dev] [PATCH 1/3] radv: Generate VK_ANDROID_native_buffer.

2018-01-04 Thread Bas Nieuwenhuizen
--- src/amd/vulkan/Makefile.am | 6 +- src/amd/vulkan/radv_entrypoints_gen.py | 4 +++- src/amd/vulkan/radv_extensions.py | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am index 6b352aebf9..e1a04e8c7f

[Mesa-dev] [PATCH 2/3] radv: Add create image flag to not use DCC/CMASK.

2018-01-04 Thread Bas Nieuwenhuizen
If we import an image, we might not have space in the buffer for CMASK, even though it is compatible. --- src/amd/vulkan/radv_image.c | 43 --- src/amd/vulkan/radv_private.h | 1 + 2 files changed, 25 insertions(+), 19 deletions(-) diff --git a/src/amd/v

[Mesa-dev] [PATCH 3/6] radv/winsys: make IBs read-only for the GPU

2018-01-04 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c index 4578a9b548..0ee56f9144 10064

[Mesa-dev] [PATCH 1/6] radv/winsys: rework radv_amdgpu_bo_va_op()

2018-01-04 Thread Samuel Pitoiset
Needed for the following commit. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 40 +++ 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c b/src/amd/vulkan/winsys/amdgpu/radv_a

[Mesa-dev] [PATCH 2/6] radv/winsys: add RADEON_FLAG_READ_ONLY

2018-01-04 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_radeon_winsys.h | 1 + src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_radeon_winsys.h b/src/amd/vulkan/radv_radeon_winsys.h index 45f58f063a

[Mesa-dev] [PATCH 6/6] radv: make shader BOs read-only for the GPU

2018-01-04 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 2 ++ src/amd/vulkan/radv_private.h | 1 + src/amd/vulkan/radv_shader.c | 5 - 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5f78af624b..528d35

[Mesa-dev] [PATCH 5/6] radv: make descriptor BOs read-only for the GPU

2018-01-04 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_descriptor_set.c | 6 -- src/amd/vulkan/radv_device.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index e815939a67..19a560a6

[Mesa-dev] [PATCH 3/3] radv: Implement VK_ANDROID_native_buffer.

2018-01-04 Thread Bas Nieuwenhuizen
Passes dEQP-VK.api.smoke.* dEQP-VK.wsi.android.* with android-cts-7.1_r12 . Unlike the initial anv implementation this does use syncobjs instead of waiting on the CPU. This is missing meson build coverage for now. One possible todo is that linux 4.15 now has a sycall that allows us to expor

Re: [Mesa-dev] [PATCH v2 00/31] Nir support for Nouveau

2018-01-04 Thread Jason Ekstrand
I'm fairly pleased that you were able to get this far with only 3k lines. How much is that compared to your TGSI consumer? On January 4, 2018 09:02:24 Karol Herbst wrote: significant changes to last series: * support for geometry, tessellation and compute shaders * support for more intrinsi

[Mesa-dev] [PATCH 4/6] radv: make the indirect GFX config BO read-only for the GPU

2018-01-04 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/si_cmd_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c index 7d75d69a9a..9f68d3530e 100644 --- a/src/amd/vulkan/si_cmd_buffer.c +++ b/src/amd/vulkan/si_

[Mesa-dev] [PATCH v2] mesa: Add GL4.6 aliases of functions from GL_ARB_indirect_parameters

2018-01-04 Thread Neil Roberts
--- This is just a rebase of the patch with a minor conflict resolution. src/mapi/glapi/gen/GL4x.xml | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/mapi/glapi/gen/GL4x.xml b/src/mapi/glapi/gen/GL4x.xml index 0a80941..4b2703c 100644 --- a/src/mapi/glapi/gen/GL4x.x

Re: [Mesa-dev] [PATCH v2 00/31] Nir support for Nouveau

2018-01-04 Thread Karol Herbst
On Thu, Jan 4, 2018 at 6:39 PM, Jason Ekstrand wrote: > I'm fairly pleased that you were able to get this far with only 3k lines. > How much is that compared to your TGSI consumer? > > around 4,3k, but keep in mind, that we really only want to convert things here and all the RA, optimizations and

Re: [Mesa-dev] [PATCH v2 00/31] Nir support for Nouveau

2018-01-04 Thread Jason Ekstrand
On January 4, 2018 11:50:12 Karol Herbst wrote: On Thu, Jan 4, 2018 at 6:39 PM, Jason Ekstrand wrote: I'm fairly pleased that you were able to get this far with only 3k lines. How much is that compared to your TGSI consumer? around 4,3k, but keep in mind, that we really only want to conve

Re: [Mesa-dev] [PATCH v3 08/20] radeonsi: add nir support for tcs outputs

2018-01-04 Thread Marek Olšák
On Wed, Jan 3, 2018 at 6:04 AM, Timothy Arceri wrote: > Reviewed-by: Nicolai Hähnle > --- > src/gallium/drivers/radeonsi/si_shader.c | 124 > +++ > 1 file changed, 124 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si_shader.c > b/src/gallium/drivers/ra

Re: [Mesa-dev] [PATCH v3 12/20] radeonsi/nir: gather tess properties

2018-01-04 Thread Marek Olšák
On Wed, Jan 3, 2018 at 6:04 AM, Timothy Arceri wrote: > Reviewed-by: Nicolai Hähnle > --- > src/gallium/drivers/radeonsi/si_shader_nir.c | 29 > > 1 file changed, 29 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si_shader_nir.c > b/src/gallium/drivers

Re: [Mesa-dev] [PATCH v2 00/31] Nir support for Nouveau

2018-01-04 Thread Ilia Mirkin
On Thu, Jan 4, 2018 at 10:01 AM, Karol Herbst wrote: > significant changes to last series: > * arb_gpu_shader5 interpolateat* (those nir ops don't map well to nvir) > no good plan on how to properly implement those What's the issue? They should map as well as the TGSI ones. (Since the TGSI ones

[Mesa-dev] [PATCH] anv: Take write mask into account in has_color_buffer_write_enabled

2018-01-04 Thread Alex Smith
If we have a color attachment, but its writes are masked, this would have still returned true. This is inconsistent with how HasWriteableRT in 3DSTATE_PS_BLEND is set, which does take the mask into account. This could lead to PixelShaderHasUAV not being set in 3DSTATE_PS_EXTRA if the fragment shad

[Mesa-dev] [PATCH v4 2/3] autotools: Include meson.build files in tarball

2018-01-04 Thread Dylan Baker
Signed-off-by: Dylan Baker --- Makefile.am | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 7b86214..66f70ca 100644 --- a/Makefile.am +++ b/Makefile.am @@ -135,7 +135,35 @@ if HAVE_VMWGFX klibdrminclude_HEADERS +=

[Mesa-dev] [PATCH v4 0/3] Meson build system

2018-01-04 Thread Dylan Baker
This is a third iteration of the meson build system for libdrm. This version is significantly cleaned up from the last version and uses a style more like the build system in mesa. It builds all of the drivers and tests, and the tests can be run via `ninja test`. It has support for being used as a

[Mesa-dev] [PATCH v4 3/3] README: Add note about meson

2018-01-04 Thread Dylan Baker
Signed-off-by: Dylan Baker --- README | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/README b/README index 26cab9d..58e55bc 100644 --- a/README +++ b/README @@ -15,9 +15,24 @@ with an older kernel. Compiling - -libdrm is a standard autot

[Mesa-dev] [PATCH v4 1/3] Add meson build system

2018-01-04 Thread Dylan Baker
This patch adds a complete meson build system, including tests and install. It has the necessary hooks to allow it be used as a subproject for other meson based builds such as mesa. v4: - fix freedreno kgls check Signed-off-by: Dylan Baker --- .editorconfig | 4 +- amdgpu/.edito

Re: [Mesa-dev] [PATCH v3 19/20] ac: add load_tess_level() to the abi

2018-01-04 Thread Marek Olšák
On Wed, Jan 3, 2018 at 6:04 AM, Timothy Arceri wrote: > Fixes the following piglit tests in radeonsi: > > vs-tcs-tes-tessinner-tessouter-inputs-quads.shader_test > vs-tcs-tes-tessinner-tessouter-inputs-tris.shader_test > vs-tes-tessinner-tessouter-inputs-quads.shader_test > vs-tes-tessinner-tessou

Re: [Mesa-dev] [PATCH v3 20/20] ac: rework ac_llvm_extract_elem()

2018-01-04 Thread Marek Olšák
This is a very good series. Patches 18 and 19 need some tiny changes. With my comments on patches 8 and 12 addressed: Patch 1-17, 20 are: Reviewed-by: Marek Olšák Marek On Wed, Jan 3, 2018 at 6:04 AM, Timothy Arceri wrote: > Simplifies the logic a little and asserts index is 0. > > Suggested

[Mesa-dev] [PATCH] radeonsi: make init_config indirect buffer read-only in GPUVM

2018-01-04 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pm4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pm4.c b/src/gallium/drivers/radeonsi/si_pm4.c index 96e4e1d..06b3fe8 100644 --- a/src/gallium/drivers/radeonsi/si_pm4.c +++ b/src/g

Re: [Mesa-dev] [PATCH v2 00/31] Nir support for Nouveau

2018-01-04 Thread Karol Herbst
On Thu, Jan 4, 2018 at 7:06 PM, Ilia Mirkin wrote: > On Thu, Jan 4, 2018 at 10:01 AM, Karol Herbst wrote: >> significant changes to last series: >> * arb_gpu_shader5 interpolateat* (those nir ops don't map well to nvir) >> no good plan on how to properly implement those > > What's the issue? Th

Re: [Mesa-dev] [PATCH] radv: enable denorms for 64-bit and 16-bit floats

2018-01-04 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Dec 28, 2017 at 10:55 PM, Samuel Pitoiset wrote: > Similar to RadeonSI. > > This fixes: > dEQP-VK.image.texel_view_compatible.graphic.basic.attachment_read.bc*r16g16b16a16_sfloat > dEQP-VK.image.extended_usage_bit.attachment_write.r16_sfloat > > Signed-off-

[Mesa-dev] [PATCH 2/6] swr/rast: shuffle header files for msvc pre-compiled header usage

2018-01-04 Thread Tim Rowley
--- src/gallium/drivers/swr/Makefile.sources | 1 + .../drivers/swr/rasterizer/jitter/JitManager.cpp | 36 +- .../drivers/swr/rasterizer/jitter/JitManager.h | 46 +-- .../drivers/swr/rasterizer/jitter/blend_jit.cpp| 3 +- .../drivers/swr/rasterizer/jitter/builder.

[Mesa-dev] [PATCH 0/6] swr: update rasterizer

2018-01-04 Thread Tim Rowley
Highlights include simd16 cleanup (renaming and removing old codepaths), fixing a potential crash with the fetch shader, and code cleanups. Tim Rowley (6): swr/rast: SIMD16 builder - cleanup naming (simd2 -> simd16) swr/rast: shuffle header files for msvc pre-compiled header usage swr/rast:

[Mesa-dev] [PATCH 6/6] swr/rast: switch win32 jit format to COFF

2018-01-04 Thread Tim Rowley
Allows for call-stack and exception handling for jitted functions. --- src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/JitManager.cpp b/src/gallium/drivers/swr/rasterizer/jit

[Mesa-dev] [PATCH 3/6] swr/rast: SIMD16 fetch shader jitter cleanup

2018-01-04 Thread Tim Rowley
Bake in USE_SIMD16_BUILDER code paths (for USE_SIMD16_SHADER defined), remove USE_SIMD16_BUILDER define, remove deprecated psuedo-SIMD16 code paths. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 1118 +++- 1 file changed, 383 insertions(+), 735 deletions(-) diff --git a

[Mesa-dev] [PATCH 4/6] swr/rast: autogenerate named structs instead of literal structs

2018-01-04 Thread Tim Rowley
Results in far smaller and useful IR output. --- .../swr/rasterizer/codegen/templates/gen_llvm.hpp | 23 ++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_llvm.hpp b/src/gallium/drivers/swr/rasterizer/co

  1   2   >