Re: [Mesa-dev] [PATCH 3/3] mesa: rework how we free gl_shader_program_data

2017-11-08 Thread Neil Roberts
This seems like a nice solution to me. I just have a small comment below. > -static struct gl_shader_program_data * > -create_shader_program_data() > +struct gl_shader_program_data * > +_mesa_create_shader_program_data() > { > struct gl_shader_program_data *data; > data = rzalloc(NULL, st

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-08 Thread Michel Dänzer
On 07/11/17 10:58 PM, Marek Olšák wrote: > On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle wrote: >> On 07.11.2017 18:35, Michel Dänzer wrote: >>> >>> On 07/11/17 06:28 PM, Marek Olšák wrote: Hi, This patch is too large for the mailing list: https://cgit.freedeskt

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-08 Thread Nicolai Hähnle
On 08.11.2017 09:53, Michel Dänzer wrote: On 07/11/17 10:58 PM, Marek Olšák wrote: On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle wrote: On 07.11.2017 18:35, Michel Dänzer wrote: On 07/11/17 06:28 PM, Marek Olšák wrote: Hi, This patch is too large for the mailing list: https://cgit.free

Re: [Mesa-dev] [PATCH] anv: fix bug when using component qualifier in FS outputs

2017-11-08 Thread Samuel Iglesias Gonsálvez
Gently reminder that this patch is still unreviewed :-) Sam On Thu, 2017-11-02 at 08:28 +0100, Samuel Iglesias Gonsálvez wrote: > We can write to the same output but in different components, like > in this example: > > layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; > layout(loca

[Mesa-dev] [PATCH] anv: don't crash when creating a huge image

2017-11-08 Thread Samuel Iglesias Gonsálvez
The HW has some limits but, according to the spec, we can create the image as it has not yet any memory backing it. When we allocate that memory, then we fail following what Vulkan spec, "10.2. Device Memory" says when talking about vkAllocateMemory(): "Some platforms may have a limit on the maxim

Re: [Mesa-dev] [PATCH] gallivm: fix compilation against LLVM r317488

2017-11-08 Thread Michel Dänzer
On 07/11/17 09:20 PM, Tobias Droste wrote: > Am Dienstag, 7. November 2017, 11:16:14 CET schrieb Samuel Pitoiset: >> On 11/07/2017 11:15 AM, Michel Dänzer wrote: >>> On 07/11/17 11:03 AM, Michel Dänzer wrote: On 07/11/17 09:25 AM, Samuel Pitoiset wrote: > The unsafe algebra codepath has be

Re: [Mesa-dev] [PATCH 4/4] util/tgsi: use ASSERT_BITFIELD_SIZE() to check opcode field size

2017-11-08 Thread Nicolai Hähnle
For the series: Reviewed-by: Nicolai Hähnle On 08.11.2017 01:07, Brian Paul wrote: I've noticed at least two places where we store the TGSI opcode in an unsigned:8 bitfield. We're at 249 opcodes now. If we hit 256 we'll need to grow those bitfields. Use the new ASSERT_BITFIELD_SIZE() macro

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-08 Thread Michel Dänzer
On 08/11/17 10:13 AM, Nicolai Hähnle wrote: > On 08.11.2017 09:53, Michel Dänzer wrote: >> On 07/11/17 10:58 PM, Marek Olšák wrote: >>> On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle >>> wrote: On 07.11.2017 18:35, Michel Dänzer wrote: > On 07/11/17 06:28 PM, Marek Olšák wrote: >> >>>

Re: [Mesa-dev] [PATCH] gallivm: fix compilation against LLVM r317488

2017-11-08 Thread Samuel Pitoiset
On 11/08/2017 10:52 AM, Michel Dänzer wrote: On 07/11/17 09:20 PM, Tobias Droste wrote: Am Dienstag, 7. November 2017, 11:16:14 CET schrieb Samuel Pitoiset: On 11/07/2017 11:15 AM, Michel Dänzer wrote: On 07/11/17 11:03 AM, Michel Dänzer wrote: On 07/11/17 09:25 AM, Samuel Pitoiset wrote:

[Mesa-dev] [PATCH 3/3] radv: prefetch VBO descriptors at the right place

2017-11-08 Thread Samuel Pitoiset
Just after the vertex shader. This seems to give a minor boost for, at least, Serious Sam Fusion 2017 and Dawn of War 3. I don't see any real impacts with The Talos Principle. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 16 src/amd/vulkan/radv_private.

[Mesa-dev] [PATCH 1/3] radv: rename radv_emit_shaders_prefetch() to radv_emit_prefetch()

2017-11-08 Thread Samuel Pitoiset
For consistency because this function will also prefetch VBO descriptors. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH 2/3] radv: add radv_emit_prefetch_TC_L2_async() helper

2017-11-08 Thread Samuel Pitoiset
Will be used for VBO descriptors prefetching. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 7323c53da6..b7f101eabb 10064

[Mesa-dev] [PATCH 1/2] radv: do not emit the framebuffer when restoring a pass

2017-11-08 Thread Samuel Pitoiset
Instead just dirty RADV_CMD_DIRTY_FRAMEBUFFER and it will be re-emitted if necessary before the next draw. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c ind

[Mesa-dev] [PATCH 2/2] radv: make radv_emit_framebuffer_state() static

2017-11-08 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- src/amd/vulkan/radv_private.h| 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 9142c0dba6..13c5882bc2 100644 --- a/src/am

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Eric Engestrom
On Tuesday, 2017-11-07 09:28:35 -0800, Dylan Baker wrote: > v2: - Add information about CC, CXX, CFLAGS, and CXXFLAGS (Nicolai) > - Add message at top that meson for mesa is still a work in progress > - Add trailing "/" to directories (Eric E.) > - Fix a number of spelling/grammar/style

[Mesa-dev] [PATCH] egl/wayland: Add a fallback when fourcc query isn't supported

2017-11-08 Thread Emil Velikov
From: Derek Foreman When queryImage doesn't support __DRI_IMAGE_ATTRIB_FOURCC wayland clients will die with a NULL derefence in wl_proxy_add_listener. Attempt to provide a simple fallback to keep ancient systems working. Fixes: 6595c699511 ("egl/wayland: Remove more surface specifics from creat

Re: [Mesa-dev] non-shared glapi

2017-11-08 Thread Eric Engestrom
Cc: mesa-maintainers, who might be interested in this discussion :) On Tuesday, 2017-11-07 16:33:57 -0800, Dylan Baker wrote: > Jason let me know today that non-shared glapi is broken in meson. The tests > for > non-shared glapi are broken in autotools and meson. Is anyone still using > non-share

[Mesa-dev] [Bug 103225] Deprecated wl_buffer still mentioned in EGL/eglmesaext.h

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103225 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH] egl/wayland: Add a fallback when fourcc query isn't supported

2017-11-08 Thread Eric Engestrom
On Wednesday, 2017-11-08 11:56:12 +, Emil Velikov wrote: > From: Derek Foreman > > When queryImage doesn't support __DRI_IMAGE_ATTRIB_FOURCC wayland clients > will die with a NULL derefence in wl_proxy_add_listener. > > Attempt to provide a simple fallback to keep ancient systems working. >

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Eric Engestrom
On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > Meson has up until this point set it's version in the root meson.build > script. While there are other build systems them creates "one more > thing" to duplicate between meson and every other build system, this > script is a simple "read

Re: [Mesa-dev] [Mesa-maintainers] non-shared glapi

2017-11-08 Thread Emil Velikov
On 8 November 2017 at 12:06, Eric Engestrom wrote: > On Tuesday, 2017-11-07 16:33:57 -0800, Dylan Baker wrote: >> Jason let me know today that non-shared glapi is broken in meson. The tests >> for >> non-shared glapi are broken in autotools and meson. Is anyone still using >> non-shared glapi, or

Re: [Mesa-dev] [PATCH] meson: Add threads dependencies to glsl_compiler executable

2017-11-08 Thread Eric Engestrom
On Tuesday, 2017-11-07 16:13:44 -0800, Dylan Baker wrote: > Quoting Dylan Baker (2017-10-27 11:22:09) > > Fixes compiling the optional standalone glsl compiler. > > > > Reported-by: DrNick (on irc) > > Signed-off-by: Dylan Baker Reviewed-and-Tested-by: Eric Engestrom > > --- > > > > This is n

Re: [Mesa-dev] [PATCH 12/13] mesa: rework the way we manage extra_extensions

2017-11-08 Thread Emil Velikov
On 7 November 2017 at 11:54, Emil Velikov wrote: > @@ -289,19 +268,26 @@ _mesa_one_time_init_extension_overrides(struct > gl_context *ctx) > recognized = false; > >if (!recognized && enable) { > - strcat(extra_extensions, ext); > - strcat(extra_extensions, " ");

[Mesa-dev] [PATCH 2/3] broadcom/vc5: Remove unused v3d_compiler.c

2017-11-08 Thread Andreas Boll
Unused since original import of VC5. Fixes: ade416d0236 ("broadcom: Add VC5 NIR compiler.") Cc: Eric Anholt Signed-off-by: Andreas Boll --- src/broadcom/compiler/v3d_compiler.c | 43 1 file changed, 43 deletions(-) delete mode 100644 src/broadcom/compiler/

[Mesa-dev] [PATCH 1/3] broadcom/vc5: Add vc5_drm.h to the release tarball

2017-11-08 Thread Andreas Boll
Fixes: 45bb8f29571 ("broadcom: Add V3D 3.3 gallium driver called "vc5", for BCM7268.") Cc: 17.3 Cc: Eric Anholt Signed-off-by: Andreas Boll --- src/gallium/drivers/vc5/Makefile.sources | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/vc5/Makefile.sources b/src/ga

[Mesa-dev] [PATCH 3/3] glsl: Fix typo fragement -> fragment

2017-11-08 Thread Andreas Boll
Fixes: 94d669b0d2f ("glsl: enforce fragment shader input restrictions in GLSL ES 3.10") Signed-off-by: Andreas Boll --- src/compiler/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH 1/3] broadcom/vc5: Add vc5_drm.h to the release tarball

2017-11-08 Thread Eric Engestrom
On Wednesday, 2017-11-08 15:15:06 +0100, Andreas Boll wrote: > Fixes: 45bb8f29571 ("broadcom: Add V3D 3.3 gallium driver called "vc5", >for BCM7268.") > > Cc: 17.3 > Cc: Eric Anholt > Signed-off-by: Andreas Boll Series is Reviewed-by: Eric Engestrom > --- > src/gallium/drivers/vc5/M

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 Jan Vesely changed: What|Removed |Added Blocks||99553 --- Comment #1 from Jan Vesely ---

[Mesa-dev] [PATCH] mesa/teximage: increase target support for CompressedTexImage3D

2017-11-08 Thread Juan A. Suarez Romero
From section 8.7, page 179 of OpenGL ES 3.2 spec: An INVALID_OPERATION error is generated by CompressedTexImage3D if internalformat is one of the the formats in table 8.17 and target is not TEXTURE_2D_ARRAY, TEXTURE_CUBE_MAP_ARRAY or TEXTURE_3D. So far it was only considering TEXTURE_2D_ARR

[Mesa-dev] [PATCH] mesa/teximage: add more targets for CompressedTexImage3D

2017-11-08 Thread Juan A. Suarez Romero
From section 8.7, page 179 of OpenGL ES 3.2 spec: An INVALID_OPERATION error is generated by CompressedTexImage3D if internalformat is one of the the formats in table 8.17 and target is not TEXTURE_2D_ARRAY, TEXTURE_CUBE_MAP_ARRAY or TEXTURE_3D. So far it was only considering TEXTURE_2D_ARR

Re: [Mesa-dev] [PATCH] mesa/teximage: increase target support for CompressedTexImage3D

2017-11-08 Thread Juan A. Suarez Romero
Please, ignore this patch (wrong subject; sent a new one with the right subject). J.A. On Wed, 2017-11-08 at 16:38 +0100, Juan A. Suarez Romero wrote: > From section 8.7, page 179 of OpenGL ES 3.2 spec: > > An INVALID_OPERATION error is generated by CompressedTexImage3D > if intern

Re: [Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

2017-11-08 Thread Emil Velikov
On 1 November 2017 at 18:22, Dylan Baker wrote: > Quoting Emil Velikov (2017-11-01 10:41:10) >> On 1 November 2017 at 17:24, Dylan Baker wrote: >> > Because meson mirrors the auototools logic, it needs the same changes to >> > allow building glvnd based egl. >> > >> > v2: - change if to elif (Eri

Re: [Mesa-dev] [PATCH] anv: fix bug when using component qualifier in FS outputs

2017-11-08 Thread Jason Ekstrand
On Thu, Nov 2, 2017 at 12:28 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > We can write to the same output but in different components, like > in this example: > > layout(location = 0, component = 0) out ivec2 dEQP_FragColor_0; > layout(location = 0, component = 2) out ivec2 dEQP_

Re: [Mesa-dev] [PATCH] anv: don't crash when creating a huge image

2017-11-08 Thread Jason Ekstrand
On Wed, Nov 8, 2017 at 1:34 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > The HW has some limits but, according to the spec, we can create > the image as it has not yet any memory backing it. When we allocate > that memory, then we fail following what Vulkan spec, "10.2. Device >

Re: [Mesa-dev] [PATCH 03/18] radeon/common: add vcn enc ip info query

2017-11-08 Thread Marek Olšák
On Tue, Nov 7, 2017 at 10:58 PM, wrote: > From: Boyuan Zhang > > Signed-off-by: Boyuan Zhang > --- > src/amd/common/ac_gpu_info.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c > index 2e56012..b0c0

[Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Julien Isorce
v2: add early return if (flag & MAP_INTERNAL_MASK) Already implemented for Gallium drivers. Useful for gbm_bo_(un)map. Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. Signed-off-by: Julien Isorce --- src/mesa/drivers/dri/i965/intel_screen.c | 51 ++

Re: [Mesa-dev] [PATCH] Adding support for EXT_sRGB for Opengl ES

2017-11-08 Thread Emil Velikov
Hi Harish, This seems to have fallen through the cracks, right? Keep in mind that I've not checked all the existing code paths - just skimming through the patch itself. s/Adding support for EXT_sRGB for Opengl ES/mesa: add support for GL_EXT_sRGB/ On 7 April 2017 at 05:20, Harish Krupo wrote: >

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #3 from Dave Gilbert --- Created attachment 135312 --> https://bugs.freedesktop.org/attachment.cgi?id=135312&action=edit foo.link-0.asm -- You are receiving this mail because: You are the QA Contact for the bug. You are the assig

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #2 from Dave Gilbert --- Created attachment 135311 --> https://bugs.freedesktop.org/attachment.cgi?id=135311&action=edit foo.ll from debug run -- You are receiving this mail because: You are the QA Contact for the bug. You are th

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #4 from Dave Gilbert --- Created attachment 135313 --> https://bugs.freedesktop.org/attachment.cgi?id=135313&action=edit foo.link-0.ll That's all 3 of the debug files it produced. (I wasn't sure which were the llvm and which the i

Re: [Mesa-dev] [PATCH 2/4] st/mesa: use enum types instead of int/unsigned (v3)

2017-11-08 Thread Erik Faye-Lund
On Wed, Nov 8, 2017 at 1:07 AM, Brian Paul wrote: > Use the proper enum types for various variables. Makes life in gdb > a little nicer. Note that the size of enum bitfields must be one > larger so the high bit is always zero (for MSVC). You *could* also do something like this on MSVC to get un

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Emil Velikov
Hi Julien, On 8 November 2017 at 16:55, Julien Isorce wrote: > v2: add early return if (flag & MAP_INTERNAL_MASK) > > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. > Ben did a slightly different imp

Re: [Mesa-dev] [PATCH] i965: implement (un)mapImage

2017-11-08 Thread Chris Wilson
Quoting Julien Isorce (2017-11-08 16:55:05) > v2: add early return if (flag & MAP_INTERNAL_MASK) > > Already implemented for Gallium drivers. > > Useful for gbm_bo_(un)map. > > Tested by porting wayland/weston/clients/simple-dmabuf-drm.c to GBM. > > Signed-off-by: Julien Isorce > --- > src/me

Re: [Mesa-dev] [PATCH 1/3] broadcom/vc5: Add vc5_drm.h to the release tarball

2017-11-08 Thread Eric Anholt
Andreas Boll writes: > Fixes: 45bb8f29571 ("broadcom: Add V3D 3.3 gallium driver called "vc5", >for BCM7268.") All are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.o

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 13/48] intel/fs: Use the original destination region for int MUL lowering

2017-11-08 Thread Mark Janes
This patch is CC'd to stable, but CTS regressions bisected to it: https://bugs.freedesktop.org/show_bug.cgi?id=103626 Please do not merge to stable until the bug is addressed. Jason Ekstrand writes: > Some hardware (CHV, BXT) have special restrictions on register regions > when doing integer

[Mesa-dev] [PATCH 03/18] radeon/common: add vcn enc ip info query

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang New ip info query is needed for vcn encode Signed-off-by: Boyuan Zhang --- src/amd/common/ac_gpu_info.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 2e56012..1962c96 100644 ---

[Mesa-dev] [PATCH 02/18] radeon/winsys: add vcn enc ring type

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang New ring type is needed for vcn encode Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_winsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_winsys.h b/src/gallium/drivers/radeon/radeon_winsys.h index 2d3f646..a14e6

[Mesa-dev] [PATCH 05/18] vl: add poc type

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Different from vce encoding, vcn encoding requires driver side to encode bitstream header, such as pps, sps and slice header. pic_order_cnt_type is a required variable when encoding both sps and slice header, therefore we need to add this new variable here, and hold the value p

[Mesa-dev] [PATCH 06/18] st/va: implement poc type

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang pic_order_cnt_type is a required variable when encoding both sps and slice header, therefore we need to get this value from st, e.g. vaapi interface, and then pass it to radeon driver for encoding headers. Signed-off-by: Boyuan Zhang --- src/gallium/state_trackers/va/picture

[Mesa-dev] [PATCH 04/18] winsys/amdgpu: add vcn enc cs support

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang New cs support is needed for vcn encode Signed-off-by: Boyuan Zhang --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c

[Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add a new header file for vcn encode interface Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.h | 325 1 file changed, 325 insertions(+) create mode 100644 src/gallium/drivers/radeon/radeon_vcn_enc.h diff --git a/src/

[Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add a skeleton pipe video interface and encode ib interface for video encode on vcn hardware. Add function defines and structures for vcn encode. Update Makefile.sources and meson.build with newly added files. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/Makefi

[Mesa-dev] [PATCH 09/18] radeon/vcn: add encode header algorithms

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Since bitstream headers, e.g. sps, pps, slice, are encoded in driver side, we need to add corresponding algorithms that required to generate those headers. According to h.264 specs, signed/unsigned interger Exp-Golomb-coded syntax element with left bit first (code_se and code_u

[Mesa-dev] [PATCH 13/18] radeon/vcn: add encode end frame

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add implementation for end_frame interface for vcn encode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/gallium/drivers/rad

[Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header implementations

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Implement encoding of sps, pps, and silce headers using the newly added h.264 header coding descriptors functions based on h.264 specs. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 234 1 file changed, 234 inserti

[Mesa-dev] [PATCH 14/18] radeon/vcn: add encode destroy

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add implementation for destroy interface for vcn encode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/galliu

[Mesa-dev] [PATCH 12/18] radeon/vcn: add encode bitstream

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add implementation for encode_bitstream interface for vcn encode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src

[Mesa-dev] [PATCH 16/18] radeon/vcn: add create encoder

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add implementation for create_encoder interface for vcn encode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn

[Mesa-dev] [PATCH 17/18] radeonsi: enable vcn encode

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Enable vcn encode by creating radeon_encoder for vcn. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeonsi/si_uvd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_uvd.c b/src/gallium/drivers/radeonsi/si_uvd.c i

[Mesa-dev] [PATCH 15/18] radeon/vcn: add encode get feedback

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add implementation for get_feedback interface for vcn encode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b/src/ga

[Mesa-dev] [PATCH 11/18] radeon/vcn: add encode begin frame

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Add implementation for begin_frame interface for vcn encode. Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc.c b

[Mesa-dev] [PATCH 18/18] radeon/video: enable encode support for raven

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Enable h.264 encode for vcn hardware (raven) Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_video.c b/src/gallium/drivers/radeon/radeon_video.c

[Mesa-dev] [PATCH 08/18] radeon/vcn: add ib implementations

2017-11-08 Thread boyuan.zhang
From: Boyuan Zhang Implement required ibs and command buffer submission interfaces for vcn encode Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 292 ++-- 1 file changed, 268 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers

Re: [Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-08 Thread Zhang, Boyuan
- Added simple descriptions for all patches. - Fixed all typos. - Agreed and changed all types in radeon_vcn_enc.h to uintX_t/intX_t Thanks, Boyuan -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: November-07-17 5:42 PM To: Zhang, Boyuan Cc: mesa-dev@lists.freed

Re: [Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part

2017-11-08 Thread Zhang, Boyuan
Thanks for pointing out, fixed in new patch sets. Regards, Boyuan -Original Message- From: Dylan Baker [mailto:dy...@pnwbakers.com] Sent: November-07-17 5:59 PM To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part Quo

Re: [Mesa-dev] [PATCH 03/18] radeon/common: add vcn enc ip info query

2017-11-08 Thread Zhang, Boyuan
Oops, thanks for pointing out. Fixed in new patch sets. Regards, Boyuan -Original Message- From: Marek Olšák [mailto:mar...@gmail.com] Sent: November-08-17 11:53 AM To: Zhang, Boyuan Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH 03/18] radeon/common: add vcn enc ip in

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 13/48] intel/fs: Use the original destination region for int MUL lowering

2017-11-08 Thread Jason Ekstrand
On Wed, Nov 8, 2017 at 9:46 AM, Mark Janes wrote: > This patch is CC'd to stable, but CTS regressions bisected to it: > > https://bugs.freedesktop.org/show_bug.cgi?id=103626 > > Please do not merge to stable until the bug is addressed. > Noted. I can take a look at that bug in a bit. It should

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-11-08 Thread Emil Velikov
On 27 October 2017 at 05:54, Harish Krupo wrote: > Hi Eric, > > Eric Engestrom writes: > >> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote: >>> This passes 33/37 deqp tests related to partial_update, 4 are not >>> supported. Tests not supported: >>> dEQP-EGL.functional.negative_partial_

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/3] broadcom/vc5: Add vc5_drm.h to the release tarball

2017-11-08 Thread Emil Velikov
On 8 November 2017 at 17:34, Eric Anholt wrote: > Andreas Boll writes: > >> Fixes: 45bb8f29571 ("broadcom: Add V3D 3.3 gallium driver called "vc5", >>for BCM7268.") > > All are: > > Reviewed-by: Eric Anholt > ... and pushed to master. Thanks gents! -Emil

[Mesa-dev] [PATCH] i965: Pretend there are 4 subslices for compute shader threads on Gen9+.

2017-11-08 Thread Kenneth Graunke
Similar to what we did for pixel shader threads - see gen_device_info.c. We don't want to bump the actual Maximum Number of Threads though, so we adjust it here. For pixel shaders, we don't use max_wm_threads, so we could just bump it globally. Fixes Piglit tests: arb_gpu_shader_int64/execution/

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 04:00:54) > On Tuesday, 2017-11-07 09:28:35 -0800, Dylan Baker wrote: > > v2: - Add information about CC, CXX, CFLAGS, and CXXFLAGS (Nicolai) > > - Add message at top that meson for mesa is still a work in progress > > - Add trailing "/" to directories (Er

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Ian Romanick
Is there a way to get a list of options before having any success? I want to disable using LLVM, but I can't get the list of options to do so because I don't have libelf (required for LLVM... which I don't want): Dependency libelf found: NO Meson encountered an error in file meson.build, line 62

Re: [Mesa-dev] [Mesa-maintainers] non-shared glapi

2017-11-08 Thread Dylan Baker
In meson the non shared path is so broken it doesn't build at all (I have patches to fix this, but clearly no one tested them). In both cases the tests for the non shared glapi haven't been updated as extensions have been removed from mesa and fail to compile (It's an APPLE extension). I'll admit

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 04:21:41) > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > Meson has up until this point set it's version in the root meson.build > > script. While there are other build systems them creates "one more > > thing" to duplicate between meson and ever

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Ian Romanick
On 11/08/2017 10:59 AM, Ian Romanick wrote: > Is there a way to get a list of options before having any success? I > want to disable using LLVM, but I can't get the list of options to do so > because I don't have libelf (required for LLVM... which I don't want): > > Dependency libelf found: NO >

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 04:21:41) > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > Meson has up until this point set it's version in the root meson.build > > script. While there are other build systems them creates "one more > > thing" to duplicate between meson and ever

Re: [Mesa-dev] [PATCH v2] meson: Allow building glvnd with EGL and non-dri based GLX

2017-11-08 Thread Dylan Baker
Quoting Emil Velikov (2017-11-08 08:03:42) > On 1 November 2017 at 18:22, Dylan Baker wrote: > > Quoting Emil Velikov (2017-11-01 10:41:10) > >> On 1 November 2017 at 17:24, Dylan Baker wrote: > >> > Because meson mirrors the auototools logic, it needs the same changes to > >> > allow building gl

Re: [Mesa-dev] [PATCH] docs: add documentation for building with meson

2017-11-08 Thread Dylan Baker
Quoting Ian Romanick (2017-11-08 11:05:24) > On 11/08/2017 10:59 AM, Ian Romanick wrote: > > Is there a way to get a list of options before having any success? I > > want to disable using LLVM, but I can't get the list of options to do so > > because I don't have libelf (required for LLVM... which

Re: [Mesa-dev] [PATCH 01/18] radeon/vcn: add vcn encode interface

2017-11-08 Thread Christian König
Am 08.11.2017 um 19:08 schrieb boyuan.zh...@amd.com: From: Boyuan Zhang Add a new header file for vcn encode interface Signed-off-by: Boyuan Zhang Only briefly skimmed over it, but what I saw looks mostly sane. Maybe nice to have is to have the code for encoding of the SPS/PPS and slice h

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Eric Engestrom
On 8 November 2017 19:32:22 GMT, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-08 04:21:41) > > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > > Meson has up until this point set it's version in the root > meson.build > > > script. While there are other build systems them

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #5 from Jan Vesely --- (In reply to Dave Gilbert from comment #4) > Created attachment 135313 [details] > foo.link-0.ll > > That's all 3 of the debug files it produced. > (I wasn't sure which were the llvm and which the isa dumps; I

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #6 from Dave Gilbert --- (In reply to Jan Vesely from comment #5) > (In reply to Dave Gilbert from comment #4) > > Created attachment 135313 [details] > > foo.link-0.ll > > > > That's all 3 of the debug files it produced. > > (I was

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #7 from Jan Vesely --- Created attachment 135318 --> https://bugs.freedesktop.org/attachment.cgi?id=135318&action=edit annotated asm dump -- You are receiving this mail because: You are the QA Contact for the bug. You are the ass

Re: [Mesa-dev] [PATCH 5/5] meson: build gallium-xlib based glx

2017-11-08 Thread Eric Anholt
Dylan Baker writes: > Signed-off-by: Dylan Baker > --- > meson.build | 16 +++--- > src/gallium/meson.build | 11 +++- > src/gallium/state_trackers/glx/xlib/meson.build | 27 ++ > src/gallium/targets/libgl-xlib/meson.build

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-08 Thread Chad Versace
On Tue 07 Nov 2017, Dylan Baker wrote: > Quoting Eric Engestrom (2017-11-07 07:25:53) > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote: > > > I tested this in a setup where the builddir was outside of the srcdir. > > > --- > > > src/intel/vulkan/meson.build | 12 > > >

Re: [Mesa-dev] [PATCH] Adding support for EXT_sRGB for Opengl ES

2017-11-08 Thread Harish Krupo
Hi Emil, Emil Velikov writes: > Hi Harish, > > This seems to have fallen through the cracks, right? Thanks for bringing this up again :) > Keep in mind that I've not checked all the existing code paths - just > skimming through the patch itself. > > s/Adding support for EXT_sRGB for Opengl ES/m

Re: [Mesa-dev] [RFC PATCH v1 00/30] anv: dma-buf and DRM format modifiers

2017-11-08 Thread Chad Versace
On Tue 07 Nov 2017, Jason Ekstrand wrote: > All of the pre-work patches have been reviewed by myself and Lionel.  I've > also > read through the rest of the series and things look pretty good to me.  I did > make some scattered comments but they shouldn't be a big deal. > > My primary concern wit

Re: [Mesa-dev] [PATCH] anv/meson: Generate dev_icd.json

2017-11-08 Thread Jason Ekstrand
On Wed, Nov 8, 2017 at 1:40 PM, Chad Versace wrote: > On Tue 07 Nov 2017, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-07 07:25:53) > > > On Wednesday, 2017-11-01 13:49:03 -0700, Chad Versace wrote: > > > > I tested this in a setup where the builddir was outside of the > srcdir. > > > >

Re: [Mesa-dev] [PATCH] meson: Add script to use VERSION file for getting version

2017-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2017-11-08 12:38:26) > > > On 8 November 2017 19:32:22 GMT, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-11-08 04:21:41) > > > On Wednesday, 2017-11-01 11:58:16 -0700, Dylan Baker wrote: > > > > Meson has up until this point set it's version in the root > > meson.b

Re: [Mesa-dev] [PATCH v3] egl/wayland: Support for KHR_partial_update

2017-11-08 Thread Harish Krupo
Hi Emil, Emil Velikov writes: > On 27 October 2017 at 05:54, Harish Krupo wrote: >> Hi Eric, >> >> Eric Engestrom writes: >> >>> On Monday, 2017-10-23 16:20:54 +0530, Harish Krupo wrote: This passes 33/37 deqp tests related to partial_update, 4 are not supported. Tests not supported:

[Mesa-dev] [PATCH 3/4] meson: Always link libgallium_dri.so against dep_thread.

2017-11-08 Thread Eric Anholt
Somehow on my cross build the -pthread is getting lost. All the other deps seem to work out fine. --- src/gallium/targets/dri/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index 0ce088e1aca6..c591b75d0379

[Mesa-dev] [PATCH 1/4] meson: Leave dep_llvm empty if !with_llvm

2017-11-08 Thread Eric Anholt
The gallium auxiliary build would link against llvm, for the gallivm code that it didn't build. This broke the build on my armhf cross, where libLLVM-3.9.so is not multiarch and thus points to x86-64 libs. --- meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/

[Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

2017-11-08 Thread Eric Anholt
--- meson.build | 5 +++-- src/gallium/drivers/vc4/meson.build | 13 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 0118c9a7c5ef..189c9be5b59c 100644 --- a/meson.build +++ b/meson.build @@ -485,8 +485,9 @@ endi

[Mesa-dev] [PATCH 0/4] meson: vc4 ARMHF cross-build support

2017-11-08 Thread Eric Anholt
Timothy Arceri noted that vc4 didn't seem to have the NEON stuff hooked up, so I worked on getting vc4 cross builds working for me finally. I haven't tested the result on HW quite yet. Eric Anholt (4): meson: Leave dep_llvm empty if !with_llvm meson: Drop stale comment about making valgrind c

[Mesa-dev] [PATCH 2/4] meson: Drop stale comment about making valgrind conditional.

2017-11-08 Thread Eric Anholt
It was fixed in 5c2ff5773a707519f6a773126f201c4e1e8a42d7. --- meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/meson.build b/meson.build index 117ed7c087f4..0118c9a7c5ef 100644 --- a/meson.build +++ b/meson.build @@ -691,7 +691,6 @@ if with_glvnd pre_args += '-DUSE_LIBGLVND=1' en

Re: [Mesa-dev] [PATCH 4/4] meson: Enable VC4's NEON assembly support.

2017-11-08 Thread Dylan Baker
Quoting Eric Anholt (2017-11-08 14:14:57) > --- > meson.build | 5 +++-- > src/gallium/drivers/vc4/meson.build | 13 + > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/meson.build b/meson.build > index 0118c9a7c5ef..189c9be5b59c 100644 > --

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #8 from Jan Vesely --- (In reply to Dave Gilbert from comment #6) > (In reply to Jan Vesely from comment #5) > > (In reply to Dave Gilbert from comment #4) > > > Created attachment 135313 [details] > > > foo.link-0.ll > > > > > > Th

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-08 Thread Eric Anholt
Nicolai Hähnle writes: > On 08.11.2017 09:53, Michel Dänzer wrote: >> On 07/11/17 10:58 PM, Marek Olšák wrote: >>> On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle wrote: On 07.11.2017 18:35, Michel Dänzer wrote: > > On 07/11/17 06:28 PM, Marek Olšák wrote: >> >> Hi, >> >>

Re: [Mesa-dev] [PATCH] amd/addrlib: update to latest version

2017-11-08 Thread Ilia Mirkin
On Wed, Nov 8, 2017 at 4:13 AM, Nicolai Hähnle wrote: > On 08.11.2017 09:53, Michel Dänzer wrote: >> >> On 07/11/17 10:58 PM, Marek Olšák wrote: >>> >>> On Tue, Nov 7, 2017 at 9:01 PM, Nicolai Hähnle >>> wrote: On 07.11.2017 18:35, Michel Dänzer wrote: > > > On 07/11/17 06:2

Re: [Mesa-dev] [PATCH 2/3] glx: Prepare the DRI backends for GLX_EXT_no_config_context

2017-11-08 Thread Eric Anholt
Adam Jackson writes: > This should be safe as these backends already support the EGL version of > this extension. DRI1 is not affected because it does not support > GLX_ARB_create_context anyway. DRI-Windows is not prepared to implement > this as there's no equivalent WGL extension, and wglCreate

  1   2   >